From nobody Wed Apr 1 12:38:02 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A32AC3B6379 for ; Tue, 31 Mar 2026 07:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940864; cv=none; b=FkjhfpolUrIWkrkQUnEEO+EHVTt/842QZjI4OZjnWnfbtBEFgHP9nUJoOebUmU4hHNhcwO9nnyElN7Po4ZcDJYVgxSvk0G3hP8Hz1g2Rn98W1I4uqrxpxbppGHGMAAv+2jkzNRVYI6ievkYF95zwXwpVzbe8DpUZSjFLRXcVqGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774940864; c=relaxed/simple; bh=pYRAcx6HtXcH5JpwE87Pvvp1RP/QkTDO/l3srWqiwbU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NdobVicdYzeHFkk93RDoUFJOs2/1fKgsJRUQEsoJxxezpPy3DvEI1hCQb6p/x6EOIJJ41AqyJl+I+N0rt8u2UPxHWsysDjh3X+yegGUS4Bm8S4o1GrI+d7AZMQn03k1LfJPv0UYT9A5QtwxAUl6oUfiLCThb9C/F7Rup/nY/hcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VPAwVWUd; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VPAwVWUd" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-43ccda008cdso1941806f8f.0 for ; Tue, 31 Mar 2026 00:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774940861; x=1775545661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=tsUJVn3ygh2X89/8L4QVHn+2OjoHvM8S7xE4MbPVods=; b=VPAwVWUdElZT3sT5nC0xnuvA9dogXUi9Zgg9jkyc7bbG64hM5GWSwyQGXv1FeyvD3V J5/acLJbv9tHWCMCZkgiLkjSbtNiCnZdLAS3hyMoDLkiX/F/7L3nuZmAprzJdNMfj+xu Oz2QpDncm7904DG6EIyNQurMXafW3QSF7sJk28xhX4i712fZsedYeZbkxtOLd4hQFQQ6 2JsXHtVs9UJlgB1bxbtGifIglHXS2WC8Nef5sLttFpmypeAgUT4pdxL6ExENZHVvjAUg Du3UpT3iZ+qa1GGXUuiZ9xq8nRi+gTHtDT8R/y7IziPKNxyMYbDtSkqkryYyI1EZieAA a8ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774940861; x=1775545661; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tsUJVn3ygh2X89/8L4QVHn+2OjoHvM8S7xE4MbPVods=; b=XMkaoNkoiRwZYqsp+i27SHfpUf+bsF/BvXyYabL6PUqVhiyLCeA10+zpQQVbfZM98K B3pnxpzfSPUPZ1Yn0T9/pizBYMIzMbqqSfBxlPvG2AR3FCU4BsXHxNBZjjFbuBvuLipn /Obk4Bn0VZF1GZPhKGzmbA3Q8HbAa8W+NFkyLf8oKRmYAlHUqT0fqA2mX1LSPbOuvyI1 kjjN2dSIot+EP+WMtil4zE/GqmdTgMeg9h2qgGfYuOLrS7ifjyWHFL+8DlvH3Zf83vr5 bpn1w5LXDSe+CZmKtjNbMhikKMg6KaF4zRahSiUaakAa1fV3Yz1uS7AuT0arkJFEhYCn SRCw== X-Forwarded-Encrypted: i=1; AJvYcCUrlqKMzdqi6K/laULxzgim/HHvc2D4n3KTvhGcNREMVp/0Y0cOJ4WbR7Q2BCdyharbeP6O1U8Eiz8BU0s=@vger.kernel.org X-Gm-Message-State: AOJu0YxbTT6PfgHKZC5zT5h7y6w50BHbcfbfOFqbMXuFd4CGZ5iYUF8R FX4eByHSTrLzwR6hxrLTyPspNt8G6DUpvZk7RlnoriWOwA3O6fNLtQV8 X-Gm-Gg: ATEYQzxMxKKfiO09stvBmsCOsRsf5dLg80Ssu1Q8u2yj+uUs4zWAFBl+bVXGITLyRei xHdMQwvwR2bwyj/nR48PwhqRkQWYMZeYecBGnE9HCd2WLvlG7qT/lugFgykjsfnPV23E6+3K5bY gj3WFWDz4ctW/HAcDNcyXjRJ0cDxNGOYQwzIKHxK8MZRWHHo5vn5Xf3RRJo5plODUajaSfEudTn yBIXKvVUxcnnaXqPHhdr69Pbqd2OdAF5350aNJtgZP4avGFIOh/V3u7MUmS3LnV9qs98OEfkG9c RLk4mqV7NtfOhH8x4PvPUpfSstUOaYc+UO+hn/RCZXYfzpkLgVwjkwgHFPUjCRGJ/hux/FJGFtE xBc/Qq/IDYjBhyei0pcS38zhPS6e6l8kn+94P+FKJwIf2NohuUiHv9LPGcQfWZJW3quc6gjpg2D TSOg9HI4GpFnhzkAYZYYkJBdKKFUCi6Q== X-Received: by 2002:adf:fccf:0:b0:43b:9f7e:c912 with SMTP id ffacd0b85a97d-43d0818f375mr3130844f8f.1.1774940860709; Tue, 31 Mar 2026 00:07:40 -0700 (PDT) Received: from nixos-office ([2001:8a0:e95c:5e00:f8c1:fa51:743d:7994]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e265fsm25801409f8f.1.2026.03.31.00.07.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:07:40 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: akpm@linux-foundation.org, vbabka@kernel.org, hannes@cmpxchg.org Cc: mhocko@suse.com, surenb@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, ljs@kernel.org, david@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] mm/thp: dead code cleanup in Kconfig Date: Tue, 31 Mar 2026 08:07:30 +0100 Message-ID: <20260331070730.33915-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is already an 'if TRANSPARENT_HUGEPAGE' condition wrapping several config options e.g. 'READ_ONLY_THP_FOR_FS', making the 'depends on' statement for each of these a duplicate dependency (dead code). I propose leaving the outer 'if TRANSPARENT_HUGEPAGE...endif' and removing the individual 'depends on TRANSPARENT_HUGEPAGE' statement from each option. This dead code was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha Reviewed-by: Lorenzo Stoakes (Oracle) --- mm/Kconfig | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index e8bf1e9e6ad9..29d2de0d5c06 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -810,7 +810,6 @@ if TRANSPARENT_HUGEPAGE =20 choice prompt "Transparent Hugepage Support sysfs defaults" - depends on TRANSPARENT_HUGEPAGE default TRANSPARENT_HUGEPAGE_ALWAYS help Selects the sysfs defaults for Transparent Hugepage Support. @@ -840,7 +839,6 @@ endchoice =20 choice prompt "Shmem hugepage allocation defaults" - depends on TRANSPARENT_HUGEPAGE default TRANSPARENT_HUGEPAGE_SHMEM_HUGE_NEVER help Selects the hugepage allocation policy defaults for @@ -886,7 +884,6 @@ endchoice =20 choice prompt "Tmpfs hugepage allocation defaults" - depends on TRANSPARENT_HUGEPAGE default TRANSPARENT_HUGEPAGE_TMPFS_HUGE_NEVER help Selects the hugepage allocation policy defaults for @@ -931,7 +928,7 @@ endchoice =20 config THP_SWAP def_bool y - depends on TRANSPARENT_HUGEPAGE && ARCH_WANTS_THP_SWAP && SWAP && 64BIT + depends on ARCH_WANTS_THP_SWAP && SWAP && 64BIT help Swap transparent huge pages in one piece, without splitting. XXX: For now, swap cluster backing transparent huge page @@ -941,7 +938,6 @@ config THP_SWAP =20 config READ_ONLY_THP_FOR_FS bool "Read-only THP for filesystems (EXPERIMENTAL)" - depends on TRANSPARENT_HUGEPAGE =20 help Allow khugepaged to put read-only file-backed pages in THP. --=20 2.51.2