From nobody Wed Apr 1 12:32:23 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3692C256C6C for ; Tue, 31 Mar 2026 05:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774933376; cv=none; b=QdL9l9PAvHEJsbJkvlnq8bsY4otNHUZNl7eqjnVHUc6MtK4gaOPKa+ByIG2lCnLRk/T8w+D32vKnRrWSl9uA5awDQVpCW7pR714UdOZ4aI7icTvex8nRGG+4iKfkvaOtGK7/XdclinQVesvryrR3siyAiPgD8Dsb2FTlGJYMKnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774933376; c=relaxed/simple; bh=wkt7rN7EVuQDmXB1NU3VmYvFgtwXC9dBC5KHdfYYs3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TOtC4un8N54NMwjHpY/RxblqNhVVqkzHcDssq2t1Yq9Ph56bq9YG2AMpyW722xmx/UcCljN2l3ClOUHLe40WFO1Qn9oIWu7iUnrAWmewAdTeREVCurxHTexBZnAoiHkGQ4DE+Om3zLXLjSAHleJGhwBVIvrzdcArPJTJ7XoQH4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XFAHY49r; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XFAHY49r" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so1911201a12.3 for ; Mon, 30 Mar 2026 22:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774933374; x=1775538174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zy4AmIm0yN4RililkSbv6Ow12X9TuxGtqsseDxGhsIo=; b=XFAHY49ri3nPo/5zuh5ofTxDYYh2RftAVAcYRapijYQUc4lneg+bx35qoCoG2aLUoL JycbCSPKAacVjVaQL2tBh3JsemPeRpldFQ3/7YvqHxQnVwAg520Xsf1gzwIMpUC3AC4n 0V8FG+E/9zDAlikTcvAFcHN7eCG0EaF1KJOtqb33Xe8SQptAXpp2kvr1VI2/PsP7X+wU gY7B1K9BRw6YjfmOcgHrnmRL2N4NRjTGNX8HzF69uBMSscVLI6zNAAFIOxLh/bItJxCv AKd2tEYdRgQiccRPAJCfWFPJmPZ1RA3R9u+aUAM7hgL09UGAtRJWq2VO3O3LCCPiVjml aS7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774933374; x=1775538174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zy4AmIm0yN4RililkSbv6Ow12X9TuxGtqsseDxGhsIo=; b=MiOQUAAiBSmAtHP2kcegtVP7xb4FZYCFwHjtilB/lQviMcRQ648La0Y47is74jn0OR QXxIPVMJJJUYVdTb1mrSRwx7oQvPVHYDElOskLBUW3SoyNFpWWQODIy7lyOD9uGn4Kk9 7IjcoxDtv+oFwjLWoPiEPL9X1BUIooRoBwgXBL2unCLLtWRYnUiTUO5tWVfo6mi5YgM5 gSADSIMnOaYtF9lgpQCkKfqMo7v8det3oW9PkSmYZXR0b3Gt7OAR2jTP2kKCM5RxGHNj dYSweoKK48Q0y8zaselkBkdOUUlssN1BXMw7xuz+c2D1xDDFVDad4j3EG2yqnor3o+bX 4yjg== X-Forwarded-Encrypted: i=1; AJvYcCUqbGVkD5HrtuSdMXLE9WmrBu0OuW0MwSmvelo0w30b7WLiVJ1b/GQgiQPiAPvJkVAXa7RBp36B/XaJxNk=@vger.kernel.org X-Gm-Message-State: AOJu0YwGnPd5/pe9qnTjVrM81d7yplgKFHD44+hrOG/aXXOD8z6jUxDm 58r/hV86zeayroQKvuCnFb1/sR9SENPLJwpx/ZaEGZpP24QV1uqvQ0tW X-Gm-Gg: ATEYQzwPGX9Cj7jHv0ApG61+ELlEt2PQAza/A4LlvFRTtCoxNwP/7ZhrxNvcRhjTMqV wODkK0knErp9jBqwqTlakj9zzX3Tl8QL0TXqyx2pnVPvIctffYU1TAk04fyGX1noiefhNN/saly oRZrPj7V19DLoIxS+TY4pBG/kte3efbEBW4Ey+WyFr5Rco9l38qntP1NQIfo1iGb5ITc7D7qTlH nI6n29rGHnn8L6uNcWDuNLvk97xzI2p+1FmWHFR4bvvnnBUHMcqnHGRQSUVMbWJFTYTjHp6C4RL QRG8peBp0T2IVhJEnyG2fRV1wkXT6XuWJaybOK/IpXmVgBjJvmCUiFxk0yWkObP+SDEx+UV9IpL zUWPHG9u515gTKwMDL6gWvRUKZwQrFfnEgRO+OIwzG08Y7R0VvAgof1A6aGbA9iwDaEm1W5KH99 KKn1RuaKbc1Y58RxH1Sg/qKMdtn8dTxz2buvGYfqZkNZQsHGM= X-Received: by 2002:a17:903:8c5:b0:2ae:61db:797b with SMTP id d9443c01a7336-2b0cda06d17mr162807615ad.0.1774933374551; Mon, 30 Mar 2026 22:02:54 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.237]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24b02a11esm87585575ad.65.2026.03.30.22.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 22:02:54 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Gao Xiang Cc: Gao Xiang , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] [PATCH v3] erofs: ensure all folios are managed in erofs_try_to_free_all_cached_folios() Date: Tue, 31 Mar 2026 13:02:49 +0800 Message-ID: <20260331050249.23662-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <1828ed19-e9d0-4908-926a-0e0a9c3d04af@linux.alibaba.com> References: <1828ed19-e9d0-4908-926a-0e0a9c3d04af@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable folio_trylock() in erofs_try_to_free_all_cached_folios() may successfully acquire the folio lock, but the subsequent check for erofs_folio_is_managed() can skip unlocking when the folio is not managed by EROFS. As Gao Xiang pointed out, this condition should not happen in practice because compressed_bvecs[] only holds valid cached folios at this point =E2=80=94 any non-managed folio would have already been detached by z_erofs_cache_release_folio() under folio lock. Fix this by adding DBG_BUGON() to catch unexpected folios and ensure folio_unlock() is always called. Suggested-by: Gao Xiang Signed-off-by: Zhan Xusheng Reviewed-by: Gao Xiang --- fs/erofs/zdata.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index fe8121df9ef2..b566996a0d1a 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -605,8 +605,7 @@ static int erofs_try_to_free_all_cached_folios(struct e= rofs_sb_info *sbi, if (!folio_trylock(folio)) return -EBUSY; =20 - if (!erofs_folio_is_managed(sbi, folio)) - continue; + DBG_BUGON(!erofs_folio_is_managed(sbi, folio)); pcl->compressed_bvecs[i].page =3D NULL; folio_detach_private(folio); folio_unlock(folio); --=20 2.43.0