From nobody Wed Apr 1 23:51:46 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9D7D13D53C for ; Tue, 31 Mar 2026 03:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774928798; cv=none; b=WzY4updkGkYPHsaFbb5l0mMlry2puDPElZ7SWIxY3e8tgWMOJuUZ1EU61yi++lB0ptSL2w2YoJAguhM5jDckpRBCcPO+dMaUI6+Ok6dxf6lXHFp0JJzZKd+RxYFScqDDopX0sIjpRF4QIUqO1cemrLt3zShLGO8NzQC6126TEp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774928798; c=relaxed/simple; bh=wkt7rN7EVuQDmXB1NU3VmYvFgtwXC9dBC5KHdfYYs3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GHA8b/5IIXPVglSt7kKn86Xx+4eZA7frTWpNn5Wef0VV2aIEuMNEofJvjmHnKO9Po0RiHq3XaXHBcBjPRKlEnf7j0CXBSWXVS8HXtZkxYfMnMrBru+kirki3/feRCYrX6Id9xPeR5AgqTjdmfv7yYquQ5RUlFRxMTdIzjP58lCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U7mQaDFF; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U7mQaDFF" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82ce09b4197so130b3a.2 for ; Mon, 30 Mar 2026 20:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774928797; x=1775533597; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zy4AmIm0yN4RililkSbv6Ow12X9TuxGtqsseDxGhsIo=; b=U7mQaDFFxhfnsAPI7npNxc3F+uBkA4XHFODWWx9hXeQBtRnV9fY1CZ/YY9u5h84X7z 39Z7TDbLNK6xHF2cAB/Di2DY9SxUoqlZZE3yf8jzcQ/rHgTVbQiNl1dvCc6lFPJrBv7S ddPx9DmogCpOfImHczTFsVezvsWMgAAyN6cAdqX6MO0IT0w+6bVECq4ZMIxQThZ8Xaii FYHDeozoVdv0sT89ypUK+xAwlWqm0aWVUKsXnkSsaoxXm3/PoyzF2j8OyOFiv53EJOgu Av3f/O0WWeIjNu9mi7w9rVB8Lvm2F1yQKXJ/ZZqvMU7QDVq/2Uj5rHO5XJYRyVd0LhMb CWug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774928797; x=1775533597; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zy4AmIm0yN4RililkSbv6Ow12X9TuxGtqsseDxGhsIo=; b=WrRwvcKbchxaBNESkVVF463hfgv39ukJ0yD/R9rR/AugNOQuUt850L69pw/VbARqxW arwBdlQbP53/fnxuGiJmU9vsy04ntp+SsvFFy19SA0hmhINSA9bqmC2yTUKWHIMlAiJ2 AuOFUKg4q8ChFYoaBoQ5hrKHK3XNIs/GnlB0UK0px7ajDqe8fUV6KboPKkADZsCNuOpf EMYkCtjz1qRK+GCVY2PFw1n+fVKSzKKNTgzjIUL/WkPgzu2BK9HB5B6cJS5LNRhcNMlu mJHkO+l4FYAwY4tOB8opvmmdFQpttCYGgWcuURjgvqwgCAWxNqSa11lVpLQhGUbUWpdB 8aCA== X-Forwarded-Encrypted: i=1; AJvYcCWP3D8Xn+gKMg56epxaX7oBrLcmFdS7bpuVCWMMXcqC3Q/aQtr6LB6P1gKaOvturYaSfuNAzVaGoDmImcc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6Gu5SsABz6rR6+Z9IOYs3br9LAcFkmhtPc1W1rtdWr5XeIsim DfAkdlYVLRPDmB1MpedDk/78OycpT8m+ks4iWnh4eM5pXGF5aNENWJbB X-Gm-Gg: ATEYQzwT4B9A2rl/fdNXNdzFBvFLPDJArxcTZcG7Z2P8y8yhjefkADn41TPT4iL5cgP UB56GAYg0vHuG7zF6yvdjT38EbymP8e94sMEZhRVhAEvgIL4FyeKFVRpNnUCnmzkWd0ap49UxY1 4AkNmwXj7sFoyuLtVA3HvKDqbPa30G9MBSCKXbjo5mF0CAkOLAA2XJReUvNGtnngiGu2A6ki35R FuVv1C9xUkvb1qKMpWK5m30bSX8xWgAph3N0bjAQO3vyZnYh033I9yuGZafjBioPGjxT3CqTn9W VYdWyzpQwOmJ4hpWqEKZ2kcZcKtySpFIQwW6f37d2XQmkMKwBRKYBGRTHF+7CZ6rXBfh2J7m1HI E0jeYheS5cZJeuLoXb+4UG9y/beImZrXCtu2ccZui61Itx+mriCxXLpjfTrbo3QX1g89TpAmK40 Fyyd5ddgjSmxWjJ1PQNhcaAxN42hsEVmmrnNMMKX2ug/zEFvk= X-Received: by 2002:a05:6a00:1ac8:b0:82a:5ef0:210b with SMTP id d2e1a72fcca58-82c95e8804cmr14266081b3a.15.1774928797010; Mon, 30 Mar 2026 20:46:37 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82caf5408efsm7894067b3a.2.2026.03.30.20.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 20:46:36 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Gao Xiang Cc: Gao Xiang , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] [PATCH v2] erofs: fix missing folio_unlock causing lock imbalance Date: Tue, 31 Mar 2026 11:46:31 +0800 Message-ID: <20260331034631.21945-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260331033300.21366-1-zhanxusheng@xiaomi.com> References: <20260331033300.21366-1-zhanxusheng@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable folio_trylock() in erofs_try_to_free_all_cached_folios() may successfully acquire the folio lock, but the subsequent check for erofs_folio_is_managed() can skip unlocking when the folio is not managed by EROFS. As Gao Xiang pointed out, this condition should not happen in practice because compressed_bvecs[] only holds valid cached folios at this point =E2=80=94 any non-managed folio would have already been detached by z_erofs_cache_release_folio() under folio lock. Fix this by adding DBG_BUGON() to catch unexpected folios and ensure folio_unlock() is always called. Suggested-by: Gao Xiang Signed-off-by: Zhan Xusheng --- fs/erofs/zdata.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index fe8121df9ef2..b566996a0d1a 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -605,8 +605,7 @@ static int erofs_try_to_free_all_cached_folios(struct e= rofs_sb_info *sbi, if (!folio_trylock(folio)) return -EBUSY; =20 - if (!erofs_folio_is_managed(sbi, folio)) - continue; + DBG_BUGON(!erofs_folio_is_managed(sbi, folio)); pcl->compressed_bvecs[i].page =3D NULL; folio_detach_private(folio); folio_unlock(folio); --=20 2.43.0