From nobody Thu Apr 2 01:10:07 2026 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8C71B3925 for ; Tue, 31 Mar 2026 03:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774926417; cv=none; b=VC5heJrWoJ0btFiRQDXtRcb4g4zDc0+LgGQh5kRtc20uQNTfFs1st9Wy1hqUUwJ1Uo2AXC6sPh1/W9Io1eB+AU579wawwi8py/joSQwx0COIBR6AqISY7fRnC2DvAMpFY6vidEPm6esfHT+qFRh9YkjPESYvx7doMp/hzMD7Cno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774926417; c=relaxed/simple; bh=LmYgkNDAMUfsXbC7Mc2xNQre+zPbNFKzsgwyV+gaOqs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=T0rwUWdMzGHXyd0yqxS+PgIojoo+51nVclVhdfK3hD3Pf3md9mtsc88hPg/0gWUf4znnf7K6n/xPe9h2iFI0TBEmtHXDy1e6eezRWv5znA2W42QmT2z5y+iuNVWGfgfo9RbmBOCAT6f9HM65Q7nGO7wDqqn1XpGdezaH0KM5jRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E3gXhNig; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E3gXhNig" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-128e4d0cc48so6248158c88.1 for ; Mon, 30 Mar 2026 20:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774926415; x=1775531215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Lt98my5dSHED1eT6na4Ue/Vw7/7t0HExMYX7rz50JRc=; b=E3gXhNigckJmY9BFxxusrjf+ry1c2XyYaQs9jIxhO97FnLlLD8NRAQGLyOWvkuckl/ KPSXRDhU605fmbjz1V4pcUu9a/vB7BOBCY3nsovgQGXCu8Enk9hADuz7ZtoSePW9bQPR aNIjKNErjXL72TVvmf5v7N8bbrJbHVXjkB1VeG4JqIf9csAM6WGZ0wsqdQpEMVmfhit6 NY/h6Sc882aymbuhgOhX4BlzgDvY8SjFeK6IvLRThROAMMDAOGNvUOSAsOsDzm1XmE0R FuEzlDpNQxlGUbkhZLVbdJCFnbIwD7d68uauFJ/FZQTVT8AkpC7zfVbUH4AqFo3r08+s XZ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774926415; x=1775531215; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lt98my5dSHED1eT6na4Ue/Vw7/7t0HExMYX7rz50JRc=; b=Udl0TrmwZE9Dv7vD9I6oXivgabeb+HnvVfo5hSLi++iHK9T4gpWzs5v+Sp84HIDYHA fzkFOLk0fA1qa5xcd765uJ/cfTZPiHMkEiJ0mo6tDWtT3XW/9Dj8K5Wf0+Y+Wj5zEz5I YKrMB681aw2JOj8NI4YDgPah/b41C2CLjtggiygEWy1d00aLigbga+RPGfCYkKschbeL b29XYCcEhAiHYJSFYdlAh9M3ddYfSgzpJUkg4RU/brp05cbBjYLF/3k07qAunM5kw1ZE RNpqEr/ekoDSBXfABm5qZPRgpFvMhhM/Vx3dUwpYvFmd59lztf+hTdVpCSwF5Q+LC1zP w7qg== X-Forwarded-Encrypted: i=1; AJvYcCX79APO0pcHi45uvqXfAzxsCvVSw3H05HbB2Li92nu4reg76GIe7jtTB4ig8qm1YZEu4jxAukxrxj45JZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YwmEoVbskQft5/+y7oZ3WgaDAqkoDsb79HOyX2B+2PA2fzuGJzB ysITCKp96XBu5QCX7dOn818PMZ7w2zWQnSVU5oBDJQ6VXoONuSI66E8J X-Gm-Gg: ATEYQzzq+70PsZJgSM1lUV2mCga07qeek13DIlPODgh1fgMyxiA4+VkDXMgGDFChjke FZP3DGTGADDiZUpBb9iPq+c9qBPcXXzskWWM9KvCGZvLf5zecYR7Io4Zc4P4U3LEB+jaQaednL+ kYL9z64mCFJt/JjrCWz8sL4LHqD6Jfz5RDdgdhia9xa0MtGn3iLY3cRN4Aw2WzBsKWqO/K5A9Z2 y7q5v3sVNkYJd14YLH7/1ojwOiTk+DG8aLgJwKo/0LJ5YS/+ZOr3bvcoqbbzY2IDurf8CF23iHS MLlNsFmGUNJlxS2uB6F2ln6bw1HvfKF7jer1SGPEhMpB1812EFRf8E3E+EFzPgJ7Nxabx+stWv3 x0m/0A9PXPnZ78gKNvlNyAa7Nv1XkdHepWyBG1JwZS4ft9kdUFq2XFh1R5pIgBcfgJLiaoVZT8+ incOkaP9ujhl9vEsuVybMixsaYUHkmq44detZjwN1iCscLu5KczbI= X-Received: by 2002:a05:7022:fb05:b0:128:d5bd:3572 with SMTP id a92af1059eb24-12ab28e4a9cmr7462020c88.31.1774926414912; Mon, 30 Mar 2026 20:06:54 -0700 (PDT) Received: from ZC-202510311500 ([123.139.39.4]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97cb08csm14922301c88.3.2026.03.30.20.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 20:06:54 -0700 (PDT) From: Haoyu Lu To: Tudor Ambarus Cc: Pratyush Yadav , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Haoyu Lu Subject: [PATCH v2] mtd: spi-nor: micron-st: Enable die erase support for MT35XU02GCBA Date: Tue, 31 Mar 2026 11:06:42 +0800 Message-ID: <20260331030644.1120-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.53.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The MT35XU02GCBA flash device does not support chip erase according to its datasheet, but supports die erase. The existing code had a TODO comment noting that the SPI_NOR_IO_MODE_EN_VOLATILE flag probably needs to be enabled and the driver implementation needs to be converted to use die erase. This patch enables the SPI_NOR_IO_MODE_EN_VOLATILE flag and adds the mt35_two_die_fixups to the MT35XU02GCBA entry, which includes the micron_st_nor_two_die_late_init() function that sets up die erase support. With these changes, the flash device can properly use die erase operations instead of chip erase. Signed-off-by: Haoyu Lu Reviewed-by: Pratyush Yadav --- v2: Remove TODO comment and rename mt35xu01gbba_fixups to mt35_two_die_fixu= ps per review. drivers/mtd/spi-nor/micron-st.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-s= t.c index 4e8c6ef14697..c22d62545391 100644 --- a/drivers/mtd/spi-nor/micron-st.c +++ b/drivers/mtd/spi-nor/micron-st.c @@ -185,7 +185,7 @@ static const struct spi_nor_fixups mt35xu512aba_fixups = =3D { .post_sfdp =3D mt35xu512aba_post_sfdp_fixup, }; =20 -static const struct spi_nor_fixups mt35xu01gbba_fixups =3D { +static const struct spi_nor_fixups mt35_two_die_fixups =3D { .post_sfdp =3D mt35xu512aba_post_sfdp_fixup, .late_init =3D micron_st_nor_two_die_late_init, }; @@ -202,7 +202,7 @@ static const struct flash_info micron_nor_parts[] =3D { .id =3D SNOR_ID(0x2c, 0x5b, 0x1b), .mfr_flags =3D USE_FSR, .fixup_flags =3D SPI_NOR_IO_MODE_EN_VOLATILE, - .fixups =3D &mt35xu01gbba_fixups, + .fixups =3D &mt35_two_die_fixups, }, { /* * The MT35XU02GCBA flash device does not support chip erase, @@ -212,7 +212,6 @@ static const struct flash_info micron_nor_parts[] =3D { * MT35XU01GBBA, the SPI_NOR_IO_MODE_EN_VOLATILE flag probably * needs to be enabled. * - * TODO: Fix these and test on real hardware. */ .id =3D SNOR_ID(0x2c, 0x5b, 0x1c), .name =3D "mt35xu02g", @@ -221,7 +220,7 @@ static const struct flash_info micron_nor_parts[] =3D { .no_sfdp_flags =3D SECT_4K | SPI_NOR_OCTAL_READ, .mfr_flags =3D USE_FSR, .fixup_flags =3D SPI_NOR_4B_OPCODES | SPI_NOR_IO_MODE_EN_VOLATILE, - .fixups =3D &mt35xu01gbba_fixups, + .fixups =3D &mt35_two_die_fixups, }, };