From nobody Thu Apr 2 01:10:06 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0031A724C for ; Tue, 31 Mar 2026 02:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774924395; cv=none; b=l0Xi9pYUP7NWnNHkXzjjeX7Z6ycI8AyHvfw7iWDqo4x6bYdSIbtLprZIFOoooV+0O753/mKZPP7mT2FS2lUlamhdEf2ntEZnnx927oxxUAIfswv/KsZAZhCC+62J4uC5IOiJPZAawqTm2WZi3FAVfWRu6XZDhiVs56iT4uftoxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774924395; c=relaxed/simple; bh=1KNn+mjKD4F+5L9f3gCgoQnDQQn2gshp5PpiAdd0Vw4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mVb1OwLNM1bo+aSkgexrDxPlQu+V2uVE2/v6hBELzXAMyRRXUsE8GIMmNTfREuxZj7hFjlNEdFKKbkeVkLOqnGFoMTwaMesBGWmzkPUQL4XF+jDKDI0qpE6KPmT5rNNIQJoRAxqfYCAf7nitjma7Ch66gUQ1vTllh4LNzFx8VGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EnbH2j9s; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EnbH2j9s" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-829a27414a3so3012007b3a.3 for ; Mon, 30 Mar 2026 19:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774924394; x=1775529194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ndPA1qw6T9cOuopTgHfdnnxjIooO/Cjbe/kcwP1WGog=; b=EnbH2j9sX/HA+/Sn67gsUz61B4pf0OCtJ9OuuZVukZBw9wh/IiYV7tb0vksfgvW7LH fbU6mqK3nbumMvXXmf+JBDTeab14M9oZO4rJR3JNumCeWS6heasBh8Q1WteMrDqMbx+j eZzLStHGsof/AT8SImfmcweOC6TcvuqbLbZtOSKJehFjo4rm02uG+ZTY/OCJKA0xcPHA 4cIoCasw05ExiFGN1hvn9NPtGuO0zr+cJCmOnN+XCbhGWEBmnVCdWBauua3reB42MTH8 2TNlCAZNB5Q6S/7fgAzsWsuQ2ehlwczzZHaNqQHi75W0E7xG5LVpPnfPSG+Wnb03fzH5 TfVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774924394; x=1775529194; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ndPA1qw6T9cOuopTgHfdnnxjIooO/Cjbe/kcwP1WGog=; b=rWMOduPUMghlJR5fzLvF4q0Z7XLfxnVlobJ4qAUwHo+XKWu3Yftv+vh4O/zAPiCPAv v8z2wiLvHRTqurCmovfB8L4eYA3VolhaV2AYh5qRiJX5hM5TE9Ve19FysHQk8bimTwZu gCoCK+AHr2kX+hkQbnPUdeUhZbDFfFsrIDJH7NJsM7pMlJmCb1bZmYbDplNbJeKKrwd5 nLdZO9EaPzyaFh8np7fuNNsuJPOSV++FeQgajKrySEkjU6Gz6bexbK/9/3b6wXnZqlQk Wqw1hHVfRbBObsIda638sqfo7DaNVUwZMMdBa9+KA/X5YCY9fiNoXWx8FnllmbMgIj7x IMcw== X-Forwarded-Encrypted: i=1; AJvYcCWyIKvEqoLYtujVu48fZwYrDKLe72hjE5fr4T6Dg1UTQgjl0d9OeqGcFp0UJFRCALNMkrupcud8nqGKU+o=@vger.kernel.org X-Gm-Message-State: AOJu0YxCACUmlEExC9txEoBynsQTSx/sFYylhoREdfonpZv2s6jQ3PZR ek5HaI2HgKta6Vpp7zk9uwLFwHR99ACovidbnH5LAJ32K2sju1wIT3r/Oe+wHQ== X-Gm-Gg: ATEYQzw3KwgYP3D3AksWc/vChwKHjE0n6JhywMCOZcnVkeinCiYSq1VgnuDTvgDx5Ct fdCkt5vpnhXr3+ekfDlSgDAXdXc6PSp93qe4NgK7pNw/nY0v6bnnWvzbRTT5KMjsPvMf8gA3sQw Huckn9t0sgxOa6lB43wfCHFOXVpcoQAZIR8csG2TX2CvEa4ItUoKw6lLoQEugT1XLakzTHIa51b 8OAXjRcDy/pkBCA/Z+KcIkCCi78nJ6ZZF24U1NR2yyGHNMKMfHx5+NtgNYhUCwCrKjHiOAXJLjG 6wU8saZiA6M+1+ddxbG641D7bJ7lFd8mLHpGPqVG+CkzWgxJDoIEjDzdp/B6PKVYMWX8iPoEGRg joy+/Of68pBNo7qVhWlhnItSKrOphxX6sB/aEQEbIvMqu+l72KSJ+6HglCv3C2DlVGTGASJtOcO zI6PhOku2aCfFYuvYRzDt4o/FNxmqfjxgvDTnS46snVYkS2Rk= X-Received: by 2002:a05:6a00:299a:b0:829:7fff:eb7b with SMTP id d2e1a72fcca58-82c960841f8mr13807742b3a.51.1774924394018; Mon, 30 Mar 2026 19:33:14 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca843b818sm10521706b3a.6.2026.03.30.19.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 19:33:13 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Gao Xiang Cc: linux-erofs@lists.ozlabs.org (open list:EROFS FILE SYSTEM), linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] erofs: fix missing folio_unlock causing lock imbalance Date: Tue, 31 Mar 2026 10:33:06 +0800 Message-ID: <20260331023306.18574-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" folio_trylock() in erofs_try_to_free_all_cached_folios() may successfully acquire the folio lock, but the subsequent check for erofs_folio_is_managed() can skip unlocking when the folio is not managed by EROFS. This leads to a lock imbalance and leaves the folio permanently locked, which may cause reclaim stalls or interfere with memory management. Fix this by ensuring folio_unlock() is called before continuing. Signed-off-by: Zhan Xusheng --- fs/erofs/zdata.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c index fe8121df9ef2..9d7ff22f1622 100644 --- a/fs/erofs/zdata.c +++ b/fs/erofs/zdata.c @@ -605,8 +605,10 @@ static int erofs_try_to_free_all_cached_folios(struct = erofs_sb_info *sbi, if (!folio_trylock(folio)) return -EBUSY; =20 - if (!erofs_folio_is_managed(sbi, folio)) + if (!erofs_folio_is_managed(sbi, folio)) { + folio_unlock(folio); continue; + } pcl->compressed_bvecs[i].page =3D NULL; folio_detach_private(folio); folio_unlock(folio); --=20 2.43.0