From nobody Thu Apr 2 01:08:42 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D7D3090D9 for ; Tue, 31 Mar 2026 01:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774921485; cv=none; b=j3fn3a2OP3xmREJNrugvG9r4yylfOjjz5LLk38J0l/nTo2k14QcgK6u5E+8Hvo6qLxmV6P20OK4hCyDoogYjdvF6I4FxXEYmqZl3RtNE3aNecGzHNwRv5JYqoL1G9WiPcXa2OKUD1tNIjdNFnUm3CPqNoYck2Uu3+9M2fEewkys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774921485; c=relaxed/simple; bh=CAd9CsIw5uBt745HRHWccms+aIxJBHEFfd2l1zBYTmU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ewOjAhVA1SzJdrOSafefnk5c01dwR/VvbrRI5nk3DyiQdxVsEPAtSKONGgxVYDM+6LLnatQ000r5J3ZHEqfSucmvgQcRm5bfs+lQrqp1lB8wly8HNSqoWR20stEBChtgUoil4W2xBFFFjgnvHGTF4KJw+RjsnelcZPJ01fd5tWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MIcVmaqj; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MIcVmaqj" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48558d6ef83so51184215e9.3 for ; Mon, 30 Mar 2026 18:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774921481; x=1775526281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0u4XGipzXcrllq+GKNKoK9rSohfYPlxp6GgA+a5PaTE=; b=MIcVmaqjrhMqGBtGDV+XNGriWFUzjAaNjHQgsrprhIxfVatsbU/KfxniG/QK/ZT4pq pl3l9PFkASgaonv9f3ryJmsfxcsQvIRl/MYZusdS1Steud9ELG2rzL938MSAgIfiChxw nxH/Nllk0XaA+Wn0OGOzri3oe/fZsORFwWOOXW52aSgvTEkCbiyUclCcsyNS03tMoA2b 0pG1u2vUCTsfBDiZv3FgMOeo2I7zqufZJkFXxGlANMffMVQLqfoDQXRfNUFdiwZd94/7 F3zIU4YQm+9m+70eBdTuKYZxn88mDJE+x9jml9PlsxHdh2HuKACInDEWR8aCOmokM6xd rdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774921481; x=1775526281; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0u4XGipzXcrllq+GKNKoK9rSohfYPlxp6GgA+a5PaTE=; b=DxDzN+oS/2qfVZiopJS+ANqN1m6PS1JsfxstobpBUkXekAvdly9nBLPaCRTGT/dkr9 xmuPlv7/Iir4RAG/CloS4ZrJvijHFdkWR52FV8E3twDU8avacL41vDUTtiDXe2DXhBWZ hqDoPg2K87qpbZS/YVSwFR7jTUh3V14na1zPu3nbqWp90pVeB6F5zyHVuXhH0O16jHah krsjahegsWCbIDBQd9c8JBErux639SR1F8WfKkFemI9lNLke+R0U3J3nWLhU26qt18vO lf1Bk5mHP3pVswIzMkPS2sdLO8NmOyXEAkwgwN1ltjyv+kImoTWyKAaCqjwc3SYKIAxQ F0dg== X-Forwarded-Encrypted: i=1; AJvYcCUpWDqt2OH+yWS7n7AY6gsQRW6a3zwv2466ASN9Jlnv4Mzmr78U2gs6E2+1Y+NKMsvTqiEbJjTH0Abhdps=@vger.kernel.org X-Gm-Message-State: AOJu0YxbX3YSCPgVb4aLY+k1MeP9XWwar31Spvl/LqlfleSdLCZtRFHp raLRa90O/bBCbbhPECSEduA6v37gblAMb/qkEx48YY9ZEy+H2zfT+m+y X-Gm-Gg: ATEYQzw9VvMJsYwIJMDsBJlVYQA7gtKVzUxown2cVjPSz7VClMEEckjhm6BDnu6N7dJ QNZBezGys2rsirn8cXrHcx4cqDjqRECxUO9oXq+GAjjoWIeZXNNgiO8GWMzWAivsGgJbTmyIBJq xOqxNHVfrV0shWRy6v7Gi6BQbqjObaWTjpI2EC631jRwXnqaUvUyyHVpozN3bahLlCLZy2gVOxr krO+dLsrul54/gwH1htsPc8AhudoyJxkgAnGqH2pjoF3EwvNabHsKDeE3su5A9lPiE4CaeHfSaY j4NUgsfMSsMUVOFHtumkc/NWjo1Nhg8056xnFrqz/oc3Wi63e/uAi3xQhHdyR+iQzeClolJ4Kyx aHgHx7DAbXndQYPgmWCuvAy6ZdyEZMqSBdTuPh1TzKyc8pWZ16R0OMwiKXyAg/7N2IcXVY73DCt P9RNilSWqEtSOa88Th8TYyD5KtTqMbEuLiYXPhzWx1+JjCqDsfs0b3FM284GsHPS7Ey9LG2NzA8 FOhsqp3o4ImNAmcsmVw8I002RGvgispiwNT62QPXvnBVoRgJs9jZKQoxAg= X-Received: by 2002:a05:600c:4744:b0:486:af22:4a2a with SMTP id 5b1f17b1804b1-48727d5a2e4mr239523885e9.7.1774921480961; Mon, 30 Mar 2026 18:44:40 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c84988sm284035275e9.5.2026.03.30.18.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 18:44:40 -0700 (PDT) From: Prathamesh Deshpande To: Leon Romanovsky , Jason Gunthorpe Cc: Haggai Eran , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Prathamesh Deshpande Subject: [PATCH] IB/mlx5: Fix potential NULL dereference in query_device Date: Tue, 31 Mar 2026 02:44:27 +0100 Message-ID: <20260331014427.11756-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reported an inconsistent NULL check for 'uhw' in mlx5_ib_query_device(). While 'uhw_outlen' is checked at the end of the function before calling ib_copy_to_udata(), 'uhw' is explicitly checked for NULL earlier in the same function. If a caller provides a non-zero 'uhw_outlen' but a NULL 'uhw' pointer, ib_copy_to_udata() will attempt to dereference 'uhw', leading to a kernel panic. Fix this by checking the 'uhw' pointer directly. Fixes: 4835709176e8 ("RDMA/mlx5: Don't fake udata for kernel path") Signed-off-by: Prathamesh Deshpande --- drivers/infiniband/hw/mlx5/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5= /main.c index 635002e684a5..471dc8df4a52 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -1353,7 +1353,7 @@ static int mlx5_ib_query_device(struct ib_device *ibd= ev, fill_esw_mgr_reg_c0(mdev, &resp); } =20 - if (uhw_outlen) { + if (uhw) { err =3D ib_copy_to_udata(uhw, &resp, resp.response_length); =20 if (err) --=20 2.43.0