From nobody Thu Apr 2 01:10:08 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 287A340855 for ; Tue, 31 Mar 2026 00:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774918156; cv=none; b=ENjE4j37rNPue5H+zqHjmC+7tTT3dmBGCxiPHq/GY3wZ9cm22VXddayEdcLgTrR6zLxCRkLdN6DdOdKy5Oofw9lgDjmFtFrN31nJvDjnSpOStHEVLE5UfKaLHO1ANVBokFntjIz6zFwcOMoUL2m/pg9Un49Jkh1gfec/N/ZKZcE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774918156; c=relaxed/simple; bh=iPj1esjPyQMuh4WUKLUVr6cUL4OZykR8gDVx+T5rnLk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nkx7mQ+LYxjYCY+GCTMAiru+fSuW6f1mpHz7r1V5cYF8Ud0LrAVekHsxnMRkslz5ULd4OK7tTRWyMq3KJe8sTUk38bgIcBdHJNe64sWzgHvHMeOeuEps49WEzjnAJp66wgaMA6C1dBCYBHOZAGpQudeM57KSNUBdw3QMNdoj18A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hTnZYmKF; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hTnZYmKF" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cfd1f9fd1so1062803f8f.3 for ; Mon, 30 Mar 2026 17:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774918153; x=1775522953; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=csGPUb3mVHj8mOAvrCTp6ZFFCIPT+BOCtOTgMTYKr6Q=; b=hTnZYmKFETyToW7S6jLaog0/rVKtY/WPHKb+kgAdhaPbJkNg8+yEyA2nu3CfgwBknI 2ZMJzeTFViuI+IDYAWYgAvpCQrtvZtSwz/+8iyQxR8s3M2/DqIylJucY6UKVUxxeOezv vvYhb+ZeFmilbwRvaYq+uxiSWnnk20VcM3CPFIFtJrG7yg0xyN6gjPW+oBb4yT1ic2e8 MKfcIoKIHCWsjA5wPWeG6HFAY2iLd+5+y9I4Yg0+yaizMV9tke0xGFIuuEzj5yALvRlr W0wPOGX/v6ZAuRHnBHwIBFzMdOwMembxeRcbt2BxFb4QkEGW6+2rAs75hV1M+jldakPs aj7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774918153; x=1775522953; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=csGPUb3mVHj8mOAvrCTp6ZFFCIPT+BOCtOTgMTYKr6Q=; b=DOuPxmdoM6nKHP2V2U/oCPt418D6y5CenvM+CN/kLQatXIJ/ZvofaffnkikvGwQb32 zO5pOKZq8ic00GhTjbIr+Dm9af0HcvbYIW7uLUgHhsQ7wF+ORxBL8i20qTjjbroc1ibb bfyw0e+b5BhBAOvA9ODR2I3hQPCEPAWROLFbHHV0OEr/FcZzL/QAbRUeq8XhX0GTJTxP w3RcNBgCxwi19WvvrD/ovHXznCYGBQcxKGW9gfMw5ak5/c+A5NXbI7BWouTBj2DSaJV3 64l3ex7rnWBMxTKT+S7bUAsxh28mYOc7zjjXacvmtUGItTWXckqBB5a3tsBctn02aeYt PcFA== X-Forwarded-Encrypted: i=1; AJvYcCXo0u7JjL8ccyzYYjks8tlhiz1XBeltJ1ZHMxyat7a40MqepmBswwfCmrCGcQROMVdSWA6bAykt2knFZxM=@vger.kernel.org X-Gm-Message-State: AOJu0YyXpup1rCm597mJ/yEQSE5KakzZipBLwHJGTjEBQwEBQzasnykV EIOpMgOWfc02QHp5tB5Nonu2YVm1VQ057rXBvGOpP7BLEnbJmL5h9Nn5 X-Gm-Gg: ATEYQzyfL4jFoE70BPrHRfS3iPh004Jr11zc7I0otOsI8v/FFYPP0D2wTfHd+LS7xs5 cJYX0eLkTGRJ8DdwWkRwNemZdN6Yvu0iDREdEViEPfXZyv5EMJrQ+ekLCZra8hGrOIuJgPSD+xU /kx1MuTNIJY84Z2Xr0b1HAA+bH/DcoD27XKjEJjMm4N9htiX/GMbTNcDiuP4cxMDs+Ftby+TUQh jzj7wejC0FGnLbN6erjwHVc2C/PzQBXPi6F1AHmwn+47VgZLqnIZsHKKk8t/5fqFrc5IEvu5zza YUquYa1zkEo9E3/JutiOpcrbOkcth0J3KrwV8uF1copFx4qq7+N4jwhuIltZHR+tE7Kn0+88NiQ yr+RdgZecmhQh7CWck4cg33g1slK0PIB4NL00NodaJbqTNRWrBOVGQFSthgu9tFDggrHkyE8xsr rLgL+nmV/A4FXGxBpkSVDTE0CWP6eQ3tCoQJG11ZUj8AqcrFXf8SIdvfXoZhvo+uNO1GH7hB5PT A7uWXFmtzQ8g4u8Pk2mvpqc73tOzBkZG5H3+n/EgY9qbKtvOObKBOsw84Q= X-Received: by 2002:a5d:6344:0:b0:43c:f40f:6c91 with SMTP id ffacd0b85a97d-43cf40f6df3mr12456532f8f.10.1774918153342; Mon, 30 Mar 2026 17:49:13 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf245e2f6sm23428139f8f.18.2026.03.30.17.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 17:49:11 -0700 (PDT) From: Prathamesh Deshpande To: Leon Romanovsky , Jason Gunthorpe Cc: Haggai Eran , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Prathamesh Deshpande Subject: [PATCH] IB/mlx5: Fix memory leak in GSI QP destroy error path Date: Tue, 31 Mar 2026 01:48:10 +0100 Message-ID: <20260331004811.8851-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mlx5_ib_destroy_gsi(), if the call to ib_destroy_qp() fails for the hardware receive QP (gsi->rx_qp), the function currently returns early. This results in a memory leak of the software resources (outstanding_wrs, tx_qps) and the 'gsi' structure itself. Align the GSI destroy path with the 'best-effort' cleanup pattern. Even if the hardware fails to release the QP, proceed with the software cleanup to prevent orphan allocations. Fixes: d16e91daf446 ("IB/mlx5: Add GSI QP wrapper") Signed-off-by: Prathamesh Deshpande --- drivers/infiniband/hw/mlx5/gsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/gsi.c b/drivers/infiniband/hw/mlx5/= gsi.c index b2e2a219639d..2272236e7f7f 100644 --- a/drivers/infiniband/hw/mlx5/gsi.c +++ b/drivers/infiniband/hw/mlx5/gsi.c @@ -175,11 +175,9 @@ int mlx5_ib_destroy_gsi(struct mlx5_ib_qp *mqp) int ret; =20 ret =3D ib_destroy_qp(gsi->rx_qp); - if (ret) { + if (ret) mlx5_ib_warn(dev, "unable to destroy hardware GSI QP. error %d\n", ret); - return ret; - } dev->devr.ports[port_num - 1].gsi =3D NULL; gsi->rx_qp =3D NULL; =20 --=20 2.43.0