From nobody Wed Apr 1 10:27:23 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A8B437E308 for ; Wed, 1 Apr 2026 03:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013776; cv=none; b=C21ETN4zzcA+uVbVruWWdRHw4XROg/VUvAPKXSDGPBp8J48bA2u9E39tLmAwjCRAoDLcQ3nlX+RJoHiVrMWEGRTYwlpVA8Vyx69gSoMFf2JlZIy8zO0AfSmLJeuT4OLUkl7r5KCd0f1HX7krBgG3t7dH//ur/85gZQnqzuyuG6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013776; c=relaxed/simple; bh=eh1pflsFy4i4xWuCJ3debJEBSGewUbDoQf1aW0vXPiQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I9qj+paSeDqOjXuthXXojJsmSC1a1+jttS5wfDiVwsbjDgggfRa4uKgJ5mKFZPf6Tve/eZE0XL59ej5RSFgyz2nUXY6/dZaSZjPvFIjJxYAG44TYvmKCm5+gLwTAwWnCEu21BrGjZqclTDLo2RV+ly7K3qXa+zchRwZPij5XwEs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R1oZZ4zc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TPvkHnWE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R1oZZ4zc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TPvkHnWE" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6312It4Z1004316 for ; Wed, 1 Apr 2026 03:22:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NeBiXiKM8mAXaG/h32EbZAyo0/+HNOhfKQaw4GQVIz0=; b=R1oZZ4zcgENv2srb SjTxEfcJMUYSe4XsmDipeJXQbykaifAQBQJO1parvpFtRtvSS2f2YEDdO32vgPIL uqROD+Afz5NIYn46/FNr0uSenVCjYYnL/atzLfJi2xHXTv8stJmkIZlxsDSxkqxX W29SbR0C6drJ+U5awUoCt/jeaucRqIkDjhqoDaLm+WF3TdmnHY2SXFil0MhO1eom bHv8ZGsJyxT2MCNMra/TujUARAK8phalNPLaAV6UUgK8t7Z9SqSt7HOYol87cXE0 bHP7iK71Yg7g2mId5KXp1VyaJ2pivIFAxcLM2V47L5oWu7MFRHadAlTpcMJpFgnM F9Tpuw== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8tfjg6wh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 03:22:52 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7d81042e8c1so25464969a34.3 for ; Tue, 31 Mar 2026 20:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775013772; x=1775618572; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NeBiXiKM8mAXaG/h32EbZAyo0/+HNOhfKQaw4GQVIz0=; b=TPvkHnWEEiH/SEARC5B4XRHQtrmTEU/FPDByprl5Zqf1FfWNUNKfT/MQK5Tx4ljkq9 6y5s//dVJgqfma+pBgG0Hc5M1MUhENB4UfBWESNJOaAE3tnIradjIuJEnB/MVALW2nPw rTid0wKKWb96kHCxS9qDCN+n2+gUfOPF8fITKvyJEgCijPHIdliAUBqkDfNhO+lQebOk MY32qQ4zScDqTWkMm5mIL73AkGnDh9wh0kV+tSyYcb6e+SEixV1IEppcw8RlyBPLC+HA hxatf26XMcqPBJO39m5oNhY+d15Cnv05hPg6fBL3osZJiygEc8lTVxCNXa9zpmMw8izS rZww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775013772; x=1775618572; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NeBiXiKM8mAXaG/h32EbZAyo0/+HNOhfKQaw4GQVIz0=; b=N5o10TyP7QZXtHl+uWPkf2GUMw+prMtnk7FI5EW9zNq+PFMrxFwv58vRDK3rfsXcba 9gYuR94WrS9XyJ4NmR5vbcPetbJ0VWw9K9Fkdg4Z1qTgnlKGL4i0YuR/tq0TYCp38E0l Gm01ON64/cwZZv/fNj0lNXLuTHgrkGRJolk1nsJP90z1y87U+t8vmp/ugG53qYsd+lNA frdHJPlmxB+YXUHP00HGtvXqqiwu8LxFN4WJJ/6Y7MoBaQHaffQc3bzXty4Xud1U6umv HEtgFqiYCMCA5HnBxLWV6wzI4mDyM+QJLG9oJxt/3d0n6uyIoSDV5/tqFTQFuS2Ctt6G xENA== X-Forwarded-Encrypted: i=1; AJvYcCW5V+ucvFMRIpjH8HivJha6e62zDKsHhlT4CoSwo9tYqIhtYU9jyEnSd8vfUESqVXGovwLTCYEyK4Atw78=@vger.kernel.org X-Gm-Message-State: AOJu0YzxtfsLQjJpS3fnx+GjVVNjHbctCogjRUt3nC5zE2ev2UhEQZJ6 tkjBybWL8Cc9sI1yKPCf7CyMRaIBBBcPU89ijFl7sgN2iDwEtFMFrPk1Fr83tfpdg4RVZrdsfB9 K3yuTLybdvE7x1XOoY4dj/CrvDdZvd8mToVrDY8Sds3eHMvscMiV35zC9E8ouREy3MO8= X-Gm-Gg: ATEYQzzU+ihgIwFImnD7Nfe4GrxReXOf94kd8pUihnxsjFy25EogIsik1AoIAZPxVW6 NkBLXRZBxw/l9srp3iKfnRC9FYJZkTeTJZYT3JXvBI2mV8jJRAGe5kZEzVdvJMI+h+2e/3sPzHq oZ4PHDomiVxS6RCO9tISfrPQCFplgV20xa2b6OfnoFSDmujH24RQUM65L4sRgY0YAhc7O4l19ci u/J9lfuiovOliJoCcwrA4c1/0dWYkgQdp8bWBM+27n54PWF29u8H0+wi3mKvEZWJ2EDKopODR5n c8r2Z6pm/KqPQuK4JO1k1nKUcd9VtsqIcOgtcEfSPlIMH6kQ9ifGJuVhoBhWz9ZXtn82YsCQsCw wYUCduZxwv3UMjVpVIhDxCnamQChoc9QOHuHXi4i/7UU= X-Received: by 2002:a05:6830:81ca:b0:7d7:d1f0:7493 with SMTP id 46e09a7af769-7db9934565amr1409201a34.18.1775013771748; Tue, 31 Mar 2026 20:22:51 -0700 (PDT) X-Received: by 2002:a05:6830:81ca:b0:7d7:d1f0:7493 with SMTP id 46e09a7af769-7db9934565amr1409191a34.18.1775013771358; Tue, 31 Mar 2026 20:22:51 -0700 (PDT) Received: from [192.168.86.59] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7da0a336d73sm9589357a34.5.2026.03.31.20.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 20:22:51 -0700 (PDT) From: Bjorn Andersson Date: Tue, 31 Mar 2026 22:22:45 -0500 Subject: [PATCH v2 3/7] slimbus: qcom-ngd-ctrl: Correct PDR and SSR cleanup ownership Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-slim-ngd-dev-v2-3-9441e9c8420e@oss.qualcomm.com> References: <20260331-slim-ngd-dev-v2-0-9441e9c8420e@oss.qualcomm.com> In-Reply-To: <20260331-slim-ngd-dev-v2-0-9441e9c8420e@oss.qualcomm.com> To: Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org, Dmitry Baryshkov , Mukesh Ojha X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1608; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=eh1pflsFy4i4xWuCJ3debJEBSGewUbDoQf1aW0vXPiQ=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpzI+HEE+6zNK/v2yvG3jpdJVZIL2zvWuS+H9Ov Hg0ELibHk2JAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCacyPhxUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcXF0A/+ORqUdaF7mRoNlZKgJfhlryleRnQNlHgahS/+/E8 Zr1nuupkvYlUttbGyNne6kiNfcU0lXDEZkuFNz+VqvDc9FtVCTn1RpAdvTTHpa78rUEgXOp4vWV ZyDt/vyEYZu8J4brtB+Go72Ug2XJHDBuIi+htYSa5bBhLeUgV4VBq9NgFF/sGk+QIGyVkN4FH02 bbeKxHlMDWCWVY1W77it8/LVjExl8neJ/265ZtHB74mer8ojfXOM1dE1RpH5IM1QndktMseeKSm eOtbtTwlV3LVTH9oFj1azptmEyLZaIdPOGn5Wj6qezuoDz1WhgBp6bnAeQB5yxVFcjQbZHx/ILh mtO9Dl1bkps5m/bJOpQB5+Jdxmrpzy3bGcPx12pKonYj8K6QUIZFWkaVEyYc+vlKY1loHPdaVvE IORld5eusPmPCA8AKYrgdQFZhDJJL5TtFq17yucRt7v5E43HAx8lmmPUvALhBqW6otXGsJ4dOee HIV3Muq+gD7Pnau+rTNNqoDU3iQYIjmX965ShihiFeG4GUeiFr8TIf9WYb6oCIAAv2foq4tNv7+ QEdkPMSAWCAjpffwnoIt+76tRvG4X5RvCFLG91V4qQiqv1l2d0xH93d3nBgqERxIBrZcoIMEK5X ZNVJqnwY372Jdu99LcI5kCRku0qqNvDJa2kaH6KBmikw= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-GUID: xHNEFcyMbSiMXJdGeHGmwpQpLNSNHRRE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDAyNCBTYWx0ZWRfX3W2DwvZaTfEB wVBJY5L7atT2J1LLmJdkZmgCRyXE5LBh2HMy9rcyjxP7BVXswZfSMV7Qxravudt+vE6SqZUwRQu atQYC9t/CxVGhARnYSTeNzr0vCZ/67dXw0CyzKbTbTSxI3CrkuBmgP8uSsuM2k9l26fEHBu3ey7 mhpj3GxDEDHYKfP/zirltc81z0CevGe6Q30HUozKM6LK9nWPq9e5yU2O9sLdBpKIrBzGDEG3271 SQw+1cWQFRZz2KI8lEU7734Z3R3s+O6sriQE29jCbKmZqGjWCw/feDLYBTh5YccV0g0BpUKRNjt 7MJYO/hKJ1AUgC3NBuFtLEvYIPcEVB1HH0vmkGpaQCrP/zJcrYTdAfB2D1h2+pNnPkrklZcNQOn FCbgO0vd47yuw3PExIFfMgWxR6n6vstjfAfWnrBqcv4tKXGm/Ht2nIFJTLN3TlTKPWtsCiab5s1 3Ay4Uze1iFtfbWhaL7A== X-Authority-Analysis: v=2.4 cv=fJc0HJae c=1 sm=1 tr=0 ts=69cc8f8c cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gyDl647GgXGSOFt2m_oA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-ORIG-GUID: xHNEFcyMbSiMXJdGeHGmwpQpLNSNHRRE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_01,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010024 PDR and SSR callbacks are registred from the controller probe function, but currently released from the child device's remove function. The remove() function should only be unwinding what was done in the same device's probe() function. Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha Signed-off-by: Bjorn Andersson --- drivers/slimbus/qcom-ngd-ctrl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index f26fe54b2ffb4bbfe6da6b717257313536abf60f..fd533d5bceb6d7352e8ac6fdce3= 21d3acc285f1e 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1683,6 +1683,9 @@ static void qcom_slim_ngd_ctrl_remove(struct platform= _device *pdev) { struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 + pdr_handle_release(ctrl->pdr); + qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); + qcom_slim_ngd_unregister(ctrl); } =20 @@ -1691,8 +1694,6 @@ static void qcom_slim_ngd_remove(struct platform_devi= ce *pdev) struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); =20 pm_runtime_disable(&pdev->dev); - pdr_handle_release(ctrl->pdr); - qcom_unregister_ssr_notifier(ctrl->notifier, &ctrl->nb); qcom_slim_ngd_enable(ctrl, false); qcom_slim_ngd_exit_dma(ctrl); qcom_slim_ngd_qmi_svc_event_deinit(&ctrl->qmi); --=20 2.51.0