From nobody Wed Apr 1 10:27:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D868361647 for ; Wed, 1 Apr 2026 03:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013773; cv=none; b=BHoS6alZi1wAvJwoLZysdZW+5wDsVkw7ipnDQo3ClH9CPk9sa5nlBOOGX80mjsnyVoLqxc0LurL1EMEVDOJtc1yhUSi9xgNptA6RCn38rObtCqpCgyLP07O3651R7z0BY4ay2MhO0fJOR7lPXScYwlfxrXFMLe0gBcUlI5KU37c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775013773; c=relaxed/simple; bh=lY2lCZgEYqxClbWM9V0f53j3uqFUVFNr9SxWISwJo00=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=W9rF6G9/5N939lCWXwt8FcinuV9JBM2BB7fpQgczdzGgmBIrJs1yW9qiRUQerJjfIGZJ/teccEEHfpftZMdseBhhkGzndUMY9qCy3TObGd+lzxfdwUnftIbWI4o8uJMzEFKrOulL1PX7LrIWoapvfvZX0KyCdz5UgiNk3U6SW+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hQ2cckUM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bgyY3VZG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hQ2cckUM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bgyY3VZG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63106BOo3926884 for ; Wed, 1 Apr 2026 03:22:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U/S/7SAnJtVprqSH8/36zGYJ0LJVG/tIKEIEQ4Y7FyI=; b=hQ2cckUM5NHFeqJl 2Z+vszKWr1N42NOTw7Du3bmWJnF/tM0VvVkY1gjrII0Xba8B88HfQIYQyr0fNNow SymbHm0AlLWgh1itzI8iI6SJxBURszWQrWEDZbC5bGPj6sYhXu3lBtYnyKx22/H3 tgCOwOpTZLVxmLOJD5cStKtL6T5Wm/YEVzFf6pvZfZGzdavMwVzigxLDlKWe/yZg U2InjeTX4XoPfzdTZ5OV3Jm88glnnlJmwUEOBif56G3CXFW7SLzDM5oUQ7Wg1xzK gOiaaXBZfVdZwn/J73PgChxpOjhxXLqSrY5I6zG+OISRuOyvFxvkVbIPXnFSob7f tflbPw== Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8b934g24-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 03:22:51 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7d73c71f9faso20612996a34.3 for ; Tue, 31 Mar 2026 20:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775013770; x=1775618570; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U/S/7SAnJtVprqSH8/36zGYJ0LJVG/tIKEIEQ4Y7FyI=; b=bgyY3VZGe0Lp+uC4NiwPhjbq389nhll4g5l3b+kl4ERxegrHnH2PFW6UNftd+zhA8k 3Vb7hMAGgflmnopihPgrggEF0zCVEGL8zRBJangFqh5jQYUxqT13S97BGjKrpMIFSPhM nQRjC1ztrwuqNK7ECcvqLA9yqKBT7bv2WcXyG4unxElqOpB8RVfBV55UYYn+F+JDNtq1 CcoW+/cSn1SYdWa4g0EZm7kULKRj1snFV5K2S/3j65MB5fsl/4Z2w87AxJsPyPrWEgsW JddP4z5rm7Vwu9SAmFPOYL+Z+OuTtQElAgH43Roqapo2nE98ruj8M3sX2KJUJR3/8tfI uqeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775013770; x=1775618570; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=U/S/7SAnJtVprqSH8/36zGYJ0LJVG/tIKEIEQ4Y7FyI=; b=jW6+2UtG3kvk6GO9MQVVKEJ+qoe+D8C2OsRrdSBPwVRDmmaslOlmAoVCeDaC2of+t/ SPpuKOBkXFlH42oyezVUXvUTSBnT+FYaBqBE5l38UpJB41tpLJ6aUj/+FLAsMuQQINgu iNlnHAtL5+cFE8GIkWxY0LUDGcViexCaKBRCZBFFF2qRbG8NoCPvcbtLMy6aKDSJCxlf ub6dSybYUkhV0lsSQUgzcLkPXLQARXrtkDmbHICmY+7LUPlNL/63P0Ny7fNbDgm96fia oQ+l0f7rC2ZiSFU7/wj5Qh7gcHXheb98aKwcC12Jn1nr0nLdx3RakVfP/NtLG5yJUVox ONEA== X-Forwarded-Encrypted: i=1; AJvYcCVJnRmXv9obnNSF1WcaZubJlKL8zrOoqAl7UE8yJxORnTr8WLR9ATYE+7zlM7YqQquFIIXWpu/U1d2FPvo=@vger.kernel.org X-Gm-Message-State: AOJu0YwqwP8B2v+1uLHkWbjuSsmUxLz3Vyi6r9pnC+oJKXyfq8Iz+gbY v25Zqy2HFKc+LQezQRvG6p5F3DoAMPBv+nlOcRqfVKmktBHFXpMAFEHXlrG7931vNOvUpGN/ksk D+w8cu2MQqtwXlJRXfYTD8S9MYF5lyxDB2t9QCFGoEomcOYum14PMBA3kT8NW5Db1Y08= X-Gm-Gg: ATEYQzwaQeJ61ey0dePBstYiUv2ij33QXJ/AjPM/P8f2g/uV4mI/X1qKy5zeyNGSMN1 j1KEw3mvb5xL5C0nqbF54FTPcQEaNJxK8ZQIVXOaXTB6Pkx3/7X+oO81ohRWvUMF31Zbfb8H4uC gd4xhYxOpG4nWH0B4hV8gTE9kqkIimcy8NbjQO9zQPqZzKPPp+eDba5UTs1uxcduP0/DyTk/JCm lkfFU2/GS4FyONXOH2LcgpyVPqhTVjWg2jcs5PoYazO7PmmaZ8u9JG1rk+jQYDkznApVyX6B0H3 uXHCFWRVuOFjaEGIKqhsi/VxwgKUXZEPIjSV3fxg8wDZUnl5brbOzsdi7pS7cTdL12QKw0ZqIvd wKO6P01jIW7YMm+unOUEhIWHY5Q5L93gQsdT1z8+tGfM= X-Received: by 2002:a05:6830:4388:b0:7d7:f8ec:2144 with SMTP id 46e09a7af769-7db993bd8c4mr1361025a34.25.1775013770290; Tue, 31 Mar 2026 20:22:50 -0700 (PDT) X-Received: by 2002:a05:6830:4388:b0:7d7:f8ec:2144 with SMTP id 46e09a7af769-7db993bd8c4mr1361012a34.25.1775013769856; Tue, 31 Mar 2026 20:22:49 -0700 (PDT) Received: from [192.168.86.59] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7da0a336d73sm9589357a34.5.2026.03.31.20.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 20:22:49 -0700 (PDT) From: Bjorn Andersson Date: Tue, 31 Mar 2026 22:22:43 -0500 Subject: [PATCH v2 1/7] slimbus: qcom-ngd-ctrl: Fix up platform_driver registration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-slim-ngd-dev-v2-1-9441e9c8420e@oss.qualcomm.com> References: <20260331-slim-ngd-dev-v2-0-9441e9c8420e@oss.qualcomm.com> In-Reply-To: <20260331-slim-ngd-dev-v2-0-9441e9c8420e@oss.qualcomm.com> To: Srinivas Kandagatla , Greg Kroah-Hartman , Vinod Koul , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , stable@vger.kernel.org, Dmitry Baryshkov , Mukesh Ojha X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2828; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=lY2lCZgEYqxClbWM9V0f53j3uqFUVFNr9SxWISwJo00=; b=owEBgwJ8/ZANAwAKAQsfOT8Nma3FAcsmYgBpzI+HI5braeNn+8ivP5KxT3frvN/12UXOwqtNh qOin3ixctuJAkkEAAEKADMWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCacyPhxUcYW5kZXJzc29u QGtlcm5lbC5vcmcACgkQCx85Pw2ZrcXHFQ//Ugc6fCvbILC0dWxHHM0huyMaPvZR5xCCVR7EpPD HQqlXVODRh3u9NCImfuqHhL8uBg2298+oeU8IrQ5QzhChIQJ0Lc0HFeVriAgSSUYkst6zGyffN0 xTNnhhry2YrE3rvk2PmpsT92ItVItbAuF5utffREsV78iGkClLWKHBs0Lx/k2/7bv4h0mvKEvp6 d4ZwwBFLgfThhvrRR6P0UW22iVZyoLcEYmZACKwpVyrjFPX1VBQioGIb2X9utQ5BYHPO8N5BidA 2oEkzuq9/OGx9WkyyikCI4qgWg4J6yHCgDIcsjugZ/vJ64dEu4wUaMc73ivckEXoGRjufxe+mQq XHvWFk9Aau64FxeVWtYhMBeDjUcXCcyML9vq2rbt2vWe+dCaNKVRwgeeVM9/6SzETqUM6hDytrJ sZ2vBozwdg+dbbHR204xbNndraQRa9jDsUq3uyTi++sktlceWck3iy0OVh+ApKdj5HPjIsdoKLX W6syp55gQHVN4+5Rbr1fW6GHHLgcKgJD1pAbbOnd4Qaeqtt2eMdYS8Suf4i91ipusrCOIcw+8cs Pa1f5qGplDF5pfzCnQagVWoENG/8Rahu1xrC+tQff9TNi7FnZgWCxkZ6vmTAD/vhlDN6j9YFsnJ UQd88PwlRQkJwBlGLUa/lfMTo1MQSMo0VOQ6oF+BzQJI= X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDAyNCBTYWx0ZWRfX0XpObOBzdmtK n0rivaJ+0MAwdlgPHV5zI0Q4q+v1myQjv8nACHqYeBXS7XEGPqCSV/mTkXO2jaVNb3UDlSS1bwF /M6bzUuzGAUrP6Hrli0Go3MccWIV/p3ZW/BdmVayC6z3PBt9E8nC6D1p5+BHjdGfOeSdAYBa0vb ORY3T9vcWHsC6C99UcA1EAivN0bhccB1+5WgMs9iKz+sQRsHXcNHCjtpYqDq4rOydHKGi0roZDA 3cBEPsZa2OqZ5UndcGSSwzNaa+l7LO6rOWkj1/OhLQCIYHSumqZcprVlHGltOXF1H/tNcuC2NRA 6LzZUNBf4TqYpBFJrDvlHziuL26qp+8d/1mdyFObGk8HI71FKyLiY598eNwOl+lNBHay2m+XxVB DtuEA0Sj6VzWVjg0vRmHBENp53qW27AIYOElPyuXJbhjsh1J8gTJUAtUDa75kIuJVZXPZaROTsM ey8+HsFhBDgzAampYGg== X-Proofpoint-ORIG-GUID: cTevPCsA5PrL1ZJfym4PgpNvhZfun5jx X-Proofpoint-GUID: cTevPCsA5PrL1ZJfym4PgpNvhZfun5jx X-Authority-Analysis: v=2.4 cv=NLjYOk6g c=1 sm=1 tr=0 ts=69cc8f8b cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=EWo_CA4GmUQ_SZ-sejQA:9 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_01,2026-03-31_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010024 Device drivers should not invoke platform_driver_register()/unregister() in their probe and remove paths. They should further not rely on platform_driver_unregister() as their only means of "deleting" their child devices. Introduce a helper to unregister the child device and move the platform_driver_register()/unregister() to module_init()/exit(). Fixes: 917809e2280b ("slimbus: ngd: Add qcom SLIMBus NGD driver") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Mukesh Ojha Signed-off-by: Bjorn Andersson --- drivers/slimbus/qcom-ngd-ctrl.c | 36 +++++++++++++++++++++++++++++++++--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctr= l.c index 1ed6be6e85d2cfc0a2b65a5ae24f666de922c89d..b603b9337905438b6c9f5dbe800= e560c864d946d 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1560,6 +1560,13 @@ static int of_qcom_slim_ngd_register(struct device *= parent, return -ENODEV; } =20 +static void qcom_slim_ngd_unregister(struct qcom_slim_ngd_ctrl *ctrl) +{ + struct qcom_slim_ngd *ngd =3D ctrl->ngd; + + platform_device_del(ngd->pdev); +} + static int qcom_slim_ngd_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -1662,7 +1669,6 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_d= evice *pdev) goto err_pdr_lookup; } =20 - platform_driver_register(&qcom_slim_ngd_driver); return of_qcom_slim_ngd_register(dev, ctrl); =20 err_pdr_alloc: @@ -1676,7 +1682,9 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_d= evice *pdev) =20 static void qcom_slim_ngd_ctrl_remove(struct platform_device *pdev) { - platform_driver_unregister(&qcom_slim_ngd_driver); + struct qcom_slim_ngd_ctrl *ctrl =3D platform_get_drvdata(pdev); + + qcom_slim_ngd_unregister(ctrl); } =20 static void qcom_slim_ngd_remove(struct platform_device *pdev) @@ -1752,6 +1760,28 @@ static struct platform_driver qcom_slim_ngd_driver = =3D { }, }; =20 -module_platform_driver(qcom_slim_ngd_ctrl_driver); +static int qcom_slim_ngd_init(void) +{ + int ret; + + ret =3D platform_driver_register(&qcom_slim_ngd_driver); + if (ret) + return ret; + + ret =3D platform_driver_register(&qcom_slim_ngd_ctrl_driver); + if (ret) + platform_driver_unregister(&qcom_slim_ngd_driver); + + return ret; +} + +static void qcom_slim_ngd_exit(void) +{ + platform_driver_unregister(&qcom_slim_ngd_ctrl_driver); + platform_driver_unregister(&qcom_slim_ngd_driver); +} + +module_init(qcom_slim_ngd_init); +module_exit(qcom_slim_ngd_exit); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("Qualcomm SLIMBus NGD controller"); --=20 2.51.0