From nobody Fri Apr 3 09:53:15 2026 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F82346766 for ; Tue, 31 Mar 2026 23:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774998025; cv=none; b=NSDHRYz2xTTxC6d8njZLL7LBiiM/4zot5Zg7X1LXSatbl+4Nj+o037IoCs7TWa43ue9dI2lvxh72RClynoYPu1DaidYLDYvra66fRC9ydaBSPBLF2jEMrk+vF0q7TfQx6VsTNWhafVVEFKMOjQmRWdy6ibxelkdXbHffy2+HaJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774998025; c=relaxed/simple; bh=jpPmDvg4WiegEQM0IYSX0CZC2jP6oj/2V+56GqkivfI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DVOTnDdc3PStWqAUTWlT56VWVKW3LObNySkJlYZ05ULaLm868FHI0EHFqWjbRFQsOmOn5GFbpjtQtmOAnckvCTtbsnBEy6Uvh0qhGqCULV2aryfzbKQ7YPisMuloCGHHw+E12d4WCdl8BFEvy5/abvvqBGMIZ2Phh5YO175qwZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NYMVcQjJ; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NYMVcQjJ" Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-56d85e76d73so602430e0c.2 for ; Tue, 31 Mar 2026 16:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774998023; x=1775602823; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MiThgiHUNvzIUgWjS4Gk6rzIcaAngyxuVqiXsTkuGBA=; b=NYMVcQjJHVojMEkbzkZ0G7vfDXtyOBSS5JshHwUc0YFt131V9cKB7TY/qrfpVXckfg 4VJrh5YnPzHNTXQXq7xRhYuFP+taslUje9hRuCfANRgbputhR+PK1E6Qx+s5cNO3Ehfa JivpgZBYI3iTB4ryAaMyIuTQ+wuU5IQdaMTOPQsqBywfTQsT/J7dERykOzqVAd4H/JpL G0PlaGekkIp312lvrowpr7vuG9XdiLmHFjCbve5GUwu/XLX+/VTmXM9OBcIr40SrWnPy 4FTO0PyYLmgsmcXyaneFd/E0ImF+whDhKhb8CQMvaWDIFb4PTVpX2Tnou/3icJtIyLMO bhog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774998023; x=1775602823; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MiThgiHUNvzIUgWjS4Gk6rzIcaAngyxuVqiXsTkuGBA=; b=kBr6K7HSx2KhvRIjRWom0amkHT/oFzlwyOyllFfmTqCWWxVb+8fgSe1ZI1fJFWGJdg umVfQSPsv/8P3faaIFLA6pc+lyhSe3V+l6W9cToytTLNfRef1+anRY69NPxTS47W1+ZY rowJRy9BSe+DMblPf6dbLPvxovWMLSvYfQx83wHJmPVtCjysjevF3ohHvupr0LtBp6ul 5SX0CpqepqOBVQdcW10CiuRXaRcRzMoKrCQRWoGXxQn7Vdlukdke1xYnyTopgpA2n45s kXG0NGrV6OWcxwnjltlLDsJVH1VNrXwgKx5eFZGQ9Rb/5k4gF/HXy69zBEwVRHSRivQO gcfg== X-Forwarded-Encrypted: i=1; AJvYcCWsuxGWCWiT9zIQ/3k48j9GcAHZolhnHDKhy/Nu8zXOPUuQJT/5gdORViBHbENVSSSw/V8HtRJyKSXXSy0=@vger.kernel.org X-Gm-Message-State: AOJu0YzRVQlUBxk/nGrd1+OnIV/TVz+jaua6YaP1Y9BXHkfKyNLzvECJ 73dgGfvNysz8Msco6QYOui8hhEmITO4+6YnoXJHnuWeasc3rUFONfkVO X-Gm-Gg: ATEYQzw+r7icNmOV0SiyPi/rxJ2ItzAR61yMZlZoKCIaKMqFTO5xulzPrPQYpqaqD/0 qETCi+IbTiP4pw9/NAjSDamoiWsBLxH4WXVuR6QwGk1Jqul8NI5aDvRtXraBuPBWFuQwO148Vqq FNQMp+0sojtfoi+d8KYpa2Sa2WIFFXI5qSL10fIX42SpI3TiwNfMNLgGAF9fC90t887V5i6CBnX qMWJ85FjKpcllAEgH9nDO/rlX1QQWisJCwAAw4k/+AFVHRL0k0sSYaPz9fITtiYhY5fj+RJWMsV EX+rozXzSYEMB7bJ0TfF1zsQNhtr4FEL3bkOUBbS2XOduGnROqvheM5YDiLUPzH2syN/XO+cxWc hPAPCmMHH+iFqMsxSwcBrTXPkb1xG1sHb/QBQ2FhCi6iYUKo6OXf71sj/7w6hQxJkHUzX1Tuql5 F4kacUhM7a6/8pZJBj+UhnJdeVulkCpf0Cvu2ABi0x6ZPhG9as X-Received: by 2002:a05:6122:4588:b0:56b:9b7b:83e7 with SMTP id 71dfb90a1353d-56d8a89484cmr792432e0c.7.1774998022785; Tue, 31 Mar 2026 16:00:22 -0700 (PDT) Received: from tresc054937.tre-sc.gov.br ([187.65.210.13]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d58a7ba96sm13948214e0c.17.2026.03.31.16.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 16:00:22 -0700 (PDT) From: Luiz Angelo Daros de Luca Date: Tue, 31 Mar 2026 20:00:02 -0300 Subject: [net-next PATCH 02/10] net: dsa: realtek: rtl8365mb: set STP state to disabled early Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-realtek_forward-v1-2-44fb63033b7e@gmail.com> References: <20260331-realtek_forward-v1-0-44fb63033b7e@gmail.com> In-Reply-To: <20260331-realtek_forward-v1-0-44fb63033b7e@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Linus Walleij , =?utf-8?q?Alvin_=C5=A0ipraga?= , Yury Norov , Rasmus Villemoes , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Angelo Daros de Luca X-Mailer: b4 0.15.1 From: Alvin =C5=A0ipraga Since we are going around and manipulating a number of port settings during setup, it's safer to assume that the port is disabled to begin with. This is purely defensive. Co-developed-by: Alvin =C5=A0ipraga Signed-off-by: Alvin =C5=A0ipraga Signed-off-by: Luiz Angelo Daros de Luca --- drivers/net/dsa/realtek/rtl8365mb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/= rtl8365mb.c index 31fa94dac627..530ff5503543 100644 --- a/drivers/net/dsa/realtek/rtl8365mb.c +++ b/drivers/net/dsa/realtek/rtl8365mb.c @@ -1989,6 +1989,12 @@ static int rtl8365mb_setup(struct dsa_switch *ds) if (dsa_is_unused_port(ds, i)) continue; =20 + /* Set the initial STP state of all ports to DISABLED, otherwise + * ports will still forward frames to the CPU despite being + * administratively down by default. + */ + rtl8365mb_port_stp_state_set(ds, i, BR_STATE_DISABLED); + /* Forward only to the CPU */ ret =3D rtl8365mb_port_set_isolation(priv, i, cpu->mask); if (ret) @@ -1999,12 +2005,6 @@ static int rtl8365mb_setup(struct dsa_switch *ds) if (ret) goto out_teardown_irq; =20 - /* Set the initial STP state of all ports to DISABLED, otherwise - * ports will still forward frames to the CPU despite being - * administratively down by default. - */ - rtl8365mb_port_stp_state_set(ds, i, BR_STATE_DISABLED); - /* Set up per-port private data */ p->priv =3D priv; p->index =3D i; --=20 2.53.0