From nobody Wed Apr 1 14:04:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B4E3CE4A6 for ; Tue, 31 Mar 2026 07:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774942816; cv=none; b=IS0LAiBN8ZDZcI50HxTwlRFZyKPt2xUKRO54mcA8tqKCu+ih8Sj+VBWxrRDlFnO8Ae0bsKh5idHnxOIENfhGFD0cRmBJp/GjTgNagpWIf+EXl+xLJVtIwpEOrwvVThJVm99uYIiWQo/3pvsJORNnhfCfGzlDb7mF4nezcvlpYvg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774942816; c=relaxed/simple; bh=o9pxdPoJfkiELITVw7ZSpLtjExuHdSfKJ0n0DkpmG+o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LCOlrSQElOH8OG47LiOY7O+Sd0i6av3KgRoGCD+hdYidjy3wj8eIeJWoDvh8wNeEnJ/MT1Uj+zNGsyQ5SHgwLb1NkxA+usefExl8dEmxKTfS5rvdsWknWVeCZkHQCKPFMoAPC3QBR6HaFhL5DUU9jipnCUCYbqfQbSPi3Dclk4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mFQ0Wlje; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EHgkY/Z8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mFQ0Wlje"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EHgkY/Z8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V25hT11402790 for ; Tue, 31 Mar 2026 07:40:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vYxV75Z4wnjwOVaThSDC96yl6BuVtN/GBJ2eo+yQEEk=; b=mFQ0Wlje/IjzSQAV W992CMCSf63T67Bf71/26I9KP2l0miWOncgv21NoY+yIr7e0hg1L8Fkyc8oer9Bl PMrdwVlOU6Tl7txy0SxUqVmeK8Lix0EPQ7Q/54EJLTJBJrpdWmOeI3kWCrL/iOFJ n67fFZKF4cv0Rw2/rzrgOQ2q/fQSvf8UT2XVgTEP5PdG/kogsjrzbrwts0VwG2DC IX9kA+6dmUxINtlis3JRzGT+jS/0+jIxcnEFdVEQ/wj52JmVz/droI0LgE0SnRdL WxZi0oOwtxUgilB8E+EAaVE1CfCh8+A8NxAsTis/vE0PQmo6FeQoYBbcXUlED+w2 D1EO5w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7r4hc8j6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 07:40:10 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-354c44bf176so6988670a91.0 for ; Tue, 31 Mar 2026 00:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774942810; x=1775547610; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vYxV75Z4wnjwOVaThSDC96yl6BuVtN/GBJ2eo+yQEEk=; b=EHgkY/Z8QGbf8dG0rOK8MtfzdgO4hdQqs9TMQYc+uOekj6dGR7P6tWLMAnFenh6tFj Ovn3lpmfU0IwcuAi3+pBux062e2kRj9JAzUZhku8gjjQPgmyy9rxRHHCa8PCiLaH7OsO 0V7b/OxH2SPwHQdINU1YAyiFMRZw4h0axxM6M3nDUMetINql5VjYHP3WUrzBakjSXNTm QMFLE70IXMH8HUNYEKmOtUazKBNNQbYB/nSHOXegVwmv5o2+EpU75Wi3EFkF6aIrF0GH f4QOEXmHh14iJU9SSbJTXZqNH0SbhWs+u9gMoiyHtjrNL6YBM5vuFEpK8Mo2M1jqIwoL BkeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774942810; x=1775547610; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vYxV75Z4wnjwOVaThSDC96yl6BuVtN/GBJ2eo+yQEEk=; b=Vg2Hrd3uiH5/iDfuNjp0ncq6cx1Y0Y5iAndvRPVyCXwRw8EmPPYK+4H9XVAIUpZgYu +upLymGGuVvECMUBrz7HrEOnODGlcFv/LLsNuLPrVvZnWpKq1T833rXV+Dv+Pavhq2ak S1Pj7PJQ8LuMJSERsrXle3zuYTvOWGH7MtwfPqjKNUcQKCBt95DsabvFyHclY0+bxt3Y eyPqNoQIHJk6IEelETYByUwnuBGHs+94yFbZ3vwNl6c7e5F2O/rQjriTgoc4/kyrfdHi dZ+dO9zuDxxpCX2upSXAULXP12fWVgJ5hV3FbXZsGaJbh1TnM+Oaz9FZUSGagCEByCHN 7Q3A== X-Forwarded-Encrypted: i=1; AJvYcCUDZHMm9FrWNBP7VlB5ChyZY5RDiT5Jrc365hFxw4KuStnzT+flCQW1QOR8WlamL5NTohRpucurM+2oce4=@vger.kernel.org X-Gm-Message-State: AOJu0YzLdC2zBhkSBVapuxdEWiZ66EjiwjcDIjuOt/5TPP1KOxotNSKQ Oo3QugcSvpl385H640z96maEC2y2eXO+OtnQKhiY1ymPNDC8a8QS+iPbUJ5JxGIYSNWL2r+PVUC 04ifNbbQMODeBzul9+jQxGWf60ASoIDjgiv7ILXGT67dPgJlJVq7h8K9KlBzmQdCpWFaCOHQHVR U= X-Gm-Gg: ATEYQzyjys3B37i/LsPEJb/vqzHo78AKiNpUg1skJugG13lZNxkJfrY6uKj5TKFQ0Xe jxGaD+Bp+Y/h9ApPISrDr9JsHh6AwdI7uumSHiaQYSbyPM6FJQrEy8wWIcfE7LtwmQFoqz3iRb8 W6l2Jn9dKDM5VL2/gVSwVniX7ISKEc/LwH0KzAZqKIHv1ZpJRU8RglnBlAqzDVW9717C93tV2dV FDYMoVQNy9bQxcKjMxE4/cD5focb4MdMljgk3O19WGCCDNM1sPV5N3VYGptzsxONVWPAPsxFOfJ pLaDg2CywEfBE4Enep+N9W3fhboCO9BRXaht2xveC+dyzvXtpHxMVsxyc81xJJIAwHOykdhbTQ8 8q5wbgX0lETraI3qfaukPRfRiZYn9r+GYdQKAgEFjNlL+jFXTdDOzNVf++iY= X-Received: by 2002:a17:90b:2d90:b0:35d:a2d3:5c31 with SMTP id 98e67ed59e1d1-35da3e1da37mr7569994a91.29.1774942809782; Tue, 31 Mar 2026 00:40:09 -0700 (PDT) X-Received: by 2002:a17:90b:2d90:b0:35d:a2d3:5c31 with SMTP id 98e67ed59e1d1-35da3e1da37mr7569935a91.29.1774942807799; Tue, 31 Mar 2026 00:40:07 -0700 (PDT) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76916baab6sm8013076a12.2.2026.03.31.00.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 00:40:07 -0700 (PDT) From: Dikshita Agarwal Date: Tue, 31 Mar 2026 13:09:56 +0530 Subject: [PATCH v3 2/3] media: iris: Initialize HFI ops after firmware load in core init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-kodiak-gen2-support-v3-2-958296fab838@oss.qualcomm.com> References: <20260331-kodiak-gen2-support-v3-0-958296fab838@oss.qualcomm.com> In-Reply-To: <20260331-kodiak-gen2-support-v3-0-958296fab838@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dikshita Agarwal , Bryan O'Donoghue X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774942796; l=1626; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=o9pxdPoJfkiELITVw7ZSpLtjExuHdSfKJ0n0DkpmG+o=; b=YhtbDfKazact3rpzFkaBQzq06718OGM0mYT7j51SsFDEOAsb85TkzJJMAyBJqhlifjdvNbnzq FPqawSWsSJPAdr+7wH1zOVEs8s14fC4fmIHnWakO2ax8j68xFelT+Qa X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA3MCBTYWx0ZWRfX4bCwki/5HP14 pLz1iJnlI9OQ0Ky4fW3LUDA0rodf4PDpOGkP0MzSCuTEB5sXoGS8taQmYEZtpl/IxQmoWcgR4Iv 84AOl7C/5oSAG/6tSrycVOEuppVbM/UjJjO50qmuElYMMNTf38agwH5uaKe119A2YPiF3DdKrGy 35QGfFd8jsKy+RCbNj8uwVmg4TBqsB24rjO7pJc6/ql4e9WX4DSJhRfKRsXvwh/4AyWFCZStzz+ JZN2SgzUIC1/gwUZ8/+JPGUiwNYaWPkGQkjbEzKH45kTlmjauU3XwCBnrHvAvNdoYMYKQ5O4WjT Jbd3aOVYbbAl6ML2smnWu1r71CDcwLOvSDW+m3rLckpwnev9l6sFhGjryZriQH5xDxDRznufKfc 5E2FV4ZYtuH5BnOmyPzqp8ETPtzM0ohfqgdecw2D2+i1FMw+0ML3wLFmVuSARzOIS7hSWjJcnMr NfHJaq3j6FYC7iPWWEw== X-Proofpoint-ORIG-GUID: RVBKFePw3jbx97Pvqu-o7tUenJFEBm8p X-Authority-Analysis: v=2.4 cv=PI0COPqC c=1 sm=1 tr=0 ts=69cb7a5b cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=u1mmxsKKFvk7TXqck8YA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: RVBKFePw3jbx97Pvqu-o7tUenJFEBm8p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310070 The HFI sys ops were previously initialized in probe() but, we don't have firmware loaded at probe time. Since HFI is tightly coupled to firmware, initialize the HFI sys ops after firmware has been successfully loaded and booted. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_core.c | 2 ++ drivers/media/platform/qcom/iris/iris_probe.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/p= latform/qcom/iris/iris_core.c index 1f326f696d08014f5ebfeb0b99cfed70665fd6ab..52bf56e517f91e98569ee029861= 83971266e1c76 100644 --- a/drivers/media/platform/qcom/iris/iris_core.c +++ b/drivers/media/platform/qcom/iris/iris_core.c @@ -78,6 +78,8 @@ int iris_core_init(struct iris_core *core) if (ret) goto error_unload_fw; =20 + core->iris_firmware_data->init_hfi_ops(core); + ret =3D iris_hfi_core_init(core); if (ret) goto error_unload_fw; diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/= platform/qcom/iris/iris_probe.c index d36f0c0e785b7de0e3527e0a824942db0fb79133..dbc15edc602b72fdec8bb2d8d36= 23676afee728c 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -266,7 +266,6 @@ static int iris_probe(struct platform_device *pdev) disable_irq_nosync(core->irq); =20 iris_init_ops(core); - core->iris_firmware_data->init_hfi_ops(core); =20 ret =3D iris_init_resources(core); if (ret) --=20 2.34.1