From nobody Wed Apr 1 09:46:28 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E20E30F819; Tue, 31 Mar 2026 17:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976889; cv=none; b=eZ1jkZPoiNowxwbuvZJyCMKClgqgP7jqSFS/WTBJbaThmld7KIzT4McxP1sK9rdwnFUvynvA4c5RmYnfqfAP/jql1q7hBspfKgnral2TycqKDNy8Y5DNMKhb+pSWcuVfJeHkzsL73QKdxNLSUSPWutUgHdJCyPKv/2A/JIZ6vJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774976889; c=relaxed/simple; bh=lMmS7VKj6iu0kl1/nj5vjFiPjTrbee5i9kEgoc3RpKI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XtFUJJGmAuB8G+HptLLmuJHIaO0qfn2iZxSRiPcNAvF6gj9Eaf6kEaFAU9IkjtGt6W8srifOC9P0R9XCEPioB6zmOpzzBckwVzZyNRGoEG5Ft8I0mXszXHwI6qR/uRqEstihIBZcJgDUVXbvtxq9ctB6EVbM8qQ25lRvdOCm61w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WD64jzEN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WD64jzEN" Received: by smtp.kernel.org (Postfix) with ESMTPS id D251DC2BCC9; Tue, 31 Mar 2026 17:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774976888; bh=lMmS7VKj6iu0kl1/nj5vjFiPjTrbee5i9kEgoc3RpKI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WD64jzENwzJ9GW18p/TjvNYLnyWlBlnKKsomtnt0AbEVGp86dFt+HLQoZ3mgzkcrG KUB6j6DKcg3F+tz7PKnZkWOpsGW5+QcQDhvHPFqUdGtldWnrZIrnBDLr0Ks3vaagO8 qR/hyGX6hPhX3nPgMJKUQmo0W5nE4ZM4FLPhxcjJGEAtTZH7HUJh9b8zbWwCx/GBwq 4/fgQSKtRiuq9OkbJKTFn8OrPFZCZPELHxPIUj534DVteJxdHaukkJhcivH8KuapvO HzpuogBWqEsz9EFCn1cUIyio5HqqMpXF4Wk9iBHXngJ04GuKnZctF3HW/td/djps/J mh6Cduulbbz2g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78E710F92E0; Tue, 31 Mar 2026 17:08:08 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Tue, 31 Mar 2026 10:08:09 -0700 Subject: [PATCH v4 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-expressatt_camera_flash-v4-3-f1e99f474513@gmail.com> References: <20260331-expressatt_camera_flash-v4-0-f1e99f474513@gmail.com> In-Reply-To: <20260331-expressatt_camera_flash-v4-0-f1e99f474513@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , David Heidelberg , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774976888; l=2830; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=07mZd8vKTRbtfL1Tn6ze8Ye/wRA3griixRoQWefHTH4=; b=KpzdD7c/VobQZ+VbR2jDO/bg2Nc45RUxuWo803tkF34FzOoJF5ot/UidlT5cdE3bUpLuvdOfr 2o3Izz8n+KLDxEd1SQ9Ew8DIZBneDFs/Ta7tdtAIFAesy6jKtXnXRp7 X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Add camera flash support for the Samsung Galaxy Express (expressatt). The flash IC uses a one-wire pulse-count protocol on GPIO 3, powered by a GPIO-controlled fixed regulator on PMIC MPP 4. The regulator is modeled as a regulator-fixed node and supplied to the flash IC via vin-supply. Downstream references: Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/drivers/leds/Makefile#L51 Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 Assisted-by: Claude:claude-opus-4.6 Reviewed-by: David Heidelberg Reviewed-by: Konrad Dybcio Signed-off-by: Rudraksha Gupta --- .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 43 ++++++++++++++++++= ++++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/a= rch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index c4b98af6955d..35514fd53e3d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include =20 #include "qcom-msm8960.dtsi" @@ -61,6 +62,32 @@ touchkey_enable: touchkey-enable { regulator-boot-on; }; =20 + vreg_flash: regulator-flash { + compatible =3D "regulator-fixed"; + regulator-name =3D "VREG_FLASH_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + gpio =3D <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 =3D <&flash_led_unlock>; + pinctrl-names =3D "default"; + }; + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&vreg_flash>; + richtek,rfs-ohms =3D <16000>; + pinctrl-0 =3D <&cam_flash_en>; + pinctrl-names =3D "default"; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + i2c-gpio-touchkey { compatible =3D "i2c-gpio"; #address-cells =3D <1>; @@ -172,6 +199,13 @@ touchscreen@4a { }; =20 &tlmm { + cam_flash_en: cam-flash-en-state { + pins =3D "gpio3"; + function =3D "gpio"; + drive-strength =3D <16>; + bias-pull-down; + }; + spi1_default: spi1-default-state { mosi-pins { pins =3D "gpio6"; @@ -572,3 +606,12 @@ magnetometer@2e { /* TODO: Figure out Mount Matrix */ }; }; + +&pm8921_mpps { + flash_led_unlock: flash-led-unlock-state { + pins =3D "mpp4"; + function =3D "digital"; + output-low; + power-source =3D ; + }; +}; --=20 2.53.0