From nobody Wed Apr 1 11:15:01 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE1B342314A for ; Tue, 31 Mar 2026 15:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971851; cv=none; b=A/cM9hgjq4sEI58jLoCkjgsubRIKhiopWOq9tolwIHE9SgFh4vFXOEUgKftVjhkaU0E4vCG3TwAkxb34moWmQTqS4bGCjICn1H7uSmSVMftP+2HkRXKwODwUKVecty/Kt74qSDrC+NtzGunSLbomE53u/apZ1DZpPrbsHrsrCgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971851; c=relaxed/simple; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kj3PvIDKVqfqyepEABllDrxA0Kwsc6Os1yD6DvBraKyvHqy8QGdPnkntE8mFZWqgVQKp+u//qImyxVWdjyQ/oEsorUix8NJj005s7/3vD1cpDeqecIxHQOi6D83nGW1DcAOOsauGhRHN5ZH4LhUq7iqLPB99PkpO3woCvjaThCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=gcjGgUu7; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="gcjGgUu7" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so49702505e9.0 for ; Tue, 31 Mar 2026 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971848; x=1775576648; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=gcjGgUu74+HcPcTyOi3RpUvw/uvDG5hgfiTvbEBW3FkGnfQC8Z0bvbVWKznNHCWcp/ mNVMv2jw/NMQnTstZx4XUNbHOhQ8HmX1YsMFKpVPO0zqvX3ol1IB4+R27W9AOiI/sWqD BMHSVN2pEDHxPhQKmbl3OHvJkuWIo6wsorK0zohlaOI7WdfMmxFIDExYmLtSksAouujC 2VmsN2XsMlyvLCqN/0U6m9tSLG6IN+sC/62UKhzJM39k+clUYDgn8RDdZ88GMyDLQZHw 0NFlNv2pLef3v0BxY14icfsxwNETSgZrSAud41M2TUC2nJ24HC706IHpW8ODhANlvzD1 wUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971848; x=1775576648; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=OlKp4mxrHnVqKRYhADDOjmPGjzfLyNc8bpg2FsUzMpdv/llkD2GvQqepzC+cRanhtG qB1nBJi9wcl9gujaUbF8J2qjxJue1dtjLL669CcDzLxD/v0fYDOc0+ThnP5DzgarjTo9 zDdhyRFPedan+fqWtGUw2cPff1aVfrfpQqlv+T7kIrOG0oijWc2VBLc6pr2H5N5OaE5B ZGsTuO4cKjVNiRT8f4t6+C3opuugYMa0nVUCiunIO22MXTXE84YHKBIbREiReSyph8o+ xBLuMrZE54KAhk/wkWD6jCaQlTUcEzttUnD4NhDXDS5DhU27L5bICJhjpYl3ok1XoTq6 VfYg== X-Forwarded-Encrypted: i=1; AJvYcCVETdQRsfAO14n+rlEllOZsdEOlmXu58VEIXtn5FPQc0oe47GWN2qwaMgWlz1+01Vvh7fHrBAJZeRfswwc=@vger.kernel.org X-Gm-Message-State: AOJu0YwH3YmzgQfQwgvqUFTV5ZutTpV9ePPd5HvJEQnXxCz/dj+dMlCh Uihw1BBnwVZ9Bq0vnkEVs9f5z3oLcwVlQaPvP4oF9pl+OyZ1/DpXWgmLROx2j+CmmZE= X-Gm-Gg: ATEYQzyckBJgPCP26IYTzQYFf7K+BKWKaluTxbypp5Q1On7drzu/aH4UFuDNx+HVL2v z8f1Wu4W2Zj5ZW4UqqlZznXqe3EeRV0mAbX5qFxq22r3+dQld5Jr8te7GjxnOsBq6ZOV0tXiJ5J tIpVvx2WxZ6dDA3blle9MHs6RKx+VJVCblkhsiFyCXqtLR5DsLRL1SSxSF2esIFCNqlKux0UMBn sgWhm6gG7K37c2LGdIVKEvJ+G//cS5BfkKHTnY2nzrfaJHE8y0g+4mBrM0sRxOktxJCPH0sfF3r rQusuei96hfETWGxk7nA65yxLCxzeqf6qI1hy5oA+Jrlv3c7Rtq9eA4lu6aclQzLV4granB2xAM LVqHWuDHadEw51qP68U0BYtcH+4XWvqyXhY9w5uCQDfCqs8weIHqodL6wRG82KAj+n2KfsuQTZo XbBHg/ovYicpf9bwqAYJYQB20Y6Xt+5KrgkhG4qUydpzp504vA4zOLfMF+syWIoE/y5wA8YGrjy Zhxhw== X-Received: by 2002:a05:600c:45d4:b0:488:79a3:f04c with SMTP id 5b1f17b1804b1-48879a3f26cmr61666005e9.27.1774971848032; Tue, 31 Mar 2026 08:44:08 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:07 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:45 +0400 Subject: [PATCH v6 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-8-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=alchark@flipper.net; h=from:subject:message-id; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3e/5L0mRfBFafkf65duuv2+rO7r1a57Cqo+xMje P/DIVZZn46JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCmuuMfI8N5s3DZXKHF7Cc2LG3L2ik4P68hWvH/fc0otrNLlr6MSgxj+GfYW6f R2HZfVbKFQ4dV17zy5bMc26ULMs5tYok/MX2WDCsA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 0765673728e4..9c082865e745 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -54,8 +54,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -71,8 +73,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -106,8 +110,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -478,14 +484,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0