From nobody Wed Apr 1 11:15:01 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D5E421EE8 for ; Tue, 31 Mar 2026 15:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971844; cv=none; b=tyIlusBDHAT1k/gWOcxmMdojBFc+6FwOoMXhADnvFHfnzqlUDAgnsC46dVumNVrc+fD9JOKcVP38kbNoN8yoFAOr4uN9Ne056beeo49f2wfY/JDJqJnvesmZKU45Br1N8enB4tJwfsZ015fvJ+I53aIU6Xyi4R5qqq8io6tbESk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971844; c=relaxed/simple; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ppB7av+gVPmSY4yMfwmxm1nZQ1C4iuCX2Eb2CO2gh9+rDFScl1+roipGs7SJQXB6gBJs7ZXFQBIEQQPE/oT39HlJTu3a5UvCGetF1T4F1v6N3y0EENiKQSrav351r3Ba/9RXrRnl2bp5nfSBC2ZAnCtJgDTCUAnM8qH0tArpJgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=IOblLjR7; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="IOblLjR7" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so79355e9.1 for ; Tue, 31 Mar 2026 08:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971840; x=1775576640; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=IOblLjR7HQd71W849/IK9hJ6liawmOg+zs3cacx0vsxLrWpHxEKTJP3Q1VlgwEddBQ 57cCJEJYHr+qT0/HV5drJuRhCrWHKVY0H+a4hWazNcQP26VgW6RYhR4vTnIZYKVb0RrM NqMM8TV5ELdLF8ujsONhClD9tQaWKuJNd/3AI1YB0prpOnjlirEZ+7GfYipWSAIh+Nyv c3PXxjTi7YTiiTUKUD5uSQpYHDs84t2RI5O4bk7QiiJ+Xo5YuADf2Qt37HXDpAEEJR5N 1+2ZOL61/G5DGRa9EPbX8roNIT/khWZP621RxIylfqNt1XRgL4xOLKVh5nKxQ+sEgODR fv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971840; x=1775576640; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=Y7ljm3gaA8da4yOPogQuHLKkSxEP9M1x83bk52poTMGSAL/MsuptKNQKYZo7ox4PuU 7onysAY8qdAK0uGFta5cRKXY2YNGEQEJNbVuFsaG7qaeIL3yTXE1cU8JD0WuKLCeAY3C u8sbddsg7R9D0Gs+oPrm3W0DybwKuQ3Z9gFgF57a8z6quO7dURwQFvAQjA0GnHjS/A+k mre2+cgXzOjguCVIG2FoZkHcJgWkMsCouBS62fA7DJMIL82CP8V+EojTF9MWrqZzVP55 fuHaaY1BgNz/SgSyyxCQqSSS1gPp/Hm+OP9v5UYIf2nwbXuxFtwT4/8YVsIaU/qBqbab NGsA== X-Forwarded-Encrypted: i=1; AJvYcCUWsXZ/pRSMuxpzXOY6qTm//IJEvWndWwkh4JGID101diaFjlAMWeQY3nBxYbZB0TUjCCjI5ABhSpmjn+c=@vger.kernel.org X-Gm-Message-State: AOJu0YwbOqugYE5nLAF+6GanQyG5Qq567TCP0H6V30TZR8vgi2/VnVEo Cmg8Pnv1nPghI7EP/qG/mY4iLLPh0T+ocNa6lhm6ajNA6Zt8/ROAxyCkWQGaZU9rl+U= X-Gm-Gg: ATEYQzwCIKZVExmtbp8NN2ZB+qr9BDIpl1qR2Y8WKtWEx+JfLNscEsfXrgAJHxWYeNJ Ol8WudCPSXW+xy8ZbXCrQX88+2cPhKnppk3axjvsSJN3ZuXh0TLMZ7wFfjDQV8KlpZNIrjGFYzp 8vl2EG2bmxdU4DPWFHzick3bcheTMkQl7M+r5dBHliNmLqe6zQushQFEWttxZ8rdiv2Fu4wf+4U iqLKE15TgGbfaKaFeiqmHuCHvgbrt1/QYzDm40indBatZ6JGzcwy0Pnk8SGcKaaL+LvNsve6cDN DdsB0rhiENX5gR9N5XsMrAOc4eElbibnmMO3gQRkMn8s2ijZ9w++YsrgQPK3FRughX3/LyiElt8 1cymrhBlqQg1wPqH4aURsQGBg69a0/t4JacKm3I1VMY6Qmh5PGCqIYwXN5ul9E54PTxXdoESHFH /G73KiHr3IEp9eKoh6qO+C4sMQ0HgWc4vvaD1dqNbd7j/7IoKcRyPN+WdyPfEeUDTvAvTSgj6Hj E+Hog== X-Received: by 2002:a05:600c:8907:b0:485:fbd2:f72 with SMTP id 5b1f17b1804b1-4887818678emr52899635e9.1.1774971840282; Tue, 31 Mar 2026 08:44:00 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:00 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:42 +0400 Subject: [PATCH v6 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-5-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=alchark@flipper.net; h=from:subject:message-id; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr0+sjLgRVHOB6OerPmLpvscZ0m3erZk50a32q+Xl yo03Nwxs2MiC4MYF4OlmCLL3G9LbKca8c3a5eHxFWYOKxPIEGmRBgYgYGHgy03MKzXSMdIz1TbU MzTUMdYxYuDiFICpjgln+M0aXljvxlI0N3xyguz3uHsTJTN+HJ7//cK3usm3Qg++kY5gZLiS+zs /qOGy11x7lmXyqpdNzdx0xS7I9GmwvF58e7LsHm4A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0