From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B4E413258 for ; Tue, 31 Mar 2026 15:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971833; cv=none; b=L8BoIDdHtGaExxo7TL92RvNVoP9tAuR62SinjxTvbt2d2HJqhpC6fV6iKwtwTcQiQhi1222wknCMS5gtOH/6W88uumK5Mm3JKyEo/6gZk4ul+3hpd9JibDcfPprUeXdAIBxOwV35zlFAhWS6VZ5Ut0zck0lVH06za2Vs0ipNy68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971833; c=relaxed/simple; bh=Kch86XWLNpsoWXsiUYScxG9+qZq2PDWJ+mVUNiuprdY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=V0/eRPmG884oW/Lfe9i3PxaZz85XpAFWQVRDubE1B48hpFZsVcQLYjoxWAInd+N4RNNtJtiIVFW4aN7ewoQx+Dx/d2dYK5zMoiNGEx+zwlV5y/5A8wq+2QrvuL2XSX91RuYB2IcRube0UlFJp4JhD6eqkWXc70llukNgGnpUKLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=SBJvd74k; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="SBJvd74k" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-486507134e4so66854195e9.0 for ; Tue, 31 Mar 2026 08:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971830; x=1775576630; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a3tePfAp0V+6zfOlKlirFvJa8IZ0hYoxL5FVcQEbR28=; b=SBJvd74kiLcY8RlHk0XC95rT+rG1H/QJ9eHW7mLJTA0jTELVftETWRwBap6qGGLXoo 4PBwA3vp4pWlSncXJKmaUVe/2a73AGKBjzvfwp68blpMdtPDCSbIQp+CWzvL1mbKBYQN 11zx1de7/JalUwkugmfoxZAI7NiImHnfKPlXns2m2Sh6s5aMccqedPC6MJYThPrQycCW JxTebjlsBDgQ+bhlZUsJkfc18li30ASnQv14+dqifBt0m8taAVX6UFoseXXb7R1hE3dx YZonYaFKgmAnlZG/N6P9flleVgxIfTAr3whJp05NzV9H2eHM13oDFhzMb5aJ+HO7KzhI 4YkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971830; x=1775576630; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=a3tePfAp0V+6zfOlKlirFvJa8IZ0hYoxL5FVcQEbR28=; b=OR7Hi1evwHFfCtmRaTACRSkrg5j914mLPHZYoaPV4iVKUfurAgIhbYkMOnwj/uRmOl bTSqYoGOmwwpHOOs3aNPNANXzx8SlusaV0cVM5EBarBp6xHtA1+xUlKaux4PFT1POcWY zIR93398TUXDwR3g0u24H+NRAeXZ3hF+/9r+cUlrQGpgYK/SZdWJg9zZu+JCZ52JwDTa uDoJ3ZaxaMSfjLq9fvqSlxNhkUf9+ZyOqgObf8JpwgdYrEPSOwu1haxQyEaZk3Stw+Yf exbDOtesBE7HDDJ495sn/reCIeMbvBauerBZQy/hS4hmQwIV6KwST0pb8fen/tFAFqrU jfCQ== X-Forwarded-Encrypted: i=1; AJvYcCU8Me7jWZDHZ0jqWzZ1cqlDHe/CBL3Y8vbJ6tHmegHHdj7U5sqQRgH2U2qzvkxZbv+uCFlFhq/0W5f7RgE=@vger.kernel.org X-Gm-Message-State: AOJu0YzMi9ooREXOWr4Rhr/pOhITLX2lPPXJ2uo2rpdZ0/8HOdqtFqCl E09u4tglSHMENkI4SjhQS3695Kq5lxZ8Wdaxe3mfOLIZyLSjw7yJvdaWBFqBC4PxRjE= X-Gm-Gg: ATEYQzwAeOBnJj+xx76ZsPR98MkYcZFHWjHPVWdiZIyKaIvzwfuMeFOv712BvceqfwF Vlhg714X4nzrTajd7toAZv+QXaZIUQIzsY0azUeej8Xtr684sD1kYuBgErDlPppU4+YRcxowD/6 zZPTsoU8yj0oreHpIP4g1rEAppUYh8qRczraWrRwgLfc+qHsqwMuhi2lhlbNqmR51gMvSp3cKgb HVlg2lMEPFGLSlbqXoS51slvXmi2QOfPkDFjAubMuohYhUx047w+4kD4nAIcssw6UqmkccRdXf3 HVXJuFvRxqKiPvzU0vIBxdtXtwQptFnc9xGqI4U+LLWng9IAkgSmYXBA8tbPVbpoTYs/c6JxSvj Gz8hHCr7dOFCiyZbXF7TLgGev+6X2cZAuDOxhr4MAO/QIbvua2dEdflX0RZiCwqVQ5UkWqAJZnH LWToiEBakx3cACwR+5Np76x6wNr+nTHJ5c6xAfwz8nHDaa5X9WW4tDRSKNFF6TtBBCAy+G4JcLX K+lnwoYby7pV2wL X-Received: by 2002:a05:600c:3b27:b0:485:3aa1:a7f1 with SMTP id 5b1f17b1804b1-48727d5a252mr294923335e9.7.1774971829849; Tue, 31 Mar 2026 08:43:49 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:43:49 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:38 +0400 Subject: [PATCH v6 01/11] dt-bindings: mfd: ti,bq25703a: Expand to include BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-1-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3922; i=alchark@flipper.net; h=from:subject:message-id; bh=Kch86XWLNpsoWXsiUYScxG9+qZq2PDWJ+mVUNiuprdY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3edDpbxWsjpTPhaqe2KMzNvBRvXLWtwtxa5cMFo w/7GL3/d0xkYRDjYrAUU2SZ+22J7VQjvlm7PDy+wsxhZQIZIi3SwAAELAx8uYl5pUY6Rnqm2oZ6 hoY6xjpGDFycAjDVeSqMDOftfsW83SDvWNwUMOnUhAVe0n5LRE/7ntH2exdflL8q7ATD/5BZqY3 BoRJKf6xn7ky5/DvF7s36NQXSt55t6VPN/dLMxgwA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 TI BQ25792 is similar in operation to BQ25703A, but has a different register layout and different current/voltage capabilities. Expand the existing BQ25703A binding to include BQ25792, and move the voltage and current limits into per-variant conditional statements. Reviewed-by: Krzysztof Kozlowski Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- .../devicetree/bindings/mfd/ti,bq25703a.yaml | 73 ++++++++++++++++++= +--- 1 file changed, 63 insertions(+), 10 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml b/Docum= entation/devicetree/bindings/mfd/ti,bq25703a.yaml index ba14663c9266..cdce83f05804 100644 --- a/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,bq25703a.yaml @@ -4,17 +4,16 @@ $id: http://devicetree.org/schemas/mfd/ti,bq25703a.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: BQ25703A Charger Manager/Buck/Boost Converter +title: BQ257xx Charger Manager/Buck/Boost Converter =20 maintainers: - Chris Morgan =20 -allOf: - - $ref: /schemas/power/supply/power-supply.yaml# - properties: compatible: - const: ti,bq25703a + enum: + - ti,bq25703a + - ti,bq25792 =20 reg: const: 0x6b @@ -25,7 +24,6 @@ properties: powering the device. minimum: 50000 maximum: 6400000 - default: 3250000 =20 interrupts: maxItems: 1 @@ -57,11 +55,11 @@ properties: minimum: 0 maximum: 6350000 regulator-min-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 regulator-max-microvolt: - minimum: 4480000 - maximum: 20800000 + minimum: 2800000 + maximum: 22000000 enable-gpios: description: The BQ25703 may require both a register write and a GPIO @@ -74,6 +72,61 @@ properties: - regulator-min-microvolt - regulator-max-microvolt =20 +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + - if: + properties: + compatible: + const: ti,bq25703a + then: + properties: + input-current-limit-microamp: + minimum: 50000 + maximum: 6400000 + default: 3250000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 6350000 + regulator-max-microamp: + minimum: 0 + maximum: 6350000 + regulator-min-microvolt: + minimum: 4480000 + maximum: 20800000 + regulator-max-microvolt: + minimum: 4480000 + maximum: 20800000 + - if: + properties: + compatible: + const: ti,bq25792 + then: + properties: + input-current-limit-microamp: + minimum: 100000 + maximum: 3300000 + default: 3000000 + regulators: + properties: + vbus: + properties: + regulator-min-microamp: + minimum: 0 + maximum: 3320000 + regulator-max-microamp: + minimum: 0 + maximum: 3320000 + regulator-min-microvolt: + minimum: 2800000 + maximum: 22000000 + regulator-max-microvolt: + minimum: 2800000 + maximum: 22000000 + unevaluatedProperties: false =20 required: --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF2641B36F for ; Tue, 31 Mar 2026 15:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971835; cv=none; b=sG6pHH96tdaYwN5GNVXZTAR1AqETrykp+VuRVQ17jDUi35tOD1A0YJoVUanyaRaB4cgexcJUoxBEoTX0pfZBiXqN/UCb04ByQUnfYrzYeUq7sA5uw2hwcgzMoXXiP/CLIyOjb+6SYIUYtxf4gKRvNIK7wEJzKXAMzWEQbmGn+UU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971835; c=relaxed/simple; bh=DcG8KW5Fnk3rc/f7uk3dyHKO5i3tnn1nAb2IeSenCzU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=csqkrKOZv3wMDQcqLRoiKD3TnvFJ8+DW2NXRPZIkIKP45wc+0yzD0eg0kShhVI/hVxaNDIDLV6vc5DXZpfExU2WhblbnZo10UCcX40GrAUYOuFqf9yJ/o1WeIq6yvmpnyCiU8IELSjEhA7XzyXpmIfaJJ+Zln9X2Ee7mUGw9AWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=CKE+UWzQ; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="CKE+UWzQ" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-486fd3a577eso53954855e9.1 for ; Tue, 31 Mar 2026 08:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971832; x=1775576632; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jCpuZJNVNsInRc1C9w8uAr8XhXxWVpiElBj6DPaFINQ=; b=CKE+UWzQ99gN5vRJddsxigmoPegNBzL9eS3NZ0nRxxt4pPYgBvWtnXFL95th3A9PWr PbQRQPL0IfOHx2vOtdM8LjzKwq9nW3JRBVMG61j3D2XAXEHo3dj4nAX1YHInuMTbdUQ4 e79vjb0TB4n1Q3HFEJWHePMVzwcV17EaWMrduCWkBJc0rNSdnKlPEkM/JGkiJ5lOTVOt +JDxydXRCYy29ekpOUKZC2g15lvA1d8hYEey1W2peveJkJb0XEV1ibBt/UFBAe5ll9EG bVJ813YOQrplb14tFOTmBmb9SGC7qcfufiSxbdvfPGnyshNScdu4be1418TV97wA5f0+ fTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971832; x=1775576632; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jCpuZJNVNsInRc1C9w8uAr8XhXxWVpiElBj6DPaFINQ=; b=UOtLT+/K/C7IFUvR3gaDVlp/iCV0QbdOfLSFwzDKcWP+IxzKEg3qM9Kzz0d5W+WgJJ Gp5eYtUmAS5T/0Ce8TBbo9/v/CgweboaQxKoeGFWubxUTcMvh495VHzkaCjvoLqvRmPC 9kRbEYX1h8IW6H1mWXvw0yZl5136MDzgNhs5RLErIVmQ3y9lDro0D5k73ljYhBCRAg8+ ShGpEeq2xI2UYDO+XJdWo9GwL8iDf3FVATvOx52PuNJqWAiHoi7vxgm0WpoMH37ZCJHp deXQPA/Tq6riW0uG2CUmnwge5eqd5FbLRu7CFwIpfeAe5j7+wQjV+CFEcBEJOg5dq1JC sUOg== X-Forwarded-Encrypted: i=1; AJvYcCUh7D5LeQtsDhEHw+8x9op6zfWXDgYerJuHhNKqEayOZna78ExdAbYCerSCSQGaIaGKyzlc0wTRXF4BdaA=@vger.kernel.org X-Gm-Message-State: AOJu0YyISXNeyzdAguQ9U7eN+HPWWyUTYBb+owIhcpsrgs4hGvs3+uvO DexRwH2x13NZZ7hHcRpaE7L6i/Ww335N4+uvYVNG651Ih44UmfVR7Utsk9QIkNrqXYk= X-Gm-Gg: ATEYQzyEvjGN/ETO8IQb1pDaaSQHEP+QgUEY4z3+4ycwaUvkwKV+OAkyyjotUIWz05a xCnh3YLpCBKH8mWAt6k7716IhUJb4tN3G2xeQFWgZWGV7fpsxLYExertzyx4pB2iAMXEuJ7MUJ7 mHgyahSYr8DyPrPaEffmoZjYr5QTDPbfMO2cmbSzPMowNR4qsz1kMrNG6Ah/r89n0InXRTSARaj 3Kcv2JzYi8Kttj9mhUTiyZ26zKBXroWF+nVLdeI1HTjbja2RbqMD+yqITsNbSHr3Xqj2lSWTgg7 rhF94nHDvTT+xAhr9ynMEhGHxJ7M86FwLJcJfcRe2E4xZBSsMukYqeTo4fCaTAWrpiDY7UcLnuJ idRDe5NIhCcWastT5QusaXR/l3GO4Bru99qGnsf0xnpnpyCup+bzT6/lc0YSDGMY3xxSRi/E68n Rhe60BZ9Nz+J+jLCOySso1kxvGuR5Cbc2k7reMNv1KxY8zhkSHRkJdN80wT1iOK7wnh7DoIgvRF l1xaQ== X-Received: by 2002:a05:600c:8b03:b0:486:fdca:ea8d with SMTP id 5b1f17b1804b1-48727ef5550mr313707345e9.25.1774971832370; Tue, 31 Mar 2026 08:43:52 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:43:52 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:39 +0400 Subject: [PATCH v6 02/11] regulator: bq257xx: Remove reference to the parent MFD's dev Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-2-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2756; i=alchark@flipper.net; h=from:subject:message-id; bh=DcG8KW5Fnk3rc/f7uk3dyHKO5i3tnn1nAb2IeSenCzU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3eoZmnxr1uHUfSjQOZkxNdw5t49PYXfFsTlvop7 ppd4i3zjoksDGJcDJZiiixzvy2xnWrEN2uXh8dXmDmsTCBDpEUaGICAhYEvNzGv1EjHSM9U21DP 0FDHWMeIgYtTAKb68zKGv5I59o+fSuka2CT/vcLMMWnipG3bujcdWPVUrGX758ucZ1QZGZ7MyvQ 5f+lS9kKhJu2/GT0WK5rutN+8IPd+6+w3GhPcZ/IAAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Drop the ->bq field from the platform data of the bq257xx regulator driver, which was only used to get the regmap of the parent MFD device, and use the regmap from the regulator_dev instead, slimming down the code a bit. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index dab8f1ab4450..812938e565e3 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct bq257xx_device *bq; struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; @@ -23,11 +22,11 @@ struct bq257xx_reg_data { =20 static int bq25703_vbus_get_cur_limit(struct regulator_dev *rdev) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); int ret; unsigned int reg; =20 - ret =3D regmap_read(pdata->bq->regmap, BQ25703_OTG_CURRENT, ®); + ret =3D regmap_read(regmap, BQ25703_OTG_CURRENT, ®); if (ret) return ret; return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; @@ -40,7 +39,7 @@ static int bq25703_vbus_get_cur_limit(struct regulator_de= v *rdev) static int bq25703_vbus_set_cur_limit(struct regulator_dev *rdev, int min_uA, int max_uA) { - struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); + struct regmap *regmap =3D rdev_get_regmap(rdev); unsigned int reg; =20 if ((min_uA > BQ25703_OTG_CUR_MAX_UA) || (max_uA < 0)) @@ -52,7 +51,7 @@ static int bq25703_vbus_set_cur_limit(struct regulator_de= v *rdev, if ((reg * BQ25703_OTG_CUR_STEP_UA) < min_uA) return -EINVAL; =20 - return regmap_write(pdata->bq->regmap, BQ25703_OTG_CURRENT, + return regmap_write(regmap, BQ25703_OTG_CURRENT, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 @@ -137,7 +136,6 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -149,7 +147,6 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!pdata) return -ENOMEM; =20 - pdata->bq =3D bq; pdata->desc =3D bq25703_vbus_desc; =20 platform_set_drvdata(pdev, pdata); --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87A2741B36E for ; Tue, 31 Mar 2026 15:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971838; cv=none; b=kNvPzXwusGV54So5WgjnJ6W4f6sru37c8i13Aa5b0sssjdpDTu5Eocu7VdzDZ2pS3/OHK5Cww7jU22uO3DD4MXp6hHyhlvX1XK2FquNl2G7oNta+o9xaVNFsmKk7Mvb4n7rbe6Epa7fDyrt8d9UyqZxsn02fRKPt4uzcAlIewf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971838; c=relaxed/simple; bh=1uAjKjH8Mriiu2XHqXVfsDGlgQSHnV96d3u/aQzpXDo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cx3fCjc/+bQHs29FSkj6tawCCBeCkR+03TIMcx8AUXYn6b2Um6wivZ9vOiNP8ThNSK4aZywGgHewSS6fAU66HVvIK8FzV8jUkt/V2O4489lWzhxRevytQEFxqLV522sC0PYbds8X+lE/7JvRAa2e43AAUXKm+f97/zMa9Hf0RHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=qnHcMgHH; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="qnHcMgHH" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-486fba7ce4cso59094635e9.3 for ; Tue, 31 Mar 2026 08:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971835; x=1775576635; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=veDJydETiE9Gv6g2pRG32dl9Jb7Mpm7Du1gG7k28aTM=; b=qnHcMgHHjfDccj+1QAnj/lAlt5BiyHG5F+cD1TDTpQsrXKAaEnovoEcV6gqEYk7PgJ 0ASc2pmisv+yYDLf+8YHpl18UwnFwF9PImEVYpehNlQ8nyO3zicrVh6J4KCMzJVQCTnK K5y6CePvSNkMlxeIEA7FQ1zrTEJ2/J7sLydwgqzpQ3JQLg90FjZ5FmqiKRdgtA11zi4Q YNisKgXa6NmRwVlBjuNeI/1wGeOFe4so1PzRsr/cXIT3+CPcB7GnOGXyKH5GpQOm6mpN 77ziPdcrCpHk51E9onAZ40r+AQ9zA2WD+an2LS4qGBNfAdIj/DEZUUYdsoSQQY7XaTEu fagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971835; x=1775576635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=veDJydETiE9Gv6g2pRG32dl9Jb7Mpm7Du1gG7k28aTM=; b=ZrOLWbfbxrAak/AiQ9jrj0pBIiq8v4W4SDkmv1bhYM1FVIeyWJSFCNX8K9nw0k522z ZNGzp0sRaDLwXv7B4z423DVgwj2TtJNzmeHG6UL7LIbUB9V7rMwIMdOoQ0o3XEjLrIS/ EF0mGRp2VhjQsHLSufoO9OkdaMXY+Ja7HNKIgH5V2vaFWV/YqRXU3MjzMdAtrGjNYy/Q SfwtgN0A/1pvFpwdjG9VV7mpTsb61HENAhZnzWC126DFtuLCC0Eji5Hdfzd4O4lBt+Mc XZv4EsPsmwyg06FpWdM79o5O41hHV3uOAYRZ53HoC6pLSf47SKbSyUKNDJE20enVGZPi plNQ== X-Forwarded-Encrypted: i=1; AJvYcCWcVYfQ8+W+91dpxf2yvRQYvEgmOSjzuonETDjtNN/ZfkMoNTc73JpPro5PxCoXYbnyFfUbGDnCj33g3dc=@vger.kernel.org X-Gm-Message-State: AOJu0YwJUIYZC/fCIoXR3/hqb29HQxF04LoDYuGAyDDpsY3KER0YOP4w 3hFyTeUO6hA3oZOqo7zgQgMSA8Hs7IF42eAVfHgidR30Vp1XwLtLvh2YVOsJ4YKzZSo= X-Gm-Gg: ATEYQzxk6DqKBRdSsMWg9l0zwfr8gucA3XvxuoJ+YaJDp/LkycX+HQs3WgePGQnK1qz 5vyHJCWXpjSXemeqRMGJCA1CJ2WgiOsxTNDdP6CewZNBzz4ZjFdAYitHef5vyrGlCMwlYo1g5lP Ovz8WPbucKCLV/1BrqRcl4ZoUUXTp8gGIjvUDOCDmSfgrV/jtA7feijxnXhrvleM6lCjqF4tdZ/ MC53f93UFFvYvAGJhZSRuh2r0QPDhcYbgy+pfErErt5PgnSw9kTbb8Bpk5NVvA4tvZmv1akb3QP c51pJtYei2KSQ/QGh56MLLJRc+XUY/eHxdbHGw0/HWQolKsAEAcF5IPWRBl3IpTVUxvnkL39FIZ EsPq4H/IzRK+7lI38rHxCz4enHadyYogc08uR1hvMvetSW/2y2ntVjVIZpUYFL81eP4HdKkpuzY VU8rrLYtOu7cU23aaHOjFI/cs1xLSoPnj/ld65fEpHaL3ZZNSmQGMKvz6ZhazHCij1m//TCb0KK r2DIg== X-Received: by 2002:a05:600c:34c3:b0:485:3f65:94a1 with SMTP id 5b1f17b1804b1-48727eda72fmr294205335e9.18.1774971834917; Tue, 31 Mar 2026 08:43:54 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:43:54 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:40 +0400 Subject: [PATCH v6 03/11] regulator: bq257xx: Drop the regulator_dev from the driver data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-3-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=alchark@flipper.net; h=from:subject:message-id; bh=1uAjKjH8Mriiu2XHqXVfsDGlgQSHnV96d3u/aQzpXDo=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr1+IrODV/rWs6zSx7Zo/dp8bsLnoqtLqkWFTzZ+8 3vzu2jrro6JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCmuvIwI0PDvuoJQvujb3zOX+L27M5U4R+cMmHircIPVnktdp63aa03I8Oas90 M8g/Ldtlq2emtYHFSXj2T7+iCqYGmy89r//CoKWcBAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The field was not used anywhere in the driver, so just drop it. This helps further slim down the platform data structure. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 812938e565e3..674dae6109e9 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -15,7 +15,6 @@ #include =20 struct bq257xx_reg_data { - struct regulator_dev *bq257xx_reg; struct gpio_desc *otg_en_gpio; struct regulator_desc desc; }; @@ -139,6 +138,7 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; + struct regulator_dev *rdev; =20 pdev->dev.of_node =3D pdev->dev.parent->of_node; pdev->dev.of_node_reused =3D true; @@ -159,9 +159,9 @@ static int bq257xx_regulator_probe(struct platform_devi= ce *pdev) if (!cfg.regmap) return -ENODEV; =20 - pdata->bq257xx_reg =3D devm_regulator_register(dev, &pdata->desc, &cfg); - if (IS_ERR(pdata->bq257xx_reg)) { - return dev_err_probe(&pdev->dev, PTR_ERR(pdata->bq257xx_reg), + rdev =3D devm_regulator_register(dev, &pdata->desc, &cfg); + if (IS_ERR(rdev)) { + return dev_err_probe(&pdev->dev, PTR_ERR(rdev), "error registering bq257xx regulator"); } =20 --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 242A641C300 for ; Tue, 31 Mar 2026 15:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971840; cv=none; b=ZB1MA0qE6G0Ufl3OBJ0pQOtNtYh7wgp+3ZMRG3KOUErN7tqPF/X5xJQFBrq68OwdRrRBXv1oZxcGvqhz3a23v5OFo83jIVFZxhFp9MyAQEV9kC04riWD2KnZ9IDPIlzP9l3LLw5EmJeZ1A/Q/XMU36g87x1mKTZcNBhiswMWjk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971840; c=relaxed/simple; bh=Vj+thyx6im8c/60dw5piAk8vyroKtJcY1a74UdrGYxA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gwUw4Klfrk6u7zl3LQKAGDYp8ji8f3mXl+oSyeO9Xu0258E/QeaTiyTyD95IOvOprCjFS8rpStcyhIWUPT2/6P7r/3rRWTnBpvqMAYNF20dDZmvW7m+/m7WQpPYp/oF4u4tv7eaO4SMtaJmYmZlV2zOg3XhCFjKuzXEwm2qOrr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=diS2wWQd; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="diS2wWQd" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4887ca8e529so144785e9.0 for ; Tue, 31 Mar 2026 08:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971837; x=1775576637; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8wsphdPWc7OLP974m9ulR0tmXF0Yx3Br+A797hF6by8=; b=diS2wWQdXlR0qqXVtr2OCyu/PeY5JO0EPhP/jxJl6b7pwAtOVf3K/IwehqpR8R/0s1 7nrjoz+hLic/U8601qU5LL5dbJ54qS2lqbRGIXhmXBIabpQY7yHwcNvIQ9lwJHalCUny 7bh1iawzoEuSuwSuLLwPoZ32CdXkb3A7HXQ1JbIkK5+wHBmyYpTV3ebxd6jZmSzN4uQE qu585xA5JD2f7mGVxqK70cGB5ct+wRnmDU16c0ZGE4kl12bn3VcuWsBimUt9GvE4oAsM nDwnRIN43a//CElr17L0MWhe6AmsLRv595KrPP5nM6cQmNVBmLbeHjoZwMMWYEcfFJD3 +0dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971837; x=1775576637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8wsphdPWc7OLP974m9ulR0tmXF0Yx3Br+A797hF6by8=; b=DZsllIXIuxRMjXwlqAOUF6D9tgSPuLzOwVoST+TWj74K3BMswgiHGi2/mUr6W0VEf6 VnbsLMODiCfta9F90dPl1spmgAbQ3SGJn7AfLJCzk7BnfVoA4YvXwsYEYXVsMrDgXi1D 0sQKFoWDS7OMSzB6z2Bqga902qg4n6wqtMKu2Awh4cQeXfIn2MJc1ey5zq/2Xfm5HY+J 83c8uu7InHnhifte0hQPem3e4Iv0Y+pmfzxmz4HvDeqKf8as4y77TQ9F0kfMjy79MwyU h3QyGDnSU1YbuKqCcJ3vQ0IoAtZJZ+3uYL3b2iOta137aSIPFAxuu7hScv1G2uGvmNVv s0jg== X-Forwarded-Encrypted: i=1; AJvYcCVPOhIfq9i2fvQt6LTaGgE4yTvEpAcbEOd4dIHBrbLoAIurdTc9AKAwtZTIqTUlb9/S60lW0JSR39gf4kQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxwbLzN2XHZzkfXl9cvt0Tljmz813x1ZsyuN/RMExWdGmsJh1Ut 246dD+PrxS9vyYsYompRgz/vAh+a6ouWTJYOAfYwGjOCCa5v3Du+ZMNx1qNTk8EWy00= X-Gm-Gg: ATEYQzysk2tTtszXjSSmT/j6d+SXbsavP8TH/Ve6b5o90i6PqKAakfK+00VFMJ8h0qB cESZCJEpXc7LCnavlwUwm4jLk/ItS2wFL3jRQFvOfRzuzLD3+pKp/myqwA3RKbyAYCg3+DPQtC4 sYvoDi3CO8wuum5xWUmqTneBbb8Cvhh9CNZ3kdGuSN6JcWHuZkogRt9r1pL6dsbpHvlPe5a0XXT loQCYXclLqjrnyaWKexVPvhgbL0Q1QSPh+qJrML1oaAG09z9tbJN20Wm8rOvTYL4PIBhrbyuwVl LsGPePo++WRPXmg3ds4arDp1diRk7vP2IXdDvYRqbWsAv/ks/Usm2PwySKL0vgOYRumfqi2WpV9 wgZFPCSI4oUrccgHlJD0VgAW2Z5ADEBgtzdHq7adSf/Ug7A7M0HszAUPv2xEqz4jZVTZqjJBBpW gXlNaSmBO6fYxvVpgTcsKrLC97UFL2CoQ7Hz/ywvlRDe9UhZQFfXHVF6nEZg1gwJFXFkUwE+tUU FSfRg== X-Received: by 2002:a05:600c:1e0d:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-488783ae683mr69431825e9.13.1774971837562; Tue, 31 Mar 2026 08:43:57 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:43:57 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:41 +0400 Subject: [PATCH v6 04/11] regulator: bq257xx: Make OTG enable GPIO really optional Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-4-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1183; i=alchark@flipper.net; h=from:subject:message-id; bh=Vj+thyx6im8c/60dw5piAk8vyroKtJcY1a74UdrGYxA=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr1e2Xt63Dd3w51LWyon7VGuF8lcub6+W6nq06uPJ a0ZGRsiOyayMIhxMViKKbLM/bbEdqoR36xdHh5fYeawMoEMkRZpYAACFga+3MS8UiMdIz1TbUM9 Q0MdYx0jBi5OAZhqYUeG/1GrrB2nL/uzzLOCwXJmM+f93I5qw+dTwxNuBL7+u8/u9nFGhuVFBoU 3N86w3/fv+TLJavmg/A+iM3qPyC85ophdf+i5DDcA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The bindings describe the OTG enable GPIO as optional, but the driver gets upset if it's not provided in the device tree. Make the driver accept the absence of the GPIO, and just use register writes to handle OTG mode in that case, skipping the error message for -ENOENT. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 674dae6109e9..0bb58ab4b8d4 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -126,6 +126,12 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_= device *pdev) of_node_put(subchild); =20 if (IS_ERR(pdata->otg_en_gpio)) { + if (PTR_ERR(pdata->otg_en_gpio) =3D=3D -ENOENT) { + /* No GPIO, will only use register writes for OTG */ + pdata->otg_en_gpio =3D NULL; + return; + } + dev_err(&pdev->dev, "Error getting enable gpio: %ld\n", PTR_ERR(pdata->otg_en_gpio)); return; --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7D5E421EE8 for ; Tue, 31 Mar 2026 15:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971844; cv=none; b=tyIlusBDHAT1k/gWOcxmMdojBFc+6FwOoMXhADnvFHfnzqlUDAgnsC46dVumNVrc+fD9JOKcVP38kbNoN8yoFAOr4uN9Ne056beeo49f2wfY/JDJqJnvesmZKU45Br1N8enB4tJwfsZ015fvJ+I53aIU6Xyi4R5qqq8io6tbESk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971844; c=relaxed/simple; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ppB7av+gVPmSY4yMfwmxm1nZQ1C4iuCX2Eb2CO2gh9+rDFScl1+roipGs7SJQXB6gBJs7ZXFQBIEQQPE/oT39HlJTu3a5UvCGetF1T4F1v6N3y0EENiKQSrav351r3Ba/9RXrRnl2bp5nfSBC2ZAnCtJgDTCUAnM8qH0tArpJgw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=IOblLjR7; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="IOblLjR7" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so79355e9.1 for ; Tue, 31 Mar 2026 08:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971840; x=1775576640; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=IOblLjR7HQd71W849/IK9hJ6liawmOg+zs3cacx0vsxLrWpHxEKTJP3Q1VlgwEddBQ 57cCJEJYHr+qT0/HV5drJuRhCrWHKVY0H+a4hWazNcQP26VgW6RYhR4vTnIZYKVb0RrM NqMM8TV5ELdLF8ujsONhClD9tQaWKuJNd/3AI1YB0prpOnjlirEZ+7GfYipWSAIh+Nyv c3PXxjTi7YTiiTUKUD5uSQpYHDs84t2RI5O4bk7QiiJ+Xo5YuADf2Qt37HXDpAEEJR5N 1+2ZOL61/G5DGRa9EPbX8roNIT/khWZP621RxIylfqNt1XRgL4xOLKVh5nKxQ+sEgODR fv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971840; x=1775576640; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j1uQzW3+bjNeF/wEPgSsxYt2kbdgf5x20O5xEAeMiek=; b=Y7ljm3gaA8da4yOPogQuHLKkSxEP9M1x83bk52poTMGSAL/MsuptKNQKYZo7ox4PuU 7onysAY8qdAK0uGFta5cRKXY2YNGEQEJNbVuFsaG7qaeIL3yTXE1cU8JD0WuKLCeAY3C u8sbddsg7R9D0Gs+oPrm3W0DybwKuQ3Z9gFgF57a8z6quO7dURwQFvAQjA0GnHjS/A+k mre2+cgXzOjguCVIG2FoZkHcJgWkMsCouBS62fA7DJMIL82CP8V+EojTF9MWrqZzVP55 fuHaaY1BgNz/SgSyyxCQqSSS1gPp/Hm+OP9v5UYIf2nwbXuxFtwT4/8YVsIaU/qBqbab NGsA== X-Forwarded-Encrypted: i=1; AJvYcCUWsXZ/pRSMuxpzXOY6qTm//IJEvWndWwkh4JGID101diaFjlAMWeQY3nBxYbZB0TUjCCjI5ABhSpmjn+c=@vger.kernel.org X-Gm-Message-State: AOJu0YwbOqugYE5nLAF+6GanQyG5Qq567TCP0H6V30TZR8vgi2/VnVEo Cmg8Pnv1nPghI7EP/qG/mY4iLLPh0T+ocNa6lhm6ajNA6Zt8/ROAxyCkWQGaZU9rl+U= X-Gm-Gg: ATEYQzwCIKZVExmtbp8NN2ZB+qr9BDIpl1qR2Y8WKtWEx+JfLNscEsfXrgAJHxWYeNJ Ol8WudCPSXW+xy8ZbXCrQX88+2cPhKnppk3axjvsSJN3ZuXh0TLMZ7wFfjDQV8KlpZNIrjGFYzp 8vl2EG2bmxdU4DPWFHzick3bcheTMkQl7M+r5dBHliNmLqe6zQushQFEWttxZ8rdiv2Fu4wf+4U iqLKE15TgGbfaKaFeiqmHuCHvgbrt1/QYzDm40indBatZ6JGzcwy0Pnk8SGcKaaL+LvNsve6cDN DdsB0rhiENX5gR9N5XsMrAOc4eElbibnmMO3gQRkMn8s2ijZ9w++YsrgQPK3FRughX3/LyiElt8 1cymrhBlqQg1wPqH4aURsQGBg69a0/t4JacKm3I1VMY6Qmh5PGCqIYwXN5ul9E54PTxXdoESHFH /G73KiHr3IEp9eKoh6qO+C4sMQ0HgWc4vvaD1dqNbd7j/7IoKcRyPN+WdyPfEeUDTvAvTSgj6Hj E+Hog== X-Received: by 2002:a05:600c:8907:b0:485:fbd2:f72 with SMTP id 5b1f17b1804b1-4887818678emr52899635e9.1.1774971840282; Tue, 31 Mar 2026 08:44:00 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:00 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:42 +0400 Subject: [PATCH v6 05/11] power: supply: bq257xx: Fix VSYSMIN clamping logic Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-5-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2028; i=alchark@flipper.net; h=from:subject:message-id; bh=0GDlOYezmKEXCru71ex6Z77WQ5tS0GByeoQbXgUi37g=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr0+sjLgRVHOB6OerPmLpvscZ0m3erZk50a32q+Xl yo03Nwxs2MiC4MYF4OlmCLL3G9LbKca8c3a5eHxFWYOKxPIEGmRBgYgYGHgy03MKzXSMdIz1TbU MzTUMdYxYuDiFICpjgln+M0aXljvxlI0N3xyguz3uHsTJTN+HJ7//cK3usm3Qg++kY5gZLiS+zs /qOGy11x7lmXyqpdNzdx0xS7I9GmwvF58e7LsHm4A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The minimal system voltage (VSYSMIN) is meant to protect the battery from dangerous over-discharge. When the device tree provides a value for the minimum design voltage of the battery, the user should not be allowed to set a lower VSYSMIN, as that would defeat the purpose of this protection. Flip the clamping logic when setting VSYSMIN to ensure that battery design voltage is respected. Cc: stable@vger.kernel.org Fixes: 1cc017b7f9c7 ("power: supply: bq257xx: Add support for BQ257XX charg= er") Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 02c7d8b61e82..7ca4ae610902 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -128,9 +128,8 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pda= ta, int *intval) * @vsys: voltage value to set in uV. * * This function takes a requested minimum system voltage value, clamps - * it between the minimum supported value by the charger and a user - * defined minimum system value, and then writes the value to the - * appropriate register. + * it between the user defined minimum system value and the maximum suppor= ted + * value by the charger, and then writes the value to the appropriate regi= ster. * * Return: Returns 0 on success or error if an error occurs. */ @@ -139,7 +138,7 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pda= ta, int vsys) unsigned int reg; int vsys_min =3D pdata->vsys_min; =20 - vsys =3D clamp(vsys, BQ25703_MINVSYS_MIN_UV, vsys_min); + vsys =3D clamp(vsys, vsys_min, BQ25703_MINVSYS_MAX_UV); reg =3D ((vsys - BQ25703_MINVSYS_MIN_UV) / BQ25703_MINVSYS_STEP_UV); reg =3D FIELD_PREP(BQ25703_MINVSYS_MASK, reg); =20 --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCC3421EEE for ; Tue, 31 Mar 2026 15:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971846; cv=none; b=BBm9rDF7Im90VP4JhhwHkhpY3AAy9q3TwtXRBSK6xDx7mA2VeCTY4XEu1Y+WXZ6B6LLNaC3d1dmGE0yy6papSqPK9xJxIEaM6WwRp/kqCxfTt+EUSgqcNNIrfIpXjzMDgdMuwwQJaVMI8imcesshiQ4HjSdhITIlY9P5jo51C2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971846; c=relaxed/simple; bh=HoUkMd3aj0s9m5BRWarIKv4NrOIfktIuX7B1xZTtvpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gwLErubRqiQqdtVqwh07DPBmHRfB12m9SK36X2jvvPabGsKbJ/LbFfvT6y5kum40lqUW4cvN5YO/fCp6wS0RM8l4WA6LWMmQ1OPUNV4YNVtvh3iLQbEdJHEyLiH/Gcd8X7smQAWzBBTbI7u4ybKrvficR7JTkaI0FRxEuQxlY28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=IaCwYfwj; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="IaCwYfwj" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48700b1ba53so53895435e9.1 for ; Tue, 31 Mar 2026 08:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971843; x=1775576643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Jv4k2NFngBv6AeWEv4O9srLSbI6EPVNmV51Qs0A5klE=; b=IaCwYfwjk+9pZGEcglvLOH5NCVKRXaON3jeepXBRTxclg4znbhHPyNPN5YNXkU7rj1 XN46uQvriYKCQkHx7nLKAjmdraT7LVfU2Nb1K3rXA/YsSfHp20CPiD2ig2VqI8CbE/og k7mJR73eQPKeePq841wwX9a6cYORjmtW2e5OuIDqSMN4qzfNF39i9mB7y+kHOALBKpZF 03pkeZ7xckk8nhMuS8nbSnbH0++YLb/ZAxDuwZJgDs8+yEPxvMPCz4EcFYPo0PWzbHd6 75BSOAnoq7Xe8KzZRl86spW45IXM10q7mg9omYNywa1gWvyQx+NdiDxDNa8tuF6w3mqD Cqxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971843; x=1775576643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Jv4k2NFngBv6AeWEv4O9srLSbI6EPVNmV51Qs0A5klE=; b=mH/mE74jnBTwPjhHdP8De8u7r1dQoe3qDWeYUcarOd/kvypFN6sEoUZ3ScwIA6l73q +ZTgVBs8/gQ6duzmh+yXCaJgWQHul+VragGPQXiVX0/6atreLHKNWdQfEAmDG1EceXvY /aNXhulW3SAJjQQQzH/loh44bFTCWazYfOvIoCBk+LTca7LPSlkxELSJn0vldd34Phsk zYpUTfol4E4JkxNVydWdU3ttd2Mhbru7EXC/uK8o/D7qFSmVvYMiEMAIwl9bEiu9yuNA rM1a9c1czeWUaLp4TcsP6GZH7QMJSDgvksB1aSYyeEH0K3R7lvEvE0I72ZxnE7FJERNT Fc2A== X-Forwarded-Encrypted: i=1; AJvYcCXEANswawwD6ysKaVTNGoYgGgDoZa+RvLtetFmTv8yt0FHqsHfsUuaa8yalPsg0AoROBRPTXwtWQgGnlUI=@vger.kernel.org X-Gm-Message-State: AOJu0YyQ5bDZeaZCOw5Kp48jnpBcEgAiAnD5yFKG0tFzy77QFarqODI4 kPgpcihx+pFCqDJs1mzD2C8Wwcn96SnTetMc0FMO62q6NuNpzO6Nujwb3Qo2FZK3ddKNhQZJBND kCEgeUAI= X-Gm-Gg: ATEYQzwRy+pbRf1L8ZhFRFTX010jxetGdyavEtS2TGDs/A4Z/X1hYyyNQm385jS1xDk FkFo/BM9U35brvD4V/uhbDloKnMQuqlTxhAcYq6pdpipucTq29eO/Ne5TtRKxVaicYNq0cB8da7 niZJpXOu35m9Ri8KBC4cRrFgt4Qibvfrp8/osvcGEPZOcoy1wu1AL5H3v7JtBCcuF5IjcMLwLZM 1wOHDm0lzVDJ756cXP950x3ouJbre6b9YgYSDmWXThiO0bpV7GdcIRniyhZfio2h7y7xJcnB9hf MbMftIdmdiJ1nGx7Iq/UCQbF9jHGcpPW8neJh53Z3305LHIIjC5DkStV38+f6p5soadAGWsF5DU 9fDgh6qvPVCeY52IZFtCd543R5Gp+j3M3S/AOV8qwTEu4KBSrYvSOcWTLDSgUycKrSoWevOSCL1 cHQZzM73boE3v7QW75bI1sge/FtNOvs8Art8FhlB0n3rbhlEFE3V5JmAIrTtO1soDrIGaZ37gKA N3JaQ== X-Received: by 2002:a05:600c:1d1e:b0:486:fc95:1a91 with SMTP id 5b1f17b1804b1-48727f2373dmr287944595e9.12.1774971842949; Tue, 31 Mar 2026 08:44:02 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:02 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:43 +0400 Subject: [PATCH v6 06/11] power: supply: bq257xx: Make the default current limit a per-chip attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-6-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2056; i=alchark@flipper.net; h=from:subject:message-id; bh=HoUkMd3aj0s9m5BRWarIKv4NrOIfktIuX7B1xZTtvpY=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3ef0ttquypte31uzOPPijUa9PT2HKimnHdZVnRH 0+ucm5e3zGRhUGMi8FSTJFl7rcltlON+Gbt8vD4CjOHlQlkiLRIAwMQsDDw5SbmlRrpGOmZahvq GRrqGOsYMXBxCsBUJxgy/DOYdUY7yz5kzsZgxwXp0/L+vf1w7O3eBSWXNetnxHrc3X2ckWG3ouj vM+evmi9YI8x49ceKQKGJWy2m/YnJ+99caDdn9Q1WAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add a field for the default current limit to the bq257xx_info structure and use it instead of the hardcoded value in the probe function. This prepares the driver for allowing different electrical constraints for different chip variants. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 7ca4ae610902..39718223c3f9 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -18,6 +18,7 @@ struct bq257xx_chg; =20 /** * struct bq257xx_chip_info - chip specific routines + * @default_iindpm_uA: default input current limit in microamps * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware @@ -26,6 +27,7 @@ struct bq257xx_chg; * @bq257xx_set_iindpm: set maximum input current (in uA) */ struct bq257xx_chip_info { + int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); @@ -627,6 +629,7 @@ static const struct power_supply_desc bq257xx_power_sup= ply_desc =3D { }; =20 static const struct bq257xx_chip_info bq25703_chip_info =3D { + .default_iindpm_uA =3D BQ25703_IINDPM_DEFAULT_UA, .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, @@ -675,7 +678,7 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdata, "input-current-limit-microamp", &pdata->iindpm_max); if (ret) - pdata->iindpm_max =3D BQ25703_IINDPM_DEFAULT_UA; + pdata->iindpm_max =3D pdata->chip->default_iindpm_uA; =20 return 0; } --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B9A6423146 for ; Tue, 31 Mar 2026 15:44:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971848; cv=none; b=aDCenghCzPpW94uPJ4IzWfUJGmeQ2LfLM4/HXw39msGyvMLlbvBYkZu/E/QkBHyekdqcpcTvskRKYDexcq8ebQlY7etlOQaj95/9Do9agwqkw756hnPfRX5PCCJ3QvjPst5usVTx56UnMDYIkEYf6uQzc151G6tu/XRSbBXG7v8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971848; c=relaxed/simple; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SJ3mQ11lvmIa21hg5WXI0cpZrFPKR8J2BJrKO0ueX2OeyAJVQDnBxoT+3GkTNCDeEwlgTgzbs017ldp/f/sktTLDzzfOwRPSfR3nbb/HpMevysIEHgyVM52J0ihrR5Nwkx/jh0g5I3JsRoPmHI5SQFCPFPhXjQHk4ijiQBrrZ0w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=cABwwynB; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="cABwwynB" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso49075555e9.3 for ; Tue, 31 Mar 2026 08:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971845; x=1775576645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=cABwwynBtz91HQQXT/PqabNqB0tswzybZM5KooRH9z1AxGGpZHl8q1fodnGBhoDQJ3 zk4uMZ33EPZLLB7q9yPK5bGTSvh9M5IyeltMwCUrRAyhT/qGzCkBX0z+vx+sIzP/xx0l asyOx/ywrHqOKgu4Z5EPad0qSjEqOgtu6biVFicz6VdF5ti4Vla+4WDKnLZAvjJQYO9R WHmowSwsck+ehm5QrrnZyTW0fZIRG398JC3HSaLlDPddrnSLfsLdADIuA3oY63OopW/m 4SBhO47MBKzseDp+VXVaiMhbBFJr9g+2IA6CK2fixrqj70WPHf6SPduDNTFZ3qQ6m+8A eQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971845; x=1775576645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8b97w0FIxP+iQSlY9+U8NDMrKZX5YXrCInQTxcuoNL8=; b=H0qzbl9+yzh6u/JVQtoTiYMStsAvxHEscWS0PN0PedLmjHcTpt2Ue5Rc9dI6pn1bZb cm/Qx+Xsno7QNqGUDmSrs5F4x3DihlLnlC81jeeS46+DTBw9j5uZzMDM5AczuybCXwNC KevUDpeASUz52J4bEiQS5dlwd+oM3Po4xfbH+Xw43AJNHLdGouGfdOTPNBCcyvqpAiAf tbP6kNpii6dr0Sf0Ys1LNMiiWkUHZd+zS0799y3XzzSb3JoTFONjRIe2oI9nH/gfEthe CDylhBWcGJUewBeHYXCF3raREtzc52LSmD5L5vKEGnI+EvFLgxin1hEgiSxscEWWmycU mExw== X-Forwarded-Encrypted: i=1; AJvYcCXDPJBSkEd1yTRubnNEqm7iVwcHaM7zyOvONwmgILNU8kPluJq6FXL0HT02kBrrYIFlsJgQ7k+iwr2HIkM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5zh8dk7QtTyTNXNy3aOmm3XOKDjhlyskm99JgFB+ZeXMmApvl JGnlKXfGYS6/r8Zj89xxkWwLL1d40F6lOhm8LLArkBCVpjFjFNTk+URFmZNLnQRoFUQ= X-Gm-Gg: ATEYQzwL3+NnX7CSPe+Ht2FWxugx5SBZ4QQDJioiVxGJRn9eGLM49dWEglxgL0FZJzt JWN8UU3bloESk9P/yN9CaVx1gSRIBDg9daOVpA9AIldqaTUxuaW05TqGCK7hauJooy8PGuaMlQH g29wsvKXmITAK4Jin1QzHrR6J7r2BorkzTIEqvjoQgpD84iNhr4+6HIAHxKqrySNI/Naqs5sL28 ldrrI47XoBAJN6zxwa6/1NYlasxnBYXtFt2tQLZaHoxVw8vkLc0h4OF/wOuY/P/yYcxy6vIXNk0 k1eQm4SnhnHe2qln9BEvN632ppX13UCh6F57djoK0pmtlVa484MayrUDzTmWXSf/ENrx6RoPQt9 xrWHwHs4PCjMYZyQ+L9lMPp/nNksCToZ7oCnFezt1xxvtkvNSl3ryqWBwqiAFNjCmVnAEwPN/JQ 1PMTLXd4mUtKqI27wnLMVK8os2hC9WiD+ii/mEblr7HiIOgg8mku8d9YzAV9PqHGzMdJG99bNow DaySQ== X-Received: by 2002:a05:600c:4f53:b0:485:3692:e8f7 with SMTP id 5b1f17b1804b1-48727ede47amr285030835e9.25.1774971845478; Tue, 31 Mar 2026 08:44:05 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:05 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:44 +0400 Subject: [PATCH v6 07/11] power: supply: bq257xx: Consistently use indirect get/set helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-7-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4242; i=alchark@flipper.net; h=from:subject:message-id; bh=K/K91eQQ75phcINLj4DBBQbD0ofWablCORf9BgG8obM=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr1+UozjGbdn6i0TNpbc3npbND99gm+lRDTzgcszY j9X9x+Q7pjIwiDGxWAppsgy99sS26lGfLN2eXh8hZnDygQyRFqkgQEIWBj4chPzSo10jPRMtQ31 DA11jHWMGLg4BWCqOecx/GZ5eHLud+NqkwvXFk6dtfPAzH1LGR0WMhQfzZq9R11l9vIdjAynPe4 smT1xtX6F8eq1k6MnVKwM3qArO/U/f63lsS4Jj3+8AA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Move the remaining get/set helper functions to indirect calls via the per-chip bq257xx_chip_info struct. This improves the consistency of the code and prepares the driver to support multiple chip variants with different register layouts and bit definitions. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 39718223c3f9..0765673728e4 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -22,18 +22,30 @@ struct bq257xx_chg; * @bq257xx_hw_init: init function for hw * @bq257xx_hw_shutdown: shutdown function for hw * @bq257xx_get_state: get and update state of hardware + * @bq257xx_get_ichg: get maximum charge current (in uA) * @bq257xx_set_ichg: set maximum charge current (in uA) + * @bq257xx_get_vbatreg: get maximum charge voltage (in uV) * @bq257xx_set_vbatreg: set maximum charge voltage (in uV) + * @bq257xx_get_iindpm: get maximum input current (in uA) * @bq257xx_set_iindpm: set maximum input current (in uA) + * @bq257xx_get_cur: get battery current from ADC (in uA) + * @bq257xx_get_vbat: get battery voltage from ADC (in uV) + * @bq257xx_get_min_vsys: get minimum system voltage (in uV) */ struct bq257xx_chip_info { int default_iindpm_uA; int (*bq257xx_hw_init)(struct bq257xx_chg *pdata); void (*bq257xx_hw_shutdown)(struct bq257xx_chg *pdata); int (*bq257xx_get_state)(struct bq257xx_chg *pdata); + int (*bq257xx_get_ichg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_ichg)(struct bq257xx_chg *pdata, int ichg); + int (*bq257xx_get_vbatreg)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_vbatreg)(struct bq257xx_chg *pdata, int vbatreg); + int (*bq257xx_get_iindpm)(struct bq257xx_chg *pdata, int *intval); int (*bq257xx_set_iindpm)(struct bq257xx_chg *pdata, int iindpm); + int (*bq257xx_get_cur)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_vbat)(struct bq257xx_chg *pdata, int *intval); + int (*bq257xx_get_min_vsys)(struct bq257xx_chg *pdata, int *intval); }; =20 /** @@ -490,22 +502,22 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, break; =20 case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT: - return bq25703_get_iindpm(pdata, &val->intval); + return pdata->chip->bq257xx_get_iindpm(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX: - return bq25703_get_chrg_volt(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbatreg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CURRENT_NOW: - return bq25703_get_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_cur(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_NOW: - return bq25703_get_vbat(pdata, &val->intval); + return pdata->chip->bq257xx_get_vbat(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: - return bq25703_get_ichg_cur(pdata, &val->intval); + return pdata->chip->bq257xx_get_ichg(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_VOLTAGE_MIN: - return bq25703_get_min_vsys(pdata, &val->intval); + return pdata->chip->bq257xx_get_min_vsys(pdata, &val->intval); =20 case POWER_SUPPLY_PROP_USB_TYPE: val->intval =3D pdata->usb_type; @@ -633,9 +645,15 @@ static const struct bq257xx_chip_info bq25703_chip_inf= o =3D { .bq257xx_hw_init =3D &bq25703_hw_init, .bq257xx_hw_shutdown =3D &bq25703_hw_shutdown, .bq257xx_get_state =3D &bq25703_get_state, + .bq257xx_get_ichg =3D &bq25703_get_ichg_cur, .bq257xx_set_ichg =3D &bq25703_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25703_get_chrg_volt, .bq257xx_set_vbatreg =3D &bq25703_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25703_get_iindpm, .bq257xx_set_iindpm =3D &bq25703_set_iindpm, + .bq257xx_get_cur =3D &bq25703_get_cur, + .bq257xx_get_vbat =3D &bq25703_get_vbat, + .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 /** --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE1B342314A for ; Tue, 31 Mar 2026 15:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971851; cv=none; b=A/cM9hgjq4sEI58jLoCkjgsubRIKhiopWOq9tolwIHE9SgFh4vFXOEUgKftVjhkaU0E4vCG3TwAkxb34moWmQTqS4bGCjICn1H7uSmSVMftP+2HkRXKwODwUKVecty/Kt74qSDrC+NtzGunSLbomE53u/apZ1DZpPrbsHrsrCgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971851; c=relaxed/simple; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kj3PvIDKVqfqyepEABllDrxA0Kwsc6Os1yD6DvBraKyvHqy8QGdPnkntE8mFZWqgVQKp+u//qImyxVWdjyQ/oEsorUix8NJj005s7/3vD1cpDeqecIxHQOi6D83nGW1DcAOOsauGhRHN5ZH4LhUq7iqLPB99PkpO3woCvjaThCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=gcjGgUu7; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="gcjGgUu7" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so49702505e9.0 for ; Tue, 31 Mar 2026 08:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971848; x=1775576648; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=gcjGgUu74+HcPcTyOi3RpUvw/uvDG5hgfiTvbEBW3FkGnfQC8Z0bvbVWKznNHCWcp/ mNVMv2jw/NMQnTstZx4XUNbHOhQ8HmX1YsMFKpVPO0zqvX3ol1IB4+R27W9AOiI/sWqD BMHSVN2pEDHxPhQKmbl3OHvJkuWIo6wsorK0zohlaOI7WdfMmxFIDExYmLtSksAouujC 2VmsN2XsMlyvLCqN/0U6m9tSLG6IN+sC/62UKhzJM39k+clUYDgn8RDdZ88GMyDLQZHw 0NFlNv2pLef3v0BxY14icfsxwNETSgZrSAud41M2TUC2nJ24HC706IHpW8ODhANlvzD1 wUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971848; x=1775576648; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3AEOePYJtU4kn4mkWQfK7NUJrP7JZP+VFvVN1gskxyo=; b=OlKp4mxrHnVqKRYhADDOjmPGjzfLyNc8bpg2FsUzMpdv/llkD2GvQqepzC+cRanhtG qB1nBJi9wcl9gujaUbF8J2qjxJue1dtjLL669CcDzLxD/v0fYDOc0+ThnP5DzgarjTo9 zDdhyRFPedan+fqWtGUw2cPff1aVfrfpQqlv+T7kIrOG0oijWc2VBLc6pr2H5N5OaE5B ZGsTuO4cKjVNiRT8f4t6+C3opuugYMa0nVUCiunIO22MXTXE84YHKBIbREiReSyph8o+ xBLuMrZE54KAhk/wkWD6jCaQlTUcEzttUnD4NhDXDS5DhU27L5bICJhjpYl3ok1XoTq6 VfYg== X-Forwarded-Encrypted: i=1; AJvYcCVETdQRsfAO14n+rlEllOZsdEOlmXu58VEIXtn5FPQc0oe47GWN2qwaMgWlz1+01Vvh7fHrBAJZeRfswwc=@vger.kernel.org X-Gm-Message-State: AOJu0YwH3YmzgQfQwgvqUFTV5ZutTpV9ePPd5HvJEQnXxCz/dj+dMlCh Uihw1BBnwVZ9Bq0vnkEVs9f5z3oLcwVlQaPvP4oF9pl+OyZ1/DpXWgmLROx2j+CmmZE= X-Gm-Gg: ATEYQzyckBJgPCP26IYTzQYFf7K+BKWKaluTxbypp5Q1On7drzu/aH4UFuDNx+HVL2v z8f1Wu4W2Zj5ZW4UqqlZznXqe3EeRV0mAbX5qFxq22r3+dQld5Jr8te7GjxnOsBq6ZOV0tXiJ5J tIpVvx2WxZ6dDA3blle9MHs6RKx+VJVCblkhsiFyCXqtLR5DsLRL1SSxSF2esIFCNqlKux0UMBn sgWhm6gG7K37c2LGdIVKEvJ+G//cS5BfkKHTnY2nzrfaJHE8y0g+4mBrM0sRxOktxJCPH0sfF3r rQusuei96hfETWGxk7nA65yxLCxzeqf6qI1hy5oA+Jrlv3c7Rtq9eA4lu6aclQzLV4granB2xAM LVqHWuDHadEw51qP68U0BYtcH+4XWvqyXhY9w5uCQDfCqs8weIHqodL6wRG82KAj+n2KfsuQTZo XbBHg/ovYicpf9bwqAYJYQB20Y6Xt+5KrgkhG4qUydpzp504vA4zOLfMF+syWIoE/y5wA8YGrjy Zhxhw== X-Received: by 2002:a05:600c:45d4:b0:488:79a3:f04c with SMTP id 5b1f17b1804b1-48879a3f26cmr61666005e9.27.1774971848032; Tue, 31 Mar 2026 08:44:08 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:07 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:45 +0400 Subject: [PATCH v6 08/11] power: supply: bq257xx: Add fields for 'charging' and 'overvoltage' states Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-8-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=alchark@flipper.net; h=from:subject:message-id; bh=xDe5OwkC59HG0l6E9h1OwEErzx9ysv39/KByzvSAFgU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3e/5L0mRfBFafkf65duuv2+rO7r1a57Cqo+xMje P/DIVZZn46JLAxiXAyWYoosc78tsZ1qxDdrl4fHV5g5rEwgQ6RFGhiAgIWBLzcxr9RIx0jPVNtQ z9BQx1jHiIGLUwCmuuMfI8N5s3DZXKHF7Cc2LG3L2ik4P68hWvH/fc0otrNLlr6MSgxj+GfYW6f R2HZfVbKFQ4dV17zy5bMc26ULMs5tYok/MX2WDCsA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 The driver currently reports the 'charging' and 'overvoltage' states based on a logical expression in the get_charger_property() wrapper function. This doesn't scale well to other chip variants, which may have a different number and type of hardware reported conditions which fall into these broad power supply states. Move the logic for determining 'charging' and 'overvoltage' states into chip-specific accessors, which can be overridden by each variant as needed. This helps keep the get_charger_property() wrapper function chip-agnostic while allowing for new chip variants to be added bringing their own logic. Tested-by: Chris Morgan Reviewed-by: Sebastian Reichel Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 0765673728e4..9c082865e745 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -54,8 +54,10 @@ struct bq257xx_chip_info { * @bq: parent MFD device * @charger: power supply device * @online: charger input is present + * @charging: charger is actively charging the battery * @fast_charge: charger is in fast charge mode * @pre_charge: charger is in pre-charge mode + * @overvoltage: overvoltage fault detected * @ov_fault: charger reports over voltage fault * @batoc_fault: charger reports battery over current fault * @oc_fault: charger reports over current fault @@ -71,8 +73,10 @@ struct bq257xx_chg { struct bq257xx_device *bq; struct power_supply *charger; bool online; + bool charging; bool fast_charge; bool pre_charge; + bool overvoltage; bool ov_fault; bool batoc_fault; bool oc_fault; @@ -106,8 +110,10 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) pdata->online =3D reg & BQ25703_STS_AC_STAT; pdata->fast_charge =3D reg & BQ25703_STS_IN_FCHRG; pdata->pre_charge =3D reg & BQ25703_STS_IN_PCHRG; + pdata->charging =3D pdata->fast_charge || pdata->pre_charge; pdata->ov_fault =3D reg & BQ25703_STS_FAULT_ACOV; pdata->batoc_fault =3D reg & BQ25703_STS_FAULT_BATOC; + pdata->overvoltage =3D pdata->ov_fault || pdata->batoc_fault; pdata->oc_fault =3D reg & BQ25703_STS_FAULT_ACOC; =20 return 0; @@ -478,14 +484,14 @@ static int bq257xx_get_charger_property(struct power_= supply *psy, case POWER_SUPPLY_PROP_STATUS: if (!pdata->online) val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; - else if (pdata->fast_charge || pdata->pre_charge) + else if (pdata->charging) val->intval =3D POWER_SUPPLY_STATUS_CHARGING; else val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; break; =20 case POWER_SUPPLY_PROP_HEALTH: - if (pdata->ov_fault || pdata->batoc_fault) + if (pdata->overvoltage) val->intval =3D POWER_SUPPLY_HEALTH_OVERVOLTAGE; else if (pdata->oc_fault) val->intval =3D POWER_SUPPLY_HEALTH_OVERCURRENT; --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83926423A87 for ; Tue, 31 Mar 2026 15:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971854; cv=none; b=iL1LKl+N6GEKEws+cD5KWQAw7vU5Vonsw7r92dMC4StjppiE8Sb212+zZpJH4rXV+tYCzBe5ClZwyAeWMc1jZdqUPkjnDGDjq2ATbOQA8p8NAEH2fdgcgHQ/ofdGy8MJDkHeRIEMbFIQHE8ar2vykkLVWQbphDXuNXrYEC5/jeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971854; c=relaxed/simple; bh=035uLfC/qCk1SQCGRS8BdnBZsGiJRDyEfYBPzln/PUA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aoLiKcdLC3sKhCDztYXmwYFiktLPwOOGzxwD6euYW/FvuxqxOos6Gf2/XGnePFZM3hkc33WJf8o4UYO3E6SeRrXADB/AkyX2s7DpyljQdtMtnZ06wJ+pjVYU9mHlTPzc7q32mMAVIYjgY2UzVexMlFNg77GvmgItR6v4OJmc34o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=XYGkR5Qi; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="XYGkR5Qi" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cfa33a983so1738431f8f.1 for ; Tue, 31 Mar 2026 08:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971851; x=1775576651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5H6NE98km+QlKXSyTbbjh+9YCr+zJjMBCTzhaVC/y8I=; b=XYGkR5Qi5baSR8tCcce+QsIvohl9ol+MqRKnXgNyGaZcnsG4J8va0jPkP3ZS/uToRF RSmGnfgtKWmWA2On17dUOyZJoxg9Lypi77Pl7pxJi88ORrculKRnlNGcNJGlBOeuzK5o zgtKmHV75O7q3Fsp0shh1SETBlRzEbI41+SNWZKHhI0Iro1/wtQlXor9cWuaG48x3W8D mqjXSAcL9O4Op5OPVhXfIsENivD4YrcYu2UiLwi+7F7+sbwoi0C5sEJsgaY9T8rXCLWI rDMAzITKiKHGGzsdzV/5s5CxufytY785Jq6h8OK9Mw+weSXDUMWUi3npNe8liYQUfrb6 Ls7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971851; x=1775576651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5H6NE98km+QlKXSyTbbjh+9YCr+zJjMBCTzhaVC/y8I=; b=XJgUCu0QMxgxhowZ2cLcKIEHnsPSxUWyjA+CgX/fiVnecwOxZNIghzbF/oU2/tufcK Db3877HFJpS5VxKMGWKUuXEKHVNw1GdwFzMtrMckVC1nHaYPjwT5oJTRxBNomV6tviPt ryGcJZNA3sqax7biLqDdlKr0m4aCQ/5EhIPjcYtNeiTCEq5NhD9bRYWZfCnmS7fJe8cN D5JDZY89bP3MEFV21FMAWDQyOjj4kbsuRNyXu5gNsmJHr/ARa16QhM5VY1M46v1jkayt gAC+I/pFqurXA3i6bXvcMbFASyeuC91KguXbGHT9em4UBucc6B7sftmBDVa/mPLm3cKO a3ew== X-Forwarded-Encrypted: i=1; AJvYcCUcUnDG/cBTVweBbSet4odnMS/MyqO7+X+rhAt/rHAff7/5AFamEQAfRvJ/HCk1N3KhT42XOYqQpGe689I=@vger.kernel.org X-Gm-Message-State: AOJu0YyuorNiL9K5+GvjFA0+5w0Gz4vcofG5UygPrG3Vb0c7xPMscnzX dyb8AovTD9AjRCfxAt7iWTqxMcuHZjYvIYvoZikXiP38tGwAK7fM2sLb3IVLF4W7wFDht0Fzo5t cKWD6Vjg= X-Gm-Gg: ATEYQzwErEtctuLwN5sQalWT6bs7j2zhNJZNKwmRhRJ/SunqFLhr6PLipEkPOaZHfLi pibPMzjwvFsh9k2CNLLRYpX8iDIGKhTIjB9r8KAraFmEVw0XW0Zit8321h3FObZeqkCUkxvsaM9 k06F6eFfU1Y9swSg+iBhcdi9lkRhr5Ufz5nOPO+gFDTLiMqvsP2A7l1YalM7yyKS7eBhceMmkG6 7meSmuaPYwfcm20DD64gNEWLHBzje6C8gd7zQ24O4OErR9F1hMChQSojH04qYwZtVHZf5zOfWix UpGvUCBxZRZX7ZzU8zHvIFpBm+gSdujyJYuSwtPvCveMDOeFFvXqHQGFNtoXQ1hY0L7NDYgN8mI Op0ZLJSPmSqRx/aaPo0xLisoz23Syg6hZ/0+7xnCqXgnYC7GR87UYJBRrRCfV4sPD2/m7mo5lcX o2zBrHC16CEWBP+t3e3Q5LAo0jzKFCc+MlIHbzugMcACgg3jYfJethMCrzMK6WX73JTxnrNVy4J XQ3rw== X-Received: by 2002:a05:600c:8b03:b0:486:fdca:ea8d with SMTP id 5b1f17b1804b1-48727ef5550mr313728095e9.25.1774971850721; Tue, 31 Mar 2026 08:44:10 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:10 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:46 +0400 Subject: [PATCH v6 09/11] mfd: bq257xx: Add BQ25792 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-9-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=19368; i=alchark@flipper.net; h=from:subject:message-id; bh=035uLfC/qCk1SQCGRS8BdnBZsGiJRDyEfYBPzln/PUA=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr2+IXyBIpMNR/fCwHWPHm56e9Un5t6WJ5OzfkqKp dS99sjc0jGRhUGMi8FSTJFl7rcltlON+Gbt8vD4CjOHlQlkiLRIAwMQsDDw5SbmlRrpGOmZahvq GRrqGOsYMXBxCsBUt/EzMux6xjg/O3fHlq4l7I8Ev+a/1jYJvxY4xThq03M1WbE5d44yMnRqaTI kbpFTlr5ppS55RHjHpxUPnnapv8rZsa9TsbluCTcA X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add register definitions and a new 'type' enum to be passed via MFD private data to support the BQ25792, which is a newer variant of the BQ257xx family. BQ25792 shares similar logic of operation with the already supported BQ25703A but has a completely different register map and different electrical constraints. Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/mfd/bq257xx.c | 54 +++++- include/linux/mfd/bq257xx.h | 412 ++++++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 463 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/bq257xx.c b/drivers/mfd/bq257xx.c index e9d49dac0a16..054342c60b73 100644 --- a/drivers/mfd/bq257xx.c +++ b/drivers/mfd/bq257xx.c @@ -39,6 +39,39 @@ static const struct regmap_config bq25703_regmap_config = =3D { .val_format_endian =3D REGMAP_ENDIAN_LITTLE, }; =20 +static const struct regmap_range bq25792_writeable_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG00_MIN_SYS_VOLTAGE, + BQ25792_REG18_NTC_CONTROL_1), + regmap_reg_range(BQ25792_REG28_CHARGER_MASK_0, + BQ25792_REG30_ADC_FUNCTION_DISABLE_1), +}; + +static const struct regmap_access_table bq25792_writeable_regs =3D { + .yes_ranges =3D bq25792_writeable_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_writeable_reg_ranges), +}; + +static const struct regmap_range bq25792_volatile_reg_ranges[] =3D { + regmap_reg_range(BQ25792_REG19_ICO_CURRENT_LIMIT, + BQ25792_REG27_FAULT_FLAG_1), + regmap_reg_range(BQ25792_REG31_IBUS_ADC, + BQ25792_REG47_DPDM_DRIVER), +}; + +static const struct regmap_access_table bq25792_volatile_regs =3D { + .yes_ranges =3D bq25792_volatile_reg_ranges, + .n_yes_ranges =3D ARRAY_SIZE(bq25792_volatile_reg_ranges), +}; + +static const struct regmap_config bq25792_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D BQ25792_REG48_PART_INFORMATION, + .cache_type =3D REGCACHE_MAPLE, + .wr_table =3D &bq25792_writeable_regs, + .volatile_table =3D &bq25792_volatile_regs, +}; + static const struct mfd_cell cells[] =3D { MFD_CELL_NAME("bq257xx-regulator"), MFD_CELL_NAME("bq257xx-charger"), @@ -46,6 +79,7 @@ static const struct mfd_cell cells[] =3D { =20 static int bq257xx_probe(struct i2c_client *client) { + const struct regmap_config *rcfg; struct bq257xx_device *ddata; int ret; =20 @@ -53,9 +87,21 @@ static int bq257xx_probe(struct i2c_client *client) if (!ddata) return -ENOMEM; =20 + ddata->type =3D (uintptr_t)i2c_get_match_data(client); ddata->client =3D client; =20 - ddata->regmap =3D devm_regmap_init_i2c(client, &bq25703_regmap_config); + switch (ddata->type) { + case BQ25703A: + rcfg =3D &bq25703_regmap_config; + break; + case BQ25792: + rcfg =3D &bq25792_regmap_config; + break; + default: + return dev_err_probe(&client->dev, -ENODEV, "Unsupported device type\n"); + } + + ddata->regmap =3D devm_regmap_init_i2c(client, rcfg); if (IS_ERR(ddata->regmap)) { return dev_err_probe(&client->dev, PTR_ERR(ddata->regmap), "Failed to allocate register map\n"); @@ -73,13 +119,15 @@ static int bq257xx_probe(struct i2c_client *client) } =20 static const struct i2c_device_id bq257xx_i2c_ids[] =3D { - { "bq25703a" }, + { "bq25703a", BQ25703A }, + { "bq25792", BQ25792 }, {} }; MODULE_DEVICE_TABLE(i2c, bq257xx_i2c_ids); =20 static const struct of_device_id bq257xx_of_match[] =3D { - { .compatible =3D "ti,bq25703a" }, + { .compatible =3D "ti,bq25703a", .data =3D (void *)BQ25703A }, + { .compatible =3D "ti,bq25792", .data =3D (void *)BQ25792 }, {} }; MODULE_DEVICE_TABLE(of, bq257xx_of_match); diff --git a/include/linux/mfd/bq257xx.h b/include/linux/mfd/bq257xx.h index 1d6ddc7fb09f..4ec72eb920f2 100644 --- a/include/linux/mfd/bq257xx.h +++ b/include/linux/mfd/bq257xx.h @@ -98,7 +98,419 @@ =20 #define BQ25703_EN_OTG_MASK BIT(12) =20 +#define BQ25792_REG00_MIN_SYS_VOLTAGE 0x00 +#define BQ25792_REG01_CHARGE_VOLTAGE_LIMIT 0x01 +#define BQ25792_REG03_CHARGE_CURRENT_LIMIT 0x03 +#define BQ25792_REG05_INPUT_VOLTAGE_LIMIT 0x05 +#define BQ25792_REG06_INPUT_CURRENT_LIMIT 0x06 +#define BQ25792_REG08_PRECHARGE_CONTROL 0x08 +#define BQ25792_REG09_TERMINATION_CONTROL 0x09 +#define BQ25792_REG0A_RECHARGE_CONTROL 0x0a +#define BQ25792_REG0B_VOTG_REGULATION 0x0b +#define BQ25792_REG0D_IOTG_REGULATION 0x0d +#define BQ25792_REG0E_TIMER_CONTROL 0x0e +#define BQ25792_REG0F_CHARGER_CONTROL_0 0x0f +#define BQ25792_REG10_CHARGER_CONTROL_1 0x10 +#define BQ25792_REG11_CHARGER_CONTROL_2 0x11 +#define BQ25792_REG12_CHARGER_CONTROL_3 0x12 +#define BQ25792_REG13_CHARGER_CONTROL_4 0x13 +#define BQ25792_REG14_CHARGER_CONTROL_5 0x14 +/* REG15 reserved */ +#define BQ25792_REG16_TEMPERATURE_CONTROL 0x16 +#define BQ25792_REG17_NTC_CONTROL_0 0x17 +#define BQ25792_REG18_NTC_CONTROL_1 0x18 +#define BQ25792_REG19_ICO_CURRENT_LIMIT 0x19 +#define BQ25792_REG1B_CHARGER_STATUS_0 0x1b +#define BQ25792_REG1C_CHARGER_STATUS_1 0x1c +#define BQ25792_REG1D_CHARGER_STATUS_2 0x1d +#define BQ25792_REG1E_CHARGER_STATUS_3 0x1e +#define BQ25792_REG1F_CHARGER_STATUS_4 0x1f +#define BQ25792_REG20_FAULT_STATUS_0 0x20 +#define BQ25792_REG21_FAULT_STATUS_1 0x21 +#define BQ25792_REG22_CHARGER_FLAG_0 0x22 +#define BQ25792_REG23_CHARGER_FLAG_1 0x23 +#define BQ25792_REG24_CHARGER_FLAG_2 0x24 +#define BQ25792_REG25_CHARGER_FLAG_3 0x25 +#define BQ25792_REG26_FAULT_FLAG_0 0x26 +#define BQ25792_REG27_FAULT_FLAG_1 0x27 +#define BQ25792_REG28_CHARGER_MASK_0 0x28 +#define BQ25792_REG29_CHARGER_MASK_1 0x29 +#define BQ25792_REG2A_CHARGER_MASK_2 0x2a +#define BQ25792_REG2B_CHARGER_MASK_3 0x2b +#define BQ25792_REG2C_FAULT_MASK_0 0x2c +#define BQ25792_REG2D_FAULT_MASK_1 0x2d +#define BQ25792_REG2E_ADC_CONTROL 0x2e +#define BQ25792_REG2F_ADC_FUNCTION_DISABLE_0 0x2f +#define BQ25792_REG30_ADC_FUNCTION_DISABLE_1 0x30 +#define BQ25792_REG31_IBUS_ADC 0x31 +#define BQ25792_REG33_IBAT_ADC 0x33 +#define BQ25792_REG35_VBUS_ADC 0x35 +#define BQ25792_REG37_VAC1_ADC 0x37 +#define BQ25792_REG39_VAC2_ADC 0x39 +#define BQ25792_REG3B_VBAT_ADC 0x3b +#define BQ25792_REG3D_VSYS_ADC 0x3d +#define BQ25792_REG3F_TS_ADC 0x3f +#define BQ25792_REG41_TDIE_ADC 0x41 +#define BQ25792_REG43_DP_ADC 0x43 +#define BQ25792_REG45_DM_ADC 0x45 +#define BQ25792_REG47_DPDM_DRIVER 0x47 +#define BQ25792_REG48_PART_INFORMATION 0x48 + +/* Minimal System Voltage */ +#define BQ25792_REG00_VSYSMIN_MASK GENMASK(5, 0) + +#define BQ25792_MINVSYS_MIN_UV 2500000 +#define BQ25792_MINVSYS_STEP_UV 250000 +#define BQ25792_MINVSYS_MAX_UV 16000000 + +/* Charge Voltage Limit */ +#define BQ25792_REG01_VREG_MASK GENMASK(10, 0) + +#define BQ25792_VBATREG_MIN_UV 3000000 +#define BQ25792_VBATREG_STEP_UV 10000 +#define BQ25792_VBATREG_MAX_UV 18800000 + +/* Charge Current Limit */ +#define BQ25792_REG03_ICHG_MASK GENMASK(8, 0) + +#define BQ25792_ICHG_MIN_UA 50000 +#define BQ25792_ICHG_STEP_UA 10000 +#define BQ25792_ICHG_MAX_UA 5000000 + +/* Input Voltage Limit */ +#define BQ25792_REG05_VINDPM_MASK GENMASK(7, 0) + +/* Input Current Limit */ +#define BQ25792_REG06_IINDPM_MASK GENMASK(8, 0) +#define BQ25792_IINDPM_DEFAULT_UA 3000000 +#define BQ25792_IINDPM_STEP_UA 10000 +#define BQ25792_IINDPM_MIN_UA 100000 +#define BQ25792_IINDPM_MAX_UA 3300000 + +/* Precharge Control */ +#define BQ25792_REG08_VBAT_LOWV_MASK GENMASK(7, 6) +#define BQ25792_REG08_IPRECHG_MASK GENMASK(5, 0) + +/* Termination Control */ +#define BQ25792_REG09_REG_RST BIT(6) +#define BQ25792_REG09_ITERM_MASK GENMASK(4, 0) + +/* Re-charge Control */ +#define BQ25792_REG0A_CELL_MASK GENMASK(7, 6) +#define BQ25792_REG0A_TRECHG_MASK GENMASK(5, 4) +#define BQ25792_REG0A_VRECHG_MASK GENMASK(3, 0) + +/* VOTG regulation */ +#define BQ25792_REG0B_VOTG_MASK GENMASK(10, 0) + +#define BQ25792_OTG_VOLT_MIN_UV 2800000 +#define BQ25792_OTG_VOLT_STEP_UV 10000 +#define BQ25792_OTG_VOLT_MAX_UV 22000000 +#define BQ25792_OTG_VOLT_NUM_VOLT ((BQ25792_OTG_VOLT_MAX_UV \ + - BQ25792_OTG_VOLT_MIN_UV) \ + / BQ25792_OTG_VOLT_STEP_UV + 1) + +/* IOTG regulation */ +#define BQ25792_REG0D_PRECHG_TMR BIT(7) +#define BQ25792_REG0D_IOTG_MASK GENMASK(6, 0) + +#define BQ25792_OTG_CUR_MIN_UA 120000 +#define BQ25792_OTG_CUR_STEP_UA 40000 +#define BQ25792_OTG_CUR_MAX_UA 3320000 + +/* Timer Control */ +#define BQ25792_REG0E_TOPOFF_TMR_MASK GENMASK(7, 6) +#define BQ25792_REG0E_EN_TRICHG_TMR BIT(5) +#define BQ25792_REG0E_EN_PRECHG_TMR BIT(4) +#define BQ25792_REG0E_EN_CHG_TMR BIT(3) +#define BQ25792_REG0E_CHG_TMR_MASK GENMASK(2, 1) +#define BQ25792_REG0E_TMR2X_EN BIT(0) + +/* Charger Control 0 */ +#define BQ25792_REG0F_EN_AUTO_IBATDIS BIT(7) +#define BQ25792_REG0F_FORCE_IBATDIS BIT(6) +#define BQ25792_REG0F_EN_CHG BIT(5) +#define BQ25792_REG0F_EN_ICO BIT(4) +#define BQ25792_REG0F_FORCE_ICO BIT(3) +#define BQ25792_REG0F_EN_HIZ BIT(2) +#define BQ25792_REG0F_EN_TERM BIT(1) +/* bit0 reserved */ + +/* Charger Control 1 */ +#define BQ25792_REG10_VAC_OVP_MASK GENMASK(5, 4) +#define BQ25792_REG10_WD_RST BIT(3) +#define BQ25792_REG10_WATCHDOG_MASK GENMASK(2, 0) + +/* Charger Control 2 */ +#define BQ25792_REG11_FORCE_INDET BIT(7) +#define BQ25792_REG11_AUTO_INDET_EN BIT(6) +#define BQ25792_REG11_EN_12V BIT(5) +#define BQ25792_REG11_EN_9V BIT(4) +#define BQ25792_REG11_HVDCP_EN BIT(3) +#define BQ25792_REG11_SDRV_CTRL_MASK GENMASK(2, 1) +#define BQ25792_REG11_SDRV_DLY BIT(0) + +/* Charger Control 3 */ +#define BQ25792_REG12_DIS_ACDRV BIT(7) +#define BQ25792_REG12_EN_OTG BIT(6) +#define BQ25792_REG12_PFM_OTG_DIS BIT(5) +#define BQ25792_REG12_PFM_FWD_DIS BIT(4) +#define BQ25792_REG12_WKUP_DLY BIT(3) +#define BQ25792_REG12_DIS_LDO BIT(2) +#define BQ25792_REG12_DIS_OTG_OOA BIT(1) +#define BQ25792_REG12_DIS_FWD_OOA BIT(0) + +/* Charger Control 4 */ +#define BQ25792_REG13_EN_ACDRV2 BIT(7) +#define BQ25792_REG13_EN_ACDRV1 BIT(6) +#define BQ25792_REG13_PWM_FREQ BIT(5) +#define BQ25792_REG13_DIS_STAT BIT(4) +#define BQ25792_REG13_DIS_VSYS_SHORT BIT(3) +#define BQ25792_REG13_DIS_VOTG_UVP BIT(2) +#define BQ25792_REG13_FORCE_VINDPM_DET BIT(1) +#define BQ25792_REG13_EN_IBUS_OCP BIT(0) + +/* Charger Control 5 */ +#define BQ25792_REG14_SFET_PRESENT BIT(7) +/* bit6 reserved */ +#define BQ25792_REG14_EN_IBAT BIT(5) +#define BQ25792_REG14_IBAT_REG_MASK GENMASK(4, 3) +#define BQ25792_REG14_EN_IINDPM BIT(2) +#define BQ25792_REG14_EN_EXTILIM BIT(1) +#define BQ25792_REG14_EN_BATOC BIT(0) + +#define BQ25792_IBAT_3A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 0) +#define BQ25792_IBAT_4A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 1) +#define BQ25792_IBAT_5A FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 2) +#define BQ25792_IBAT_UNLIM FIELD_PREP(BQ25792_REG14_IBAT_REG_MASK, 3) + +/* Temperature Control */ +#define BQ25792_REG16_TREG_MASK GENMASK(7, 6) +#define BQ25792_REG16_TSHUT_MASK GENMASK(5, 4) +#define BQ25792_REG16_VBUS_PD_EN BIT(3) +#define BQ25792_REG16_VAC1_PD_EN BIT(2) +#define BQ25792_REG16_VAC2_PD_EN BIT(1) + +/* NTC Control 0 */ +#define BQ25792_REG17_JEITA_VSET_MASK GENMASK(7, 5) +#define BQ25792_REG17_JEITA_ISETH_MASK GENMASK(4, 3) +#define BQ25792_REG17_JEITA_ISETC_MASK GENMASK(2, 1) + +/* NTC Control 1 */ +#define BQ25792_REG18_TS_COOL_MASK GENMASK(7, 6) +#define BQ25792_REG18_TS_WARM_MASK GENMASK(5, 4) +#define BQ25792_REG18_BHOT_MASK GENMASK(3, 2) +#define BQ25792_REG18_BCOLD BIT(1) +#define BQ25792_REG18_TS_IGNORE BIT(0) + +/* ICO Current Limit */ +#define BQ25792_REG19_ICO_ILIM_MASK GENMASK(8, 0) + +/* Charger Status 0 */ +#define BQ25792_REG1B_IINDPM_STAT BIT(7) +#define BQ25792_REG1B_VINDPM_STAT BIT(6) +#define BQ25792_REG1B_WD_STAT BIT(5) +#define BQ25792_REG1B_POORSRC_STAT BIT(4) +#define BQ25792_REG1B_PG_STAT BIT(3) +#define BQ25792_REG1B_AC2_PRESENT_STAT BIT(2) +#define BQ25792_REG1B_AC1_PRESENT_STAT BIT(1) +#define BQ25792_REG1B_VBUS_PRESENT_STAT BIT(0) + +/* Charger Status 1 */ +#define BQ25792_REG1C_CHG_STAT_MASK GENMASK(7, 5) +#define BQ25792_REG1C_VBUS_STAT_MASK GENMASK(4, 1) +#define BQ25792_REG1C_BC12_DONE_STAT BIT(0) + +/* Charger Status 2 */ +#define BQ25792_REG1D_ICO_STAT_MASK GENMASK(7, 6) +#define BQ25792_REG1D_TREG_STAT BIT(2) +#define BQ25792_REG1D_DPDM_STAT BIT(1) +#define BQ25792_REG1D_VBAT_PRESENT_STAT BIT(0) + +/* Charger Status 3 */ +#define BQ25792_REG1E_ACRB2_STAT BIT(7) +#define BQ25792_REG1E_ACRB1_STAT BIT(6) +#define BQ25792_REG1E_ADC_DONE_STAT BIT(5) +#define BQ25792_REG1E_VSYS_STAT BIT(4) +#define BQ25792_REG1E_CHG_TMR_STAT BIT(3) +#define BQ25792_REG1E_TRICHG_TMR_STAT BIT(2) +#define BQ25792_REG1E_PRECHG_TMR_STAT BIT(1) + +/* Charger Status 4 */ +#define BQ25792_REG1F_VBATOTG_LOW_STAT BIT(4) +#define BQ25792_REG1F_TS_COLD_STAT BIT(3) +#define BQ25792_REG1F_TS_COOL_STAT BIT(2) +#define BQ25792_REG1F_TS_WARM_STAT BIT(1) +#define BQ25792_REG1F_TS_HOT_STAT BIT(0) + +/* FAULT Status 0 */ +#define BQ25792_REG20_IBAT_REG_STAT BIT(7) +#define BQ25792_REG20_VBUS_OVP_STAT BIT(6) +#define BQ25792_REG20_VBAT_OVP_STAT BIT(5) +#define BQ25792_REG20_IBUS_OCP_STAT BIT(4) +#define BQ25792_REG20_IBAT_OCP_STAT BIT(3) +#define BQ25792_REG20_CONV_OCP_STAT BIT(2) +#define BQ25792_REG20_VAC2_OVP_STAT BIT(1) +#define BQ25792_REG20_VAC1_OVP_STAT BIT(0) + +#define BQ25792_REG20_OVERVOLTAGE_MASK (BQ25792_REG20_VBAT_OVP_STAT | \ + BQ25792_REG20_VAC2_OVP_STAT | \ + BQ25792_REG20_VAC1_OVP_STAT) +#define BQ25792_REG20_OVERCURRENT_MASK (BQ25792_REG20_IBAT_OCP_STAT | \ + BQ25792_REG20_CONV_OCP_STAT) + +/* FAULT Status 1 */ +#define BQ25792_REG21_VSYS_SHORT_STAT BIT(7) +#define BQ25792_REG21_VSYS_OVP_STAT BIT(6) +#define BQ25792_REG21_OTG_OVP_STAT BIT(5) +#define BQ25792_REG21_OTG_UVP_STAT BIT(4) +#define BQ25792_REG21_TSHUT_STAT BIT(2) + + +/* Charger Flag 0 */ +#define BQ25792_REG22_IINDPM_FLAG BIT(7) +#define BQ25792_REG22_VINDPM_FLAG BIT(6) +#define BQ25792_REG22_WD_FLAG BIT(5) +#define BQ25792_REG22_POORSRC_FLAG BIT(4) +#define BQ25792_REG22_PG_FLAG BIT(3) +#define BQ25792_REG22_AC2_PRESENT_FLAG BIT(2) +#define BQ25792_REG22_AC1_PRESENT_FLAG BIT(1) +#define BQ25792_REG22_VBUS_PRESENT_FLAG BIT(0) + +/* Charger Flag 1 */ +#define BQ25792_REG23_CHG_FLAG BIT(7) +#define BQ25792_REG23_ICO_FLAG BIT(6) +#define BQ25792_REG23_VBUS_FLAG BIT(4) +#define BQ25792_REG23_TREG_FLAG BIT(2) +#define BQ25792_REG23_VBAT_PRESENT_FLAG BIT(1) +#define BQ25792_REG23_BC12_DONE_FLAG BIT(0) + +/* Charger Flag 2 */ +#define BQ25792_REG24_DPDM_DONE_FLAG BIT(6) +#define BQ25792_REG24_ADC_DONE_FLAG BIT(5) +#define BQ25792_REG24_VSYS_FLAG BIT(4) +#define BQ25792_REG24_CHG_TMR_FLAG BIT(3) +#define BQ25792_REG24_TRICHG_TMR_FLAG BIT(2) +#define BQ25792_REG24_PRECHG_TMR_FLAG BIT(1) +#define BQ25792_REG24_TOPOFF_TMR_FLAG BIT(0) + +/* Charger Flag 3 */ +#define BQ25792_REG25_VBATOTG_LOW_FLAG BIT(4) +#define BQ25792_REG25_TS_COLD_FLAG BIT(3) +#define BQ25792_REG25_TS_COOL_FLAG BIT(2) +#define BQ25792_REG25_TS_WARM_FLAG BIT(1) +#define BQ25792_REG25_TS_HOT_FLAG BIT(0) + +/* FAULT Flag 0 */ +#define BQ25792_REG26_IBAT_REG_FLAG BIT(7) +#define BQ25792_REG26_VBUS_OVP_FLAG BIT(6) +#define BQ25792_REG26_VBAT_OVP_FLAG BIT(5) +#define BQ25792_REG26_IBUS_OCP_FLAG BIT(4) +#define BQ25792_REG26_IBAT_OCP_FLAG BIT(3) +#define BQ25792_REG26_CONV_OCP_FLAG BIT(2) +#define BQ25792_REG26_VAC2_OVP_FLAG BIT(1) +#define BQ25792_REG26_VAC1_OVP_FLAG BIT(0) + +/* FAULT Flag 1 */ +#define BQ25792_REG27_VSYS_SHORT_FLAG BIT(7) +#define BQ25792_REG27_VSYS_OVP_FLAG BIT(6) +#define BQ25792_REG27_OTG_OVP_FLAG BIT(5) +#define BQ25792_REG27_OTG_UVP_FLAG BIT(4) +#define BQ25792_REG27_TSHUT_FLAG BIT(2) + +/* Charger Mask 0 */ +#define BQ25792_REG28_IINDPM_MASK BIT(7) +#define BQ25792_REG28_VINDPM_MASK BIT(6) +#define BQ25792_REG28_WD_MASK BIT(5) +#define BQ25792_REG28_POORSRC_MASK BIT(4) +#define BQ25792_REG28_PG_MASK BIT(3) +#define BQ25792_REG28_AC2_PRESENT_MASK BIT(2) +#define BQ25792_REG28_AC1_PRESENT_MASK BIT(1) +#define BQ25792_REG28_VBUS_PRESENT_MASK BIT(0) + +/* Charger Mask 1 */ +#define BQ25792_REG29_CHG_MASK BIT(7) +#define BQ25792_REG29_ICO_MASK BIT(6) +#define BQ25792_REG29_VBUS_MASK BIT(4) +#define BQ25792_REG29_TREG_MASK BIT(2) +#define BQ25792_REG29_VBAT_PRESENT_MASK BIT(1) +#define BQ25792_REG29_BC12_DONE_MASK BIT(0) + +/* Charger Mask 2 */ +#define BQ25792_REG2A_DPDM_DONE_MASK BIT(6) +#define BQ25792_REG2A_ADC_DONE_MASK BIT(5) +#define BQ25792_REG2A_VSYS_MASK BIT(4) +#define BQ25792_REG2A_CHG_TMR_MASK BIT(3) +#define BQ25792_REG2A_TRICHG_TMR_MASK BIT(2) +#define BQ25792_REG2A_PRECHG_TMR_MASK BIT(1) +#define BQ25792_REG2A_TOPOFF_TMR_MASK BIT(0) + +/* Charger Mask 3 */ +#define BQ25792_REG2B_VBATOTG_LOW_MASK BIT(4) +#define BQ25792_REG2B_TS_COLD_MASK BIT(3) +#define BQ25792_REG2B_TS_COOL_MASK BIT(2) +#define BQ25792_REG2B_TS_WARM_MASK BIT(1) +#define BQ25792_REG2B_TS_HOT_MASK BIT(0) + +/* FAULT Mask 0 */ +#define BQ25792_REG2C_IBAT_REG_MASK BIT(7) +#define BQ25792_REG2C_VBUS_OVP_MASK BIT(6) +#define BQ25792_REG2C_VBAT_OVP_MASK BIT(5) +#define BQ25792_REG2C_IBUS_OCP_MASK BIT(4) +#define BQ25792_REG2C_IBAT_OCP_MASK BIT(3) +#define BQ25792_REG2C_CONV_OCP_MASK BIT(2) +#define BQ25792_REG2C_VAC2_OVP_MASK BIT(1) +#define BQ25792_REG2C_VAC1_OVP_MASK BIT(0) + +/* FAULT Mask 1 */ +#define BQ25792_REG2D_VSYS_SHORT_MASK BIT(7) +#define BQ25792_REG2D_VSYS_OVP_MASK BIT(6) +#define BQ25792_REG2D_OTG_OVP_MASK BIT(5) +#define BQ25792_REG2D_OTG_UVP_MASK BIT(4) +#define BQ25792_REG2D_TSHUT_MASK BIT(2) + +/* ADC Control */ +#define BQ25792_REG2E_ADC_EN BIT(7) +#define BQ25792_REG2E_ADC_RATE BIT(6) +#define BQ25792_REG2E_ADC_SAMPLE_MASK GENMASK(5, 4) +#define BQ25792_REG2E_ADC_AVG BIT(3) +#define BQ25792_REG2E_ADC_AVG_INIT BIT(2) + +/* ADC Function Disable 0 */ +#define BQ25792_REG2F_IBUS_ADC_DIS BIT(7) +#define BQ25792_REG2F_IBAT_ADC_DIS BIT(6) +#define BQ25792_REG2F_VBUS_ADC_DIS BIT(5) +#define BQ25792_REG2F_VBAT_ADC_DIS BIT(4) +#define BQ25792_REG2F_VSYS_ADC_DIS BIT(3) +#define BQ25792_REG2F_TS_ADC_DIS BIT(2) +#define BQ25792_REG2F_TDIE_ADC_DIS BIT(1) + +/* ADC Function Disable 1 */ +#define BQ25792_REG30_DP_ADC_DIS BIT(7) +#define BQ25792_REG30_DM_ADC_DIS BIT(6) +#define BQ25792_REG30_VAC2_ADC_DIS BIT(5) +#define BQ25792_REG30_VAC1_ADC_DIS BIT(4) + +/* 0x31-0x45: ADC result registers (16-bit, RO): single full-width field */ + +#define BQ25792_ADCVSYSVBAT_STEP_UV 1000 +#define BQ25792_ADCIBAT_STEP_UA 1000 + +/* DPDM Driver */ +#define BQ25792_REG47_DPLUS_DAC_MASK GENMASK(7, 5) +#define BQ25792_REG47_DMINUS_DAC_MASK GENMASK(4, 2) + +/* Part Information */ +#define BQ25792_REG48_PN_MASK GENMASK(5, 3) +#define BQ25792_REG48_DEV_REV_MASK GENMASK(2, 0) + +enum bq257xx_type { + BQ25703A =3D 1, + BQ25792, +}; + struct bq257xx_device { struct i2c_client *client; struct regmap *regmap; + enum bq257xx_type type; }; --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10A00423A83 for ; Tue, 31 Mar 2026 15:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971856; cv=none; b=RuDuzmFKQ5yvgiki1ExJeIsqrSDxbAY1yfVXkPWwnK5gTRtG6xobb0TZ0vZwBklYEmuWpIqx+hrdJsYb3FQyeFNiEuUEfMxn+/PzKPctWiILFCNDFthoJ4xqkBximOWtodB8u+5sW6LEEp8AfFf9R4qw+yYb1v2ZLTayNqbhg8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971856; c=relaxed/simple; bh=q9BptJDuAQnjOV/HxIZuYo7P6hJdxkSiFaoHcUpNVb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZMrOSjrRCZwezYOAXvBIvjrplMKHYwxtSDFE0t/YohCUwJzP6WR2lE09wbNWSTlcABibT78ypbNUWv7GquCr+OC19cVwqzC3rU8Y2EoHdHiVPl/DsLqLoVEsv2KevCk4eUqlskLfT4lpcPu8+PYPDBF6ppLPFdBmu1di2ivmYcQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=jlMXsJjA; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="jlMXsJjA" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486fb112c09so54589765e9.1 for ; Tue, 31 Mar 2026 08:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971853; x=1775576653; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gzdSIakIBsa879u0fxfflVhMlKymXjPa/1rJ4QxUnO8=; b=jlMXsJjAOg5oD7hc1Dj08nUdrf56nun6f/NabowWGpajBW5IqfUezrzyfOx+qGlEB9 dBa4uc2dRNmYI+Al5OOkfxSSPFGZ6n29F6hJ4KlznTl0wSiDIbgg0N0MwjKzmJS5BqY8 bkhF2mMmenbl3P5IAGgnGPOjHaf9t5hok+nRi9M1syVRwMpFLT54vfXHtjxgp0xF0AeA c36Dl+Mk3gUiP3e0v1r0EAZT+du5HhhFOpIhmYe/MkK2JP41KD4sTpbslCbXb5VCZQrC LSAcQQb8Q6+zMq8RsihDkru4CXb3/QRdPxvKj1CdAx7tw0BxFXep+nIoA/rQGmrKPgiS bkag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971853; x=1775576653; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gzdSIakIBsa879u0fxfflVhMlKymXjPa/1rJ4QxUnO8=; b=ae068nfe4frRcZvzyqaNYvpPrm1XgRD6AuPKwPfLermQAjZuvscoW5TWLjtD6oTFku K3ISnz+ink2TZg+w4+KlOFblTn8Sb9IBh23Tf6lrWme6KoLmnDL9DDsMPhTipjsBZYlE qv4vlf67MgX5B34sYUVl4wOT8z7fHc7GZMX9m6dRPktyqlxjCLyi109+O9WV3XI+76mL d3U2oRgyrCfsXox1KaX3wohJqbU4bJxnpM3BIlUvyMr84aacwgNgOya5Fh2J+7/npI2u rh9GsL0eoP2v/AXBA6vgrLuDaln5XW+yqGmPj6P4j2ds18+y3YE0fOIz4fIW3KpfRF/G A5Sw== X-Forwarded-Encrypted: i=1; AJvYcCV/dzaz82w4hJl984fPL7vrJ/85NOAvamgIro8vRtGnk2IBxghOD32JITuyfM/CZOC7IzhdOndgvDjj3q0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcwKjOygpw/5YeroD+J/LBRu7R7C7cU7IqbwGVy/ABZhbhRKw0 M7HJ+L5rwxMAVbUDzGoA4Tos7E7nj8wtbUKRvmQpWK+Y3vrB/aX9D3eHaNTAXsYw3kk= X-Gm-Gg: ATEYQzzZEWZDgNm+uxw6Wc5la+fiPXnehj3d6xxP+3b+m66SHU185EVLZ/h2ociqpka VsulV5c84sdUpCdSqfYUCMWiY5q3xhuMhJ6mtrzCvK+8HGsQ2UTfNwPLgEgObr7cU88vEHeMUtu QRqxrkDRqaRh4tREOe0zR497ZhLwVZjbjXLKBV8A06ay+VFVZTSSy9EnUFY47GG7p9zmC8mASQF zUFFLz0Ic/9FIF/FK6dhVWOvORoT0LjZsrbNJeTOmniBij8eSReyE1x97JBb0Vh1QqYVRE1bhwF 68ghesXKNGBBPItKNAVVw1WHIVLfzf5IRwX4b59iTZECvBhhT1vLmcnN04amcJCP5OmOB28wQGR CoKmcvbElyhoyUvaRfd1pfOnxkp0gkBspNC/yfGWGvXUwqFhOvKzcQYapuVJLByhR59yl7GgPYu /XujABWhU1+TaMJPNFNhuEPeuxQ0nOzPQoDUx8dbVc/6G6xUslt2pRqSvjJ1sAPk4G7JSnL93Ln RZs7Q== X-Received: by 2002:a05:600d:7:b0:485:439b:683f with SMTP id 5b1f17b1804b1-48727f5fe73mr231743725e9.20.1774971853323; Tue, 31 Mar 2026 08:44:13 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:13 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:47 +0400 Subject: [PATCH v6 10/11] regulator: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-10-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=5094; i=alchark@flipper.net; h=from:subject:message-id; bh=q9BptJDuAQnjOV/HxIZuYo7P6hJdxkSiFaoHcUpNVb0=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr1+nnr8Vq/ebevVT8ZJSTIv+7aPtey6+pzVRxW3P Y8WenHneMdEFgYxLgZLMUWWud+W2E414pu1y8PjK8wcViaQIdIiDQxAwMLAl5uYV2qkY6Rnqm2o Z2ioY6xjxMDFKQBT3dLIyPCjuZlBa44m3w1nCR0Tp7hfc77fmn1IcXXChJ0bTRk17YIY/js8CHm pKfDl7/XrCVceKicdmlnw/5dXmuGGoOeT77C77OIAAA== X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792, an integrated battery charger and buck/boost regulator. This enables VBUS output from the charger's boost converter for use in USB OTG applications, supporting 2.8-22V output at up to 3.32A with 10mV and 40mA resolution. Acked-by: Mark Brown Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/regulator/bq257xx-regulator.c | 98 +++++++++++++++++++++++++++++++= +++- 1 file changed, 97 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq25= 7xx-regulator.c index 0bb58ab4b8d4..f197162382cc 100644 --- a/drivers/regulator/bq257xx-regulator.c +++ b/drivers/regulator/bq257xx-regulator.c @@ -31,6 +31,32 @@ static int bq25703_vbus_get_cur_limit(struct regulator_d= ev *rdev) return FIELD_GET(BQ25703_OTG_CUR_MASK, reg) * BQ25703_OTG_CUR_STEP_UA; } =20 +static int bq25792_vbus_get_cur_limit(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + int ret; + unsigned int reg; + + ret =3D regmap_read(regmap, BQ25792_REG0D_IOTG_REGULATION, ®); + if (ret) + return ret; + return FIELD_GET(BQ25792_REG0D_IOTG_MASK, reg) * BQ25792_OTG_CUR_STEP_UA; +} + +static int bq25792_vbus_get_voltage_sel(struct regulator_dev *rdev) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + int ret; + + ret =3D regmap_raw_read(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); + if (ret) + return ret; + + return FIELD_GET(BQ25792_REG0B_VOTG_MASK, be16_to_cpu(reg)); +} + /* * Check if the minimum current and maximum current requested are * sane values, then set the register accordingly. @@ -54,6 +80,37 @@ static int bq25703_vbus_set_cur_limit(struct regulator_d= ev *rdev, FIELD_PREP(BQ25703_OTG_CUR_MASK, reg)); } =20 +static int bq25792_vbus_set_cur_limit(struct regulator_dev *rdev, + int min_uA, int max_uA) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + unsigned int reg; + + if ((min_uA > BQ25792_OTG_CUR_MAX_UA) || + (max_uA < BQ25792_OTG_CUR_MIN_UA)) + return -EINVAL; + + reg =3D (max_uA / BQ25792_OTG_CUR_STEP_UA); + + /* Catch rounding errors since our step is 40000uA. */ + if ((reg * BQ25792_OTG_CUR_STEP_UA) < min_uA) + return -EINVAL; + + return regmap_write(regmap, BQ25792_REG0D_IOTG_REGULATION, + FIELD_PREP(BQ25792_REG0D_IOTG_MASK, reg)); +} + +static int bq25792_vbus_set_voltage_sel(struct regulator_dev *rdev, + unsigned int sel) +{ + struct regmap *regmap =3D rdev_get_regmap(rdev); + __be16 reg; + + reg =3D cpu_to_be16(FIELD_PREP(BQ25792_REG0B_VOTG_MASK, sel)); + return regmap_raw_write(regmap, BQ25792_REG0B_VOTG_REGULATION, + ®, sizeof(reg)); +} + static int bq25703_vbus_enable(struct regulator_dev *rdev) { struct bq257xx_reg_data *pdata =3D rdev_get_drvdata(rdev); @@ -101,6 +158,34 @@ static const struct regulator_desc bq25703_vbus_desc = =3D { .vsel_mask =3D BQ25703_OTG_VOLT_MASK, }; =20 +static const struct regulator_ops bq25792_vbus_ops =3D { + /* No GPIO for enabling the OTG regulator */ + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_linear, + .get_voltage_sel =3D bq25792_vbus_get_voltage_sel, + .set_voltage_sel =3D bq25792_vbus_set_voltage_sel, + .get_current_limit =3D bq25792_vbus_get_cur_limit, + .set_current_limit =3D bq25792_vbus_set_cur_limit, +}; + +static const struct regulator_desc bq25792_vbus_desc =3D { + .name =3D "vbus", + .of_match =3D of_match_ptr("vbus"), + .regulators_node =3D of_match_ptr("regulators"), + .type =3D REGULATOR_VOLTAGE, + .owner =3D THIS_MODULE, + .ops =3D &bq25792_vbus_ops, + .min_uV =3D BQ25792_OTG_VOLT_MIN_UV, + .uV_step =3D BQ25792_OTG_VOLT_STEP_UV, + .n_voltages =3D BQ25792_OTG_VOLT_NUM_VOLT, + .enable_mask =3D BQ25792_REG12_EN_OTG, + .enable_reg =3D BQ25792_REG12_CHARGER_CONTROL_3, + .enable_val =3D BQ25792_REG12_EN_OTG, + .disable_val =3D 0, +}; + /* Get optional GPIO for OTG regulator enable. */ static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev) { @@ -141,6 +226,7 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_d= evice *pdev) static int bq257xx_regulator_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; + struct bq257xx_device *bq =3D dev_get_drvdata(pdev->dev.parent); struct bq257xx_reg_data *pdata; struct device_node *np =3D dev->of_node; struct regulator_config cfg =3D {}; @@ -153,7 +239,17 @@ static int bq257xx_regulator_probe(struct platform_dev= ice *pdev) if (!pdata) return -ENOMEM; =20 - pdata->desc =3D bq25703_vbus_desc; + switch (bq->type) { + case BQ25703A: + pdata->desc =3D bq25703_vbus_desc; + break; + case BQ25792: + pdata->desc =3D bq25792_vbus_desc; + break; + default: + return dev_err_probe(&pdev->dev, -EINVAL, + "Unsupported device type\n"); + } =20 platform_set_drvdata(pdev, pdata); bq257xx_reg_dt_parse_gpio(pdev); --=20 2.52.0 From nobody Wed Apr 1 09:46:28 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD130425CCB for ; Tue, 31 Mar 2026 15:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971861; cv=none; b=C0KnI9x5uOEAZAlA2R1VL2mUpi/wApf0/RGsiJncAELJKxn81ubjyo8+zLxAwXj4B4u84zZmqc1QaBJeBQU3KFQY7XJvje9nCWnoU/VHU0gDrXfb78Z1yecHbpUh9ZR5+z1cF0cLwGjFqK5bH72APmVeOIhkeZiHxr6iLSjyPHA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774971861; c=relaxed/simple; bh=VW4PGKQbMprs05QZjLUFAcp7NQ6qIj6tfIjDvxiwqeE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WVrbvzqEwdYkZdOTgWj4U5jlsr6c6fMIZWnKZtA6fGtZ+ygo6AxOQMyAiUtAOQIdJa0xM0DnphDQic4CTAItuPs1rrpr3ItcZGDvPjAtQlPNy4WUCktdpuLBxwH9lxgJDRKwwMoIxB1eW1ygo2rF0aWFvRORrGYQ0fYd/qF9I0M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=VhLBB9WE; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="VhLBB9WE" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fb112c09so54590585e9.1 for ; Tue, 31 Mar 2026 08:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1774971857; x=1775576657; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HJBOPz5cenCqobIA2pP3hpiRljJx71ZTKxf/DvRJSFg=; b=VhLBB9WEzyBni7AnFCRNCE1beaZmO0EKVkAiJFBOlLC9pH4pTuMN6VXB37sn50y8/N aZc95oF9m/mS1aKsXOsnwWc7u9MTPJX2IzAbv2cK5XVxzq92oGYaKKKVzM5hTUyGCXQJ X9aku6RUH7YROThmsaAvS6RnQpI7MJOv7ztyxvvtc5z8y2W3w4zFG+iQ8JPFa74C1gnX +GA8b0rANtjUIqdzbR4X+3ylfoS74XlaKHCfsTbXbALQ3qY3OIH6aUBT0wkwWcTG6qOV Q726Xjqh07RnGIqSB061JfyvfYLiTJeUPKTM4J5gLstcyo11QIxw0ZUXxqzvvlcpIs7q 0+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774971857; x=1775576657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HJBOPz5cenCqobIA2pP3hpiRljJx71ZTKxf/DvRJSFg=; b=TIMP6bpZLgTj4QWDnIlG+JbXVHCRo2or0XiG9zjcE8apCd4mjahWX97cid2Gb+bMZv P+DH+4Kot0vSmfTVuegFSl1+BVVZ8PNEOPDxsVID7kqpXR2Jde2OQyJwIyt+lnHdk/xy ngtM3Nkr+HrXwb5fi8fl+mvVHyJfbakfAQiXRiFJJmgTSDEk+qfWYJTKF3GXNlosveIO L7n1Z2sPf080WYS0mqLSPV/F8Fj8ZlNJ2vMfKAlSGG1rRyNeQkfvePnA5TdqdEfZ1PVw 2V8FaB1DNXkUvh0yr1byflbZvpVZP3MQij931TTrozJV/HECm/haaUllJ8siaEy8yXm2 7lSA== X-Forwarded-Encrypted: i=1; AJvYcCVCvW3LK6i4Gjq992btGwTK4nlHMMdZnK3jHKCLDufTuC3NvBpzjGWCo/J6Z7egpduOWEjVDkPb1o5t78M=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz1TqUQkjJ+Ndr73vxEEp2lR9OR8pmdGw/ZpS41547THdFfEbw TmZvAwdnMInyNC+/V5wqKDYBbxDW5n84acbvLB9WPAmCqkQ+L3v13W+LtWxXx5IR8CE= X-Gm-Gg: ATEYQzz7A/3jBExDKB8Vl5vjKSA30a7T8Y4WkXdmI4VkFaBCA4kIOroOCWrTdfLnvBI jyBPT8apEbCsEi1NGzgcKe44GoFf7uY+aJuNLMrVJOTHfnbsKvBnAqgBowQ4lMa6WNR9NfNMJcq vRCngaIEBL8ju6QjiHQfEVvq+yCV3H7CmsHmuqNS+9yUsUmt5nWaazX8i9kaXtiwzeqK47EJrbj Nx3B24ke4sBFnmYYx/STIiIwJCHsJYGxMZ1bwVU+7RawiuJqXGX9EHAPYPpS5+2Mk51YISbknS/ RYc0DBEGgnISAtfB7GV0FT2lPgoV4BD8getJ3tRZj6JsxTBWss6Z79oDurLZV4zH4uddb/62ttS xtu1MlunVoz8+wqAM2x2MfZ9rSKhROd4vi3YP6NnxqVeHmCTnTorbPa5VXwEES98VEtC8GOKQ33 vzGjvvfhxE4WJd8/IOmZ09sDEqRNtqQNb8UnVeiB7uhm84wBE1t/mZHgtDJ0Qsu+lc1Bjy9G2jk dcTnA== X-Received: by 2002:a05:600c:8215:b0:485:3baa:af14 with SMTP id 5b1f17b1804b1-48727f5f985mr265707625e9.18.1774971856859; Tue, 31 Mar 2026 08:44:16 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c8852a5sm48412605e9.9.2026.03.31.08.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 08:44:16 -0700 (PDT) From: Alexey Charkov Date: Tue, 31 Mar 2026 19:43:48 +0400 Subject: [PATCH v6 11/11] power: supply: bq257xx: Add support for BQ25792 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-bq25792-v6-11-0278fba33eb9@flipper.net> References: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> In-Reply-To: <20260331-bq25792-v6-0-0278fba33eb9@flipper.net> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chris Morgan , Liam Girdwood , Mark Brown , Sebastian Reichel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=20378; i=alchark@flipper.net; h=from:subject:message-id; bh=VW4PGKQbMprs05QZjLUFAcp7NQ6qIj6tfIjDvxiwqeE=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWSefr3hAc9He6P7a7vSu7vT+NW+CFpLu9tGvPWVUfp0b D33nL4NHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEy16AOGfxaM6fNbfC8paKjnLDZPq268a8oRcN/22HrVhYuca3n97BgZroslMZQ G1U6YXFZ7pyjPrsr7xZtXU7teRnjyXDw1JVuBHQA= X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Add support for TI BQ25792 integrated battery charger and buck-boost converter. It shares high-level logic of operation with the already supported BQ25703A, but has a different register map, bit definitions and some of the lower-level hardware states. Tested-by: Chris Morgan Signed-off-by: Alexey Charkov --- drivers/power/supply/bq257xx_charger.c | 482 +++++++++++++++++++++++++++++= +++- 1 file changed, 481 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq257xx_charger.c b/drivers/power/supply/= bq257xx_charger.c index 9c082865e745..b9a41fe6f00e 100644 --- a/drivers/power/supply/bq257xx_charger.c +++ b/drivers/power/supply/bq257xx_charger.c @@ -5,6 +5,7 @@ */ =20 #include +#include #include #include #include @@ -88,6 +89,53 @@ struct bq257xx_chg { u32 vsys_min; }; =20 +/** + * bq25792_read16() - Read a 16-bit value from device register + * @pdata: driver platform data + * @reg: register address to read from + * @val: pointer to store the register value + * + * Read a 16-bit big-endian value from the BQ25792 device via regmap + * and convert to CPU byte order. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_read16(struct bq257xx_chg *pdata, unsigned int reg, u16= *val) +{ + __be16 regval; + int ret; + + ret =3D regmap_raw_read(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + *val =3D be16_to_cpu(regval); + return 0; +} + +/** + * bq25792_write16() - Write a 16-bit value to device register + * @pdata: driver platform data + * @reg: register address to write to + * @val: 16-bit value to write in CPU byte order + * + * Convert the value to big-endian and write a 16-bit value to the + * BQ25792 device via regmap. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_write16(struct bq257xx_chg *pdata, unsigned int reg, u1= 6 val) +{ + __be16 regval =3D cpu_to_be16(val); + int ret; + + ret =3D regmap_raw_write(pdata->bq->regmap, reg, ®val, sizeof(regval)); + if (ret) + return ret; + + return 0; +} + /** * bq25703_get_state() - Get the current state of the device * @pdata: driver platform data @@ -119,6 +167,43 @@ static int bq25703_get_state(struct bq257xx_chg *pdata) return 0; } =20 +/** + * bq25792_get_state() - Get the current state of the device + * @pdata: driver platform data + * + * Get the current state of the BQ25792 charger by reading status + * registers. Updates the online, charging, overvoltage, and fault + * status fields in the driver data structure. + * + * Return: Returns 0 on success or error on failure to read device. + */ +static int bq25792_get_state(struct bq257xx_chg *pdata) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1B_CHARGER_STATUS_0, &r= eg); + if (ret) + return ret; + + pdata->online =3D reg & BQ25792_REG1B_PG_STAT; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG1C_CHARGER_STATUS_1, &r= eg); + if (ret) + return ret; + + pdata->charging =3D reg & BQ25792_REG1C_CHG_STAT_MASK; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG20_FAULT_STATUS_0, ®= ); + if (ret) + return ret; + + pdata->overvoltage =3D reg & BQ25792_REG20_OVERVOLTAGE_MASK; + pdata->oc_fault =3D reg & BQ25792_REG20_OVERCURRENT_MASK; + + return 0; +} + /** * bq25703_get_min_vsys() - Get the minimum system voltage * @pdata: driver platform data @@ -142,6 +227,31 @@ static int bq25703_get_min_vsys(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_min_vsys() - Get the minimum system voltage + * @pdata: driver platform data + * @intval: pointer to store the minimum voltage value + * + * Read the current minimum system voltage setting from the device + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_min_vsys(struct bq257xx_chg *pdata, int *intval) +{ + unsigned int reg; + int ret; + + ret =3D regmap_read(pdata->bq->regmap, BQ25792_REG00_MIN_SYS_VOLTAGE, &re= g); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG00_VSYSMIN_MASK, reg); + *intval =3D (reg * BQ25792_MINVSYS_STEP_UV) + BQ25792_MINVSYS_MIN_UV; + + return ret; +} + /** * bq25703_set_min_vsys() - Set the minimum system voltage * @pdata: driver platform data @@ -166,6 +276,29 @@ static int bq25703_set_min_vsys(struct bq257xx_chg *pd= ata, int vsys) reg); } =20 +/** + * bq25792_set_min_vsys() - Set the minimum system voltage + * @pdata: driver platform data + * @vsys: voltage value to set in uV + * + * Set the minimum system voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_min_vsys(struct bq257xx_chg *pdata, int vsys) +{ + unsigned int reg; + int vsys_min =3D pdata->vsys_min; + + vsys =3D clamp(vsys, vsys_min, BQ25792_MINVSYS_MAX_UV); + reg =3D ((vsys - BQ25792_MINVSYS_MIN_UV) / BQ25792_MINVSYS_STEP_UV); + reg =3D FIELD_PREP(BQ25792_REG00_VSYSMIN_MASK, reg); + + return regmap_write(pdata->bq->regmap, + BQ25792_REG00_MIN_SYS_VOLTAGE, reg); +} + /** * bq25703_get_cur() - Get the reported current from the battery * @pdata: driver platform data @@ -195,6 +328,30 @@ static int bq25703_get_cur(struct bq257xx_chg *pdata, = int *intval) return ret; } =20 +/** + * bq25792_get_cur() - Get the reported current from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery current value + * + * Read the current ADC value from the device representing the battery + * charge or discharge current and return it in microamps. + * + * Return: Returns 0 on success or error on failure to read. + */ +static int bq25792_get_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG33_IBAT_ADC, ®); + if (ret < 0) + return ret; + + *intval =3D (s16)reg * BQ25792_ADCIBAT_STEP_UA; + + return ret; +} + /** * bq25703_get_ichg_cur() - Get the maximum reported charge current * @pdata: driver platform data @@ -218,6 +375,30 @@ static int bq25703_get_ichg_cur(struct bq257xx_chg *pd= ata, int *intval) return ret; } =20 +/** + * bq25792_get_ichg_cur() - Get the maximum reported charge current + * @pdata: driver platform data + * @intval: pointer to store the maximum charge current value + * + * Read the programmed maximum charge current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_ichg_cur(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG03_ICHG_MASK, reg) * + BQ25792_ICHG_STEP_UA; + + return ret; +} + /** * bq25703_set_ichg_cur() - Set the maximum charge current * @pdata: driver platform data @@ -242,6 +423,28 @@ static int bq25703_set_ichg_cur(struct bq257xx_chg *pd= ata, int ichg) reg); } =20 +/** + * bq25792_set_ichg_cur() - Set the maximum charge current + * @pdata: driver platform data + * @ichg: current value to set in uA + * + * Set the maximum charge current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_ichg_cur(struct bq257xx_chg *pdata, int ichg) +{ + int ichg_max =3D pdata->ichg_max; + u16 reg; + + ichg =3D clamp(ichg, BQ25792_ICHG_MIN_UA, ichg_max); + reg =3D FIELD_PREP(BQ25792_REG03_ICHG_MASK, + (ichg / BQ25792_ICHG_STEP_UA)); + + return bq25792_write16(pdata, BQ25792_REG03_CHARGE_CURRENT_LIMIT, reg); +} + /** * bq25703_get_chrg_volt() - Get the maximum set charge voltage * @pdata: driver platform data @@ -265,6 +468,30 @@ static int bq25703_get_chrg_volt(struct bq257xx_chg *p= data, int *intval) return ret; } =20 +/** + * bq25792_get_chrg_volt() - Get the maximum set charge voltage + * @pdata: driver platform data + * @intval: pointer to store the maximum charge voltage value + * + * Read the current charge voltage limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_chrg_volt(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, ®); + if (ret) + return ret; + + *intval =3D FIELD_GET(BQ25792_REG01_VREG_MASK, reg) * + BQ25792_VBATREG_STEP_UV; + + return ret; +} + /** * bq25703_set_chrg_volt() - Set the maximum charge voltage * @pdata: driver platform data @@ -291,6 +518,29 @@ static int bq25703_set_chrg_volt(struct bq257xx_chg *p= data, int vbat) reg); } =20 +/** + * bq25792_set_chrg_volt() - Set the maximum charge voltage + * @pdata: driver platform data + * @vbat: voltage value to set in uV + * + * Set the maximum charge voltage by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_chrg_volt(struct bq257xx_chg *pdata, int vbat) +{ + int vbat_max =3D pdata->vbat_max; + u16 reg; + + vbat =3D clamp(vbat, BQ25792_VBATREG_MIN_UV, vbat_max); + + reg =3D FIELD_PREP(BQ25792_REG01_VREG_MASK, + (vbat / BQ25792_VBATREG_STEP_UV)); + + return bq25792_write16(pdata, BQ25792_REG01_CHARGE_VOLTAGE_LIMIT, reg); +} + /** * bq25703_get_iindpm() - Get the maximum set input current * @pdata: driver platform data @@ -319,6 +569,30 @@ static int bq25703_get_iindpm(struct bq257xx_chg *pdat= a, int *intval) return ret; } =20 +/** + * bq25792_get_iindpm() - Get the maximum set input current + * @pdata: driver platform data + * @intval: pointer to store the maximum input current value + * + * Read the current input current limit from the device. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_iindpm(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, ®); + if (ret) + return ret; + + reg =3D FIELD_GET(BQ25792_REG06_IINDPM_MASK, reg); + *intval =3D reg * BQ25792_IINDPM_STEP_UA; + + return ret; +} + /** * bq25703_set_iindpm() - Set the maximum input current * @pdata: driver platform data @@ -344,6 +618,29 @@ static int bq25703_set_iindpm(struct bq257xx_chg *pdat= a, int iindpm) FIELD_PREP(BQ25703_IINDPM_MASK, reg)); } =20 +/** + * bq25792_set_iindpm() - Set the maximum input current + * @pdata: driver platform data + * @iindpm: current value in uA + * + * Set the maximum input current by clamping the requested value + * between device limits and writing to the appropriate register. + * + * Return: Returns 0 on success or error on failure to write. + */ +static int bq25792_set_iindpm(struct bq257xx_chg *pdata, int iindpm) +{ + u16 reg; + int iindpm_max =3D pdata->iindpm_max; + + iindpm =3D clamp(iindpm, BQ25792_IINDPM_MIN_UA, iindpm_max); + + reg =3D iindpm / BQ25792_IINDPM_STEP_UA; + + return bq25792_write16(pdata, BQ25792_REG06_INPUT_CURRENT_LIMIT, + FIELD_PREP(BQ25792_REG06_IINDPM_MASK, reg)); +} + /** * bq25703_get_vbat() - Get the reported voltage from the battery * @pdata: driver platform data @@ -368,6 +665,30 @@ static int bq25703_get_vbat(struct bq257xx_chg *pdata,= int *intval) return ret; } =20 +/** + * bq25792_get_vbat() - Get the reported voltage from the battery + * @pdata: driver platform data + * @intval: pointer to store the battery voltage value + * + * Read the current ADC value representing the battery voltage + * and return it in microvolts. + * + * Return: Returns 0 on success or error on failure to read value. + */ +static int bq25792_get_vbat(struct bq257xx_chg *pdata, int *intval) +{ + u16 reg; + int ret; + + ret =3D bq25792_read16(pdata, BQ25792_REG3B_VBAT_ADC, ®); + if (ret) + return ret; + + *intval =3D reg * BQ25792_ADCVSYSVBAT_STEP_UV; + + return ret; +} + /** * bq25703_hw_init() - Set all the required registers to init the charger * @pdata: driver platform data @@ -434,6 +755,62 @@ static int bq25703_hw_init(struct bq257xx_chg *pdata) return ret; } =20 +/** + * bq25792_hw_init() - Initialize BQ25792 hardware + * @pdata: driver platform data + * + * Initialize the BQ25792 by disabling the watchdog, enabling discharge + * current sensing with 5A limit, and configuring input current regulation. + * Set the charge current, charge voltage, minimum system voltage, and + * input current limit from platform data. Enable and configure the ADC + * to measure all available channels. + * + * Return: Returns 0 on success or error code on error. + */ +static int bq25792_hw_init(struct bq257xx_chg *pdata) +{ + struct regmap *regmap =3D pdata->bq->regmap; + int ret =3D 0; + + /* Disable watchdog (TODO: make it work instead) */ + regmap_write(regmap, BQ25792_REG10_CHARGER_CONTROL_1, 0); + + /* + * Enable battery discharge current sensing, 5A discharge current + * limit, input current regulation and ship FET functions + */ + regmap_write(regmap, BQ25792_REG14_CHARGER_CONTROL_5, + BQ25792_REG14_SFET_PRESENT | + BQ25792_REG14_EN_IBAT | + BQ25792_IBAT_5A | + BQ25792_REG14_EN_IINDPM); + + ret =3D pdata->chip->bq257xx_set_ichg(pdata, pdata->ichg_max); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_vbatreg(pdata, pdata->vbat_max); + if (ret) + return ret; + + ret =3D bq25792_set_min_vsys(pdata, pdata->vsys_min); + if (ret) + return ret; + + ret =3D pdata->chip->bq257xx_set_iindpm(pdata, pdata->iindpm_max); + if (ret) + return ret; + + /* Enable the ADC. */ + regmap_write(regmap, BQ25792_REG2E_ADC_CONTROL, BQ25792_REG2E_ADC_EN); + + /* Clear per-channel ADC disable bits - enable all channels */ + regmap_write(regmap, BQ25792_REG2F_ADC_FUNCTION_DISABLE_0, 0); + regmap_write(regmap, BQ25792_REG30_ADC_FUNCTION_DISABLE_1, 0); + + return ret; +} + /** * bq25703_hw_shutdown() - Set registers for shutdown * @pdata: driver platform data @@ -446,6 +823,30 @@ static void bq25703_hw_shutdown(struct bq257xx_chg *pd= ata) BQ25703_EN_LWPWR, BQ25703_EN_LWPWR); } =20 +/** + * bq25792_hw_shutdown() - Shutdown BQ25792 hardware + * @pdata: driver platform data + * + * Perform hardware shutdown for the BQ25792. Currently a no-op + * as the device does not require special shutdown configuration. + */ +static void bq25792_hw_shutdown(struct bq257xx_chg *pdata) +{ + /* Nothing to do here */ +} + +/** + * bq257xx_set_charger_property() - Set a power supply property + * @psy: power supply device + * @prop: power supply property to set + * @val: value to set for the property + * + * Handle requests to set power supply properties such as input current + * limit, constant charge voltage, and constant charge current. Routes + * the request to the chip-specific implementation. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_set_charger_property(struct power_supply *psy, enum power_supply_property prop, const union power_supply_propval *val) @@ -469,6 +870,19 @@ static int bq257xx_set_charger_property(struct power_s= upply *psy, return -EINVAL; } =20 +/** + * bq257xx_get_charger_property() - Get a power supply property + * @psy: power supply device + * @psp: power supply property to get + * @val: pointer to store the property value + * + * Handle requests to get power supply properties, including status, + * health, manufacturer, online state, and various voltage/current + * measurements. Reads current device state and routes chip-specific + * property requests to appropriate handlers. + * + * Return: Returns 0 on success or -EINVAL if property is not supported. + */ static int bq257xx_get_charger_property(struct power_supply *psy, enum power_supply_property psp, union power_supply_propval *val) @@ -550,6 +964,17 @@ static enum power_supply_property bq257xx_power_supply= _props[] =3D { POWER_SUPPLY_PROP_USB_TYPE, }; =20 +/** + * bq257xx_property_is_writeable() - Check if a property is writeable + * @psy: power supply device + * @prop: power supply property to check + * + * Determines which power supply properties can be written to. Only + * charge current limit, charge voltage limit, and input current + * limit are writeable. + * + * Return: Returns 1 if property is writeable, 0 otherwise. + */ static int bq257xx_property_is_writeable(struct power_supply *psy, enum power_supply_property prop) { @@ -622,6 +1047,17 @@ static void bq257xx_external_power_changed(struct pow= er_supply *psy) power_supply_changed(psy); } =20 +/** + * bq257xx_irq_handler_thread() - Handle charger interrupt + * @irq: interrupt number + * @private: pointer to driver private data + * + * Thread handler for charger interrupts. Triggers re-evaluation of + * external power status and updates power supply state in response + * to charger events. + * + * Return: Returns IRQ_HANDLED if interrupt was processed. + */ static irqreturn_t bq257xx_irq_handler_thread(int irq, void *private) { struct bq257xx_chg *pdata =3D private; @@ -662,6 +1098,22 @@ static const struct bq257xx_chip_info bq25703_chip_in= fo =3D { .bq257xx_get_min_vsys =3D &bq25703_get_min_vsys, }; =20 +static const struct bq257xx_chip_info bq25792_chip_info =3D { + .default_iindpm_uA =3D BQ25792_IINDPM_DEFAULT_UA, + .bq257xx_hw_init =3D &bq25792_hw_init, + .bq257xx_hw_shutdown =3D &bq25792_hw_shutdown, + .bq257xx_get_state =3D &bq25792_get_state, + .bq257xx_get_ichg =3D &bq25792_get_ichg_cur, + .bq257xx_set_ichg =3D &bq25792_set_ichg_cur, + .bq257xx_get_vbatreg =3D &bq25792_get_chrg_volt, + .bq257xx_set_vbatreg =3D &bq25792_set_chrg_volt, + .bq257xx_get_iindpm =3D &bq25792_get_iindpm, + .bq257xx_set_iindpm =3D &bq25792_set_iindpm, + .bq257xx_get_cur =3D &bq25792_get_cur, + .bq257xx_get_vbat =3D &bq25792_get_vbat, + .bq257xx_get_min_vsys =3D &bq25792_get_min_vsys, +}; + /** * bq257xx_parse_dt() - Parse the device tree for required properties * @pdata: driver platform data @@ -707,6 +1159,17 @@ static int bq257xx_parse_dt(struct bq257xx_chg *pdata, return 0; } =20 +/** + * bq257xx_charger_probe() - Probe routine for charger platform device + * @pdev: platform device + * + * Probe the charger device, allocate driver data structure, select the + * appropriate chip-specific function pointers, register the power supply, + * parse device tree properties for battery limits, initialize hardware, + * and set up the interrupt handler if available. + * + * Return: Returns 0 on success or error code on failure. + */ static int bq257xx_charger_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -722,7 +1185,17 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return -ENOMEM; =20 pdata->bq =3D bq; - pdata->chip =3D &bq25703_chip_info; + + switch (bq->type) { + case BQ25703A: + pdata->chip =3D &bq25703_chip_info; + break; + case BQ25792: + pdata->chip =3D &bq25792_chip_info; + break; + default: + return dev_err_probe(dev, -EINVAL, "Unknown chip type\n"); + } =20 platform_set_drvdata(pdev, pdata); =20 @@ -760,6 +1233,13 @@ static int bq257xx_charger_probe(struct platform_devi= ce *pdev) return ret; } =20 +/** + * bq257xx_charger_shutdown() - Shutdown routine for charger platform devi= ce + * @pdev: platform device + * + * Called during system shutdown to perform charger cleanup, including + * disabling watchdog timers or other chip-specific shutdown procedures. + */ static void bq257xx_charger_shutdown(struct platform_device *pdev) { struct bq257xx_chg *pdata =3D platform_get_drvdata(pdev); --=20 2.52.0