From nobody Wed Apr 1 12:32:23 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B5F32EA16A for ; Tue, 31 Mar 2026 10:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954341; cv=none; b=R1ONzdQVDFupaP1AOiyLJbBNSvBXTqa8e+0IxqCBsvVSW9439qvJ+qhhCoGr7npCD82g5mKSpcPtGd/bDqlHbPhRmqTLP83/kjZ1DJcsROlIyDetrYfaqq+hRGttBjxvC1RV04wyiFTIPYKAr8ucg8270XeX/OAYT1CQFBFM23g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954341; c=relaxed/simple; bh=EEfIDGiDksuPpb8arPSItu4dHB4/kLVwih5ZEhNu544=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=eEQWXO7XcT3i/ZDP8r/R9d6arXRQ9x7/OMk46PMZfpxFOk9/JNZ31NLN9bplvZI/mDNbsysJPJUa7f9uXwfyE22TL0ZgcabevkqJ3cfzL2ypk3HHt45o7EqycvcppLDOvQ3I77jbvVpXzUbKlZYHhZ5/ZtRb3o+/zHgrCOS9oX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=X2XZpg1d; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="X2XZpg1d" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-48531e6012bso61344505e9.1 for ; Tue, 31 Mar 2026 03:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774954339; x=1775559139; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Wl5LyeV0+eQ04x5EwM2jDgCGaIxGE9I19kcEd8pTzTE=; b=X2XZpg1dTosVkpmHwLHmjs4J2YLv4/qtruqV/OqBwlIojJBjKKAXwNFuWRGnDzNsHu MhHITCfc5KML8xXzONvOuLCddPRtkvVzodr7LSwppbgtLv+Z/VxrL/UduQPmNwSDVo8F KJ8d7E0y281dL3KPZomcxyv1GNPZ59319n9lOPt1mFKlKrztbLoH94EtAmfrxraWcDaC sT/YLeJsVM9ODwxcin72/dInj1zLVnyHzd7K1ZOEoANn6/SLDAm79+11sypdpL2zc8zU eWj5hOG2hfkkLLVWj0qBI0bxjp59dCWUzj1P58Nj5l9u6N293va28/z0Y0NBlbbKXR54 qGtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774954339; x=1775559139; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Wl5LyeV0+eQ04x5EwM2jDgCGaIxGE9I19kcEd8pTzTE=; b=eu3XBT4qjRHopRnsg1QCn0uiN1lEvNUBfy0pD9bzlJUXUA5U4tg2zDgWmQNr9KDKhX EZQqHCov4Qz0tsXETjIQI9yNCSOVCCoeGRFZAUS/VAi/VHS+Es88gSNQwp04EZlDS5dr hV4iE/OLoOdhVXBcKA+XnkFim0F5+k1H40spMD5g/+RWyz5w9nF3kQylk7YgVWgzRKIJ dp7RhuL0+IgG03i3dq0+9DsUClZziVcrURyQ11vNRN6YOG5KEhh94cIihM/ECVMeFZeL j2q6A3snznPNtgPwxFAkGzZwJOQRHdeZdkzkiowk4rWvVxPlHaCIejCA7rK2JzPNjxM4 AWUQ== X-Forwarded-Encrypted: i=1; AJvYcCU5ChY98cu9Q343jGhyYEyqm7ZZMU6r0FGoFbpOAJ+zQd2Y33IfqmLJqAa/D9kFEdUffAWswREhOnhwEVA=@vger.kernel.org X-Gm-Message-State: AOJu0YwmXAHTob7xZM/ZLrmAWd8mw+H3xrNkcXQrQT+FhZps62yL3RdH SgicMAqUWtBHOdtsBvHAEqyHwN5AF9RN+HyT6qrRInU2854o+nG/WR//SbzkuSVY9Q6CA6n6sMt rJIM6yqcgfYmATQ== X-Received: from wmdd14.prod.google.com ([2002:a05:600c:a20e:b0:485:2d79:6c74]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600d:e:b0:485:5812:bb9e with SMTP id 5b1f17b1804b1-48727d31801mr234219505e9.0.1774954338534; Tue, 31 Mar 2026 03:52:18 -0700 (PDT) Date: Tue, 31 Mar 2026 10:52:13 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFyny2kC/x3M0QrCMAxG4VcZuTaQblPQVxEZ6fxXA2UrDQxh7 N0tXn5wOAc5qsHp0R1UsZvbtjaES0fzR9cEtncz9dLfZBgCx5FLRdGKSXPe5qlogvOSNTlfY7x rgIwQobZo5WLf//75Os8fE+zz6G4AAAA= X-Change-Id: 20260331-b4-prepare_alloc_pages-flags-5bb9a1e04e00 X-Mailer: b4 0.14.3 Message-ID: <20260331-b4-prepare_alloc_pages-flags-v1-1-ea2416def698@google.com> Subject: [PATCH] mm/page_alloc: cleanup flag vars in alloc_pages_bulk_noprof() From: Brendan Jackman To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Brendan Jackman Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable These two variables are redundant, squash them to align alloc_pages_bulk_noprof() with the style used in alloc_frozen_pages_nolock_noprof(). Signed-off-by: Brendan Jackman Reviewed-by: Suren Baghdasaryan --- mm/page_alloc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 111b54df8a3cb..5e280ded6e7ac 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5051,7 +5051,6 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int = preferred_nid, struct per_cpu_pages *pcp; struct list_head *pcp_list; struct alloc_context ac; - gfp_t alloc_gfp; unsigned int alloc_flags =3D ALLOC_WMARK_LOW; int nr_populated =3D 0, nr_account =3D 0; =20 @@ -5092,10 +5091,8 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int= preferred_nid, =20 /* May set ALLOC_NOFRAGMENT, fragmentation will return 1 page. */ gfp &=3D gfp_allowed_mask; - alloc_gfp =3D gfp; - if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &alloc_gfp= , &alloc_flags)) + if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &gfp, &all= oc_flags)) goto out; - gfp =3D alloc_gfp; =20 /* Find an allowed local zone that meets the low watermark. */ z =3D ac.preferred_zoneref; --- base-commit: 57e5b07deacb0a9bd7b8c9b933ff72e902d4f06b change-id: 20260331-b4-prepare_alloc_pages-flags-5bb9a1e04e00 Best regards, --=20 Brendan Jackman