From nobody Wed Apr 1 14:08:25 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B86E3F54A4; Tue, 31 Mar 2026 10:28:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952891; cv=none; b=WQ2FxWHJuIBKOjDmwP64j+0FSL7HmRFeuWfs6tfF90RjrPy4/wRDdUKxZDmp5PDKWkVqyhcA8y672JalJgxkalIlY2+sVGAGeWMQJgPb1jgPqYCk4+5xuW8jCZ5TEe7Eov5FuUCh37Hd4KYpvBpUU49WIuTcl8NAaYb13HX8s/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952891; c=relaxed/simple; bh=qf2g31u0bwndi66xXFxx/Ola4B6Cn4PwKIM7cuvAdwQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h5psKo992CvknllZkKv0r+PLXSUsgxdOOd5fARsl06idun1bnJVcSJQG6o7NigH3s9eZQ6z25Kql2RnvPwMZkbnkr3Ez2pr/O2IjRctpGTBAIkQxr4I/rzJ3FsHA4vuGJC8yCneJfqFJ7XZ5ztItZo6U0aYPWoUUcUB8lOWbXDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=CmOsHh9m; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="CmOsHh9m" Received: from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DFD97244D; Tue, 31 Mar 2026 12:26:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774952799; bh=qf2g31u0bwndi66xXFxx/Ola4B6Cn4PwKIM7cuvAdwQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CmOsHh9m2Nlyfl0gHLXBPcDwx/z0LTvsaMl1kw1RkQvQGNr2JUIqoyfYQqpnoNUGH 0JghC3cNu1w75vJDKHeYTdSdTMLQ1U7GS6CRABsGQxo+K3sh3EIv6P0yj+Zlj0/Y6x rrhnKmmV8Uv6TAqtEPGVhNBOQGaNKRwlOQ+2I0GA= From: Jacopo Mondi Date: Tue, 31 Mar 2026 12:27:40 +0200 Subject: [PATCH v2 10/15] media: rzg2l-cru: Manually track active slot number Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260331-b4-cru-rework-v2-10-f94b238b35d4@ideasonboard.com> References: <20260331-b4-cru-rework-v2-0-f94b238b35d4@ideasonboard.com> In-Reply-To: <20260331-b4-cru-rework-v2-0-f94b238b35d4@ideasonboard.com> To: Mauro Carvalho Chehab , Laurent Pinchart , Biju Das , Hans Verkuil , Sakari Ailus , Tommaso Merciai Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4125; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=m18J3ltumDy3/Y8d2cVSeJ5oXxXGhI1khmxc8wX8oLs=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpy6Go182ZGIhwgGHPJTW/t5PlAJ8CAWk0Vkj2U TlyiKah4ImJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacuhqAAKCRByNAaPFqFW PJKZD/9hzzFdxisXpgSZaUT7zKFqo2J1li92mpcLBZITZVzDQxpkQ3+Z+8kQyKM9fQdaLn1vFT8 QRHXqgcblTKIPzG5Qw1TJB1x9CrgpxCETSO6NqDJKy0rZJYhw73uwVhNNKXD/1WB4vXo8aXTAbr m6Cp5I4DlE6m1N+Z5AAlrOzZYtHkKkPZsJ8PSwf1y7ihzDAfg7NYlsDjzRbuJ7ilYNvNSAZ3QOm /6XaQImYeuNpcD6Uo6Ed01tJaXNbakpq5IdkeZIVDvIpMjMHl0hjuFmZ1L2k7HRlUJ50+x+FF7D JRSFfFQ3l0ucKcBu2ETXjQOQHn9qNwJCGd23jIkbEqHNsSKgRynaPGMMfpMzQCAo3LRlkSC2oJz lMPgGOlu11fdC6yUMMG4h7wUBHv0oiZJAn5mrXYSAm0AV6gspRFD4Q++YWEhU5EK6du5yech40x byUeSXwOn31Ic1OGOcdJMyRQdPynMjFjmI3H9RqsvT67ux0hgyk5T9t+g6gTock60qLdgtf3GAC Th67042xGtlyl1P+DSiKoL/9+29wzKtdQ1jVdnXsiRztLyWeP/n9lov3F/MNRJzYhFc5quSInEs D8WlVH9jmbel3rmM7Hax4Pqq0gWjmNCQSsxiYjChjf2lZZgkPU6tEjqgxTiaoUlhi1IBBCdR0JD Po9HCp+voZB+PQQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B From: Jacopo Mondi The CRU cycles over the hardware slots where the destination address for the next frame has to be programmed. The RZ/G2L version of the IP has a register that tells which is the last used slot by the hardware but, unfortunately, such register is not available on RZ/G3E and RZ/V2H(P). The driver currently compares the value of the AMnMADRSL/H register which report "the memory address which the current video data was written to" and compares it with the address programmed in the slots. This heuristic requires a bit of book keeping and proper locking. As the driver handles the FrameEnd interrupt, it's way easier to keep track of the slot that has been used by ourselves with a driver variable. Signed-off-by: Jacopo Mondi Tested-by: Tommaso Merciai Reviewed-by: Tommaso Merciai Reviewed-by: Daniel Scally Reviewed-by: Lad Prabhakar --- .../media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 6 +++-- .../media/platform/renesas/rzg2l-cru/rzg2l-video.c | 31 +++---------------= ---- 2 files changed, 7 insertions(+), 30 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers= /media/platform/renesas/rzg2l-cru/rzg2l-cru.h index 12d574182eb8..25f17069585c 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h @@ -119,9 +119,10 @@ struct rzg2l_cru_info { * @mdev_lock: protects the count, notifier and csi members * @pad: media pad for the video device entity * - * @hw_lock: protects the slot counter, hardware programming of - * slot addresses and the @buf_addr[] list + * @hw_lock: protects the @active_slot counter, hardware programming + * of slot addresses and the @buf_addr[] list * @buf_addr: Memory addresses where current video data is written + * @active_slot: The slot in use * * @lock: protects @queue * @queue: vb2 buffers queue @@ -162,6 +163,7 @@ struct rzg2l_cru_dev { =20 spinlock_t hw_lock; dma_addr_t buf_addr[RZG2L_CRU_HW_BUFFER_DEFAULT]; + unsigned int active_slot; =20 struct mutex lock; struct vb2_queue queue; diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 5769dbcbd084..b02940369a18 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -634,31 +634,6 @@ irqreturn_t rzg2l_cru_irq(int irq, void *data) return IRQ_RETVAL(handled); } =20 -static int rzg3e_cru_get_current_slot(struct rzg2l_cru_dev *cru) -{ - u64 amnmadrs; - int slot; - - /* - * When AMnMADRSL is read, AMnMADRSH of the higher-order - * address also latches the address. - * - * AMnMADRSH must be read after AMnMADRSL has been read. - */ - amnmadrs =3D rzg2l_cru_read(cru, AMnMADRSL); - amnmadrs |=3D (u64)rzg2l_cru_read(cru, AMnMADRSH) << 32; - - /* Ensure amnmadrs is within this buffer range */ - for (slot =3D 0; slot < cru->num_buf; slot++) { - if (amnmadrs >=3D cru->buf_addr[slot] && - amnmadrs < cru->buf_addr[slot] + cru->format.sizeimage) - return slot; - } - - dev_err(cru->dev, "Invalid MB address 0x%llx (out of range)\n", amnmadrs); - return -EINVAL; -} - irqreturn_t rzg3e_cru_irq(int irq, void *data) { struct rzg2l_cru_dev *cru =3D data; @@ -690,9 +665,8 @@ irqreturn_t rzg3e_cru_irq(int irq, void *data) return IRQ_HANDLED; } =20 - slot =3D rzg3e_cru_get_current_slot(cru); - if (slot < 0) - return IRQ_HANDLED; + slot =3D cru->active_slot; + cru->active_slot =3D (cru->active_slot + 1) % cru->num_buf; =20 dev_dbg(cru->dev, "Current written slot: %d\n", slot); cru->buf_addr[slot] =3D 0; @@ -769,6 +743,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queu= e *vq, unsigned int count goto assert_presetn; } =20 + cru->active_slot =3D 0; cru->sequence =3D 0; =20 ret =3D rzg2l_cru_set_stream(cru, 1); --=20 2.53.0