From nobody Wed Apr 1 09:44:32 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F11A3A452C for ; Mon, 30 Mar 2026 21:33:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774906390; cv=none; b=B1mHRQjOYDL5E8ke+CgfO3wfHKa5EY4oHbquUDvnc5AeXAktHLpvfkO58XQw7r6fQvou4ISroccsg4uj599HoSlcZMC16l5iKcFlaAZlFJJOjpKMzftu+96tG8DzAIRGawe90oNRMBp3J1v8StUc+acZV8+TUTSpuRYpwzm4WrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774906390; c=relaxed/simple; bh=kMcZjPsOMrDkhR41RdpNe609HpL2qZ9sTZwgMq52YiY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V/SF5O3/CgWFX93aoH+LDzZ6peWjxjtU5m0Axntu4qnB5U2ES+Jad2FxlpgObqDtG1qoLslQfwIwPKOkGHnLuOY/VAipXyA9VUdSFqEGBI/hYKJKLzffxjJTespbfjig1dJ9+RVX7ZuCf/DAFuYAYpm00I+/AzR86bZeGcPeCwY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XgLxC+dU; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XgLxC+dU" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43cfb723793so1007925f8f.2 for ; Mon, 30 Mar 2026 14:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774906387; x=1775511187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=xBdx6H/Z1jGCptYLlq0P8qy8OL6OaKAaFg5bJOcmtsg=; b=XgLxC+dUH1Wn0OEePd1wpRNA3mGoY1KeKezxVoXDNt7RB5VtopftB4VParxrcBgv9r TxyRA088fRdk4K6yqxn73MoSDMBT5bztb/Jco8fR9lwVdFC4Ngf73VwoifzRenmuFERt nj9mpHTTSdQ4Mls/OCpQ3xm9vX0XYCziMem6R81ERTta6JHhFVGr1EIkVaplaR7rrLxS 6fYcUShlLknFisUjSCTYUYTv4CkPrKdVhnCJ1pOUI3D/DY4D3iRaugmRl0tbYUl44j4q IID5v5cZW7U+ZTLq99X0hJgzFKDRulr+hRjq8BH9CZCoTYKzaLa8HdW7/QCci+pse2oX pgwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774906387; x=1775511187; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xBdx6H/Z1jGCptYLlq0P8qy8OL6OaKAaFg5bJOcmtsg=; b=apTFHXpqBVcJNMNJMgyBkOTYR84DvH7N0NZX31bPk6Vw/Q4RknjCQ1RYvTTdNoqMOH InVwPKR7KL/1GqzU0If83MsScCvbjyRczVReooS3k7JOP4OO9pQiGDxRcmWVSYwxP9oe 5GzQn5pnoImlsy2Gsauk5/DGosctiXyxTlYhFXc5Uo/GqiDb+ij4JastD/CpHtTs5ZGx iaDbsvGXOLThIzjYPa+JYRVdBnF5lZwjn2F49FIICa2y2UntIDucouf/cpm7wsnVPhxh 13gvhi0EawFfuj2V6Og4xRB8VxhDhKFnYQytp5qEthkS62TSEF9vq2pnuTmnT5ZzywbR 1YEQ== X-Forwarded-Encrypted: i=1; AJvYcCXyqPYxbMROlrleJqgDC89w8oM+P84a2lOcANeU1TmLftoiqlkkybPilZFxYBnAf1Xn+yRtmBeivERejkY=@vger.kernel.org X-Gm-Message-State: AOJu0YyKow+8du/Pjl94oObqRhkOstAr00hNVHcxmwp3l5BY8fhoV4pJ 7OF1tLNpfUs9NX/ZGGvUVMxgcFbEzozKAHRkOiDn3AekaOiw2qflfDyY X-Gm-Gg: ATEYQzykoi14Qejmy28HmTHaQlkK3BhXPaxtRHk0+fVrRXCHX5SvNw+7mFZFBnZLOYH Rxr2gj52nXK7YAJ/FAQuXeqE8pztHBGsr2oL3AgBhyWVXDp1QStaQMl3uAUl8xivwAE+WIjhhJi LU5arFW1G2vGuGTrVPDE3VRdzKgjbR3VC9kW9oH23DcblzjYlWoPkX0YSoCQq80GSfyUVRS6wSr HR5VxOAT/KHBHa6yIr3GnaM+GjbP/QQvDCUr0r3mqv9VPdI9m0CgWXjzOS8A3Lg6xtjClFfg/Dq DiaWkesezOU7FQmtc28yYC5wrgtggTl8Vr9NSBiZQxkSwm6H6N5eGVgHYu5mSF38UQ6puGo30wP 04LYnr+gQaLlQZaqALtLAQbgwN9tTY1exBVnoCWx0sc1AsxdHbe9eL7bQT6zhnj2DU2p4nH+KyT 7fl9revFOMSUyRqW6g4JzpR5FtNj5R1sug1CEktW5EZKPnx2JDkQrI6LtNiIDPMxL8iw== X-Received: by 2002:a05:6000:40cd:b0:43b:8f29:b08f with SMTP id ffacd0b85a97d-43b9ea46662mr22538065f8f.30.1774906386448; Mon, 30 Mar 2026 14:33:06 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e9e18sm20855869f8f.9.2026.03.30.14.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 14:33:05 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: andrew+netdev@lunn.ch, pabeni@redhat.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] ppp: dead code cleanup in Kconfig Date: Mon, 30 Mar 2026 22:32:58 +0100 Message-ID: <20260330213258.13982-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is already an 'if PPP' condition wrapping several config options e.g. PPP_MPPE and PPPOE, making the 'depends on PPP' statement for each of these a duplicate dependency (dead code). I propose leaving the outer 'if PPP...endif' and removing the individual 'depends on PPP' statement from each option. This dead code was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha Reviewed-by: Qingfang Deng --- drivers/net/ppp/Kconfig | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig index a1806b4b84be..f57fba84fe55 100644 --- a/drivers/net/ppp/Kconfig +++ b/drivers/net/ppp/Kconfig @@ -37,7 +37,6 @@ if PPP =20 config PPP_BSDCOMP tristate "PPP BSD-Compress compression" - depends on PPP help Support for the BSD-Compress compression method for PPP, which uses the LZW compression method to compress each PPP packet before it is @@ -56,7 +55,6 @@ config PPP_BSDCOMP =20 config PPP_DEFLATE tristate "PPP Deflate compression" - depends on PPP select ZLIB_INFLATE select ZLIB_DEFLATE help @@ -71,7 +69,6 @@ config PPP_DEFLATE =20 config PPP_FILTER bool "PPP filtering" - depends on PPP help Say Y here if you want to be able to filter the packets passing over PPP interfaces. This allows you to control which packets count as @@ -84,7 +81,6 @@ config PPP_FILTER =20 config PPP_MPPE tristate "PPP MPPE compression (encryption)" - depends on PPP select CRYPTO_LIB_ARC4 select CRYPTO_LIB_SHA1 help @@ -96,7 +92,6 @@ config PPP_MPPE =20 config PPP_MULTILINK bool "PPP multilink support" - depends on PPP help PPP multilink is a protocol (defined in RFC 1990) which allows you to combine several (logical or physical) lines into one logical PPP @@ -109,7 +104,7 @@ config PPP_MULTILINK =20 config PPPOATM tristate "PPP over ATM" - depends on ATM && PPP + depends on ATM help Support PPP (Point to Point Protocol) encapsulated in ATM frames. This implementation does not yet comply with section 8 of RFC2364, @@ -118,7 +113,6 @@ config PPPOATM =20 config PPPOE tristate "PPP over Ethernet" - depends on PPP help Support for PPP over Ethernet. =20 @@ -164,7 +158,7 @@ config PPPOE_HASH_BITS =20 config PPTP tristate "PPP over IPv4 (PPTP)" - depends on PPP && NET_IPGRE_DEMUX + depends on NET_IPGRE_DEMUX help Support for PPP over IPv4.(Point-to-Point Tunneling Protocol) =20 @@ -175,7 +169,7 @@ config PPTP =20 config PPPOL2TP tristate "PPP over L2TP" - depends on L2TP && PPP + depends on L2TP help Support for PPP-over-L2TP socket family. L2TP is a protocol used by ISPs and enterprises to tunnel PPP traffic over UDP @@ -184,7 +178,6 @@ if TTY =20 config PPP_ASYNC tristate "PPP support for async serial ports" - depends on PPP select CRC_CCITT help Say Y (or M) here if you want to be able to use PPP over standard @@ -198,7 +191,6 @@ config PPP_ASYNC =20 config PPP_SYNC_TTY tristate "PPP support for sync tty ports" - depends on PPP help Say Y (or M) here if you want to be able to use PPP over synchronous (HDLC) tty devices, such as the SyncLink adapter. These devices --=20 2.51.2