From nobody Wed Apr 1 11:13:16 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EF22E4247 for ; Mon, 30 Mar 2026 18:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894987; cv=none; b=e0fB16dPLQuxohpFxYMuOlsxfRspUqzVGj2GbxLLHVngmvyta3BTteX5KD/ZlfPC29Ueci/DCvumtIeQiwICu6gw4y5LBBB3PdtcRd3eUvM+7N7EtT0zFmWwSDq4lqAOa/MyLzKHprBoxmRi7elxMH2rw+s92eCh0rt9r+MWIpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894987; c=relaxed/simple; bh=suqsuBsVchdVwVar4ZZtGbmQ+dClyiLJBPlCob+IUiY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xh8lL+4+9qu/TLIn/M1OfXt50s5VayLkurbrV3wZKIOsOLcL05TUpD+0Tpvg4NTJSOgjMogPYhDghdZpSp9uiT8TnfMJ6KsRyJurKhLfSU14BcuG4ZqabrEvoISWqlpEXQZ6JhHH0VgZsyLPGE+W263vCG6Ydn1PJ7qdlWSVIV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lZ+fJlff; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ+fJlff" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486b9675d36so40613015e9.0 for ; Mon, 30 Mar 2026 11:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894984; x=1775499784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PcKBh4KWsiN7v1ouQtoD5ZQbdxWi7sovHzhSf4lU27I=; b=lZ+fJlffqqAeLJ4lsMVWjWUqmdoUJemHb+OghwcHM3TzY63DEaU6zvG21x9YDG9tTm sOQMCOcHysYfBa1JYLhBQx6G9qELlVHjhS7MM5fXygFgUHNq0yVE7HKKTYF7A/Dmr9Fu Jb/STuFOLyY930/VZZioblTGLNujavXEmq9gU64lMxZLTbU25YY3Wovp9Mml+n+xOVsI QtjqVxCmtdC/pxXsm0NKU8DYyOhTkD7I/hDgVifGFv8iM8jjgJPrUxJPyhMFT+1i3KH7 +1gXECZXMaCLVgW4ZHNEBbPj/5Kj91bO699GhcVhyU+t+GDBKRNPsrL88D9vP6f+Lrip OQ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894984; x=1775499784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PcKBh4KWsiN7v1ouQtoD5ZQbdxWi7sovHzhSf4lU27I=; b=MFt6/7lUTBvoufzID9w82jxMyrFV9qxmOFXphu+gpc36pO/SPj49zur7BqUa4sHOxC 1EDHAfPXx0UlVwNuBfCJJGjRJ6igQywuMLGvXAAAzqdfmnqzG5AQzxUw+TShGEAg5SX9 K8aUvRrY4wOuaSJOf7IJ08UftoQUrPFZ9DU1zO3mbH2eQ0vYDqqzp+y0LsMsYnTbFfUU z5BZh1DjfuVwBFtJFIlSALQBM7KMTYYRudMUo++6Kdmbua423vRyEhjZrBQH6nGdjgkQ 9QNoiPAMszDPIG/pKvH4G9JiMr/O3BMHtb+W15GjhJfLbkrImCZKo1m1/iuvonNM6pzx z1uA== X-Forwarded-Encrypted: i=1; AJvYcCVjoj1k9ljUJz6kqNnIPmlcxFxSxKNmBvjDE1rtWWErqhF2YEbaenjHJLzlJxkyKpen5C15GD4b1BFfHbk=@vger.kernel.org X-Gm-Message-State: AOJu0YytRPFfr55kaQYBAsQsXgPEIym6lUVqfjn75496pgUR1cI+nVIo GszJhPH7iO1HlDQ8OarlxRK8ASelzuqCXVwoKsQMCkANR/myzjGIMYW3 X-Gm-Gg: ATEYQzxn2s0vgF6npFR81jCQBvnY2I4VpzLRqq24nXhx0Eg6pF3712sCAwO7M3u7Fg3 DTfvntg6qzSe5M2Iysrn1w0xMEQhbWZdXhIGo3I6l9CYCVRqw1Bc9DKdnU4krUDphp2Dux9D4Xr YdwvgizrzMxaQhnUQEFzVwubzn6QfqkIhDUfBX0B3UZl5auoMkeulp8Nmnq+OmumEe6BH/gpI1p rFDcZ0+144frKk17yMikQELxptXF8OlJD+P5EwcgIl6WaIMwAy7GVK5E71P5/Uy/v/weMXuScws KtUTNaQDA+8Mz9x+EsNxenmjGaGUj/ghY/c+OHG4ouo1FzwkJ/my7ytT7pIPm36Q9MUhBAAqmeL 7LhqpNL5mS4QYaRbk67sh25xbU5p40mod6w1paEVO/rpJP7JSDzBYD2HC32V7qJ/+pQtT2y6dMw QiufrgE4Dm3g8q7wgRRuSF7hCUZD2E5BqSM92sI8XVdz0uUbo7weer X-Received: by 2002:a05:600c:a31b:b0:487:716:2fa2 with SMTP id 5b1f17b1804b1-48727ec3c1dmr187938795e9.16.1774894984046; Mon, 30 Mar 2026 11:23:04 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:03 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 5/5] staging: most: dim2: replace BUG_ON() in poison_channel() Date: Mon, 30 Mar 2026 19:22:55 +0100 Message-Id: <20260330182255.75241-6-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 23230a32c..7953d4626 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -647,7 +647,8 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) u8 hal_ret; int ret =3D 0; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; --=20 2.33.0