From nobody Wed Apr 1 11:12:45 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62163DEAD1 for ; Mon, 30 Mar 2026 18:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894986; cv=none; b=MnCFRfwYhR7BQQQUz8QHc7K6JniBv8DbmxCizaQ/qNrJlqc6C2ArGoSY09KGvR3w5W4RAg2i5ttrQspd3tswkeFNZ24ypTZBrhVOrf5brVtkUYowqefy+c8Qb49ZsaAaHAqJM73wDIQgiS2yE9PY5NxPg/ZUoaC9MTKWW0ARpZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894986; c=relaxed/simple; bh=7v6hWVMphHmp1fk2Axl/HTUNGWtaCf74TNaGvVarMjc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RQQHAWMVL2+y/lLJefJxLbPvFX+bMisjkO2QpleLP0wnRVwstQe9hnyK9ktsm0gAu/VyMKs0pnX+qxZfcYn+Cm+01qr9xqyZLsnBOjXudRE6FHmx7/tB31eyc0ScS2dGNvlhuxIcosU1e5CWbHzI6+z8qnLXgBED3EgKBswx7WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O0+ra6wa; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O0+ra6wa" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so47944265e9.1 for ; Mon, 30 Mar 2026 11:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894983; x=1775499783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zxKeE3nFIhdamqdbJMN8NtBpVsh6P3ltxH0ua/ul5Bw=; b=O0+ra6washLiN3mc4R7mqlaL3CLpOPPSXfm7IidbdvWyFGhE8zI74PPgfDbBc0tqeG +KiiE2JeS3qYax57OShb9o+tUfdq7l4moiX1lWVlXcz2Jtn4VOjD7TUC121uzvkLkqZO rkQtBxtYLD88++fQC98EVuk5+818KdTJs0xZ/DVUuAcw40xh8y6ibkXjrnuo5Euvz9JA 2nUq34QzSoJDca1RtpMDBQLH9SBe1pKDWen4JDIrILSAD283wVjc7FEDisNwIKe731zI vqWTVzwx8c00MdI6cFHPvC3btN1coTAGut7NXV0DaeWUtCWV85EGBg2bjIWeFhIuj6Wi pgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894983; x=1775499783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zxKeE3nFIhdamqdbJMN8NtBpVsh6P3ltxH0ua/ul5Bw=; b=O4l3VuBL1tdAN+74H9JnptIrh13dVw/xM6ZIhZtljqDIZqFO5UcdAfpNLH4ufZ2Szx Xl50AQ5eYb/KYuRofdcRXbMk3M+YkIIlFskoqdnI6R3DwvLMz3KCCJTy7m5ZtDv0CFnC wH991w6SN8gk99sA/GI7H7AuQjt+cwpcsSM4HmpNUwc+e8jgaEJmNBE0gQ6YaHSbzpVF dHtI6NHAnbvkQbgPNbNMk2jA25AugNTqq7CT/GPjg9cvdOFd/MhlwwI06fHeBhbN9Wa0 KHuHinOxNTJjnoDX8FQolXx47H4kwlu5IZUz/NHUbtY4q5MlHby0X/FJOVlj4s2DdgWZ JKtg== X-Forwarded-Encrypted: i=1; AJvYcCUnDt4cZclmQFEnPrAv2VjuP2vDIR8by2hHSLLDWAhsk45JeaoKNesZC+fVNZoaWR4ngEEeo7UDel7ZVB8=@vger.kernel.org X-Gm-Message-State: AOJu0YyOo/0pBUfDGeyOYHtqKdBy84lg0EKkgz4YKxRLF/7g0CbdpNAy PN9mc+Nqun1XhTgo7sFXOvNne6JI+ITj1BtMof9bfPpAjXRp/47GXoNZ8c4uGjWIOm+eTQnt X-Gm-Gg: ATEYQzznCBupQpzxA1beIT7P9GtXAYoQl3zP7ZlMYjWsOrmNyNU4aVfOO5pq2LWckpz 1vPOVPdARkFssld0AdZmzk3mHI4ERmBxV9dnie7TIveUI3s3orAsAevYKvb/rDYep2T+6KtKWwK YVX+2/yixPsMmi4sjtxhhNZEpQWLLWuzr/VtXHtiHAw7WzsDY+2DR/XL5T+sawypKnaB55nzj2m uO1KuNFClBk8UBuw19mM3sxamD79nghc3kMg1WCct21AQFVTxOdYY+Hb60vJWOpJJtmjc3ORbvp T+/vx4IR5izu2wrYOcIhbRfKz+aR8BUiocFnTIL5gTuKX/W4RBT7QfYiBwXJ8OQ3gMl4cCL75OU gLCE9GDGx0Syt3YHWQ3nryvt9dk+Kzu8rFB1wFYqA9qkVUQwXDdD5lRrqdTWT0aJVWyQq8WLm1D 00bziPJ+AZBnUxoNX/timR3d0tGGqutrI3XztK8mIQT2uIDUzG64Ta X-Received: by 2002:a05:600c:468b:b0:485:3989:b3e4 with SMTP id 5b1f17b1804b1-4887828a552mr10234925e9.6.1774894982765; Mon, 30 Mar 2026 11:23:02 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:02 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 4/5] staging: most: dim2: replace BUG_ON() in enqueue() Date: Mon, 30 Mar 2026 19:22:54 +0100 Message-Id: <20260330182255.75241-5-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 0b80f313a..23230a32c 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -570,7 +570,8 @@ static int enqueue(struct most_interface *most_iface, i= nt ch_idx, struct hdm_channel *hdm_ch =3D dev->hch + ch_idx; unsigned long flags; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; --=20 2.33.0