From nobody Wed Apr 1 11:05:45 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B183DA7ED for ; Mon, 30 Mar 2026 18:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894984; cv=none; b=GMqpuXVNmOcYihVXuQ8nqEG8T5EPbCWLH4gtxHqlKAoHTINR+n31vnYIEKjyhoyplqQnXnWzfk1kEBSKeOeB5kuVS7iOJV3qtHNBC+DEZ7pnHRB3FTyqRdoLazNG/dWyWOWPbRjKRttOCRTYPbUeHgdkOh9CR/jnyEKM42OgYKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894984; c=relaxed/simple; bh=afnlTER8NQZCosHmqikaBKCytlvj1AE7Y50aUK7CQCQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JEQglXhcvGb71yPEjoojzdjVm1B/20PyeR77inQEf/7GrmsG+3P3QVL+WerHtEeidJ3lnLpdkAxRRnikOF3ZDRAZN3SHhPX/KVWKQbD0xTy+SLDs5TU3aao3QlRAl7/WVHDgRe0nI9yiz7r3ikV9XIpxYcCkEe9qhF5A3CqvT5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N+8fN510; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N+8fN510" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-487012ce896so29759025e9.0 for ; Mon, 30 Mar 2026 11:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894982; x=1775499782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bjhxgiz3AskIlrAxUl1wlfuKjiBj1EhlUuK3gAiRWjU=; b=N+8fN510jhT8hYkri/OKQWT7NCDrNCR4yUMmtdQjR5i/h/MKNFU7e4GMgAuYx+5J7D qg/pIjubLZgHXkUrj9lPBEtWq+q8AvTRTfR7L1IY9Iev+ZVqaAicqq4+qVQFCQaqKiZy jaOyAwKdpcLOLHi+b21+A6avJmZe1L9+HygKNSyer+VMXBACSP8JTkwbsQt9CrFgmD9+ ghYvC0M+4Tsc7bmi+CiE3ZLE+dZ0mrhYbFcaVhjvH7NunthItS1zsfkydXF3Xe4os00Z OV1h7T1HUGXGHiaSKQmiCPoelCauRzc2c4RA1EQ/Egwc2ZLSq/9oeEj0laC4IsVxqmbm 4kOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894982; x=1775499782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bjhxgiz3AskIlrAxUl1wlfuKjiBj1EhlUuK3gAiRWjU=; b=XJN/q6Q7fU9/wRTwJIdhI3LDjPrzzpLOcp5nbB/Gvh3MC5BHwQzDmC4+7UuIr6mEzh 420bhnyEDRu4fnAgPMv0DQ7/IjssHK7m3Mt7XDtNWq7xySPdFjOmy5YFIRj+RARrhGuw zYctrIx+NLkfG/aoh3ilv5GROIa8N0aHZLUk3nYugu4txvAB7IuoACHuJpXw29UlJCAZ lXdjnCGvvXe+5/q6kz69FlAm8EysA/y/zVjv3nS2OyhIYg/MGd5pJmdiodNUs77P4Vve H+ZRX7J2Ym92u5SG63eq+hegdrGasVPALfTPc5NY5wIurpPYp5fW51vSFMn211D4ajvi DOOA== X-Forwarded-Encrypted: i=1; AJvYcCWRSCWPF+l+eAZrqmuNhKrxsTKIixNd5NtRwEI1BSyOolwL+9b/6JxZrrKJQ2SEFlpbj/h9j0JbHMWUsBc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt6PoLOzUcSj1paGsgdlkFKREe7aWwEkFDiT7I+F3WiJcvzQwC d3Whhl1J6DrNY3pUyJ85dPpeJkS4tfnd7QQ8vHxOOEpC/fo7L1fe/mR1 X-Gm-Gg: ATEYQzzlxg97huWAoVuQOPWmbcUemd7LTVNuvsHJP4gJchFXjc7Rd1QMRI1ZNJhbIqN 3LY+buPMtX0ZdE8wEdhb3RMKV5eYyhCFHQs99iv153Nix7b84GQTkQOtfP0fTdGkXNWOrzb+cMS kyw7G6GEoZeVlwBHFQFJEdg3xK09pAuOeyPGuBJizfMz8KCm6HUMqXHSPGgYgZwIX+cTbN1kdmL +E6TzVheaYjCtdPudwDrixcTrWQMR2MlOasxAWjJNVPZ9JhkBsxzTNsgOVqsWBxkFYjTeBtvmGK Wa0yQ3HI4RYn6BxfSmGcBBZvkWsxXULG4NaVVQ5j152rZcM0/ZUG0MsdM/dnL+EVEXihOhdowbm Pri4qv1Fsn0QhTFCOagzWPnoh+rRyOiL1pPBKo4soTEvxiYcmDSWP+Asy52PNFHXVG3b+XwYpNc pl0cQjHBCKlEE4/OIR8NRdWoWNsf0oaqcCPdg1utIYGENrtOIoK/TZ X-Received: by 2002:a05:600c:4e08:b0:487:1fb4:7b3 with SMTP id 5b1f17b1804b1-48727ef0cc2mr250199165e9.23.1774894981400; Mon, 30 Mar 2026 11:23:01 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:01 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 3/5] staging: most: dim2: replace BUG_ON() in configure_channel() Date: Mon, 30 Mar 2026 19:22:53 +0100 Message-Id: <20260330182255.75241-4-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index b820c3647..0b80f313a 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -457,7 +457,8 @@ static int configure_channel(struct most_interface *mos= t_iface, int ch_idx, int const ch_addr =3D ch_idx * 2 + 2; struct hdm_channel *const hdm_ch =3D dev->hch + ch_idx; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (hdm_ch->is_initialized) return -EPERM; --=20 2.33.0