From nobody Wed Apr 1 11:05:44 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1833DCDAA for ; Mon, 30 Mar 2026 18:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894983; cv=none; b=rh6n6eXE3b2abxkoctaUC96KgwsY5PjwxgE/ku/+zLKVJijEl7SxG9YvUZ2kpLptFIUtWWNBzh6RjoLMhOFJuqHGKSvp8hgRvgazhOsxTALu6wRzZ2Tb2ezZGiB00UgQnNvAqMkoH5sbTnvvRdpl2XxAOpx/G+vJK4igsOvSRfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894983; c=relaxed/simple; bh=DAeFPN+sO17RHHzLN3HxpZNpoUkxEL2tH+xtJwMVrO0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c0rUqz37J/+XTGpWw8NmL0vc+PrIeBnNsAmiVMQ1aFMWgBpqfmcY1O5d+9plp6E5TiJFE2xdEak3kPbovgY1sneGcl47foKYNOrF562M+lUgAHWuo5oVWmAvzW0q4NwDlThTDicxnItt0dCNBl1HiFGyJ276qd7y8N96sqvnOJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FN1E3zdY; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FN1E3zdY" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fb439299so44689495e9.0 for ; Mon, 30 Mar 2026 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894980; x=1775499780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=stK9cT5cCw4Q6PYwLkH9CVyAPf4y8jr4qJdOQMJe9ZI=; b=FN1E3zdYjjuq5HVqa+3xq2DAB7a0w3hTiZoruilW4qa6CUCyo1FEPsUu24/BbDNquv yzrP9tOLw5z4FWjEzSaLNSVjfed5bXeYe4dlO7s7kBTlvw+0y1WKxCFAC6Zdi520ECRk wEVUyiMK+TEGU8Lf/IYrIo0lAAZV1bMbBLgwOsnbjcakgNirPs4vQB8arhHW8p5SC3jN sNZWUnTanKcjtPpktjtBGi65U+yB/7xrO3B1UqweK/EURPifg2kwsWQjZjH4l4VP0+TR /pqu6QPsmcwPzLKTpS0GvZTDqi3v3c2lbp7bnR7m+Gt3I2LJAYrzCf9APejjul1qN9eo nV6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894980; x=1775499780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=stK9cT5cCw4Q6PYwLkH9CVyAPf4y8jr4qJdOQMJe9ZI=; b=sMMgwIhFZ0q3hn2FS7atzFbewhMmjs4KW4P3qE3KVeX28RxwcyRanWeVR4hfBkgVo4 8XOJoK+R9MlsbAb6pE0fohXe3fBZncfA1iTXqyTBWQ9xwEp7kzlfiVeXYNli1AGiZB5k xNuqZ4OR6qE79jedwPaIf0c1Xw6NlaHrHyXe40M5sqHySZWAAaHUG2kCReSNA60LTd1v WK3ED7s4XCxVVsyZEzVXW16zW0zXt4pvFteTwDzE65bxYgjL9WLiYwseQTAXzB/lsCvB cSsr7T/odw6uKdT4JAsbqvnl30cG9JOIb9DsKwjsNhGLrmyFKVvXZZwrYUMCB3nQq4Qc vDuw== X-Forwarded-Encrypted: i=1; AJvYcCUPMINEz5z1vTSJYrWsjMzqWIWEV8ACVEdmQj3rH/hFZ6luu/eRz3c0BHqZxA2ypYTMFjrLBZwQRkk9gKM=@vger.kernel.org X-Gm-Message-State: AOJu0YxNFEYD+uPBogXyu2VkHEbg4AJCOX9TKGkEgthMHPqvn8RZ8wI5 Tl8yuDD2pGNg39CgCEPjGlbsBvzkXrSV1Pclmc4MUNP1ufDmm6q2j5bm X-Gm-Gg: ATEYQzx0QiB4RggdkdB5m88XuXUl4lkabhrM9fULFc9qawK+NYkK2roa2n3yckYtlzA YTQtws8ICasLKoRKGQDCruRgYdG3HdPHAqJu+7fIDgVJGowOxKd967VB/lGxwNM/3hilNDBDbR1 XvN28CDQFShES2Y5BA2ENCxyitAoTFMuTbHGE3xWnxmJ9tu4eI4Trk27GXUU/2V3aPYF4v/GBTd XREKHgJYm0gB2YmHxCsNpmj4DMcWZCq9/8JvH4pedIvOTOTnLgOtA8RM3MIZ1OQvXIxxK0p/dCB mV1kvxKJ4KHU7BkSEvkD4KPxsiHERrlc2bNeM0xog0dT+ca9KEgpKjjkgOCTSVzaZ/7S6V15eam BWTk+e4qePjf6nKGJBRC8oPzyfFulK3nBDJPl0i4ck22M67+ES8irxLMLFOqhLCv4rCAQYgbl44 gcpEwibSsSkEdlVFh47OBLUgxuxheN7P4FFXiZooF1t7iZqLBzR0/m X-Received: by 2002:a05:600c:3513:b0:486:fb5c:3b20 with SMTP id 5b1f17b1804b1-48727f23fccmr210042895e9.13.1774894980297; Mon, 30 Mar 2026 11:23:00 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:22:59 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Date: Mon, 30 Mar 2026 19:22:52 +0100 Message-Id: <20260330182255.75241-3-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() calls with an early return since the function returns void. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 48315f8cd..b820c3647 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -271,8 +271,8 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) unsigned long flags; u8 *data; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); + if (!hdm_ch || !hdm_ch->is_initialized) + return; =20 spin_lock_irqsave(&dim_lock, flags); =20 --=20 2.33.0