From nobody Wed Apr 1 09:46:38 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB37E36E486 for ; Mon, 30 Mar 2026 18:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894982; cv=none; b=ak7gI9awRtKQO/gFCIOx+e6dAB0bthAcv4KHOleH2R1qdbpHwDAXFYdCXvqz0B/HX9Wfi+9b9yZFaUzz50IzypP4QAjq4UQLk9RMzzsEVmFIEbPmI9TVjYqIxPenOVyWTU+8GJLnCpS3Vmhie5FHPBV4k46ZoZpvCnEQqnYYoWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894982; c=relaxed/simple; bh=nQfxStQgAZIT/7V2Dz+B5yYQNdnSX6jeRQJEbF127hc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YfBUPwOUUG14IsXL5PW5blvIKS61bN7ndnBOrzUyQ2y228ME+P4Zz9SxPScTDY+ivOXol3WdB6KlR9RAX6hGar3e4jKPbhIEKaaB/w0T6UAtd+z2KSOZ+vX8xqpRMZmGKcT6WYh1b6w7qblgRte7tXuyyJvXT8keFGIwt9ZeYl4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l62M9c8W; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l62M9c8W" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso58024305e9.0 for ; Mon, 30 Mar 2026 11:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894979; x=1775499779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/YYKbi9TAQDo4vIdQzi1VMjiLJLyck2kBAU63KbgZ0A=; b=l62M9c8W2YcbBml79s0nDm4CDkRnyKD+O0dpvV+0GQrAdxBJCmLraxfusAW1hpXhPI Bx7WguD2mXLByPn9KNJgW8r2QgpAEkZncLbUaQIAcJEo9G/WJc0oKAcXffVx434bZ/vp Yz2nIwsnpF6WKzotbqLOKBrO4Rh9MPM9keQ+GkQR2+0Ojan0xSN6W6glzYH2QV/dylfW MvCFEQKxK0OTZRYMggjA6AI5k+Tw7bM8EkSBlPqrBGlhKqvyPLZ+YBCUI9X10TxwD19q ttLmgJtC94y4ulzbY15fHSQkYWeCYEFcsCSyLmJ5h0FIupRVbPFAr3I5BIFnbAuDfndU Olzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894979; x=1775499779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/YYKbi9TAQDo4vIdQzi1VMjiLJLyck2kBAU63KbgZ0A=; b=Gd3NVE7COygDfZMGKP+d/9vCyhcr21CqUCjzWZzIUOQrY1EiYdN5cAdD8YgI4PIa0p M6W5f3QsKsBeqcY3euaA+b5VRU5+QrRjyZWTvS4WswCZkvng4R7ofM0ltYdtWZfpr//u rHlgosTdiCj2g0fEhH2OrCl8NU6RGFUOydpF+MW4X0/564CKdME7mHDP98zAtHN/4Y5X xt0hZVakrKoJzL5PRtrUWdNoTklLw7K4K5aaxztXVTh6jjbAtYU0cqO3LJomwRtLl3vY pr+R0iHg3q769g5kFcEhEsr55396R9HEsophVyX/eDan4aM2m7s5evMwDL3RNFQ256RT mx2g== X-Forwarded-Encrypted: i=1; AJvYcCU3QMNm/OiZIKGN9W6YECikYFF3hFoEtCap8FK6mtqGWv71tRxNATfxuD+dmBIC23D9+WN8BLlB1hwFBX0=@vger.kernel.org X-Gm-Message-State: AOJu0YxdGbCuGghKnL9/es+yBNBGLxm79AWUucEZ+2HvDkkl8IqdCU+h LX1U/d9poo6qC8d8iNMiFUZN4N+xTDPs5m7Oz3Klo8iW74N5LGhcYThW X-Gm-Gg: ATEYQzwiSy51tLGPyKhpTvzBzlFXmtRiGYFK1TOVsIrQU/Y/ETu0sUEpr1FVcJLJVN/ sdmc0jJ+U2oSVb0x8BJhhwb73c/Q3+phxyD50j45x+QUdjYekB+Ic5XUA1FdizJt810WWqMBHHW exFsnTXuKxVowS8Et76mi9jOwPIvZAE1rTUMiW8KYN4Uc1bW68XrWCG8qeWjZ2ieYTAMORkLBNa CFjDGufh2QUUwX/hNAT5JBkWdGr3r1KN1U3OZeCv1vbzt7M8KuNodmIbI7wJBxSmq0aQ6bR5Qt9 BvxlpzPFTnBL/W4jPYEvB+b3IRA/HawjU4yPoSiHeHHr3jmKyIAq3wdEyXNlxx2Qu/+aS2/lsde ESIqSZ9PEce3GVHw6+ghWnUVq6uUep6zKJ7HP8BMquR7S+WGQ2LIBcbjpf1fDjnNqZUll11Hp0U xbFvSa9UyeSlBU2FtETe9Qmz2xPyQZmm96H2KjDGblUb5FhShwz0vt X-Received: by 2002:a05:600c:4e15:b0:485:2ce2:4c8a with SMTP id 5b1f17b1804b1-48727d67a21mr218116275e9.1.1774894979039; Mon, 30 Mar 2026 11:22:59 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:22:58 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 1/5] staging: most: dim2: replace BUG_ON() in try_start_dim_transfer() Date: Mon, 30 Mar 2026 19:22:51 +0100 Message-Id: <20260330182255.75241-2-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() calls with graceful error handling. For the null/uninitialized channel checks, return -EINVAL instead of crashing the kernel. For the zero bus_address check, release the spinlock and return -EFAULT. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 66617e89e..48315f8cd 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -165,8 +165,8 @@ static int try_start_dim_transfer(struct hdm_channel *h= dm_ch) unsigned long flags; struct dim_ch_state st; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); + if (!hdm_ch || !hdm_ch->is_initialized) + return -EINVAL; =20 spin_lock_irqsave(&dim_lock, flags); if (list_empty(head)) { @@ -187,7 +187,10 @@ static int try_start_dim_transfer(struct hdm_channel *= hdm_ch) return -EAGAIN; } =20 - BUG_ON(mbo->bus_address =3D=3D 0); + if (mbo->bus_address =3D=3D 0) { + spin_unlock_irqrestore(&dim_lock, flags); + return -EFAULT; + } if (!dim_enqueue_buffer(&hdm_ch->ch, mbo->bus_address, buf_size)) { list_del(head->next); spin_unlock_irqrestore(&dim_lock, flags); --=20 2.33.0 From nobody Wed Apr 1 09:46:38 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1833DCDAA for ; Mon, 30 Mar 2026 18:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894983; cv=none; b=rh6n6eXE3b2abxkoctaUC96KgwsY5PjwxgE/ku/+zLKVJijEl7SxG9YvUZ2kpLptFIUtWWNBzh6RjoLMhOFJuqHGKSvp8hgRvgazhOsxTALu6wRzZ2Tb2ezZGiB00UgQnNvAqMkoH5sbTnvvRdpl2XxAOpx/G+vJK4igsOvSRfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894983; c=relaxed/simple; bh=DAeFPN+sO17RHHzLN3HxpZNpoUkxEL2tH+xtJwMVrO0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c0rUqz37J/+XTGpWw8NmL0vc+PrIeBnNsAmiVMQ1aFMWgBpqfmcY1O5d+9plp6E5TiJFE2xdEak3kPbovgY1sneGcl47foKYNOrF562M+lUgAHWuo5oVWmAvzW0q4NwDlThTDicxnItt0dCNBl1HiFGyJ276qd7y8N96sqvnOJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FN1E3zdY; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FN1E3zdY" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486fb439299so44689495e9.0 for ; Mon, 30 Mar 2026 11:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894980; x=1775499780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=stK9cT5cCw4Q6PYwLkH9CVyAPf4y8jr4qJdOQMJe9ZI=; b=FN1E3zdYjjuq5HVqa+3xq2DAB7a0w3hTiZoruilW4qa6CUCyo1FEPsUu24/BbDNquv yzrP9tOLw5z4FWjEzSaLNSVjfed5bXeYe4dlO7s7kBTlvw+0y1WKxCFAC6Zdi520ECRk wEVUyiMK+TEGU8Lf/IYrIo0lAAZV1bMbBLgwOsnbjcakgNirPs4vQB8arhHW8p5SC3jN sNZWUnTanKcjtPpktjtBGi65U+yB/7xrO3B1UqweK/EURPifg2kwsWQjZjH4l4VP0+TR /pqu6QPsmcwPzLKTpS0GvZTDqi3v3c2lbp7bnR7m+Gt3I2LJAYrzCf9APejjul1qN9eo nV6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894980; x=1775499780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=stK9cT5cCw4Q6PYwLkH9CVyAPf4y8jr4qJdOQMJe9ZI=; b=sMMgwIhFZ0q3hn2FS7atzFbewhMmjs4KW4P3qE3KVeX28RxwcyRanWeVR4hfBkgVo4 8XOJoK+R9MlsbAb6pE0fohXe3fBZncfA1iTXqyTBWQ9xwEp7kzlfiVeXYNli1AGiZB5k xNuqZ4OR6qE79jedwPaIf0c1Xw6NlaHrHyXe40M5sqHySZWAAaHUG2kCReSNA60LTd1v WK3ED7s4XCxVVsyZEzVXW16zW0zXt4pvFteTwDzE65bxYgjL9WLiYwseQTAXzB/lsCvB cSsr7T/odw6uKdT4JAsbqvnl30cG9JOIb9DsKwjsNhGLrmyFKVvXZZwrYUMCB3nQq4Qc vDuw== X-Forwarded-Encrypted: i=1; AJvYcCUPMINEz5z1vTSJYrWsjMzqWIWEV8ACVEdmQj3rH/hFZ6luu/eRz3c0BHqZxA2ypYTMFjrLBZwQRkk9gKM=@vger.kernel.org X-Gm-Message-State: AOJu0YxNFEYD+uPBogXyu2VkHEbg4AJCOX9TKGkEgthMHPqvn8RZ8wI5 Tl8yuDD2pGNg39CgCEPjGlbsBvzkXrSV1Pclmc4MUNP1ufDmm6q2j5bm X-Gm-Gg: ATEYQzx0QiB4RggdkdB5m88XuXUl4lkabhrM9fULFc9qawK+NYkK2roa2n3yckYtlzA YTQtws8ICasLKoRKGQDCruRgYdG3HdPHAqJu+7fIDgVJGowOxKd967VB/lGxwNM/3hilNDBDbR1 XvN28CDQFShES2Y5BA2ENCxyitAoTFMuTbHGE3xWnxmJ9tu4eI4Trk27GXUU/2V3aPYF4v/GBTd XREKHgJYm0gB2YmHxCsNpmj4DMcWZCq9/8JvH4pedIvOTOTnLgOtA8RM3MIZ1OQvXIxxK0p/dCB mV1kvxKJ4KHU7BkSEvkD4KPxsiHERrlc2bNeM0xog0dT+ca9KEgpKjjkgOCTSVzaZ/7S6V15eam BWTk+e4qePjf6nKGJBRC8oPzyfFulK3nBDJPl0i4ck22M67+ES8irxLMLFOqhLCv4rCAQYgbl44 gcpEwibSsSkEdlVFh47OBLUgxuxheN7P4FFXiZooF1t7iZqLBzR0/m X-Received: by 2002:a05:600c:3513:b0:486:fb5c:3b20 with SMTP id 5b1f17b1804b1-48727f23fccmr210042895e9.13.1774894980297; Mon, 30 Mar 2026 11:23:00 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:22:59 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 2/5] staging: most: dim2: replace BUG_ON() in service_done_flag() Date: Mon, 30 Mar 2026 19:22:52 +0100 Message-Id: <20260330182255.75241-3-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() calls with an early return since the function returns void. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 48315f8cd..b820c3647 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -271,8 +271,8 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) unsigned long flags; u8 *data; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); + if (!hdm_ch || !hdm_ch->is_initialized) + return; =20 spin_lock_irqsave(&dim_lock, flags); =20 --=20 2.33.0 From nobody Wed Apr 1 09:46:38 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B183DA7ED for ; Mon, 30 Mar 2026 18:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894984; cv=none; b=GMqpuXVNmOcYihVXuQ8nqEG8T5EPbCWLH4gtxHqlKAoHTINR+n31vnYIEKjyhoyplqQnXnWzfk1kEBSKeOeB5kuVS7iOJV3qtHNBC+DEZ7pnHRB3FTyqRdoLazNG/dWyWOWPbRjKRttOCRTYPbUeHgdkOh9CR/jnyEKM42OgYKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894984; c=relaxed/simple; bh=afnlTER8NQZCosHmqikaBKCytlvj1AE7Y50aUK7CQCQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JEQglXhcvGb71yPEjoojzdjVm1B/20PyeR77inQEf/7GrmsG+3P3QVL+WerHtEeidJ3lnLpdkAxRRnikOF3ZDRAZN3SHhPX/KVWKQbD0xTy+SLDs5TU3aao3QlRAl7/WVHDgRe0nI9yiz7r3ikV9XIpxYcCkEe9qhF5A3CqvT5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N+8fN510; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N+8fN510" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-487012ce896so29759025e9.0 for ; Mon, 30 Mar 2026 11:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894982; x=1775499782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bjhxgiz3AskIlrAxUl1wlfuKjiBj1EhlUuK3gAiRWjU=; b=N+8fN510jhT8hYkri/OKQWT7NCDrNCR4yUMmtdQjR5i/h/MKNFU7e4GMgAuYx+5J7D qg/pIjubLZgHXkUrj9lPBEtWq+q8AvTRTfR7L1IY9Iev+ZVqaAicqq4+qVQFCQaqKiZy jaOyAwKdpcLOLHi+b21+A6avJmZe1L9+HygKNSyer+VMXBACSP8JTkwbsQt9CrFgmD9+ ghYvC0M+4Tsc7bmi+CiE3ZLE+dZ0mrhYbFcaVhjvH7NunthItS1zsfkydXF3Xe4os00Z OV1h7T1HUGXGHiaSKQmiCPoelCauRzc2c4RA1EQ/Egwc2ZLSq/9oeEj0laC4IsVxqmbm 4kOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894982; x=1775499782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bjhxgiz3AskIlrAxUl1wlfuKjiBj1EhlUuK3gAiRWjU=; b=XJN/q6Q7fU9/wRTwJIdhI3LDjPrzzpLOcp5nbB/Gvh3MC5BHwQzDmC4+7UuIr6mEzh 420bhnyEDRu4fnAgPMv0DQ7/IjssHK7m3Mt7XDtNWq7xySPdFjOmy5YFIRj+RARrhGuw zYctrIx+NLkfG/aoh3ilv5GROIa8N0aHZLUk3nYugu4txvAB7IuoACHuJpXw29UlJCAZ lXdjnCGvvXe+5/q6kz69FlAm8EysA/y/zVjv3nS2OyhIYg/MGd5pJmdiodNUs77P4Vve H+ZRX7J2Ym92u5SG63eq+hegdrGasVPALfTPc5NY5wIurpPYp5fW51vSFMn211D4ajvi DOOA== X-Forwarded-Encrypted: i=1; AJvYcCWRSCWPF+l+eAZrqmuNhKrxsTKIixNd5NtRwEI1BSyOolwL+9b/6JxZrrKJQ2SEFlpbj/h9j0JbHMWUsBc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt6PoLOzUcSj1paGsgdlkFKREe7aWwEkFDiT7I+F3WiJcvzQwC d3Whhl1J6DrNY3pUyJ85dPpeJkS4tfnd7QQ8vHxOOEpC/fo7L1fe/mR1 X-Gm-Gg: ATEYQzzlxg97huWAoVuQOPWmbcUemd7LTVNuvsHJP4gJchFXjc7Rd1QMRI1ZNJhbIqN 3LY+buPMtX0ZdE8wEdhb3RMKV5eYyhCFHQs99iv153Nix7b84GQTkQOtfP0fTdGkXNWOrzb+cMS kyw7G6GEoZeVlwBHFQFJEdg3xK09pAuOeyPGuBJizfMz8KCm6HUMqXHSPGgYgZwIX+cTbN1kdmL +E6TzVheaYjCtdPudwDrixcTrWQMR2MlOasxAWjJNVPZ9JhkBsxzTNsgOVqsWBxkFYjTeBtvmGK Wa0yQ3HI4RYn6BxfSmGcBBZvkWsxXULG4NaVVQ5j152rZcM0/ZUG0MsdM/dnL+EVEXihOhdowbm Pri4qv1Fsn0QhTFCOagzWPnoh+rRyOiL1pPBKo4soTEvxiYcmDSWP+Asy52PNFHXVG3b+XwYpNc pl0cQjHBCKlEE4/OIR8NRdWoWNsf0oaqcCPdg1utIYGENrtOIoK/TZ X-Received: by 2002:a05:600c:4e08:b0:487:1fb4:7b3 with SMTP id 5b1f17b1804b1-48727ef0cc2mr250199165e9.23.1774894981400; Mon, 30 Mar 2026 11:23:01 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:01 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 3/5] staging: most: dim2: replace BUG_ON() in configure_channel() Date: Mon, 30 Mar 2026 19:22:53 +0100 Message-Id: <20260330182255.75241-4-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index b820c3647..0b80f313a 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -457,7 +457,8 @@ static int configure_channel(struct most_interface *mos= t_iface, int ch_idx, int const ch_addr =3D ch_idx * 2 + 2; struct hdm_channel *const hdm_ch =3D dev->hch + ch_idx; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (hdm_ch->is_initialized) return -EPERM; --=20 2.33.0 From nobody Wed Apr 1 09:46:38 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A62163DEAD1 for ; Mon, 30 Mar 2026 18:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894986; cv=none; b=MnCFRfwYhR7BQQQUz8QHc7K6JniBv8DbmxCizaQ/qNrJlqc6C2ArGoSY09KGvR3w5W4RAg2i5ttrQspd3tswkeFNZ24ypTZBrhVOrf5brVtkUYowqefy+c8Qb49ZsaAaHAqJM73wDIQgiS2yE9PY5NxPg/ZUoaC9MTKWW0ARpZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894986; c=relaxed/simple; bh=7v6hWVMphHmp1fk2Axl/HTUNGWtaCf74TNaGvVarMjc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RQQHAWMVL2+y/lLJefJxLbPvFX+bMisjkO2QpleLP0wnRVwstQe9hnyK9ktsm0gAu/VyMKs0pnX+qxZfcYn+Cm+01qr9xqyZLsnBOjXudRE6FHmx7/tB31eyc0ScS2dGNvlhuxIcosU1e5CWbHzI6+z8qnLXgBED3EgKBswx7WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O0+ra6wa; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O0+ra6wa" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486fc4725f0so47944265e9.1 for ; Mon, 30 Mar 2026 11:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894983; x=1775499783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zxKeE3nFIhdamqdbJMN8NtBpVsh6P3ltxH0ua/ul5Bw=; b=O0+ra6washLiN3mc4R7mqlaL3CLpOPPSXfm7IidbdvWyFGhE8zI74PPgfDbBc0tqeG +KiiE2JeS3qYax57OShb9o+tUfdq7l4moiX1lWVlXcz2Jtn4VOjD7TUC121uzvkLkqZO rkQtBxtYLD88++fQC98EVuk5+818KdTJs0xZ/DVUuAcw40xh8y6ibkXjrnuo5Euvz9JA 2nUq34QzSoJDca1RtpMDBQLH9SBe1pKDWen4JDIrILSAD283wVjc7FEDisNwIKe731zI vqWTVzwx8c00MdI6cFHPvC3btN1coTAGut7NXV0DaeWUtCWV85EGBg2bjIWeFhIuj6Wi pgMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894983; x=1775499783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zxKeE3nFIhdamqdbJMN8NtBpVsh6P3ltxH0ua/ul5Bw=; b=O4l3VuBL1tdAN+74H9JnptIrh13dVw/xM6ZIhZtljqDIZqFO5UcdAfpNLH4ufZ2Szx Xl50AQ5eYb/KYuRofdcRXbMk3M+YkIIlFskoqdnI6R3DwvLMz3KCCJTy7m5ZtDv0CFnC wH991w6SN8gk99sA/GI7H7AuQjt+cwpcsSM4HmpNUwc+e8jgaEJmNBE0gQ6YaHSbzpVF dHtI6NHAnbvkQbgPNbNMk2jA25AugNTqq7CT/GPjg9cvdOFd/MhlwwI06fHeBhbN9Wa0 KHuHinOxNTJjnoDX8FQolXx47H4kwlu5IZUz/NHUbtY4q5MlHby0X/FJOVlj4s2DdgWZ JKtg== X-Forwarded-Encrypted: i=1; AJvYcCUnDt4cZclmQFEnPrAv2VjuP2vDIR8by2hHSLLDWAhsk45JeaoKNesZC+fVNZoaWR4ngEEeo7UDel7ZVB8=@vger.kernel.org X-Gm-Message-State: AOJu0YyOo/0pBUfDGeyOYHtqKdBy84lg0EKkgz4YKxRLF/7g0CbdpNAy PN9mc+Nqun1XhTgo7sFXOvNne6JI+ITj1BtMof9bfPpAjXRp/47GXoNZ8c4uGjWIOm+eTQnt X-Gm-Gg: ATEYQzznCBupQpzxA1beIT7P9GtXAYoQl3zP7ZlMYjWsOrmNyNU4aVfOO5pq2LWckpz 1vPOVPdARkFssld0AdZmzk3mHI4ERmBxV9dnie7TIveUI3s3orAsAevYKvb/rDYep2T+6KtKWwK YVX+2/yixPsMmi4sjtxhhNZEpQWLLWuzr/VtXHtiHAw7WzsDY+2DR/XL5T+sawypKnaB55nzj2m uO1KuNFClBk8UBuw19mM3sxamD79nghc3kMg1WCct21AQFVTxOdYY+Hb60vJWOpJJtmjc3ORbvp T+/vx4IR5izu2wrYOcIhbRfKz+aR8BUiocFnTIL5gTuKX/W4RBT7QfYiBwXJ8OQ3gMl4cCL75OU gLCE9GDGx0Syt3YHWQ3nryvt9dk+Kzu8rFB1wFYqA9qkVUQwXDdD5lRrqdTWT0aJVWyQq8WLm1D 00bziPJ+AZBnUxoNX/timR3d0tGGqutrI3XztK8mIQT2uIDUzG64Ta X-Received: by 2002:a05:600c:468b:b0:485:3989:b3e4 with SMTP id 5b1f17b1804b1-4887828a552mr10234925e9.6.1774894982765; Mon, 30 Mar 2026 11:23:02 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:02 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 4/5] staging: most: dim2: replace BUG_ON() in enqueue() Date: Mon, 30 Mar 2026 19:22:54 +0100 Message-Id: <20260330182255.75241-5-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 0b80f313a..23230a32c 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -570,7 +570,8 @@ static int enqueue(struct most_interface *most_iface, i= nt ch_idx, struct hdm_channel *hdm_ch =3D dev->hch + ch_idx; unsigned long flags; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; --=20 2.33.0 From nobody Wed Apr 1 09:46:38 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EF22E4247 for ; Mon, 30 Mar 2026 18:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894987; cv=none; b=e0fB16dPLQuxohpFxYMuOlsxfRspUqzVGj2GbxLLHVngmvyta3BTteX5KD/ZlfPC29Ueci/DCvumtIeQiwICu6gw4y5LBBB3PdtcRd3eUvM+7N7EtT0zFmWwSDq4lqAOa/MyLzKHprBoxmRi7elxMH2rw+s92eCh0rt9r+MWIpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894987; c=relaxed/simple; bh=suqsuBsVchdVwVar4ZZtGbmQ+dClyiLJBPlCob+IUiY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xh8lL+4+9qu/TLIn/M1OfXt50s5VayLkurbrV3wZKIOsOLcL05TUpD+0Tpvg4NTJSOgjMogPYhDghdZpSp9uiT8TnfMJ6KsRyJurKhLfSU14BcuG4ZqabrEvoISWqlpEXQZ6JhHH0VgZsyLPGE+W263vCG6Ydn1PJ7qdlWSVIV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lZ+fJlff; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ+fJlff" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-486b9675d36so40613015e9.0 for ; Mon, 30 Mar 2026 11:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894984; x=1775499784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PcKBh4KWsiN7v1ouQtoD5ZQbdxWi7sovHzhSf4lU27I=; b=lZ+fJlffqqAeLJ4lsMVWjWUqmdoUJemHb+OghwcHM3TzY63DEaU6zvG21x9YDG9tTm sOQMCOcHysYfBa1JYLhBQx6G9qELlVHjhS7MM5fXygFgUHNq0yVE7HKKTYF7A/Dmr9Fu Jb/STuFOLyY930/VZZioblTGLNujavXEmq9gU64lMxZLTbU25YY3Wovp9Mml+n+xOVsI QtjqVxCmtdC/pxXsm0NKU8DYyOhTkD7I/hDgVifGFv8iM8jjgJPrUxJPyhMFT+1i3KH7 +1gXECZXMaCLVgW4ZHNEBbPj/5Kj91bO699GhcVhyU+t+GDBKRNPsrL88D9vP6f+Lrip OQ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894984; x=1775499784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PcKBh4KWsiN7v1ouQtoD5ZQbdxWi7sovHzhSf4lU27I=; b=MFt6/7lUTBvoufzID9w82jxMyrFV9qxmOFXphu+gpc36pO/SPj49zur7BqUa4sHOxC 1EDHAfPXx0UlVwNuBfCJJGjRJ6igQywuMLGvXAAAzqdfmnqzG5AQzxUw+TShGEAg5SX9 K8aUvRrY4wOuaSJOf7IJ08UftoQUrPFZ9DU1zO3mbH2eQ0vYDqqzp+y0LsMsYnTbFfUU z5BZh1DjfuVwBFtJFIlSALQBM7KMTYYRudMUo++6Kdmbua423vRyEhjZrBQH6nGdjgkQ 9QNoiPAMszDPIG/pKvH4G9JiMr/O3BMHtb+W15GjhJfLbkrImCZKo1m1/iuvonNM6pzx z1uA== X-Forwarded-Encrypted: i=1; AJvYcCVjoj1k9ljUJz6kqNnIPmlcxFxSxKNmBvjDE1rtWWErqhF2YEbaenjHJLzlJxkyKpen5C15GD4b1BFfHbk=@vger.kernel.org X-Gm-Message-State: AOJu0YytRPFfr55kaQYBAsQsXgPEIym6lUVqfjn75496pgUR1cI+nVIo GszJhPH7iO1HlDQ8OarlxRK8ASelzuqCXVwoKsQMCkANR/myzjGIMYW3 X-Gm-Gg: ATEYQzxn2s0vgF6npFR81jCQBvnY2I4VpzLRqq24nXhx0Eg6pF3712sCAwO7M3u7Fg3 DTfvntg6qzSe5M2Iysrn1w0xMEQhbWZdXhIGo3I6l9CYCVRqw1Bc9DKdnU4krUDphp2Dux9D4Xr YdwvgizrzMxaQhnUQEFzVwubzn6QfqkIhDUfBX0B3UZl5auoMkeulp8Nmnq+OmumEe6BH/gpI1p rFDcZ0+144frKk17yMikQELxptXF8OlJD+P5EwcgIl6WaIMwAy7GVK5E71P5/Uy/v/weMXuScws KtUTNaQDA+8Mz9x+EsNxenmjGaGUj/ghY/c+OHG4ouo1FzwkJ/my7ytT7pIPm36Q9MUhBAAqmeL 7LhqpNL5mS4QYaRbk67sh25xbU5p40mod6w1paEVO/rpJP7JSDzBYD2HC32V7qJ/+pQtT2y6dMw QiufrgE4Dm3g8q7wgRRuSF7hCUZD2E5BqSM92sI8XVdz0uUbo7weer X-Received: by 2002:a05:600c:a31b:b0:487:716:2fa2 with SMTP id 5b1f17b1804b1-48727ec3c1dmr187938795e9.16.1774894984046; Mon, 30 Mar 2026 11:23:04 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:3437:41ca:45cc:e6f1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48733c095dbsm130198405e9.0.2026.03.30.11.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:23:03 -0700 (PDT) From: grondon@gmail.com To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gabriel Rondon Subject: [PATCH v2 5/5] staging: most: dim2: replace BUG_ON() in poison_channel() Date: Mon, 30 Mar 2026 19:22:55 +0100 Message-Id: <20260330182255.75241-6-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330182255.75241-1-grondon@gmail.com> References: <20260330182255.75241-1-grondon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gabriel Rondon Replace BUG_ON() range check on ch_idx with a return of -EINVAL. BUG_ON() is deprecated as it crashes the entire kernel on assertion failure (see Documentation/process/deprecated.rst). Signed-off-by: Gabriel Rondon --- drivers/staging/most/dim2/dim2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 23230a32c..7953d4626 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -647,7 +647,8 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) u8 hal_ret; int ret =3D 0; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; --=20 2.33.0