From nobody Wed Apr 1 11:10:57 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2456383C69 for ; Mon, 30 Mar 2026 18:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894686; cv=none; b=KWJrNiODCxXapZ7r0fmmaDE0E+uThLJRDBtE0B8DmqNmb13ui2bxJjyQpGiGWgU+iwBdgHMpfUU9ri7Qo2CeDcqMlWY7Fnl9BeiepXJSwnUG5jkoiYY446/zeJB/iomsCp1wnnhcj0eYJblGViyIyQ6zp6o26tzR4nij/Q28KH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894686; c=relaxed/simple; bh=jWDPKmEInibgEwWSaBhCJV+GEWo9o58hMOVkOchtk38=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A/Xqo+dWJ8ZtpFy5Q4HDWj4Ybu9IeEZ6icK5focBI1BJ8Cp9RZGXbfbwn4lcCxx1NJnonB4zoGhaWE7/tZrvclus1xoZFFLxHOUnYAoUrWBUL1nWt8uHXwOJQp7FKoBU7NqkKPByvuLYiawNlqqLs/BZiIBWL/rGdrwxWD0FFGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pnrTNlzv; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnrTNlzv" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-8296dabef74so4573690b3a.1 for ; Mon, 30 Mar 2026 11:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894684; x=1775499484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=egWOjCKA5Tr5GMAmRAwMz9x5gxn0udJ7TK4JECSEdQE=; b=pnrTNlzvbF7YBpcMN6z38g2lvQRKzPq00RW3RUlHqdn0utoFewQLjdDvHZhoLJNhWq 28L/BtsCCXxlgRt5pG//IRrl25KAeyLbh6j4qx/XgU+tIuexxCxC92gmxrjTPu50rpcj HXHKcD7Ac/TMWoPPDONUwU76WET6PSn/84Xg9bEZ3jHLlBZEvBv/Hzbd3h3wLpE+5XZX 6nZggPU/9XMjXuJ3EgRaF+TSXTrDDYtBcdYjFgzc2w6igTcX8KNPvb7bPlWD2ORFpmYB g8cvH6pUFNcgdQkW/dmedmSALQzd42bMT7g1iM4CascZt5yRuJ+x2A8gs5ua5ilLC5Yv OR5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894684; x=1775499484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=egWOjCKA5Tr5GMAmRAwMz9x5gxn0udJ7TK4JECSEdQE=; b=GnOUu572CjUfW2oTVFcpj+QBpJ1lwyLrPEn046MnxYheypfpAIlTdzp97hTZU3Fguh oddt6ZMYqKydtXi1TwQpktAKBGWJUczr3JYe200DCFru8MAYyBSU/eVILGZVloHtYVDk eAc4ez1lAFPCwOWmZ3h+xqA7L2R93h1C6woopd0oXJTkeyf+HeBV4/ikJ0SJtwmIfYtI RtyHdZJiMTAizNNCqQDjsQUmHuPT1PW0fVTEWKV5d0iLQz5KTqlyM3fDUHT8v4tNdLaz ailTMKnYoPycw9nA0zLxo121h5cbCmp15RJbqqYr6oIIbcfdMO3SZ7XVoqXzjUtC82tw mpuQ== X-Forwarded-Encrypted: i=1; AJvYcCVlfLuspfQlVjhZS97FUgq3jB0JKF7F6cKRT0xesJn1dTeuOn1zabijuw0NLPhMAC3d99hlP51fkud23Sg=@vger.kernel.org X-Gm-Message-State: AOJu0YxecU93W0avg+ZXey4QFzgMgPsKyamFMv/mE8QDBzN6GAv8tI0I LRdCXHedTywbU5SDjatyqLzKifw7Pa0LnwnfZrfOCICl5nhdf3oP7uXS X-Gm-Gg: ATEYQzzC6TcxJbRoKUUVRGgpQl7Ooj3jk0nnoT008GFJyWRiDVjjDNjXliRLjQayFE5 msukN2PGyoS9uhUFcV6L3Q7rR6nX561E5O/wV0bx3ellyUJN+zoltSA5BZEnd7YNpDKVLyI1e29 u7p/jVbM6l3LiMW2men0c5+sp5XmtvVv12I3zagTciDiosyeIj/BF09rS0z3R5/bz5EKSEDUB1w vPgJSRbwMiudrG4ke5FuYmni9aZs3ov1nIoLjdJvjGlWfiW3ClKbM945td3V5VMPiurVt0+4E33 SOw/MzJEM5ZqX9F27kXiq+XK0GAD0FwgLVyA1Y5FiAvf65d53eNYEFO+4C8cnLGSQOoX9SyQNvW sNizYTcDcQ+htM8tc9nTO9lSIBMcyVkMiiSHrhrTcOCoQDamrrYrAYIQXLaiTNqs9Z14F2+TM9y 3I3DdJTVz9JiJBTTSYPUJ9EMdeAq9Qu9HD6iqyLCM/ X-Received: by 2002:a05:6a00:2e1c:b0:82a:768c:9a49 with SMTP id d2e1a72fcca58-82c95ef6a78mr14209644b3a.42.1774894684234; Mon, 30 Mar 2026 11:18:04 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:18:03 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Tue, 31 Mar 2026 00:17:10 +0600 Message-Id: <20260330181710.23258-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modernize the driver by using IIO_DEVICE_ATTR_RW and IIO_DEVICE_ATTR_RO macros. This involves renaming the callback functions to standard _show and _store formats, making the code cleaner and more maintainable. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f2486cb29..80f84e2bb 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -121,9 +121,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -131,10 +131,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -150,24 +150,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -175,10 +171,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -208,14 +204,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -239,7 +232,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -269,9 +262,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -289,10 +282,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -330,8 +323,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1