From nobody Wed Apr 1 11:16:22 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739B8362151 for ; Mon, 30 Mar 2026 18:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894679; cv=none; b=mNxBrVp4o0rqbS64uFKk4nWsNb8GacpZHZXSfwMCF9jjMTISDalxKofz2OlvsGT4Ku9IW41ODCJRzmIxGiXgoREwTN9A0k5V8A1Lw46Q70BMKhbWQXNqj0mgbbZ7IV0KCfe/4TeGRS7ADmbooUzWqi4Ryi4WbRZHNQanCwAC9Ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894679; c=relaxed/simple; bh=Br5vGAXYgtBTtZqV3PmJuhT96uRJmxgj8Z+FdJj7Yxs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UAUq46f9GYRk8Bvg7QYAS0m08YEENxEv55v/cMPVnpttNsDWqEQ83SonIf5zkD3fB0K0zxldiUEryot+Tgi1zspMy9vqZbPzNVXPeAIVS6Gt/H1oCWL5xA3qzB48X3FXFMiYGbYSmaNXWsGngUDsy9jqfqZfV2iJJ5qgXT67/IQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UXyVgLdv; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXyVgLdv" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-82a62714fe6so1917527b3a.0 for ; Mon, 30 Mar 2026 11:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894677; x=1775499477; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AEev0NrgAro5b++Ke8wuTx9Yh3OdT4GarY6/WNk8AFQ=; b=UXyVgLdvJcpR39RSvtP96JNd83RUi6khDbasqa71wEFNAC2nfFuC0QFvkZ6AslVj5t PQAdng7mIk87UZNw2K77kIB+y4MwF5yibO4LBaXjTkHUmNx7cy+1Tiqk451lgRAshLqU pT5tDcA+eqoUdPo1wahPsXYPw+xv14tT4U2KDkJm8CE6ByeuiRNfUPNIl2wECYoN7RLX z8C9KN2eHp+VAReeart51e3T8iqeqhEnCyZYP/Fd4EM1kVGTzrILNvI+vjujBYsYsymG zgGSlHqVxgxIm5dZ9IJ5FkmVtSTy9Io442oGSvh3DdTR/6LxTGRxJXJghsX6DLHkoZ5k NNMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894677; x=1775499477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AEev0NrgAro5b++Ke8wuTx9Yh3OdT4GarY6/WNk8AFQ=; b=YfHz9zcXesGr9NfCn4LMbdbaF/v/RoJgXEzbWt5/GTqbXVIhwENa0TszWa5a1J2FuR Wsc6SBILLJhux+k8v1Gu7EBxJo17vh7o6K8SNABDHab7WUTher8Rdyj4fa89kCDoDwj2 1tJr+0WjbV+E2SEdILkNdRkQvpWPRtHICXaKKICktM4qVDo6/+MihmGSHFg2efXuWRLV MiTmYrwwUyHuem1MeBmokpwf1Wzq+2BPDrMV4JWeBb5aTgH3uk9nLMZJSwj6LGKHheag lFr4n0rUWMURAw9pBGC2jHSq5n5FLHHePHBZcZ9XdQk+rf1chWFGRtjgs/XQQjw/8lXG hmbw== X-Forwarded-Encrypted: i=1; AJvYcCWp7AtfxzngtvATsXlMcbAc6UHCrFUR2HuU+1f1q/qwM06pjB79RZxpZN0V4JCTYYMWm+Z7GoE7L9/XrvM=@vger.kernel.org X-Gm-Message-State: AOJu0YwvBne0ZoDT59xHfu1rP3dAvkPC9Me/u1cHVBaDz+wc8CuTALRU 6OMgvVRre2yQskBateWzSefvhisIin2ahez2y4olVp9k3wLfZBoIwruA X-Gm-Gg: ATEYQzz2rW7oEnKLs4+KRakfaQ6KLCb/lLEark8wz1BVJxDHU0pTy2YgwT6BXPjGy/g eKNPx0QCgKt51CRTDA0otrUX5cC9Mb/8uM/9Bmvc3T7QocCGTGSECq3IrXZs5M9UAPNbu99dB9y g4tT2mIkPqj6qinmccMoVDmDdQ/xSlrcTHG994WyVFc0jA52uXUzJKFdJ6ILYGvsexFdJcASq37 iqsdi30lRbXuxMnG9ispXiyzu+Ld4dwxKN7Xeur0BZmoFBkTiYHCq5GXCO9BtXRGRLIR0sUE3IP Nj0ZK91/uxdapCSNC2s1vnu5wQgyy36M+sczbBUpHM3GjHjBNPglpxCMmq5pbBM3SW0GofCpyIQ A0PIfjPNnrmuiPxiEsScWtA3+drez6z5aG7ZgBV6zVTMnrBykDSsp0Pv+okXhhEcqRtrFt1gyjJ vJDIXxEoKUO8AxRLIHqXPaVk9aJlYNnkiV8badOboH X-Received: by 2002:a05:6a00:2187:b0:829:f777:dad4 with SMTP id d2e1a72fcca58-82cd665a37emr432819b3a.29.1774894676677; Mon, 30 Mar 2026 11:17:56 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:17:56 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Date: Tue, 31 Mar 2026 00:17:09 +0600 Message-Id: <20260330181710.23258-4-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all show attributes. sysfs_emit() is the preferred way to return values in sysfs callbacks as it is safer and handles page boundary checks automatically. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f9a0a5a69..f2486cb29 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -128,9 +128,7 @@ static ssize_t ad7816_show_mode(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - if (chip->mode) - return sprintf(buf, "power-save\n"); - return sprintf(buf, "full\n"); + return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 static ssize_t ad7816_store_mode(struct device *dev, @@ -161,7 +159,7 @@ static ssize_t ad7816_show_available_modes(struct devic= e *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } =20 static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, @@ -174,7 +172,7 @@ static ssize_t ad7816_show_channel(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d\n", chip->channel_id); + return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 static ssize_t ad7816_store_channel(struct device *dev, @@ -236,9 +234,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=3D AD7816_TEMP_FLOAT_MASK; if (value < 0) data =3D BIT(AD7816_TEMP_FLOAT_OFFSET) - data; - return sprintf(buf, "%d.%.2d\n", value, data * 25); + return sysfs_emit(buf, "%d.%.2d\n", value, data * 25); } - return sprintf(buf, "%u\n", data); + return sysfs_emit(buf, "%u\n", data); } =20 static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); @@ -286,9 +284,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =3D AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] - AD7816_BOUND_VALUE_BASE); - return sprintf(buf, "%d\n", value); + return sysfs_emit(buf, "%d\n", value); } - return sprintf(buf, "%u\n", chip->oti_data[chip->channel_id]); + return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 static inline ssize_t ad7816_set_oti(struct device *dev, --=20 2.34.1