From nobody Wed Apr 1 09:45:47 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 235F23822BC for ; Mon, 30 Mar 2026 18:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894664; cv=none; b=k25IT4AFVs7g6LHiX/M9v/5L39k/ZQedr2Lt8+OhWDTWidpyp4wsC8XIU3UCQY4xI98cnSv6J0d62H5gkxPcyP3B0SKvJ5ETP1JlSaWOO4g4ZGoC2vbjuowbD+qFVIGupZ+hrAZ9BIyY/SGtLkW/kv2I8tVVAueYJE/O/GhcT44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894664; c=relaxed/simple; bh=v5TwC4wVPLBMn+PJai0mOiveMJJJtBoH0VbaQ85em6k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uQihYMGjh+B4JjiheUnXpgWEXrJ/PMpicrrFTyBtoeK0xSKauEr9zwetZzJKVKZNm6qIKh4Yo8WCqYe6HgpmYojrZlxv2WlQFL/eQStnb63Ey6462MCyFKNm3QBYMOTOm4GPHeJDPgqRo5SQ1D2fs511UxZ3bzlh9jXhELOsr68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LI+brK/2; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LI+brK/2" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-829b8b6c4d0so3834999b3a.0 for ; Mon, 30 Mar 2026 11:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894662; x=1775499462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gtow8N65d/BtaUdMdcH6YJ/Rpa4A5Q8aZEpXNaY0IMQ=; b=LI+brK/2ZriXePWg1wJgR9BgbK0Fp8YOt16iInAWYS1Wll5i6AEisuO37qHF5E2v0W jR0jDI01hJNbd5A6TTFAXZmhJLfLkgCh/Jccx7G9GKlnTLe6p1P8oRtUIgO6E0legCQL fR0iHMON9btuCEnu08aAwo4kLpcE64ng3cOfuurD3s9Db78dLAFIlTOPoQNfUXBv0xP6 MRaGqRgwAtdf/FPk2Q4VQDJeKHk+ZUxK6v2UJfFXGByNhVzeY+Vw/szWfbUHdzfu4v5T Tntbp96Ljip0178ggBJwRR3qR06nJkhhBUO+FSvUCU/MGEoh6MHmJEiESynr6lWg6tLT BVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894662; x=1775499462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gtow8N65d/BtaUdMdcH6YJ/Rpa4A5Q8aZEpXNaY0IMQ=; b=naGkW4MPcUdfbA7r85GkRGjD1VtXuBFrBZ6Mh3zdAAz9S4c3ytecr5+2ao2Ac5MwIb pa/b/2MV0PoB8x3df7t76hFFGK8U90Qa9MgDRS75VBErHz8l5XFnNDmujiHL/os+9o2P Xlv2Kwz0tF1mk2gz4Apfnv2enfRjf4mPrmjQ23qw4xq4vb3szhZYGkb4yx24g3CWf4Vi F9FRG4D1o7wtK4gKh0gip/kbuE75K2Tf4nyUCeHcNsv7aJL4WbjG3UsD4g5vvfn5aaPy yYrm+sy5hfrediUJNpkixw7Q+UlIkP2c3on58sV51G1K9M3qRnMPV1/I/sNOuLGDSb69 VGdQ== X-Forwarded-Encrypted: i=1; AJvYcCWsZv9Nz+rZTMUWxt/94eQgYpy8VsUsAb58g6IrzceN03UgKh1ekvEaHQAvpBczqF9onoD6azwPOUjEBrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo5eP3jYZsYrUhta2CmLAIFhfuPDk7brr8keuyarsUQCU/5ONa LLnaiL9+oxiEx73AqQspu45gfSm2KUSDBPw7LAfcuNHBOj5T4Gw9tOvO8fT+ScG3kDA= X-Gm-Gg: ATEYQzwzpNBUUn+PTbWeD1W+lu8RsTBmdT4ZJdhk6fvnALmZb0BKElfVdc/P/v0i06R JiMgadD/3UfVlt/ABEZ768XdeBpSKc775xaCIhpfsDjoFhQjxrvYbOZ5Fd7WI8pxaazdfB39H4o NNXvHYNM8QZOvL+1tKhzTWw1iUqvulrBWsLAebeqh7kcF2QVYgTEHGMTuMCzSfAeEhSvAqeR1lY SPshQdtf0s2JsCEDroLaUb2CljCO9oMv3OkCylySvldfdiQIU/aafeZ2Mr30crkEMqvciSz/ZBh 52OjUgoTkH85++fqYSHEMDIwqqiBhNFD5jSOObfId/49xyXRdtYW7HBsuJLwLkkc0uZeDSWpql9 iqdG2GUfsOoxx+aQptx8tUdA4Z4HWNvGFqXrkCzU7iINLDMDHh9NzM8SDBjPCdw1gMigNMKAKds 2V8qRbrSag7RdA0FxG7+tWLL+jWFzoO5QQ5fcwRM8R X-Received: by 2002:a05:6a00:1488:b0:82a:805a:7e2 with SMTP id d2e1a72fcca58-82c959d534cmr12982518b3a.9.1774894662502; Mon, 30 Mar 2026 11:17:42 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:17:42 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 1/4] staging: iio: adc: ad7816: redefine mode constants to start from 0 Date: Tue, 31 Mar 2026 00:17:07 +0600 Message-Id: <20260330181710.23258-2-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Redefine AD7816_FULL and AD7816_PD constants to start from 0 instead of 1. This change is necessary to use these constants as direct indices for the mode string array and to align with standard indexing in modern sysfs helpers. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 172acf135..5acfceb90 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -22,8 +22,8 @@ /* * AD7816 config masks */ -#define AD7816_FULL 0x1 -#define AD7816_PD 0x2 +#define AD7816_FULL 0 +#define AD7816_PD 1 #define AD7816_CS_MASK 0x7 #define AD7816_CS_MAX 0x4 =20 --=20 2.34.1 From nobody Wed Apr 1 09:45:47 2026 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089AE377038 for ; Mon, 30 Mar 2026 18:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894671; cv=none; b=Jh5rH5KCKJk2XB6F+frzObRnYT55H/xZli0IVKQT/KjGfDyEXjMkYHvcf1gqPHZhhSmX3C3XwjgQ6fCqefqm/TqSwNWjZnk8Ck4JebH/hva7kFLdAsZze3Ek2GrsZtwDQxM7krYlWQKkeRxzjCXvqjGqmLIxrLKO9CWMI7UdItU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894671; c=relaxed/simple; bh=Mc846RV35bT6iP3fArUd1CRV+Tf3YyEFa0/aDDYCJ1c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NLo+lak7O2vgcuaaO2QkPZ7An51H1B3Mamkf/lKqPA3gLZ4C2t62PNZ0zdU2h+H4L1EL5loR8AwdgReGqSzJJu1whf+KpYONqZUAvxCN4WyQBXJTITFmKv9N3YNpVnqW/TVTIRx2UKKc1EkOlrfN5BG2hpBrYUDwlDcDQ2kpHno= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eQ0QolDP; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eQ0QolDP" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-82a07738118so2698914b3a.0 for ; Mon, 30 Mar 2026 11:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894669; x=1775499469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PpGXMoX9YPHZwP7oVnaLSkpSaXw3E3SWpCp8C56AwzE=; b=eQ0QolDPbbvCYFig/gBnzeM5G37ecNxycy2CraA/uE1cDKgivnn7XqJ3NNt5WiUYn+ 8q7iEMJ/XwmWES3udgT3eqgYw1jZ318qGoxT8axSRUQOc+c7ybnKEyn/LS9ICst8idnO yF+pS8y7j+xtkFCMK0Mkd3w0fpH9R4TEqxhXp+Rdi5ZJ9/yr5vjozDbOUyu4Q1H7N285 jSuFV/4iK0KwMpPCB1zoG3/XHaWhSRIZVSX/r7yLfF2leGcfNJztmdFzTbDI1vcxeR+q rCeNbiu/acqeeZishxYgm/khB7D3RZ/frpzPX8OnFoYvjs7iE0Ta+mXPkQBwFvKUqz/e otUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894669; x=1775499469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PpGXMoX9YPHZwP7oVnaLSkpSaXw3E3SWpCp8C56AwzE=; b=Snoo5RmEfg10frxSWGRHiy7wLNg8G5XBq9DLG015pyGo+Lcpf4wRwQLzDmM1iLOLmm WT/BvWErqCqt5Dy3I5fGBJiC40VNwNnJYq6R3uNrn4iJ9ZeAlHyVGwtxJ2qKeQbIZVkp GBJAWTJnCZuEeRFyfZ9+gfGduKOQgWN+ix9Uyqkk9FjzJs3eSApUQWApDBIW/jnudU9C 8/MB3ahWmTmHlPpdmU9QKJ0PIZN7FlfScZ087rB349CutweXRsG/nvjM04qmSyYRBAXD L1oZXqYj4Fi14mQ2mFQxAAq3o7ilr1w5h+jS4S0Ivekkv1d6dzUDT5gdzzZxdLB3qsIn gwKQ== X-Forwarded-Encrypted: i=1; AJvYcCWGuY9FpEfMTyCUXnSIeiE7ZLwDJknr9Winh5GxDsrgw/W8khqTrSlsW0bqyX54V9STn9HW8UM9SUPLSPk=@vger.kernel.org X-Gm-Message-State: AOJu0YwcOe05hk1XHelPGjmne77wK85X7+LYzjyKfHkcOIV1nJD4QcP5 SgdISE+WO7HdxqNuVClu6C9l3UmzDXNjQY4tKHfndVY3gQ9PoalXYI0/ X-Gm-Gg: ATEYQzw6Zb3cJYn40Rbjt2y/DkLCYo8HUM7yilLi0bz9YqlRDkuVEhSuPNnIvS/k0ZO 89NcJV4c88gThEQx5quGqwP/JrTot3jDWAddsSQRyRmB008tEFQRxUHKN6XIVWwj38YERXqMA0q Q0CspTeeEeZ/f2Ytzvbe4ga/BQaVT7Xrud0B8YkvasvvAzZcSf8d9PHec6amKlohaW1/sNMQLcU V2YueFF1fzyjB8o6rNNW+jwo5TzhES5slOWXuEGJw+4RgXRIG6Vp7TMGYG0pWGgIYR++NT4gv88 HyZKiYxW2h4IQQMW8DPPUOw66fJz1bUvaEoGVuV775oSxs8vzTsKwYmjOAtRX+Q5c765S4sHjYw CrkLhBHQE8l1aw0Y1TU9cg1S0z+sOHqtBCIkyRjAYA9p84ybCahcGEH3teLONTCqEr6eLWaBQvT G0xpMFiVo8B4r/IZTuSh5aDm33gbYioTmNLSv1fKQwWsvhmFfycTo= X-Received: by 2002:a05:6a00:94d2:b0:829:7a62:5f with SMTP id d2e1a72fcca58-82c95e5ab81mr12051966b3a.9.1774894669426; Mon, 30 Mar 2026 11:17:49 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:17:49 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection Date: Tue, 31 Mar 2026 00:17:08 +0600 Message-Id: <20260330181710.23258-3-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual strcmp() logic with sysfs_match_string() to simplify the mode selection process. This reduces boilerplate code and leverages standard kernel helper functions for string matching. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 5acfceb90..f9a0a5a69 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -58,6 +58,11 @@ enum ad7816_type { ID_AD7818, }; =20 +static const char * const ad7816_modes[] =3D { + [AD7816_FULL] =3D "full", + [AD7816_PD] =3D "power-save", +}; + /* * ad7816 data access by SPI */ @@ -135,14 +140,14 @@ static ssize_t ad7816_store_mode(struct device *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); + int ret; =20 - if (strcmp(buf, "full") =3D=3D 0) { - gpiod_set_value(chip->rdwr_pin, 1); - chip->mode =3D AD7816_FULL; - } else { - gpiod_set_value(chip->rdwr_pin, 0); - chip->mode =3D AD7816_PD; - } + ret =3D sysfs_match_string(ad7816_modes, buf); + if (ret < 0) + return ret; + + chip->mode =3D ret; + gpiod_set_value(chip->rdwr_pin, ret =3D=3D AD7816_FULL); =20 return len; } --=20 2.34.1 From nobody Wed Apr 1 09:45:47 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739B8362151 for ; Mon, 30 Mar 2026 18:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894679; cv=none; b=mNxBrVp4o0rqbS64uFKk4nWsNb8GacpZHZXSfwMCF9jjMTISDalxKofz2OlvsGT4Ku9IW41ODCJRzmIxGiXgoREwTN9A0k5V8A1Lw46Q70BMKhbWQXNqj0mgbbZ7IV0KCfe/4TeGRS7ADmbooUzWqi4Ryi4WbRZHNQanCwAC9Ow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894679; c=relaxed/simple; bh=Br5vGAXYgtBTtZqV3PmJuhT96uRJmxgj8Z+FdJj7Yxs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UAUq46f9GYRk8Bvg7QYAS0m08YEENxEv55v/cMPVnpttNsDWqEQ83SonIf5zkD3fB0K0zxldiUEryot+Tgi1zspMy9vqZbPzNVXPeAIVS6Gt/H1oCWL5xA3qzB48X3FXFMiYGbYSmaNXWsGngUDsy9jqfqZfV2iJJ5qgXT67/IQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UXyVgLdv; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXyVgLdv" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-82a62714fe6so1917527b3a.0 for ; Mon, 30 Mar 2026 11:17:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894677; x=1775499477; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AEev0NrgAro5b++Ke8wuTx9Yh3OdT4GarY6/WNk8AFQ=; b=UXyVgLdvJcpR39RSvtP96JNd83RUi6khDbasqa71wEFNAC2nfFuC0QFvkZ6AslVj5t PQAdng7mIk87UZNw2K77kIB+y4MwF5yibO4LBaXjTkHUmNx7cy+1Tiqk451lgRAshLqU pT5tDcA+eqoUdPo1wahPsXYPw+xv14tT4U2KDkJm8CE6ByeuiRNfUPNIl2wECYoN7RLX z8C9KN2eHp+VAReeart51e3T8iqeqhEnCyZYP/Fd4EM1kVGTzrILNvI+vjujBYsYsymG zgGSlHqVxgxIm5dZ9IJ5FkmVtSTy9Io442oGSvh3DdTR/6LxTGRxJXJghsX6DLHkoZ5k NNMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894677; x=1775499477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AEev0NrgAro5b++Ke8wuTx9Yh3OdT4GarY6/WNk8AFQ=; b=YfHz9zcXesGr9NfCn4LMbdbaF/v/RoJgXEzbWt5/GTqbXVIhwENa0TszWa5a1J2FuR Wsc6SBILLJhux+k8v1Gu7EBxJo17vh7o6K8SNABDHab7WUTher8Rdyj4fa89kCDoDwj2 1tJr+0WjbV+E2SEdILkNdRkQvpWPRtHICXaKKICktM4qVDo6/+MihmGSHFg2efXuWRLV MiTmYrwwUyHuem1MeBmokpwf1Wzq+2BPDrMV4JWeBb5aTgH3uk9nLMZJSwj6LGKHheag lFr4n0rUWMURAw9pBGC2jHSq5n5FLHHePHBZcZ9XdQk+rf1chWFGRtjgs/XQQjw/8lXG hmbw== X-Forwarded-Encrypted: i=1; AJvYcCWp7AtfxzngtvATsXlMcbAc6UHCrFUR2HuU+1f1q/qwM06pjB79RZxpZN0V4JCTYYMWm+Z7GoE7L9/XrvM=@vger.kernel.org X-Gm-Message-State: AOJu0YwvBne0ZoDT59xHfu1rP3dAvkPC9Me/u1cHVBaDz+wc8CuTALRU 6OMgvVRre2yQskBateWzSefvhisIin2ahez2y4olVp9k3wLfZBoIwruA X-Gm-Gg: ATEYQzz2rW7oEnKLs4+KRakfaQ6KLCb/lLEark8wz1BVJxDHU0pTy2YgwT6BXPjGy/g eKNPx0QCgKt51CRTDA0otrUX5cC9Mb/8uM/9Bmvc3T7QocCGTGSECq3IrXZs5M9UAPNbu99dB9y g4tT2mIkPqj6qinmccMoVDmDdQ/xSlrcTHG994WyVFc0jA52uXUzJKFdJ6ILYGvsexFdJcASq37 iqsdi30lRbXuxMnG9ispXiyzu+Ld4dwxKN7Xeur0BZmoFBkTiYHCq5GXCO9BtXRGRLIR0sUE3IP Nj0ZK91/uxdapCSNC2s1vnu5wQgyy36M+sczbBUpHM3GjHjBNPglpxCMmq5pbBM3SW0GofCpyIQ A0PIfjPNnrmuiPxiEsScWtA3+drez6z5aG7ZgBV6zVTMnrBykDSsp0Pv+okXhhEcqRtrFt1gyjJ vJDIXxEoKUO8AxRLIHqXPaVk9aJlYNnkiV8badOboH X-Received: by 2002:a05:6a00:2187:b0:829:f777:dad4 with SMTP id d2e1a72fcca58-82cd665a37emr432819b3a.29.1774894676677; Mon, 30 Mar 2026 11:17:56 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:17:56 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Date: Tue, 31 Mar 2026 00:17:09 +0600 Message-Id: <20260330181710.23258-4-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() with sysfs_emit() in all show attributes. sysfs_emit() is the preferred way to return values in sysfs callbacks as it is safer and handles page boundary checks automatically. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f9a0a5a69..f2486cb29 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -128,9 +128,7 @@ static ssize_t ad7816_show_mode(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - if (chip->mode) - return sprintf(buf, "power-save\n"); - return sprintf(buf, "full\n"); + return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 static ssize_t ad7816_store_mode(struct device *dev, @@ -161,7 +159,7 @@ static ssize_t ad7816_show_available_modes(struct devic= e *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } =20 static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, @@ -174,7 +172,7 @@ static ssize_t ad7816_show_channel(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d\n", chip->channel_id); + return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 static ssize_t ad7816_store_channel(struct device *dev, @@ -236,9 +234,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=3D AD7816_TEMP_FLOAT_MASK; if (value < 0) data =3D BIT(AD7816_TEMP_FLOAT_OFFSET) - data; - return sprintf(buf, "%d.%.2d\n", value, data * 25); + return sysfs_emit(buf, "%d.%.2d\n", value, data * 25); } - return sprintf(buf, "%u\n", data); + return sysfs_emit(buf, "%u\n", data); } =20 static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); @@ -286,9 +284,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =3D AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] - AD7816_BOUND_VALUE_BASE); - return sprintf(buf, "%d\n", value); + return sysfs_emit(buf, "%d\n", value); } - return sprintf(buf, "%u\n", chip->oti_data[chip->channel_id]); + return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 static inline ssize_t ad7816_set_oti(struct device *dev, --=20 2.34.1 From nobody Wed Apr 1 09:45:47 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2456383C69 for ; Mon, 30 Mar 2026 18:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894686; cv=none; b=KWJrNiODCxXapZ7r0fmmaDE0E+uThLJRDBtE0B8DmqNmb13ui2bxJjyQpGiGWgU+iwBdgHMpfUU9ri7Qo2CeDcqMlWY7Fnl9BeiepXJSwnUG5jkoiYY446/zeJB/iomsCp1wnnhcj0eYJblGViyIyQ6zp6o26tzR4nij/Q28KH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774894686; c=relaxed/simple; bh=jWDPKmEInibgEwWSaBhCJV+GEWo9o58hMOVkOchtk38=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A/Xqo+dWJ8ZtpFy5Q4HDWj4Ybu9IeEZ6icK5focBI1BJ8Cp9RZGXbfbwn4lcCxx1NJnonB4zoGhaWE7/tZrvclus1xoZFFLxHOUnYAoUrWBUL1nWt8uHXwOJQp7FKoBU7NqkKPByvuLYiawNlqqLs/BZiIBWL/rGdrwxWD0FFGc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pnrTNlzv; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pnrTNlzv" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-8296dabef74so4573690b3a.1 for ; Mon, 30 Mar 2026 11:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774894684; x=1775499484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=egWOjCKA5Tr5GMAmRAwMz9x5gxn0udJ7TK4JECSEdQE=; b=pnrTNlzvbF7YBpcMN6z38g2lvQRKzPq00RW3RUlHqdn0utoFewQLjdDvHZhoLJNhWq 28L/BtsCCXxlgRt5pG//IRrl25KAeyLbh6j4qx/XgU+tIuexxCxC92gmxrjTPu50rpcj HXHKcD7Ac/TMWoPPDONUwU76WET6PSn/84Xg9bEZ3jHLlBZEvBv/Hzbd3h3wLpE+5XZX 6nZggPU/9XMjXuJ3EgRaF+TSXTrDDYtBcdYjFgzc2w6igTcX8KNPvb7bPlWD2ORFpmYB g8cvH6pUFNcgdQkW/dmedmSALQzd42bMT7g1iM4CascZt5yRuJ+x2A8gs5ua5ilLC5Yv OR5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774894684; x=1775499484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=egWOjCKA5Tr5GMAmRAwMz9x5gxn0udJ7TK4JECSEdQE=; b=GnOUu572CjUfW2oTVFcpj+QBpJ1lwyLrPEn046MnxYheypfpAIlTdzp97hTZU3Fguh oddt6ZMYqKydtXi1TwQpktAKBGWJUczr3JYe200DCFru8MAYyBSU/eVILGZVloHtYVDk eAc4ez1lAFPCwOWmZ3h+xqA7L2R93h1C6woopd0oXJTkeyf+HeBV4/ikJ0SJtwmIfYtI RtyHdZJiMTAizNNCqQDjsQUmHuPT1PW0fVTEWKV5d0iLQz5KTqlyM3fDUHT8v4tNdLaz ailTMKnYoPycw9nA0zLxo121h5cbCmp15RJbqqYr6oIIbcfdMO3SZ7XVoqXzjUtC82tw mpuQ== X-Forwarded-Encrypted: i=1; AJvYcCVlfLuspfQlVjhZS97FUgq3jB0JKF7F6cKRT0xesJn1dTeuOn1zabijuw0NLPhMAC3d99hlP51fkud23Sg=@vger.kernel.org X-Gm-Message-State: AOJu0YxecU93W0avg+ZXey4QFzgMgPsKyamFMv/mE8QDBzN6GAv8tI0I LRdCXHedTywbU5SDjatyqLzKifw7Pa0LnwnfZrfOCICl5nhdf3oP7uXS X-Gm-Gg: ATEYQzzC6TcxJbRoKUUVRGgpQl7Ooj3jk0nnoT008GFJyWRiDVjjDNjXliRLjQayFE5 msukN2PGyoS9uhUFcV6L3Q7rR6nX561E5O/wV0bx3ellyUJN+zoltSA5BZEnd7YNpDKVLyI1e29 u7p/jVbM6l3LiMW2men0c5+sp5XmtvVv12I3zagTciDiosyeIj/BF09rS0z3R5/bz5EKSEDUB1w vPgJSRbwMiudrG4ke5FuYmni9aZs3ov1nIoLjdJvjGlWfiW3ClKbM945td3V5VMPiurVt0+4E33 SOw/MzJEM5ZqX9F27kXiq+XK0GAD0FwgLVyA1Y5FiAvf65d53eNYEFO+4C8cnLGSQOoX9SyQNvW sNizYTcDcQ+htM8tc9nTO9lSIBMcyVkMiiSHrhrTcOCoQDamrrYrAYIQXLaiTNqs9Z14F2+TM9y 3I3DdJTVz9JiJBTTSYPUJ9EMdeAq9Qu9HD6iqyLCM/ X-Received: by 2002:a05:6a00:2e1c:b0:82a:768c:9a49 with SMTP id d2e1a72fcca58-82c95ef6a78mr14209644b3a.42.1774894684234; Mon, 30 Mar 2026 11:18:04 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d4d90sm10099966b3a.36.2026.03.30.11.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 11:18:03 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v3 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Tue, 31 Mar 2026 00:17:10 +0600 Message-Id: <20260330181710.23258-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> References: <20260330181710.23258-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Modernize the driver by using IIO_DEVICE_ATTR_RW and IIO_DEVICE_ATTR_RO macros. This involves renaming the callback functions to standard _show and _store formats, making the code cleaner and more maintainable. Signed-off-by: Md. Mahmudul Hasan Mabud --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f2486cb29..80f84e2bb 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -121,9 +121,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -131,10 +131,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -150,24 +150,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -175,10 +171,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -208,14 +204,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -239,7 +232,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -269,9 +262,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -289,10 +282,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -330,8 +323,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1