From nobody Wed Apr 1 11:16:22 2026 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3C23DDDD0 for ; Mon, 30 Mar 2026 17:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892486; cv=none; b=IGKtEuhR/XInmbIeTtm5M5+pBNHxWNA6o0GUjlhPPs5xghpTIQHoNicAw0FwJLsIKLjP8+hdteKHoBsGvYOX8nqTTeT88nAGcjWjZkey5kMpQXCmpMEzugmXfGk5ltp/D8RMG3UJy9LTOHdFvJojoxGNm1ddSr3/C/8qJ4gNWMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892486; c=relaxed/simple; bh=tSquc7sa2Cn6LfGxEXgHs/QIbImA+arPbrIn1dVGGHs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iL2rIa4oxVS/qda69JBj4jCg7JjHQnXkGjw+ziLTSMobeUcXquh0T92183Kp6NhLfdWB7qvcXt6hTSYSZBhujUkig2mFzW5L98zM1P7OpRmwWqH7YlmE0O6UWw+zIGDCQOMYbaYQ3ovvjdl6qNPmTDnIBS0A0+yFZT5ZmSJJms8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iaiYEQmO; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iaiYEQmO" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-829afe24fb5so3342801b3a.0 for ; Mon, 30 Mar 2026 10:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774892485; x=1775497285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7fqwDF4ChSEr48olaKrcyFKqRQaBIIIXtDoKMJ7juOk=; b=iaiYEQmOzz72GdQQiXodXXq+s5o6xiJB6g3lWEX5lrNTu2zsxjVHHIkL/JBvnnZ/fl G76tSpztaGzXjixTlXJbAbKVwtNXUm+9KXkyv/2I+bSFZgAtJszvh1bQjQ4VUKJqICyA BlS6l2p6klgZPbVn0v9brt82N0tF7H+MmcjR8bKkm4wayFl3UJWnhoxlNAxtXUGfppoh 4h0yaTaKL5bXJziReTHMRD0Zs2gbL7x4pIbiKvAa4LnnJpzd7OwIxECq6IoQSXEeUciU dlMgouMu8vw9VoeD6jjdJ0yPJYz9siu0FYrdogE/swWyYy1AIcW1c7HdIBRN3HaQ0jsj TGCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774892485; x=1775497285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7fqwDF4ChSEr48olaKrcyFKqRQaBIIIXtDoKMJ7juOk=; b=qOAt61BVsmX0AbA2yNHqCLf4SaD1+FCYRvD/Nf82uuoedLSpgn8r5CXuU0yBqaiAsp 5N3Oy99xMmK+qGVibwPlJWiIgcN9urJFD8ypMLPc/Wmtd5QhEXVT1NBktuO/zDH+SRr6 Z1Zio/vEs/rDX8oY5ieVVrfavtw3ODExmHSm1RdehXr7xBW4thJH3nfseZ48diY1dxe4 UR2mRYEkRSuDCfKtnVUHr75um2SH8FckOWnL59VO/1oVIluSEQqQ6r/Ya+578G4rQI7/ v0r/blzyUcK2sX0sjaFQ7oPfMum7RA4NkQgEg4sakm7qwQ70n0QNpHsEn0wH9poXnWVF g3vg== X-Forwarded-Encrypted: i=1; AJvYcCVM2UlxnCAlu1gHfBtoXrDFCodNZWGwR66YViLiowm8aYeGxYtxo/DsZfbPeUQ4VjmyqyPyOjbM5cr/ilQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4iObVA30Pk/h3xHKFL9VI3wmUI5cIM1N18PYeo659tOrvCW7G gRlM8nZlC6nVkCm9H4VTucWLe6jvm5zaLocsylOXakbfdk8QvKhk8W8CFBupXAoTtWg= X-Gm-Gg: ATEYQzxTyvE0g3vz7w2z5yn2REw91si8DtjTSicC9XIX7YTTDoeUJ4hiA6XO946bx1o D4kMb8XOz3ORtbm2Hi46OthWPWTl3mtg+pyJInMSIVdjTM0Z4etvbY/0OYWNGPSsog29HMtrHI1 s9FsxBOPP5+qSS9eOoBNBCsCoMsWuJbC4AAyzpizc817CjQeNToCWztZHAcsnG2+TuZ/hjF7j6J nSGjefpnSLriIeTmBP75BQ3dPBr6KMIvfv1lrmgLBSVJbo0NlciJN1H8rZRlTavtpzj3z9KBlWl sMWjWYr9WQX3VlRDSVxN0t5l4H5XGsvVZOYn7p+dY5yLETR2t/EkwqaVVcfLKrHNnfPPF5t7GrX YzJARciLtFe7qGDjSyaXAs+YNKVavYcmxo1sj2LPbgH8r8HhjOFJjIPCIWxdY6ulJ8Z8q38PHRp Tfld59Y0o0o9L/Tq5Y9TDw3ARIPGVbPonXgcK/CcAG X-Received: by 2002:a05:6a00:4299:b0:82a:7aa3:a2f3 with SMTP id d2e1a72fcca58-82c95ee4bedmr11931671b3a.33.1774892484669; Mon, 30 Mar 2026 10:41:24 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca860b125sm7844052b3a.50.2026.03.30.10.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 10:41:24 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v2 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Mon, 30 Mar 2026 23:40:24 +0600 Message-Id: <20260330174024.20712-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> References: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f2486cb29..80f84e2bb 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -121,9 +121,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -131,10 +131,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -150,24 +150,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -175,10 +171,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -208,14 +204,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -239,7 +232,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -269,9 +262,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -289,10 +282,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -330,8 +323,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1