From nobody Wed Apr 1 09:45:13 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C942135E958 for ; Mon, 30 Mar 2026 17:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892465; cv=none; b=JBqYa34WRqGFuYYDcGtS5ucH5/bVdK1ypvtsySLxT+xIA/YF2cYDOXIq8CCkmLJqpg/WqyQYQ5SuQDJMIhol/e6dGJgI3Z2zXoyY3hGQQ65TRC0/Y2wWwFMCYM0fzezD2hrYY0NM00XBh8nj8DRu+Zr/mDwT0s9IHvNHjsbWsSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892465; c=relaxed/simple; bh=88ZM+t1K/1lR4CXqOTdLV+/TyBjxHD/qP13b/YAWW+k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JFaEck9CEQC504ZW8qHB+DGncI4nc9gfIZBgD3a5Gu3RbN67/5d/KYwF3f96Pc+pdtKIHcln44f9cS3fQXHIl4KD6iBIJ3XMfKEIvLUm48CNkndo7P9VGnoig1NkCbJvGyhwSKjEKJPI3nefuKF+5Ind3/XSrS/WHIoJw3jRnqQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TxR1+cKr; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TxR1+cKr" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-829781b2b01so2439129b3a.2 for ; Mon, 30 Mar 2026 10:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774892462; x=1775497262; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YVy602CnFkEAsjnffDl6n+Q2QuDxV7ckhIIG5PyOqtw=; b=TxR1+cKr+6VB7QTEqLbkMRvM9aNcuRbcRen6q2ctgT+Hukrjpbk3g36APXdkw01MJK YPMe5gYqn66dnCUjH3XCDWj8oQoSo4JB/4sJB3fpyVGHSUF6+RzdETnkS2uxdf8w0SG9 0G0L1mJOzmCbD80rA/85yzItzYWeLOaFajKJm5ZqLDfIqmw1Ny8lsqNP96rToKpCeqCd M0QVHI8zEzSPXhsF9PXLD7wTDvEU7r7vnnbTUCA4RATMNmS+Zuan+EThxrhTMV6p0Yfy sBFPDUHXyKvxasnZftNo2/RmxbNUjiNnBjJY6gEbD0k/wOxmEGUXjKGAK1HyARNoDYKB Iu2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774892462; x=1775497262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YVy602CnFkEAsjnffDl6n+Q2QuDxV7ckhIIG5PyOqtw=; b=AKirRmdkwjA0LmFaCDky1Xqrhe6NVGAOkyeF/zFLAKWTp33srHmIOZ31EEnJ8BRXN0 xG0Aa8Q9U3txQEBYS9dIGt9Jh9+vOUlB+N9xDOWatPpJfwi+MX07pqjiBrKe81YY6JiD BDxKZa8/89pnFPBcX4uJdq/jYWYVsTssEcQ5wjSiuFsguiJX++PcVG/WUJlJCA/FnFqp Fq+ANX6pQWO0HCMTfPO/FiKtLrU8rSrvVuYCEtvSKgGJycvkPlv1v5Zj8Sq3TDpTkz5S DyvrjnJa6nMSuZCy5jqqssnaxcFMEKytAVGgy4I1AEwfBLxP9PdLPjgzgeroXWFMF3Fk 9y2w== X-Forwarded-Encrypted: i=1; AJvYcCVXSsPuoR99HDnW6L9rAPC/gYcGtecMxjI2pDMxCwE8FSlQ4r3/wY8DdYcpk9QRgq84dEkyLy5ux1COVmw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywrlsf6wlc6hgX3xoWw5KVKmvDaBnTTmDcyysXA66Q5ejmU34rs 4QB9uu1Ba7umsybyMnIfJlp2ctwZ+oaVV8cfNDbzwl74AIpQ+640do/q X-Gm-Gg: ATEYQzxOBK3GpEP1UGlqRcqwoh3NL7OWD83dxYy+ogzwLU7NPoM87CUs1/xNiC5oPWJ iCiRY5ecla+SkKr74rU68aeeTkZuOW4qZVIMRbTGy6A7GU22kLYI70efNzE5AIz2qgcwSDxKowV GorKSPLHOD+T3V3wiFKNKwF64aQgbHKknvXOjPF/Q8GcSaGRMh6/AzXOyD8KsFMZAnWBmMCNX8s 2pIfk98g1Nj+W/fY0gsOuyiriNHY1Qd5zX8MFvl9JmXC65D9JITkbC50MLk7ogv4NJBHmSLy7zR FOYn4FfQW2roH/euo4yDKtRA+y578iKTPXIV0nqwEQI3rdtFiHlWp6JBWwoso4h/ASdsvQy5xkh xXzrTM4q3vXcVs5g3VK0q2CFs0mQCOofwFv1yDUed8xYqYYTj9Io4aeRE3YLi3kn/uecqeIe5qK JO4OrevxXPLz31zaPCo4rCWmdDNNd5rXFwscCbsxXd X-Received: by 2002:a05:6a00:408c:b0:824:3bd9:aac6 with SMTP id d2e1a72fcca58-82c95c234e9mr12931073b3a.16.1774892462084; Mon, 30 Mar 2026 10:41:02 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca860b125sm7844052b3a.50.2026.03.30.10.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 10:41:01 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v2 1/4] staging: iio: adc: ad7816: redefine mode constants to start from 0 Date: Mon, 30 Mar 2026 23:40:21 +0600 Message-Id: <20260330174024.20712-2-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> References: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- drivers/staging/iio/adc/ad7816.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 172acf135..5acfceb90 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -22,8 +22,8 @@ /* * AD7816 config masks */ -#define AD7816_FULL 0x1 -#define AD7816_PD 0x2 +#define AD7816_FULL 0 +#define AD7816_PD 1 #define AD7816_CS_MASK 0x7 #define AD7816_CS_MAX 0x4 =20 --=20 2.34.1 From nobody Wed Apr 1 09:45:13 2026 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307763DE441 for ; Mon, 30 Mar 2026 17:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892471; cv=none; b=fT6XrVT6P595cRL0luZT9Uw6O4T1tmjjUViSbcdhKu24JANQon3bSksn1so12jRmIWfecnIni61rV3hIbwM6Ws+9nd8BZrqLg3SBPsXmrwqymV8u0Zy7OVN6YT9LoZDgcbr4p+3SrJSYLSYu1AGvNVe8G2kBTwL8uyVUoPyUMZc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892471; c=relaxed/simple; bh=od+CttlPpI9/Mh/jJSm8FrUoGXVeBS2nvt98p6hrArk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cwdWMgbiu9XXgCRXzSd1FZ4iekKBxgfmS6BvqJezCdIUAbrDnm3zGVR6G0TcU7KSh56gMqkpsifjesSS0+RaoRMYNpRHW1tj/A2bBO12wOuSc7IUSDb5n9pOQZq4ow0FJ/q49G3++lk2jWxkz7JrbSBZ3XLSwFlGdeqkzzDBfho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N5NEYeuE; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N5NEYeuE" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c7393536e53so1862498a12.2 for ; Mon, 30 Mar 2026 10:41:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774892470; x=1775497270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Br6i/M290AXSW7sbMlbOqqhuMEb0TR9+xezMJ45NLio=; b=N5NEYeuETItsUMPQHIOgz6mwJmngXg8Z9OwYU8TWlWm1MsFsAO3Oxn+tBavG+JFzNn f4+VnpI/TRjFghZfruvPYkqkY4w44TKy8WFrP5fE2aBbNtHXw+X1XTpLKXg7Ee07J843 H71gnaxniBMjXk+C15lohp7DPmXAh928062bAYywq6LYahPCo1IfidfSBKNKzofTrdbx Ixi0jp1eHOKFxQTgBFeL6v8qGIhUT/PW0KYxLd/JPJgb2aLHr+LL2ixYGXUVPDtyYXHn hnVXlRv2E20L8a7+6UfqA03LYJdo8PdkNevl0zNgJqL4rFAjQHlDna3x/Hd5OUl22EoI xldA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774892470; x=1775497270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Br6i/M290AXSW7sbMlbOqqhuMEb0TR9+xezMJ45NLio=; b=nuZQw5H25hid1sIr2j8ChZLA3QCMtV7MUzLQBDY3QxcMF2GyCJI9x+kyEFRaebOKgG kvhefUdSInXNp05+TMkZcHOC9ters8x5MMgSZ9iB6NRwl7nZ1K03CxboMcut4axb39fe qvylIiYSknkEuysIVm8IN3PCHcdsu5gJLKtf0iibUiUnm4W1IKxzFEecc/LcjNd1u31S f3HCNhWnerrOQwb9oCptyn7zHrP0V2VSYW2GCy0g1QmQraf8Tal+4EknKVeBJX/+UmIs 79YY7zpXkVhHUMLDLGl5QIUVXwZO9lW9dWRUPgGtXPxePr3EYd0/B/tQ6aL80bQdLckQ OA8A== X-Forwarded-Encrypted: i=1; AJvYcCWn9dy9gomeW+L+EhgzBhV8SdumXFhvYLzf+X1BwWZpikBPzJEy6O1KCs/oGffXNV88cbz+VfaUpGxOpHQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6b9B+pqxNvNEBPE7KAOi/WrAdOkTDQH8iQxnCD/41OAmbVflo GVHVBx7+HwOsEs+i66Woi2z/ZSeovuKpx3fSWh9myIi+7wFpvgab6Jrp8nOTcYriZCg= X-Gm-Gg: ATEYQzwgp0MC3cMsaqzkgOXKtB/UDdFODYxVYsHwixjqua+DfcLYAwxe+zyVnRsgoMA 8AfvWZz+7ikgNQTdJGYCZxRuUA9vOC7q79TI7zJrpb2godZjYEsAmRsMZVyGY1y1vF8oFv5Xah7 mpDJnNW51ZU5e0/I58JjfMB+NhHY4LRkVZZrxxnUbXmcV2GeANxljC3MW3S2e1ZYrW91nBLIyxM TyRYJIwZkxIdl8ohA8X1S+9IxXR+hIUhYaoQkvgAKVnS77yB1Dg7UZXD0ss5kgcOh8G9iUsT1x2 xgw+FyXNHi7BHZfJSYRrEwxiUIQELbi+/S0A2Mh7Act3DR3zgwa2KE7GHGEXfpqjgTNcPqJ9HyX n41tUw6WUfah6Jh7hgo5KH0R4pXpOz6RslVISMRsCipKjPiM3mE6ys3OaozO7+hPGLlz4uHvZo9 0HUXh8yZsKncyIGng+6tJBfVGXXzcsa9I83qt5nuVKAfXyTI+70T8= X-Received: by 2002:a05:6a21:9987:b0:39c:113:14a4 with SMTP id adf61e73a8af0-39c87ae49e2mr13191508637.50.1774892469601; Mon, 30 Mar 2026 10:41:09 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca860b125sm7844052b3a.50.2026.03.30.10.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 10:41:09 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v2 2/4] staging: iio: adc: ad7816: use sysfs_match_string() for mode selection Date: Mon, 30 Mar 2026 23:40:22 +0600 Message-Id: <20260330174024.20712-3-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> References: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- drivers/staging/iio/adc/ad7816.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index 5acfceb90..f9a0a5a69 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -58,6 +58,11 @@ enum ad7816_type { ID_AD7818, }; =20 +static const char * const ad7816_modes[] =3D { + [AD7816_FULL] =3D "full", + [AD7816_PD] =3D "power-save", +}; + /* * ad7816 data access by SPI */ @@ -135,14 +140,14 @@ static ssize_t ad7816_store_mode(struct device *dev, { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); + int ret; =20 - if (strcmp(buf, "full") =3D=3D 0) { - gpiod_set_value(chip->rdwr_pin, 1); - chip->mode =3D AD7816_FULL; - } else { - gpiod_set_value(chip->rdwr_pin, 0); - chip->mode =3D AD7816_PD; - } + ret =3D sysfs_match_string(ad7816_modes, buf); + if (ret < 0) + return ret; + + chip->mode =3D ret; + gpiod_set_value(chip->rdwr_pin, ret =3D=3D AD7816_FULL); =20 return len; } --=20 2.34.1 From nobody Wed Apr 1 09:45:13 2026 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205343DC4A9 for ; Mon, 30 Mar 2026 17:41:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892478; cv=none; b=K9tbkjAqlX+P6jN1LuyoYHtlJiCLznJSqV+GHOzn44Wn9ZUXQkVR9xE88ObOQUNKpAAUs3vb5fry9tbvkB65PZiMVR7+e1BfQq068VtPUaKAYQtG+e+JGZTaIrLJYsNCCisfPQZUstQ+tP586TNxCJzdmOrwgOtSZ22ufbOFawo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892478; c=relaxed/simple; bh=9qTZJN4MZ8hzBIdowCVJK06Yf+gkp3opcTlMx+EtYus=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=L6kyy2Rlg7EUsVCPUDolVIx1XDEdSzJnLMKp1ODc2mZiZsjkN88+y2AnX6DGDjjxfdI74YJOvGF8w6PAMEGzt5G/XrDMVgm86evcaM6hXtNGQM9lF0PWrtGVoTHKPA1N8gYvzx0qW5YTQJFrrdk0EsrEBFGRo8rQKyrb4T1R3Rc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VpfCfB/j; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VpfCfB/j" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-82748257f5fso3126371b3a.1 for ; Mon, 30 Mar 2026 10:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774892476; x=1775497276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r0JUsGvLhS5kbPI7JpUTp+ry0YaI45Aayw2r9a2X+zM=; b=VpfCfB/jQg3s+QIfU8Lo4zGifaLn8Ny5iZqwDegmnozosblbtIlaoU+ZZ4+/PQiUG9 hvF94HrufbESPZnP3V0sqz8XpjBf5Q50B9QdO3adFbTyGglbLIJnaj+jA6aqqGhmfeYb KJ1KNGw4mvT6E2zuOp2BIeox4bRNeHoGxse2WbKQb36/OAlo78PvJk/9RXFhStRqJlGh 79E81imk9tvHqJk0fbdt54YJaAb5etRO04jmvY7jSzOKUtbJwJE8C4B2ksQSI5xaEv+d dflL8aMZn88cXONSxiSzo2+iMIAqqPc+/YddP1BmSld/vqsnVmbRLlBQwXuRcUOLEglK DBaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774892476; x=1775497276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r0JUsGvLhS5kbPI7JpUTp+ry0YaI45Aayw2r9a2X+zM=; b=ZOlifUno92lk1AZ8wgtQ44E26uqOzwZ8+ZWVcS5XQKtmpaMP4CMZ0j1D382mmwABh7 yeWd4bP1zCqKH0z8UO8lBztmJ8L+e5YUjW7jUp+7NjsMGcrshiKkIrzcgt8tFXtsl9uo m23YQHpjL4hsjV7e+pi/WomGvMq6JS1bJvUnnb+2Zg+ySB6ptzZ3u6dl21g2OQOcATTR Prsay7QBMVPwmpa//fR2FCD5HrZrniQm960UGR74X2oIoQXxdavj3dNckqaybWFcqX+8 CEGNo1OoeOfsoMexr7q5N5PrULH92rFYgQz+BI9nJ7PtfcSObpca2pChQRI/gZBe7Ie8 ya3A== X-Forwarded-Encrypted: i=1; AJvYcCUPfR4r9/9xoWmGDP+eAl3RQTlNIjlzYA+yeSayxjXiv6/QK9nBL5X+RzPB6af4nvC4gSL7FqwD7FCfZVU=@vger.kernel.org X-Gm-Message-State: AOJu0YxxmKsQyIp1/zoc5vokSvj2V6iS/q2KXC3zaGwCaMmpYnew83iE qiw8D8CYd0UtEif7Od31eQ/Q5lHIz5EDkvXDZe503DXP87CPIkBBVJ6w X-Gm-Gg: ATEYQzwHNXRFwljCXB3k/DX0Skjo5TErleIyhlrov7mJuHkrXDbdAxwU0wxjSZc4FWj sWo4itYyG1DA7U4HagYye0WQltK2HT645DIuh0Ziq1PZkBPI9AT59N/GEBTMmRwakg7Wboo+fbX bf1MRsEPSYgQgaC8z8nVyrpQMWaqv5hISiImvahhijN4RX+UlmCwtJrWxQfMXrfVWxWE7g2w3LZ HZsBkSaTaxcd2R8XJlUFU3t73eKeBh5vB/udqcINSXJ2PPlm8gM3F3TNfOFys+DNdbNJcvDkvY5 aHRhvOW9NoZFgpSnM3FtCkjkJCS6mieZihf2GckFcx/6VANdtqXhVyxGj+a/itj9viSXrmfzG12 8W/neXYR9cuyCNVI05Z8DeDUq3GyFYUZfhPr/evX3iF47CUx6vQzzl0TTYkeFMaQEiIuQTJWcGc ar7hqqt7JohI+yZZ/xzNcDP4YYMkc7Mp2M55N2MI7+XXJnj5po1ho= X-Received: by 2002:aa7:8486:0:b0:82c:9c90:6ea0 with SMTP id d2e1a72fcca58-82cd61d48e3mr265854b3a.3.1774892476427; Mon, 30 Mar 2026 10:41:16 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca860b125sm7844052b3a.50.2026.03.30.10.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 10:41:16 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v2 3/4] staging: iio: adc: ad7816: replace sprintf() with sysfs_emit() Date: Mon, 30 Mar 2026 23:40:23 +0600 Message-Id: <20260330174024.20712-4-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> References: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- drivers/staging/iio/adc/ad7816.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f9a0a5a69..f2486cb29 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -128,9 +128,7 @@ static ssize_t ad7816_show_mode(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - if (chip->mode) - return sprintf(buf, "power-save\n"); - return sprintf(buf, "full\n"); + return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 static ssize_t ad7816_store_mode(struct device *dev, @@ -161,7 +159,7 @@ static ssize_t ad7816_show_available_modes(struct devic= e *dev, struct device_attribute *attr, char *buf) { - return sprintf(buf, "full\npower-save\n"); + return sysfs_emit(buf, "full\npower-save\n"); } =20 static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, @@ -174,7 +172,7 @@ static ssize_t ad7816_show_channel(struct device *dev, struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); =20 - return sprintf(buf, "%d\n", chip->channel_id); + return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 static ssize_t ad7816_store_channel(struct device *dev, @@ -236,9 +234,9 @@ static ssize_t ad7816_show_value(struct device *dev, data &=3D AD7816_TEMP_FLOAT_MASK; if (value < 0) data =3D BIT(AD7816_TEMP_FLOAT_OFFSET) - data; - return sprintf(buf, "%d.%.2d\n", value, data * 25); + return sysfs_emit(buf, "%d.%.2d\n", value, data * 25); } - return sprintf(buf, "%u\n", data); + return sysfs_emit(buf, "%u\n", data); } =20 static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); @@ -286,9 +284,9 @@ static ssize_t ad7816_show_oti(struct device *dev, value =3D AD7816_BOUND_VALUE_MIN + (chip->oti_data[chip->channel_id] - AD7816_BOUND_VALUE_BASE); - return sprintf(buf, "%d\n", value); + return sysfs_emit(buf, "%d\n", value); } - return sprintf(buf, "%u\n", chip->oti_data[chip->channel_id]); + return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 static inline ssize_t ad7816_set_oti(struct device *dev, --=20 2.34.1 From nobody Wed Apr 1 09:45:13 2026 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3C23DDDD0 for ; Mon, 30 Mar 2026 17:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892486; cv=none; b=IGKtEuhR/XInmbIeTtm5M5+pBNHxWNA6o0GUjlhPPs5xghpTIQHoNicAw0FwJLsIKLjP8+hdteKHoBsGvYOX8nqTTeT88nAGcjWjZkey5kMpQXCmpMEzugmXfGk5ltp/D8RMG3UJy9LTOHdFvJojoxGNm1ddSr3/C/8qJ4gNWMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774892486; c=relaxed/simple; bh=tSquc7sa2Cn6LfGxEXgHs/QIbImA+arPbrIn1dVGGHs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iL2rIa4oxVS/qda69JBj4jCg7JjHQnXkGjw+ziLTSMobeUcXquh0T92183Kp6NhLfdWB7qvcXt6hTSYSZBhujUkig2mFzW5L98zM1P7OpRmwWqH7YlmE0O6UWw+zIGDCQOMYbaYQ3ovvjdl6qNPmTDnIBS0A0+yFZT5ZmSJJms8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iaiYEQmO; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iaiYEQmO" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-829afe24fb5so3342801b3a.0 for ; Mon, 30 Mar 2026 10:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774892485; x=1775497285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7fqwDF4ChSEr48olaKrcyFKqRQaBIIIXtDoKMJ7juOk=; b=iaiYEQmOzz72GdQQiXodXXq+s5o6xiJB6g3lWEX5lrNTu2zsxjVHHIkL/JBvnnZ/fl G76tSpztaGzXjixTlXJbAbKVwtNXUm+9KXkyv/2I+bSFZgAtJszvh1bQjQ4VUKJqICyA BlS6l2p6klgZPbVn0v9brt82N0tF7H+MmcjR8bKkm4wayFl3UJWnhoxlNAxtXUGfppoh 4h0yaTaKL5bXJziReTHMRD0Zs2gbL7x4pIbiKvAa4LnnJpzd7OwIxECq6IoQSXEeUciU dlMgouMu8vw9VoeD6jjdJ0yPJYz9siu0FYrdogE/swWyYy1AIcW1c7HdIBRN3HaQ0jsj TGCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774892485; x=1775497285; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7fqwDF4ChSEr48olaKrcyFKqRQaBIIIXtDoKMJ7juOk=; b=qOAt61BVsmX0AbA2yNHqCLf4SaD1+FCYRvD/Nf82uuoedLSpgn8r5CXuU0yBqaiAsp 5N3Oy99xMmK+qGVibwPlJWiIgcN9urJFD8ypMLPc/Wmtd5QhEXVT1NBktuO/zDH+SRr6 Z1Zio/vEs/rDX8oY5ieVVrfavtw3ODExmHSm1RdehXr7xBW4thJH3nfseZ48diY1dxe4 UR2mRYEkRSuDCfKtnVUHr75um2SH8FckOWnL59VO/1oVIluSEQqQ6r/Ya+578G4rQI7/ v0r/blzyUcK2sX0sjaFQ7oPfMum7RA4NkQgEg4sakm7qwQ70n0QNpHsEn0wH9poXnWVF g3vg== X-Forwarded-Encrypted: i=1; AJvYcCVM2UlxnCAlu1gHfBtoXrDFCodNZWGwR66YViLiowm8aYeGxYtxo/DsZfbPeUQ4VjmyqyPyOjbM5cr/ilQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4iObVA30Pk/h3xHKFL9VI3wmUI5cIM1N18PYeo659tOrvCW7G gRlM8nZlC6nVkCm9H4VTucWLe6jvm5zaLocsylOXakbfdk8QvKhk8W8CFBupXAoTtWg= X-Gm-Gg: ATEYQzxTyvE0g3vz7w2z5yn2REw91si8DtjTSicC9XIX7YTTDoeUJ4hiA6XO946bx1o D4kMb8XOz3ORtbm2Hi46OthWPWTl3mtg+pyJInMSIVdjTM0Z4etvbY/0OYWNGPSsog29HMtrHI1 s9FsxBOPP5+qSS9eOoBNBCsCoMsWuJbC4AAyzpizc817CjQeNToCWztZHAcsnG2+TuZ/hjF7j6J nSGjefpnSLriIeTmBP75BQ3dPBr6KMIvfv1lrmgLBSVJbo0NlciJN1H8rZRlTavtpzj3z9KBlWl sMWjWYr9WQX3VlRDSVxN0t5l4H5XGsvVZOYn7p+dY5yLETR2t/EkwqaVVcfLKrHNnfPPF5t7GrX YzJARciLtFe7qGDjSyaXAs+YNKVavYcmxo1sj2LPbgH8r8HhjOFJjIPCIWxdY6ulJ8Z8q38PHRp Tfld59Y0o0o9L/Tq5Y9TDw3ARIPGVbPonXgcK/CcAG X-Received: by 2002:a05:6a00:4299:b0:82a:7aa3:a2f3 with SMTP id d2e1a72fcca58-82c95ee4bedmr11931671b3a.33.1774892484669; Mon, 30 Mar 2026 10:41:24 -0700 (PDT) Received: from Mahmudul.. ([2400:c600:545e:6508:42eb:3d78:89be:591b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca860b125sm7844052b3a.50.2026.03.30.10.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 10:41:24 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v2 4/4] staging: iio: adc: ad7816: use modern IIO attribute macros Date: Mon, 30 Mar 2026 23:40:24 +0600 Message-Id: <20260330174024.20712-5-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> References: <20260330174024.20712-1-mdmahmudulhasan1511@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" --- drivers/staging/iio/adc/ad7816.c | 72 ++++++++++++++------------------ 1 file changed, 32 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7= 816.c index f2486cb29..80f84e2bb 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -121,9 +121,9 @@ static int ad7816_spi_write(struct ad7816_chip_info *ch= ip, u8 data) return ret; } =20 -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -131,10 +131,10 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "%s\n", ad7816_modes[chip->mode]); } =20 -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -150,24 +150,20 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); =20 -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } =20 -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); =20 -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -175,10 +171,10 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } =20 -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -208,14 +204,11 @@ static ssize_t ad7816_store_channel(struct device *de= v, return len; } =20 -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); =20 -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -239,7 +232,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } =20 -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); =20 static struct attribute *ad7816_attributes[] =3D { &iio_dev_attr_available_modes.dev_attr.attr, @@ -269,9 +262,9 @@ static irqreturn_t ad7816_event_handler(int irq, void *= private) return IRQ_HANDLED; } =20 -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, + struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -289,10 +282,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } =20 -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); struct ad7816_chip_info *chip =3D iio_priv(indio_dev); @@ -330,8 +323,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } =20 -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); =20 static struct attribute *ad7816_event_attributes[] =3D { &iio_dev_attr_oti.dev_attr.attr, --=20 2.34.1