From nobody Wed Apr 1 11:12:44 2026 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52BEB27CCE0 for ; Mon, 30 Mar 2026 16:55:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774889715; cv=none; b=oc4S4odBkLMX8eBQ068LBg3bWnMGsZqkG5QnDJgnKFP11A2A7zxOU6sUirfubj2FgadofhXnpdDNKRcjeBStbOQh/w76vf3690Z+JC34rlB4oTlrVzFcG3+Sneqbx3UhyOzlnHGkJS6ZY+tAxKXKGWuSJBtRcvmqJnMI4iBo+nA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774889715; c=relaxed/simple; bh=+SaACf2PNmxd5pQWD0kHDgFviaN9ipDMh+KEaWIpRr4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kl9llncp2ak1odUKqzt1EABR55zRfgBJU1BuyHFmxxUGaxy0pYTwRp5o+cPWG5OOjeeMSOy5b88GD4YnBQWhExmRyvQv+d+uv3qUP1r+l5SA1qXKbmMqrtcomHARaiP0i5/XxohPbfxvksa2qAHLtAVxbBKRElvRpQ9Uk4fRWSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Crzc6+Pc; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Crzc6+Pc" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-6501c4857b2so2975345d50.3 for ; Mon, 30 Mar 2026 09:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774889713; x=1775494513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2f9qYmvdl3SMYn7348I/foZIVCTRci1cAAcILJVHy94=; b=Crzc6+PcX+kJNCxHOwDhh6HpYgNFFAafEm8fuMwwsIFoiSVOErxCSsXNMtdaZOBI3B jdnG+HyT/k/5sqmost6VY9pdljAJe0wrySNJmmUKksri0mCfBTE75qGloJr2/3+njbYs Yp23w5gnbSZQJfIz4JCIseumnXUp0UP24hGF7Q5BRjOrIM45I39jy31kcZNLwVqhMz86 zXO5K1vC2Zu6iObhuvzonjPpqxT+nA9K5++iGmbUZNWgKfzjeGUxfOa5pkbjWEte0j+7 83OW2eHOBElUl1JLZuHmxW0a8JEs0BaxED+586nSUMsZrUJtGY5ujRTU3R+Qgeg6uYOa fdQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774889713; x=1775494513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2f9qYmvdl3SMYn7348I/foZIVCTRci1cAAcILJVHy94=; b=AszpaOtdQzbvJQgj2BhzhkEsJMKaP5u+IJjxfgy/n2e2c/SukJ7ExYRv2txemXaqqS H1TOsDRj/07AwwCuTLG7soFxj27Ppzx9sfjRGTqDzfWhN2/rjJjH6gQ2lbW+HF21Jq1S D01eEYvQZ312fYCp88v2I7xR/TKB5dkOS52508pv9k2Qy9tn8f/wQ1sjF70hnIISi3An xqMMf84f2Zdeop9ZoYPP6ARDG5RAyjkdA3qj013spxCRbnj1truqpbfvUpC6XlbQJEsa 2ZhdKZ3lEHYqKnVVRLAQctPM5PuLJyfvUksmHU8MG4/NLH1d3ku4cx7v7CQZvsbpeax3 ZWVw== X-Forwarded-Encrypted: i=1; AJvYcCU4rfuOPoCat160ADVpi/oKamWlHoFlVH9Hev76Z3DNXg4fvnYY0aRegHBcTpqRqDTf0sEzH5nfnIX6YPM=@vger.kernel.org X-Gm-Message-State: AOJu0YzVtqnhcsRBZ3yRPayo9M4/N5PaAcLqiOBxBpCBeVUo6JacmeZW 3WR1e2pNV0jIYdIkadBBPvPb6LzYXqYW1jp/dv3v0bj5/xbb9KOSfhG5uGfdpSmZ X-Gm-Gg: ATEYQzyl8fBpZtFlAzA3UW/h/+xEtoRqRkMxz9PVZh5P8T1kd5R9DvX3iGZLNq0tJQw RtoFxFVI/+L4+qz0vP75oJ1iYQPZlZEAXh2425SFLCOO3xaTeublsa8PiJL/jgd43zDNWd/9P+A 6RzJITpjrzk/D+dcFqQF+ThZp9AauhIwQDKTS0NWi1UUX9s7C5YKwizqq93Y5P83zq/bY3rpaY8 jXpErTqMnT8h8yY67NCyM/61M2Gapn/xqMIbkrvEaV8HC98OibHpguMtwKH+atTeMG9WvVZIW3a RohhKJ6WEs0WVjWoSFc6J/MYqraakYn9wQi4VDKyfBNTrS3C79H0JJHPtDsV969E/fw9CHQAuUz eU/hVKAAxYbTnfJ+V6Chq5up5b4aJz+n4MKawmICR/GU5CqQReON3eGwmm3HD3UOksmoVbtVhEl by825pBerSPf8YyScVvpZmz5gdT5vaLd4QUK3jg7UBYbwqqUB0fkybAvY3zoenQSRZlQ8B8h/wB JJjYG4qgLLaclZWNLoGjxpFon+R609+tWc= X-Received: by 2002:a05:690c:6e87:b0:79a:bf27:fe65 with SMTP id 00721157ae682-79bde0a01f5mr130241797b3.35.1774889713195; Mon, 30 Mar 2026 09:55:13 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a09583f32asm1639527b3.24.2026.03.30.09.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 09:55:12 -0700 (PDT) From: Ethan Tidmore To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/2] staging: rtl8723bs: Remove dead code Date: Mon, 30 Mar 2026 11:55:09 -0500 Message-ID: <20260330165510.33134-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260330165510.33134-1-ethantidmore06@gmail.com> References: <20260330165510.33134-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove commented out code and remove if statement with no body but a line of commented out code. Signed-off-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_ap.c | 83 +++---------------------- 1 file changed, 7 insertions(+), 76 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 4b4012411011..3327519dd729 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -20,8 +20,6 @@ void init_mlme_ap_info(struct adapter *padapter) INIT_LIST_HEAD(&pacl_list->acl_node_q.queue); spin_lock_init(&pacl_list->acl_node_q.lock); =20 - /* pmlmeext->bstart_bss =3D false; */ - start_ap_mode(padapter); } =20 @@ -32,8 +30,6 @@ void free_mlme_ap_info(struct adapter *padapter) struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 - /* stop_ap_mode(padapter); */ - pmlmepriv->update_bcn =3D false; pmlmeext->bstart_bss =3D false; =20 @@ -377,7 +373,6 @@ void update_bmc_sta(struct adapter *padapter) =20 if (psta) { psta->aid =3D 0;/* default set to 0 */ - /* psta->mac_id =3D psta->aid+4; */ psta->mac_id =3D psta->aid + 1;/* mac_id =3D 1 for bc/mc stainfo */ =20 pmlmeinfo->FW_sta_info[psta->mac_id].psta =3D psta; @@ -413,17 +408,14 @@ void update_bmc_sta(struct adapter *padapter) /* ap mode */ rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true); =20 - /* if (pHalData->fw_ractrl =3D=3D true) */ - { - u8 arg[4] =3D {0}; + u8 arg[4] =3D {0}; =20 - arg[0] =3D psta->mac_id; - arg[1] =3D psta->raid; - arg[2] =3D 0; - arg[3] =3D psta->init_rate; + arg[0] =3D psta->mac_id; + arg[1] =3D psta->raid; + arg[2] =3D 0; + arg[3] =3D psta->init_rate; =20 - rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0); - } + rtw_hal_add_ra_tid(padapter, tx_ra_bitmap, arg, 0); =20 rtw_sta_media_status_rpt(padapter, psta, 1); =20 @@ -448,12 +440,6 @@ void update_sta_info_apmode(struct adapter *padapter, = struct sta_info *psta) struct ht_priv *phtpriv_ap =3D &pmlmepriv->htpriv; struct ht_priv *phtpriv_sta =3D &psta->htpriv; u8 cur_ldpc_cap =3D 0, cur_stbc_cap =3D 0, cur_beamform_cap =3D 0; - /* set intf_tag to if1 */ - /* psta->intf_tag =3D 0; */ - - /* psta->mac_id =3D psta->aid+4; */ - /* psta->mac_id =3D psta->aid+1;//alloc macid when call rtw_alloc_stainfo= (), */ - /* release macid when call rtw_free_stainfo() */ =20 /* ap mode */ rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true); @@ -544,9 +530,6 @@ void update_sta_info_apmode(struct adapter *padapter, s= truct sta_info *psta) =20 memset(&psta->sta_stats, 0, sizeof(struct stainfo_stats)); =20 - /* add ratid */ - /* add_ratid(padapter, psta); move to ap_sta_info_defer_update() */ - spin_lock_bh(&psta->lock); psta->state |=3D _FW_LINKED; spin_unlock_bh(&psta->lock); @@ -567,9 +550,6 @@ static void update_ap_info(struct adapter *padapter, st= ruct sta_info *psta) =20 /* HT related cap */ if (phtpriv_ap->ht_option) { - /* check if sta supports rx ampdu */ - /* phtpriv_ap->ampdu_enable =3D phtpriv_ap->ampdu_enable; */ - /* check if sta support s Short GI 20M */ if ((phtpriv_ap->ht_cap.cap_info) & cpu_to_le16(IEEE80211_HT_CAP_SGI_20)) phtpriv_ap->sgi_20m =3D true; @@ -621,11 +601,6 @@ static void update_hw_ht_param(struct adapter *padapte= r) pmlmeinfo->SM_PS =3D (le16_to_cpu(pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info) & 0x0C) >> 2; - - /* */ - /* Config current HT Protection mode. */ - /* */ - /* pmlmeinfo->HT_protection =3D pmlmeinfo->HT_info.infos[1] & 0x3; */ } =20 void start_bss_network(struct adapter *padapter) @@ -662,16 +637,11 @@ void start_bss_network(struct adapter *padapter) pmlmeext->bstart_bss =3D true; =20 /* todo: update wmm, ht cap */ - /* pmlmeinfo->WMM_enable; */ - /* pmlmeinfo->HT_enable; */ if (pmlmepriv->qospriv.qos_option) pmlmeinfo->WMM_enable =3D true; if (pmlmepriv->htpriv.ht_option) { pmlmeinfo->WMM_enable =3D true; pmlmeinfo->HT_enable =3D true; - /* pmlmeinfo->HT_info_enable =3D true; */ - /* pmlmeinfo->HT_caps_enable =3D true; */ - update_hw_ht_param(padapter); } =20 @@ -694,7 +664,6 @@ void start_bss_network(struct adapter *padapter) rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VO, (u8 *)(&acparm)); acparm =3D 0x005E4317; /* VI */ rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_VI, (u8 *)(&acparm)); - /* acparm =3D 0x00105320; // BE */ acparm =3D 0x005ea42b; rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_BE, (u8 *)(&acparm)); acparm =3D 0x0000A444; /* BK */ @@ -711,18 +680,8 @@ void start_bss_network(struct adapter *padapter) rtw_hal_set_hwreg(padapter, HW_VAR_DO_IQK, NULL); =20 if (!pmlmepriv->cur_network.join_res) { /* setting only at first time */ - /* u32 initialgain; */ - - /* initialgain =3D 0x1e; */ - - /* disable dynamic functions, such as high power, DIG */ - /* Save_DM_Func_Flag(padapter); */ - /* Switch_DM_Func(padapter, DYNAMIC_FUNC_DISABLE, false); */ - /* turn on all dynamic functions */ Switch_DM_Func(padapter, DYNAMIC_ALL_FUNC_ENABLE, true); - - /* rtw_hal_set_hwreg(padapter, HW_VAR_INITIAL_GAIN, (u8 *)(&initialgain)= ); */ } =20 /* set channel, bwmode */ @@ -739,21 +698,17 @@ void start_bss_network(struct adapter *padapter) =20 if ((cbw40_enable) && (pht_info->infos[0] & BIT(2))) { /* switch to the 40M Hz mode */ - /* pmlmeext->cur_bwmode =3D CHANNEL_WIDTH_40; */ cur_bwmode =3D CHANNEL_WIDTH_40; switch (pht_info->infos[0] & 0x3) { case 1: - /* pmlmeext->cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_LOWER; */ cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_LOWER; break; =20 case 3: - /* pmlmeext->cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_UPPER; */ cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_UPPER; break; =20 default: - /* pmlmeext->cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_DONT_CARE; */ cur_ch_offset =3D HAL_PRIME_CHNL_OFFSET_DONT_CARE; break; } @@ -789,8 +744,6 @@ void start_bss_network(struct adapter *padapter) =20 /* update bc/mc sta_info */ update_bmc_sta(padapter); - - /* pmlmeext->bstart_bss =3D true; */ } =20 int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf, int len) @@ -836,12 +789,9 @@ int rtw_check_beacon_data(struct adapter *padapter, u8= *pbuf, int len) /* beacon interval */ /* ie + 8; 8: TimeStamp, 2: Beacon Interval 2:Capability */ p =3D rtw_get_beacon_interval_from_ie(ie); - /* pbss_network->configuration.beacon_period =3D le16_to_cpu(*(unsigned s= hort*)p); */ pbss_network->configuration.beacon_period =3D get_unaligned_le16(p); =20 /* capability */ - /* cap =3D *(unsigned short *)rtw_get_capability_from_ie(ie); */ - /* cap =3D le16_to_cpu(cap); */ cap =3D get_unaligned_le16(ie); =20 /* SSID */ @@ -1075,12 +1025,6 @@ int rtw_check_beacon_data(struct adapter *padapter, = u8 *pbuf, int len) =20 pmlmepriv->htpriv.ht_option =3D false; =20 - if ((psecuritypriv->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || - (psecuritypriv->wpa_pairwise_cipher & WPA_CIPHER_TKIP)) { - /* todo: */ - /* ht_cap =3D false; */ - } - /* ht_cap */ if (pregistrypriv->ht_enable && ht_cap) { pmlmepriv->htpriv.ht_option =3D true; @@ -1098,7 +1042,6 @@ int rtw_check_beacon_data(struct adapter *padapter, u= 8 *pbuf, int len) get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pbss_network); =20 /* issue beacon to start bss network */ - /* start_bss_network(padapter, (u8 *)pbss_network); */ rtw_startbss_cmd(padapter, RTW_CMDF_WAIT_ACK); =20 /* alloc sta_info for ap itself */ @@ -1117,9 +1060,6 @@ int rtw_check_beacon_data(struct adapter *padapter, u= 8 *pbuf, int len) =20 pmlmepriv->cur_network.join_res =3D true;/* for check if already set beac= on */ =20 - /* update bc/mc sta_info */ - /* update_bmc_sta(padapter); */ - return ret; } =20 @@ -1475,14 +1415,12 @@ void update_beacon(struct adapter *padapter, u8 ie_= id, u8 *oui, u8 tx) { struct mlme_priv *pmlmepriv; struct mlme_ext_priv *pmlmeext; - /* struct mlme_ext_info *pmlmeinfo; */ =20 if (!padapter) return; =20 pmlmepriv =3D &padapter->mlmepriv; pmlmeext =3D &padapter->mlmeextpriv; - /* pmlmeinfo =3D &(pmlmeext->mlmext_info); */ =20 if (!pmlmeext->bstart_bss) return; @@ -1540,10 +1478,8 @@ void update_beacon(struct adapter *padapter, u8 ie_i= d, u8 *oui, u8 tx) =20 spin_unlock_bh(&pmlmepriv->bcn_update_lock); =20 - if (tx) { - /* send_beacon(padapter);//send_beacon must execute on TSR level */ + if (tx) set_tx_beacon_cmd(padapter); - } } =20 /* @@ -1847,8 +1783,6 @@ u8 ap_free_sta(struct adapter *padapter, psta->htpriv.agg_enable_bitmap =3D 0x0;/* reset */ psta->htpriv.candidate_tid_bitmap =3D 0x0;/* reset */ =20 - /* report_del_sta_event(padapter, psta->hwaddr, reason); */ - /* clear cam entry / key */ rtw_clearstakey_cmd(padapter, psta, true); =20 @@ -1888,9 +1822,7 @@ void rtw_sta_flush(struct adapter *padapter) list_del_init(&psta->asoc_list); pstapriv->asoc_list_cnt--; =20 - /* spin_unlock_bh(&pstapriv->asoc_list_lock); */ ap_free_sta(padapter, psta, true, WLAN_REASON_DEAUTH_LEAVING); - /* spin_lock_bh(&pstapriv->asoc_list_lock); */ } spin_unlock_bh(&pstapriv->asoc_list_lock); =20 @@ -2017,7 +1949,6 @@ void start_ap_mode(struct adapter *padapter) =20 pmlmepriv->update_bcn =3D false; =20 - /* init_mlme_ap_info(padapter); */ pmlmeext->bstart_bss =3D false; =20 pmlmepriv->num_sta_non_erp =3D 0; --=20 2.53.0