From nobody Wed Apr 1 09:43:46 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2B1033FE12 for ; Mon, 30 Mar 2026 15:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884030; cv=none; b=E8HiWsdrpheaTr7UzmPLM2Awj9aEnu182cdzz7v2YxydfeUkYlLaNtEdxDjgDL2LblltVcJPnehmpU7LVgxwxEzeLc3T/eDB1edQFyU4aLq9v1/rNC4Hu63CjSCDkGMpGZtDUBs7iCnw089suP9quE5V7lYvuQL0H+rQSBMhBFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774884030; c=relaxed/simple; bh=zaYZzXfNb5Yh8uDxRqRlNV+NT11MzWt0MOXKtvGWU2c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qcb6Mvz0l+mclcdrbNz37QOW5L9amva/atP2qvDmAvb9mFEmwEYryi2q1Q3xJ5eYgmFACipjaH0+EVf0o5dTc6fcEmz0EO/1nkHBv8OIG6w0OhC9Rm6PxSEwV1tQlbr7L89OH/ZTSqdriRkC3LqRixgBapMQ2PX8CkQEuNF0aZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kdfF/Qnq; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kdfF/Qnq" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483ad568d68so6554945e9.2 for ; Mon, 30 Mar 2026 08:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774884028; x=1775488828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sDvERDZoAlGyHoO/AmLOjRnD9UlryXe2PNrEtyg6T8E=; b=kdfF/QnqU1ROaamS1piMLKusCEuszMSB0Gji+sPdcN9y9r5ZSEz2/RAS750gKsmUte hwDakI0sD3MNcfR9c3VHQ5o5kjjCyGILxBGhfLNu+jyriu/bK+amjO6HbLQFfVek7/Ew VBRMUYFmR0zLWGxYcrxQDHPI1CPi1tH5a1757jBfFiieMYVkYCN3V5R5YWKbFPAmWvLv OpjFDn/zGWmZBfVFP7Eb0pGCbuLxS6+GZUbrUVKbdtV064fc5CPP28ZYze/TaA+ga832 iouKK1SlA0p9GxIXRFWI+fZRyGB68nMxGoj99JJ2MIhzbU5SWZR33TOwVxjfkmd4Z3BU GHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774884028; x=1775488828; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sDvERDZoAlGyHoO/AmLOjRnD9UlryXe2PNrEtyg6T8E=; b=i+zSoapSmASa2pOu7oN2oztnlNvvGSNjrfr9d1GGElot/X4babbNN5OFHk3ckdMICG rRCS8WMLGUL1qX3fpw/6rqyNAKh1zFoBn6bSMCabeJgfNJAV6ZNxhJroj9u5K2cng4nq Ab+FWhXIOrtI4LQgiSE6Sw74+/4iAlazGUufbae6HVGIXCikgdHKzbG3VhFG2mxfKKqe BP4RHQs2Dl74lH/cTEfPCI0Ab9myDFh0mMTvNlQ0bSIggrVUDqa2uSka1ZtmPPxQTWAo ldDdmD8nDM4Hu0DCZOeTKAySVRGyhZ/ey/A4XXDZFBrNkCjT6FqwQ9gr4gfvsOXIclm9 0nMA== X-Forwarded-Encrypted: i=1; AJvYcCW3NSJVBZqtYoMH/clLO8VL6TPLc7x9fTkuVKilAC2ctWcXWBC1TKo3aJ/ApHmDmoId2j90/eY6IalRRMI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8YSwAvYN4rX8lGAMBvtQTLdcGvN5IeEG5uAQeKge1lPsPzE60 z88Kt3W0ntL5L6Sef+wO+X1u9yDiXdDrCE6nl1pGnbCggGR1K+u4NWNB X-Gm-Gg: ATEYQzwmVdSP7wh1bB2Atb3ZhffPkIyjQ9KCB3DWILlCkMraIVWXSHCx84lJU8pZNww hMRLfsa52LyU12ST+zOZnZ3R5yF5Z9mtQbjK5pBjMvEqg/ThFEGGRf149gNzJCS0ryNlxh51gI/ BL1AI3qdeMsGWdnMeB9q4X1qG3RJzqlELsslfmvJOlm4q7iPNbn/ebKkBsJ8PVbUwv4lBDscjOq 1jzX52dDr+Ht74CcEEfxX7FTN27+PYyFpC23EbuSyUUVwfzjj0H+bjiqC22MnlB7bvcMrfxBJON 5EIVBVWugq6Kidb1opfLUD6O6Jzg2KHqBmgLPZt1Z7yBXqQroZjvK4Pan6d8AaV6Ctx7zG7+Mym sMLIEohE6cVliE4wPuVRboZkCeID4INs7EvP8wpUBfRvdprMb/xkhZq4OMUTmx8d3QKcENtjWC2 UEMLWjhl2s1N35QKVBNSn2CgYd55cva+y8pMmy7V8l6aJ1CuYTNbEiuIEF00YN5wv2L877OjVxp y+gLk3GvMzQQKGs5B/n X-Received: by 2002:a05:600c:c493:b0:486:ff8e:1911 with SMTP id 5b1f17b1804b1-48727ef0319mr107582435e9.5.1774884027689; Mon, 30 Mar 2026 08:20:27 -0700 (PDT) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-82-131.paris.inria.fr. [128.93.82.131]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-48722be608bsm430820075e9.0.2026.03.30.08.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 08:20:27 -0700 (PDT) From: Thomas Fourier To: Cc: Thomas Fourier , stable@vger.kernel.org, Herbert Xu , "David S. Miller" , Kees Cook , Jonathan Cameron , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: hisilicon - Fix dma_unmap_single() direction Date: Mon, 30 Mar 2026 17:19:32 +0200 Message-ID: <20260330151937.83837-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The direction used to map the buffer skreq->iv is DMA_TO_DEVICE but it is unmapped with direction DMA_BIDIRECTIONAL in the error path. Change the unmap to match the mapping. Fixes: 915e4e8413da ("crypto: hisilicon - SEC security accelerator driver") Cc: Signed-off-by: Thomas Fourier Reviewed-by: Thorsten Blum --- drivers/crypto/hisilicon/sec/sec_algs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/sec/sec_algs.c b/drivers/crypto/hisil= icon/sec/sec_algs.c index 54e24fd7b9be..85eecbb40e7e 100644 --- a/drivers/crypto/hisilicon/sec/sec_algs.c +++ b/drivers/crypto/hisilicon/sec/sec_algs.c @@ -844,7 +844,7 @@ static int sec_alg_skcipher_crypto(struct skcipher_requ= est *skreq, if (crypto_skcipher_ivsize(atfm)) dma_unmap_single(info->dev, sec_req->dma_iv, crypto_skcipher_ivsize(atfm), - DMA_BIDIRECTIONAL); + DMA_TO_DEVICE); err_unmap_out_sg: if (split) sec_unmap_sg_on_err(skreq->dst, steps, splits_out, --=20 2.43.0