From nobody Mon Apr 6 09:49:45 2026 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011012.outbound.protection.outlook.com [40.107.130.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8A33C1986; Mon, 30 Mar 2026 11:24:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869877; cv=fail; b=iApCTL6FIbel1Wefv6LRJ8cKN+TAr8OXaFveCBRcqXlbXkLEUXwfGO2wSkNGYfGRiTqPa6oJ0nn9Ys/ZGAmbOUXWv4Ej0VLvA0X1O65ta21euUxmAnr7sdccV/PFVnrJh6b/XLED83fhFIoBoq0vDbonSpc8e4j2grGDDuqCXGs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869877; c=relaxed/simple; bh=3O/ORVmeE4LTreSezBLRTWEyBELACMx8WGbdYHcnhhk=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=bE5lYmmHWySqrFRa7lww1U1DdVnrqPz8ULBbVBUy5C9PFP1hQmHYeaihvRpRLj6N3724A60RjxiHzbvgsmsYoQPivKDlruCRVLoK92Q8iZSH7OCJ0lYB7fRe/BCriPU8b85xGNxvAHmaGLHHb5IBaclFTNz6MD73CLOF/vjBxGo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=n3hh0YEZ; arc=fail smtp.client-ip=40.107.130.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="n3hh0YEZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wpS3CO/BAX2lOc6HorIE/vWm+F/q9mCpzO+n8Vq3wXtHJ0/etjgsNcz5X2WJC1bk48AbPrkpXX7xh+gAj9sFnfIkOtXBPmHjvWA8k+AEqoQJR5rfPsU7ch5TcRGEyerskxrQ2RJLgFIpQEqHD48a6wO6NQpn0BP9CyDYDSjpV+fHjFJ5DB9vWWKWVB60MCd3Hjl+t+c1LHiwwLy9+B6sQw7ui5Lu6NKeoRs1GF7196vHGEpNdQYEXUflel7U7DViUNiEL9WL/js7q+bVgt0hHj1D0+gGrE+hzDKNpiruPzVG93kcgpv2G4V4pmH/QulpVV8VIbrzgHAgBsFIw5h1Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iYtWKN468AYcmwQsYSWAgH/Fo9OGSrF0j8fEL5WYu3g=; b=v6l/sXCiekej9uai6Ez/S0OmGa3pXAtYkhSmTjJwCw/GQOPptWI5laZa6nnti/Nnh4ypPy/KEeFZ88FiDDPv0Zjv3OG6tnzPB4hFvXmMpbdaG1tfU0t3nVPFQPI6aT5kauI6oOVY2MTnQLvNWa64EHBovmGb16nFF8n9/ibytQF+MuzHRdtQbhN+Ca94I7BbTvWQC/BfHSM4Pk8R2ZaoX9K8aTCYdyVtXb6zykNDYhTdwZjbsfENtjYTDqmDvehduxwfG8G79wBMo2g64TQPpwhOcZlBrXyd4oaFvngWKwLf6cNoBwR8j+uFQq6h6latvzg1MFvHT0wCxg7DwCTPpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iYtWKN468AYcmwQsYSWAgH/Fo9OGSrF0j8fEL5WYu3g=; b=n3hh0YEZ4o9hul+NZ7ALq6BHw/LxSWruSjJ7kyl+VGPj7GooFdAJj7CwQOaI5fw6ayjER2LXJtn6KNJr0OxOHcZXWrNvScKRbmeddA7vYHrcMT52wS2+92MaX8Te75/HMp8GlWDtDpSf5y00drv02OyWJgO9EjT87HplvQTsZPfrsl/dn1HbUdua1ivY9Ejk9a4a3FuUx8ka5m+Cr75nN4XxJJTimXVb0nglCtWVCAiJEPhiKtyicDdYQUDTDDfRNDx36jaCW8n99u4NY6Xrms5T65P8uH3wDCibAnZJsmyQRS8mhryv2pJbVHMB8i23+6BTvhTgZDNhRB3+I+b/8Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by PA1PR04MB11036.eurprd04.prod.outlook.com (2603:10a6:102:48b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:33 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:33 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] ASoC: fsl_micfil: Add access property for "VAD Detected" Date: Mon, 30 Mar 2026 19:25:45 +0800 Message-Id: <20260330112555.3637002-2-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|PA1PR04MB11036:EE_ X-MS-Office365-Filtering-Correlation-Id: 06150b00-3bc0-4632-ee14-08de8e4eeaaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|52116014|376014|366016|56012099003|22082099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: 995CB84K+mRh/KPmVJK7hIWlfNEUzq5hPPUNzV709Siz7Ca6KFguEmOJdyM7a+lH4zYHTtHEWtrmxcwUCQAc1rplMFPES0C/7eIm25SHRIZBBavg9c23dljtkXCFwfrX6wrI6nZv5yDXNFk6/Yn8Ww3qSNBYkPM1SvmrRR/U1OYtVghPowER8CqHfXp2Z9cNXJkxqLZS+MuZJrgdciNAn+pPRFabN96maQjmiBu6t2XJ75kyjwOTkrGVIzS2sTlBX0o9RkbVA2n9zyJ+arAMNH1dGQvEeP/VAfpQb1GjdT0yo7erNlvVBlmmJHFlhLfiDUepi64oIeP9H+w8jyM+rhtNtXVxMrxOUK6GyeIozj3sLK+o6fxEfS2v2II4pNt1FNOfw8EplfXF6RV2M9a742369uDjpRRcz/7f/bT7bOEiNvON5u79pObacMI2Wl4YVtkr/fmW62gKLSaaU5DVPRFip2MDJ5AUf0vvmtSMtOdSKn2H0MrdsATFbPBkdTs8nFuW7ePBhq5k8QPJ4ygZMC5JjlizFxWkcU3E/wY4criKTUtF0xRjNtkI8mXCzmb9O8Pls7Frzu1zaIdJlLYMuesqlzJ7JjBUGwEMpKk9Y4l7lQaLcc+GJvtEFGZ5grKODNpq0VUaJx7dWubmfdisG9PORjp/eOlAHeDgJAnQ31CmkE9awzckhmpZJB5eJOsrhivv1zeK1hw87+x55Ihdfqfnjib30bZv/IuBF8QFLjrzNFJIbXNQ2ij/B2dLkOpPsUThpa+6f02KCWKiV4B52lDqEbX69SvDvskFzdfzxSHyEKItlpyw6xn3A1KtUydS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(52116014)(376014)(366016)(56012099003)(22082099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RyM32qIkSOxS6SldrwUmkHXVYBQFsNyt4Zq2nrHp+zLR+ODhzell+WxHCasP?= =?us-ascii?Q?gt3kvkmyffjm7HAu365R1arvXVGtYNIWBNwMb1pfVY/T3/y8vphgrRRKAoNg?= =?us-ascii?Q?YxJbw0QcivBQPmiheVUmzY8Gt8exgxnv5zPK6O46fxJCaj74hbBeFvmXu18r?= =?us-ascii?Q?FZod0dq3LjDahrOlWihPxg7nIGseuAA6QggoyUdXVLELMWSwL9FeC1+CLv4f?= =?us-ascii?Q?KhXUTT6W7MlhNkLGnieMknR6s9Rrx7TclyDgBR4hPJ+P/KRrhrdcF6sROFf1?= =?us-ascii?Q?8IJHav+vNFK9o+Hro8O8ffwQ3/2L9xmfyHevmnhqD/y/dy3hXPbSKFZnHIrT?= =?us-ascii?Q?CobFD+wXK9wruqHd3Rq2waLVjWUXlsXyHH9l+rPFYoOPoW87OD7sI73omS+W?= =?us-ascii?Q?OtqvCBlp48X2dzmRrnDA5PsUYp61m5JWn37ErmxdgWQX5bgdADC5lHcumxPb?= =?us-ascii?Q?PAU4IK6xh2zricHXcXRQ0yv96LRh3MdiLPg76TZJcQrLBwDqe+EvYcSeI/Dk?= =?us-ascii?Q?jkj85SoZ3GuucRMBsa6X8X305NScWXuuLs0WZbXk0WLDU+GYZT+dBfAaHYKj?= =?us-ascii?Q?QhmHTkMJdgJGsz+MfwzrkP1kpzZ2gXc/Yd50h7q31MHaiZ1wyWi8E8IdQznJ?= =?us-ascii?Q?4caio2LCTbbJRppaG0zuDN14EqBd3OaKkHa2MmPmrZ8cAt7Ah48Zls3RFxwy?= =?us-ascii?Q?2E77z/K0BF1hTn+kTICvHctEsuQhCzglu9k3wgyX91sh37U6Q/WTJt+6Lw03?= =?us-ascii?Q?BNnYhjxW8h+9Ix+AUohqXxmiWEHmyjEXyq1LdHNW0RR3YpbJpd+vWeCOGa7F?= =?us-ascii?Q?e54eVLhBeboI6n4iZ38GSBavuK2n2vId86tWSTwtq0mC9y2Hi49qg1Dn88eu?= =?us-ascii?Q?4nTbHpPHNqYdArObZQJW6nbOXxZpSTlmDSCPwdjl0p+yfyMmf0JoD5Umwt9f?= =?us-ascii?Q?fLw8wynEFIFlcr/FRq/rQhYIC9jjQzEEAiMOTnvWZxxe/6hh3ERKYhQ3/qtf?= =?us-ascii?Q?NzDV8jv9DWf2dA+cUK7oRAFJ2qsTMRFF+SjcMey6XeCw59Cx8G5cm/e8P1rX?= =?us-ascii?Q?7YYknNufqd2OhQtkREviH0+bi9LrP9DBNEXlwjMIW8mBYrlyMmbrYjj33qdd?= =?us-ascii?Q?cjv4/shz6A5XySL0HLAZ8LbI78r0Qxax2bjNuOipkIZMIQI7knRqfRMTfxCV?= =?us-ascii?Q?BenKITE5X1gHcri4r9vmgCqYLYrBhsV7+/xKX722npbtwJbze1OfV/Y5M708?= =?us-ascii?Q?6f7ut/ClG8eXljKSkdPzsBWQT4H8I6WodVSzElyqZeEqFb1Hl1bJqXGFc1c5?= =?us-ascii?Q?l0r5b10vf6EN9MiABF7yuNLw8qnWGjythm8hSDLJWuxfg7ozcwDqsPgVdTvK?= =?us-ascii?Q?81kn4BjEWAPMqAA0/Ll/Rt6fL0gBdS+3QtYggJna3fbE8OU8pIb3M5NJf5yM?= =?us-ascii?Q?FOSDwfvdv/f3uhHuKOfYy/S+JO770L/UPsNLfhkh+eoCImitUcOw/xis2o48?= =?us-ascii?Q?N8TUbjOjp3DNaKlS1J37sf446mowAQrLIZhfHl5wkxSf6y0nnMkwuS4V99IB?= =?us-ascii?Q?4xrleag9iWrCx9MZhz9z1KdV9r5OAfwHLSgU90rNYzfX1Ak7IhITf9DTOfz8?= =?us-ascii?Q?/CCGH92p/cyQ4MI3zYiE9fYpZEkqS47ByXlNsFSC0JljEZXjIngn6Umi4roV?= =?us-ascii?Q?8EZZJGVmO9xxjbEt7mfdE4SEzwltYA9KbRmuv5Lkjc77PPYErXNMqz9DwVII?= =?us-ascii?Q?Kf3Eheaqog=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06150b00-3bc0-4632-ee14-08de8e4eeaaa X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:33.2426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dKhuslLd30VJtouwKNlA+pIzQv8gOkhR0n+NL1sjo13GmrtOWDx2nkftnnkjyUdAbd5rh9jNNVKD0cqXTqqVrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11036 Content-Type: text/plain; charset="utf-8" Add access property SNDRV_CTL_ELEM_ACCESS_READ for control "VAD Detected", which doesn't support put operation, otherwise there will be issue with mixer-test. Fixes: 29dbfeecab85 ("ASoC: fsl_micfil: Add Hardware Voice Activity Detecto= r support") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index d6cde2757c6d..79850211742c 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -503,7 +503,13 @@ static const struct snd_kcontrol_new fsl_micfil_snd_co= ntrols[] =3D { SOC_SINGLE("HWVAD ZCD Adjustment", REG_MICFIL_VAD0_ZCD, 8, 15, 0), SOC_SINGLE("HWVAD ZCD And Behavior Switch", REG_MICFIL_VAD0_ZCD, 4, 1, 0), - SOC_SINGLE_BOOL_EXT("VAD Detected", 0, hwvad_detected, NULL), + { + .iface =3D SNDRV_CTL_ELEM_IFACE_MIXER, + .access =3D SNDRV_CTL_ELEM_ACCESS_READ | SNDRV_CTL_ELEM_ACCESS_VOLATILE, + .name =3D "VAD Detected", + .info =3D snd_soc_info_bool_ext, + .get =3D hwvad_detected, + }, }; =20 static int fsl_micfil_use_verid(struct device *dev) --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013027.outbound.protection.outlook.com [52.101.72.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D73638642B; Mon, 30 Mar 2026 11:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869880; cv=fail; b=kFafAkWq02yJGQTDBMd8le52OCI2EDkwp3UNJJaUovS5oklWpABlm2AR6PfhO+lyVqhpem7d0+ls2bQtvvzX6W8T+CqbjVGXxkAU74WkD30Pmw6kDeSMJ8qfx+cZZfBlGNOphGWJzXuBdmr6FhOYEQCUEzfh9Y4vGHbHC/hqMcg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869880; c=relaxed/simple; bh=0WOC96N4xvo6manO/Shd2Ycy3favvBt32Q3LwDDJ7qo=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=c+M+05JQjhom1YdlvKz1tJzDJ0sM9CiuwxTODnehW+QLxkxdV+R2NlV5AWn635SeGPQn0BaGGR5gEEN5+V20O15IuPgFDMBknprR/0crJrg/LD2BhOxYASf3SsqfXUzKrEvR/doPp//F/SPisJIdjPL43lYTZovZd9/YgLd0l90= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=b49c5k0y; arc=fail smtp.client-ip=52.101.72.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="b49c5k0y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tl3CIzrJlrVw/2V7RTu90EeqyU4I6yDoxdaym1oLF854/GJXqe7j2tR7l6NbCh6cq3bENibLAQ0DzT31RHAwXVoBiZnFW9RLElVNPbg90ZyZLRnOjE9zjw0REXDVxUdYukwgUAemk9NanbSxS7+fIwNbNlL/Ftkn5AyyybbghzIdafOiN8yo9IJTKt8sBxbNW+JxZvdLabkoCpsYb8fQM+MX3i3t/JaVhHsJ2D5/CyEvAsBYldniuO+Xx1Fn1g8vLm0nsGZ1wYNYLGnoxWpKob6g5qMoNrB84+DuxHs0c6Gg59w2OVTAF/MzT2HmGcpyPhWhRRtKjzIHROU79Qbk5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VlIrpXKqus6x43WSMgpfF/1iWwelY/PhqPKK3iQxXAY=; b=k4hWFgM2CZYQ9nOaeod2TxgaR1hdrgqy8DIHL5GuhA9uUQPxRZ6nhhT2Si5U8/t895yn4O5ZBsGf7wGt39BlvwhLM7vNzAuZoSt51JVCQXBUeAUKauzo0FmhHlsWE9gzqB2a6IwI10y64RlaZqNRp+CNxrXiwXxyWLFoRs2OJwjxK0awhBtTDFWneaDQDiNUF17apoxHqNBMbYl0N70WacxGmqv66lQoNQ2XzQy5SbPOtL41tbrHb48UE0AEr1ElGblWHBX4B5fpDR69Cg/zMBX54FK4ibZXVfUnzZDwKXnqv0SZTohd+DTX/n+DpfCTdD8MoxUUxo/DJzou1eQo1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlIrpXKqus6x43WSMgpfF/1iWwelY/PhqPKK3iQxXAY=; b=b49c5k0y+Htk5wMqeqtCoEqGgWM6FwO7T2YQ7Sqac1s3pJUABBkd7nxkCZkLs/xeI75D/g0L/CTQAa9eA/OJgzVKuJgGaAtKDI1z/AI/P99BLLJ8+H91roFETOzQEZGSyz0VGDd7N/+gGS7jT4Nhjr7cJbEWPau+7W9oLD4zAvhLld8yk2vY0iklqCNfqqyHoQka9EWJAqB638ioqQveQThSvu1UEhQ8yZBJMdVaEPx+stTnDYKEKah/PAFFnzdMLfINk+kCJNL8mKeIU7BLparcSIGMZx6fJgQuG4BpnPhUX44pUbK5zXcicEHXG/Dsiy57fddf9rq5Rob8jHvxeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by PA1PR04MB11036.eurprd04.prod.outlook.com (2603:10a6:102:48b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:37 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:37 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] ASoC: fsl_micfil: Fix event generation in hwvad_put_enable() Date: Mon, 30 Mar 2026 19:25:46 +0800 Message-Id: <20260330112555.3637002-3-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|PA1PR04MB11036:EE_ X-MS-Office365-Filtering-Correlation-Id: 97194c6d-1742-4ff5-b642-08de8e4eeceb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|52116014|376014|366016|56012099003|22082099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: p8lgbOa14TNxeoF30VfrN9w4x/JScA/hZazFHAWIdozgH+AlQve0ZmAxnVu/s5HxhvKzNCHAP0PdMzYaysag4ND2gYMRf3tYy3OdMUMP+gQ9ksKHhL0QC8UQGug0qLl4KgsM0t/RvM5p/L9T1uu8UZpz34xsoEgP9u9NBZ6q2c8AGPTElPLma9GW1KlVIZ+AC/eX5o7QpGNjmbN+UHaG662TWQsdlxSgcmvFoGMle6uo+O40NrgRFJv67j7tYJNl/SVoLbEWsDjxTUki6/1cRskQrbwpTV1ZW8tOd6tcWqf6ci5sg/WseHQG5Vgt8kpJxn/PtpytMFaY4k9nrtxZydIuDawnd3XoV0vH8C6LI6PLPzrYzTe5eKSHpb/tApUfjoj71qQ2qzH5j8haPICynDbVQgysSBgpodIdnSu13a9eax/VdbuqGJP7bZ81ib52z3x1PotJGXSZr7pOJIOtzVUXN2YERiweGX2N/ASRL/dK7esgfkZVbmhDEpy5/gDakRRxJ9eoMWj+fu8iWYGH7okzl8snfatU0WF03JtkKWyXsddhuIAdfEhUI6VddQXws9zv07dDm8/yZn7eUSIQGhuM9dsRSH3ZGBeEvfk5jUS1RHLwspvB9kxbGtauEl0Daw2Bb0Le7Bcdfcz6lwOKgwy5epKw5EiEYXNxbnO3vTmlP75tFQHwM4O0XXRb+4Bqbnw0PQGutC1PvRjYCaxqSNFZyqgh9MTWe5KO+byhfm3eBMAvoLugfP584kAW1RX6/GYLDnWwNT1BGn1MKdVqPgNfyBC70rCw0xmyCRAV0j4rH/3IZ4eXXA9E5IHhOs9h X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(52116014)(376014)(366016)(56012099003)(22082099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rnNBVWT2IW9s9zzsn69xe8C70ENdKnNYwZ89F+tzbqZ8B31eNmLBUG5KWtuJ?= =?us-ascii?Q?m6P9yMRXONhv/kchPt1A1ZZzQ0ws++Lt10hYYPX67rduhtIj147Gas2Jg3Uz?= =?us-ascii?Q?K7srCPRrtv/KULCqMoXk5q2qkEJ4XfQ/4mfeqVEpz9zbTBMRxYbE9e+37E32?= =?us-ascii?Q?OLf2sYP6Y6qGcWEqSnd58KoTXoRepce2V5mZaaYHwDykq1kDR1els+TCmIzt?= =?us-ascii?Q?35deN8suEF0wJgwvOI9R+3pesELCVhP3lp+kHGl4v4gBcvJKN1VhxOB6bvhj?= =?us-ascii?Q?4DmOt4B2XLsRJlXuIvo+rMbpFIgW5+JEoKU5ZimtPtvwkduhGRtQoVNqbNZ0?= =?us-ascii?Q?7Eth9t4HXDVfy9e3xPGbD/KdZj+GT94sQxi9UsoLTEcaOrHo/048+t57YdU4?= =?us-ascii?Q?DDJrBOAgozj94UasD1OaAzGUuC/iYGILWWVJhvT3tgqRUSRgbBaoAZAMCB8j?= =?us-ascii?Q?jDbwGlEz/e0r0gkvwhLSX39EUfjzo+cdeiAKrdG6zPI5mwIArLEPKulzN09X?= =?us-ascii?Q?z2jROgdeVSkk7P/CcpG7jUoh57A106JdRl3SZtoVJP0Lw2awNguJ0rZtgARu?= =?us-ascii?Q?JAPImxTa4H62e4Np6frByQHIK79+nFQcWJ0hG3Ci3LPcJgPXaMLJ7XKlaRJu?= =?us-ascii?Q?AfGrWoJ4Jz0gkjL+waU5jfRA7Tq7yQ8Bd2+5k8NBjU3+rttQs3k/2TDHUmEk?= =?us-ascii?Q?R9SkZqM31wGXDh5sx+WBXiivrgrxDKifeUyoan9X8Ep3Ub55cu/MdgXBqKdM?= =?us-ascii?Q?LCd5nlCsXJyQRTcIxTxJ8c8VhVcS3N4SoOghfWjWde06jp3WwmFhbt4/HdLe?= =?us-ascii?Q?J8gvHMgtAh0OO42DU5HZ5lLu8IARqdP0F+HNe1CHDaMowf/IRbwgl4tLx1Em?= =?us-ascii?Q?3DLENx2xcchwgtY21X3Mh2Tg1wLYj0VvtaoevZUEca0OP/aAjjf7ccCNtdeN?= =?us-ascii?Q?722W90fp2SIv3COxeQ9kUuKun5Zv06RtcAHtzIxWIv+OdNXGjB7fKpUib2AO?= =?us-ascii?Q?yZV4SZ10pFgY/W4E5I1atL+GROU+E4e5JzFqehcj9oGAoxJC6RaoPgjEJDqw?= =?us-ascii?Q?Nls64lMJsBpogMdx6eYAhAu3bN1YIQBJ4hlm1+7FEiuQ70NBhZm5FmFmTUwG?= =?us-ascii?Q?ZMBbWUmGkUvPyJQzpTKJOx3pbwUB8Z3CbbsOo8Zg/3kA6EZQQFQso54l4OY5?= =?us-ascii?Q?Jkg6hvsUXXrEazH5NHN7opnrbqf+6TZzi1UkjWDzIKtqTFhg/Z0pTDce8s5n?= =?us-ascii?Q?oQzJ9FQnc2wb0Mst9+jedLPEQZEFxw4NwB8rykPZmP5t/H9PAM96SFt5tMqx?= =?us-ascii?Q?5Od5Tll5TSycTP9OPsyYwijwKMKoCtcZANucDmc7N5a3QuYocdjgOHm8xewt?= =?us-ascii?Q?ucYB9j4V+RAFLdsMM2aQkYb2SDKqhEH6AiyGJufTFMgMY7qfVKJ9L0YogaNz?= =?us-ascii?Q?/tq+RPKU9vgxElmeQ4lYjW1vpYjlDcdcoobrd6aCXzpDLKPEdAqafALho0Fb?= =?us-ascii?Q?JM1zhfOu6adotA82SCWixrw7Rg532gRbAeNsGKut/pAjvjzQXaDmxCJgKnQ/?= =?us-ascii?Q?q/dMFmSFY1EUdBhRqg0Rk4uSrUuC6rlYYFBBgmluiJnF7exAor4tpdmjNGc0?= =?us-ascii?Q?KaGI13vXSy6fwwKdD84CTOukHc0NzxQjz81udN/AYTFkItEkhdmUU7XNWWJJ?= =?us-ascii?Q?C4H9T4JaUYJqKDZQqkq8vKHJh11xpWX0ImmznfMOyrOtUgLV+sj1WnYHTmyC?= =?us-ascii?Q?3/szasZr9A=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97194c6d-1742-4ff5-b642-08de8e4eeceb X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:37.0959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1Zya4cKNnRQ1A40QBYpTIgBjwC1ErTCBjtuN45ciGfbf077RcXkiEmFBWUg12eiV2k8AtjuGWxiiiR5B621zag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11036 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation hwvad_put_enable() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the vad_enabled variable. Fixes: 29dbfeecab85 ("ASoC: fsl_micfil: Add Hardware Voice Activity Detecto= r support") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 79850211742c..97f24c9bdd68 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -377,10 +377,15 @@ static int hwvad_put_enable(struct snd_kcontrol *kcon= trol, unsigned int *item =3D ucontrol->value.enumerated.item; struct fsl_micfil *micfil =3D snd_soc_component_get_drvdata(comp); int val =3D snd_soc_enum_item_to_val(e, item[0]); + bool change =3D false; =20 + if (val < 0 || val > 1) + return -EINVAL; + + change =3D (micfil->vad_enabled !=3D val); micfil->vad_enabled =3D val; =20 - return 0; + return change; } =20 static int hwvad_get_enable(struct snd_kcontrol *kcontrol, --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010068.outbound.protection.outlook.com [52.101.69.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD1F73BD642; Mon, 30 Mar 2026 11:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869885; cv=fail; b=jXdwP6aGjIU9OnNggtUWFMq0iXMl83wK4bUkUFWjEA3Oua+riqL5Ko2FJiUqc6IPra3UF5zwlVgj/2L77FM/wDaU0FsAB3aj9YZWix1c3MIhzqBEtAq4CN4auEATdfGVMBIGxMXIYy1cQF9Zfs0VsDMLKZms6IH9qo709PfHloM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869885; c=relaxed/simple; bh=bc0YvWcAF8bR32JzvTYcwUyh5BvvQ3EAJW56frLTC5M=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=oFutKkTsXiQpxbZISPSdBvmb7GzeSwvNHktueAn3T56Y/QhhpbSud/vByIJx25cwapJ4EUgCm365XvmoyHTR3kskXMr0VP5LLsEvSAb3b0HQ5bL/qtvw+JpVu+UQ6E9VGkPw5sRceUV+iqtpbf0sFSf/Yt9gtV09m71mNkXR+no= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=gqty9s1C; arc=fail smtp.client-ip=52.101.69.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="gqty9s1C" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DyWRCakk/gEFEPTnh0sQ6Wr0NbAmdTYfiGelq2oXp5wQ3B0rRQJT4ZSYlSQ8y/tTfFAOXdXmR+HlMDKrgOnTvabt6PFDx9rt9ZNh495myQahbI04NTGkODCX1etZlx1s+17sOm/64zWIZ6EbxaiQyWgBDsDYH6wL12wlycbyVRInjWIX7MMDr/dAX64so6+SQSoA6oA3MsEvs1f6KmxatOFqXZNQ6juas8nfpHc0s33YP06T2iG/9SiFIi8ugphgTkU1thQwDL0f0ALzeI79BK584dO7sPkf7NiCLr5Xs70m27ynVir+g7xUjjbhHnVZ2mg8LibUoL/DYgEOThnY3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y04GCk7Dn5EiZCT7lizHtIqx7R1Rt2FBz+pto40UiW0=; b=uQArv7xD6XKwZBDQaIpjcKT2Sz+quk+iX+dsZis5tcAl91VyYtstr5U4NzFk6Kp6k9qV06kOMp7AvxBC9gaO/SGJlyX4kwqt4NMd3LpdmiyxIlV0n4bvZbLUrFbHBKt3Sn6Fusj7VnjPMM/ZIVD2prJgw0+2IkPkmQGUkDoEVNXfpg3OIvAkeUbsnalY06cg26I/Cc7Vg4wzyz/NdF8GK9sF3WBeroIiR2yj5DootWPwLHMdhYNbRS2s65gBySJvEZI1GXuD4iwpq7c6E5eJfSJdkaJbzH187vxavOq3clqyJg50i1rCnWm9goSnGPoWXvNqoW6ZHJQlQkgrZh0PyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y04GCk7Dn5EiZCT7lizHtIqx7R1Rt2FBz+pto40UiW0=; b=gqty9s1Cg4+jnlkaUO2eqBcnGimNudayRzwrIEwq7bS5shujhRPDaPGpRnS/CRfqArINmXv6j+bW4uXgIXKLqqW3exrrwF3hYcEgn6w8oi8cVnJFZm970GCGLPPByXKHHsBvMgcJTBnTDW7l6iXBgmHWvEns9pyI9jahV0TS3gqY7A5ZrMZNr4qhCnTYtkQB4OCglf/55CukPiu8z8j1cFHaEBs3i1KjPyC9fhLnoZQFDqO6GO0Rtbxdh7yXdWvr2CuIqL7iFGejjjgBuJi4kM83vgL9F4SPIrT+vSJBPNcFn4U/oVanw6ZFb3I2kk7wwMqgc4n6eIIvHFs9Hr6lMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by PA1PR04MB11036.eurprd04.prod.outlook.com (2603:10a6:102:48b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:41 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:41 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] ASoC: fsl_micfil: Fix event generation in hwvad_put_init_mode() Date: Mon, 30 Mar 2026 19:25:47 +0800 Message-Id: <20260330112555.3637002-4-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|PA1PR04MB11036:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ce97089-9b93-4849-87ae-08de8e4eef47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|52116014|376014|366016|56012099003|22082099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: 32bB7kOFUTXKEjj7o1NQiQuYJl/ZMOGSMgknpk00DJSj+2gMVG25gkSpy8dD/chZY99pRAc3aG9PbYxKBU20cPD9uLON00/46W+YLdWWaWAC8QFiAfEb8ApuM2WuHwVoheKfwy6pk1tqUZwvBOaB+Jn/JkXMHAvwV7862aN5Kj3cQB6h6ntnU8mcgTRzkgdvThso1RJiv8EUAYz1Lkj5kY6GkkY4fcw8HPGn8ZsEnAuPegtH3Fq4D5D8LOUVNeuw3pLJHMQHYfM45veOJvuSMZrDqzUNVOKlt5aTkFJrqjZlsrS8g8GWOvv+2u1iBQaYZc3BxrX4XobkI77B+kyZIO3mVW365b87IGJ5XeKI2Z7FDKRftKSSrIpDK4vpSpFHaoDnArNdmzDZ/DqW5A3f7PvS6sLZVwlQwv0pXY2BXmSRozyRbBzfe7OWmBKsv6mlLxHpTbmB2iofR/PYmZlU24PjO7OFfdBA/NNSuPD/VNhDNLR0exAxqhJqzx7936A36onJa8PZbd52Hbbx6EmkYXleMljA1S+lFqZ3KM/OWvOwj7J2bDkruIQ3OtGke+l4YLUprKigMPUXOwkRuG16UBP/wo1t6EK1G2eHDb12YebbWbnTP5o+CzK48/oZeahpSux+1KLtQpKyAgp3RcgRIc4KOVmDqiTRDQ1XJQX/kfr1AbIAo5GVhhqDUDOXSdAZ5nAdcbRBHy6vu0cRCLixUyMwrELcxFW7WAHSTRjaWlT32eJRTfveXuu/lNVnSjbq0Pf6iX11yBigsnGKArByU+BSXLKKojRFXEmWwkENRjcRmINhKsj0T3oSf/Girkiu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(52116014)(376014)(366016)(56012099003)(22082099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1aaF/59ix8xWPSjGnMWicXCruSqMwfIIoHm73VE/J6mEEF5SrgNMz0QbD+9d?= =?us-ascii?Q?pCRpwYHQ5+/66rZq3cumnOtfJsa03YDfebMAXYr+qBNKESxM9bVKAUtwldtN?= =?us-ascii?Q?ggrsWL37Xclpuwafh/EkQzG06WjKmCrdb0MbJnmSQZvyA/gQaH+2JkDk2P9T?= =?us-ascii?Q?E9wOCYh9M0ql9JTwNMfRDGOwFIBEma+QEfCOy5+mFci/GoxhghJvqxJY1jfD?= =?us-ascii?Q?jxJ5phJ7pDNulotuXY1uMWhgBwVBJ4Qi/92mQl6kJKn4CWoO8+ASz/2iaNWO?= =?us-ascii?Q?HXFemLhE0vWejuhECfxif1UBtnqDzRqonpgYJsI0nlCcLrhcC1f9e2luhqMQ?= =?us-ascii?Q?qOTyMIeKOdliLCnQH72frN+ijYmHQBJIRVfUrZL7xHERG+7aua9MEJpFFOMM?= =?us-ascii?Q?6ELeNS4ZLPEH3hYIdIAJjWQvsp2mkyQrfPF2TGwIfoKCzajCtuT+FJE3Xk+F?= =?us-ascii?Q?ucG8KkIL3bFjUsDEDMkKxro4ja764FrgvkrENgHVRtwKBmNJnRSSb79A2ROU?= =?us-ascii?Q?DYqKrqNIK0FtTDWs4Yv8txYapbERXcoJTMrtBU8K/ntYaUdYGb+XcCD9gjzy?= =?us-ascii?Q?cZVW1mxtK9MykHqfcEt+wiT+uHBXTN/BDg5ZzHoyXu+WgbiA0LSOQ13MYqAi?= =?us-ascii?Q?wdRNR/48T40FpKSzeGdn+lNHkeZr3tlsJrPMQjYw9nFrCeV4zOuem4x4tIXQ?= =?us-ascii?Q?atQwky2PQF9I1bTZE4Wv4wxTrZn5ueUnieOsfUqi4AkENqvZDp0Epipj2NpE?= =?us-ascii?Q?07tAiidCeojIXFAc6pZ7UX/wzcQn7Nt5A5/ZImtR+tCYnlilvJfImm2SezJs?= =?us-ascii?Q?w7wUGmlhek8B0VVjYWrGwVFjGuu3qS+Ss7+Zwzji4riTwC+clgwoWsVlSZla?= =?us-ascii?Q?2WtcGngn9LTngBLJoM4rH8WNQ1dZOkTKjHdv4vLqBSFBzyOdgt7UiSOWKS9T?= =?us-ascii?Q?Hnqg3GDXveLfBcVWSYJoJDJWudBxWowz0dpbENC8Mkyf2/dq2mA3gRHEHruG?= =?us-ascii?Q?au/lmIgc8zqm8rbZRAyEdDmnNbLF83CtRDxAWRFpY5APhUDRFBdBCpDJ2CUk?= =?us-ascii?Q?whhuT7NsKfy37+TnnKhp0PTUl65/QhT8jaBiB3kr7/OEqDx5vYV2q30LSMhs?= =?us-ascii?Q?fpZSs1Gmnd0YzfhVPyY2veupLXHsHM92xlFQfmUmIPspgiHXZk4V95MVK8vF?= =?us-ascii?Q?Y6FAOniqGqth0QGxGhmmMxc1myryy0+pyIteKp45Y2a1OB/q43fa3miZTz/w?= =?us-ascii?Q?5REdEmca5U3iqBQP363GUm0Bd7JCwgZmfbJaeK08hkZmNPQXiRH7WWe2tre2?= =?us-ascii?Q?KaxlPuoMRzgrKm6yQZM0TbdI9KIqMdYNwD/wo7FOl6FviBGp9B8V0S7wNpdH?= =?us-ascii?Q?0TbP6iN4ZhiD/q9AecnMllaQccMMrjk68JOVF0GEwl8K9HlitY/U6P618Fuc?= =?us-ascii?Q?WVt/eWMGHi9EQdLfzMYnnQ8EILab13yEMXH4eepipiUj3JjT2vNNiSm3l2l+?= =?us-ascii?Q?WPf/qp1mWu3xu2dr32S97jEorDRKB9Qv2KR8Hie7MKQlXRoRYgXBsyfqCOga?= =?us-ascii?Q?SXO3kDHY6CZyrCuEpD4u77X7MZCm3C6+RAlXxdPrWkZ8Vbu+bPPRnYAeESjQ?= =?us-ascii?Q?8P9ri5KPs97PH19JxwGo8isdeeyk+SSRHP2MavgRXME7KtAeZVkT8ieWvWsy?= =?us-ascii?Q?gtPMhJurnc4V1QiM98TTZ1dAOwjaTUy0nwroYCH16aB+xtHqvu6AJYjPatZb?= =?us-ascii?Q?WAI092t9ow=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ce97089-9b93-4849-87ae-08de8e4eef47 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:41.2170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qrSRTZDYHdbFK2p5lgKeSu1zJJCNQZ90Fc7Ixs1cJULthS8qKTyGtnw1wMwXgnqG/a3y/s2s7Gf82NUq1ndcvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11036 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation hwvad_put_init_mode() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the vad_init_mode variable. Fixes: 29dbfeecab85 ("ASoC: fsl_micfil: Add Hardware Voice Activity Detecto= r support") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 97f24c9bdd68..1c826e0cb1d5 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -407,13 +407,18 @@ static int hwvad_put_init_mode(struct snd_kcontrol *k= control, unsigned int *item =3D ucontrol->value.enumerated.item; struct fsl_micfil *micfil =3D snd_soc_component_get_drvdata(comp); int val =3D snd_soc_enum_item_to_val(e, item[0]); + bool change =3D false; + + if (val < MICFIL_HWVAD_ENVELOPE_MODE || val > MICFIL_HWVAD_ENERGY_MODE) + return -EINVAL; =20 /* 0 - Envelope-based Mode * 1 - Energy-based Mode */ + change =3D (micfil->vad_init_mode !=3D val); micfil->vad_init_mode =3D val; =20 - return 0; + return change; } =20 static int hwvad_get_init_mode(struct snd_kcontrol *kcontrol, --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013011.outbound.protection.outlook.com [52.101.72.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9832A3C3BE5; Mon, 30 Mar 2026 11:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869889; cv=fail; b=eJUD5oln9HhOMKpkHsY/oSDsOI9AZzZOKBGItz1PWQ6hQJvGzerV6gNPh+52gOPMHiNlyxwXnqcc/PIwa894jJLPAorYV5E7QganelnBkUQ9E2sOadPo2G8dfNqRxhlQ3PYwPyqbt46ONH63btlPVKBjUWNJFAnwRubArDB7F2Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869889; c=relaxed/simple; bh=eYMFVQaCAmuTgSX97pLRtA+GQy7mr0h63BXRTT9qpqM=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=QcKOvBojFlBcC7wQMXGFOi5d8bcSujohZYY7H93j13A23r6JjazS9QRwD7LXHE3CU54o1RnV8+b+kZiVpEWJcr0Y5uUIc3Xucm7G0zkFRi+4ecKDaCmBPTrWj0Ko2I4DSCR35+6marXMYIo/tBetkQpO2NProHuZmHkN5VbL7/g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=hZdDHnb5; arc=fail smtp.client-ip=52.101.72.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="hZdDHnb5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TrOTJWEfTJHalj+1qjn5FTMJ9JGbkut/OxzmEsjHNB8eL5gwqtMGWGIaUTDtzoK5IhuQ7hzj8zIpka5F3nKY/+pbAyS6iOamMKlAcSEaZr9/wkNfO8Yi0pdBGynLWXrGCUiAIzqL7JsX/YGaJzV5Gq5MFNSwmQs3yyW+z8CsF07gmpTcMjjixbw3a70NQJioBDTYYGzCxVUYTR6sn6hH5J14uNm1zDO5XxEb7TtrFW0qK/MBI304NX1S7Iq4UVPZj4wSNsOAvxH8cOHynxB6CpZEUM/f7C4N+2ovvai37hDgkbB91qQREviibC1Zkt1VwuRIB+7tuJljOSNxeX9EBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FmrTItx47rJ0HdJvNf6wHuSfObpE19m86nMqe1jrQsE=; b=pQitCvdpQYLl79NE7KdnEcLYIfIvZoBXyHH5SG6xNQthPiZvySG4c0hHGEapNIcIxt/ezEU0JF2rz0NOAJdO12nzB9R5xKKrLYqsEfh+W2mFgTRMv1uTrCmSMtoz8LnPq70DHhQLgn0cqkfYSDX4PBOWN1XDxk8ancwW9gDYAuvETgdIedKDRUsWoRYmGAP35re9cDTB5gRgdNg158nNQbR+cR8RD3skTSs6vMS0YkTYa6tCwx/S64RR6LYVRBWa/q6A9z+rCpK0Ivsl/etCEqGfdH3DUTlVzuuikgbxt3XNyzS1QlzILUrgBeBdvzZoHSYUBa1yISGsngy2hE5oaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FmrTItx47rJ0HdJvNf6wHuSfObpE19m86nMqe1jrQsE=; b=hZdDHnb5tUDbFKZigHAsRtJZ+Z7W/AXhh09Hb0LcPIQ9mluNymyxX9KrLmR/Z2QCRj/HF1hpvpdF8G/JK/u11Amry7vrnl1Bz/7jlhEzvAX6a1PP4FT/PCijwugZQ5rzIByFnJTOXCsZdzjp9T1HmvIIB/1rTmE9JnMf+Acn2nfRll0irdvIg1PW2aP+B7m+4SwyKgR5kaHcM5FnczzduQvoLiwG78A4fB/fYyO1G+9lQwLWO2epwDQ0oPeCrFMaMAiWWPT8K5i6a7jLwmeEbvYZVXW6Ov0D8Elgu7ZWMfzIcAAGTvwGXrcrp35TXKkDsAgdVCvemFr2GUlzjyb/Xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by PA1PR04MB11036.eurprd04.prod.outlook.com (2603:10a6:102:48b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:45 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:44 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] ASoC: fsl_micfil: Fix event generation in micfil_range_set() Date: Mon, 30 Mar 2026 19:25:48 +0800 Message-Id: <20260330112555.3637002-5-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|PA1PR04MB11036:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e4e95f7-179c-4613-9a56-08de8e4ef1c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|52116014|376014|366016|56012099003|22082099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: mbDsMCYUwLex/h0F0ial4DS4ticLgysOQhUON2/RpNX64waCgrD/jTE1jKRJOCiBu9GGuYlsvU0iyH6oRq3PcgO2sJPYqAznxkTWWsRNvTB7JlRtrHY2oPhx8XSn19iYfLbQTOFo/9vvl7YfsS4tuAyifD+WId9iJT7Bt4OUKmoSyL9npzdYWrrjP++oCY6WlK+D2q6e3/pmapg8oHg74FEKPlTBKRy38Cp+eD7sBkRvPusXGDZWE5CGeFbAk2EdLYLfpT3vgsqV4z5dg40Ok+SP1iAalOX0fh+6MPxX4cJ/iukev0RuinMEUEc6d4xdQPlahqNSVI5qur/W3XBTyly/sDd8RpKCheoOhKMlHfWrCoepqcNyPRtfH6tOKX8uiEoUL7JpNNQTjhjOJ1NYawlOkLOlvfDEphL5ikYKg8eD81VAz5T0278c3KNnigYsz6nHLuigZGuoQVxQkd5j6fVBeu1cI1jnHdShhB28dMOFSvPpgSz2r+8SUb5kjjFL9NURcTEGKNjY6/euKzPnD7qHuPTmZSEcUqjQUW8O2bhDYvkekcJQIv30s06yESx51vRTq2jyIXNC2pneMlrMRCC+NgeDofOLI1OJh8zcx2GA2sJj6xM3jSa/Tf56jYPkjhuqiA1mGwztrd4nGScG+84KVq+UvdoCJ0Rq8ZiJKE0XDxaiUIFa3m+TdpqC5xzDKmf8Nz+RRMfhYFmjNxNv7vsJDniENQ9zr5Ym3qd77X4tPJmnWBWgkTT6ovoCWnROjWGJHCjkj1DOm1vkckKyENy7LSh/v2schSxpcE06bE/gixqnK6977gM06vJmRtPW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(52116014)(376014)(366016)(56012099003)(22082099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?050cTbG6Cm/jlDFQEfbC8czzUDHj46MGCyrQKYZppT6yxaZ5y93CBWRhzwOw?= =?us-ascii?Q?AV2j31GEd0DRZWwbijL35bj2j9zYn0TrEOmVKTdnOd+iCwP5cq2Gspda5jSe?= =?us-ascii?Q?bIIsRej4/EytGCAA8aF371qEHgHE8Nsex2vdo/rZnu3GnEEvjELhl7BKWXkK?= =?us-ascii?Q?NO1GQ5RmiPueG8kEXYU2Mf9aMPWz1epJcOcdklhEo+pmJoVS4/Jl7vthRFBm?= =?us-ascii?Q?/LYwZj9NX0pBuJDfAuY1JJY+bI7vUw5rLBU16U2TJP5wL0j9rolv7b+g5ZS7?= =?us-ascii?Q?LlHPlsYgIsAQ77nlEiYLQ9YSTzr7aPBOwbI0j2lrt7Hs3tYzvVP1rBviDy6u?= =?us-ascii?Q?yMj5V9ympLsjwJzR1fUriqQz58eVFQXl9ty0M6gyANhyYKFg07vN8rBGuWUe?= =?us-ascii?Q?1lu4n9aGNbaEmiJB1O4/GjaonWEDJLdrB0z3MnfgQBi/09ozBXCsMTs3O2vC?= =?us-ascii?Q?ZM8Va55Ls1w9OAxmOnRQZwhNe3/BZPYXiWo8s0OwokB4m/mQTxVUegIAkGG3?= =?us-ascii?Q?wcueh7m9Cts702eS53Ia2UVIgjsCsU8JKAdMvFeAhUES9a34giGV3TafmwIs?= =?us-ascii?Q?gPJxm53clrK+qurFuw/7S38e7irQKgI2GwyNa8QiPRMH6sZu3sLdvuI8seSu?= =?us-ascii?Q?7h/nQt2slI9kJs4/IaR2olmNcRqeVyIOSpwa74jB8/+FYAENjAmD1/kgGdWt?= =?us-ascii?Q?Ewv0XNzLZjjxApLH2p/mWCi4NzhjX/Uc4rf6t4UmxaFAL7JGtjusy084bc0v?= =?us-ascii?Q?TUv0LWCR/j6ZBOOymh4TjAAa2rSbDSuI9wuoreZlBdHSJCpAgeJbQfYWzueR?= =?us-ascii?Q?hy0JLZOVMaYI7D9Z9Ez80Ay2kOLW8iz8YdjLwdeNl0lw6XjtSFtMQNz7TsRr?= =?us-ascii?Q?J4E7yP8NCCeUSh3UzqGZ9CwSpU4m2CDUFKqJiYhc5f9+rmJPlgrkqnPyim9c?= =?us-ascii?Q?Rpsb3WGYZ0b5+DL0IUWG4XeQ2n4e60umFHD5DoE2ZiM9XuQ52F5EK0NmExz7?= =?us-ascii?Q?Wld2DpUzRSUoRu7QXCy/WLwXJIxv4/as/oEWWNukYzrLtGNmbXndAR1TMcxO?= =?us-ascii?Q?Ft/0cgptSEahJh2g50ZnYi9EkbC+ht7Yp7oJlWGLZAfwtXyIXOGGXpK7LgcF?= =?us-ascii?Q?W4PHdin09jfLqeTj/YKM7jqtHPPsHbGaBZK2vyG1Ia7ESEVVWYPBuW4cju+d?= =?us-ascii?Q?sr4PkbMJP5ZIviV1wkqEAgWqy5KYxdXgXwHYDcaXWE94ltYO2jmUEXiIhyEh?= =?us-ascii?Q?AJGwTTzt38CvMNZkppsYz6zmzsHHHdZgC89otuZK5VEWj+Vob1+NxV76aUCs?= =?us-ascii?Q?EPUWmAofH9xCgI+aVqH3iZ2+svb88/4dTq2XVfCr+xajoeb8OrIDysu86f8+?= =?us-ascii?Q?ZBc2eVwKagRU+q8A6wsw0fwBHLPMbVg9enXIWKDhEBZdNwpk27t7vPWKmbu+?= =?us-ascii?Q?x2mlZde10JO5rDm99L/qlZZlxq5gvN7slKkljmOHzbNNTojvRQrNlctkTrxn?= =?us-ascii?Q?2UsxKBbXlJ6a3eMMUbp0QRYyxhPzPbNAIWjl5jeabUrhWZkcT91HanVR9ziq?= =?us-ascii?Q?d2zpDN/4W22sMYqwMHL0WhhpdHAj/iDdsfLMjd4we6CQdbD1tNYcojbqY8Ta?= =?us-ascii?Q?/uNbIl11BtzammD8YFBGoK9GgOF11EBITxp84tB0UwHn9OEgWs9PVsSGr6M7?= =?us-ascii?Q?CaBJSjVVDiUCATxGPH2KN0g6bDDRyUz6i2QwvttEBZDIWj0d0gSOmJ8ctrSN?= =?us-ascii?Q?ETMRAD77TA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e4e95f7-179c-4613-9a56-08de8e4ef1c3 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:44.9015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yyn3h8Gvc5m+5Zb1qy9bYF9bjR3ij9/IkTGWywfUwRgG+LorjTxlzdcZoh9JiEjSY2pBaQRwGn47mG5BsDc+qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11036 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation micfil_range_set() only returns 0 or a negative error code, causing ALSA to not generate any change events. Use snd_soc_component_update_bits() function to replace the regmap_update_bits(), for snd_soc_component_update_bits() has the capability of return check status. Also enable pm runtime before calling the function snd_soc_component_update_bits() to make the regmap cache data align with the value in hardware. Fixes: ef1a7e02fdb7 ("ASoC: fsl_micfil: Set channel range control") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 1c826e0cb1d5..0cfdd6343291 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -210,15 +210,23 @@ static int micfil_range_set(struct snd_kcontrol *kcon= trol, (struct soc_mixer_control *)kcontrol->private_value; unsigned int shift =3D mc->shift; int max_range, new_range; + int ret; =20 new_range =3D ucontrol->value.integer.value[0]; max_range =3D micfil_get_max_range(micfil); if (new_range > max_range) dev_warn(&micfil->pdev->dev, "range makes channel %d data unreliable\n",= shift / 4); =20 - regmap_update_bits(micfil->regmap, REG_MICFIL_OUT_CTRL, 0xF << shift, new= _range << shift); + ret =3D pm_runtime_resume_and_get(cmpnt->dev); + if (ret) + return ret; =20 - return 0; + ret =3D snd_soc_component_update_bits(cmpnt, REG_MICFIL_OUT_CTRL, 0xF << = shift, + new_range << shift); + + pm_runtime_put_autosuspend(cmpnt->dev); + + return ret; } =20 static int micfil_set_quality(struct fsl_micfil *micfil) --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011059.outbound.protection.outlook.com [52.101.70.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41B273C5DCD; Mon, 30 Mar 2026 11:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869892; cv=fail; b=e5V9zDRD/TjocU5Bd+p2OCnSSiGmXwradAg3MaLBJXTa/CzcM/mN5KRPcwXYj3X0Hu51I3ouGzbAP8k/j/sn+BOTnrrYVRWLVZ6SWtIckVWCcwz1nSWqaWGkln1HioZBR6KFOfQrhKrhqnjXmtt1Tl5AlNYzOEkDZD7AkR9dZcc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869892; c=relaxed/simple; bh=vBQw3ZG7rpuuLWUReMNccXW5ZTCfv/VY/nlCZREKNXc=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=aVru4eVZh7jkwHFsVssW2/H7A18XjK+7ychH7zL7BHeE61ghW2+qCnIU3HlG3sVOFfjGi+YcN3S+VzkUiYou1xjnYQUgHN4MQofcaHYU8+bHuBwyW9jUNlKcNZoNQjNfGw1HrJGTAMGgXlsfn1h6cM6o5yRO/JVZudmq1a1qe9o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=oRYoUfaB; arc=fail smtp.client-ip=52.101.70.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="oRYoUfaB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LE3fI3mE9WgB9v6XgCJj6pjelZiwuZsIYnjChLMT4rLdbMh9ZfyXBz62uc3DVirJMRrCAYzMtoeqLdXDzWNQb7CeQJC5HUixvJJWb7ySbVTapCy5ubdRlIyFl0zIz+BfMEsC9lT+ghipH5w6Azul5DdhrahzSmC9hWy3t5FbFum7nXWp/De83HQ6X9sKvqTVJ6TlomLgEpqbmrux7NeY+w6TL8EQbpH4RWnMo7Pc5a4PCPXkDlw4p4RPyOtFHEeu0ANKVhVkuMsi/OC2M/CTvKtSIgrbWp+iruYv0m5DLXEkSO/o50n18tznd90jvknXZx+dSN9h2Wv/djGOClNO6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=haS41qD/fAlt8cHSvubSuj5P3Zr9kdx2zsfBPqlcmMw=; b=qMTcEO/8yuKZHzR+d4hCMlWVR9vUaeKDbKTIPNHQKOIE9MyIkUi9wNqKmjklEWoBC/Ycn/yJdb/RFvDU9cjzPMm+1WjQnF993E5ma2w2IAxEDgqLg88yA2oIWkg6pnVtX8yM38XmlTwpfeUZPABXd789T4bq6JS89loQ45t9wg82aD/NJih3LAZFJ6tMG5j6W7ZsB80PZAkiD9iHc4kgO/W8MsJjwiUyIHWp5fZxgVF1nQA0JsLfnbnqcYeZzdwqYngT4tVDUuvwZ04CdObYlXwPrfevUMRMDqzjqu/PpM9XbX379LdzH9I2D2KfRv2/C2CPR+GDouA+vD/QpGSsMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=haS41qD/fAlt8cHSvubSuj5P3Zr9kdx2zsfBPqlcmMw=; b=oRYoUfaBVoydTJZ/tkUvIsT1nFVghXy2vu3P5+tvmE2jvyJ9uQItmXu4WMjiuP9es/iAR2KR5a5Q1lG3CVicqoTUFTv5Qn8R9NTkY+r8AvYzdXJawRL8x7QCLPLnj7HrudpoBFXeIM037O94pcTVt7pIckXdmEh3tKloyQbsiDTPB1XMNhpt42QsomN6zRTtCB6bfJ0kMh7ArH/WCqYY7anhdoMD+eY52Hy4jRM7io2vTDv1+Xjsg/AGTKDMM88Y51WOIaOYczazCIQNyJ3Lg04sIXbTUyovIi2PLIhSf6RYI19Qtx1JvYycb23GmDLFvbCRFOWUyVwM4AoNNy7iQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by PA1PR04MB11036.eurprd04.prod.outlook.com (2603:10a6:102:48b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:48 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:48 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/11] ASoC: fsl_micfil: Fix event generation in micfil_put_dc_remover_state() Date: Mon, 30 Mar 2026 19:25:49 +0800 Message-Id: <20260330112555.3637002-6-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|PA1PR04MB11036:EE_ X-MS-Office365-Filtering-Correlation-Id: 28d63676-e1e2-4c9c-c7f6-08de8e4ef3de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|7416014|52116014|376014|366016|56012099003|22082099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: RmpFCS1ZlpfplBSV39eqWH3rC56OVeDLUO87BmVipI11k//7pBVCeZLjJpJ2/4px1ubI15PReWP5aQnLvrvKBzzLsd0bXaTcYgNWucvBWcx0zT0dPBEHcACzDwANg3uHeys5+zkslD0O3tUT51LDOQmmxxpZMdomz7UF9DWoiFLVwbGRhsB/E8F/tnyFO4TRasmEoZZJCLgVEw3nXrAM9VQY20I3Uhu4Rl4v2Ri3jvU9YcTErFV9ia7/oUgTIVYDdu0T4jsTRr9fY6a/an+kn9L8XxfW5XSiA6Y85dKQ9X7UA6Umt/H6HRUY2SZYEPFURkqCjfvWLdXDUefQZOIR0QRV9NrgjM7psLognJxJLfeFHJhyh9f6pDzYyEUSY6vH5kdf2IDSTEmWCjr8sY1llek43EglxEQoirYGbCbooU4BYG71+02o0Fyb5pcANiFm31+XIDSgN8V15gxhUU58Kg7udUO/M00RVAX5fdhK6++Cs/zprhlBKkJaEzKHnUaxYbPqXjmHCIelniho1k+T0EGDBf61/9UVmdpOyGHxrIm7mwptiu6h8sPwxdfajqJmU4CHluo7rOEeRCSgJ5PnMLYJKYaMQgQAVYB+zr1uJpe0wun3Ek0wxKnqIsI3xfrR7O0jxFaPSutdNwLyZ4PmscurLyW4qdf86RcUFluXkQfrp0MJs4jUGWhYP3ymMS6s/LkRZOv/rp9fz1O2ZAsrI36bOyi8wnW+bIXl88Vh+1ow5Fj4tHKCUaI5iV2SI+vpCAO7oI91JKQPfVzuZC/VsGFJwUamk93/YEtIshOLCfJ6jW1HnH189hWmmqQqFcSv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(7416014)(52116014)(376014)(366016)(56012099003)(22082099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GOjHPfpZHVkis+75teV/Fhv87NTb31KFx4aLwfLh8I+qHUmTKU1Gt69uMBKo?= =?us-ascii?Q?wijPwoI0bBexM9JcoyqwuK6VYgbCC2Sy8feJaM+lvqrrgfW22NWiZSTOqi4C?= =?us-ascii?Q?Dk0Foi9FgycEDx1x0h2zfUi+rd2brF6Zz/Fz0BXoWc2dPQmVH0pqFyNyloMc?= =?us-ascii?Q?KfgbNuvwCwP3RITVtLG3k34ULAsdSiTkI9RlgrZCQ6G3n2YHOCiedNvU4On9?= =?us-ascii?Q?xrf5b8qNBgfyPugQb1wH7iNJ6l/5MS6kKKn1sazmmvKex29cV2D3KiEQrIyv?= =?us-ascii?Q?SbOs9Fr1tB0Swll0jHACZBydF/62EAYXQ/P0j3aqO8h1mNZJymBFnnwrFTCg?= =?us-ascii?Q?YQwXtAaOcNaBrAT1YzANEMOf2pY+I8/gSI55smkNaTaM/w76wuxnwawhrqjf?= =?us-ascii?Q?lI73dbyIKh5KlCp2wbLRVl+BsAzAMsXZdi3L3+sR+Gj+2ErqzymU479cUuMx?= =?us-ascii?Q?ZwqzyliJsK3xPpDd9Qm1bKkaRicjy3/C8jru4nwPgnJw0aEUY8fum6qtP0M/?= =?us-ascii?Q?/sfC/kMl0CK37ThY0Qbxg2USk1yoq4Pu2V8YxAYjidzW3OjrQ+mLyGYo7Xaj?= =?us-ascii?Q?slpOYltPlxg5pIBS794LzvQY7LjVGQWRJoeu2Sh/i2FWPzeK0fQD3VQkg8+R?= =?us-ascii?Q?JoZhxa/yEugFTosNagXr2GqlNs/7AUwPLaSLHmyGL2mHpGPuDYeqpc7Zy6Ey?= =?us-ascii?Q?8yYYl2eXUJrrPAzywyOZ9go5BPioIGJ6AZ99yasciXxEHHiFJGkQ8ipeQWEo?= =?us-ascii?Q?7CILzVdr5sp6KvcsPClZ4qysvctDq5dZyvZN/e4XeO+TG54pKaDot9sBhCG3?= =?us-ascii?Q?h2rRt/cwfIgmPoxJhkMt4yosmTd31LAlZHBgiD679H4IOMxusnMBJnlT9OsJ?= =?us-ascii?Q?KG9zChE1F4rcOA+9GPJvxEYpGYFI2s0yO1B7pNzjZ41Ss0bTHap8/qdJFHU7?= =?us-ascii?Q?ms3hVhYrfgn0L6eNpzj8UWFgoWFHW7YMGXSxLAC4U9v85Mq2eiT5i/AEtt8G?= =?us-ascii?Q?meaDll5btagg9Wx/uPvzii8bVRi7FN5ovXYbhH2nkVfqxhuun4WP5fOnYpBz?= =?us-ascii?Q?5x4JgkuflLYyfcswvZQU4vhyEwelzJc0r00q9+dw4iZevsOKaPYw79kdejXn?= =?us-ascii?Q?K0yGyPT+jhsBOo7r7JYMVJWw0mt83xJr6WqoDHNZ6eMmhd4TGFL8xtEbqFpK?= =?us-ascii?Q?AnzzGbeGPnW8w+fRiAWB596ShBH2OWETVhi7LlSouMoG42J2zyHjTfbo3TTF?= =?us-ascii?Q?OjhdM86cs6dcTteDUmwTp4pP/OuuKE/eJ6QvE4Md6iNrPFaYu+Qj1sv5ldTP?= =?us-ascii?Q?EHVIhMHplPk665vvoYFZ7j064G+Wxk4Rx7WbTjD/K1AvJgtB7EyAbVRvb7UC?= =?us-ascii?Q?RRGlrTVK9NUyAKo85h7DZeFWPje+5WyOZsv26T4YQMjAar4y4Kz7h1W1w8up?= =?us-ascii?Q?mlEtZo0g+loW39ZiZC3O7qO+NJCcjRfSWrj9U6qBenAGV9eHXkInct8wZKHu?= =?us-ascii?Q?anUBXTs3kNbcmMZr81e9BnA8AFmlNwuZp4pPCQBxKku8Q5yYsl9bT4j5pGc0?= =?us-ascii?Q?lTlqb5OmquVWFoGrleASW5XG5YWEmYmN0Wo7M5MYvXq7Hx3PQCDqSYmiKRJj?= =?us-ascii?Q?ZgKAizmOWxtnSaKti93pONXviExLdL7IkLmCqiox3wlscZr+DproipRhV390?= =?us-ascii?Q?c/JBEQi68HLa+vefvRLHvEAjZFvrKiyipauCPUVPiVehivPkeCxABv7ffnGW?= =?us-ascii?Q?NLYwnbabHQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d63676-e1e2-4c9c-c7f6-08de8e4ef3de X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:48.6315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xesnZ50jpj9od0BNCVGWFeJLCKIqwUm/V56ZyLfD/NgI0L5U0E1GysxqbctqTLOuUpysOB2wXGLKY7gsCVNWvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11036 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation micfil_put_dc_remover_state() only returns 0 or a negative error code, causing ALSA to not generate any change events. return the value of snd_soc_component_update_bits() directly, as it has the capability of return check status of changed or not. Also enable pm runtime before calling the function snd_soc_component_update_bits() to make the regmap cache data align with the value in hardware. Fixes: 29dbfeecab85 ("ASoC: fsl_micfil: Add Hardware Voice Activity Detecto= r support") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 0cfdd6343291..983805bbaae2 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -351,6 +351,10 @@ static int micfil_put_dc_remover_state(struct snd_kcon= trol *kcontrol, if (val < 0 || val > 3) return -EINVAL; =20 + ret =3D pm_runtime_resume_and_get(comp->dev); + if (ret) + return ret; + micfil->dc_remover =3D val; =20 /* Calculate total value for all channels */ @@ -360,10 +364,10 @@ static int micfil_put_dc_remover_state(struct snd_kco= ntrol *kcontrol, /* Update DC Remover mode for all channels */ ret =3D snd_soc_component_update_bits(comp, REG_MICFIL_DC_CTRL, MICFIL_DC_CTRL_CONFIG, reg_val); - if (ret < 0) - return ret; =20 - return 0; + pm_runtime_put_autosuspend(comp->dev); + + return ret; } =20 static int micfil_get_dc_remover_state(struct snd_kcontrol *kcontrol, --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013055.outbound.protection.outlook.com [52.101.72.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A11543C73DF; Mon, 30 Mar 2026 11:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869897; cv=fail; b=C97pcr8faz4JAhtn2yb1sPrYq9EDZbcVYvzZBVuBP3gvyCIKP5DkdITt30ealvAUSKAsD9onMX7S+3/s+OZdXFXyMCFPRvhP1iq50glHTI82HDSwhtzroAQptzICF6JBM6NeKdnBDo8kNLi3u/dnHYJKv+eIz1etgM4jFWeaPbA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869897; c=relaxed/simple; bh=aBA8GgaliWchNnTrDHeATWGIxXo6wFBqLqskkaY0O1k=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=OJVa3333SNhdYmJxM8Uy+Ydi7GsSjLcu6XBD1Xjq52v45Kcz53pGbxEDoZQraoP4RIdvmEYVDSGbcoRDNa6kXoflcuRao0ihnpS5PrJN0E9rR/fn2N+SXJ/4Zrwq2xiN25G6HsR7EtWxk8zTeVhD8ar8GkYtA+yqvMeRqzb0hFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZUBOhjKR; arc=fail smtp.client-ip=52.101.72.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZUBOhjKR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GYjaByX9Fuq48Np2vFCdPKFhk8iSM7xj+w16IfUUVHhjVq7iafZukLKVlYn+3hsGP84tlrj7qMIkHkMaK1UOeaBge64g1Ld/17Vvfh42J6tWnz4MQIovv1jwnm+rttuvYvalJpcPf4rL4jLrvpza3dJfuhWD7lQjZA9i4MvuyxTwCYC2wgEkEIR/jd+Nqif13+aAmEZl8+xiaMQb2sG/d+nFlYRANRlJrKe3poLNeMk1GwTlmvDkCw+wxM6bdllNXWP+7FAD6q8D1lAkFO9i/mPSNvFMIVy2yivSuYdRok6AFRRrrShPPn9dW2tbKEq/OxM5skrUl2QePJujQhJP4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Oi/2KTsaG7nxKIQclwlTR7Vxue18R5nbgO2D18qPW4=; b=rKm2ipzMtAEubDSrtAYzP5TBm8Ih9meAQC2qzCKiuF3dhOSxRgyVoxV/VFpjb4sYNFxGkxoE/ZsXPOg6NOZTvSIkRgSO+hVkIUKhTmm2BOYgSdLgD+ly7MdEmhlKxT79hz3nbO1bE7PQO5aA5dVuErkSZMs8Tug4jXtfM+6fb62J6mxl17KSizPjZzVC1P7Bw4Y3IrHnUTOR2aZsbJlZROsMziCBQOz82aevhfnMKpHbHIpalHidYGmGz9AxsuEJGgY7Muiyvr/VfEja1PF/3uyUx1shj9LR2ezxgW4yRXlxgCU/qCdM7xn4qXnuKO5FWfTafrOp13gG8tmoe20PnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Oi/2KTsaG7nxKIQclwlTR7Vxue18R5nbgO2D18qPW4=; b=ZUBOhjKRLEymJclsNCuDYLW4maF2Gsuf+kCiof5JfCb5b/1M7nkEdRBjB8LL08uoMqqVgHwUhHZWA95WKmNnI+JhxZXJ1CU87SwB8j/HsDbmDGV9+KCtc2yhJrfYSLsp53AwkNRL/il3bh+OQjb6fjA3RQvk90ZdW7SCsZitwIhSdtCVGI8IUJbRm6vMSIIKwYPCb/NoaiZorhjLqoLl+/GMgQpCtboAspsx8gOIR3pVuh4gExS3ONtyYBw1GMWSLr3T6pPdzcHzyebifH27dtfKp/SdCaB697cfHRLhghvKXcvRs0/hXFbb8g6tJhXF4Mh6lsUJbCutttipH6nPNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:52 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:52 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] ASoC: fsl_micfil: Fix event generation in micfil_quality_set() Date: Mon, 30 Mar 2026 19:25:50 +0800 Message-Id: <20260330112555.3637002-7-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: 66ec4dd9-62d2-4f1f-1a11-08de8e4ef620 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: xfVC3Q1KiBeV9mQwUwRbzGhHFscqVWXIBnvf50A1grzucKhyZOxvloI2nYyEErC5P8V+dNPRe415jeNMIenifOh0XApFXac2H5Ke1kvbhTJ2FX4sWsOxZCVQyTry+uSphCEBDgD1ijdUnUqnWkEDpbDlTHb0hNLzOEMoLj/b5E393+JJIwHkb4DqOf49CmnAuD3tZ9Jl42y4JPnECZjWn8No0T5nrL1mlYk2Ng4fr87H7Z799BeGE9E9zkSJ3UHOkn97YhixdpMgoaYYJgvV3Pxt8cLzl9Wp3eFNo/EFCqDk2gybw2APo2dHwoNQrUM+he1PyrdVnuJvyBNiha9jl/ZK+nSScAsmsJA9nXgAly0Ak+o4xjyKWaVj7Jtzdw2qJNw2wzxEQt7QTapm2wwY6f//a4eEzlNoxGRgMypxPxBYoayH3XiNV2cw3Ugdr+G4NxgS9AI542Kcy3QU7R4aGHL/lwGhi23ql7OWRlihhXU6CgC01PyD9H2qQyOGGre1N9/maMPlx+x722F2Q4hePeiRHCUuziv3YNcIaoIrFku5Ez3trQLyNtbFGVxgx2BDL4p9XvLhFtwj74aCN6SifVx3Ohm7Xx6+HJ30a4z8ogq1jtTsTMwufnRdHypKKd0s2WysipVN9b5r9d2IMoAdC5mz/HFc97Sz34+kVbMKk3HfuBV5NLzyoEujzAjPGUHLL7jYRC20H++EgkGXt903SzKk4jEIJ2xLmaWS9uBY7h/9rnMY++sFKmhAJ7e9bq2KKqXrSTHJx4onmPh5klBSK4qPLsrvs30TyoDCMzds8yAY8EpOfSvx4X/KKGuHOWzY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1nIbLnt+O4HHWAZ+GyKM1RGMUOhXtP6qWe5VeItZrbGmZvpLm+xC7oFvWpdG?= =?us-ascii?Q?Yw+Q/4g/HRdhyUu3ti40W0O1iUzaOKTffD0p5OKOXPG3hgFk0tsjutlYLan3?= =?us-ascii?Q?ZLX0ifpS6WHIvcenj+diTApz3+8Yjn606A/PXTaJnzVdnP9QDAgyfffit7Dt?= =?us-ascii?Q?Tp4kj/4OtNIrf/xds1lBfbSSIWisDDENry69FNVKh/PlSkneueXrA1dneP+5?= =?us-ascii?Q?9Q5WA3pe7YXvKKaE1/D1rynZu55LvvqC6N+7obI8EqGT9YRzjI/83aWJR8Wx?= =?us-ascii?Q?OQso9k312+ctEwhLKklJALcBIYf3hx/OuF/QSkv5vvI7Mj2AHkEZSjKWaMVZ?= =?us-ascii?Q?ZeJA/a4f7mxLFullqKUNVeTzxhzuOggTfKCCPRafnQy6z9dHBVt5P+Ijzsep?= =?us-ascii?Q?SjmyURCyhM8FCeyyYdnvRGvncTrhBTWkSCGSUWEg7tWN/HHP9TbBMjuG2Aer?= =?us-ascii?Q?AvuhAr9ez5c2T/4pa+RwHotHtYKvnmNA2wqFj83/mqE22S/4HxkZ40Vk4i+P?= =?us-ascii?Q?s1P+I4oNtIEwYz2VKG2CUydhXTzp18Vv9monyuQ2zzD7jiNvGuiIUWnNmSTL?= =?us-ascii?Q?1VFsgvYFm42pBcsGcggabswHY+FMeSC1vAffzVGsEg/3ZQ/ke24r31k62d81?= =?us-ascii?Q?ax6tckDWan+IlgnChPyyr9Xi10B/uBiIlVp+FIeP/GQ8arz0IODWRRtP+fJn?= =?us-ascii?Q?rM/pdHAY+ZHap/Dz5sg2+LxnUbcWpqFpr7q1I0Xf/8jMV7vZDWkeJ/HbWozs?= =?us-ascii?Q?e3EqKphPuUNcY8G0s0M9QzJF3D8zUbEGv8WiuZKxGe6yiKxDIlhnOra0+6xu?= =?us-ascii?Q?YO3qEm9XyuCHZHYU12zDC37EO/1gyej4nOLEdTFfzH1eh54X3PHLraQIOGAh?= =?us-ascii?Q?/wmHqMUWYbJb7LgJ03DZhuVsXhEAFkg3tDGLsR+R+waaZWMvEAu8ZRmrzU+D?= =?us-ascii?Q?vDDlhYTh2/oKOWmoHAQa8/wL4RvYZ6o6d9g9j2QjkYLsKOcBVvtSPqWm+/xc?= =?us-ascii?Q?NwO7WQoMKUwlrZUvEHf9kA+hA4gbzGiYUuqgmdMkw9aDKN2hjF1FjwACgjLN?= =?us-ascii?Q?dHpHX0yFNQigZSNoqfREQOESrK9maM3xZgsT5Vf1Ge9sHUUF5QInYNzuEO+F?= =?us-ascii?Q?S0nz+zIga8mXtJ8cF5qx62Oh/23Lju/mz6WcNfN8wY7ChzIiElZRn2agl0Bm?= =?us-ascii?Q?oQ9NQHKGtcsc4ov087lzN+9bgzknzLdOfTixYIHWAzPP5NPJedYTweICcHSg?= =?us-ascii?Q?GVIita7GLTLY2ZacRH8pScLgkeVZjQdsS2D8amHI4e4dDKu/sg1lXArZCIAF?= =?us-ascii?Q?Q3jxFeTySRdS/9+a6cyOOlPQkQDWiXaXghtitcjrXsl8M0A83LFl+8eR3pw+?= =?us-ascii?Q?AMy5TO+AWWASxqUo1edZSCby/uBkTDwWEvpAMpqTffalSma/A1+gWu5vL4nm?= =?us-ascii?Q?0my7XE9N6UszQb7NCcngPBlccL2RYoONQEWdyJwacm+af7g0u6ln0yStcP3Y?= =?us-ascii?Q?BpwaJaa01rL/wHB8wN0JklLM5i321u348KYYw4IfY2J8C8SkiqCL8zkYhwEj?= =?us-ascii?Q?J45eWd3+tPjQ7qXWcyAyluV07SYl/nVqK7EZFVROpMStucFRChEF7nqGK3aH?= =?us-ascii?Q?A+n2+w6QjI91Gp/v/CjsUVdiq8geu6o0YQT4WS/MNAPtYUAzHE9rqtKgIuNI?= =?us-ascii?Q?clyDtPvX3ZxxnOOCIxtPtzoU6hOnwtEn5Dzh4QlXdELUX4p9BfUZ3BMG2jZ9?= =?us-ascii?Q?1Hq+AuFMKA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66ec4dd9-62d2-4f1f-1a11-08de8e4ef620 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:52.4540 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z0HLcOIOO0LiuWLSwBDC7tlSrChLB4ql7rHt5CPZ9rItorgD1bT2Lhe8eJvOAO+Chy5upvYrjMpqEREQCEdbQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation micfil_quality_set() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the quality variable. Also enable pm runtime before calling the function micfil_set_quality() to make the regmap cache data align with the value in hardware. Fixes: bea1d61d5892 ("ASoC: fsl_micfil: rework quality setting") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_micfil.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 983805bbaae2..2e887f1f1f36 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -289,10 +289,34 @@ static int micfil_quality_set(struct snd_kcontrol *kc= ontrol, { struct snd_soc_component *cmpnt =3D snd_kcontrol_chip(kcontrol); struct fsl_micfil *micfil =3D snd_soc_component_get_drvdata(cmpnt); + int val =3D ucontrol->value.integer.value[0]; + bool change =3D false; + int old_val; + int ret; + + if (val < QUALITY_HIGH || val > QUALITY_VLOW2) + return -EINVAL; + + if (micfil->quality !=3D val) { + ret =3D pm_runtime_resume_and_get(cmpnt->dev); + if (ret) + return ret; + + old_val =3D micfil->quality; + micfil->quality =3D val; + ret =3D micfil_set_quality(micfil); =20 - micfil->quality =3D ucontrol->value.integer.value[0]; + pm_runtime_put_autosuspend(cmpnt->dev); =20 - return micfil_set_quality(micfil); + if (ret) { + micfil->quality =3D old_val; + return ret; + } + + change =3D true; + } + + return change; } =20 static const char * const micfil_hwvad_enable[] =3D { --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013055.outbound.protection.outlook.com [52.101.72.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363663BE14D; Mon, 30 Mar 2026 11:24:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869899; cv=fail; b=GJR+UY8v+mrxlM7K5J4fJIdERDPzdTI++UwnFNlJ7JRhnqY0PDw6YEQhzS321jt3wMw2aHfmzx3gMdr707I6uKbsm2+TrAjaOOjG5vLvfukUNssmJ3vzM85Zi8uvPo7D8i7+Af0hWC4ZKQ/She9TnQwN66ZWUEDSyuaKMzeABKA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869899; c=relaxed/simple; bh=1glDNbAfvfcl/h+iTuEYjPIYg3fpyPZ4SERugOz/q7s=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=C6Lo63CXifR1emidhOyv2S2VT59VlB7/iO3z87h6uUWkBpVFyoSdhKXZumPcOqLit9rsaZUnTpuqkFjlypT38vlSVDO4To+p+oZa9/axcxBmIaLiT+Cv17caC7Wdsu7+KrO7fInnLQaGWwuEQzIBXtM3d3LMjaM3yZqwSQSY8fs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=da3pj2Gf; arc=fail smtp.client-ip=52.101.72.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="da3pj2Gf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I7/7IuKWQe9jyIHxQbDDH3u8RsnmjnFIh1T+by4B110CSz+ZL+yh1jZlgq71G6Qtik3wKACXRjEjEE9o220PHInLaMzuJo8WYMJuxVHl1C6BRhJD5e8xgN4cdJ3fx2EwKBV52BVktBs40eEFbVw1yJptWN6Zh4n2Q6EpGjOd4wp3MyinkK42Mk5RnR9LaK5Xlxg89HrOZxLyZZGntk7eBTeq295ycw9pADtqZmrGJccsTJxDVc5AmmkpSYXQVcU7rlbWCjGvwlDMg0Z8l+k2Jat5cgTfZdG+iiLBYIs356vRndtxYT8jZ9Jdc+Qv495Sl+6jp+fRfMIUZMnfMRjaqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjz7/cKn+uswz6wnJFHTG2Teqay8TwPjwvJMoHSg6vA=; b=efh6HGE8o4mj/W4Axd7l4o2QjdMXoyOX22hsKvS8+bJaMSIWfeE8nq6Spm6esaLLVG4CQU4sc/4nsF1ejAhjq51Kc1EWoL4ONVacJcyRUdRFGSf6M8nv6ykVoo0SvTwKnvs91iuAuIu/cEnTCxoQmk25sYPkTfFYDSMf1awOyP1N57wIOdGbAKS/vIUe1GEPcXyJmPtff0MYJSPIW21BB2HAYyk9NNkzLNNqF8yX0Q154v57WT6y/mddyGA4Q+dNGX1bVPdqzPGBEuuCvhXAqzUWiIyxXNPm7h5d/OlkLmeRFsRJmCy6BqaS/gf38VbDJJUOAKPFb3og+FNd5H8N9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjz7/cKn+uswz6wnJFHTG2Teqay8TwPjwvJMoHSg6vA=; b=da3pj2GfBkTNjVeDbqmZNeyWO2VRVjo2+JT4Has4tnoLp5KmcBSdk5uaBIEW+G3jIlk+ZNBYUesWcFns4OkVp9RJ1sYRD4k3gGM1C+r0sj6hGpTgJPMmO+GJng9uR+50K0SR8w5rnAQQlk5lr781DLhxJRx4SZUwwaxLiHpAc1BekjTm+FvvJcKZx+f2JH5UAvJ4UGlvNCJlG0MjaxO/blldvWgmJE3ZTxiNMFiLeS5rStjlgWwJI4iBOACbkSaPvNYtVe0VaZkb1VhHWeUrQHx8HxnuHMo/ddjpPCS8aVMf8dNectIO/vZHchMLjILX0HONv1iWWpAfhyiYx8GBjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:24:56 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:24:56 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] ASoC: fsl_xcvr: Fix event generation in fsl_xcvr_arc_mode_put() Date: Mon, 30 Mar 2026 19:25:51 +0800 Message-Id: <20260330112555.3637002-8-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: a92677c3-3156-4f4f-c32d-08de8e4ef88b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: 39YORPYei5dAMhohJns+NMPivlmRpQIgy1BIqmmwCSTNptUTu3Jvs785E6P8rN2fAotYre4IbniEXa4w1Gitq5U9pvgSXVM19IOrYi7XADRWXhfHE2io/mG7msIkTd/RcWScUdEVnS5zLKPdMMtWQYQ7icoBqx+jhYSGQYKOu8q7C6dOaHHN76sr5oYFKbwHLofExEVX/R/JAGKdqnNWJoJSgbMtESg2yWYuacD6Wj5Ow9tCz/E/Jwblr/YAsRTxrSMYIqPKjKV1Ixa444EZ5mBSJD9OKdFTcX8f+Rgtac8V2XduyMuKJTHJX7nVR9bjWlMqgWrZbbyCJTjHRQAlSAwA01ElggRnuzEJRXaLtcD5kFa8+mEs5M2i88Mh6aAhXhBS+CFBWLperFWadHHQVYq09EqG/MZPWbe4RsKw0DBJWJXPr3ff1idV6oZK9PCxAantoee+lfpw3AZiIgisLm6hNygSjEouJr0dMp4yEn+Hd2/4IM/qvFkLPUN/Nv042hd8EZPzaclg/pRT8cnK9u3iV226tMr2QdAwIVZkpHAJy3lp49mWUvtxPOm6xsA4kgXNDaf2Prci9b1S0GxGChR53E/vtzYrFq8k8ddRW7FMZZKC0LqPQRtdIuHr3KEnLiNdn43AHt/QGwgBjYwfOBBN2SB/tg5jbpRILbnPpZPNTD+NjhJUtqmhGuHvkPjTde72Y4lVzYY+uZHPeNXJ3TgEwLPl1I6qLe3PaeY5c4jNFdH3+dDu4Lf0jLbpi1+sy4YxXlCdb4cHLFI85rGpX11VET4hSDeYUfo+3kZLG6sjvfs299vSS5R9y0oFZAbv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ntiYhL93jr2KS0QhqDodliKz0HFRIPizdlAswgTK6UPFitoUcszuvCRQnGZe?= =?us-ascii?Q?h71B5wkoTxcI011lL8DLsWoIjkxN+aqgiYCCnRzNtZ7I7OUTBtZUK6U2h/JM?= =?us-ascii?Q?hK7srz4Emr00Q/BlFrQbL9Ouh4SD9wsHFuWNxsRm/Dv+iyMsHKjln+YtSrWQ?= =?us-ascii?Q?lmWImmmUg+Vi6LK4WUqSDOexTDal+KihAAgdoNtz+5wSgdvBTWFnugYin5Mp?= =?us-ascii?Q?uC2lXsjSOEJL+W0JoX8DcuiVBK8IZOpvNb8A0I4eeF9fot0WZISelgXZZ3e+?= =?us-ascii?Q?82M8kL/b1NAN0Cs0LRInaOLvocCmiIyOGl9eUejU6TdZQv5d90qfCfi/pRqD?= =?us-ascii?Q?JsOIGBbt/QlXxgujDnTjXboPU30GTIb055SVrWrLX2eROv21xwh/NMrSLkkf?= =?us-ascii?Q?gFX8ZqDfQr0aRl6k3XSUX68Q9rRrrUFk1v2Q29Q6pi2R+vAJ9nISpOaldBVD?= =?us-ascii?Q?UMKUg201crH/NmlA9YU+/FciLLNLNlY8+84OLDSa+GU5+lxqvgLKy6MzTLU9?= =?us-ascii?Q?ZtX4TxHewP84+27axkEm8LaEylWwpS1it/5YD5dXreqc3qGiugujHaZEw+Dh?= =?us-ascii?Q?SKxj4B7detNk9NEwxhEiJldjHPgJzS7ysG2qsb8jfgve+OWLN7Cria84i1J9?= =?us-ascii?Q?16RFKZEshSTqFy7bz493ma/SR4RIzD396HWgERVuQIFZWi8MA1m3pAYBHdu/?= =?us-ascii?Q?i/BRrgA3fzv6ghKUIiI1i2DclwN6yiZr81tQz25wKyznACHjZs0tmwlQkF4J?= =?us-ascii?Q?FSE5i5Vu3OS6Pu1GYXnVVD7kaZLf245ti8Md+SDV3a7e0K3oZoapba/eH3T9?= =?us-ascii?Q?gX5YGD9Ju/8hz86Ff9lQJs0q5CG+t5rWVqvcBCMjC1fRO5cf2krhmIifaPK1?= =?us-ascii?Q?jQ36X9IsdcmTbtjmVv1x3jdRC4iEyCX5OzfMYFMxPCfiasbrQGpsY0NdMDtR?= =?us-ascii?Q?bSpcUSJ7bLMhaVnz4MFTgrdhlZlkXcvXCYtmtn9qizpTNhgLmI/K/NyjnsOv?= =?us-ascii?Q?nxvvHFgh3TES/y5UKbAyBCPadOB7ZHZpRQ8xnw2eU8mbnn9gwC5UFKSBb/df?= =?us-ascii?Q?4SsD53I2FAuuCAZ+PeuEn7yDt+UVnBkc0fmTGE3iQ9B/9fpld8g53AWTNcRK?= =?us-ascii?Q?gC6ucf7XzU0dy4oRKkBbZyNz68Lm/y7OEUV8n3O+po7US1YPVEsLX+e1RgFP?= =?us-ascii?Q?/A4d+wMApj4qsaHx89zCH77zgWSydPfanfXA4FbfHvMgtUB4yEUxof+QBRCQ?= =?us-ascii?Q?GKd7W0N9bIL0p0W9guwvKF8aregaZp0KUM8YKzDDyXpeQmhqT2eZis3GzYvt?= =?us-ascii?Q?1353oHJX3+Rf+dmJBP64Yev3hJG/A9XrX+ERZ86R1f4QMyZiXRNdxDjLqS0R?= =?us-ascii?Q?cfvtXUy7cyIx98c5EQal5E2xSgF+0lQlhbSN88fBoqZUQSy5KFI94y1fqXRI?= =?us-ascii?Q?RIly4+Keoip6pspvLCD405HdI9jH0AgT3Ff8gBchp0clLv5xkv2wg+4ONqZe?= =?us-ascii?Q?GmkBxSVoJGGFGACZxfiaVh5kKHWJlC62mjS8Bz602mPUb5XP2IYYP57eH626?= =?us-ascii?Q?5B8hlIzsFdOvaCBHsll/9+JF3gqCO6Tb3zGX2jqn3XvI1+/UKFDjSCHhnwSz?= =?us-ascii?Q?vcgGgdOqzxA8LuPMaXxo3NXalJV/QA3uvLkwwNMa/vtcq/ExTgBPLctDypuh?= =?us-ascii?Q?+oRo1Pc73MVJ9BatIfMPZkEj74GFlgUQLw6W4Ve7gLiUbaYsBMLcccvJWsHp?= =?us-ascii?Q?zF7Gy/ZWsg=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a92677c3-3156-4f4f-c32d-08de8e4ef88b X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:24:56.4035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IcbELolahrE2X4jJblf03Scp54UqRSHiyE2pHo7QJUj3Dic0pGB+6ueTWCu16bXQB3AXvuwsMU1XTGrvadVt5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation fsl_xcvr_arc_mode_put() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the arc_mode variable. Fixes: 28564486866f ("ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_xcvr.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index de25d9e667ee..109e3e03f455 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -167,10 +167,17 @@ static int fsl_xcvr_arc_mode_put(struct snd_kcontrol = *kcontrol, struct fsl_xcvr *xcvr =3D snd_soc_dai_get_drvdata(dai); struct soc_enum *e =3D (struct soc_enum *)kcontrol->private_value; unsigned int *item =3D ucontrol->value.enumerated.item; + int val =3D snd_soc_enum_item_to_val(e, item[0]); + int ret; =20 - xcvr->arc_mode =3D snd_soc_enum_item_to_val(e, item[0]); + if (val < 0 || val > 1) + return -EINVAL; =20 - return 0; + ret =3D (xcvr->arc_mode !=3D val); + + xcvr->arc_mode =3D val; + + return ret; } =20 static int fsl_xcvr_arc_mode_get(struct snd_kcontrol *kcontrol, --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013057.outbound.protection.outlook.com [40.107.162.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C983C5549; Mon, 30 Mar 2026 11:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869908; cv=fail; b=XFV154GIuKLnLnnJ1rLLNn/mohxbed+wQFTARw+Uwgd+TQlkgftam8eumKYIXxGFMVPUXuzkRzbBpBoV0CpATQCBn0jBYsei1aMhqw919y8XGc3LtM90+dVUL0rGxpwc6iUnXDrOu1voiNryabYReUP3hTMpWiFBtzHWbHt5ye8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869908; c=relaxed/simple; bh=TM5AhqMBYBdLNkojU/lS+ZkRQqL/VeBqMaW1q0K9xLs=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=oEh8s9m7/kMRXB6CuH9RnLd9V35s4sHYAOhT9SpQRWGpxFeuIrWFPn7Ul+gy0+sSMipVUxFRlE/ALOR/+ayS//T4rwND0P5zxAP0PdO5KiiEMdB5JRK9AHLfzlaFWa2WDz21QKr1Z8WIDnehQqaeX6rh9yn2lDNG6PxV+588kjc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FilLD6Mq; arc=fail smtp.client-ip=40.107.162.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FilLD6Mq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m8KxgLRZSl3OH5OntrGS5XOTq+AUFW4OSrsg96OglKT1BVOfPTuCvA4YRjG6bC3dtxamhyPpOwd3vSZMHfWGxnJWnng6okKDikEnM+/BfpGEXSjT2c93tcVt6VudHTgxTeJQ4m+dK9euuzVCAfYPrwu6O37t5WiAMrwA+Ma4V1d+BvbQ7kGXydWQwWGDe7fgp5gfi8Af4A9FVpkKE8nhseZA5sWHuK96txLBSiHZUKNX72pFNF//newid1QJTSOChWOwafGqWjiVGpYz+BGv2jyyyLgghGbBhePohZ6D1jDIFdGcSsBx7iFAyRtfh/qS8HR2coOUe42HWCmC2sZS7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z1Ua7Y/Yo6TxbvyaRDoolgjhe+iyuzuyd94d3RcAmdw=; b=ECkNKW/5T+rE9JoOBMdQrreaXnNtKziXktIfuqsTT6s4B0ZHeyAxGBarpqF8MJEDM6/rQnX7lLeJzMwN9iRy+h60eJSbgnpc75NTXg+RbaLFnrv2dwiTGWN+9CRlG6hTpDzN5kzWUeNjXJWMePtYXoiSKxQha+f/S6IH768GOa7TvbiTruQ3gxH/hRTbm8nehDyc3MaBMXkJzsr8eimQHuObmDrG1sH5bam3DN6WlRVDL2A5ipJyKwcRp4jQkBgqPDMK4UgsoGSTA6CjqsVuCv927eFOAk7NAcPDMicrclPrRTO2VNYOp5UCl3BZpFXnxeBm/jIuX82Wou22Gf1rjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z1Ua7Y/Yo6TxbvyaRDoolgjhe+iyuzuyd94d3RcAmdw=; b=FilLD6Mq/Ver6Qt2N5L0qbZE5oYqjPEC4UY/2sNKOJUkjw0fYz6N+eDA51LSrXkfbCkD0q7tIfdlzu05BXdb3WMyKzDY3FvQiJqr8xdb65JWFNy1YsZkBuJd/cl8+gdjMbBow3ZG5wk0OESfiLalktJjRJmM8xxQ8lr1oDT0MGteuX60llZDXXOMp2ZlQ0DKSyibNpJMAPC1KafJ0CIPBDJJiJrwZhIZKtZEfcVhmgmZKfRk/9WfFMFn3T0cFl7wP2EteaVhr7a8lFVhvcF0nf+YJ+GJS5HbQWeHy9Qnu4fvLmwX3yihs9SiJknopGec8VRHnvlC7+I1O8Kium6tFQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:25:00 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:25:00 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] ASoC: fsl_xcvr: Fix event generation in fsl_xcvr_mode_put() Date: Mon, 30 Mar 2026 19:25:52 +0800 Message-Id: <20260330112555.3637002-9-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: ed8d20f3-0d5d-4160-8879-08de8e4efaf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: 1KI+fSdsGOkw4YbhwSTVg2+gtyt0RliY8CRFMJNnkWjwO3V9ylGpTUyVzhCZtAxSB8/qxrLepe0Ny5dCRoWcM7OaxousqhfAJY51bY9Gqon3nASlFgojuyh1xCM8DcgUmORTubyEmBJiwDjBTgai75a93QwvYlSEyuBmedYfhZe5v2UDSNafp0zBGeq++3W2OMvYjpbTKBD8WnuLPSCOJD+9xQ1ImOkcKZWF4Ku2J7XFn83tTJUR1F9M7zddiPMgWYd/+T1XHNTu9wwmw9ueBbRrD1kz+TuEfOpr3lWsDpc2p6Is61GYZmrGA7E9/ow8BL+W1q/G0uvylfU4NoNQ46oAIRkt3rWXtbyBREnlpHHytTujh9J/tLlX4M/5Au4RxKmJODJetk1P7U9JlRDdCzBxOu9gTOhc1FVnf78+jiRhzXh9CErzdYF9Wbw/uC4ZH8Yp0xflagnyo//+1kCmzYUsQ6OqsUSZbtpQbi2gGtuFuHCJ8nifFv+B5G3fyE8gopTXQBnlhxnwnj8IAX/qMipv7ojtl5Fz80j8uAez213nYVrRXzFiAg/bjALLN7lVR9mUokWvtv1YG0EGE2GIrvZOgqvVVM0u6odcvB0mLBwxjgEdLVTvBIxguskrjQWJP3JTh6LIjon1DuhS2RDfG1LMXsjcsLFLkGm3+a6MEbiqgq3C6+82xeeX4O/mo3RH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IN1okvTBsp9kuWvxVkJIwm6SMuEvSSKXH7nc/2xGQKmA4S7fR+8nN154qLBI?= =?us-ascii?Q?P8Y1xw8o0eSXzeCQx6aAXlM+WxcBNMJ0jirqsXz9uX2266QZ55n1/U6DyPvP?= =?us-ascii?Q?1qSZT7pn5ldECoMcN4S1QkeuMojLI5wT6hvI9C3sEE7VhX+cruhigJpHsjH7?= =?us-ascii?Q?YmAWmcatSojqTOZ+8v4jhc/QxJDESgYh+qGWBe3hCKoPVMVirUBJNDXF1uU4?= =?us-ascii?Q?7Q7az3LdEi17pFu5fvbuwVHsImQGwd8mzugXdRyJLJH4TJ0Qrd0lpI68nEb8?= =?us-ascii?Q?DKBuSAMJCgY9eWnlSSIaD3I6T6GvXbL93dLLbqml3Vz5O9mxz0fgXbYrzsi2?= =?us-ascii?Q?2206VSB6hXa4tDAahQLCrsswyb50SOfR6mjDnxdHjj5RjR1oUanxky6gy/dO?= =?us-ascii?Q?9kUnkEgQmI2KP1IErQPMPz8PAHSui4gjY4x91gb4wtMOf9a0033sE+yUikPw?= =?us-ascii?Q?Rt0JzPvtCEE6VuL1nA9Xm1vsFjR1dwksr5PhQX5f4GrZ1Dq5JJTUQdErq7bx?= =?us-ascii?Q?8aXFxxzYeuxShkF9E+QvyzncpkOPMQ2rU2xFdG/B4htsbKdoFKwHBtMZXnTL?= =?us-ascii?Q?p2sS8l3QwW7N86WmO0Ab48ETs019s6VUdBGAcfVlNnfmNrZYtoO/RSeKbRIY?= =?us-ascii?Q?u0XeESfLYENO4ZrJ2PA/84N3WWAD/VVcuxhGjTDH2nInExvFNKR0Y7yjrzdb?= =?us-ascii?Q?2pajBabeS+WO07uN94xzgcYBPTjoLf5o1kp1HBMAIsFSx1ZiKotePSeK4VWR?= =?us-ascii?Q?gYwZIaCtmQrS0yH3mci1QkDxY6Zg6i0Y52cRwVVUioP5Lw20O7vyJ3ayjxYQ?= =?us-ascii?Q?vjEDYkLmQ2LWfVmRnY0aAAW6dQZ15bajuo3qlQVYkpBZvEWNzW9EKfO2pRD1?= =?us-ascii?Q?WV74AFO8rH0pCv1T7Ww5Npjq5mxQwgo/j6f+BmvQB4Wp2N8nZragowoCSl9T?= =?us-ascii?Q?t+Qb+gAIpfmfLa+L3fS6yNrXiMKdCdrJ85aOIztfDlmmIxpnoqHEYYXKsRZU?= =?us-ascii?Q?uhhmYzgRKrw+zHPv5cj2Kl/0qQIFWyCYc8wMRv11hCu0JWjq5CfNOrzMEi4n?= =?us-ascii?Q?2ypEDDNfn2k5JotsYV3D+e+lmst78SWPuCJ/digQES0DCTkiDPdwcj5tB1iI?= =?us-ascii?Q?P3ZY9U9w1YLybfgVl31flw07+3WW5LGGUM63UavawYjjwxCh4ZOtX8gsGpGv?= =?us-ascii?Q?knJ+vzB0ywmuiRWiqE1EFUpTJtiaEQGpGhVXBpFnvN+haD7XrLnEVQCs1KX0?= =?us-ascii?Q?nrbrlbRRKxXtM2PynOfWSwlpasUSM2Px27l3WETNiGQ8tU4oL+DuPPHC3Akn?= =?us-ascii?Q?9pEVc/pGK1oXO/R/g7gvFpLh1z4P3ItKtguHIeyJiuJ1yUu2YSh3QcMHPKmg?= =?us-ascii?Q?ncdcdLDfgQ/fSLBQur6sW56aZHBKUrt86badyOlnQ96UZ6nkxPPF3oIkcioR?= =?us-ascii?Q?P/i8NdmCi5GZZJANKxrsuilgS6sxzRS7we0w665L3BWL4jMxM1mV0Fa2B6Zf?= =?us-ascii?Q?84Xx3bRZgOqgghzo4OC54/d1nCZxfTZeqj6wma7EAOiNhgSnA9kHp5c9f2xy?= =?us-ascii?Q?9p3To+BnTndGhLkp428XV8nz2/pidiOZ4jpdQ9cOdkcANyMjWh8rLkt0+eO9?= =?us-ascii?Q?2Q4CwvkqeQ/rMij1HOz6/NttvnkO2JD98opUQR4FQ2OWOPlwulVhMvw2CUUG?= =?us-ascii?Q?uzHD7MIgg6+Tr3+wcU3U/fFRkrNEYJa14yFh8i5oXugZsyQc8H+8kL/3j70+?= =?us-ascii?Q?c7uEpNsGPQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed8d20f3-0d5d-4160-8879-08de8e4efaf6 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:25:00.5151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 96NaPr1N9sFV12c6anz4YD2Suxx0k2h0hHdyeSyBF3gT8XMG/6PEeDJ14jEIweynIWcOPa66NHzu0czoLqkkAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" ALSA controls should return 1 if the value in the control changed but the control put operation fsl_xcvr_mode_put() only returns 0 or a negative error code, causing ALSA to not generate any change events. Add a suitable check in the function before updating the mode variable. Fixes: 28564486866f ("ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_xcvr.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 109e3e03f455..ee16cf681488 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -277,10 +277,17 @@ static int fsl_xcvr_mode_put(struct snd_kcontrol *kco= ntrol, struct fsl_xcvr *xcvr =3D snd_soc_dai_get_drvdata(dai); struct soc_enum *e =3D (struct soc_enum *)kcontrol->private_value; unsigned int *item =3D ucontrol->value.enumerated.item; + int val =3D snd_soc_enum_item_to_val(e, item[0]); struct snd_soc_card *card =3D dai->component->card; struct snd_soc_pcm_runtime *rtd; + int ret; + + if (val < FSL_XCVR_MODE_SPDIF || val > FSL_XCVR_MODE_EARC) + return -EINVAL; =20 - xcvr->mode =3D snd_soc_enum_item_to_val(e, item[0]); + ret =3D (xcvr->mode !=3D val); + + xcvr->mode =3D val; =20 fsl_xcvr_activate_ctl(dai, fsl_xcvr_arc_mode_kctl.name, (xcvr->mode =3D=3D FSL_XCVR_MODE_ARC)); @@ -290,7 +297,7 @@ static int fsl_xcvr_mode_put(struct snd_kcontrol *kcont= rol, rtd =3D snd_soc_get_pcm_runtime(card, card->dai_link); rtd->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream_count =3D (xcvr->mode =3D=3D FSL_XCVR_MODE_SPDIF ? 1 : 0); - return 0; + return ret; } =20 static int fsl_xcvr_mode_get(struct snd_kcontrol *kcontrol, --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013057.outbound.protection.outlook.com [40.107.162.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E0093C5542; Mon, 30 Mar 2026 11:25:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869909; cv=fail; b=IG9cLY0m9p7SXwG49LfrsZTIcm76bHIafEjqh1XamiHPwlZZRelBcp8tKRXV5DqGf07Y624jDIgaECGqASB6xofpqiuzflP9BHYF0N3jVnwkfV/r7c3wlWi8sa3RSOWoqc8GPztGTMh0PTcWwdi/ce6GfZQkdyVC4P5r7GhwFUU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869909; c=relaxed/simple; bh=CzMqE8pxtKS4TRaRNNLH7ScJ9KZpknbuBwcanfVA+Gw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=dnaCGKPbKh8y/eGVJ0+DuSOV8Hh5ijUw32Oo7hRH259ZYW9F3tFpkCzyC65PrJPaZH9h1UtD8V9aLdE9pmVxYHLIXAgjbnnDmkuVKTZi9IobumqgNDU2KfHpWXpyQ99ixVf2nugYL4RvnmdCzhkthLEW/qgnlIMz1cJ1Z+Bk6EU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=AQiQ0p1J; arc=fail smtp.client-ip=40.107.162.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="AQiQ0p1J" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pErrGX5c1xGwCSQhAVKwb99WsKETCVPsFp11zLTzIFtRhtkDqsxLkdNO/n2HgUnnWrv3p74RCBTfUa2hVjpuxeMZgbczN3VCtXvbsdK7TPR+dgzLM6hs98/Bs4PQvniGGMz37P2ZswwEV3DZQG1S7qnIwEKbekdVXJY97OEelvo6S0uPCtjb2CzAAp/1uEfkKsPL/XIE58Cy+1TFzDl9weJhhXfxCCiPtPqnAem4nA2iWvDrmtRD22Lc3qQZaMwBVlpQHN+aZZbhi2WdNIhvYdsQmfGmelUL9Y0JTvJu35eGhYKhI8zFeWpUjFteDrYCFPFU36/3TTujwcOTkFJQyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Uzoe5gXhM8SPvOT7oaHjCJYRsmb2cWNtkzMLoIVxUU=; b=PO7O5hMBQT7AjviBeBdXsOTfxgpKk95dyV8qrOBwja1wl8kyKj9gudjuMbJFMBgMKWy2LEMriNwL9bQ07cNgA36I2P4IrOHp4tMfwbEI5BS+vmWO1MUuWUfY7xwc1FK4ocyY88v2wv3qvcyXfBkMHwC4kXV4Vxo2AVjZPV2J4Zli4mcs9m0LOzxctb6DuswQJj9Sj6E+jn1iXszQiSGlUs9nvzej55hvSO4GX7Gh6Zn2EEtk3uYf/cFr2amhT8PDNsbLB8VTVLjgFUXWj7KpptNCmX6PSZ6XSv5dWUq4hYajeGbxKpNbfZgxYj0hjUSqXpRK/AsEPwI0s9fp6iy4EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Uzoe5gXhM8SPvOT7oaHjCJYRsmb2cWNtkzMLoIVxUU=; b=AQiQ0p1J5yuDpWFqJ4RuZVgAhaRsA5v1ukZBLWcduWSkGMddeRn+lUlcjqEXhAbXb46jsVc9Qk6Dm/f5mG3PvhFDUBnAEL6RuDsXi2uQ9txSz3TivaRhsKIA5hnbVc3CA/OWgftPH4rejhH9c/BPZS1VPr3oGOFTWJpjzFu16CIkimStmQ4uWkHWiU/+D1O0xWE03fJEzCvPtmcYl22reBN8DRk4+kFfDJCs2+lDoIBOhO0dHo0azLerDiuH4YpTqbjHacADq6qIPBZzKD/hyoMoAuhOIOIqGr0Dtxc1/qDtVe/WZ9qszjS2i2tHJ8PlzPLGk6k7tWxqnf/ZhZJ2WQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:25:04 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:25:04 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] ASoC: fsl_easrc: Check the variable range in fsl_easrc_iec958_put_bits() Date: Mon, 30 Mar 2026 19:25:53 +0800 Message-Id: <20260330112555.3637002-10-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: 8cd8e029-516a-4f76-d6de-08de8e4efd37 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: +MXAH71lMgYJbC+NACtVHhdCgdzy9gk7fgYR3wUJscqMwVKRjTa/GDNVuw3ycSCHX6c+j2b6ModKK/LChUNgOdUBINONIJYee2C66qkLT8tv++31ambscRCO0aKWPsDvju+u8N7770WA4jiZBtaKT4Z2NuffHz8CmvdjOvJ4uKkkC9GaO80gOPbQqj+mNCmWrf3Bzz5JmkLbdmNG1mBFVWmg160K3s+Ke4ImvzOnXPOyLaI+heQnXwT/h9U3LBaRBxnQePow6FJQmB7g9mjD5dVpZzMII52lg83epqdvmrHyrb3znuHtgReNBanlRq5dcgLzF9JPwRtpPLOAACkl2c6VYOR7bQFx/1JJ0q86sW1iePdFkobfUYSjpQQw1WDsm5j/mULNDd91goPr6pxhOVDwvMiPlmvVPmMQbCr5tiFgqWXljNbEs2WrMfDJTWQuyHVC96/8B9qDeGHZgikzd4eSawp2B4PpHoMfQEB2OsMANsTPNq+7VOHu9C8+01XH0FNSJrEUfimHwr8c+EiwkXAnkNdaTbkNJ61QeMwEBzfO8U7r4OBDQSO17Z1tmGZRoWx1cuAaKdNnS4GmW1Ur8Fy1ix3lAnA7KLezJQCyP8dNHwqfDa2b3UWmx2PLCJk66QMElzrCmY9sIMDKiVuKg7zK8CpLz6swXdpZZLR/v0zgDbRwLJileMMGTpzIunRqq2KQGKhfM/St5LcPRsKvRHSYfv3IMVDZej6L5GxAccHYI7qSUU1dZcVahtblNUvhp+S4KS1wJ+iRI0kdIXgHbRrb6UldHB9VIhVDB/YY+IDu63wjJWol42OhHNpMQsos X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HGM1F0BhynUlfVWHqN7Fb05U3H4mzWB/qFAipkI9ibX/lUR0LC1gY9THom2L?= =?us-ascii?Q?vj4sV4N6FtfFjRdSGFeLl0m6YQ7wfisoJIQQeTUKbdGD/OBeIrS28dR+rhx1?= =?us-ascii?Q?8XPcSZbvUW3VBrXRemon1ksHg3K+wALZU9ZFziq9OaGaUeQS6iutpXW+g3kS?= =?us-ascii?Q?27mjxnHxKivgrMhlqK3wmz2vjQ1lJh99ebRt5kp2Ds6ThjQVKYyEFMxfnl1j?= =?us-ascii?Q?7W2slPoQZiBsZq5EDBdiQQ7YYle5O3oKNlaHRNY87j+BHid6uRkIsuv/rtfW?= =?us-ascii?Q?1THGP767oDJMDDlydINRqcZ6TQVnpWeJNHcZSrK65vY76BFs1rrbkWWyaG8h?= =?us-ascii?Q?DIX0WyRoZYKAtiCiVe1caF0CHhmgHgPqPTIwm5dOJ1uKHQqhC7N/Y4SCKbv7?= =?us-ascii?Q?pkfFn/Lt8tJaXpOKmtUqmhCG52j0iE3akSHZPd0v231rknnUrRolSYP+O2f6?= =?us-ascii?Q?CX0kddM3sEJ/XyCjKrM+5EmQIdB88bGmYZoDuManmY21oflqagbl2X26QXPB?= =?us-ascii?Q?lhaQ/GX9x76qyRLBuR4308UGZKdkAPHpY6zMOtVakPvnCLsIl6Oss7Rz0Eto?= =?us-ascii?Q?BoXRLI+APRtoIxy2SXqFoN4MKCuuCMPp6f8BJwoMlp0/zWORcRjtrPXh8nzT?= =?us-ascii?Q?rUvP+X8gVIjL69PPHlnP2Y2lgud4MpicZWULjRbw0dNDw0zvJS1ICrFMwqaq?= =?us-ascii?Q?NUhwar/7NmBalEXfJz9QQ/nr5dwDaOHLZwloh8JrgMkVysre/2cpJrq1Evwt?= =?us-ascii?Q?s6UuvGrab9PBrpu26YaGiDxWXG68/KZpKUrVBztZpm0H2RxXGj5nupDTPKaV?= =?us-ascii?Q?wJ+E7AVsw90F2IwgzyVEQg9gJtXaR0V3yDjB15V0WxvSam4PtLluvAeOV/+5?= =?us-ascii?Q?Cltxk00ygcX49eA2h7hYQjC3ihyPvUBVdyLuoT2eV/qZzJRwQ82vVXvzkJTu?= =?us-ascii?Q?SNALc2ugIOHyoexbIpZj8khT5ZcwcdCM8j9vkujNvkgFQfE3BfOeB0OMLW/p?= =?us-ascii?Q?2kI38oxjdZEFxLsEUDBQ92/2XrQrzveTSq8Ul9p5zds7vEMB3ViQY9H62bLl?= =?us-ascii?Q?8AInGPHQwfO2wS0GTZGKYrgreeJzV5G3g0dawfwMLJuH3uVCQY2uPG+e3P1j?= =?us-ascii?Q?QGqP1adeqg+MLLWcsLnRqoG8p1bXlx9A8PHMyCPLrXbPU3h6c+FJbhSwl1pW?= =?us-ascii?Q?LX16X/mBtdJca7aYSQaDhCrciJzZUP92FPXqvjr72ePozhSwCiVxA9wFhzPp?= =?us-ascii?Q?P6vPFaJZdBFQJ+wOGIDAjc0iXMoc8jI4W+YZQgSoqgxcLmTPLkKZm17S4MZz?= =?us-ascii?Q?83ZgRC4XG1TJ+HJ0MsC6UJx0GlpQtR4mE18sufz6eobf/gGhxMfCVrAz0aFj?= =?us-ascii?Q?2LMNs0il7afCC4QtYbnxQqaftjD+hrmNCCO2RzJurh51DnZbk5zhNkNXXyGX?= =?us-ascii?Q?WqVwXGMXk8VSPHrX7wsaCGZc1Q/upVjamOBWvOvhQoyXCo130jewiQaMO2fV?= =?us-ascii?Q?tbaup/sTBYbKdn8pTmV2JoQRDnJr/5hOcjKRw/+4LG9HPlTxhE6vfdBSPd27?= =?us-ascii?Q?wTDSasl7oHEdJK5xREUbfk1beZvoyJd8pG6t5T23O8BbdskmXdXRuQXU6IU4?= =?us-ascii?Q?C+rrn+8krtyWnbukm0Cx9IFM4yrCWgmm9oAt/U3S4x9v7IGp8KobJMUWOO5m?= =?us-ascii?Q?Yjonjks60Ladt17H0ykznch2ALzMO+97Jtt5EC0N8g7qJ1hUyVpa8la02VwG?= =?us-ascii?Q?JL/7lcDgHQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cd8e029-516a-4f76-d6de-08de8e4efd37 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:25:04.3077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: La4D4+Ic2lVDs/URN5iVcSAa5FCITPPsjkNG0JvwglQCrJABNJG5d3Z7lOje9HU3hblo98PYxjD+Msdffifpvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" Add check of input value's range in fsl_easrc_iec958_put_bits(), otherwise the wrong value may be written from user space. Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_easrc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index 599e439b359a..f48e43a0edcf 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -54,6 +54,9 @@ static int fsl_easrc_iec958_put_bits(struct snd_kcontrol = *kcontrol, unsigned int regval =3D ucontrol->value.integer.value[0]; int ret; =20 + if (regval < EASRC_WIDTH_16_BIT || regval > EASRC_WIDTH_24_BIT) + return -EINVAL; + ret =3D (easrc_priv->bps_iec958[mc->regbase] !=3D regval); =20 easrc_priv->bps_iec958[mc->regbase] =3D regval; --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013057.outbound.protection.outlook.com [40.107.162.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2C393C943A; Mon, 30 Mar 2026 11:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869911; cv=fail; b=g46+/l7jDvQSpGgHT0EScCBXcG0uQDlA7nZ+nyeH8nx7ncWTluhyyZaMdQnOPCmmhNumL/uQ0aIWzZsGZqYB93u4QcfvybSebDodfSdYf3b0qbwyxk2h0kFMEU05H94m+B923fjXcZcEWx4qp1/X2s//qnTyBGHZHg5hfkjPVHA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869911; c=relaxed/simple; bh=72BKGs8TzH7Tv6r+rEjW4XSfQ3tWbwVnDZlIzhmbrRA=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=mB9m1LaNdwFEJwMoJg5HiyKuAZVYYm44khyduR627xsAsm4rXwLLmv50zHLoqki9Fsk1WksjhiTL8zSmwX5ZNNLgDKSBzy1ziwzADsIzK8bRDLjAW09OQwGSIFAmUaEap3/G+LDg1rsFmyuVegf1SCE9VSVDfFBKhlIWuyeV1vc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=nERbBAnH; arc=fail smtp.client-ip=40.107.162.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="nERbBAnH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n9CsC7vO1ibuCqtKR2/L3Yu18QVZTyv5eZWrlbYEzLjitOY/cp1xkOpP3GdLSpzxiGEPydGidWWRIli8fMcdenDVO33m0UlRO7U115L/iWBTuUmJUZ9dMUHUGacgu4vj7biz6DSDhAmnqlpQXNqjgdh2pp7W6ADo96MfsWxranm3mBExpjnu8oMTAR/TFUgfoX6taTejlH0zq7nfcg6v4sDhBk02+O9tn5JXrMTHxw2EFwfj2hCPlVF2wn1ZpEP6lmcF+TZCYWilBovFFSxXw9MuW8T4KjDCqo9Fr34T64fVbdmQ3iJ27y2dVFzB6Htw8p4kcbnrtR6l4f1HAoFkZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1W8Z6I5k4qC1og9LoTkBGolQOg+dtplXEcqMJbQxjaw=; b=WQGIeWhGRzKtB5mlMlNYo85y+buAbx7/vSfqdaW/FOCLBw3M5L9KtZ42/SkEnV5PdRZ/nuKpdkysBwY/19L1nLgiZRjE9Dn086dPaIrHzuup2wl4X1XaymxwiCRyh2oi4ik1q70VyH+N33kKXpbRqjRVA0TFQ9HbQfaiAvV4bezkRGQjAjmZOOXqv66z88xiKazXrKintyNHu4e+v8TwG/gnF23S9kKb8vFRF0xuZIuaeI+NWv7GZvgsmNcx3Pt9Vcq7Nt/bxxx0eB1Nsto68MfErJeF7AqMaytfCqThcKJTXIFvyeqqZ3xNFiyQ5C0f16FOzOhag+jE1csKb2Trsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1W8Z6I5k4qC1og9LoTkBGolQOg+dtplXEcqMJbQxjaw=; b=nERbBAnHSaoD463/yO90kc3zh9cznEFA3VCoOVi6YsIrTbnfZPJ+JFNKURMkgR9wVxcPjVZEFWXHcY0jjCuIaroduV9USbpeTOL/O1vy9VMxWKhJpbhY9iufwKdMFxp+Mk4siDmHpozOrKlghwwMA0I9+65XIb9tm0kk3p5Xhz+decJDNxjhz1HYoJ2J/dHAewXhMF6xw/kLFbEbJacSImaePeiVeKTcILHXuawTkzm3egswWscdpkX8msxxyVsJdVkqtLn0Cd/STMrC+daMJjK7y4FAGuvpSCQA73TYSiLtxQ6v1FU6XDAA8oJvTosM9XgJUsTCD/UopHTgb9nb6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:25:08 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:25:08 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] ASoC: fsl_easrc: Fix value type in fsl_easrc_iec958_get_bits() Date: Mon, 30 Mar 2026 19:25:54 +0800 Message-Id: <20260330112555.3637002-11-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: fa90fbf1-ea74-4b13-c05d-08de8e4eff7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: +p+v8OsXi73MpZ38CMLesrn0lsAJyHSX+2DOxFNmbJUYT9S3x9TOhSWUYiNbilHh0FloP6VnmKU5HbhJXKnIRi5B2/6b5feGXKSEwbZsTw9BggcEoBn0K54OQf1Cb+1b1UkSDjVMKypdVHOhfJnUraACzwREaUXoDCPhaCjGC35krhhJeyBnu0Ob1dE3+4S/ZSffLXgp6PV5FOrCWe3CCzAMu21BfwPv3pqgioAp41xHuAKc3U50iBATn/K0rKsAv197XLguktbIwUOCxJ0gYE+t6o2h0sAzesfYn18Hx2pRpjEF/dGDYQaeN0TMq5ij8WM3xnVm6I30zOWW+Fx4Bi38yNjnbVPO1Xss25NJ45yFVx3lb17WBZzz+jEmCJhNwN8Oa2kkj5+pYpyH35PW2ohzGuwXXayP/N4QFZvmBaLDD9hOaZtYjjagNbepKPvU2vy0lSs9UiGcofjmeRVU+5bG1u/Z8UM9wN008teGSkiAQW/raCljYhyfWzBZYejvh4UPH/6FWYz15kc5qe7MfRZKSm3fz+a8KYYv0doha9y97fahD0Lf2w9G+cZs1X2iiUCPtsBKtx05KHfjvwuXah4zaNQNjgAKB7Pn/JZmX4B3SbcqSayZVyet2LWrePOje3BGMTOlnA8m+lncwLDujYbDTkXgNB2qEServ7ZKfN2oDHTiUjogN3ngy2OV3wO0PPyEtrcTemCXvBpJVPtExflUNcnyA8nwxzzHJbj7jCZxLcR53gpO98P1E325umJB3NP+32NdcJBGIAgo+Csvg/ltsOC2XM2Kpi6pjtJ8TSApui6ire0pP1R6LgQcKQ+E X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7ZHBQX/1IZQbl2XZjiJ09bhujhBjz5wz3WTyqH6+pstaWzvVOd7wKL89OQCw?= =?us-ascii?Q?6C0tdzTv5pN+L9oEH5BiZqCdCKbYqVddlvMV23eFWExZ8tQzfYmSwRMzDYno?= =?us-ascii?Q?/BictuELbDLE0cCxhb1pmW3I+EuSH2/XGmcnLwVQCMmBtNbcnF9yyDdb921p?= =?us-ascii?Q?+ar0E3EZiBUON22w1YsHdM2NJYmPhZCpeZXvRdonpXwYafzk/3ykkg+mSKjU?= =?us-ascii?Q?aVXt6A+tj9D/djP7R6PAzXrPoeAP7XygYGw18QrChtxycXJt+MKjBh2JE3em?= =?us-ascii?Q?1dJDzYnmPbPSQyW9uITnJtzUlDVpgBZW7XoaFO+zbp+TI8yf98vin6kBsGR+?= =?us-ascii?Q?wN5wgOGCVxN4ElueGDWll9XfkG8gueUt97vdrHK+vZ0FF2XcneID4/JpyEQM?= =?us-ascii?Q?dPV2xAt828i62t7BgeBMtefIdnYM9yGz44Z9GhdGgskXpEDSpPPIUhurZMFn?= =?us-ascii?Q?kcbIMoYt9Js4Sf3txbXqCoyIrBWV70YV2m2mIjEVArJ6bvSPpTXJ6D1HajRq?= =?us-ascii?Q?KzReStTnuSrJdgTa6T/cxhrVJP4tYarOAy0Z5AmApfS/XSgp5kPltreE10hp?= =?us-ascii?Q?ueENsyYptpEi0MpdtJxdWJ7OTLXmH/eZzuFNKQzi3///OeFnj5PgbC3CmV6R?= =?us-ascii?Q?YAdnAwYxccKQOJfob/auBUUHtAFPEVIZiZ+bQ2AuFGflpyYAvkYH5I/RNg2j?= =?us-ascii?Q?7zQ9UTE8/gi5LsTznf07Quy2K+e3suBcZrv/VRXfjPmpNnTYqcgeolSHVMsR?= =?us-ascii?Q?PT/B2MNG5SgV9GTLfoAFFP54A5tp0YNlrIG6ir/JBuWl11kMzXx+BRhGvXvz?= =?us-ascii?Q?nLR8dk9hMsfW3KQUL+XAvIrfGd0HcqwXFGRWLHSLrmqQJXe7KbD3qXb7rzhU?= =?us-ascii?Q?5rejiVA4RtrZsbm+jFCwTpzvQoSOToXjIVCLuKX9YMJq52SmLyBfwVObIqtv?= =?us-ascii?Q?ALLQMvyQ0zLtt0V/mAP1HYIplPkS5VYN6Xvk0afza1anV8qne1YZT1zHRJDZ?= =?us-ascii?Q?BX/O/pCjopR/oX/DCdQjRHktYZWY5Ggh7bTyju56VuoQoFQ/zUSGAOyoQS/0?= =?us-ascii?Q?LKlZ1xln0S92iuujyTqiOJlnZT4zZ8P7EJQpbi+hkfv9dQdZSe13NCgIS8rC?= =?us-ascii?Q?+yVxgfZgo1EYU33QvCFjj4L46wdMS5PpxkK85Y7+6t2jm/pECfrHqlycs/TI?= =?us-ascii?Q?ZIBqD6O7NRIRP91E6XYlgNXbk1yeO0jqikHHN28doPW14YMt2jIoTPLawI57?= =?us-ascii?Q?zt2NcaefZXGk5FVFHIgPTLFSSi036qfU/btW7DFI8HGddI5BuCBgrtKSYrx3?= =?us-ascii?Q?y6neIboNzaEHl4RdtWaKZ8Of7mnpOPblDOkr6YRfCNFCezWXOJrYw6WRBjfA?= =?us-ascii?Q?sbI7o6p8o4qFkGOjBy5DAsZWPXBlkT+I6LcHisy3alUbmJW+hg/ji7lqsV1h?= =?us-ascii?Q?njhltMPz8X2pZKFQMLa44+ZwoRQuzspqKJeEidaEB+aDuK5HozccsTubcdhi?= =?us-ascii?Q?3wS8bIMgRmRAR+Wnpt1eqdyl5s5TCnK1cK/BAXD/VIoBf3qcxXKb5j65Fj2W?= =?us-ascii?Q?c+g+hp713r6JMdfPrJVMaXQONnKcs7ye5cEpH6uX7jEuozGIS4JNWEJk1KAf?= =?us-ascii?Q?gT2grHQp0faBx/fXskp/L7p0G0FowFv9Z1LqGyUK7s8i7s1QdNQbiDZa88D5?= =?us-ascii?Q?Q/qIxGglRM13QCdEwYNMKJg+rPA1w8A0kSYzmbn96x69R6QKYkmr/F7BFuo+?= =?us-ascii?Q?95XvJwE7MQ=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa90fbf1-ea74-4b13-c05d-08de8e4eff7c X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:25:08.2018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sWKVPtU67dkpq/dsLv9eB7Oe9aoNN2zrrS1WrdF4srq6wtvbF8nm9T6jZnP+wNN16HamSTSvfJ0Yln5mds5W9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" The value type of controls "Context 0 IEC958 Bits Per Sample" should be integer, not enumerated, the issue is found by the mixer-test. Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_easrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index f48e43a0edcf..3086cb758beb 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -73,7 +73,7 @@ static int fsl_easrc_iec958_get_bits(struct snd_kcontrol = *kcontrol, struct soc_mreg_control *mc =3D (struct soc_mreg_control *)kcontrol->private_value; =20 - ucontrol->value.enumerated.item[0] =3D easrc_priv->bps_iec958[mc->regbase= ]; + ucontrol->value.integer.value[0] =3D easrc_priv->bps_iec958[mc->regbase]; =20 return 0; } --=20 2.34.1 From nobody Mon Apr 6 09:49:45 2026 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010004.outbound.protection.outlook.com [52.101.84.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 349BE3C943A; Mon, 30 Mar 2026 11:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869916; cv=fail; b=gpvpiGyi9pqwluLCdu7ZTKlLHWSx6xFHDIYVFO3pFWdqSLXH8fSDPwFNxeYX9ak1Xo6/thibc8ZbnFsCyA0bI8Hd+2x2lKEBP3NTdqQ2W0AUsdXphQkfjdKW3ru8U3A9N0yFhjMVXCCpIAdtuvc/v5K9dyE1aPl39JM75CD3gwE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869916; c=relaxed/simple; bh=OoeZ24Frqa9W4JWcWd1NMPungbGV1fK6ltYlAxAWrrU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=dq2EyvjWm++yT53p9hm5wzEIWOMneSdxJ+rtv4Ebd9R3qVA3Uy+oPotzfhF4CpkcAb30P/ELr5JfWjpk1lDzmfC0n1Qu0CWu6gJ6jf30LeTmXmCmVQITuSoEbHzMPE5HXtz77YiCkDUGwbCBHYAgGilOH3xeN2Sl0QEe08QCrOg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=UicXeAYL; arc=fail smtp.client-ip=52.101.84.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="UicXeAYL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H80javA9rVy1DkPImFAI7PBQTa9o8H1l/HSH+eHR7PSdP4UmjkPOiGVXy2S5n+6C7gKqCMtjbV32Zj0z7VpCjTrUBaaJore6TSxI91lrfIc2R9z+iRYUZfcno1LTvEa+h8qqB5pNroCDZ0lyXY4ycI3v+dXIs4r6sDI8Xk0/oDS4HAGnraW++FjGTvWHpgUlFa1JjB4NQCt7d7ogAauK9lgBSzyt0e0aeW6mVeTHBTNZcbWMhzNKaGktqMbk6Xyhmrv7KDROJCL8m7/RnGkoMqfhxHqhfNqTSdUwoFMQS+dn8PRiQjJeGD1HacaZdbcw3hJB1b05E0hOnYG1oczFHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWGdX/mjOth4JlJfJRauxMX+NXWz6kf5QtU1iCyARiI=; b=S59Y2jw8+TpMU4xsHFyp6askv18OshsQhIizFlgzkn3HCGA3eebT+tZfU2fSlndo2i71F4STgcoxIyJVLOlX71sko3OIucqcjAWBw7sl7rJqGEd3N/rJHiF4pVhTT8GFfj0mStNS7JHs8to+Cuj3yNgISIvXNjYHy7OPgWQga94FxLaZNumtdWajvY3ZIkSCEmf8ioVa8DkfP2CLkCJaxtuz7q4ASZzGq9SHP/j3AETRIJEosgAHcaSEAF7xf89oruncZiXZzMIDvYhUZfEV6UlwBX2AD2pwi62uPV1j035WaHjxZ0ZI4JGV0ORllJ/WdU9RDO/x5iiLslCSDNRhAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWGdX/mjOth4JlJfJRauxMX+NXWz6kf5QtU1iCyARiI=; b=UicXeAYLUzrahvulK0eqenJUbrY3vbhY/mljhKw4o59u1eBdm+e78Yd9tyjjY8Zea+fXI2KYYqYLmXCDMPnydmD729niXRKiyOyFjFqvkheG//BwRTaj68DgmO7Ksh1d36b1AAaBaS363KfG+tLA7t2ONg8w6+9wDNbH+AQ2WAUBWKDiQlVgJM7oGcqAmf7SLJYPnP5iSOTBmns35CnyurIdiaKVwCX8/ZYonJpYgYM10kpLGIuzdcP2Ly/3KuTKEMmkLpoa3DJg/aw5LmBF63RH0y7LUR9M0KTeE09gVw95LIFngkw0B2OlbZZA6X1tqYmn23Ju1ifWvmJ9f/Z+bA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) by VI0PR04MB11481.eurprd04.prod.outlook.com (2603:10a6:800:2c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Mon, 30 Mar 2026 11:25:12 +0000 Received: from AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b]) by AM0PR04MB7044.eurprd04.prod.outlook.com ([fe80::bab2:d15c:fcf8:ef2b%4]) with mapi id 15.20.9745.027; Mon, 30 Mar 2026 11:25:12 +0000 From: Shengjiu Wang To: shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] ASoC: fsl_easrc: Change the type for iec958 channel status controls Date: Mon, 30 Mar 2026 19:25:55 +0800 Message-Id: <20260330112555.3637002-12-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20260330112555.3637002-1-shengjiu.wang@nxp.com> References: <20260330112555.3637002-1-shengjiu.wang@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI1PR02CA0009.apcprd02.prod.outlook.com (2603:1096:4:1f7::10) To AM0PR04MB7044.eurprd04.prod.outlook.com (2603:10a6:208:191::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR04MB7044:EE_|VI0PR04MB11481:EE_ X-MS-Office365-Filtering-Correlation-Id: c6a1d37a-25d7-4c83-5035-08de8e4f01ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|52116014|376014|1800799024|19092799006|22082099003|56012099003|18002099003|38350700014|921020; X-Microsoft-Antispam-Message-Info: SAKjoyanb03d5KJgki+aDAetQ0ZWXL+OERN17vPq1JRMBEvD6shEEdI80vmcC4cpSoWuYmp0AQ5C0TNewk1VrTNoWRNZ1n3z+iRP0GfycZXwjWGNLSZYeJftp17lc7jZSCSo4sMiMXobk/vbQiTbPLVNpsb2o8cl2gSnwzBUHAPmT1CEKqJl6ZCiCsVJLYrT5LIo5dbhbVV464Kli5W8OjXAJAcINFrKyKUpdJGemqc5388t2TKrGay450JZXxRjDCEdYQfYpyjejCGkTay7K0O1dzIQZ8RB33ipGF1DzNf0M+pn9QEDcCcuWJ8UO/oFzaVZS2eCDS7Pry+GEYHSHkwmCM/QI6EADg4Xpc+oYeyBjENwUo4kLkvhS31u1nDIFu3kQi5QgvOj3d0bdxyING3KHq19qHihuII635wUGgGvlc3eh+nr76tWfazp06X6OpspImfoT4c9Vf/lzWffeBHnhcHSQro1fCKRKvVVrPQMj8PpEjgxY5A+MNjiibAg9S/VOK/npGCd0gjkRo7QsuOvZzpmsI3Y94WAWnkDVmCzY+tgLAoDHE9TovO9gUEgmmowKdhHR5aTq9XlgH1kdZLo/JGDffVnAZdGXqgpWNGwMNk6TNr7Kq70+ePHk/qDTmh5/7MFnZiymAAlpYtZ0x/wzi6WXt/fDMxHASVJAasXkP77L/zGFzzXZ0DP+sAfrj/U5oe+LyQlcnXbw1vyd4nf79A0oRAU2DE1qfdycKQ+tkMsdA96Y8aV7yoGjTm62myci9FP5XatyyhVhEuhptbNp0zuhwNwQeRaMWq1gL7cpvnVISTAp+6p14OLayI2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB7044.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(52116014)(376014)(1800799024)(19092799006)(22082099003)(56012099003)(18002099003)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6xZylJSQt6GuBXSgH7e6MIZGYNJZ5LK423NCbnu746yvNoNCBxnX6NtXL6ND?= =?us-ascii?Q?rjtIZf/ZnN8L16m5FdeaXrYUcemsZdp3Ab6hGPIkH3wyUblSJ3nFf21BJFXZ?= =?us-ascii?Q?qxTXOvI+u9UgaCtf6Km3sTVw2JXXySNVEQMSryKVkTMh6WhcPEn8DiNCD8hI?= =?us-ascii?Q?r1uPMtwqDPxrVosdXUaXTabDGv4ejvf/Am/ZjIiPTnu6mLIm66ul+3UpGPW1?= =?us-ascii?Q?juPNTmlW8RJv4lnKc+T1arvYJIUOCXLRAfeLYAgbz9RxsrrM4lPh6bxfQBAZ?= =?us-ascii?Q?zzBPFEv8maKWG9zy68p5wj5/vMFaaAtqVwtMDt/y6omO/9TnJ1XuabYNPXBp?= =?us-ascii?Q?g7oI0SfEgu3zQ4Rl/nAn9Iq1PRB1vqzg8fw8BzlQCe9DO6XzFss/iq+SEIg5?= =?us-ascii?Q?dltHvaSJ1isSOnilBzVTrdH40wcmq0RsDov65yKcyfI96B3aXmPXqXJKqoqX?= =?us-ascii?Q?Vuk+9NiHLq2mo6QYxmY6HsPo5Lv1dxibYAECqKgqYt18LCGsqA4//HpG+m+l?= =?us-ascii?Q?nFGui2pIq/glp5pREJxTdfQ1652iTzcvfNbZ5uD9iQGfMOBkcCHVASwkmzbz?= =?us-ascii?Q?Vp1JLSpzjSpB0C8KmkP370/c5+ONyd11u5BkZkAjGEPZKhMZjym4oxjxCacw?= =?us-ascii?Q?ljoYGkrWhA47LU7piZIGaqU9x5bpVsMazOh4DX7bgdHZEKDKQtnNZOKnA4om?= =?us-ascii?Q?BLUeapTDIaQ+tVCQuDEtZ9J7p0HXvt8a4UhEdeu8PMMvF07U5NuhUYVJa1IX?= =?us-ascii?Q?T56CigCpkJ0gXqyqxecfEbxdULTvTBAhHrRYcaNZdhsbUZUH9JQh2YDd45vh?= =?us-ascii?Q?l+RNgjMWeSSAWndu82WsAeLMFnzbhx3kLogYC8mRpwdfsOD8Gk+U3jEnxfn+?= =?us-ascii?Q?D9oxeZkKW1L4KsYrLXRXlXfTlg/dv+fFt1OZDD0GIJtLwEHRIuPHErDoOUcT?= =?us-ascii?Q?Ugz/A9uoj1sIjd3Xb7FzTzN8KDxkzKIngyaNNEG6TfBPoCXCXIAoZyAs4ESy?= =?us-ascii?Q?xWDSGDfy69PG8eWR5de3HHhxN33j3WI3gxZ6MqGY/k3rUNLhASb1no01XM59?= =?us-ascii?Q?JL9Sv5mObBBmId/0APZgtzJaX5MvKu3ZeGqnLBFtC9Xcr2B1ScYGqIBF3dmc?= =?us-ascii?Q?QOIkwTfPUg5uJyY+wbriHqt3iBb8NuGVOzlnAsiNuMZw2CI0YfxbMYwXDg79?= =?us-ascii?Q?f4RYtrPu0LGoaos0LHETiTlu4mIlVPWn4UfpOCfAAtWY017pch1zzyKS8ary?= =?us-ascii?Q?t/yPuqzRSwXqyU/3TZhwgbnYu5wfW9BP4ayP+Oxs+SNIZ2+lAW0+GEmSgZN/?= =?us-ascii?Q?dfED11sof94F8EQMq5K5m2CT73RuxJdyuRObDlz4PQTSo3x9jymA6oQ/Ba8J?= =?us-ascii?Q?cFEDyFyEQHjlsWLKtueFK09r80862U5dUVKrQrpU0eanIp652oeLM0iTxoCm?= =?us-ascii?Q?dil1jXPYdRaX26mf/YrFRu+7Ju84OTIRtDY9dbe6S0yYOo8X3r6TYR/CYoYN?= =?us-ascii?Q?W3My1pFnYOJNz+wYmDOHyJIMAEVTBgXHw64TdAhByh/B9UwCXe4WjtrD5+od?= =?us-ascii?Q?N/vAICjKHQPOWzQfoCElUbSGfSMYOXpiRBGSQqPXFm24WVJV6wApVXfxaKif?= =?us-ascii?Q?KNO7vxQmWAYuJKt9ViW0JF4TUw4iWkGX/seQiTGClBZgyGL5Ph7ZPp07v7hb?= =?us-ascii?Q?Wg1Edb43F3466hg5h7uhF7YTSJ+jN7YtObHAeLBBMaWdJyCEQLmbYgJVVil2?= =?us-ascii?Q?XuhYAzu2MA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6a1d37a-25d7-4c83-5035-08de8e4f01ca X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB7044.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2026 11:25:12.0765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M419CAQHWOBag8hq7l8blQxo85J8INBI+1sl00Z5hGtJ6cl3geHIafN5pdQDoGT0jfEjL/O9g+65lc5QqyExXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11481 Content-Type: text/plain; charset="utf-8" Use the type SNDRV_CTL_ELEM_TYPE_IEC958 for iec958 channel status controls, the original type will cause mixer-test to iterate all 32bit values, which costs a lot of time. And using IEC958 type can reduce the control numbers. Also enable pm runtime before updating registers to make the regmap cache data align with the value in hardware. Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_easrc.c | 108 ++++++++++++++++++++++++++------------ 1 file changed, 74 insertions(+), 34 deletions(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c index 3086cb758beb..a6c643a4d51e 100644 --- a/sound/soc/fsl/fsl_easrc.c +++ b/sound/soc/fsl/fsl_easrc.c @@ -78,17 +78,47 @@ static int fsl_easrc_iec958_get_bits(struct snd_kcontro= l *kcontrol, return 0; } =20 +static int fsl_easrc_iec958_info(struct snd_kcontrol *kcontrol, + struct snd_ctl_elem_info *uinfo) +{ + uinfo->type =3D SNDRV_CTL_ELEM_TYPE_IEC958; + uinfo->count =3D 1; + return 0; +} + static int fsl_easrc_get_reg(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component =3D snd_kcontrol_chip(kcontrol); struct soc_mreg_control *mc =3D (struct soc_mreg_control *)kcontrol->private_value; - unsigned int regval; + struct fsl_asrc *easrc =3D snd_soc_component_get_drvdata(component); + unsigned int *regval =3D (unsigned int *)ucontrol->value.iec958.status; + int ret; =20 - regval =3D snd_soc_component_read(component, mc->regbase); + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS0(mc->regbase), ®val[0]= ); + if (ret) + return ret; + + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS1(mc->regbase), ®val[1]= ); + if (ret) + return ret; + + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS2(mc->regbase), ®val[2]= ); + if (ret) + return ret; + + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS3(mc->regbase), ®val[3]= ); + if (ret) + return ret; + + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS4(mc->regbase), ®val[4]= ); + if (ret) + return ret; =20 - ucontrol->value.integer.value[0] =3D regval; + ret =3D regmap_read(easrc->regmap, REG_EASRC_CS5(mc->regbase), ®val[5]= ); + if (ret) + return ret; =20 return 0; } @@ -100,22 +130,52 @@ static int fsl_easrc_set_reg(struct snd_kcontrol *kco= ntrol, struct soc_mreg_control *mc =3D (struct soc_mreg_control *)kcontrol->private_value; struct fsl_asrc *easrc =3D snd_soc_component_get_drvdata(component); - unsigned int regval =3D ucontrol->value.integer.value[0]; - bool changed; + unsigned int *regval =3D (unsigned int *)ucontrol->value.iec958.status; int ret; =20 - ret =3D regmap_update_bits_check(easrc->regmap, mc->regbase, - GENMASK(31, 0), regval, &changed); - if (ret !=3D 0) + ret =3D pm_runtime_resume_and_get(component->dev); + if (ret) return ret; =20 - return changed; + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS0(mc->regbase), + GENMASK(31, 0), regval[0]); + if (ret !=3D 0) + goto err; + + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS1(mc->regbase), + GENMASK(31, 0), regval[1]); + if (ret !=3D 0) + goto err; + + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS2(mc->regbase), + GENMASK(31, 0), regval[2]); + if (ret !=3D 0) + goto err; + + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS3(mc->regbase), + GENMASK(31, 0), regval[3]); + if (ret !=3D 0) + goto err; + + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS4(mc->regbase), + GENMASK(31, 0), regval[4]); + if (ret !=3D 0) + goto err; + + ret =3D regmap_update_bits(easrc->regmap, REG_EASRC_CS5(mc->regbase), + GENMASK(31, 0), regval[5]); + if (ret !=3D 0) + goto err; +err: + pm_runtime_put_autosuspend(component->dev); + + return ret; } =20 #define SOC_SINGLE_REG_RW(xname, xreg) \ { .iface =3D SNDRV_CTL_ELEM_IFACE_PCM, .name =3D (xname), \ .access =3D SNDRV_CTL_ELEM_ACCESS_READWRITE, \ - .info =3D snd_soc_info_xr_sx, .get =3D fsl_easrc_get_reg, \ + .info =3D fsl_easrc_iec958_info, .get =3D fsl_easrc_get_reg, \ .put =3D fsl_easrc_set_reg, \ .private_value =3D (unsigned long)&(struct soc_mreg_control) \ { .regbase =3D xreg, .regcount =3D 1, .nbits =3D 32, \ @@ -146,30 +206,10 @@ static const struct snd_kcontrol_new fsl_easrc_snd_co= ntrols[] =3D { SOC_SINGLE_VAL_RW("Context 2 IEC958 Bits Per Sample", 2), SOC_SINGLE_VAL_RW("Context 3 IEC958 Bits Per Sample", 3), =20 - SOC_SINGLE_REG_RW("Context 0 IEC958 CS0", REG_EASRC_CS0(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS0", REG_EASRC_CS0(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS0", REG_EASRC_CS0(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS0", REG_EASRC_CS0(3)), - SOC_SINGLE_REG_RW("Context 0 IEC958 CS1", REG_EASRC_CS1(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS1", REG_EASRC_CS1(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS1", REG_EASRC_CS1(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS1", REG_EASRC_CS1(3)), - SOC_SINGLE_REG_RW("Context 0 IEC958 CS2", REG_EASRC_CS2(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS2", REG_EASRC_CS2(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS2", REG_EASRC_CS2(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS2", REG_EASRC_CS2(3)), - SOC_SINGLE_REG_RW("Context 0 IEC958 CS3", REG_EASRC_CS3(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS3", REG_EASRC_CS3(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS3", REG_EASRC_CS3(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS3", REG_EASRC_CS3(3)), - SOC_SINGLE_REG_RW("Context 0 IEC958 CS4", REG_EASRC_CS4(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS4", REG_EASRC_CS4(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS4", REG_EASRC_CS4(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS4", REG_EASRC_CS4(3)), - SOC_SINGLE_REG_RW("Context 0 IEC958 CS5", REG_EASRC_CS5(0)), - SOC_SINGLE_REG_RW("Context 1 IEC958 CS5", REG_EASRC_CS5(1)), - SOC_SINGLE_REG_RW("Context 2 IEC958 CS5", REG_EASRC_CS5(2)), - SOC_SINGLE_REG_RW("Context 3 IEC958 CS5", REG_EASRC_CS5(3)), + SOC_SINGLE_REG_RW("Context 0 IEC958 CS", 0), + SOC_SINGLE_REG_RW("Context 1 IEC958 CS", 1), + SOC_SINGLE_REG_RW("Context 2 IEC958 CS", 2), + SOC_SINGLE_REG_RW("Context 3 IEC958 CS", 3), }; =20 /* --=20 2.34.1