From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E01C63B47FC; Mon, 30 Mar 2026 11:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869656; cv=none; b=ELoQkePbld9sLilXawqZTb7kLmBTDoi71X1tuAcRD7vVWt5OA9ZCinCxjcY8/EAR+XejtAGPNW6SaSA+Lfv71f+DCrM8rHj67/PBOoKMvlG6igq7eVFQ9WOoUZc7v9uIjqgIDWq9b5jy+sXp5jN2jP1+WraIQm4llbH6QI8uBdw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869656; c=relaxed/simple; bh=ta3USsTzCkdW/hUeHq05JFtmK/O/UClmpoMITevJkmc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TcKmmPCJlkWCCcUdm4lHsVvv2y+G3VeqDh9m8Xg//B6qwCKQuFqOUpogucsabOe7kb8F04rB9y5FlcJPxMXN/E3lm8nb2mOAo/fxspy4zZvvotVhh2HoQFrhfeLrtTVbaGkwMoGR7hNsdzmeXihRspt670HBvwijcI6aJOewRfs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=JTdIJ+Bm; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="JTdIJ+Bm" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UB0SFX1037162; Mon, 30 Mar 2026 07:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=B0dCj 1Tm9+7sOxaTFeG/62gnnNl3tVaKWKdbfZ12r8I=; b=JTdIJ+BmE3qM5S+CS3Zcs 1lzolBqxEksc+VIyRr5dmX5/lefF3TXDo9yUFozJHTTCW4gGaZbbvYr4ANPlU76k PahfIPWZFawYp5gGRWNaMpFpGAWfJpS1DaX3KRxFN1JA/FVA8uCplgDXP2lL5WrE 1SIvpel/ycVOspvlTsO+4YqAykqSu7esFnsCqZQ370iZl+G8JVLCnxhQiVmI1QD7 mbInusxR0nbud7s/AcLBTJA3+zeRw3sYZXmsBAH+aN14Jfw1rcogdQHRrsO+tksn /OjakoH7l+FVe17VKruyMjaPDUnlX2KXeBwEabx6t6lBKa06ctWjEUBX7rbVAQfc A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d740ybbt3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:31 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKUEC026867 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:30 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:30 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:30 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:30 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgU014225; Mon, 30 Mar 2026 07:20:22 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 01/13] iio: adc: ad7949: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:44 +0300 Message-ID: <20260330111856.121589-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=ANnNY0ku c=1 sm=1 tr=0 ts=69ca5c7f cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=5bXQaU6tI9Ar1A2g10wA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX3hQsbx9z5May 10l+uvnX970e18V91QuAFL/dWJi+P+FPvGi99+ST2tUR98Wg2c9HGIF6EL/9WTSkLj0PIdvoL+5 5ENmkGDNG07Z2MmXn+so5xNaMYmRwDMzj/LznHAKdKi3rNm+urpmIZANlWCqXQ3dUzoW8jxjHa+ 1xoi2FGCtKkS/qKo7IO+cYCOcsJr/aLv4B85xKGexB3Yxiy803bkQ21wILwIDOSIdMDUWFDcJh+ ljCDM8yTu8eWSXn4Vby5YCS6oJ2WzEhcCzfHDkqObFoEoEG8hTlZ772YlY/i1e54eCYGG+Ea3u3 bPfG0zSq+AY7c3GHXcksO+sXzozYTct+4NUWlztB1OjdnBiltTl4/qQlRqxykE2rHgr4eJFnBte VBaoTbyrXA14CWbOyfV2FnMeXgnDgmhKTloVSI8Ir910ECRdi3bRKTS3aqwMvPRnW5ZYrb3RviC VhkArvmVQNWGEip7H5w== X-Proofpoint-ORIG-GUID: 34p50CAAQyJSLmd8sjmYpVpZtzKAcmwV X-Proofpoint-GUID: 34p50CAAQyJSLmd8sjmYpVpZtzKAcmwV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7949.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c index b35d299a3977..ebc629bcfd4d 100644 --- a/drivers/iio/adc/ad7949.c +++ b/drivers/iio/adc/ad7949.c @@ -341,8 +341,8 @@ static int ad7949_spi_probe(struct spi_device *spi) } else if (spi_is_bpw_supported(spi, 8)) { spi->bits_per_word =3D 8; } else { - dev_err(dev, "unable to find common BPW with spi controller\n"); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "unable to find common BPW with spi controller\n"); } =20 /* Setup internal voltage reference */ @@ -357,8 +357,8 @@ static int ad7949_spi_probe(struct spi_device *spi) ad7949_adc->refsel =3D AD7949_CFG_VAL_REF_INT_4096; break; default: - dev_err(dev, "unsupported internal voltage reference\n"); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "unsupported internal voltage reference\n"); } =20 /* Setup external voltage reference, buffered? */ @@ -382,10 +382,9 @@ static int ad7949_spi_probe(struct spi_device *spi) =20 if (ad7949_adc->refsel & AD7949_CFG_VAL_REF_EXTERNAL) { ret =3D regulator_enable(ad7949_adc->vref); - if (ret < 0) { - dev_err(dev, "fail to enable regulator\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, + "fail to enable regulator\n"); =20 ret =3D devm_add_action_or_reset(dev, ad7949_disable_reg, ad7949_adc->vref); @@ -396,16 +395,10 @@ static int ad7949_spi_probe(struct spi_device *spi) mutex_init(&ad7949_adc->lock); =20 ret =3D ad7949_spi_init(ad7949_adc); - if (ret) { - dev_err(dev, "fail to init this device: %d\n", ret); - return ret; - } - - ret =3D devm_iio_device_register(dev, indio_dev); if (ret) - dev_err(dev, "fail to register iio device: %d\n", ret); + return dev_err_probe(dev, ret, "fail to init this device\n"); =20 - return ret; + return devm_iio_device_register(dev, indio_dev); } =20 static const struct of_device_id ad7949_spi_of_id[] =3D { --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E32573C1989; Mon, 30 Mar 2026 11:20:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869656; cv=none; b=UHwGqWy9Y/yhWsRfUyEG29rJl3TuwhDgPfyMLb5qg7W9Fw/kYhrNLbZo0eFFdUmuxBDwjU38wbHx8XPku5PHj8rdJ6iJQEW8qV6QN00p2eoprNSbobMFavh6OQMcV7sX0R9x9h7sxISv+2WJrmtAJBfIoZsIpjaEHg+fBV8DeEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869656; c=relaxed/simple; bh=pKkY9Uod292N/1rIK/h5daGmGASBQjUn5scJABLEqEA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X/WYclt+rXBlNUoqDSc5rJXvuhZaOJPe4+s/qV99AxrZMA/6vSwQa2M4VVP6YI5aFTs+nua7/wDGNjXPdQ66gJX6ud2zfjCo9IpwfGVfysw6nBEh4mzygMWPTWkEEaXpN+q5Ajjp2at1FXJHN7iuudrCvw3c4HlFpBp4OCBSrSc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=uYDeq5w7; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="uYDeq5w7" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwHKG3973205; Mon, 30 Mar 2026 07:20:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=+66oZ D1OrsWnVACGpzeP2IXK5Bhg4F1abw7VYwtnhy0=; b=uYDeq5w7bJ54ERDobjclo kvltCPXMB2fGeyKfcPYUeVmlrVgqYAaMvmFwiKxdW0Vp5UTdVH+wQ5lFGHSU5Fd8 IuVMQ3CopacTe31AGjG1yJGTU10CagCO7ZU6w7ObIMoQVRgE7EWGKVYFEk1dAm8N aOZ1YbfiTkvJcwJeASR7GaF49o2Ee0EZRNXkgtb8lNpnu+M0UZGoANMByOwdm1OH 2KbeZKoD/ndbLvJQp0tf9Jvvhmnsn4pHPK0CmtlRD+DmTffsPnLvFVGLadwOZV0T 1KyWoXxJObpVu1wxpaZn8ASIKKc70Dus3Psck5nOtbC/ONJpyOzwSW3FlJ4kx/Mj A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d7gkv9kee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:30 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKUsM026864 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:30 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:29 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:29 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgV014225; Mon, 30 Mar 2026 07:20:24 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 02/13] iio: adc: ad7780: add dev variable Date: Mon, 30 Mar 2026 14:18:45 +0300 Message-ID: <20260330111856.121589-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: tb2MX7Lt-MORPIaCmEFzrScg4IvgorA8 X-Proofpoint-ORIG-GUID: tb2MX7Lt-MORPIaCmEFzrScg4IvgorA8 X-Authority-Analysis: v=2.4 cv=TeqbdBQh c=1 sm=1 tr=0 ts=69ca5c7e cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=hkRV8TbGJaEPuLU2XnUA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX6tvVaTgeC/vB egrh7fhlsDdOGXrFMLoKuDEdOQbLMNXvSTvZokRCkykPtdoHG67SxqTMpsPcaCztFFSJD84Ax7w M1cXlMuP3/EYR+yTHoKDRtBhwjx018Q3LraykMBn+CVPjG1JFfV7r5AkUFgUB3fMZ8Mk8I5gXXe liOaPMhCYAMZOEYOnJ39C2Nt48NHVUjk1gyWF2C8F9FP684KLWyoi8KMGNkXiCShVKrp16XHcfR rxz++7t8tuMRU5sYEpaUuB9HWFyGbiYylBTBqdcz2ir0AKZ/qUaWaaSG3fVw2VEh5Q/8FhrCZ+X joh3X230I2dSwEODhKn7VJ/SB+58/pGCgnZ2hDmHFanDwCrS4Kg7XH0rLEX5v4zfW+IpFBXAJep m0TotAxfRSy1sO6g9Is/vZrnellk1b1K9D5uYIV8c4IulPVSYqA5D3zDsd909taxZGQFwWHiEU+ wgQrMt1KlZChFssDiqg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1011 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Add a local struct device pointer to simplify repeated &spi->dev dereferences throughout the probe function. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7780.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c index 24d2dcad8f4d..4c1990e27213 100644 --- a/drivers/iio/adc/ad7780.c +++ b/drivers/iio/adc/ad7780.c @@ -307,11 +307,12 @@ static void ad7780_reg_disable(void *reg) =20 static int ad7780_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct ad7780_state *st; struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -329,11 +330,11 @@ static int ad7780_probe(struct spi_device *spi) indio_dev->num_channels =3D 1; indio_dev->info =3D &ad7780_info; =20 - ret =3D ad7780_init_gpios(&spi->dev, st); + ret =3D ad7780_init_gpios(dev, st); if (ret) return ret; =20 - st->reg =3D devm_regulator_get(&spi->dev, "avdd"); + st->reg =3D devm_regulator_get(dev, "avdd"); if (IS_ERR(st->reg)) return PTR_ERR(st->reg); =20 @@ -343,15 +344,15 @@ static int ad7780_probe(struct spi_device *spi) return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, ad7780_reg_disable, st->reg); + ret =3D devm_add_action_or_reset(dev, ad7780_reg_disable, st->reg); if (ret) return ret; =20 - ret =3D devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev); + ret =3D devm_ad_sd_setup_buffer_and_trigger(dev, indio_dev); if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7780_id[] =3D { --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C3E37C113; Mon, 30 Mar 2026 11:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869657; cv=none; b=uppAtqYToGHeqA5IQqGkZpPyGStnLHPUU9snZwfJIYeTtW/hJewThU4pR8PyC6Q69nbT3FU9Gh3MtboLI7YOEy0UN8ptMXU/PuenKaDPDRWfiGbqvTGGtbjO72WgCmrN4rL/QHJCDIexnLTNUUz4f7b9fN77wWVkwF+oetnePfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869657; c=relaxed/simple; bh=JZdRjC8+BZFhcwq2gjX1TR6ONItuOQS7SEINtpqxhts=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=beHPgX0pynL5CqiFcHOt7e7FU0a5fgOlO7/NG22n13DkDzVeWHPXdKCdqLKqM13etKbTJSbjoqXMnGsppqXmG18MSxLT6J+nY/LeITQdq6TpGASj1+X8+vWAptYpGDPhLrEsABYDqyIZNAJ5P7zkoI6xVryPBhIEmmv+3dnUUjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=uyyX6ny3; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="uyyX6ny3" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAw7sq3973001; Mon, 30 Mar 2026 07:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=rdVPl LrdYkuoG7++joWcI7oIDaYPGkzdu/KItXnowZw=; b=uyyX6ny3fX8KeaiJOeNYC 88Tada4VJ5uIGtaywysS5kLKkEq4JguhynOUCE5ngVYiBPQBosuiWQJbKQ6uR9Pe yHHS9J2Oi0HYSNFGpv3xXD1SS6OQlA/78DSdNJNeUWTHo/3NGYyPlxX4AFqS46tC n6dy1b4rvZp1WSFoCs7Br4O/yzvPHj2d8LUeehD527MuRctDUKuf1S5j9pigw80R 8aAK1Oj5Y9O5I7HatFf6kg5RU8dEbY90TVakGUC9JYVqPxNjwplq6SXeDCtkWjxd 0/bg3Y7Qv2KWLFkV1ATPLnrd215MrP+bh4VmP9SaFvB6U0saU+QZkY+Wrlj0Op0o w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d7gkv9kej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:32 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKV7k026873 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:31 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:31 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:31 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgW014225; Mon, 30 Mar 2026 07:20:25 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 03/13] iio: adc: ad7780: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:46 +0300 Message-ID: <20260330111856.121589-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: R9skgND3amYOn2ID_bwDECn36ttUqJWs X-Proofpoint-ORIG-GUID: R9skgND3amYOn2ID_bwDECn36ttUqJWs X-Authority-Analysis: v=2.4 cv=TeqbdBQh c=1 sm=1 tr=0 ts=69ca5c80 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=0a4eyNQZxP4F6lfmbKAA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX7kDgJBs5S/vx pgBC+fkdZ68xDbch4+6I8kCDvFIROy+upLIs+IFcPiBdoPreNKOlxpXGEuIQyggu3lhd6QnP3Ge UCwvB4lwcohPic1raFf3vObCPZHdrsdtB24JXtdv+tY7OSDkVGc4DaEn6dhcF0oIMs9HA6lcCg/ eO8rkdFQ6NWrj+ztzqoahhLKnrDsCKFv2zJHCEJ0lcS/pRlA0P1/6R4oEnQfetAYVbY4KWxC+c/ l2ntjSudt/NcthGKkrrOxq4Hay1zgHaGggTmW1pGIb1blCg9GZmZVfjYTyFOgkxEfM4v8Yo+0Sp jqTYZSPBYgizMMUbstsXyDJnEbIVKm+mF4BmxRRUe5usAcYupsQoOoGmDN9NpscB97WTibZQa1T cr0YQ0XA6dvadPpW0Ac2KftmxtEW896Ip6jQ5+AFwVowlntWDV5kM3HzGfWiNsTHTdpAMDXCT90 IUaaB4b5OIDfbCMoaNw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7780.c | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/drivers/iio/adc/ad7780.c b/drivers/iio/adc/ad7780.c index 4c1990e27213..26382b1f8c9e 100644 --- a/drivers/iio/adc/ad7780.c +++ b/drivers/iio/adc/ad7780.c @@ -264,16 +264,12 @@ static const struct iio_info ad7780_info =3D { =20 static int ad7780_init_gpios(struct device *dev, struct ad7780_state *st) { - int ret; - st->powerdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", GPIOD_OUT_LOW); - if (IS_ERR(st->powerdown_gpio)) { - ret =3D PTR_ERR(st->powerdown_gpio); - dev_err(dev, "Failed to request powerdown GPIO: %d\n", ret); - return ret; - } + if (IS_ERR(st->powerdown_gpio)) + return dev_err_probe(dev, PTR_ERR(st->powerdown_gpio), + "Failed to request powerdown GPIO\n"); =20 if (!st->chip_info->is_ad778x) return 0; @@ -282,20 +278,16 @@ static int ad7780_init_gpios(struct device *dev, stru= ct ad7780_state *st) st->gain_gpio =3D devm_gpiod_get_optional(dev, "adi,gain", GPIOD_OUT_HIGH); - if (IS_ERR(st->gain_gpio)) { - ret =3D PTR_ERR(st->gain_gpio); - dev_err(dev, "Failed to request gain GPIO: %d\n", ret); - return ret; - } + if (IS_ERR(st->gain_gpio)) + return dev_err_probe(dev, PTR_ERR(st->gain_gpio), + "Failed to request gain GPIO\n"); =20 st->filter_gpio =3D devm_gpiod_get_optional(dev, "adi,filter", GPIOD_OUT_HIGH); - if (IS_ERR(st->filter_gpio)) { - ret =3D PTR_ERR(st->filter_gpio); - dev_err(dev, "Failed to request filter GPIO: %d\n", ret); - return ret; - } + if (IS_ERR(st->filter_gpio)) + return dev_err_probe(dev, PTR_ERR(st->filter_gpio), + "Failed to request filter GPIO\n"); =20 return 0; } @@ -339,10 +331,9 @@ static int ad7780_probe(struct spi_device *spi) return PTR_ERR(st->reg); =20 ret =3D regulator_enable(st->reg); - if (ret) { - dev_err(&spi->dev, "Failed to enable specified AVdd supply\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to enable specified AVdd supply\n"); =20 ret =3D devm_add_action_or_reset(dev, ad7780_reg_disable, st->reg); if (ret) --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FB23C5DB1; Mon, 30 Mar 2026 11:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869664; cv=none; b=mu/NDSxoJ3ONURPueamxdwWOyQrgv3ml8J6AUMHeSxsrdfhMQtziYC3VtO/wH+WavNP9cr9hNpp74qofNnpE3ZMrDsMoRgv4tdMkv3YNvFW83X0kTpkXcCEv4e8xz0ae8fJPb5qFNOql+F8AsK+1IKmXSUe5kN7uPMe/6lYQWeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869664; c=relaxed/simple; bh=WkbsMETcrZbavo/sscetFZr/SEVsZ2wdFx7akWJKLGM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ndqgDLzHNBSca65mwKIVT9fJhSpPh3kSfvxy4JUtyUwUF7s7+hLekxe43+dAjdb1Edq+N9k7DMADF/9qNEiRkapApWPYgq/HmuC9T2im5nQYgxRdnTmkD2Hf+JpExT0pTss1B37Ewh0K0Ya5eWzgMZinSsR5qIFR2St3JS9gJQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=HiFpM4Fh; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="HiFpM4Fh" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwKOt3973543; Mon, 30 Mar 2026 07:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=GB4Fg 9w1FCmgADZmdu4Yv+DTzfZkc3nKNEy5tEV+evQ=; b=HiFpM4Fhc8GurisLdRvFh Yjg8Y6927G6ujQin4RUmXuQqylwyC0kpeL2/CEJ5zZSwpTq6V/TCZdH26WmNDkFg 41m45xCF3DZ/Wxi+GExX841or7zlFpZ6jWeHgpWqeuYiDi3cLLZvJHkINAceY+Dr xOCaY0adddNPj3rZHBc+Gb9DPPdNtWeREEC+Bldc78BYL02U1/hP6MWIwtey3AAm mjZCHg3Ow7A5DS5WYATGz0Beue2mIZ8UJ0RIy/zkBZsWvG2kXNdjFViB54use5P0 VcLlnoK6wb3u8M6TlkbmcDuzvvQwcJ4v788jrKk0t6IUCNkRKFTGcL5i5UVbTtHD Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d7gkv9kep-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:37 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKawt026888 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:36 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:35 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:35 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:35 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgX014225; Mon, 30 Mar 2026 07:20:27 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 04/13] iio: adc: ad7793: add dev variable Date: Mon, 30 Mar 2026 14:18:47 +0300 Message-ID: <20260330111856.121589-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: TVaIwo2K4-MpBCkMZxkh4qpwquv_tuNV X-Proofpoint-ORIG-GUID: TVaIwo2K4-MpBCkMZxkh4qpwquv_tuNV X-Authority-Analysis: v=2.4 cv=TeqbdBQh c=1 sm=1 tr=0 ts=69ca5c85 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=ZpqOwzHjV6la0-d30qEA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfXz2oQz3FEIKFc GQA8F5W4XrLPgSY2rY90bM5rA0ePd6UifxiJSpSbIcfSZeEAC2ZLmGexUkMs/A9B4D15R4B60NZ fJDSWs5k8/JH7xH7laN+Am+n+Jz6NTVq5BZKK/jywcavP09MLxHHAHgDaLk7IkGiJq+ETGpEUoZ 84ynpnBZbMVzgPy6z3rtsCrG1ierr/+wj59eym1Dg9dPzRHUuVSSWfa5/rCg9ON0PweJjNQkKs6 YLdX3e3vuhI6PggHFT+c93NsiQFghTp+7BeR8eXE3yxjpHtZfiwNKC7kia/8e/UQhEMwX9VfHq2 rSTn6E4cByAQoIs1qtIzFhXqUcYT/+UhrvQUnb/jWfPunxJG88l1VX/h0sDmWm3/ZhA8W5gk4F3 WSsmnAITJBkDYFASMeX2mX3OAoI92cpyWyNLCgsVDMxDc8H7ekAmCyxWRwM9m767Cy9+Fb0X8ib WlovR+WifxetsiZ+66A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1011 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Add a local struct device pointer to simplify repeated &spi->dev dereferences throughout the probe function. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7793.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c index 8ff7b70d6632..21c667e37b31 100644 --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -774,7 +774,8 @@ static const struct ad7793_chip_info ad7793_chip_info_t= bl[] =3D { =20 static int ad7793_probe(struct spi_device *spi) { - const struct ad7793_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + const struct ad7793_platform_data *pdata =3D dev_get_platdata(dev); struct ad7793_state *st; struct iio_dev *indio_dev; int ret, vref_mv =3D 0; @@ -789,7 +790,7 @@ static int ad7793_probe(struct spi_device *spi) return -ENODEV; } =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) return -ENOMEM; =20 @@ -798,7 +799,7 @@ static int ad7793_probe(struct spi_device *spi) ad_sd_init(&st->sd, indio_dev, spi, &ad7793_sigma_delta_info); =20 if (pdata->refsel !=3D AD7793_REFSEL_INTERNAL) { - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "refin"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "refin"); if (ret < 0) return ret; =20 @@ -816,7 +817,7 @@ static int ad7793_probe(struct spi_device *spi) indio_dev->num_channels =3D st->chip_info->num_channels; indio_dev->info =3D st->chip_info->iio_info; =20 - ret =3D devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev); + ret =3D devm_ad_sd_setup_buffer_and_trigger(dev, indio_dev); if (ret) return ret; =20 @@ -824,7 +825,7 @@ static int ad7793_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7793_id[] =3D { --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9271E3C5DB0; Mon, 30 Mar 2026 11:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869664; cv=none; b=cWm10r/BoTeRy7cxGp04nGcUCGVXE8KLaoKQmk1PSFf89NQvbsX9mlpOT46GUVYdMo81EXWOMl4jW4q+kV+SPY6k/Wv9Gpad9Fadsm/2qVlfp2Q6AA8kxFAEo4UdKHtv4cx4cUaGDhV6m6iw3HhJ8QhMkL9L3DF7uEAkkTuYV7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869664; c=relaxed/simple; bh=kkU7Xhy3geAlDcN2sR4Z8MdZNXkXSwqhJihLYHrd5dE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PUkKFyDCdPpcIoO80SP/X6eyWEr6KVfhWhAmF+ONoer8P/wokhsV/4Yoc9f4SHLnPTlJP+OSA/fc3gNMHFsZqUuJ/NGRSxbPoqXm4vfJc3yzKErfTCCtMKhrpjyB8H1W6/iP9WG93bzYdmUayLWTgKUas5W/FlPVgPpc5bdlhY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=cf3zJz2L; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="cf3zJz2L" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwAUM216998; Mon, 30 Mar 2026 07:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=z6ev5 v3cOGVegvUFhUo2M8XWvFMj2W2PJcISx4umswQ=; b=cf3zJz2LZFn9y73AtJ1Fw wQM3xz6cyVu+knVxw4CwwdvymuYaYE4sajyIWp1iziUJh3TSOwC70Q4aug9YBwIp EnqbPFZv707QPOmk5pcoLxIRyAqYd8LtrDCINYI4JMalcsi+OqzngOboKTqux34q szQA22uGtqhrD+Gc4IlTCBv+T+FC971UbygZeETPFVn3NGUi6/VAJrB1IZJdgthv 5kSXc/3/oHxFTLvFKhL8W8iznpiMIi6sXO3m8WdZAXQrOO/ZNxrpPTY1gnfzQmtZ 5eQJXwHtpOvT+Rmdp8Jv/5rHKMyC0kNM5XOc5K1HMAb5G347qxLLBJdYDWZD257/ w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4d6wab477x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:38 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKbF0026894 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:37 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:37 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:37 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:37 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgY014225; Mon, 30 Mar 2026 07:20:29 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 05/13] iio: adc: ad7793: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:48 +0300 Message-ID: <20260330111856.121589-6-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: A6AsEtvyxR0s-Chty-R27F71qxYn2gpU X-Authority-Analysis: v=2.4 cv=YJmSCBGx c=1 sm=1 tr=0 ts=69ca5c86 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=t-RRPw6fO018OCHZOIwA:9 X-Proofpoint-GUID: A6AsEtvyxR0s-Chty-R27F71qxYn2gpU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX/eHixe1b/7ar zu7ZvfmySiXgrjr+LGGjQZckTow4j/knqZ1648wlpuMFZWafqCZlscW5hcbHqJWfd44FNCrKkVo Ew/O22kmOIOxJswVE1nCdhGYC8Oj7rr9/2MxGM5o5v9ytCfpl9i2QEE3d7MRV3S8o9/ptxY1Nzq YKR5am2tPyAjc33E8DOxqbjIuJGxzboMqZQGbenJhyOLZcyxXEgp6meDeNkp8PCx26OpKgZqZtH kiZQG/ao6kjedlquSyoN91ZEsZZ08PtJ08zmZ3mkWbcpGIYolZCTh5d3E68JDktPhpu8vmCyqRO R/hAhIcj/EvO3iX5nwEApVg+jf6aWjBmP3AZOdH0Z1G9qObyZHARTNH8vVhb5bbGSaPgMcVPcxZ qHIW6EMgBAaHlyoJe1Wwooaekf1bPLVaU3jsentN93UyCwk7LWOgzIGNWZVdXyP61jRZsBjPT10 1E46wWwwOWF4C0KuYdw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1011 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7793.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c index 21c667e37b31..624530cce938 100644 --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -278,8 +278,8 @@ static int ad7793_setup(struct iio_dev *indio_dev, id &=3D AD7793_ID_MASK; =20 if (id !=3D st->chip_info->id) { - ret =3D -ENODEV; - dev_err(&st->sd.spi->dev, "device ID query failed\n"); + ret =3D dev_err_probe(&st->sd.spi->dev, -ENODEV, + "device ID query failed\n"); goto out; } =20 @@ -338,8 +338,7 @@ static int ad7793_setup(struct iio_dev *indio_dev, =20 return 0; out: - dev_err(&st->sd.spi->dev, "setup failed\n"); - return ret; + return dev_err_probe(&st->sd.spi->dev, ret, "setup failed\n"); } =20 static const u16 ad7793_sample_freq_avail[16] =3D {0, 470, 242, 123, 62, 5= 0, 39, @@ -780,15 +779,11 @@ static int ad7793_probe(struct spi_device *spi) struct iio_dev *indio_dev; int ret, vref_mv =3D 0; =20 - if (!pdata) { - dev_err(&spi->dev, "no platform data?\n"); - return -ENODEV; - } + if (!pdata) + return dev_err_probe(dev, -ENODEV, "no platform data?\n"); =20 - if (!spi->irq) { - dev_err(&spi->dev, "no IRQ?\n"); - return -ENODEV; - } + if (!spi->irq) + return dev_err_probe(dev, -ENODEV, "no IRQ?\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (indio_dev =3D=3D NULL) --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBD2B3C5DA0; Mon, 30 Mar 2026 11:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869663; cv=none; b=YrWDaJBOY8/cf50mcYwracf+THkJ1vNwqsmxqu5hgGFKp2GT25ygtQkmb0ZBHVLdHrD638I+CidwAYV1KjLiEsCdgJx6shUdqgqxacrzC+gQ2wMNnv2dYKvfQrYYQFUhrX8ad9cet45ONMwV+YpANZrgvrSVgYMGTExErKElIts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869663; c=relaxed/simple; bh=m9B+u6RfIIHkXUE4GM+Y1kUNK5pZSHQWBcWQ3QVqvQM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m7Pugwh/KzbNse+acyQdkiFA9bojpi75BbQKaYS8Q44iO6I7deUlYj9SOJp767agQGE62U/vaoCoMPqoeES6qmheofdfd3q2qHO2sdpXC3PAQ1/w6mtlZMCx7uMzkehEmlcBazj5L0DPEy5Z+UpVcGPcRDhkMbS+ORu+xnfF3TU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=D7x5vAji; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="D7x5vAji" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UB0SLQ1037170; Mon, 30 Mar 2026 07:20:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=VH3Yb MevbBgekDyPQ32AoddQYfOLus4euxdyGF8Iwnw=; b=D7x5vAjizEPwBh3oEZ6ky VfBdAsh5TWFGdvO3S7nGWfK2YytVTHzFLqfjHEC5tvA4b6Bx6vst4mfPb9UbwE0d esNp49COOCTJt3RPHE63h+ulCuD0lH+aPtuf/4F0jwCr8yP7nIujT/yl6qpNLLbi t5DEFyp94mL1IdZ5u57RUh57cHSN4XrUrKRd5UZ0C+FL/F/oBGHLnp6AF/7npRvA 3KWEqw25x6sVCGqS7gjvwRvEATbynpB2svj77KcoYHp5RlojJgbdD30Z77jJsUdH BbUlzdVWJyNCbXTg+JwRdq1xhg9vzsaaTU9tEaE3AP+G57IwKmEmEtImQPhZ8AX4 Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d740ybbte-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:38 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKbiX026897 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:37 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:37 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:37 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:37 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgZ014225; Mon, 30 Mar 2026 07:20:31 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 06/13] iio: adc: ad7292: add dev variable Date: Mon, 30 Mar 2026 14:18:49 +0300 Message-ID: <20260330111856.121589-7-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=ANnNY0ku c=1 sm=1 tr=0 ts=69ca5c86 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=ZS_pxjKD1y5eJwAqsaYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX3SL6luomgifD X6cnRRc2QIWq+a8EHAMScDxVsaALXBThaiBugRzbjDCQNNyNItqaaO2G2HGkftOGM1ozCzbA24K iejtJzlkmDAwLFx0q2RWa5547sXwUZSHSZcczDEtPYl+Egi52QjptXf9hBKPS/d3NJySjZj0H+B 84ZtyGVkFU93G8IfW25VK++Gnr3hr05BufeRVP3ZD2OSZZfXr3E6GH8BrLDL+1j1zfof93IqPc8 AhRFW6yL5IrJh3Cku93W4rixv/9YZQOVDgDjbWmrcUu0+wuUchcaJTn7l3e8qsUZMmi59r0Lnow 58r5qvKvC4xFkKFw9dXMWlLCcJeyJMBlFuO5eAqIMAGm0aTrIg2Q1bhekCpPksTvPiEoTxhJkvB iBO2DJcXAU2lsSIFb7FqPC/D6rIm+wor+IS4SxunYikMLbw3wb/lDtZhVv7lID08InA2RYQh3K8 FQKcasmn9yeJU2kir5A== X-Proofpoint-ORIG-GUID: mGN0Ezv4gNwaSVF_LFbF9apnodlrdZmm X-Proofpoint-GUID: mGN0Ezv4gNwaSVF_LFbF9apnodlrdZmm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Add a local struct device pointer to simplify repeated &spi->dev dereferences throughout the probe function. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7292.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c index a398973f313d..64d40b053582 100644 --- a/drivers/iio/adc/ad7292.c +++ b/drivers/iio/adc/ad7292.c @@ -253,12 +253,13 @@ static const struct iio_info ad7292_info =3D { =20 static int ad7292_probe(struct spi_device *spi) { + struct device *dev =3D &spi->dev; struct ad7292_state *st; struct iio_dev *indio_dev; bool diff_channels =3D false; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 @@ -271,7 +272,7 @@ static int ad7292_probe(struct spi_device *spi) return -EINVAL; } =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vref"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vref"); if (ret < 0 && ret !=3D -ENODEV) return ret; =20 @@ -281,7 +282,7 @@ static int ad7292_probe(struct spi_device *spi) indio_dev->modes =3D INDIO_DIRECT_MODE; indio_dev->info =3D &ad7292_info; =20 - device_for_each_child_node_scoped(&spi->dev, child) { + device_for_each_child_node_scoped(dev, child) { diff_channels =3D fwnode_property_read_bool(child, "diff-channels"); if (diff_channels) @@ -296,7 +297,7 @@ static int ad7292_probe(struct spi_device *spi) indio_dev->channels =3D ad7292_channels; } =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7292_id_table[] =3D { --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9980F3C6619; Mon, 30 Mar 2026 11:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869668; cv=none; b=LTGviVozJcpLRaRG/TVmSaJAou5AWrQhwNV+kAKAPVVt3jT2LgnraICzW84YYGPsH9vU1+6eAMob/sv0lQwYUc3LEHkGMetEUhQodIiSQP+g23rWzgYlgPyC+X/iMS3B6r2sLdFAY4mT3Z7yPnG/7gxfsAISTzhFLJjGsBRHeqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869668; c=relaxed/simple; bh=bkto8uHvJrKzfl1e/kYuUEj35h/fcuZeOlw/ZZ7/9T4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GYY4XFLGga0flW6XTjsunhfgrJhiC4glr3mE0piyVQb677nYY0ZHzjJdJ2k7MXBWtu9uoNi3GmovWdvuSH3+v6VlOckq/zks3US1hTcLpwwWpnBZ03O+psCZ6BFmJD0jmm1jAA5wQrPFvdrc8uGLggLcqrsewtMNJzF5G1XyOEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=iJ47EbOF; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="iJ47EbOF" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwFxE217508; Mon, 30 Mar 2026 07:20:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=V41Ni eJEo/xS5gJz+bLXGJzpAjFEx1WqetW7gu/sYh8=; b=iJ47EbOFWTjGnoXabUK59 B8XK0VksDRTo3SZloouRbI0Y599t953wgwaK3acU/kXLg13X5wCK9tQeAN1EGFMk K/Xd0Zni2y1uyg9zkXekf+N/dVquBO2G1J3ozKK/3278Vre4kKEXTcPuMVuwy/sI ieRu7dybLC5WNMbNd+rls87WzTAYoZSK0dhBlPSFIozpQXwJmo9A655NQDCIUxx6 qIeRM+IdgbLDJjUJffUJX94b7OhtHyQSc96OPHkfNtbwBFZRhGnH9slkowzI9PRR WP/AHGq+QY8+/XlnjOo+PrwYmaZ8flRjL0GChLkNNkBR3HJxQWrz/uMNGUgjl+Fd Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4d6wab4782-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:41 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKehq026915 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:40 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:40 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:40 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:40 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDga014225; Mon, 30 Mar 2026 07:20:32 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 07/13] iio: adc: ad7292: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:50 +0300 Message-ID: <20260330111856.121589-8-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: DLhorja5KVU-fR_QQpI_WCg4xVwUjbs9 X-Authority-Analysis: v=2.4 cv=YJmSCBGx c=1 sm=1 tr=0 ts=69ca5c89 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=K8fRmz8qadsuYCWvO-IA:9 X-Proofpoint-GUID: DLhorja5KVU-fR_QQpI_WCg4xVwUjbs9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX4PTKm9gOSp0L TvnvZVVYY/qZvVuPwOvZj4/j8NgD8p1A2z800x1OXCBNPOq8SXWNUOY3jv2+Q7ecHA8PBWvUxQI DjIqp9kTv1/sd7KadRxDgu+jJUW4JKCjQzMpH45oRLJB5QEuram0aNQGWySxeo0kcOJ1cPJJDRg p4stELQN5bySVq+hRbfgWjF3F0opRstnqvY7YUW2+/VPBOWtxPGnh7qhxejux+DUdo2tGNCFiwp cJtepBPNIlpTB5+BFr74nkicCduMP8ejhGX+bJVxA3dvGLnlSYfQF6hTbrNShljYKSu+JhSj3zT z5fkXU4i/8hjZVjyUIL8Oc2ColqrHope0BH7+Uz75U1BQCRjCpgA8rk+TJSWcUg+Hq3T5qIO6Tr 1krtRad+Sd7NRN837TxSNIbY/T7iHHhtWN75LP/mTnbpKL45Ev7WVsfFxsFKcOoI752jIy6OOoT TNll3AEdTMxuFWhjOmg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7292.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c index 64d40b053582..e5ad83d2240a 100644 --- a/drivers/iio/adc/ad7292.c +++ b/drivers/iio/adc/ad7292.c @@ -267,10 +267,9 @@ static int ad7292_probe(struct spi_device *spi) st->spi =3D spi; =20 ret =3D ad7292_spi_reg_read(st, AD7292_REG_VENDOR_ID); - if (ret !=3D ADI_VENDOR_ID) { - dev_err(&spi->dev, "Wrong vendor id 0x%x\n", ret); - return -EINVAL; - } + if (ret !=3D ADI_VENDOR_ID) + return dev_err_probe(dev, -EINVAL, + "Wrong vendor id 0x%x\n", ret); =20 ret =3D devm_regulator_get_enable_read_voltage(dev, "vref"); if (ret < 0 && ret !=3D -ENODEV) --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2ECF3C6A25; Mon, 30 Mar 2026 11:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869668; cv=none; b=k5E65abrq/U4Ysbo0OxBINlAHTlmYnHLo/MAhR6qNbmGxI4AcVBm110MuQuPIf6t9pcYZbGzvrmofUbrSSn+T6EtByMiRLkLt0045K3+EWcoP+s5VuwJXEbbtolqMYlYlorClZg+XEAJHWKuXb7ZrAkUN62Jx0SnybXQHHc5Yt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869668; c=relaxed/simple; bh=47mVUW2psllq0uhogJHNG9F8n8nba0TWZqKrUOzLChg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PVq7G7n4G9YnqsG1rHgwF5lTiV2s9XSSrsKrkbQ/b+kE3FU1/mKTOssa5K8OE/EOOet/5aL/IqfwFyIO0MnGWsb9KnG7nz/NBWb4BbcsD+RxI8BjxLBe5S+hw0ShxwEMTGcAqbB3lPYIQYAVkDNMraJ4t1Kl9zO1zCEjkyhR1/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=ykpJAM6w; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="ykpJAM6w" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwJqK2844923; Mon, 30 Mar 2026 07:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=2Fxoe yzIAW10Eh10xTn7QFh3pJaxE+OXdOfFLhBqMzI=; b=ykpJAM6wVTkuuzf/3URP6 rVrCoxDhbVBbR4+GuDw/sTbFWohm1zHJrPLGD9uv/ivxzJo/mWzW1k9mPikFgR3N AjLpkgqyAJTsHr91NEd0eiAFf0i4iYqluCO6vvgG+ECVJJ8eHpxxBzFWanQjw53K TTC6BJ2xmM8DvD+38b6XKL1rPbnLuCrXC5Ze/2N8Vm0HU31WCoBjz0njEUnO2dKe AxEpj8NJiS8cArgA1HfTYpXTtqaak11mJxLL0v+/pWPjQ7LLG5/pCcDGGSYkQwrc b2DkYJTF6r+w+JK3TTilWMbgtVZotbinjrmmSoTec2p5Gdbr1KdjfyvsDW2WSmcV w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d6bw0xs1j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:44 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKgYj026928 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:43 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:42 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:42 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgb014225; Mon, 30 Mar 2026 07:20:34 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 08/13] iio: adc: ad7791: add dev variable Date: Mon, 30 Mar 2026 14:18:51 +0300 Message-ID: <20260330111856.121589-9-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: mpAj8H6K6hMpalFUszT6W82H_4BpZcRf X-Authority-Analysis: v=2.4 cv=BqyQAIX5 c=1 sm=1 tr=0 ts=69ca5c8c cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=-Vny9m8iCYfL8Uq4-AMA:9 X-Proofpoint-ORIG-GUID: mpAj8H6K6hMpalFUszT6W82H_4BpZcRf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX9npSaEQZCik7 +rY0RvpDnHutSo8YBIuVx78q7Y/dB1psOQhLI6wSxyccYeuT5qdxLyIA88fqiychJvaAGjeI/NK hAi6SeQghJIBONZhRt//9I6217o2V6VOJPQBVwqw8fSHDWJpck9pbvs2iepDNjDLZyEMIwdN1ht /3m38USiMYit0e/P3svPi27dWgos0tJNVw4BkN5eq1ALdnjau4Qwelg4TsHq9keBBWSLwHIyIT4 fLCTo0dPmp5TeTnEngG8NxXXAW7Lwv8fVvU8zIYgctI8rK4DqdRewejqL1Xg8Q+LaTn3ay4UUph S+l9cnAZna931GSvmJuLkSwLoJsdnj+gECOTxR9j4jO2RrE4Px7ZRnKg/xEQuDSdTqfKc1gwUQa bPqN91s2ZIjIi5BJ0T31cygB99TojLNpVoTUDawuEGiqk3toZi11xJDZG6EXQwOV76nvzkJ06Y0 InFVdnt56DsOgbFZ8uw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Add a local struct device pointer to simplify repeated &spi->dev dereferences throughout the probe function. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7791.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/ad7791.c b/drivers/iio/adc/ad7791.c index 041fc25e3209..ab1ab0d88492 100644 --- a/drivers/iio/adc/ad7791.c +++ b/drivers/iio/adc/ad7791.c @@ -407,7 +407,8 @@ static void ad7791_reg_disable(void *reg) =20 static int ad7791_probe(struct spi_device *spi) { - const struct ad7791_platform_data *pdata =3D dev_get_platdata(&spi->dev); + struct device *dev =3D &spi->dev; + const struct ad7791_platform_data *pdata =3D dev_get_platdata(dev); struct iio_dev *indio_dev; struct ad7791_state *st; int ret; @@ -417,13 +418,13 @@ static int ad7791_probe(struct spi_device *spi) return -ENXIO; } =20 - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; =20 st =3D iio_priv(indio_dev); =20 - st->reg =3D devm_regulator_get(&spi->dev, "refin"); + st->reg =3D devm_regulator_get(dev, "refin"); if (IS_ERR(st->reg)) return PTR_ERR(st->reg); =20 @@ -431,7 +432,7 @@ static int ad7791_probe(struct spi_device *spi) if (ret) return ret; =20 - ret =3D devm_add_action_or_reset(&spi->dev, ad7791_reg_disable, st->reg); + ret =3D devm_add_action_or_reset(dev, ad7791_reg_disable, st->reg); if (ret) return ret; =20 @@ -447,7 +448,7 @@ static int ad7791_probe(struct spi_device *spi) else indio_dev->info =3D &ad7791_no_filter_info; =20 - ret =3D devm_ad_sd_setup_buffer_and_trigger(&spi->dev, indio_dev); + ret =3D devm_ad_sd_setup_buffer_and_trigger(dev, indio_dev); if (ret) return ret; =20 @@ -455,7 +456,7 @@ static int ad7791_probe(struct spi_device *spi) if (ret) return ret; =20 - return devm_iio_device_register(&spi->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } =20 static const struct spi_device_id ad7791_spi_ids[] =3D { --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B073C6613; Mon, 30 Mar 2026 11:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869667; cv=none; b=HrTQg1x3bONJzTjWWxkjQ5Cto8656637wSrzNWLeDc9PNSye78iZBQ3hAl5JYzuKco237rwVDAuM3MU4PHd0kV2wZTAN3O7v27j4Zt4RJCMZhGmltHixvzoahxFAxwHJBG9LNPWCfDdd1684dhJmbKt95SWrb6C3TfnZbTcHXH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869667; c=relaxed/simple; bh=0jU1z4/HUE3tO61F9Zfpfm7igv3qZhCqED1/MvAh6Aw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ldBRCbJ70vKarN9TBZClWQfgvj4Stlv/knT1zgKCjKlLl1WXjeLSU+phUdz+wjxaUi4di2GWGejfZgnVmuvJwtseNDmPlDEaREiZz5gDu8ttPzUvzSZKYgEgJGPbMQsdYu6L5/450FBYu/+Y574F0jyGfD0KUInibNCb8tmxGOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=bdLZNIwP; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="bdLZNIwP" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAw8hk3973011; Mon, 30 Mar 2026 07:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=qMUm6 HOgYwomSyrlrKY6ZQWQ/oAnfYFNrTxyiWpnETs=; b=bdLZNIwPZAWbVY42dfnD5 3/sSRAzGnL2ub7OYzuS6Ep98bqqQ8xFy4Os786DKHNcFtt/DMBM1TNmoBj1DQICv K9xDAEZQz5Y938D0CwvUSUF3j2WVw89XiFMUIDHekT7ouJ7tFmd/SQSBld74MXE4 hBPQkdO1umxOpxzd9CcbhFaSxkJeO6qJCXeLQVCCcT3aKgFDqWUjvPngZqk39STg LuBxr0CgWeLah48ZJTrivcoGGtDsG5m+M+40Btfj9m+sDDGRibDWCmfoI8IpN8vH +bZPMBaX0bGcGQVtwdtnhu9MWyIMf+gwglWKEqGvM+6KN20xsF8mkjuAUkcC5n8Y A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d7gkv9kex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:43 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKg6t026925 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:42 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:42 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:42 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgc014225; Mon, 30 Mar 2026 07:20:36 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 09/13] iio: adc: ad7791: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:52 +0300 Message-ID: <20260330111856.121589-10-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: FGxbx9VDiWs6QpNJpuoS15FsBXp_94Va X-Proofpoint-ORIG-GUID: FGxbx9VDiWs6QpNJpuoS15FsBXp_94Va X-Authority-Analysis: v=2.4 cv=TeqbdBQh c=1 sm=1 tr=0 ts=69ca5c8b cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=2CiB3Z0a25eI0F54yJ0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX3dvn0hDBmzG7 rY/b7hyXT32uUAnPMQbEnYcUA8JZs7TLHasW+VFglCBWAU2GTgMPalKJyUFbkQGJva6fB1HxWmQ OJUTQ+adoBb9EKliLABhRfy89/xC53Nv9yZKfvIshO+4BvUqXkpyDCoWWYuEa7GpcnAkZwxWeZr sVHo2GECTpZlOk/paHeyCnRKN8ceiXM7nnC3FMDSS2WDdH1ozJkOc6j8tDIM6k0F3y39BzxrFL9 h5fh5YToxAmzKQ7FNTOEngSoZCtJQmdnuiLGBNjq+DfJ1zDY34q8dvg9EnYJC9EM0itQzlT5zLJ YOBGW8ddhl+Bx553ifbOcvZf747ZpCyo6kfOypJfhDOtSZq1EBM177zpLZP4A3J3QCbEddQBWQq OiCN7BYNFD4sqa23+WOj9OMCFeERV0kFHVeL+OK8cUTyMzd1Bnhl/TtBPeMsYwM8UR34C9Ps/uA Ox3lsBRhdqxh4vdmlFw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7791.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7791.c b/drivers/iio/adc/ad7791.c index ab1ab0d88492..bcdc19e799aa 100644 --- a/drivers/iio/adc/ad7791.c +++ b/drivers/iio/adc/ad7791.c @@ -413,10 +413,8 @@ static int ad7791_probe(struct spi_device *spi) struct ad7791_state *st; int ret; =20 - if (!spi->irq) { - dev_err(&spi->dev, "Missing IRQ.\n"); - return -ENXIO; - } + if (!spi->irq) + return dev_err_probe(dev, -ENXIO, "Missing IRQ.\n"); =20 indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A4B33C73EB; Mon, 30 Mar 2026 11:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869670; cv=none; b=NNDseYFT0k1qvPB6jKTry5N0JTExmw8COkoLnp+6no5hQdWUu9+yHpnxkfc3VaE2nNqQkH2lpGjvW61tnLK/AMIFZslfkPbH1T+EoKvmf56l7KCI0vzLMQCQvhrtBmqOKIBH8evgfivp7z3mZDdrC3FVySOTKAkB1QCuswIxQuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869670; c=relaxed/simple; bh=YZC0eX1SqbFCTqmeOk9BBQDEQzwN4Cc4mRJR3EvyZUg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lyA8mWN2/ggywO+SH4j0EgdBi4xvjb6+ET5vdyzUiifRJ1tqNc28ZzmYfGnqSIq6871nOYQnYHrCqEXzkSGHWWHg7aqj0Q9mHfTjnVJK4qu7vHYF0f/QWt3e6Fg4Ts2taEiF3vf+dYZqTsR4GtOVOguIoIAe3+Zz4pUdm3E2Nxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=iodw06I0; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="iodw06I0" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAw7ss3973001; Mon, 30 Mar 2026 07:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Uky+e 9OUvov0uCNS5cPahC4abIctml7hqiJBQF/inQw=; b=iodw06I0+wwWNyEI/YznC 45LDmvVJodNg+yTwegk8wQPMP8CCzgcUqnr73qy8i41dF0I4VsbpkHRRnRiouvik 9DPus+USLZPlw8tPGqrl4cU1MWJQTTwxJO1stJjzVoper3R3Bd9v7PJ8IdmA5OMY HnOwTjEsVPgTvDWF8gDUIPW8jJYnABHs87Y4709dTS5ngfYrZX1Y2mOYsmFWCBax XUMX7Lpzk82XbDctvtGgZb4LT7eXwwqWapsBG0WesG+zWOlRcAk8VV7ka1J+7uCA pcN6HTIinLEgdQYTXm2gYSYCvOpUXLAl+5lREfRTYcM/3f84noEbj/0t746rAJLR g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d7gkv9kf5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:47 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKkXx026939 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:46 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:46 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:46 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgd014225; Mon, 30 Mar 2026 07:20:38 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 10/13] iio: adc: ad7280a: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:53 +0300 Message-ID: <20260330111856.121589-11-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: V0IQtERppzcSGg1LQtPIpASN78TMxqjM X-Proofpoint-ORIG-GUID: V0IQtERppzcSGg1LQtPIpASN78TMxqjM X-Authority-Analysis: v=2.4 cv=TeqbdBQh c=1 sm=1 tr=0 ts=69ca5c8f cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=OmVn7CZJonkx5R5zMQLL:22 a=gAnH3GRIAAAA:8 a=JdEU7mAuevLnVqv-DSYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX7l+Upj8ZOIJf zl1M9kUjP20Dg2cqZbQYPe3ZdoIKdTk3sF00eXO7AOpujLlWjQyaPldz2wrOQWS8wWvx1lyru0s 57pOPSBWBMMXMFWzFR4EI6KBwhlV1mGvOCj9gigPMQL/KE+sKZJwgtkfHkBohKn+akpsl2nIOdV yFPFuOT0v7uFZJG1irZtcJj95aYceGguv1fNzXT/ER6UzE2s1GiNRsg0Jc9xmakT4Flv7EF/9gI RCfww7ySaCISfl4QhYwK67vNS/sZ/vwjm6IgJoMtSK0iJrwXaOF6i7hJecr0hA2DhQtU+Yf+19K vrU+hK+aMkbGuMZJVofCm7IfO7k5vcmuMC7d+BxYlPK6FeINXK62SuL9MjeKY411xbr6QafU7rn CzCnubQZyyjkZyrDr/f8QOQr2GbC6yCRO4Qr6jWMH8VozdHPy/GjBDaPYJbOlpNrEGJ8OGQo8rZ XCHP9VuK1pXhgeTlqVw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7280a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c index ba12a3796e2b..f50e2b3121bf 100644 --- a/drivers/iio/adc/ad7280a.c +++ b/drivers/iio/adc/ad7280a.c @@ -990,8 +990,8 @@ static int ad7280_probe(struct spi_device *spi) st->acquisition_time =3D AD7280A_CTRL_LB_ACQ_TIME_1600ns; break; default: - dev_err(dev, "Firmware provided acquisition time is invalid\n"); - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "Firmware provided acquisition time is invalid\n"); } } else { st->acquisition_time =3D AD7280A_CTRL_LB_ACQ_TIME_400ns; --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 195FB3C5557; Mon, 30 Mar 2026 11:21:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869670; cv=none; b=hL9CtJTJ55Td1Ineov3wQxZ1itk7bn7omiceRiLfys67FqSPINlstLfzrChVZhL0zChhP1sEDQfsN9RDMct+UEGjukvvcAIMP3iwK5KFjIfZSktL/qysIJjqbNYbdMKx7yn1m+Dy2QLNgEWWRTKr4DtFNb0DiWlzbDqep9gTeFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869670; c=relaxed/simple; bh=Uf5kWA2KDEBBnhlix15FvE6L23GO/1i3M/PG/Z92bLM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rLmurmWoKdNa7NWZ4wqcf4uvB7q/fHLH8LJGEBQWlIfe3d3lVKKPxWccWy+Fi/4TIOEFeNq5qPyNV9njsmh1pDhiAzl4k/KkdLI3tdbtg0frAAMYTTURW3DJ7LiQ0jrvt+titRnf0VRECVRzLZ7O+RpyiG6w4P4JZIf8Z/fPcOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=A2tM844V; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="A2tM844V" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UB0SQs1037161; Mon, 30 Mar 2026 07:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=pH8fp X3BfcM0L5HVudJ3oyr10hr252AnnPiixxzf1Ic=; b=A2tM844VirzmrESdZcDv8 Rh9QQ3cKicQ4iLNWNrtGvbZshfVVVUApyxYh/HNwCfxBB//L0tKWc4F84+7Ii7n2 Qd7hLTmTOD0bHH+ABhwj+A4sf3YxbU2Hpeu6RMVpiEDda3d9HR7Mi2K3A2ezcEqH WBp804CGL8I3v68qk9qVYZAi9mw4D16WX5B0X/IfiwPAOqE2i+06MB8XQWnG70Ap mY39T2kagvzoq/nMvz6aIvgi5P8F7nlDaNY0BUDwkEN0UMVH9Zej7hIdR7uER+sF 1RmJbS7Vj443NiNGRHIc7J25c5DuyKwQF2lxpShB50uLzsmUvYEJ3MqvkGrLkXrH g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d740ybbtw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:47 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKkdX026942 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:46 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:46 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:46 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDge014225; Mon, 30 Mar 2026 07:20:39 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 11/13] iio: adc: ad7768-1: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:54 +0300 Message-ID: <20260330111856.121589-12-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=ANnNY0ku c=1 sm=1 tr=0 ts=69ca5c8f cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=uXIjobp8t2wMuQ0fPvqm:22 a=gAnH3GRIAAAA:8 a=3ypIGDK6mX7mcVr3tMcA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX+qxY8ZefYh4v WjxwXmpI8BwMhQbhnRl9r6rEahYIY8SGhEyn+lIEuASRPJqFV+4n4i7uyyDz3MEBF3JLd3tinco 6ui5lZt5KFyiUq/xueVZ2ilp5BRX/og3YHILK6lUZ4D2hprxW0JQYHKUetA9ojEAOBfU5aI0qMI q2AKMDb/xQNicvaepdZJRlDGwm77ja53VNFx+rQt4gqwl4M4l168KdJByZhFDeiC68gQXtI8bwr x2WByeMqOLp6a7XzTEs+CeuIV94ulK5LCB7fhc15g2MRXfYOZOy3HnQY2NJVcOgv3zMf+aQvdbr JyAbVWhGvTQoR5g1LG/eQB00irToRsPi+qY4uGaTuYN6sqNGRUI8TUw1zVvJPEXLKOTpX+SWcYM PQCTaODbJ90MdPt52WFeP4HxBYR2bOgn0DApegHi041H65s2xhOUTwlnnLkdwCYDiZa/rfLxtCw V6sN6VESYVryi634HYQ== X-Proofpoint-ORIG-GUID: XIHhYyDefvuFt-yXn86xsb3J7tGFxRZu X-Proofpoint-GUID: XIHhYyDefvuFt-yXn86xsb3J7tGFxRZu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad7768-1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index 73fb734d06b2..598936e47fd2 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -1871,10 +1871,8 @@ static int ad7768_probe(struct spi_device *spi) return ret; =20 ret =3D ad7768_setup(indio_dev); - if (ret < 0) { - dev_err(&spi->dev, "AD7768 setup failed\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "AD7768 setup failed\n"); =20 init_completion(&st->completion); ret =3D devm_mutex_init(&spi->dev, &st->pga_lock); --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB393C872B; Mon, 30 Mar 2026 11:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869672; cv=none; b=abXOW+WzLPz9j+e0uDCK4YDoUUXSshLa9wU0qFLTdgf/Pzo+9zhmIHl1mLqJpdygusQdtzYu2FnEDPEWJre4kAeo4/gPYoBNTvl/uVc4LKcQjwXg6fxByQEYEGX0fojOBAgtzWUiFHnrH+YPnZ+UVRMBYbi4oeK5ZlA900W6kaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869672; c=relaxed/simple; bh=nxCDkOxjPenGRRkIYldU4/VGgS9GlgaITD5iYtxqy+8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rIYc0C20lXvfJEckwejlJkAtG3ZJqE6fvmkTFslK4a/Z1ucY6PB1RW2LWKNcZ/xvU270CwGbZRWpwfv0KpWjE+2R92Y/b0lOIYtre8blCscb70HS4W8BrOYnH7+RNwTUuMfPKGZZLGs+iEqXaWZ4ax2trCuSRMxduT300+EghSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=JjU20Y0b; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="JjU20Y0b" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAxEr42846686; Mon, 30 Mar 2026 07:20:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=sGUlD nO4SQy7Y1+0XtpjYg6RgHnhyUMJvGwb/1VZrNY=; b=JjU20Y0bN7UmDqZ2ME/6A ibQ489JHAonHZ7UylLScHrqNB9z2UVuWqtqO3n4tOF9ENTaXIDqbA28Gi8JcrpKs hqUPIKWyXp3qQAC0GC9m9FAIjFYZe1yrBKmZhnxw8E35N0m3CTLlI9dS0LI326xN wVH6wDoX18QAzXgZrN+HK/FhWq2TpX0BNpopdtOaJcWwHL2BJYuFLXJu0gfYh4sd E5hOpBjGDKcc20xg46/VPSpCkmJSCCmA3zhqB8eG6YnwdQJl4YWlvcaJI3AbC1At B/uL25+gQvntCABnnh28wjUW4lSrBgyaO27MajuVZ3fxSd2/fyRQ93D3MRqpTqrA w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4d6bw0xs1v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:49 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKm5j026951 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:48 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:48 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:48 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgf014225; Mon, 30 Mar 2026 07:20:41 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 12/13] iio: adc: ad9467: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:55 +0300 Message-ID: <20260330111856.121589-13-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: 6sfala40uqlH9pfkRt2RSzXNpH16aHcH X-Authority-Analysis: v=2.4 cv=BqyQAIX5 c=1 sm=1 tr=0 ts=69ca5c91 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=Z0pTeXoby7EwIRygza74:22 a=gAnH3GRIAAAA:8 a=noCrUjetKPCLGXENsFEA:9 X-Proofpoint-ORIG-GUID: 6sfala40uqlH9pfkRt2RSzXNpH16aHcH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfX8JehyhGes7EJ mAAyiUGkz44wUiewmw59MQoAQRalLadiXNawkl78MuxQSuFqbhjxdIHPW1A9sRZkW3Kuk+julib 9IWurAwPlyR2pyfaIk2mX+e5ys8mK6NOwDSmBUAKZj6Srz7tWBiWYMBr3+3VigizxP0MHspxR4J gRSnv2v5+1ztOjuRpW9kuIwe4P1afbyFhFLJgeq/Ca3sQU/x4DzfI/GgmQ/lS3ZWrvs6m9Da0o2 LlgWUESMxFDVvx43Hc13+/++d8S8wsQgBexuU1jfJLqdeYSNjg0xTxxhpM8CW4VUflHCyjdnATx 5p6Kct1RjHiZBqR00EFgxSJSEMcRJwLswTK1v6gXoeaBUGeYQwr6Sdq7YuYUnQatmiTa02q+yD6 ylhCNTb7ZURr17UTFM8v1a5+dUr5JEwCrUjYu4PV4rOleLgZS0Y64rvJrhKRtlOTgT7xH43ZoEU foL1YXeUOhVvBOZeMLw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus Reviewed-by: Tomas Melin --- drivers/iio/adc/ad9467.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c index 0bf67437508f..0c377f9a7f25 100644 --- a/drivers/iio/adc/ad9467.c +++ b/drivers/iio/adc/ad9467.c @@ -1349,11 +1349,10 @@ static int ad9467_probe(struct spi_device *spi) return ret; =20 id =3D ad9467_spi_read(st, AN877_ADC_REG_CHIP_ID); - if (id !=3D st->info->id) { - dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", - id, st->info->id); - return -ENODEV; - } + if (id !=3D st->info->id) + return dev_err_probe(dev, -ENODEV, + "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", + id, st->info->id); =20 if (st->info->num_scales > 1) indio_dev->info =3D &ad9467_info; --=20 2.43.0 From nobody Mon Apr 6 09:20:00 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 569873C9EFD; Mon, 30 Mar 2026 11:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869675; cv=none; b=RMMwP5q3xhJZE/98PpnlM+potaxDVo5/9s39/Xi7vP3234ID+YFK9L6o7j/VRp+ilHmgZCD9v3FfsGV+UbRiAr8YiSDQbTv9djZNFyLv+XLYhcAXpYwMpwS9O3Be3TPfa5BAn5ITi62IIEVRecQfoj4GQFF92AdQK1y2nQ3EPWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774869675; c=relaxed/simple; bh=yEm2kQ1Bm9gHwaiHulG0ZYvvXxm+s1dwkuBK2lU9eTw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oSTEGt68pho/csG3eym0kSn8I4HlDTE1p8RVohFqMneFpUkSWpYs+tzwE4O5V0gv3bGDgrqAfJCt8VpU+rooQ4dC9dH+44uUC9bt7AJuRpSV6vWB8AvQhQKVAhniSCyhZgfm8TC+TPCuPXxaJ2k32r9sekBBbZz4FkVmUdqgNs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=SCRFUWve; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="SCRFUWve" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UAwCJL217176; Mon, 30 Mar 2026 07:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=zDZaA W93oGLSeJ7siRA7oSWtnbC4931eEMdEp8pbWvo=; b=SCRFUWveCECadkCjd+rfu OftixpqTFhxUcseOJsJ2JKNlv8c6cU7SXSKaqVik292IrRyGnWFbJczdUH++mQfX 7yn6u/j+D2k98E4uYyy1JAvu3Oy1VC5Ck/Ubmj5tkADOq0or2z9rOdv1kPTdkd7Q gGYw36CaBGJm76HmZ6H+mm80oFofChzvVGMe1Q7tOU7WehZHz63SJbAMpP+lTUPt YnF4RwQeI4lY5/CGn7okusRmJxw7MkyUZbG6Lq1yi2lx+ghSiIDGssp4fCeW0X00 J+FvDXunOxRU7c1mf1OwLibYydNimlC23bs6f5zWECEBTGo+Q9tWhQ2nmaD7ARWG A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4d6wab478n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Mar 2026 07:20:53 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 62UBKq5n026962 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 30 Mar 2026 07:20:52 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:51 -0400 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Mon, 30 Mar 2026 07:20:51 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Mon, 30 Mar 2026 07:20:51 -0400 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.204]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 62UBKDgg014225; Mon, 30 Mar 2026 07:20:43 -0400 From: Antoniu Miclaus To: Jorge Marques , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Marcelo Schmitt , Renato Lui Geh , , CC: Antoniu Miclaus Subject: [PATCH 13/13] iio: adc: ad4062: use dev_err_probe Date: Mon, 30 Mar 2026 14:18:56 +0300 Message-ID: <20260330111856.121589-14-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260330111856.121589-1-antoniu.miclaus@analog.com> References: <20260330111856.121589-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: 7Bgqrcvcms6W1iBk_GMsKIVigR3WORYb X-Authority-Analysis: v=2.4 cv=YJmSCBGx c=1 sm=1 tr=0 ts=69ca5c95 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=0sLvza09kfJOxVLZPwjg:22 a=N--XFCr6TIEc_64PeIT2:22 a=gAnH3GRIAAAA:8 a=wKzcWFdhvmuAoNSPTJgA:9 X-Proofpoint-GUID: 7Bgqrcvcms6W1iBk_GMsKIVigR3WORYb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA4OSBTYWx0ZWRfXw6+rYu/WDhvp m5ozaE5VB2eqSYT2cQP/EW0EcRFpavOlVB48PqsSBlDl98TbqXcjfQgqyupIc5INVLfyaaWGXei GvA/aXEP+7Jbl4gcoLCULbxj5Fd0706W8B6AZN7IETmPdwknj8uQHA7tn2Y/1Z6gxIKkzw3T/jt P+V0RNa9EOUHOJR2sRHN5Cicax8KPO1wlWoMP/K5ReVnc+TqGA+qhvQEmQNh/2ohHwxxjaBKzmO IDnPVu/PO6ytGan8bzAsoDmSpmV9g98WE29wB0hvwvchG9tXvK7Ha30CPlpRKu6Iy1XXiOhTfWL PgTWK6Xmy3GrhFNXETVaOSN2Q9+OhK7eTGfpoHYGeAJEXDEi3li8OXdtb5cK2+oJkhM2cKtrgNP cNitE7dhnSB/M9W6WarK+PgrtRp6G0kPQVlafwkitzY8KancYHXGKUkRFW9ksmylf3PYPrLSdee M4qxSGhMVqBHN0egx7A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300089 Content-Type: text/plain; charset="utf-8" Use dev_err_probe() instead of dev_err() in the probe path to ensure proper handling of deferred probing and to simplify error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ad4062.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ad4062.c b/drivers/iio/adc/ad4062.c index c864de3b46ba..8942c79e8d83 100644 --- a/drivers/iio/adc/ad4062.c +++ b/drivers/iio/adc/ad4062.c @@ -436,10 +436,9 @@ static int ad4062_check_ids(struct ad4062_state *st) return ret; =20 val =3D be16_to_cpu(st->buf.be16); - if (val !=3D AD4062_I3C_VENDOR) { - dev_err(dev, "Vendor ID x%x does not match expected value\n", val); - return -ENODEV; - } + if (val !=3D AD4062_I3C_VENDOR) + return dev_err_probe(dev, -ENODEV, + "Vendor ID x%x does not match expected value\n", val); =20 return 0; } --=20 2.43.0