From nobody Thu Apr 2 05:48:27 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D785381AF7 for ; Mon, 30 Mar 2026 09:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862367; cv=none; b=OIXIBp3uqGPRiSNXYb057SCbh58I+54HBP3hUzecYcGsYhcGyQeiif43W6d3xYUb1Y6WLtlbmXhEQfSLP3iwVjAFKf/ZUjjAcgVaJPaQOZm4cbRA3mjWhmwYClymbSSe/CQU2RxbermbxBWn7EiKic5Yp6ZGklq22mad3D9hMLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862367; c=relaxed/simple; bh=v2wJm5OxMhFirUpbsSseKePV0XDwNFTZ0HeYn749ALw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Q4ySDVqr23NJx9cgJTqoNRCf/y040Lfr4x4HOIBq7kMX3Fgv32Kpyd7fBTSjvHo4yx49Vcv2szrmIS7HO6eLn+5J4g8Ajn6Xof6Ql+f4z2kXELi/0h15uR2FOK+mM0M45YgzRmgccd8QX7BexryoTO/zQZDuz3QRdSyWGc0CKF0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dSbHaYzF; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dSbHaYzF" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4853a5ffc05so9157495e9.0 for ; Mon, 30 Mar 2026 02:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774862364; x=1775467164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5jy4tutbo6n4MCIxyRYqtKSRHX+kUl57MnIxgCmBAFA=; b=dSbHaYzF+LR3DQUxQV7NjAh+UO7BEBjxiNKYgum10Q06KjKvnBebNap1yVBTWbGCq5 c1CGp/6sGmVmtJgP3FiQlmGp1CtBGzaNUMq/a2fJn8ZeA3TDkbejeZJTQDc1TBpVe+3o zLFZ6t4XvHKfJF+63Pb+dyZu7xtM9NGHVsNEg2Al9gVWQvUXhSC9Eo5+AiqEbKTsRJgN dgKoGXyLD2qIk8X7d8hKUbTpn1fSXI5MWjmuFWwmxJpKc6XT8/Dvi2cf9KWvnowbVOfI QRe02ix2rQD6iWn7J/QSCYhdpvhN1bxNz0eV1a5Pdkh/dIYigeKDaz1S/Z7xhXYfaNDd VmOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774862364; x=1775467164; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5jy4tutbo6n4MCIxyRYqtKSRHX+kUl57MnIxgCmBAFA=; b=aFDDDTRbZUcVMkARy1i1ocD0cX9DRPGNdNiYVe0em5nZXoYYmLYTtLl3e+RIRaE5aI 4WOHVL5BE5OFuY//876iZQjC7rtF4839YuB5vFKTtr6U2eoxU540uzW6UyPpx6WxRw1V /BCYOV83mWvTBSlPnDCJB+7Qy3STnpgLi5n7vozHaBeipjlXOkVelSZcusCDOyPZmim4 G5RJ6tnfmpoF9qRPOnsv59EZU9bjPV/Puy4zVqSKBw/K8fPNpenDdkRmWOwhpXs0P6j2 VZdMb5qzUPUsAuPL2uujHlOIm+/coQwOSNQtT4nd+fIzO1HEF8VYflyNt/VpDiFd+IrG c9qw== X-Forwarded-Encrypted: i=1; AJvYcCVJ6ALxXPp85egu7PuK7g9z0SuGLJE2i/Qi4t6CTgB2DC0jwWtoGEm1dTNZuzHXn545oIOmpg0HFxESTZQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy51qpStj4DuNyQZ93ELy+70xaA1ctO5i6T3tWzM8HUBncoplwN 81rBrQ+osAlwXrYPlIYOyknELNu/5TqV9oBPAtW9cbdNMYe2c8SIlYGx X-Gm-Gg: ATEYQzzefatLeOSfV/EtT6CxQOR86ToxvSxy47gDl1IC1PPa4zBLcW7fWXSffUfFbBs Pj5v4IowEiwNKMbjl8kyULYxLEcluLwEcbhBR7LdSZj5pEco6CL6LXdEak1OsG5x+tRs7hC+wDH rPPi4WTvjvLu/C03iPFRMPbTleif7OKv4qHOgHGk1pTsF5tUToVxtcRaY4AMO5UQh+e2WOhiZLi Upa4ZLL9/ZsQdrDtQvmwAlV4r0U9n167Ghcy3frxE4ZvPjDzBXkk8bcLNHT8UJaCnw3ovM/JiSU Iwi/yO/Owk4+tHHXhqOvVj8Az65Y96RsmIWnJF4uJHnwcEE4y8PN9v14Jp6CJdCoDOERkGy5R08 H/JmYj7uVmYw/2S3+e0/zV08qsLorzGzzWOxPUEFX8+EbhVvXpJKAtXQ2RPnUPKnnw+8M0QG3GO Y7zUIubsSUAKmboaeSCBk8ZV216rt3ITOqyHFykEMOKZkSZu5R+ictrHFoK/PANdBfTnq3O1TWh phTiUg6VZzX3esn9EuR X-Received: by 2002:a05:600c:5249:b0:485:f1d6:2b1d with SMTP id 5b1f17b1804b1-48727c8680fmr118714665e9.0.1774862363788; Mon, 30 Mar 2026 02:19:23 -0700 (PDT) Received: from thomas-precision3591.paris.inria.fr (wifi-pro-82-131.paris.inria.fr. [128.93.82.131]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-487270af027sm123355925e9.3.2026.03.30.02.19.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 02:19:23 -0700 (PDT) From: Thomas Fourier To: Cc: Thomas Fourier , stable@vger.kernel.org, Christian Marangi , Antoine Tenart , Herbert Xu , "David S. Miller" , Richard van Schagen , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: eip93 - Fix dma_unmap_single() direction in eip93_hash_handle_result() Date: Mon, 30 Mar 2026 11:18:14 +0200 Message-ID: <20260330091817.25797-2-fourier.thomas@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The buffer rctx->sa_record_base was mapped in eip93_hash_update(); rctx->sa_state_ctr_base and rctx->sa_state_base in eip93_send_req() with direction DMA_TO_DEVICE but unmap with DMA_FROM_DEVICE in eip93_hash_handle_result() and eip93_handle_result(). Change the unmap to match the mapping. Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 cry= pto engine support") Cc: Signed-off-by: Thomas Fourier --- drivers/crypto/inside-secure/eip93/eip93-common.c | 4 ++-- drivers/crypto/inside-secure/eip93/eip93-hash.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/inside-secure/eip93/eip93-common.c b/drivers/cr= ypto/inside-secure/eip93/eip93-common.c index f4ad6beff15e..75659a45ea5a 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-common.c +++ b/drivers/crypto/inside-secure/eip93/eip93-common.c @@ -687,12 +687,12 @@ void eip93_handle_result(struct eip93_device *eip93, = struct eip93_cipher_reqctx if (rctx->sa_state_ctr) dma_unmap_single(eip93->dev, rctx->sa_state_ctr_base, sizeof(*rctx->sa_state_ctr), - DMA_FROM_DEVICE); + DMA_TO_DEVICE); =20 if (rctx->sa_state) dma_unmap_single(eip93->dev, rctx->sa_state_base, sizeof(*rctx->sa_state), - DMA_FROM_DEVICE); + DMA_TO_DEVICE); =20 if (!IS_ECB(rctx->flags)) memcpy(reqiv, rctx->sa_state->state_iv, rctx->ivsize); diff --git a/drivers/crypto/inside-secure/eip93/eip93-hash.c b/drivers/cryp= to/inside-secure/eip93/eip93-hash.c index 2705855475b2..19a41a0db667 100644 --- a/drivers/crypto/inside-secure/eip93/eip93-hash.c +++ b/drivers/crypto/inside-secure/eip93/eip93-hash.c @@ -67,7 +67,7 @@ void eip93_hash_handle_result(struct crypto_async_request= *async, int err) int i; =20 dma_unmap_single(eip93->dev, rctx->sa_state_base, - sizeof(*sa_state), DMA_FROM_DEVICE); + sizeof(*sa_state), DMA_TO_DEVICE); =20 /* * With partial_hash assume SHA256_DIGEST_SIZE buffer is passed. --=20 2.43.0