From nobody Thu Apr 2 01:35:48 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A820B3AD531 for ; Mon, 30 Mar 2026 08:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774858907; cv=none; b=oFaRorcf7D+Eq2ARz5yEzQyAmtCgzznAMDMRt0LPwKHF4yD9LbO5qtEqCZ9TMtW3kB8TrU+Kr/oZow/AxxQJQq/+PqKXLivZ17zKroFDcNIDiaqxMRImTbfr5a+IedsDYny7ul8UbHLwQN/+1L/jT9VNhDEAdfh3PLmtcDRf6Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774858907; c=relaxed/simple; bh=Nn5W6j2KgfG3MXrQpHQ1hcxXhxv/yUbhKAiv5Knj23A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rmYG1b6g8ZL+emuxlgxfY4UNKyYd1EBuA1LxK61fdZz4w0MSJh+hioPTUulxSQM779fnGIpp/+h/RTk+76waZSV4fVEQQmyfVZerZCxX/1WDv68vyDLWRv53iXqLNAdVesi3y/AWA6OdxZuYKx8JVvtNH0lT+4/y1liVD6/t+Ro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ODVRXoP5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TLhORz3T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ODVRXoP5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TLhORz3T" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U7FRoA1931791 for ; Mon, 30 Mar 2026 08:21:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=it+OAEpYU8v 0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=ODVRXoP5DPzAOpeIcW0XRex9b9l CrEkwyNYBrFqKot1f6vuXl18YEpNr9OsG3mGouk+4ukkEjxlGVP0R6WSZLR5NSiT X2Q4yVm1Ewgj++zto+b0rLONXRoud0rVDYMwJ/65t+IHZ6XJzZrL2Cot8+Jt4W/8 iriy+Qp52rESuU1nxHZ/PiAcuOq4gMARmx4AqX74edlPxp9EmEEZwJtvHZTeCa4g FYRgAOmqgSaiWhhvZPBWE+8lQLHQ7V/0U5GHATajY+uzBTIX2MqGA9pzsYMfIjGp nKn2mUFy1IbGxOIGL0PBrAM7wWqVi4wmW5qRgWuhyZT0qa3txTrSk96AUpQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d65xqnb53-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 08:21:42 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b3544bc7bso57241861cf.2 for ; Mon, 30 Mar 2026 01:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774858902; x=1775463702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=TLhORz3Te5ybLPk6+CW3DHK5CPoJZyeARZpyGTgeP+2hcStx0t/1QSZ+7qHMnZadaq PkRkL/2tfqIbCULRcvdjZfDlKay8AT7VTgnews4BWJjPw1XDCoWYCJaP7yt6XIfhCGuP i8Qa9guY0VlEASaIJUDXjnnopmdrq+YC7ZTMZFi4R0uZNiZ3EdAKdd/xq2tcJfr6uQxQ EhpWuE8uAH2bqnqwKAz/VUpNDvJq1cFPb6EAMmi1dZih2qvKBfayi3AMfaRkIpDKQu7S wtr6/9HwlitQAV5IPi7PKi+R3oTGT6AMduPu2i7VTxME1LEnjN+nF54Pj1kNW0BM4KQi 3BiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774858902; x=1775463702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=PzXbGyE9z1i+RiwQZcqskcwb2Nu5ECxq6uD/q4UO2yZrms4hFkJMVQwqYQSiY0KSkY hX0ss8J3557QrG+3riw+UrfXLi4OQH1nVpwJTYUFLXDB1XZlArdx2J9bq2XymsY7oq2T 6v9UiMgR/pkkF403GB9fa1HDsYfhyYwwvgD3mSgSpaJPNsMDDYP+0VQ9Bt84EgYCRLoK jb/7n4gnzksN3FaVudjOva0ZhD5h+k1OnBJkOcIw0djfufURH7S1VDH2akjwJTZrPrSq 4xgKtbfhKMdEKaLizaHh+vX6uhxKixBdOjC9a1SxNr8ei/Ko28HM6NmKV5cilWZkfMS1 DEhw== X-Forwarded-Encrypted: i=1; AJvYcCVJmv0Ws6GIyPDRF2FMU2NkuLaUBM0Q1qaI5uK3KwyKJ/PXzkWhPrcZ0WyDuFcNQqO7dGOShV5WrpY6Ki4=@vger.kernel.org X-Gm-Message-State: AOJu0YwUiNlH7QJYApcCyEoh+l1KFnSTSJDYTdofnA0pQKdOBc6XLcKV 9eves4r+QEt9fV/H/PA4uDyiDdEUHxnmzgOwlN+WYCpdZ7GRSZpc1altRRuwSiQWe4a4ifuclja xAChWyftxMgKTb659V4uI8IhKn6tCJk3ljOEJ6cep0TUWVsZrE+V2A06D+0lIeUSGnZ/J7Oz/kb M= X-Gm-Gg: ATEYQzxQVPjbqGkJ5xVjfFzmIvooiSMIpDtvIJV32TX6H3o7ashMdABoEoAWvELMzY6 iWpeU5r0YR/gHUuw7Zk3UoqdGL18PE3ITwW38w9ZFVOCS0+7UxpoVXrRW8pVwZ9MZ2HoLlqI5sa g7t/uFVK1zub31WZQIsmH89dlDru4yI7d5xljB1B1sLD0HK5xUVANbrH0Zw2CjXK2i0pkH5LMoF hQ6OqzHuPvPmcSHid6f9ydCBD8u54AOQenNtwz4FyACQWuxXg3XYqf1aCeDb6eK/KUW5r1XQPB4 ekXhby6BvH3aKZsQWVarelYRrMI0nG+c0UZS7kBxtPlO+Nhc3l6SN3jxbMpXn6qdUHdpLuIJnWr earDK5kcAIcpnVekE7CArT585ES7e6GawbL7pe6E99jMiYhc32ldh+/A= X-Received: by 2002:a05:622a:5a87:b0:50b:40a6:29b5 with SMTP id d75a77b69052e-50ba39186acmr156494531cf.42.1774858901764; Mon, 30 Mar 2026 01:21:41 -0700 (PDT) X-Received: by 2002:a05:622a:5a87:b0:50b:40a6:29b5 with SMTP id d75a77b69052e-50ba39186acmr156494201cf.42.1774858901294; Mon, 30 Mar 2026 01:21:41 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf1db08e6sm26244773f8f.0.2026.03.30.01.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 01:21:40 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v8 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Date: Mon, 30 Mar 2026 08:20:56 +0000 Message-ID: <20260330082105.278055-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330082105.278055-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260330082105.278055-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: GTkX3j2D_4aiLJJFbBhnT0Mx-Rwdy1EM X-Proofpoint-GUID: GTkX3j2D_4aiLJJFbBhnT0Mx-Rwdy1EM X-Authority-Analysis: v=2.4 cv=evLSD4pX c=1 sm=1 tr=0 ts=69ca3297 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M_mAHeyD2EURj3i0m2kA:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA2NSBTYWx0ZWRfX53cUqKlsEHk+ Q9XAEKK1lWIiDyS5M3KyZ1zTnM0ZSRkFXpXycMPucD7X4kIuWWtZJ60akKu+SRufHyIlikXOhwt Hd25K22YsDDILcyP0PWb28MmdKOZ9TS+wVF2bm111dtYbdXEPeVqv3nYEnQBEDV/fN2F1chFsHG 3TsRpvlg/a1mH+ljjCdpVQPJFzTAeQxubEr4G2Ayz6gt0UpiVod+EVRFIa4fJa9kWh7c04Og/Dd TKrKVDdkNcQg5bJDD+WZBYaQUkq4LJ1yXOti2LBMHrHZXVtsLbf7ktHqZNY3SzErsxos2TdaAf5 mXkCQmLqYQy5P45pwhUhZlxhs7mox4ODeNeeEDVNgTGnW/lKI29w7/SPjO09zw+exXWV87fk3Vh 241Lcgz3tv/gMCbauXVZGozTJWToRfY5pc/yWSJjsPy/0cp3VRCCZI0ooh9VHqyrHNiVZHd4tge iBFE5ktmONwQgvEhEAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300065 Content-Type: text/plain; charset="utf-8" As prepare can be called mulitple times, this can result in multiple graph opens for playback path. This will result in a memory leaks, fix this by adding a check before opening. Fixes: be1fae62cf25 ("ASoC: q6apm-lpass-dai: close graph on prepare errors") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6= /q6apm-lpass-dais.c index 5be37eeea329..ba64117b8cfe 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -181,7 +181,7 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_subst= ream *substream, struct s * It is recommend to load DSP with source graph first and then sink * graph, so sequence for playback and capture will be different */ - if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { + if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph= [dai->id] =3D=3D NULL) { graph =3D q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); if (IS_ERR(graph)) { dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id); --=20 2.47.3