From nobody Thu Apr 2 09:13:07 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 977F423183B for ; Mon, 30 Mar 2026 07:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856960; cv=none; b=ZJz7o0A7+/7NBNr8nw6LgybB4Ky/fR/UVf7TF7k8UOOYm9ykMGQ91BNIpGk+2TNtz298rbVYV94yPdtY3A2ctD3MRVRt/TkJ1RgVNwodbaBp8m4R0FPG8MfP4vtQ1j08yS1rJMWNghgvJALA8N2CiYWeM5Mxz+etnnXsgljmcpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856960; c=relaxed/simple; bh=PgD3o0jwMp6kDXwgJ79jkjmidrEPYUAbk5Dd5GJ6mE8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ibo5T+jSSTD3KEhfpnCxgsqZQUuf+7fWlp67EqbYSaDgg8O/UVIxPkh37ktYe+5rj7knWfSxVZxPG3LsrWPZJUC4r1WPoHPqDEKAGUUB4nYBCz69x0ItodesUTL5SLRjo5AiQDlTgvYrgqx9sg9FLQbS9CYexctfgKbbPRLItyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZtscpV1n; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VDJxOLAU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZtscpV1n"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VDJxOLAU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774856957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=JVY6xwa07Prh7BoAXHjyZRtVv7vEWGmZ2sCIyoIQnwc=; b=ZtscpV1nTMNtvG/BBLiyCDkNNfDVLZW9IO7BGqSmbmI28Lf3rImwio0FBVYpM0UOdAifAZ g7pq1jWYe8141WiYsZmAaILj2H4WhPPqr61gYwZWE2S8wM4DY4hp4GEXvqVy6R1oApOv0x +xnbAginK7wk1QmJV08e76L6zNpymRw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-VslkYISYMUqixJ6jmaCJYw-1; Mon, 30 Mar 2026 03:49:16 -0400 X-MC-Unique: VslkYISYMUqixJ6jmaCJYw-1 X-Mimecast-MFC-AGG-ID: VslkYISYMUqixJ6jmaCJYw_1774856955 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d03ae4f2aso161515f8f.1 for ; Mon, 30 Mar 2026 00:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774856954; x=1775461754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JVY6xwa07Prh7BoAXHjyZRtVv7vEWGmZ2sCIyoIQnwc=; b=VDJxOLAUdFVmZFfJcUrJWCELk0XJmPkp8bKsuKEbcJyvNu8t7Owda2G6dnY1N53giN BSQpEdKK+o5ytG7//vGF3mM5yMYkJcF5gOuTeqTRtRNYCRee003LooiocV5xhN0/lYep 7lPT2P1i2Wavzaa2q/Bu3z5lyOpXznOWb2XHRC5A7mP5L/yp0jlpcROkfR/TpFOlku9X Pgm/oL2/0jn8C4yl+3EfXmrCF1X8q0f7vU74XstaMkYWdFqFDMl3+URj5cugwGAUnAUD eoOJPYBoP+CCASHBvcILSRVWyUkVxknFJvi7BBhAfK0KRkho+tPn3PtiZRd0JZVWs37s iZrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774856954; x=1775461754; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JVY6xwa07Prh7BoAXHjyZRtVv7vEWGmZ2sCIyoIQnwc=; b=E9CMKgho6XfNZxVOsx5lzHO6wCAFtekWXwDb/2GIkM8xdMqg4Y+3lT0JkyWU0Sc6mW mhaBVtRIipF/H4Dw7xnLXI+UdzK3CRwHcQqjoemNuj4ToQ7q7dWU/MD0Cz5QphXM8qtn 1VMWlfTGRxsHBBGotTZvfdXv5NSMlo/fAiXGQlN3TXpyJ5j8dfNf1lKjmmBPQVOnKxGi 32264H3LsJP+1U/G5OccYIvoZBb4SEO/rNIoevmrq/T+mKVp27YxoKtAA70M2huD7xK1 efvqXcEhX3LLF62mMAbdiuqxRBK2pCv2RRtparWoveDhRy4VAMIzWdhT2tZqE85iHGzu zAeQ== X-Gm-Message-State: AOJu0YzBZGP9IbHA25pW042sHcBl0jhBeQ+YklL9YEbC2htVfatLxNy2 I0upCRmmwNgo660xGAeXieB8txEkxI4gyITJBSADpb0Hzblt7eniQuwt0FxSQcf47Kxquf4+Jsq pwYcbMxK1ksr/Jj8AxjHY5eUMJx4/2uPFxLYQ1so7PHXCvqnHvstwN6J+P7mbPl3KPKXBYOnN85 D5I0q8Y5lIXT7kaq5gMnii/apPcNO9PjNX6q++JMI0HtxTqz2/CA== X-Gm-Gg: ATEYQzwk4Sg0bIEWTD9i3JVYwfCwhFqm5l2v+hGazw7Hu2PQaaFwnH4ojef3oHWddde znqdUvkqGqIhZbUJg1k6Y6iXfZdFnzhltQFTeHf+fideHE1ByM5Asr5r763MYO2oG5UKEJoPuwO 2PqixV2z8JSz/TMJRvcn5P45FaoTJftDijCpu0EhHhBxkD478oqeyUZkKMO3Mu75PNlznY/bIhC 5QfmdtuLozlof0kmwIheFWwC5oDRfgKuJBzwaRTOBqjCac7TlNWvEJSw9TRE47QP3VUrCmUHLGK DAjB9+aIDWFlgnoE9WxbP216K6Nt2SFj4NYuaFCyEeoAFHR0TaDeE2KF23Wvquf1ORbdM6reLmB qqpxSfJ0JVLoGyxNynn/KJtTBv4S4BmpgM+CHy8/GZWm2twXpIQJ9YvQKNdsdD+ifmivkEFINr4 BJXyYcFTSiNfgcXoc6njhu+tEo X-Received: by 2002:a05:600c:c493:b0:487:575:5e1 with SMTP id 5b1f17b1804b1-48727ef5571mr181061435e9.24.1774856954353; Mon, 30 Mar 2026 00:49:14 -0700 (PDT) X-Received: by 2002:a05:600c:c493:b0:487:575:5e1 with SMTP id 5b1f17b1804b1-48727ef5571mr181061045e9.24.1774856953875; Mon, 30 Mar 2026 00:49:13 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722d23679sm489316315e9.9.2026.03.30.00.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 00:49:13 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Alexander Bulekov , Fred Griffoul , stable@vger.kernel.org Subject: [PATCH for-6.18] KVM: x86/mmu: Only WARN in direct MMUs when overwriting shadow-present SPTE Date: Mon, 30 Mar 2026 09:49:09 +0200 Message-ID: <20260330074909.140480-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sean Christopherson commit df83746075778958954aa0460cca55f4b3fc9c02 upstream. Adjust KVM's sanity check against overwriting a shadow-present SPTE with a another SPTE with a different target PFN to only apply to direct MMUs, i.e. only to MMUs without shadowed gPTEs. While it's impossible for KVM to overwrite a shadow-present SPTE in response to a guest write, writes from outside the scope of KVM, e.g. from host userspace, aren't detected by KVM's write tracking and so can break KVM's shadow paging rules. ------------[ cut here ]------------ pfn !=3D spte_to_pfn(*sptep) WARNING: arch/x86/kvm/mmu/mmu.c:3069 at mmu_set_spte+0x1e4/0x440 [kvm], C= PU#0: vmx_ept_stale_r/872 Modules linked in: kvm_intel kvm irqbypass CPU: 0 UID: 1000 PID: 872 Comm: vmx_ept_stale_r Not tainted 7.0.0-rc2-eaf= ebd2d2ab0-sink-vm #319 PREEMPT Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 RIP: 0010:mmu_set_spte+0x1e4/0x440 [kvm] Call Trace: ept_page_fault+0x535/0x7f0 [kvm] kvm_mmu_do_page_fault+0xee/0x1f0 [kvm] kvm_mmu_page_fault+0x8d/0x620 [kvm] vmx_handle_exit+0x18c/0x5a0 [kvm_intel] kvm_arch_vcpu_ioctl_run+0xc55/0x1c20 [kvm] kvm_vcpu_ioctl+0x2d5/0x980 [kvm] __x64_sys_ioctl+0x8a/0xd0 do_syscall_64+0xb5/0x730 entry_SYSCALL_64_after_hwframe+0x4b/0x53 ---[ end trace 0000000000000000 ]--- Fixes: 11d45175111d ("KVM: x86/mmu: Warn if PFN changes on shadow-present S= PTE in shadow MMU") Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu/mmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index a8fe777ba274..dad7abb1112b 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -3060,7 +3060,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct= kvm_memory_slot *slot, child =3D spte_to_child_sp(pte); drop_parent_pte(vcpu->kvm, child, sptep); flush =3D true; - } else if (WARN_ON_ONCE(pfn !=3D spte_to_pfn(*sptep))) { + } else if (pfn !=3D spte_to_pfn(*sptep)) { + WARN_ON_ONCE(vcpu->arch.mmu->root_role.direct); drop_spte(vcpu->kvm, sptep); flush =3D true; } else --=20 2.53.0