From nobody Mon Apr 6 10:42:14 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247C739F181 for ; Mon, 30 Mar 2026 07:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856883; cv=none; b=q/wi9vM5KEGjTpeY6tsvgPQfi6elwtQEzCuCmekMJOws+tlTTomLibAEUSOdYLKd9g+2b5c7hhXZFaj6OcCX7Gb+GuvzDb9rnaD85M4bXdLvBV8wiFPv+BdinXmRhWyaKU3aJWgIN8gU3cGVwzwhvA3hq9geZkZl/38TqjqPOws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774856883; c=relaxed/simple; bh=7GMzw0oRiafV0eMb7x9aC5ZHTmc/GWR5ESfda8BEsAc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZAZ6x+kCTUMwm/JU3F2v/arPHqgnf+S7UznZJEYqhlZX2QOAHcz7Sq0OIxbjq/+GknF+fjyY1nyTij6rA00d3Ty7ZOFRmgX8e3NrGsyRG2N8nQvFY3N8ywAKQl1pouYANuiKVh1XrfcTiUbBkHFsWGzEh9Z3NFzZimBt61QtAqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O/R9MFF0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lWhdLLEt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O/R9MFF0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lWhdLLEt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774856881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qg0u0qRIxbfnVPhgM3unvPlEH448ub4jA5OeQ5LRf0k=; b=O/R9MFF0E4l1BsrMUc78/4PoShDEnTMg8JZMPJW6PLlQsQSlyqPr+fwDLdFWurwizE2GlX yyXd6SUQta/X9Kqw0cAM4i0cY6dVpcPojy8jjmaVwh73NO2v4T7lPVodaWkbd4mX2g8ybD fjT91pRbaIotfArJAxXU6sh6YiRdUSU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-Av20L_qJOtyZjhzdRQGQYQ-1; Mon, 30 Mar 2026 03:47:59 -0400 X-MC-Unique: Av20L_qJOtyZjhzdRQGQYQ-1 X-Mimecast-MFC-AGG-ID: Av20L_qJOtyZjhzdRQGQYQ_1774856878 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-487219e0800so29358745e9.2 for ; Mon, 30 Mar 2026 00:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774856877; x=1775461677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qg0u0qRIxbfnVPhgM3unvPlEH448ub4jA5OeQ5LRf0k=; b=lWhdLLEtOc51DcthOQqW66KiGMwCfPEnh1otj1+EBE9XAtdKPF4dc8XOZGbNhtLALR rmgCBjfKc1OL50Mo2yKnVAg7wQ136pV86wABGpbquiimWM5jxlEJZcVJXoIAKby+w4Xm bJFD3gipgVMYNPBqzT2IaQ8G8NIFxnfr8t3R3npNU8MiG+fX33mIpyMTxtjQWPZhnpln n7uW2+Uk/4oxo7cOE96t0IhiAdpWFlbPuthpjC0TzpCPtuQ+DRHJYbhc5tHao0OyPWuP Ia7bruZOQKeh9KrK84OjnD0gj8ZN29jG8OG8RxZEKsW/UM6n1bbBUyq/bnZEj1Tbfdu4 dtlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774856877; x=1775461677; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qg0u0qRIxbfnVPhgM3unvPlEH448ub4jA5OeQ5LRf0k=; b=B0pqKD5TVCYrF+dPQ1M3d6FETxwkbw7P+EpQc5ObgZOAL/YIb+TFZU4s56mzjLCaR+ 6WtmzP/vP43OxKoWukGqbQz5NqV61rNGVk92FE45cbYGYCfp62VcXYrIebS1bFRCRE3Z hq5gW7SL4nt+FNJJbKdnL0oxEvqrXO/dHuX5b2nxx9jPEkAHZ+k+5tlgfJY9IWhVp+N+ y3BgdGMxoh5SuIOb6uA2yUOvTdBs8ROx/+3Upv3FEkL29nPRPzXvOXpEmsnm0ZoMbkuR 3coc6bX3jOHPBtUUoYgdZ+1lBfTq3mRAF/rNKN6/D7O2gd3TaiybukIOhdY7f0jqnzmx nQCQ== X-Gm-Message-State: AOJu0Yx8CT/WXn79AUFy9GjPowbvgNI7SHomISMl+leGD60e7HTP7eao 5L9CgC8OqhXsSPfs49c9yWTRxgDVVrc+L7US3nnCMxJGfHcFTsBOGtzhO85AfRfpVUPyluY7RWB xz9SjrrlZkdEkSgxIsf/Z8tuR1/nWboKbcPujBXX/5xPs39yGSDsiIG9iSm1gE0dlOfIbq1Jc8M z8eHv0JYCcOZFBYUulcolsN2F/63WVxYCezQBnh8IPz47sshTb/g== X-Gm-Gg: ATEYQzxW2v8gAAKDucx2YQgKJbbDzn1+ujBclhae8aXLwnuqVN+2t+tLndqGT8Ek1FY xCH/n0md0r5AQdnXQxosNf2Y/23yzr4us8CPgfE0C6hClp9PL4R8Kc1G8JHpY5DOyKFRosJjujF irl/m5wzFDMwARDGHmyNcMynXZgRxCBqX9NidZFwRTXVStWDPP1beCuGGvptUHTPZOIc6FtX5l9 dfM29r/lPa/7a4w4E46cNxwuM8EfqgvVfIg7/eQTr+Ml7FdAGZ+h0pibe1B8eNnKYp2X93MN1jP 4YAt66DnOXhLwIhYtGfqySP/I80oSTF311KSJQWegJAt9PSdCQuEsTxfrfzHNncmrwEmQjQ1Z+B CcFUJXpgX99MalTZTH5Sw69atogKGQCBZFAzGxbZoZ5Fxa0HA8G5ZpKxULyywkYenhzx3tbWpoE CRS0xlxX0u4BPNRAv5XRRGRTC+ X-Received: by 2002:a05:600c:4f53:b0:486:de04:5906 with SMTP id 5b1f17b1804b1-48727eda749mr187072395e9.19.1774856877213; Mon, 30 Mar 2026 00:47:57 -0700 (PDT) X-Received: by 2002:a05:600c:4f53:b0:486:de04:5906 with SMTP id 5b1f17b1804b1-48727eda749mr187071945e9.19.1774856876706; Mon, 30 Mar 2026 00:47:56 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c9506dsm251858425e9.7.2026.03.30.00.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 00:47:55 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Alexander Bulekov , Fred Griffoul , stable@vger.kernel.org Subject: [PATCH for-6.19] KVM: x86/mmu: Only WARN in direct MMUs when overwriting shadow-present SPTE Date: Mon, 30 Mar 2026 09:47:52 +0200 Message-ID: <20260330074752.136232-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sean Christopherson commit df83746075778958954aa0460cca55f4b3fc9c02 upstream. Adjust KVM's sanity check against overwriting a shadow-present SPTE with a another SPTE with a different target PFN to only apply to direct MMUs, i.e. only to MMUs without shadowed gPTEs. While it's impossible for KVM to overwrite a shadow-present SPTE in response to a guest write, writes from outside the scope of KVM, e.g. from host userspace, aren't detected by KVM's write tracking and so can break KVM's shadow paging rules. ------------[ cut here ]------------ pfn !=3D spte_to_pfn(*sptep) WARNING: arch/x86/kvm/mmu/mmu.c:3069 at mmu_set_spte+0x1e4/0x440 [kvm], C= PU#0: vmx_ept_stale_r/872 Modules linked in: kvm_intel kvm irqbypass CPU: 0 UID: 1000 PID: 872 Comm: vmx_ept_stale_r Not tainted 7.0.0-rc2-eaf= ebd2d2ab0-sink-vm #319 PREEMPT Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 RIP: 0010:mmu_set_spte+0x1e4/0x440 [kvm] Call Trace: ept_page_fault+0x535/0x7f0 [kvm] kvm_mmu_do_page_fault+0xee/0x1f0 [kvm] kvm_mmu_page_fault+0x8d/0x620 [kvm] vmx_handle_exit+0x18c/0x5a0 [kvm_intel] kvm_arch_vcpu_ioctl_run+0xc55/0x1c20 [kvm] kvm_vcpu_ioctl+0x2d5/0x980 [kvm] __x64_sys_ioctl+0x8a/0xd0 do_syscall_64+0xb5/0x730 entry_SYSCALL_64_after_hwframe+0x4b/0x53 ---[ end trace 0000000000000000 ]--- Fixes: 11d45175111d ("KVM: x86/mmu: Warn if PFN changes on shadow-present S= PTE in shadow MMU") Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu/mmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 01e159941434..440e3d9fc689 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -3060,7 +3060,8 @@ static int mmu_set_spte(struct kvm_vcpu *vcpu, struct= kvm_memory_slot *slot, child =3D spte_to_child_sp(pte); drop_parent_pte(vcpu->kvm, child, sptep); flush =3D true; - } else if (WARN_ON_ONCE(pfn !=3D spte_to_pfn(*sptep))) { + } else if (pfn !=3D spte_to_pfn(*sptep)) { + WARN_ON_ONCE(vcpu->arch.mmu->root_role.direct); drop_spte(vcpu->kvm, sptep); flush =3D true; } else --=20 2.53.0