From nobody Thu Apr 2 07:43:45 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA1C339A807 for ; Mon, 30 Mar 2026 06:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774853638; cv=none; b=CwPEFcioNVCQTtHlm/bWsI7xlnaQSC1bB5dluaM8DzpAKS+Ph68iEIZ1nyB2wNx2raVEUn/kplb+ZtuH96tml0L7gUYAcyEex8pWCLNId8onXq43dspwpNm7V+j9q/ljoK1yVOQG8sbJTphc9Dyocp7NGtzSx3OEvlZa7oXqBmQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774853638; c=relaxed/simple; bh=1ZMQRFTsE9RGEd8MISqxE82qOuGiFFOcLA43cHDuWsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TzcalZCu1mdBZaIoXGmAp2TMhZiTS70JdtcayL/LA0/+YmoKoRH47S3nXN1d+fLGqIGStVq0HamCX9ExDwQDaNPKKSwGYesS7Smz2FlkRDa4neZ5ABZ7R5RlDkGnpobJyccw2aS+ccGfXDntaeyk2Fr/jtsLoBSbl8HMaOmmx8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TLGBj4te; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TLGBj4te" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8299f1ca894so1966959b3a.2 for ; Sun, 29 Mar 2026 23:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774853636; x=1775458436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N3Sfp0Ek0ayKazM5uQym569fBFMivhcwWZXFfdYQ8Y8=; b=TLGBj4teOMRDIwTEWJ8OAm94rPixaY0l6q332vqr9JcKxF/M0kgTFD8x4gYm7FHK85 hLEF9sYUD84Et9LScnn/WciRvZJYfvW0SdseIUC+NFxzYsCZzwotrV6Xjx6TgEwfA7Dt zE0Uuwg8JbBHXbpRdy+0Igb9HAlVQ7Z+ngWru+5AeD9fEt+RUW/0z9xftENH2Y/L0HXf UEr0yWxci+D3XEjYGRvtZlGcJgSz0N3Vm78Ak8xZgNQixQxhjm9arWKWdB5RQJ2BIzW2 UqcbHFYBK4H0Kk9kzLvBFhmdolch1KWKRDO9UYwCeyDzF+k+ZUtebI9BzPkXs4tOUgaj ArDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774853636; x=1775458436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N3Sfp0Ek0ayKazM5uQym569fBFMivhcwWZXFfdYQ8Y8=; b=Ipx0Klvk/f4BtW0uUQHoU0iFKoAz6JPYWLqBkWSYFz/oEolGWLahg5z6c2RrG/m6/o 7+KpYM/HzXIH0SMReKM6FZAjE3wyYbdSnd3tNE4PBmoMa4Ray8Mn9WId+3w+K/vLSNTQ ejUmvCklDgNXYDnv/GB2N2E3WECijScvOb7DBNMYoCaYNLr7unsquOPXHndR2Rp1gfjD AQ6Vcx5Bw1/F1AKUebjH49lqt3AYhZz0QDMhuCdDDrXEGs4/BTimyNumZvZMK48ZiY9d Fdezw6obHTWdF24njMaBaeG7mTcDrMyWEEw5I6xbeWm5yv06Kk3rIgpRxE0iXUO9lyoC l1xA== X-Forwarded-Encrypted: i=1; AJvYcCXFubt5sq6e36E9DtdGV9DmOzwh3wEaflxwxvFkIma1RilCuAE+jV/Rbj+corRRUmU1EsZqqlQ1tK45PJc=@vger.kernel.org X-Gm-Message-State: AOJu0YzdiN4mZVHqmTiRhh0NAnEnIufAlFtfg4FXiyku6TdyuPUakGbH 4vUnU/C2oqc4glj3sB8aDzS5XmGTNqDxfQ8tTWZzTVd7DPIl0aewqbo0 X-Gm-Gg: ATEYQzwrMr4vOO0QYR3qqwW6Qr8Eb/33fLKaa0vSJ9ZTWkHssYSn1lSt3tOa0JdSHzU nA3ctLLbJroO9LWWF5tGPqrnq4S4o2WDRaSkPUE7Lll6IR+ymkKX4Zsi5pi3qNrkocB8IpLRkQP UvUqdbvXn5GKVeoAzfU3T4ja/r6HQzUO6tcmI2OieLtgxFYF98eHqGW2TQaA2+VU/9LVfTcR8Mc LwI0dfxvQDCT0L2uC6vMtn2uEBcuAe6W52Hxahk9rUNPEfGFAYoXQfPFudSzkxqZ7XUw6DzqP8m xf0s5Coer1YAuJh2HDU4Rp9Rw1aFXRK2a9oFcgyxhZtgBaCnTGxV74NNQAh/QkHOZzbog7Wk59k Wm3gvHwXlmJZFHZHzq57K/MElalINFTZ0Iy4xy+b93P1w1xlGljiBj9JLRYDfYBDgBLaihkAaK2 uQk+ewHjmNGG7jx8XLIg4cBQrq5Fbh X-Received: by 2002:a05:6a00:4511:b0:82a:110b:e212 with SMTP id d2e1a72fcca58-82c95706cc7mr10873894b3a.0.1774853636040; Sun, 29 Mar 2026 23:53:56 -0700 (PDT) Received: from kfuzz ([202.120.234.33]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm6287090b3a.20.2026.03.29.23.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 23:53:55 -0700 (PDT) From: Kangzheng Gu To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kees@kernel.org, thorsten.blum@linux.dev, arnd@arndb.de, sjur.brandeland@stericsson.com, xiaoguai0992@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v4] net: caif: fix stack out-of-bounds write in cfctrl_link_setup() Date: Mon, 30 Mar 2026 06:53:42 +0000 Message-ID: <20260330065342.145549-1-xiaoguai0992@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260329190350.19065-1-xiaoguai0992@gmail.com> References: <20260329190350.19065-1-xiaoguai0992@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cfctrl_link_setup() copies the RFM volume name from a received control packet into linkparam.u.rfm.volume until a '\0' is found. A malformed packet can omit the terminator and make the copy run past the 20-byte stack buffer. Stop copying once the buffer is full and mark the frame as failed by setting CFCTRL_ERR_BIT so the link setup is rejected. Fixes: b482cd2053e3 ("net-caif: add CAIF core protocol stack") Cc: stable@vger.kernel.org Signed-off-by: Kangzheng Gu --- v4: - remove the Reported-by. - print a warn message and reject link setup by setting CFCTRL_ERR_BIT. - using %zu to adapt the compilation of 32-bit kernel. net/caif/cfctrl.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c index c6cc2bfed65d..373ab1dc67a7 100644 --- a/net/caif/cfctrl.c +++ b/net/caif/cfctrl.c @@ -416,8 +416,16 @@ static int cfctrl_link_setup(struct cfctrl *cfctrl, st= ruct cfpkt *pkt, u8 cmdrsp cp =3D (u8 *) linkparam.u.rfm.volume; for (tmp =3D cfpkt_extr_head_u8(pkt); cfpkt_more(pkt) && tmp !=3D '\0'; - tmp =3D cfpkt_extr_head_u8(pkt)) + tmp =3D cfpkt_extr_head_u8(pkt)) { + if (cp >=3D (u8 *)linkparam.u.rfm.volume + + sizeof(linkparam.u.rfm.volume) - 1) { + pr_warn("Request reject, volume name length exceeds %zu\n", + sizeof(linkparam.u.rfm.volume)); + cmdrsp |=3D CFCTRL_ERR_BIT; + break; + } *cp++ =3D tmp; + } *cp =3D '\0'; =20 if (CFCTRL_ERR_BIT & cmdrsp) --=20 2.50.1