From nobody Mon Apr 6 10:43:33 2026 Received: from canpmsgout02.his.huawei.com (canpmsgout02.his.huawei.com [113.46.200.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09093939C2; Mon, 30 Mar 2026 06:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.217 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851940; cv=none; b=b1P5q3fjrsL8Es2OD2bihOdbhNaxjV9a/LkwLzHwJDGi8iWRip/0AdnHRpCeAuDFGztgpiSpzmVWZFY6+RU7RWChTFyuj2jSQLSi45ee6MTh0194oqIXXQzgnzXTolrRpAfKSin5JNN/jK/vrnfmpkDqbNNz6snoQ9nk6puFoXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851940; c=relaxed/simple; bh=V2iM7WWAPZkuHcB840wa/HGvAJM+pOuflSG+IT9cOMc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=U7/LBp+vUj8ZL9uBscS14wDMFyQVCJtputatrFMEoHygo7EHyK8EH9zEleX5oNMr9cqGVPZYAjZ/dcx8I/if766ZK/qNWeafDZXB6wDX0XOIGEw5d2/BIB3+rssaGrpz92PWm1gk/4q9iS8DDVOHEnCPoKWO0mWuGG4Q4T4BjqY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=MFdx9+jz; arc=none smtp.client-ip=113.46.200.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="MFdx9+jz" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=qIbWKuJDaAn0koYK5nyi+7ngsUGOIfzghBpw89mahkU=; b=MFdx9+jzFxpmVxc9UfAfQRnnnqNMWXhwhUPbdjOiOWtzzk+codqPtSSampGzP3sAv9pMvvDOl talsGLLbvbRq/Lu4nrv9dPpb1YsK4c+ycS7iPVjDuDdfwezqRNgbT1DI6Y0BotqkzDaxwgilOEE juaXtrT1eJnMG6nOkt/kgts= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout02.his.huawei.com (SkyGuard) with ESMTPS id 4fkh123xkQzcb59; Mon, 30 Mar 2026 14:19:34 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 49832203A0; Mon, 30 Mar 2026 14:25:35 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:33 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:32 +0800 From: Chenghai Huang To: , CC: , , , , , , Subject: [PATCH 1/5] crypto: hisilicon - fix the format string type error Date: Mon, 30 Mar 2026 14:25:27 +0800 Message-ID: <20260330062531.2976138-2-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com> References: <20260330062531.2976138-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" From: Zhushuai Yin 1. The return value val of sec_debugfs_atomic64_get is of the u64 type, but %lld instead of %llu is used in DEFINE_DEBUGFS_ATTRIBUTE. Fix it. 2. In debugfs.c, since the types of q_depth and xeq_depth are u16, the results of q_depth - 1 and xeq_depth - 1 are int rather than u16. Use %d for int. Signed-off-by: Zhushuai Yin Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/debugfs.c | 4 ++-- drivers/crypto/hisilicon/sec2/sec_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/= debugfs.c index 5d8b4112c543..e5878558dc64 100644 --- a/drivers/crypto/hisilicon/debugfs.c +++ b/drivers/crypto/hisilicon/debugfs.c @@ -305,7 +305,7 @@ static int q_dump_param_parse(struct hisi_qm *qm, char = *s, =20 ret =3D kstrtou32(presult, 0, e_id); if (ret || *e_id >=3D q_depth) { - dev_err(dev, "Please input sqe num (0-%u)", q_depth - 1); + dev_err(dev, "Please input sqe num (0-%d)", q_depth - 1); return -EINVAL; } =20 @@ -388,7 +388,7 @@ static int qm_eq_aeq_dump(struct hisi_qm *qm, char *s, = char *name) } =20 if (xeqe_id >=3D xeq_depth) { - dev_err(dev, "Please input eqe or aeqe num (0-%u)", xeq_depth - 1); + dev_err(dev, "Please input eqe or aeqe num (0-%d)", xeq_depth - 1); return -EINVAL; } =20 diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c b/drivers/crypto/hisi= licon/sec2/sec_main.c index 6647b7340827..056bd8f4da5a 100644 --- a/drivers/crypto/hisilicon/sec2/sec_main.c +++ b/drivers/crypto/hisilicon/sec2/sec_main.c @@ -909,7 +909,7 @@ static int sec_debugfs_atomic64_set(void *data, u64 val) } =20 DEFINE_DEBUGFS_ATTRIBUTE(sec_atomic64_ops, sec_debugfs_atomic64_get, - sec_debugfs_atomic64_set, "%lld\n"); + sec_debugfs_atomic64_set, "%llu\n"); =20 static int sec_regs_show(struct seq_file *s, void *unused) { --=20 2.33.0 From nobody Mon Apr 6 10:43:33 2026 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF25339478F; Mon, 30 Mar 2026 06:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851952; cv=none; b=TZGHBJMmL2bdrJMrsYFISbYGvQP4e0JJTKrIlHIPnC/+o4BAR99w84aczTkR/x4XbgV9xQFd8mZsMhyAeMB//wE5ljLJlg6PgspaXmzV+1EA5abpyJ7Jo0i3n+rUzOJGu7az/r6Rj2jKK4x7ibcMLJ/NT4n8TzMmPxzFHhAk5b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851952; c=relaxed/simple; bh=NVgqMp+ej9gXxrCJL59iSZwkkaMmXobCyidAXEEqekA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Tx3dncD7n3KgOaW3e+Sp2orX2KvCcz2LWVJQMdICSDyosvDzshtYzK2VDuL4MjTDyUmGgLdQtsnKnrhXPN9NOOnWF7l8A6bVN6DpK+ZdrJZIQI7dSNVLJgIYy0gGVYQ3EijXc4rOXMpse0kWYqyUq4Z+C4dONSHVaHfPFiqihBY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=UcQ0oYsR; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=UcQ0oYsR; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="UcQ0oYsR"; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="UcQ0oYsR" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=NtHldOAKLME86m23DlCEDtsS98a/InDXmypmupVIqpM=; b=UcQ0oYsRoInmeaO/LBx3bkZQ7dzUlhsU+iOXdj2cGOeMBrzaE/gRg+VTH4A7xTsHzyrbPyNP4 Gmj3Rnf+oxMrjFJjI5EFxZPD6q6/mVoq+m2o8X/nAA81t9fAKi7/qzWfRIP3VbJbHdTv5YdzpZT iO0fU8b7/tBIo/qAGfJwpBM= Received: from canpmsgout08.his.huawei.com (unknown [172.19.92.156]) by szxga01-in.huawei.com (SkyGuard) with ESMTPS id 4fkh7r2b0mz1BGDX; Mon, 30 Mar 2026 14:25:28 +0800 (CST) dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=NtHldOAKLME86m23DlCEDtsS98a/InDXmypmupVIqpM=; b=UcQ0oYsRoInmeaO/LBx3bkZQ7dzUlhsU+iOXdj2cGOeMBrzaE/gRg+VTH4A7xTsHzyrbPyNP4 Gmj3Rnf+oxMrjFJjI5EFxZPD6q6/mVoq+m2o8X/nAA81t9fAKi7/qzWfRIP3VbJbHdTv5YdzpZT iO0fU8b7/tBIo/qAGfJwpBM= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout08.his.huawei.com (SkyGuard) with ESMTPS id 4fkh0r1JBXzmVW3; Mon, 30 Mar 2026 14:19:24 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id 2B9C440562; Mon, 30 Mar 2026 14:25:34 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:33 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:33 +0800 From: Chenghai Huang To: , CC: , , , , , , Subject: [PATCH 2/5] crypto: hisilicon/qm - add const qualifier to info_name in struct qm_cmd_dump_item Date: Mon, 30 Mar 2026 14:25:28 +0800 Message-ID: <20260330062531.2976138-3-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com> References: <20260330062531.2976138-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" The "info_name" is never changed in struct qm_cmd_dump_item, make it const. Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/debugfs.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/= debugfs.c index e5878558dc64..3ee6de16e3f1 100644 --- a/drivers/crypto/hisilicon/debugfs.c +++ b/drivers/crypto/hisilicon/debugfs.c @@ -45,8 +45,8 @@ struct qm_dfx_item { =20 struct qm_cmd_dump_item { const char *cmd; - char *info_name; - int (*dump_fn)(struct hisi_qm *qm, char *cmd, char *info_name); + const char *info_name; + int (*dump_fn)(struct hisi_qm *qm, char *cmd, const char *info_name); }; =20 static struct qm_dfx_item qm_dfx_files[] =3D { @@ -151,7 +151,7 @@ static ssize_t qm_cmd_read(struct file *filp, char __us= er *buffer, } =20 static void dump_show(struct hisi_qm *qm, void *info, - unsigned int info_size, char *info_name) + unsigned int info_size, const char *info_name) { struct device *dev =3D &qm->pdev->dev; u8 *info_curr =3D info; @@ -165,7 +165,7 @@ static void dump_show(struct hisi_qm *qm, void *info, } } =20 -static int qm_sqc_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_sqc_dump(struct hisi_qm *qm, char *s, const char *name) { struct device *dev =3D &qm->pdev->dev; struct qm_sqc sqc; @@ -202,7 +202,7 @@ static int qm_sqc_dump(struct hisi_qm *qm, char *s, cha= r *name) return 0; } =20 -static int qm_cqc_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_cqc_dump(struct hisi_qm *qm, char *s, const char *name) { struct device *dev =3D &qm->pdev->dev; struct qm_cqc cqc; @@ -239,7 +239,7 @@ static int qm_cqc_dump(struct hisi_qm *qm, char *s, cha= r *name) return 0; } =20 -static int qm_eqc_aeqc_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_eqc_aeqc_dump(struct hisi_qm *qm, char *s, const char *name) { struct device *dev =3D &qm->pdev->dev; struct qm_aeqc aeqc; @@ -317,7 +317,7 @@ static int q_dump_param_parse(struct hisi_qm *qm, char = *s, return 0; } =20 -static int qm_sq_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_sq_dump(struct hisi_qm *qm, char *s, const char *name) { u16 sq_depth =3D qm->qp_array->sq_depth; struct hisi_qp *qp; @@ -345,7 +345,7 @@ static int qm_sq_dump(struct hisi_qm *qm, char *s, char= *name) return 0; } =20 -static int qm_cq_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_cq_dump(struct hisi_qm *qm, char *s, const char *name) { struct qm_cqe *cqe_curr; struct hisi_qp *qp; @@ -363,7 +363,7 @@ static int qm_cq_dump(struct hisi_qm *qm, char *s, char= *name) return 0; } =20 -static int qm_eq_aeq_dump(struct hisi_qm *qm, char *s, char *name) +static int qm_eq_aeq_dump(struct hisi_qm *qm, char *s, const char *name) { struct device *dev =3D &qm->pdev->dev; u16 xeq_depth; --=20 2.33.0 From nobody Mon Apr 6 10:43:33 2026 Received: from canpmsgout05.his.huawei.com (canpmsgout05.his.huawei.com [113.46.200.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC76394490; Mon, 30 Mar 2026 06:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.220 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851944; cv=none; b=s1tdVDGlgTzk78mS57cAmX61H+hbCg40XyfxA6a7QHikr+i86G3hANIQjhD85O6K8AwdxaELjT8pp7iHeDXc0lbA9r1aGuNYruZGMlVEQcu8Lgl6Hryaw+NRYBe2VxQKeAcFQuAumEnbpPouiSNUpc3QTYlbrOWQUz+RArkzKsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851944; c=relaxed/simple; bh=9L8e7750CQ7WYuG8PyeOjdLciNxQLopB/tvRvVheT38=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hGQXJyXkP+xOfXciz780MVPL7bgPmE0s+d4eGlXPdMfqQVNPPj4pGPER5fycGzL3LcvnhJstk9wUR+AQBf7XuqHseuEU+2Jk5Ah2/oK1Mon+Jwf9Ul3blWkKWjFgSJcRw9Qh+FlmTZbBkACdlxuJGtS/+bhat+MA1/YRqt4xFDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=eDk4zY1z; arc=none smtp.client-ip=113.46.200.220 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="eDk4zY1z" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=4Q4/hdG8r7RlOlRpzRWgODwIfL6Nka/KRUBqZxxKjAQ=; b=eDk4zY1z2e3jwol7kqwNAZ0iNYtrDfSbM9H6MtxNYXXX5mKVJgSRZrtCkuHoGAQI3qEYZcW60 WE9FmCiMi168tdVCSOGpQBJgIu4qkoNjKI818O4hK3ATxjApJ+UqFjVT5PDPi2eUelaCu5L2q0L 1841ywmhfbV6j3FKDjCbGoI= Received: from mail.maildlp.com (unknown [172.19.162.223]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4fkh1k1Hqyz12LDF; Mon, 30 Mar 2026 14:20:10 +0800 (CST) Received: from dggemv706-chm.china.huawei.com (unknown [10.3.19.33]) by mail.maildlp.com (Postfix) with ESMTPS id B558D40569; Mon, 30 Mar 2026 14:25:34 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv706-chm.china.huawei.com (10.3.19.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:34 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:33 +0800 From: Chenghai Huang To: , CC: , , , , , , Subject: [PATCH 3/5] crypto: hisilicon/qm - remove else after return Date: Mon, 30 Mar 2026 14:25:29 +0800 Message-ID: <20260330062531.2976138-4-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com> References: <20260330062531.2976138-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" Else condition is not needed after a return, remove it. Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index d1626685ed9f..0588355920dd 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -4278,8 +4278,8 @@ int hisi_qm_sriov_configure(struct pci_dev *pdev, int= num_vfs) { if (num_vfs =3D=3D 0) return hisi_qm_sriov_disable(pdev, false); - else - return hisi_qm_sriov_enable(pdev, num_vfs); + + return hisi_qm_sriov_enable(pdev, num_vfs); } EXPORT_SYMBOL_GPL(hisi_qm_sriov_configure); =20 --=20 2.33.0 From nobody Mon Apr 6 10:43:33 2026 Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F10394793; Mon, 30 Mar 2026 06:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.221 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851945; cv=none; b=E2MZ7ywmsp/tKDjloq9HKSdrz2H2Zx75+6aWpFsHEozqXQyjy2DRo+UqMhqzJXVCUdjIrpIV7oYEZKS5EEnZpkJnsdxttbxCfXTmMR6TW/V4C/fU4XZrxm/yogHF3LaixDMx1184KH42a2YK62n2B86aDznVPr4fzu5wUWjwg+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851945; c=relaxed/simple; bh=Sx0Fc6PZy+pvfWt6qAHAyn6JoAVr3/sQlRxZ2AlorIA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UIn1L2+h7XD72Ok7G7qQhSV5gNbqNHFa1hc7UCf6ihLTkH2WD1EuMgo2JNeaM5YN5F0zLCl3CBBsDrE4O6T/CnKfrbr4YGx3ENK+Zkz3qJb10/pLNgcoocJu8zfd6VmY1eQ9u+B+uahuwS3VQFMBbtZ9bpWoGCGGiYVfi1Bn3A8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=qa7gkjGG; arc=none smtp.client-ip=113.46.200.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="qa7gkjGG" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=O8KXfZ76HdUg1YpieV7WvZyfDkTw293oakpRQ4NFQzI=; b=qa7gkjGG/aGB0LJ8MJ+nUWO4ljp2qVVTZFXnWZZMz+hFWcjwwBcXvC4Im4c0QgjZK+otqWxtB HvfyqfEWVsHKQM+fi/4ypkFDshDWN78DEDBo9layq/rmf6xaUEps2YSkSE5k8iw7PDCzCWH0ikY 9FWHRTnh09BW6kyV/rk7FYg= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4fkh0t5YQGzRhR7; Mon, 30 Mar 2026 14:19:26 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 4F91A203A7; Mon, 30 Mar 2026 14:25:35 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:34 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:34 +0800 From: Chenghai Huang To: , CC: , , , , , , Subject: [PATCH 4/5] crypto: hisilicon/qm - drop redundant variable initialization Date: Mon, 30 Mar 2026 14:25:30 +0800 Message-ID: <20260330062531.2976138-5-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com> References: <20260330062531.2976138-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" Variables are assigned before used. Initialization is not required. Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 0588355920dd..2bb51d4d88a6 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -3381,7 +3381,7 @@ static int __hisi_qm_start(struct hisi_qm *qm) int hisi_qm_start(struct hisi_qm *qm) { struct device *dev =3D &qm->pdev->dev; - int ret =3D 0; + int ret; =20 down_write(&qm->qps_lock); =20 @@ -3917,8 +3917,8 @@ static int qm_func_shaper_enable(struct hisi_qm *qm, = u32 fun_index, u32 qos) =20 static u32 qm_get_shaper_vft_qos(struct hisi_qm *qm, u32 fun_index) { - u64 cir_u =3D 0, cir_b =3D 0, cir_s =3D 0; u64 shaper_vft, ir_calc, ir; + u64 cir_u, cir_b, cir_s; unsigned int val; u32 error_rate; int ret; --=20 2.33.0 From nobody Mon Apr 6 10:43:33 2026 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913C3382369; Mon, 30 Mar 2026 06:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851939; cv=none; b=PM0z8sxRmAvUvTKpaZxf3MChhNxsRpC5z8Zfh4Ck5NWM/BB7Yer44VyJZdLThgJRDgqO85T1CWAFi8cKAeWxR2ecpQq2a8zjqi7tcC6MCh8m2meGEL9JEWSrrgngbAn0r7sctJOnp2Fy7D2S/e3hh9dQpqqUPBl4qG0b8Y/UXp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851939; c=relaxed/simple; bh=jJKfanWZpYtgSyxZ50QVDqdpJVn+yU6BSW6raNgHQOY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H5VZ7AHaihHj81H2hhgyPX7AsYDOcyqBOmhnGCfAiBNnDXM3pjJRReHLMNSZyql9uu1m6qKUW5TntI1nzb7+scYZQZjlHu+/Fx/gLUOWNLzE8wdJUlUa8vvQHrtIBtiKYdjL/MGTNOdh5fcnmmJo6tuD1haeHr1hT65LlJ3UHlk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=cRpCqcww; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="cRpCqcww" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=1tK0WtC+91a0BZrfD200a8cx70L5JBMeduqK1gjqlPE=; b=cRpCqcwwNyYkr4618s4s1KClnwpQ+fIuaqbMQqRGTQxymscKIPOlunwjpMSBeuGQq+ELZ/0qg gEc2wihiOrRxO5qAOidzTpd44kNNT9Y57k9Ae+M4FgsakCLp3jKDPEZzaWs3cn9j5hElIXe3eCs 6yGsnoqkgLhg6p9kOcAfyLI= Received: from mail.maildlp.com (unknown [172.19.163.15]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fkh1k59bXznV4N; Mon, 30 Mar 2026 14:20:10 +0800 (CST) Received: from dggemv705-chm.china.huawei.com (unknown [10.3.19.32]) by mail.maildlp.com (Postfix) with ESMTPS id 94F0640539; Mon, 30 Mar 2026 14:25:35 +0800 (CST) Received: from kwepemq200001.china.huawei.com (7.202.195.16) by dggemv705-chm.china.huawei.com (10.3.19.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:35 +0800 Received: from localhost.huawei.com (10.90.31.46) by kwepemq200001.china.huawei.com (7.202.195.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 30 Mar 2026 14:25:34 +0800 From: Chenghai Huang To: , CC: , , , , , , Subject: [PATCH 5/5] crypto: hisilicon - remove unused and non-public APIs for qm and sec Date: Mon, 30 Mar 2026 14:25:31 +0800 Message-ID: <20260330062531.2976138-6-huangchenghai2@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260330062531.2976138-1-huangchenghai2@huawei.com> References: <20260330062531.2976138-1-huangchenghai2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems100002.china.huawei.com (7.221.188.206) To kwepemq200001.china.huawei.com (7.202.195.16) Content-Type: text/plain; charset="utf-8" - sec_register_to_crypto() and sec_unregister_from_crypto() have been removed, the function declarations have not been removed. Remove them. - hisi_qm_start_qp and hisi_qm_stop_qp are called internally by the QM. Therefore, the EXPORT_SYMBOL_GPL declaration of these non-public interfaces is deleted. Signed-off-by: Chenghai Huang --- drivers/crypto/hisilicon/qm.c | 8 ++++---- drivers/crypto/hisilicon/sec2/sec.h | 2 -- include/linux/hisi_acc_qm.h | 2 -- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 2bb51d4d88a6..3ca47e2a9719 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -472,6 +472,8 @@ static struct qm_typical_qos_table shaper_cbs_s[] =3D { =20 static void qm_irqs_unregister(struct hisi_qm *qm); static int qm_reset_device(struct hisi_qm *qm); +static void hisi_qm_stop_qp(struct hisi_qp *qp); + int hisi_qm_q_num_set(const char *val, const struct kernel_param *kp, unsigned int device) { @@ -2262,7 +2264,7 @@ static int qm_start_qp_nolock(struct hisi_qp *qp, uns= igned long arg) * After this function, qp can receive request from user. Return 0 if * successful, negative error code if failed. */ -int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg) +static int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg) { struct hisi_qm *qm =3D qp->qm; int ret; @@ -2273,7 +2275,6 @@ int hisi_qm_start_qp(struct hisi_qp *qp, unsigned lon= g arg) =20 return ret; } -EXPORT_SYMBOL_GPL(hisi_qm_start_qp); =20 /** * qp_stop_fail_cb() - call request cb. @@ -2418,13 +2419,12 @@ static void qm_stop_qp_nolock(struct hisi_qp *qp) * * This function is reverse of hisi_qm_start_qp. */ -void hisi_qm_stop_qp(struct hisi_qp *qp) +static void hisi_qm_stop_qp(struct hisi_qp *qp) { down_write(&qp->qm->qps_lock); qm_stop_qp_nolock(qp); up_write(&qp->qm->qps_lock); } -EXPORT_SYMBOL_GPL(hisi_qm_stop_qp); =20 /** * hisi_qp_send() - Queue up a task in the hardware queue. diff --git a/drivers/crypto/hisilicon/sec2/sec.h b/drivers/crypto/hisilicon= /sec2/sec.h index 0710977861f3..adf95795dffe 100644 --- a/drivers/crypto/hisilicon/sec2/sec.h +++ b/drivers/crypto/hisilicon/sec2/sec.h @@ -285,7 +285,5 @@ enum sec_cap_table_type { =20 void sec_destroy_qps(struct hisi_qp **qps, int qp_num); struct hisi_qp **sec_create_qps(void); -int sec_register_to_crypto(struct hisi_qm *qm); -void sec_unregister_from_crypto(struct hisi_qm *qm); u64 sec_get_alg_bitmap(struct hisi_qm *qm, u32 high, u32 low); #endif diff --git a/include/linux/hisi_acc_qm.h b/include/linux/hisi_acc_qm.h index 8a581b5bbbcd..a6268dc4f7cb 100644 --- a/include/linux/hisi_acc_qm.h +++ b/include/linux/hisi_acc_qm.h @@ -558,8 +558,6 @@ int hisi_qm_init(struct hisi_qm *qm); void hisi_qm_uninit(struct hisi_qm *qm); int hisi_qm_start(struct hisi_qm *qm); int hisi_qm_stop(struct hisi_qm *qm, enum qm_stop_reason r); -int hisi_qm_start_qp(struct hisi_qp *qp, unsigned long arg); -void hisi_qm_stop_qp(struct hisi_qp *qp); int hisi_qp_send(struct hisi_qp *qp, const void *msg); void hisi_qm_debug_init(struct hisi_qm *qm); void hisi_qm_debug_regs_clear(struct hisi_qm *qm); --=20 2.33.0