From nobody Thu Apr 2 09:14:00 2026 Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F218F30BF5C for ; Mon, 30 Mar 2026 06:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851013; cv=none; b=lXsyciUSSuPT4IR+Dw7qp4onx56lzz9ib3q8xZn3vx8/ELRTq1BB8iKfPQ2EjNvkk14ZS1PUfvBHCj+UwNZhPwMDPTHeP6Qmhoq5cCRVf6psrss2HU5HvrF2anOB55n2FqLesepy8EhX5um6htncmZP6u3H5CjZvJfZ4WBIEDFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774851013; c=relaxed/simple; bh=57DrXeQnUGc6iR/CXOWyyyVZBnQ5MkHIKUWHPpAsMcI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=DlmigKqIHa4wPSQpm5BB3Xb0DKNy04CEjOeTJJRg+9wYIJwAM9MbCmItrh2vEes1pji7W/WaDAaQJi6936IM0nRBLA2yZu2SiIIqsnZoMp3nHbqQuXSmgWQytZx6Q3GCoTCa81hyICfvZRReiitpdF6n3jIiCMounfw6hhzMIiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bs4qHoHG; arc=none smtp.client-ip=209.85.217.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bs4qHoHG" Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-60536adb815so120664137.1 for ; Sun, 29 Mar 2026 23:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774851011; x=1775455811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SVkfdJP2KulZKEM0URtofZekmehI6WAdAhgF+udGJlg=; b=bs4qHoHGkb7YdhSUMkLyR+fYZeSFTOyp4dW7olvEW9+8evk+HFAWsU6JLCVPjeHJoA Q5xxHR6Nz9RorRUQMREo0aDKfEZEShpTdNU6CUuoykOV1qfNAbVaJzhyNsMFJe+Dilb/ 1x9I4XwVTRhciWZtTCWv6ovp4wrwjlQYDyKOL8fXOAiC7rFjHI4Dj2+YP+Pq4QBFv+nl D8vYMgZX4imi+/6XhRZJXow5hBRVb4QQVn7anFYyRnGH2SeSdlIkleFONdXOGkHxkuw9 feA16jCUxVLnmhRC5bgWpjz0Jq1fnHjbqlhAUeRVrPjGJkVckorUgpxK7bkpB9jgimsU JVtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774851011; x=1775455811; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SVkfdJP2KulZKEM0URtofZekmehI6WAdAhgF+udGJlg=; b=MelVJHmgDBOVh6qTVu0FpLpbGV7K1+pukXxhNQrohv6JiRvvNlHbJPZzmx1ai7vYFp xcIzB2AGslWq045ujSBCNvWScmSFumviRvzjrnf2nWOSHpWsoQQXYGs5TnVB+iKMSVzD FDi53rakkKGhXyECfAqgsxa99ZhjGc8I0fX6L62LlRFKU9lHC5I8nAX9gzEP4zt7XawA 7UMvBZPU52XtjxFQmqMEC5O1ESHaRcV1A4gzXDq0JMDGv6dygWdz4ZDd80vr+KdTXxJO fD7N0N3x/UxFkmr5NxAw/9YJE/0iRzr6o95VajhGDSXCZp6tfiz/YmCcZ0ufyOnSPLvy IwXw== X-Forwarded-Encrypted: i=1; AJvYcCU2UBVrsT0iK5wqTIIXqBt1ElH22EVMJgTeDxR4DWTfcNZaa3zw243MKVPamIjP9fdPch432ko9AIJvxfM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw12VyGljQByVCE82cfoT+F7Tr/D2aw2Xg6RQxZMrcAxzZKxSny hxkYdzBs728XR1r3NfMrk4+X4eE0rxwEBqT5Hyb7v/CBnRiKGvT8JYb8 X-Gm-Gg: ATEYQzxvq2w8JQmCFTByE5o9imzqFM3c6347SHLGj9Re+QAJgjx6w+JhXbkCnELRmeA HHVKdqwk+akzag2jfYUxCNdnqK39SJCezvtxVATkENvsHRiNFAcN8bsCKNk/iFciaEwK9MxIvH0 2XlKm0JWau9pozk+aGdJu8vmOIyAqiM5DIopFJ1f3X9vOFcE2mh1WDiA67ola3jPPqFX1tqpKPI fDhY34hp+GxOHX7E0cFg9LoMAsN0FV7/F4ai+g7cHySceg0QWkqAvZ0Gw50gSp3JHzMjhWIfBcE gTG7HE8ZRppqZxYZa0/8/fmiXAG/BZHv6Q7aJble8v1PKd0fmGO9+qyGz8ml2S5VHtGU9hGN84e jvGFef0ClYPrvYE2pqduIo7xNm6sItEryTnuDte7obXYRRwtNKfJDtk6xfBO42VtS9GICOaUbVh opI2mG2nPpXu5KtB/+f/OBCZIq X-Received: by 2002:a05:6102:cd0:b0:603:2173:d75e with SMTP id ada2fe7eead31-604f8d8b751mr3805351137.0.1774851010812; Sun, 29 Mar 2026 23:10:10 -0700 (PDT) Received: from localhost.localdomain ([2a09:bac6:d6d9:aa::11:1d6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60512d3a037sm7133561137.9.2026.03.29.23.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 23:10:10 -0700 (PDT) From: Sebastian Josue Alba Vives To: gregkh@linuxfoundation.org Cc: marvin24@gmx.de, linux-staging@lists.linux.dev, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?UTF-8?q?Sebasti=C3=A1n=20Alba=20Vives?= Subject: [PATCH v2] staging: nvec: validate battery response length before memcpy Date: Mon, 30 Mar 2026 00:09:26 -0600 Message-ID: <20260330060926.751031-1-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Sebasti=C3=A1n Alba Vives In nvec_power_notifier(), the response length from the embedded controller is used directly as the size argument to memcpy() when copying battery manufacturer, model, and type strings. The destination buffers (bat_manu, bat_model, bat_type) are fixed at 30 bytes, but res->length is a u8 that can be up to 255, allowing a heap buffer overflow. Additionally, if res->length is less than 2, the subtraction res->length - 2 wraps around as an unsigned value, resulting in a large copy that corrupts kernel heap memory. Introduce NVEC_BAT_STRING_SIZE to replace the hardcoded buffer size, store res->length - 2 in a local copy_len variable for clarity, and add bounds checks before each memcpy to ensure the copy length does not exceed the destination buffer and that res->length is at least 2 to prevent unsigned integer underflow. Tested-by: Marc Dietrich Cc: stable@vger.kernel.org Signed-off-by: Sebasti=C3=A1n Alba Vives --- v2: - Introduce NVEC_BAT_STRING_SIZE constant to replace hardcoded buffer size (Marc Dietrich) - Store res->length - 2 in local copy_len variable for clarity (Marc Dietrich) - Use NVEC_BAT_STRING_SIZE in strncmp call for consistency drivers/staging/nvec/nvec_power.c | 41 +++++++++++++++++++++---------- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/staging/nvec/nvec_power.c b/drivers/staging/nvec/nvec_= power.c index 2faab9fde..7b7980127 100644 --- a/drivers/staging/nvec/nvec_power.c +++ b/drivers/staging/nvec/nvec_power.c @@ -19,6 +19,7 @@ #include "nvec.h" =20 #define GET_SYSTEM_STATUS 0x00 +#define NVEC_BAT_STRING_SIZE 30 =20 struct nvec_power { struct notifier_block notifier; @@ -38,9 +39,9 @@ struct nvec_power { int bat_temperature; int bat_cap; int bat_type_enum; - char bat_manu[30]; - char bat_model[30]; - char bat_type[30]; + char bat_manu[NVEC_BAT_STRING_SIZE]; + char bat_model[NVEC_BAT_STRING_SIZE]; + char bat_type[NVEC_BAT_STRING_SIZE]; }; =20 enum { @@ -192,22 +193,36 @@ static int nvec_power_bat_notifier(struct notifier_bl= ock *nb, case TEMPERATURE: power->bat_temperature =3D res->plu - 2732; break; - case MANUFACTURER: - memcpy(power->bat_manu, &res->plc, res->length - 2); - power->bat_manu[res->length - 2] =3D '\0'; + case MANUFACTURER: { + size_t copy_len =3D res->length - 2; + + if (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1) + break; + memcpy(power->bat_manu, &res->plc, copy_len); + power->bat_manu[copy_len] =3D '\0'; break; - case MODEL: - memcpy(power->bat_model, &res->plc, res->length - 2); - power->bat_model[res->length - 2] =3D '\0'; + } + case MODEL: { + size_t copy_len =3D res->length - 2; + + if (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1) + break; + memcpy(power->bat_model, &res->plc, copy_len); + power->bat_model[copy_len] =3D '\0'; break; - case TYPE: - memcpy(power->bat_type, &res->plc, res->length - 2); - power->bat_type[res->length - 2] =3D '\0'; + } + case TYPE: { + size_t copy_len =3D res->length - 2; + + if (res->length < 2 || copy_len > NVEC_BAT_STRING_SIZE - 1) + break; + memcpy(power->bat_type, &res->plc, copy_len); + power->bat_type[copy_len] =3D '\0'; /* * This differs a little from the spec fill in more if you find * some. */ - if (!strncmp(power->bat_type, "Li", 30)) + if (!strncmp(power->bat_type, "Li", NVEC_BAT_STRING_SIZE)) power->bat_type_enum =3D POWER_SUPPLY_TECHNOLOGY_LION; else power->bat_type_enum =3D POWER_SUPPLY_TECHNOLOGY_UNKNOWN; --=20 2.43.0