From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D44B73A783B; Mon, 30 Mar 2026 09:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; cv=none; b=Y1ldEwUBxTickOlaQvnMkKNgjclrNo/vftzmNBcd6X60xWcOPmbcwRLK3jJ0s1gYoMcDmhjAHrGuUfkx8Un4DE+PJB+EB9AlaU34Z+L3vsuirqDusXeiuJ4t4NzNek7+HlW8hr8Rmj5drCTbvUHxDdzFaYPV0SEAjTrRM0Eqq9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; c=relaxed/simple; bh=xn9R5Y4c2FVuxWGJ+XDVZ0hhgrzdWZnr3TAJrrkBg1E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=RsKZ4bAaY8L7srHA9Ksqt3f+jnLVk9Q0wKsnhVYR2TpiqDOxTMwFMY4osttKf/Q+9ChEBtzmUloDkzLm7sMMRHED+zW9/O79T3A3UCxn+6QU4olnn4M8g7KLsPfw7DLTZPVjkUhkL3LOT2DkrN7OMtARaqt+hhJbgmHNfNsEpVY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=SFLHwWLi; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="SFLHwWLi" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78ap-008YcW-QT; Mon, 30 Mar 2026 11:07:31 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-001zkS-8Z; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861650; bh=dqCPK//hWZVdcc5L/u7Ya15VIfulvFBTzBi5FMRGLF0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SFLHwWLiFRB5SJLzUdu0l+RzPao/+783rGqSJYfjkXXfJgrRnaul+Q8aF+cfECPZY iaTgD6vwepPo/v345Gs1HPwizgpy7BkdMgme51VcuTAHBTlrMhrpAY8SDyKDWBJgC8 znWsNKe7C0Db8r0O1E1Roi+kRJ7oZ4t3UGRVS4+Xxgd5X2oQvJp2omk7R3zee5oQgF 0VWNDESlRP8nrWkzFnYi1DUQhBED/r87/aZSW6g1pz7r/lhsgVt5xctFZ25fhyxjBH gRqkUXZLF3xV3t7xBxMnOA3GBupznnuKg6EsTaTx7FU++6MlH3RdQTfvp7NV3tM9NG K0Fvd0i1Af+3g== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id CF68D240036; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id B656F240042; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 9A07720E49; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:11 +0200 Subject: [PATCH v2 1/7] PCI: intel-gw: Remove unused define Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-1-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=814; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=xn9R5Y4c2FVuxWGJ+XDVZ0hhgrzdWZnr3TAJrrkBg1E=; b=FHddLPDNO+kJIcVaelMDMt8m27z+6YGeOf3wn7zLgtR9c5k4XKhiMqOYgmPfXUqzmeH4AOIrI YRmjB13eGmaBJoKsyGgmgp3mTz3UKZ9E/CCTrlq6TASdbJ280mgBhFy X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate: clean X-purgate-ID: 151534::1774861651-EE6CD842-A28411D9/0/0 X-purgate-type: clean The C preprocessor define 'PCIE_APP_INTX_OFST' is not used in the sources and can therefore be deleted. Signed-off-by: Florian Eckert --- drivers/pci/controller/dwc/pcie-intel-gw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/contr= oller/dwc/pcie-intel-gw.c index c21906eced61896c8a8307dbd6b72d229f9a5c5f..80d1607c46cbbb1e274b37a0bb9= 377a877678f5d 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -47,7 +47,6 @@ #define PCIE_APP_IRN_INTD BIT(16) #define PCIE_APP_IRN_MSG_LTR BIT(18) #define PCIE_APP_IRN_SYS_ERR_RC BIT(29) -#define PCIE_APP_INTX_OFST 12 =20 #define PCIE_APP_IRN_INT \ (PCIE_APP_IRN_AER_REPORT | PCIE_APP_IRN_PME | \ --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3A843B27C9; Mon, 30 Mar 2026 09:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; cv=none; b=hbxmzuKoj6oHFJw93zF+ERgdwJ0X9NQshRVyd1FUd5MXg3CzlNEsbKp1dfaa9Rnn9rP1pIXXhulMW/yFBft+vVuTRAR+oEfTN2+g7bNFVXdGmfE/HXbmlSDMXe4XdxhD2c9aRw+MKz26aKNBi48Ck/Xns2TI6KgaEkJYs2BNVDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; c=relaxed/simple; bh=agN87K+CDzqSq8A3CtdiM5qsSgnm7chk8ZFt0OrwmeU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=kbjzRHyrZxIzXWHzLzEvwbfbpgN/AVk+b+FebPIkqc7GwISmIzPSc9jEHS1l/+eV9Ylkcm0DhNymY0Vv6oA6kkBOk93hsDYHKAFB8xc02hXzH88oz1BAUEPOjFxljkuPoq8ShHUOkmf8MiYCdP9EY//SFzhe62n1x81mZYd7h1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=edQ2oG6K; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="edQ2oG6K" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78ap-008Ycu-Ul; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-008YbP-Cp; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861650; bh=lMn3lFGeOL2LbKYJ5BgVNUmk+cjNqBsZKKuwLQ+o6aA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=edQ2oG6K66GfAqJd0kgsfIGvAxxbeJ6DEyt+5Bgy+bgnQFenimYRilAADUh5RbGMQ Q0RicTNqpHcpobDeh+HbIUWsy18osA6NtvKdKkL8iPHf7ByRfUYo2SHv784G+8jOIA ICArCQDj/oo6GFpUe78VW0qnnq9piU/Ee72S+qjhvaWmjzk2rZkrsLLXLc+b4m4TWM 3K+Q9EFjoVSa/m2AFL3BZ0gjOBVlA2iGPn3BK+k0dLC7R4wNuz3CN0yXYUc0oUJ5+9 uI+mcof7fuQsnIvNI5DmaUQl07ED1A5lbtF8chk8QXyFCGgUelVa9lsEdepQ24+iVS NHdH1OgRbk3ZA== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id E5F25240047; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id D6BDC240046; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id B50B62040A; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:12 +0200 Subject: [PATCH v2 2/7] PCI: intel-gw: Move interrupt enable to own function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-ID: <20260330-pcie-intel-gw-v2-2-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=2285; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=lb6QCw9gymNGaU3gwgLeUyGUNWDhF66pmRRGTrBntko=; b=sNI2x29ee8uZAAOa7uvLnjH0hd/tlcDXapNwhd+w/Lxe6TI2ELK+oSHLImAoSEYbbPr2pI5UM h6JCo6beY/zAk1YwVMLUenjAct7orP8Fysn3R/7pAmn9P4yV/lhKKmZ X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= Content-Transfer-Encoding: quoted-printable X-purgate-ID: 151534::1774861651-EEC25842-DDEDDA82/0/0 X-purgate: clean X-purgate-type: clean To improve the readability of the code, move the interrupt enable instructions to a separate function. That is already done for the disable interrupt instruction. In addtion, all pending interrupts are cleared and disabled, just as this is done in the disable function 'intel_pcie_core_irq_disable()'. After that, all relevant interrupts are enabled again. The 'PCIE_APP_IRNEN' definition contains all the relevant interrupts that are of interest. This change is also done in the Maxlinear SDK [1]. As I unfortunately don=E2=80=99t have any documentation for this IP core, I suspect that the intention is to set the IP core for interrupt handling to a specific state. Perhaps the problem was that the IP core did not reinitialize the interrupt register properly after a power cycle. In my view, it can=E2=80=99t do any harm to switch the interrupt off and th= en on again to set them to a specific state. [1] https://github.com/maxlinear/linux/blob/updk_9.1.90/drivers/pci/control= ler/dwc/pcie-intel-gw.c#L431 Signed-off-by: Florian Eckert --- drivers/pci/controller/dwc/pcie-intel-gw.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/contr= oller/dwc/pcie-intel-gw.c index 80d1607c46cbbb1e274b37a0bb9377a877678f5d..e88b8243cc41c607c39e4d58c4d= cd8c8c082e8b0 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -195,6 +195,13 @@ static void intel_pcie_device_rst_deassert(struct inte= l_pcie *pcie) gpiod_set_value_cansleep(pcie->reset_gpio, 0); } =20 +static void intel_pcie_core_irq_enable(struct intel_pcie *pcie) +{ + pcie_app_wr(pcie, PCIE_APP_IRNEN, 0); + pcie_app_wr(pcie, PCIE_APP_IRNCR, PCIE_APP_IRN_INT); + pcie_app_wr(pcie, PCIE_APP_IRNEN, PCIE_APP_IRN_INT); +} + static void intel_pcie_core_irq_disable(struct intel_pcie *pcie) { pcie_app_wr(pcie, PCIE_APP_IRNEN, 0); @@ -316,9 +323,7 @@ static int intel_pcie_host_setup(struct intel_pcie *pci= e) if (ret) goto app_init_err; =20 - /* Enable integrated interrupts */ - pcie_app_wr_mask(pcie, PCIE_APP_IRNEN, PCIE_APP_IRN_INT, - PCIE_APP_IRN_INT); + intel_pcie_core_irq_enable(pcie); =20 return 0; =20 --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E0A3AD531; Mon, 30 Mar 2026 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; cv=none; b=UAFKVrZ+1KwA7Nc4zeJ4bzWyGDlLnMludrG+nf8O7QTjyuKCwK2OJhlA7YxP+hlD7C1WcX6Syn/Gm5TwOO/dmaJChwlHqrO08NC2cReBMe0581PTZ/meH4b40Fl1vHrXg3mpS3+Fo82+LVgbCeYinsbfMNvZ1/lwUaLw6OWBLt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; c=relaxed/simple; bh=coHmsdtqcsW+dKyhuAd7vn7jGgDFbg9jYRqHLyenC9w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=GIgT4xWE0Bit0BJxydHm2rQCqihghZ8pXI2lD486lhGeCDAPrdX2btuk4OLRc82p0VhAJT3V3TOq6MRhPt3u3WCzIEx3P4e8Jqj2DC9x1zytw+2iZ65dpKh28GgcHyVt+fhZgs3Jdm5UjaJVXRK8vg1NV5242vBJegZ+HtBrkHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=kQfNrtS3; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="kQfNrtS3" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78aq-008Ydf-6D; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-00GTFL-KD; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861651; bh=eTw8E3ezVzDUqc+dP4JdW7vl/OP8CGUQKxaL+SejZ2g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kQfNrtS3U/b1N3yvK+ooX+3QBH1QVBrgc36X6tdWU1UM9H5za5gSHr4oUIPYS0VMt jC/xgoN0TpBR0RQqVnYDpnpCY+aGHRNXxVzuL3j9FugVfJrFbOsaPYscu2clrZEgAw vmh4mgFKhdMmEMKQaGJMDUe5YY8SKauzwDYrbp5q8wOklS2Z2fnDD4G8j2MNUltb2o UaNOzK2+/evR6AaQ3EpcNk4Fya89XbtlF00fi9kCThAVm0BHGXzHuyvjkFzKUf3eV6 nyRaAhkYXGXQ5NbYIbS+6770JoPgcfcEIVjagVv5wAqwxz1S4huT4iEWzq5dW1/il3 Gqn+au3KwRwcw== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 143FA240046; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 07392240042; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id D579F20E49; Mon, 30 Mar 2026 11:07:30 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:13 +0200 Subject: [PATCH v2 3/7] PCI: intel-gw: Enable clock before phy init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-3-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=2080; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=coHmsdtqcsW+dKyhuAd7vn7jGgDFbg9jYRqHLyenC9w=; b=T7awTZDD/b7+5jEOtcR4CkLqqj61lqSA8enPoRPazwosA0itEgbgpwu+gglvzKCRpTT1so2Uw SdhHrH9PH9ZAcddIOzuilxpL6qU4agJRCrQ+7qoKyempnq7wdfaMzp2 X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate-ID: 151534::1774861652-EF422842-845B70A9/0/0 X-purgate: clean X-purgate-type: clean To ensure that the boot sequence is correct, the dwc pcie core clock must be switched on before phy init call [1]. This changes are based on patched kernel sources of the MaxLinear SDK. [1] https://github.com/maxlinear/linux/blob/updk_9.1.90/drivers/pci/control= ler/dwc/pcie-intel-gw.c#L544 Signed-off-by: Florian Eckert --- drivers/pci/controller/dwc/pcie-intel-gw.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/contr= oller/dwc/pcie-intel-gw.c index e88b8243cc41c607c39e4d58c4dcd8c8c082e8b0..6d9499d954674a26a74bff56b7f= b5759767424c0 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -291,13 +291,9 @@ static int intel_pcie_host_setup(struct intel_pcie *pc= ie) =20 intel_pcie_core_rst_assert(pcie); intel_pcie_device_rst_assert(pcie); - - ret =3D phy_init(pcie->phy); - if (ret) - return ret; - intel_pcie_core_rst_deassert(pcie); =20 + /* Controller clock must be provided earlier than PHY */ ret =3D clk_prepare_enable(pcie->core_clk); if (ret) { dev_err(pcie->pci.dev, "Core clock enable failed: %d\n", ret); @@ -306,13 +302,17 @@ static int intel_pcie_host_setup(struct intel_pcie *p= cie) =20 pci->atu_base =3D pci->dbi_base + 0xC0000; =20 + ret =3D phy_init(pcie->phy); + if (ret) + goto phy_err; + intel_pcie_ltssm_disable(pcie); intel_pcie_link_setup(pcie); intel_pcie_init_n_fts(pci); =20 ret =3D dw_pcie_setup_rc(&pci->pp); if (ret) - goto app_init_err; + goto err; =20 dw_pcie_upconfig_setup(pci); =20 @@ -321,17 +321,18 @@ static int intel_pcie_host_setup(struct intel_pcie *p= cie) =20 ret =3D dw_pcie_wait_for_link(pci); if (ret) - goto app_init_err; + goto err; =20 intel_pcie_core_irq_enable(pcie); =20 return 0; =20 -app_init_err: +err: + phy_exit(pcie->phy); +phy_err: clk_disable_unprepare(pcie->core_clk); clk_err: intel_pcie_core_rst_assert(pcie); - phy_exit(pcie->phy); =20 return ret; } --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364693B27D3; Mon, 30 Mar 2026 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861659; cv=none; b=bKdvvczLtC3vr3N36zizLGwETO6Bb5pFBBq30YxU5I6fhsPZFS1+V3lHuOVZSP7EzPMWpenoZECQvA42rZtZaR6F3gFvIx/jMLU8hviagTd+zsupqac6F2sxFanFfkbxi2HX1fdzc5nJSgWsLna+MF4krbgORAJap/aJyjJLMxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861659; c=relaxed/simple; bh=e55VB0sOSl+JSPzr6ZYodo7iAcDR8KlkDnHRQ4PcMVk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=jsKw0FAWPR+z71ikxJNr3O0rxMl2wb9heXWlem43tHkIdglTO/gfySPf5qLZRsgmDuVs8bY8/+p+XmtgMUFkLDgXBp6YAmCp9cvnjatugTB4SQGfb3Gd313bpaWYeWLk9cJPPSrFA8HJOuy9QrOe0i3/t1bYKARkkO1aD+F4ILI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=axZyibhz; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="axZyibhz" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78aq-008YdX-5D; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-009iaI-Jq; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861651; bh=m+/djrkgilb4aSqNgXkCDE4sf4r1b8wwgRVEYUv5Q00=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=axZyibhznQD0z1wIFU65AWimUJ1U3QbLt5GxJ/ENDBbTuMEqB5CbPvQl7o0oNO9ks U0plnpdOLKXyJId1P71aMSHMUn6JrPKUMtGBaIPAOoXlWSMDxTiMZNUUOhyvph1M7p 8WaT6drBoU+pv1sMGFHfqqBBdgwyWqgE95ro/JsFmzlxFvbszM/Dh2hTsbgm/WUk1b Nkje//32iLyA+LPQ4fAJyFnAGXYPQRDQtu52qc8QrjtKaAvBdvUGvWFv+k1R8HnMvK EgxrwThE5hGnFhqNJpQnLPaZZjGL+PGbD0TORnvPzqv+pBc3xJzXX3HU01XmqW8ixb mtrduscsCao3A== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 3462F240051; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 2B60A240050; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 05A3B2040A; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:14 +0200 Subject: [PATCH v2 4/7] PCI: intel-gw: Add start_link callback function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-4-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=3052; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=e55VB0sOSl+JSPzr6ZYodo7iAcDR8KlkDnHRQ4PcMVk=; b=VkjBonXUhPvt5S5XDvblpL/gtoaP1nwAGJeUlXaTe9uYErZGn5MRGJ6P0XwSJfTh6fTkOm2bh W+BlfVSHfolBvSPpaqUk9bwYzMSvJxxuXgkayOe2nSCzRq/+QlGgWLi X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate: clean X-purgate-ID: 151534::1774861652-C7C23842-48C85DE9/0/0 X-purgate-type: clean The pcie-intel-gw driver has no start_link callback function. This commit adds the missing callback function so that the driver works again and does not abort with the following error messages during probing. [ 2.512015] intel-gw-pcie d1000000.pcie: host bridge /soc/pcie@d1000000 = ranges: [ 2.517868] intel-gw-pcie d1000000.pcie: MEM 0x00dc000000..0x00ddff= ffff -> 0x00dc000000 [ 2.528450] intel-combo-phy d0c00000.combo-phy: Set combo mode: combophy= [1]: mode: PCIe single lane mode [ 2.551619] intel-gw-pcie d1000000.pcie: No outbound iATU found [ 2.556060] intel-gw-pcie d1000000.pcie: Cannot initialize host [ 2.561901] intel-gw-pcie d1000000.pcie: probe with driver intel-gw-pcie= failed with error -22 [ 2.571041] intel-gw-pcie c1100000.pcie: host bridge /soc/pcie@c1100000 = ranges: [ 2.577736] intel-gw-pcie c1100000.pcie: MEM 0x00ce000000..0x00cfff= ffff -> 0x00ce000000 [ 2.588299] intel-combo-phy c0c00000.combo-phy: Set combo mode: combophy= [3]: mode: PCIe single lane mode [ 2.611471] intel-gw-pcie c1100000.pcie: No outbound iATU found [ 2.615934] intel-gw-pcie c1100000.pcie: Cannot initialize host [ 2.621759] intel-gw-pcie c1100000.pcie: probe with driver intel-gw-pcie= failed with error -22 Fixes: c5097b9869a1 ("Revert "PCI: dwc: Wait for link up only if link is st= arted"") Fixes: da56a1bfbab5 ("PCI: dwc: Wait for link up only if link is started") Signed-off-by: Florian Eckert --- drivers/pci/controller/dwc/pcie-intel-gw.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/contr= oller/dwc/pcie-intel-gw.c index 6d9499d954674a26a74bff56b7fb5759767424c0..24c463781f1e31d5617a5ff81bd= bce563ed5a1d0 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -284,6 +284,16 @@ static void intel_pcie_turn_off(struct intel_pcie *pci= e) pcie_rc_cfg_wr_mask(pcie, PCI_COMMAND, PCI_COMMAND_MEMORY, 0); } =20 +static int intel_pcie_start_link(struct dw_pcie *pci) +{ + struct intel_pcie *pcie =3D dev_get_drvdata(pci->dev); + + intel_pcie_device_rst_deassert(pcie); + intel_pcie_ltssm_enable(pcie); + + return 0; +} + static int intel_pcie_host_setup(struct intel_pcie *pcie) { int ret; @@ -310,19 +320,8 @@ static int intel_pcie_host_setup(struct intel_pcie *pc= ie) intel_pcie_link_setup(pcie); intel_pcie_init_n_fts(pci); =20 - ret =3D dw_pcie_setup_rc(&pci->pp); - if (ret) - goto err; - dw_pcie_upconfig_setup(pci); =20 - intel_pcie_device_rst_deassert(pcie); - intel_pcie_ltssm_enable(pcie); - - ret =3D dw_pcie_wait_for_link(pci); - if (ret) - goto err; - intel_pcie_core_irq_enable(pcie); =20 return 0; @@ -386,6 +385,7 @@ static int intel_pcie_rc_init(struct dw_pcie_rp *pp) } =20 static const struct dw_pcie_ops intel_pcie_ops =3D { + .start_link =3D intel_pcie_start_link, }; =20 static const struct dw_pcie_host_ops intel_pcie_dw_ops =3D { --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C3C3B27E2; Mon, 30 Mar 2026 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; cv=none; b=Ya95axyUmtLN7e/Z7j/Q7IFQ6iJ8Xywo4XRQ7nSPeUWt3aQBBv8W4+UpWx6m5d2bcReTuyGWf9nZrVI8N0kwpXu2yWs2/kdHOmu3oyiSiLWYfe5DYxnb7KZGYeYDA+lWfje9BEYGxExMRynn4/b+dc2QTXuIuOjVPMgYWYDDFT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; c=relaxed/simple; bh=Ati0WQXsi/BbMty7w9zy15si5sKm0IPY4TkcmlS7Z9Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=TwiSOULND/gigdDtBC1biJ6yA5nqb+iL4zhm4D6fRIlu7ueDADawFDI1vVnCe60/ng8g333k3/JlbFITO5O89hmiNV1Tcf1m8T2gBAgUY94RS5Qg66QLeXM/r1gjWMHVexq1iLPOH2z4tsdhO0RI6iTs5sQHGKhNZ0fkApsU1J4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=kTaggtKJ; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="kTaggtKJ" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78aq-008YeN-Fd; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-008YcB-Rg; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861651; bh=BofokuiPDJZU4b3Xyu05PlOTjPGWqOiC0E9vOzhVtD4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=kTaggtKJHvwlPslYA1urj+6xWZcviq4exu8SP6+kYfFe8W7Lnn3O8m5f7WBpJeRGa eqgrQsl+4wpN25EytML4Pkd00CRU/rNxN9xd1z1ij5BFIpea85IP30DaPpOHXg1gdC eIeeuBpMy5dybdI/Ydp/GkNjCr1+hkCnBy3NQBgaxSSMa91IFdQeTZQqrylkg3OE7Q owt/a3tEdGKA/QFdkdw0REyFthVPNwCzmcHE8Nn2DZA9hEpeeU3wx/FtripEchd24J ejKtzTD2JOblmg+DbpWDGCMYATiRj590vneD4ZCKqCB90A8dQYyqYhC/DB7omAkrBi gC+zaKAUVG4+A== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 67C15240040; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 5F04C240036; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 29A7B20E49; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:15 +0200 Subject: [PATCH v2 5/7] PCI: intel-gw: Remove atu base assignment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-5-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=2173; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=Ati0WQXsi/BbMty7w9zy15si5sKm0IPY4TkcmlS7Z9Y=; b=kTeDwbb87ZDCFjB4oRXDikxEf8css8e5gSMQkHoRoDrxSAMvbLkmSNkFHdR3WQ72AuM5xJRUV foMvxU2nXl3DDPapCb6sGOvsz+EbdiHd4qDMd3eo6wgBb+hx/rdO18j X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1774861652-C6C25842-7B2AD83F/0/0 If no ATU resource is defined in the DTS, the default value is 0x300000[1]. This is set during probing in the function 'dw_pcie_get_resources()'[2]. The driver overwrites this again when its init callback is called in its 'intel_pcie_host_setup()' [3] function. This is because the value here is '0xC0000' rather than '0x300000'. This callback is called by the dwc core via 'pp->ops->init' [4]. function callstack: intel_pcie_probe() dw_pcie_host_init() dw_pcie_host_get_resources() dw_pcie_get_resources() [2] pp->ops->init =3D intel_pcie_rc_init() intel_pcie_host_setup() [3] As backwards compatibility is not an issue here [5], the value for the ATU resource is moved to the DTS and is therefore loaded by the dwc core. It is therefore no longer necessary to overwrite the pci->atu_base address in the init callback. The DTS must be modified so that the additional resource is loaded correctly by the DWC core. [1] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller= /dwc/pcie-designware.h#L292 [2] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller= /dwc/pcie-designware.c#L150 [3] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller= /dwc/pcie-intel-gw.c#L301 [4] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller= /dwc/pcie-designware-host.c#L589 [5] https://lore.kernel.org/all/BY3PR19MB507667CE7531D863E1E5F8AEBDD82@BY3P= R19MB5076.namprd19.prod.outlook.com/ Signed-off-by: Florian Eckert --- drivers/pci/controller/dwc/pcie-intel-gw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/contr= oller/dwc/pcie-intel-gw.c index 24c463781f1e31d5617a5ff81bdbce563ed5a1d0..f41b64ac48d5c05e6b0e5b14c3e= 0cd7a4c407d16 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -310,8 +310,6 @@ static int intel_pcie_host_setup(struct intel_pcie *pci= e) goto clk_err; } =20 - pci->atu_base =3D pci->dbi_base + 0xC0000; - ret =3D phy_init(pcie->phy); if (ret) goto phy_err; --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E193B27EE; Mon, 30 Mar 2026 09:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861659; cv=none; b=DRGeUoqm62qmxmDQDoqIBkDRUqnPKhRzBeXK1NVLOyER2B6Gvx+scOhw0kjOyDaPVU3I9E7qhSdeZaDYkvlFEQKuZVvtU1XKicxLpqDvCaD3KVy+3l7kpcAYft7gOrbAn0eDdB+KcgAoAOZwxHGdrAo97Ow5vuEL4K1Xi3HDlRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861659; c=relaxed/simple; bh=44idu4lYBdKXyDCFc9AO6ve7cpsNsJ7WQmMRL/XaSSA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=VT60gQyAqo+REvCLuu4vCOqnCTKMHDSO4DtBjk4wTnQYG2sUXG04OOZc5wFyUslYTNKoyfIO5ULu4VIMMZbNbVji1j4F5Kl2A6vDylpVh7EBMQTRoHekefIy/3audyy775+N33l2epeJk+qgRZZLAJrVViwhY99z6QRh9EUYO0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=vAS07I3H; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="vAS07I3H" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78aq-008YeP-GA; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78ap-009iaO-Uj; Mon, 30 Mar 2026 11:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861651; bh=Lo8WEUkHygeOqbMVPhJFGYFHIJXRE1Uzi8HNns3bkEw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=vAS07I3HaPpi0MC8vRKNLCCWN2U6M5z/8BPTxwgWzPhoCDkdTQYRtQUdPsQq5EEDq 7u4e02n76XY3ajnK1YDON6eMTsHbdFRY+9k4+3IizEEJUxTl7fxvX4rgQeQBQzszkk fOufYlok8C2pZ+HJOI43qhrc+z3qwTznCZKKoNK/odj17ImIcE/FjNERupgid8+yRx H5esvO2tXlpzeVM/INpKx7b6gbDwuXQc2AaVxyyHq29zmxxAt52D1U+VbccNtSolrp QCdX7mXeYLDTTqZegkG3U7LPzyhNDg5/koX/l4ljf9RiT9b3ag8WDDYzPd5g16NP+e ZkyfdZUZ4Gifw== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 8AD7C240036; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 80E7D240045; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 5D5E02040A; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:16 +0200 Subject: [PATCH v2 6/7] dt-bindings: PCI: intel,lgm-pcie: Make atu resource mandatory Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-6-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=2279; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=44idu4lYBdKXyDCFc9AO6ve7cpsNsJ7WQmMRL/XaSSA=; b=6a+kh0mrGISPBeBV/cRAwP8gS1HnnlsT0AWSdGXFxEO18dzeS8qY2onc1qUgtozQ9Uoeo0n+s flstiyub/yWCgJKA0My87ZAtUKMOtJqQkxL0lz0Z3fWChoNPmSrCaEh X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate-type: clean X-purgate-ID: 151534::1774861652-ECECE842-7064A64C/0/0 X-purgate: clean The ATU information is already set in the dwc core if it is specified in the DTS. The driver uses its own value here [1]. This information is hardware specific and should therefore be maintained in the DTS rather than in the source. Backwards compatibility is not an issue here [5], as the driver is exclusively used by Maxlinear. Old DTS entry for PCIe: reg =3D <0xd1000000 0x1000>, <0xd3000000 0x20000>, <0xd0c41000.0x1000>; reg-names =3D "dbi", "config", "app"; New DTS entry for PCIe: reg =3D <0xd1000000 0x1000>, <0xd10c0000 0x1000>, <0xd3000000 0x20000>, <0xd0c41000.0x1000>; reg-names =3D "dbi", "atu", "config", "app"; [1] https://elixir.bootlin.com/linux/v6.19.10/source/drivers/pci/controller= /dwc/pcie-intel-gw.c#L301 [2] https://lore.kernel.org/all/BY3PR19MB507667CE7531D863E1E5F8AEBDD82@BY3P= R19MB5076.namprd19.prod.outlook.com/ Signed-off-by: Florian Eckert --- Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml b/Doc= umentation/devicetree/bindings/pci/intel-gw-pcie.yaml index 54e2890ae6314ac6847fc23f49440d05d66d87d4..e4b781f57e8ae84a3ffc33635a4= 21e1a5761587e 100644 --- a/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml @@ -29,12 +29,14 @@ properties: reg: items: - description: Controller control and status registers. + - description: Internal Address Translation Unit (iATU) registers. - description: PCIe configuration registers. - description: Controller application registers. =20 reg-names: items: - const: dbi + - const: atu - const: config - const: app =20 @@ -94,9 +96,10 @@ examples: #address-cells =3D <3>; #size-cells =3D <2>; reg =3D <0xd0e00000 0x1000>, + <0xd0ec0000 0x1000>, <0xd2000000 0x800000>, <0xd0a41000 0x1000>; - reg-names =3D "dbi", "config", "app"; + reg-names =3D "dbi", "atu", config", "app"; linux,pci-domain =3D <0>; max-link-speed =3D <4>; bus-range =3D <0x00 0x08>; --=20 2.47.3 From nobody Thu Apr 2 07:43:58 2026 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E132D2397; Mon, 30 Mar 2026 09:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; cv=none; b=Hq7oK9xVDjrTx7f6hAyZIFJjWnbmeBYy5JTNX4zwEQ9THFa7wHJyb9tJ7sLpdZuTi61QjsSVNIKt37vhRaDtkoEz1u6F0IeZ5txdK2qX02hljo5Csz3nAw55NU01pBl40d3uCJ2l1ORf3h1XdEVBqnt1bfxKnYhyOCk1f5sivyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861658; c=relaxed/simple; bh=TNKQcUOxp3IEx4/KXd1OG59UNOtH64WRIf6g/vY5agA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:Cc; b=Ld0TwtTVuazsqGqYwYDEU2ccoWhecf9TJPkpOwJ4WnyMR4aQecbj9uEGNL/U1CPImpnm/BrckFzLAiyKVOHNm/vdr84FrRcouP+RFWnqs3pjLW91pHuYzUENA0p+HOgUi/fEakiaO/khqlliX2ZQ8gglJY3NdKIXVbcmrmP+BEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=WAqNAn+d; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="WAqNAn+d" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w78aq-008YfB-Ld; Mon, 30 Mar 2026 11:07:32 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w78aq-00GTFS-43; Mon, 30 Mar 2026 11:07:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1774861651; bh=E2ZTfUj86mp0drWTHwRl8zkHJBvXCjXQAwVjq3aAu94=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WAqNAn+dFmHdlv6/Kbl2yXL1/PrYLN5oyTdyjMklTNMpY6iwJJWyHFfpiJwkxH9QN A2tEQBq/KpBhDz1fuWNqxED7OWse2qRVR8l9wFnFHKb+typoioVdpn7ijpMFm1cn5i 9R6NUVCQEx6TGS3lHoztVu+TxQazshswGmqc/amoNbm9g0Q4ulxZlm7uixyIMlM3rG DE7dikMKpCPKfbC39kK8qwvLYXEQ4ZCChT3L1FuZifHQ/gkkKo6J3cfHorlsnGsz1k QC3ZB0n8OPbWIcpkMY0NQs08Ps+I6E/yo2pvB9/CYI60pb9v3NZlv0jbc4XCXwHNvS 7N5MUB8K4+Dqw== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id B2E6E240046; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id AA9F7240045; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) Received: from [10.2.3.40] (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 7F72020E49; Mon, 30 Mar 2026 11:07:31 +0200 (CEST) From: Florian Eckert Date: Mon, 30 Mar 2026 11:07:17 +0200 Subject: [PATCH v2 7/7] MAINTAINERS: Remove bouncing intel-gw maintainer Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260330-pcie-intel-gw-v2-7-8bd07367a298@dev.tdt.de> References: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> In-Reply-To: <20260330-pcie-intel-gw-v2-0-8bd07367a298@dev.tdt.de> To: Lorenzo Pieralisi , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Johan Hovold , Sajid Dalvi , Ajay Agarwal , Krzysztof Kozlowski , Conor Dooley , Rahul Tanwar Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Florian Eckert , Eckert.Florian@googlemail.com, ms@dev.tdt.de X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774861650; l=809; i=fe@dev.tdt.de; s=20260205; h=from:subject:message-id; bh=TNKQcUOxp3IEx4/KXd1OG59UNOtH64WRIf6g/vY5agA=; b=Ai4EcdTuvfoadf2/5hKFXz45gpxWf53pA0vgteDN6C0heygXcZD4+D9vlqn+/XioMS5vdF9sV 0OSYzHuStAmDC4gjuvVpYRpVHz5KKPyGrnqF8ITjr0+8i5l46wqOSjz X-Developer-Key: i=fe@dev.tdt.de; a=ed25519; pk=q7Pvv3Au2sAVRhBz5UF7ZqUPNxUwXQ78Jdqu8E6Negk= X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1774861652-06AC7842-4ED56781/0/0 The maintainer's email address has been bouncing for months. Mark the PCI intel-gw driver as orphaned. Signed-off-by: Florian Eckert --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 96ea84948d76aff5e07579911d0f370ae13f481b..26f3b2e192fa9ef2e1c89d2310b= ebaa0a67dff00 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20505,9 +20505,8 @@ F: Documentation/devicetree/bindings/pci/intel,keem= bay-pcie* F: drivers/pci/controller/dwc/pcie-keembay.c =20 PCIE DRIVER FOR INTEL LGM GW SOC -M: Chuanhua Lei L: linux-pci@vger.kernel.org -S: Maintained +S: Orphan F: Documentation/devicetree/bindings/pci/intel-gw-pcie.yaml F: drivers/pci/controller/dwc/pcie-intel-gw.c =20 --=20 2.47.3