From nobody Wed Apr 1 11:07:03 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8659D399007 for ; Mon, 30 Mar 2026 19:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898827; cv=none; b=SdRP0hCes9a3AjrJVNk3rLhuHTiISXHz4VJ3Hg1ssxSzCkfWZPS+M3Q1usL/SdA63M5SQHJNZ2Xau8hIg7tWGjJ811OQKWxu9aDpzPWZosw0sopq3hS13XpMywGMmAqS85RTnVGSMXlgfJPw4FZHOgwCwH9jLoSvgBmM1qu1o+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898827; c=relaxed/simple; bh=R0ebnJ6qrNna1VrOtxRIwwfFZx59fPLMHaDL3c7t4zo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mqHhipCWFj+kXMGrI6saKdCtgjq18y2TeKqXF5U8ko/cctz8g3y9aDsoEIhwAcI62fypMdCTAJNFlrfJ1S/XLot9oXyh+aljUbb6EDwXyFhuu9DOxh17dUD6v1hHKbVX+D2vG2VGKbBu0gE6Pgf9N4dTzkhKAfZ8nPUjQr6Ks5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JBxF/xwy; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JBxF/xwy" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 0DF6A1A3090; Mon, 30 Mar 2026 19:27:04 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C1AE35FFA8; Mon, 30 Mar 2026 19:27:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1627810450B50; Mon, 30 Mar 2026 21:26:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898820; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jXjz4tZtuVEq+hWrmCAUagtFbybLj/9NWSGKn/xDMdU=; b=JBxF/xwyqBirTzI8n8ol6nz+o9gkOandjrcg/frbHTeby7fDWUjHok3DXcCOiImGk6zg6l p/OM7nRKrKDxCZa3v15dqNhpRqETfCvVbRIC/wDyrk4B5mwFoTpqpFBghryyudcxREO7oh jzswn3cu66i4wfKXiCxr5A7d2CvgZsfJMpHF9rHyjZVtXmqnA+9YmHMl88sJLYk717l6vD II4+eiaO5+Z1yzvskP6KT/TNs1sfFXQ1sbxe+TvCl04FWnpcO0t1jl/p9qtLPv8vEOBMLD 3x6oWuLVoynrKX8q9IAYkqaKbIreGbnBbvgTHWoSW/3+PzlE3ZMLPrRbjoOaaQ== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:44 +0200 Subject: [PATCH v2 03/10] drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-3-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 lcdif_attach_bridge() uses dev_err_probe() in some error paths, dev_err() + return in others. Use dev_err_probe() for all of them to make code consistent, simpler and with bettere error reporting. Signed-off-by: Luca Ceresoli --- Changes in v2: - rewrote after removal of previous patch removing loop - not added review/test trailers as the code is a bit different --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 8da8a265c05c..1c76709c4d94 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -63,10 +63,8 @@ static int lcdif_attach_bridge(struct lcdif_drm_private = *lcdif) continue; =20 ret =3D of_graph_parse_endpoint(ep, &of_ep); - if (ret < 0) { - dev_err(dev, "Failed to parse endpoint %pOF\n", ep); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to parse endpoint %pOF\n", ep); =20 bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 0, of_ep.id); if (IS_ERR(bridge)) @@ -75,20 +73,18 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) of_ep.id); =20 encoder =3D devm_kzalloc(dev, sizeof(*encoder), GFP_KERNEL); - if (!encoder) { - dev_err(dev, "Failed to allocate encoder for endpoint%u\n", - of_ep.id); - return -ENOMEM; - } + if (!encoder) + return dev_err_probe(dev, -ENOMEM, + "Failed to allocate encoder for endpoint%u\n", + of_ep.id); =20 encoder->possible_crtcs =3D drm_crtc_mask(&lcdif->crtc); ret =3D drm_encoder_init(lcdif->drm, encoder, &lcdif_encoder_funcs, DRM_MODE_ENCODER_NONE, NULL); - if (ret) { - dev_err(dev, "Failed to initialize encoder for endpoint%u: %d\n", - of_ep.id, ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to initialize encoder for endpoint%u\n", + of_ep.id); =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); if (ret) --=20 2.53.0