From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71BCE3988EE; Mon, 30 Mar 2026 19:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898806; cv=none; b=jEhVyrnR40EpPl2FqwzQwjP1M7eCqYSRzVaP7rq9qirZCue0z6issob5J/O4/K7PEn89Wxjd5Yd+XG8Tnw5AkPOZ37dtDXDs2//TlTVOa9R57SmSB5jXqNBoXn7wgitpaCSYYjuQB5kfJwvWfLRfnznnlgLhP0Snk15/o226eP4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898806; c=relaxed/simple; bh=xCyOeEb1Rt3PAU0y1z2oi9zSYVPFWqIkwkXXe5MYVu4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bsRQhzvfsHo4p0FmN+PeoaZ7HFy5T2abJuLVyMiWvc6RjfeVZAYyBo5r2ep+YiP33nNCjc/8mk3LPMINwgx8mO3b++B8LU/2mcypJu25b50MB8bqk4nT/OuRzuvRpU0EFILPbNsfClnEEtyHBBPTk3PdsNhHPujxXKNWjmKNUcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DUBF8zzn; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DUBF8zzn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1D3E54E42871; Mon, 30 Mar 2026 19:26:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DC0B35FFA8; Mon, 30 Mar 2026 19:26:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7BD5510450A1D; Mon, 30 Mar 2026 21:26:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898799; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ivxqBE+xFSPsodl278KAuSqCfPXljKrE3bnno2mTk08=; b=DUBF8zznaRhYoRbXCbhou5bEfqo1KCg4iOZaX87EG1PqnLrN/gCiL/Qb7x6hmGEUklMQOf Q3IdaGFCp8xE7U74CKnO8DzAVepH4yMfVsjedNfCmLKyPpmQv72T379fVZHMNAT47AohL0 ZeVyXPCpAnTjZxEdAMODIgcJzx4J/6d8aZTaDQGlK4CJMmuVaDMYHigdHzK9McEELlN2EO vYRM0iMMuCRiJnziJwMINhUxCuRnV5ZISDV6WRU7cpkwg9ncmROHuX4mPEw5UY8nUfd33O eXwOCCnJGNs20ghKae9xfRXUs2zSK32r12Grbze+xI5D+zxW6bcblVuAm2NyEg== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:42 +0200 Subject: [PATCH v2 01/10] drm/mxsfb/lcdif: simplify remote pointer management using __free Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-1-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 Putting the remote device_node reference requires a of_node_put(remote) in two places. Use a cleanup action to simplify the code. Reviewed-by: Liu Ying Tested-by: Martyn Welch Tested-by: Alexander Stein # TQMa8MPxL/MB= a8MPxL Signed-off-by: Luca Ceresoli --- Changes in v2: - Use the correct cleanup action - Fix commit message - add missing cleanup.h include --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 47da1d9336b9..7719629487da 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -5,6 +5,7 @@ * This code is based on drivers/gpu/drm/mxsfb/mxsfb* */ =20 +#include #include #include #include @@ -53,16 +54,13 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) int ret; =20 for_each_endpoint_of_node(dev->of_node, ep) { - struct device_node *remote; + struct device_node *remote __free(device_node) =3D + of_graph_get_remote_port_parent(ep); struct of_endpoint of_ep; struct drm_encoder *encoder; =20 - remote =3D of_graph_get_remote_port_parent(ep); - if (!of_device_is_available(remote)) { - of_node_put(remote); + if (!of_device_is_available(remote)) continue; - } - of_node_put(remote); =20 ret =3D of_graph_parse_endpoint(ep, &of_ep); if (ret < 0) { --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAFC1397E6A for ; Mon, 30 Mar 2026 19:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898816; cv=none; b=HckfcXzAgNYmj1QUCc+3ebthZXXtbmFAbeBnDdEBh/CLZak4Cj6rmQePxVbMX8UXq/BdjGrtbiskmGxS8nEWA/EnRJip34lC0p6dHmVGwjmGTDbL+r9Zbk2VMmET4RZkvLS9nX9KmFUxw5KmGZr3grw7/LUmZFtPAtWRyRRAg0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898816; c=relaxed/simple; bh=6Pcf82giUoyz4el+483qK1+q2iHJAfuimQRDnd6B49k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jhy51q2o2k9SxNNou95MBhbwDtcNHYy2XRA66EAEi0qwj6n9HiAczuodzFeJrba8foEgI7NjZuNeyPPq+N9Y56V0tCPwWhQ3eXqzc65VLkCmdF9Cq9fi4+VfEEd2ms2Ye0XQvUdFXhK4MhC0RS5Rq3V8n1zdT//Vj4AJeA+IIBc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=CipHVpMu; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="CipHVpMu" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 83A034E42876; Mon, 30 Mar 2026 19:26:53 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4CC545FFA8; Mon, 30 Mar 2026 19:26:53 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A46FF10450CE2; Mon, 30 Mar 2026 21:26:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898810; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=r5YD/yxjXsXR/FTuyz0kb/x6C7V4fkojRRR9SHdzDk8=; b=CipHVpMu1QXvt145DSbXYeg6wDRBgyPwSrsA3rmWjAr9xhneOmVEAIrlfDq0sLCBACK+g9 P6Wrf9YJybynvalCqXBZW33gqQE9EsdtKgGCoK+EuayXGtnk5ppmD24zUjpgx6AtErXGlA k6wx+6tCFSI3OjSzrEakUrJ1eWd3OeWbRxoz8luAFGZ+93+gX5sYehYIl54e5L4xJBlDNt Wp023PeUgPFeqdN7YdzWIz5oyEwbWkS2rg1Nu1+lpqk2yc0RUMLHCjO2TtyRi8hPXR+9kS 3XesAILVcMNxjKHGI1nh+0I5dHy/rG4LJBmkRbwBbEum678UFwgNgoX3wHU0ig== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:43 +0200 Subject: [PATCH v2 02/10] drm/mxsfb/lcdif: simplify ep pointer management using __free Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-2-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 Putting the ep device_node reference requires a of_node_put(ep) in many return points. Use a cleanup action to simplify the code. Signed-off-by: Luca Ceresoli --- This patch is new in v2 --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 7719629487da..8da8a265c05c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -49,7 +49,7 @@ static const struct drm_encoder_funcs lcdif_encoder_funcs= =3D { static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) { struct device *dev =3D lcdif->drm->dev; - struct device_node *ep; + struct device_node *ep __free(device_node) =3D NULL; struct drm_bridge *bridge; int ret; =20 @@ -65,23 +65,19 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) ret =3D of_graph_parse_endpoint(ep, &of_ep); if (ret < 0) { dev_err(dev, "Failed to parse endpoint %pOF\n", ep); - of_node_put(ep); return ret; } =20 bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 0, of_ep.id); - if (IS_ERR(bridge)) { - of_node_put(ep); + if (IS_ERR(bridge)) return dev_err_probe(dev, PTR_ERR(bridge), "Failed to get bridge for endpoint%u\n", of_ep.id); - } =20 encoder =3D devm_kzalloc(dev, sizeof(*encoder), GFP_KERNEL); if (!encoder) { dev_err(dev, "Failed to allocate encoder for endpoint%u\n", of_ep.id); - of_node_put(ep); return -ENOMEM; } =20 @@ -91,17 +87,14 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) if (ret) { dev_err(dev, "Failed to initialize encoder for endpoint%u: %d\n", of_ep.id, ret); - of_node_put(ep); return ret; } =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); - if (ret) { - of_node_put(ep); + if (ret) return dev_err_probe(dev, ret, "Failed to attach bridge for endpoint%u\n", of_ep.id); - } } =20 return 0; --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8659D399007 for ; Mon, 30 Mar 2026 19:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898827; cv=none; b=SdRP0hCes9a3AjrJVNk3rLhuHTiISXHz4VJ3Hg1ssxSzCkfWZPS+M3Q1usL/SdA63M5SQHJNZ2Xau8hIg7tWGjJ811OQKWxu9aDpzPWZosw0sopq3hS13XpMywGMmAqS85RTnVGSMXlgfJPw4FZHOgwCwH9jLoSvgBmM1qu1o+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898827; c=relaxed/simple; bh=R0ebnJ6qrNna1VrOtxRIwwfFZx59fPLMHaDL3c7t4zo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mqHhipCWFj+kXMGrI6saKdCtgjq18y2TeKqXF5U8ko/cctz8g3y9aDsoEIhwAcI62fypMdCTAJNFlrfJ1S/XLot9oXyh+aljUbb6EDwXyFhuu9DOxh17dUD6v1hHKbVX+D2vG2VGKbBu0gE6Pgf9N4dTzkhKAfZ8nPUjQr6Ks5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JBxF/xwy; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JBxF/xwy" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 0DF6A1A3090; Mon, 30 Mar 2026 19:27:04 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C1AE35FFA8; Mon, 30 Mar 2026 19:27:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1627810450B50; Mon, 30 Mar 2026 21:26:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898820; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=jXjz4tZtuVEq+hWrmCAUagtFbybLj/9NWSGKn/xDMdU=; b=JBxF/xwyqBirTzI8n8ol6nz+o9gkOandjrcg/frbHTeby7fDWUjHok3DXcCOiImGk6zg6l p/OM7nRKrKDxCZa3v15dqNhpRqETfCvVbRIC/wDyrk4B5mwFoTpqpFBghryyudcxREO7oh jzswn3cu66i4wfKXiCxr5A7d2CvgZsfJMpHF9rHyjZVtXmqnA+9YmHMl88sJLYk717l6vD II4+eiaO5+Z1yzvskP6KT/TNs1sfFXQ1sbxe+TvCl04FWnpcO0t1jl/p9qtLPv8vEOBMLD 3x6oWuLVoynrKX8q9IAYkqaKbIreGbnBbvgTHWoSW/3+PzlE3ZMLPrRbjoOaaQ== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:44 +0200 Subject: [PATCH v2 03/10] drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-3-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 lcdif_attach_bridge() uses dev_err_probe() in some error paths, dev_err() + return in others. Use dev_err_probe() for all of them to make code consistent, simpler and with bettere error reporting. Signed-off-by: Luca Ceresoli --- Changes in v2: - rewrote after removal of previous patch removing loop - not added review/test trailers as the code is a bit different --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 8da8a265c05c..1c76709c4d94 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -63,10 +63,8 @@ static int lcdif_attach_bridge(struct lcdif_drm_private = *lcdif) continue; =20 ret =3D of_graph_parse_endpoint(ep, &of_ep); - if (ret < 0) { - dev_err(dev, "Failed to parse endpoint %pOF\n", ep); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to parse endpoint %pOF\n", ep); =20 bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 0, of_ep.id); if (IS_ERR(bridge)) @@ -75,20 +73,18 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) of_ep.id); =20 encoder =3D devm_kzalloc(dev, sizeof(*encoder), GFP_KERNEL); - if (!encoder) { - dev_err(dev, "Failed to allocate encoder for endpoint%u\n", - of_ep.id); - return -ENOMEM; - } + if (!encoder) + return dev_err_probe(dev, -ENOMEM, + "Failed to allocate encoder for endpoint%u\n", + of_ep.id); =20 encoder->possible_crtcs =3D drm_crtc_mask(&lcdif->crtc); ret =3D drm_encoder_init(lcdif->drm, encoder, &lcdif_encoder_funcs, DRM_MODE_ENCODER_NONE, NULL); - if (ret) { - dev_err(dev, "Failed to initialize encoder for endpoint%u: %d\n", - of_ep.id, ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to initialize encoder for endpoint%u\n", + of_ep.id); =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); if (ret) --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A438397E7D; Mon, 30 Mar 2026 19:27:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898837; cv=none; b=Mv+gXJHUeqqmJb2DdKZ79wzwopAUG76pEu3r6quBUDvhqdrsnZGQ0eTI/3pfqH/XYEeGPjuZ/vhpKKaehAY8Neo8xZYSzbK1NKcwmcqfJLGEmP1EvyfF34dJKjJZu3B0wYaXAzHcgr24MEXe2aSSFVdOVZt20SAHPw8FeD+fohk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898837; c=relaxed/simple; bh=67BecinHv8uNkx13YQtQOdO/VfN630S0g0v7Zaiz2BE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qaB8iDKupBmhLkpTbRZWFYlZE67o/OT9LfKEXJ8BUK1+EU5g4OHH3JkFgtC9DmyfANPs1I/DH5LfEClSmHFq94Uv8d4ClIOu9gX10uqRL+vN1xJQregBiy6oblCQnI7U54ZmCHbCsuMYFfwbQhDGOU5g2SfKKFCoQDaLJ5Teqik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GI5rb1mn; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GI5rb1mn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id D51871A3090; Mon, 30 Mar 2026 19:27:14 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A46055FFA8; Mon, 30 Mar 2026 19:27:14 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 4AC1610450A1D; Mon, 30 Mar 2026 21:27:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898831; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=LB8F39dnm+yWAxgcFRa27us+SDsfN60WmWpBoxHvYqA=; b=GI5rb1mnrDS9yyt7I390DDbYlsXwX8BS4puwHEeopz0HSK5o/wu98GWdd6j9u/Mhonljpn qhm9z8GtkMdy97Yzrxm1oGVFOWVPO7Xsmx92BtXSLGoEOMSNJ1S0a4G4H3YKK2D8EeKtym tT/LFv15ALlCfXuu6+XScOoVcvUDwrT6yl2Kv+W7YTlIppzMsKZcu1Bw0Qxv9BuT7N0zHB B+E/8elgjZ1biUVaIryxfGZo+l7B3my0qCtriSrqaSsAp+CZ1zSk/JR6m4JKSFMqCtWU4T NePGfLp0dJJwKIV7CJBt/GuXPfqjB0tDmnOGx3HwVboWrtztr8c/Azs8toXsHA== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:45 +0200 Subject: [PATCH v2 04/10] drm/mxsfb/lcdif: lcdif_attach_bridge: move iteration-specific variables declaration inside loop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-4-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 The bridge and ret variables are per-iteration variables, whose values don't have to be carried to the next iteration or be used after the loop end. Move their declaration inside the loop scope as a cleanup and to make code clearer. Signed-off-by: Luca Ceresoli --- This patch is new in v2 --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 1c76709c4d94..c8ba8f9b1da8 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -50,14 +50,14 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) { struct device *dev =3D lcdif->drm->dev; struct device_node *ep __free(device_node) =3D NULL; - struct drm_bridge *bridge; - int ret; =20 for_each_endpoint_of_node(dev->of_node, ep) { struct device_node *remote __free(device_node) =3D of_graph_get_remote_port_parent(ep); struct of_endpoint of_ep; + struct drm_bridge *bridge; struct drm_encoder *encoder; + int ret; =20 if (!of_device_is_available(remote)) continue; --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B124E3988FD for ; Mon, 30 Mar 2026 19:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898849; cv=none; b=sw82Bl8Ip/Vf88TlZhYwuSXllGO2Xx9E4lS3noo+UKC8L+8W818ZHz9gEEPGUN07suRh9EIdTxYoI1Ixwf4tDBvgHnsFkkaJOjB6m+jDfjT++FNZ00CKMDXCo4xTRaskMB5dErGEMfeecEp/XPd9r+876+vfgjo3N4KCXwH8t+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898849; c=relaxed/simple; bh=oRDSLVIhZREQnhojtBhd+XVOGond5MBmTbcfchbLU+0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fwTezcLnopHFuruD9aZ8uSP33ZIHC6rzk7m9Z3v+CXx3ELdZDTC7Zlfgq30sI9Y0tuDxiP7XMxhnjqadc+dgcJgpzIpRzu33VARAgqSIXYeXbPrzgB+Fj2xzgcjJcm4KrQgNojLf2SryEChFKFxM8db/KptVepwT3x1X99vWXjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=F9vgzbbE; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="F9vgzbbE" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 774BC4E4286D; Mon, 30 Mar 2026 19:27:25 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 479D05FFA8; Mon, 30 Mar 2026 19:27:25 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7C99510450C85; Mon, 30 Mar 2026 21:27:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898842; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=VuQRGR76TLjd4qdXspTNlbhKj4opWUlSzRZbLjOVvpA=; b=F9vgzbbEcNJVkvVzGgGFoBmR/Y82n5lzSKHfow5QeEc5erRoRaeUyYagLIDpymkFqaYhrV 0aJZwyRDdf72JL1fmibdwxK+nfwuW+cd1y9OIqSKMV1CIvv/7/QizOsBpDumAFaSV1v6vH K77yGlxpXpBgJyMvFDcm8HsB/PZrCjqrf8ddbS/Zw6ObrJC/1rJAmAU77pzZplXF761A5B CEDcj/JElQGEBeOahSZfQfZ4TmAB56xSfrlB8jaNccZwYnGydUjvKHrESw/cz8FW7W0KLd u8cXbiiSho5q5HMhryYZmlIeCXZ81/fmvUptQG3N2qNQIsM94wuLpjbXCeiLnw== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:46 +0200 Subject: [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-5-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 The meaning of this flag may not be obvious at first sight. Reviewed-by: Liu Ying Tested-by: Martyn Welch Tested-by: Alexander Stein # TQMa8MPxL/MB= a8MPxL Signed-off-by: Luca Ceresoli Tested-by: Damon Ding (on rk3399) --- Changes in v2: - improved comment as suggested by Liu --- include/drm/bridge/dw_hdmi.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h index 336f062e1f9d..8500dd4f99d8 100644 --- a/include/drm/bridge/dw_hdmi.h +++ b/include/drm/bridge/dw_hdmi.h @@ -126,6 +126,12 @@ struct dw_hdmi_phy_ops { struct dw_hdmi_plat_data { struct regmap *regm; =20 + /* + * The HDMI output port number must be 1 if the port is described + * in the device tree. 0 if the device tree does not describe the + * next component (legacy mode, i.e. without + * DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge). + */ unsigned int output_port; =20 unsigned long input_bus_encoding; --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7269D3988F1; Mon, 30 Mar 2026 19:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898861; cv=none; b=m+xyb/BY7LGgA5RQfYOtwLroTywXgH7FUhlYF8UTyFggoOc3siUPbkGcmpvOsof85zK/NnTK1gtEZksXHy9OtGdma6nTGMkGtBbvhZbXxicFyxBDApJ6MJF0theY39RhnqtWHNkRV/Ejgc0fs8zElpJGlxKOUumiKlznZQ2621Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898861; c=relaxed/simple; bh=Jt9K1sF+2992vS0R60lkewDb/SpPcd+jIzSohZ+ZTbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AykKJKI4KtC2qENWvhzfQU8iy6B41u6a6vr2UXivYGmplinw8GkQMggFhgHJbW2JAOUik6utGESf/O/ZihLbOS4budcTHIHvzsupDj6SVwYU98HG1ETTKqF1kDQ131incaK+NZA4PN9qV1ZX83iz7R1l8koJx6BG24sdOraXbko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=0PHcwA9M; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="0PHcwA9M" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 2DCE04E4286D; Mon, 30 Mar 2026 19:27:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id F26E05FFA8; Mon, 30 Mar 2026 19:27:36 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 787B710450A1D; Mon, 30 Mar 2026 21:27:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898853; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ZQCvJ0TS+BQKrCcbzDTIhBi7S7lbQ8/4UUzm3mUzHd0=; b=0PHcwA9MH+BPxLX1X1X76wr4T/ZiDnYRrsgGd5aSJttwZn06EPMbR9TRdzEGTyxXvGvdAa NUKsDs2NCD6QwZzAzOYzUN9LSbv/c/WVciVEY1hHkzS5d0YNiDesYS3YsEMeVij1GcoL3E mSoHHJzbnotYkv+Vo0TwRvnKjf+9qPy0mLYKi37AlnTsgA7Pd2S4Z9Znm8bMn4CfD1cgsj lQ15GaDEBTur2T1xGQTkxCZd6n9FJ/q27uBqoA7fgyLM+UZuYU/gGYsY1LO+Ni27o419Mb 5TgvctnpmMSscCzCMhvlKhvqOvvwBVWiaqB/L5DotE0u5hbBS8nU1FEUCHyACg== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:47 +0200 Subject: [PATCH v2 06/10] drm/bridge: dw-hdmi: warn on unsupported attach combination Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-6-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 dw-hdmi can operate in two different modes, depending on the platform data as set by the driver: A. hdmi->plat_data->output_port =3D 0: the HDMI output (port@1) in device tree is not used B. hdmi->plat_data->output_port =3D 1: the HDMI output (port@1) is parsed to find the next bridge Only case B is supported when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is passed to the attach callback. Emit a warning when this is violated. Also return -EINVAL which would be returned by drm_bridge_attach() right after anyway. Reviewed-by: Liu Ying Tested-by: Martyn Welch Tested-by: Alexander Stein # TQMa8MPxL/MB= a8MPxL Signed-off-by: Luca Ceresoli Tested-by: Damon Ding (on rk3399) --- Note: Returning when the warning triggers does not change the functional behaviour of this function. It is not strictly necessary in this patch but it will have to be done anyway in the following patch. --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index 0296e110ce65..ab1a6a8783cd 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2910,6 +2910,10 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *= bridge, { struct dw_hdmi *hdmi =3D bridge->driver_private; =20 + /* DRM_BRIDGE_ATTACH_NO_CONNECTOR requires a remote-endpoint to the next = bridge */ + if (WARN_ON((flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) && !hdmi->plat_data-= >output_port)) + return -EINVAL; + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) return drm_bridge_attach(encoder, hdmi->bridge.next_bridge, bridge, flags); --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8580B39891C for ; Mon, 30 Mar 2026 19:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898872; cv=none; b=j+p7drGRJKickzo0bbGmJ0ynKJEVll37Y7lMErSdlPa4RdE5z6ydRvGdqEkfrMniJrSJ6nmqf0SYtu0PQMmW3kemyZoxZDhBQWfzHa2nMO1LS5um2euGmZdC8whuFFG8Q4UpFu8y/WXeU6zAT37MlrV7+PzIUwV4cY4v73+SSVY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898872; c=relaxed/simple; bh=JdEfXb9NrA6KhHIuMprHKeXAUoVs6GT6tDt6whZSyIA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cc2zlQRN+pnQJD6sXPiwjccqwzQfvGhs8wKSr3D+jOSYhnyWHVlcO9MYhn/XeaB8YwxdI2GdFDmq0cF6jr5+PYYRjpu9ZTI+Rf2qLglgMKZcrhI24iA50wKof1adbGzxjaDsqTPEMi7WxXUIGxRzz+lh8azJTOxUnjPsQy1qxZk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=l+5hED3E; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="l+5hED3E" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 3A7BD1A3090; Mon, 30 Mar 2026 19:27:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0B0955FFA8; Mon, 30 Mar 2026 19:27:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8DEF310450B50; Mon, 30 Mar 2026 21:27:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898864; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=lrdbrqCZ+MOt91LtVIxLd++8IerWKhbESpGKP1DQo4I=; b=l+5hED3EknXVdL+oNd73oCY+UvDuRcN5WKwjze/10Azi+AoCJn35KmensStnHixWUdHUKL u1/JJDDv0Bz1LNiXm1cIdmEwdcfAHqKeNysW7cG7eK7T9YhURoVK3koNC6qGIIA/JRLkgh OeMpvcOyp93ajzdgZe3JUxTjJBIRyHp69LUhaWySQDnXRLrA5IwZaBdraFjMoqKtfp48g5 fLKlwAfSnRKWkvfw/6NboniMzZQugJPphl/iIzGMqXzrTAxqSGJS9BgAlFjftET4dTv37a tUNR8cu9bLv/lmjy7J1CLAgOon79CWZ+md9cjv5ulGcVmWy+UM7m33+vFiVK8g== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:48 +0200 Subject: [PATCH v2 07/10] drm/bridge: dw-hdmi: move next_bridge lookup to attach time Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-7-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 This driver looks up the next_bridge at probe time and stores it in hdmi->bridge.next_bridge, but only uses the stored value when attaching, and only in the DRM_BRIDGE_ATTACH_NO_CONNECTOR case. This will be problematic with an upcoming change, adding an hdmi-connector using a device tree overlay when not present. That change is in turn necessary to migrate the i.MX LCDIF driver to the bridge-connector. The problem is that, adding the hdmi-connector via an overlay, devlink considers hdmi-connector a consumer of the dw-hdmi device, generating a chicken-egg problem: * hdmi-connector probe won't be tried until dw-hdmi is probed (devlink) * dw-hdmi probe will defer until it finds the next_bridge (the hdmi-connector wrapper bridge) In preparation for those changes, move the next_bridge lookup from probe to attach, when it is actually used. This allows dw-hdmi to probe, so that the hdmi-connector can probe as well. Also avoid storing the pointer in hdmi->bridge.next_bridge: the value is computed when needed, thus a local variable is enough. Finally, this also allows to slightly improve the code by not doing any DT lookup in the !DRM_BRIDGE_ATTACH_NO_CONNECTOR case. Tested-by: Martyn Welch Tested-by: Alexander Stein # TQMa8MPxL/MB= a8MPxL Signed-off-by: Luca Ceresoli Tested-by: Damon Ding (on rk3399) --- Changes in v2: - Fix returned error codes - Added missing cleanup.h include --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++----------------= ---- 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index ab1a6a8783cd..f4a1ebb79716 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -6,6 +6,8 @@ * Copyright (C) 2011-2013 Freescale Semiconductor, Inc. * Copyright (C) 2010, Guennadi Liakhovetski */ + +#include #include #include #include @@ -2914,9 +2916,20 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *= bridge, if (WARN_ON((flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) && !hdmi->plat_data-= >output_port)) return -EINVAL; =20 - if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) - return drm_bridge_attach(encoder, hdmi->bridge.next_bridge, - bridge, flags); + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { + struct device_node *remote __free(device_node) =3D + of_graph_get_remote_node(hdmi->dev->of_node, + hdmi->plat_data->output_port, -1); + if (!remote) + return -ENODEV; + + struct drm_bridge *next_bridge __free(drm_bridge_put) =3D + of_drm_find_and_get_bridge(remote); + if (!next_bridge) + return -EPROBE_DEFER; + + return drm_bridge_attach(encoder, next_bridge, bridge, flags); + } =20 return dw_hdmi_connector_create(hdmi); } @@ -3307,28 +3320,6 @@ static void dw_hdmi_init_hw(struct dw_hdmi *hdmi) * Probe/remove API, used from platforms based on the DRM bridge API. */ =20 -static int dw_hdmi_parse_dt(struct dw_hdmi *hdmi) -{ - struct device_node *remote; - - if (!hdmi->plat_data->output_port) - return 0; - - - remote =3D of_graph_get_remote_node(hdmi->dev->of_node, - hdmi->plat_data->output_port, - -1); - if (!remote) - return -ENODEV; - - hdmi->bridge.next_bridge =3D of_drm_find_and_get_bridge(remote); - of_node_put(remote); - if (!hdmi->bridge.next_bridge) - return -EPROBE_DEFER; - - return 0; -} - bool dw_hdmi_bus_fmt_is_420(struct dw_hdmi *hdmi) { return hdmi_bus_fmt_is_yuv420(hdmi->hdmi_data.enc_out_bus_format); @@ -3373,10 +3364,6 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device= *pdev, mutex_init(&hdmi->cec_notifier_mutex); spin_lock_init(&hdmi->audio_lock); =20 - ret =3D dw_hdmi_parse_dt(hdmi); - if (ret < 0) - return ERR_PTR(ret); - ddc_node =3D of_parse_phandle(np, "ddc-i2c-bus", 0); if (ddc_node) { hdmi->ddc =3D of_get_i2c_adapter_by_node(ddc_node); --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C60FE398916 for ; Mon, 30 Mar 2026 19:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898882; cv=none; b=ltyQgZ9q+djYDGegJ8AGNot2/Er0KUmYhliudxGizK1mxYs3Gvg8BkrCR2MYt7Lh9ZOu3ix+Br/FlTzWi7poAYY+61BnxaRkJ22dASRlxYybvoS8X7RVpWsStd+3HcIT9VaU70nkGVReTrYPcUHrvADOH0Y4Cn94CjAb13b1gV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898882; c=relaxed/simple; bh=8lLuCQ4CcN6NsOTpntXIKDy+qzK5OmGbDZxW3Sg0Avo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HEoTd7vGZf43ii44CJRuh7tfSo9DwOe+a2O17i25x3EnjZ+9fLiMP2HfPBBSvmaIZHc5YUuAYlKBIAJIVRz8qmquwpOWzW8mLfzVjjY4LTD4Zcny0VmSVk4NF7KJ4Z+TF0cdrCvk/AzPqt3CCW7juyBYAtfOsEoQoaiTa6J5JPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dzggqOYk; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dzggqOYk" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9635A1A3090; Mon, 30 Mar 2026 19:27:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 5DF545FFA8; Mon, 30 Mar 2026 19:27:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BE87210450C85; Mon, 30 Mar 2026 21:27:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898875; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=O8T964MxGFYFbkUiXwr8dehorUZYeF8EMTUnPBp/DzI=; b=dzggqOYkArba03xn7HMlX41G0CsMlq57WKi7evpTIho+Zpxbx+cP20xQuE4mHMFl0Iymub LdrTntpNjVAyJAWBjT3RobLoTUv9jVRuzKL8HUNFQeWQ1TQwSF++t9TIPGnmMg3Ts7yQHP 5hRMbHPocvYOvX228m2rBBZU2Mkgt3b6zR3GBV/90NFP4BrbOoU5T3J9QWPDncKQcN4lfJ RIhPZNHu8JRjDfixW5IOD+OaHkDNGFpm//GMuB/loVua0QToqQ3w992k1jJoykCOlDw3HS 4D8qCLNVhtJlx4OXkAk+X0QNdXaWTV6xbALpoK9PxrnUJ9vPptRbu05lHcoh3w== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:49 +0200 Subject: [PATCH v2 08/10] drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 The imx8mp-hdmi-tx is one of many drivers based on dw-hdmi. dw-hdmi in turn can operate in two different modes, depending on the platform data as set by the driver: A. hdmi->plat_data->output_port =3D 0: the HDMI output (port@1) in device tree is not used [0] B. hdmi->plat_data->output_port =3D 1: the HDMI output (port@1) is parsed to find the next bridge The imx8mp-hdmi-tx driver falls in case A. This implies next_bridge will always be NULL, and so dw_hdmi_bridge_attach() [1] will always fail if called with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. In fact case A assumes that DRM_BRIDGE_ATTACH_NO_CONNECTOR is not set and in that case it adds an HDMI Type A connector programmatically at bridge attach time. Support for DRM_BRIDGE_ATTACH_NO_CONNECTOR is implemented by dw-hdmi.c in case B. However switching to base B requires that port@1 is connected to a "next bridge" DT node, typically the HDMI connector, because dw-hdmi won't add the connector when using DRM_BRIDGE_ATTACH_NO_CONNECTOR. Many dts files for imx8mp-based boards in the kernel have such a connector described and linked to port@1, so the pipeline will be fully attached up to a display-connector and a drm_connector added by the bridge-connector. Sadly some of those dts files don't have the connector described. Adding it would solve the problem easily, but this would break existing devices which do not update the dtb when upgrading to a newer kernel. In preparation for switching to case B while preserving backward compatibility for such devices, introduce a module adding the hdmi-connector node to the live device tree at init time. This will allow the dw-hdmi code to find the next bridge (the one wrapping the hdmi-connector) and let the pipeline work as before. The module is inserted only if there is no endpoint in port@1. So boards whose device tree describe the connector will not have the device tre modified, and will start isntantiating the correct HDMI connector type as described in the device tree. For boards lacking a connector description in DT the overlay will be added, abd the HDMI connector will be Type A, which is a reasonable fallback and is what the driver is currently doing. [0] https://elixir.bootlin.com/linux/v7.0-rc1/source/drivers/gpu/drm/bridge= /synopsys/dw-hdmi.c#L3310 [1] https://elixir.bootlin.com/linux/v7.0-rc1/source/drivers/gpu/drm/bridge= /synopsys/dw-hdmi.c#L2907 Signed-off-by: Luca Ceresoli --- Changes in v2: - don't apply the overlay if the SoC is not i.MX8MP - build unconditionally, but depend on DRM_IMX_LCDIF - remove useless error check - add missing cleanup.h and init.h includes, remove unneeded includes - avoid dtc warnings on overlay - fix typo in Kconfig help text - not added the Tested-bys because the code has changed - split the 'plat_data->output_port =3D 1' line to a separate patch This patch is inspired by commit 0ff223d99147 ("drm/tilcdc: Convert legacy panel binding via DT overlay at boot time") --- drivers/gpu/drm/bridge/imx/Kconfig | 18 +++++++ drivers/gpu/drm/bridge/imx/Makefile | 2 + .../bridge/imx/imx8mp-hdmi-tx-connector-fixup.c | 53 ++++++++++++++++++= ++ .../bridge/imx/imx8mp-hdmi-tx-connector-fixup.dtso | 56 ++++++++++++++++++= ++++ 4 files changed, 129 insertions(+) diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/im= x/Kconfig index b9028a5e5a06..49f074559b00 100644 --- a/drivers/gpu/drm/bridge/imx/Kconfig +++ b/drivers/gpu/drm/bridge/imx/Kconfig @@ -18,6 +18,8 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE depends on OF depends on COMMON_CLK select DRM_DW_HDMI + select OF_OVERLAY + select DRM_DISPLAY_CONNECTOR imply DRM_IMX8MP_HDMI_PAI imply DRM_IMX8MP_HDMI_PVI imply PHY_FSL_SAMSUNG_HDMI_PHY @@ -25,6 +27,22 @@ config DRM_IMX8MP_DW_HDMI_BRIDGE Choose this to enable support for the internal HDMI encoder found on the i.MX8MP SoC. =20 +config DRM_IMX8MP_DW_HDMI_BRIDGE_CONNECTOR_FIXUP + bool + default y + depends on DRM_IMX_LCDIF + depends on DRM_IMX8MP_DW_HDMI_BRIDGE + depends on OF + help + Modifies at early boot the live device tree of boards using the + i.MX8MP fsl,imx8mp-hdmi-tx adding a hdmi-connector node linked to + the hdmi-tx. This is needed to support bridge-connector usage in + the i.MX8MP LCDIF driver. + + You need this if you use the i.MX8MP HDMI output and your board + device tree file does not have an hdmi-connector node connected + to it. + config DRM_IMX8MP_HDMI_PAI tristate "Freescale i.MX8MP HDMI PAI bridge support" depends on OF diff --git a/drivers/gpu/drm/bridge/imx/Makefile b/drivers/gpu/drm/bridge/i= mx/Makefile index 8d01fda25451..84499fe2e444 100644 --- a/drivers/gpu/drm/bridge/imx/Makefile +++ b/drivers/gpu/drm/bridge/imx/Makefile @@ -1,6 +1,8 @@ obj-$(CONFIG_DRM_IMX_LDB_HELPER) +=3D imx-ldb-helper.o obj-$(CONFIG_DRM_IMX_LEGACY_BRIDGE) +=3D imx-legacy-bridge.o obj-$(CONFIG_DRM_IMX8MP_DW_HDMI_BRIDGE) +=3D imx8mp-hdmi-tx.o +obj-$(CONFIG_DRM_IMX8MP_DW_HDMI_BRIDGE_CONNECTOR_FIXUP) +=3D imx8mp-hdmi-t= x-connector-fixup.o \ + imx8mp-hdmi-tx-connector-fixup.dtbo.o obj-$(CONFIG_DRM_IMX8MP_HDMI_PAI) +=3D imx8mp-hdmi-pai.o obj-$(CONFIG_DRM_IMX8MP_HDMI_PVI) +=3D imx8mp-hdmi-pvi.o obj-$(CONFIG_DRM_IMX8QM_LDB) +=3D imx8qm-ldb.o diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c b/= drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c new file mode 100644 index 000000000000..4c0a22bf416b --- /dev/null +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.c @@ -0,0 +1,53 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Add an hdmi-connector node to boards using the imx8mp hdmi_tx which + * don't have one. This is needed for the i.MX LCDIF to work with + * DRM_BRIDGE_ATTACH_NO_CONNECTOR. + * + * Copyright (C) 2026 GE HealthCare + * Author: Luca Ceresoli + */ + +#include +#include +#include + +/* Embedded dtbo symbols created by cmd_wrap_S_dtb in scripts/Makefile.dtb= s */ +extern char __dtbo_imx8mp_hdmi_tx_connector_fixup_begin[]; +extern char __dtbo_imx8mp_hdmi_tx_connector_fixup_end[]; + +static int __init imx8mp_hdmi_tx_connector_fixup_init(void) +{ + struct device_node *soc __free(device_node) =3D NULL; + struct device_node *hdmi_tx __free(device_node) =3D NULL; + struct device_node *endpoint __free(device_node) =3D NULL; + struct device_node *hdmi_conn __free(device_node) =3D NULL; + void *dtbo_start; + u32 dtbo_size; + int ovcs_id; + + soc =3D of_find_node_by_path("/soc@0"); + if (!soc) + return 0; + + /* This applies to i.MX8MP only, do nothing on other systems */ + if (!of_device_is_compatible(soc, "fsl,imx8mp-soc")) + return 0; + + hdmi_tx =3D of_find_node_by_path("/soc@0/bus@32c00000/hdmi@32fd8000"); + if (!of_device_is_available(hdmi_tx)) + return 0; + + /* If endpoint exists, assume an hdmi-connector exists already */ + endpoint =3D of_find_node_by_path("/soc@0/bus@32c00000/hdmi@32fd8000/port= s/port@1/endpoint"); + if (endpoint) + return 0; + + dtbo_start =3D __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; + dtbo_size =3D __dtbo_imx8mp_hdmi_tx_connector_fixup_end - + __dtbo_imx8mp_hdmi_tx_connector_fixup_begin; + + return of_overlay_fdt_apply(dtbo_start, dtbo_size, &ovcs_id, NULL); +} + +subsys_initcall(imx8mp_hdmi_tx_connector_fixup_init); diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.dtso= b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.dtso new file mode 100644 index 000000000000..5dbe06d5ffe7 --- /dev/null +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx-connector-fixup.dtso @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * DTS overlay adding an hdmi-connector node to boards using the imx8mp hd= mi_tx + * + * Copyright (C) 2026 GE HealthCare + * Author: Luca Ceresoli + */ + +/dts-v1/; +/plugin/; + +&{/} { + #address-cells =3D <2>; + #size-cells =3D <2>; + + fixup-hdmi-connector { + compatible =3D "hdmi-connector"; + label =3D "HDMI"; + type =3D "a"; + + port { + fixup_hdmi_connector_in: endpoint { + remote-endpoint =3D <&hdmi_tx_out>; + }; + }; + }; + + soc@0 { + #address-cells =3D <1>; + #size-cells =3D <1>; + ranges =3D <0x0 0x0 0x0 0x3e000000>; + + bus@32c00000 { + reg =3D <0x32c00000 0x400000>; + #address-cells =3D <1>; + #size-cells =3D <1>; + + hdmi@32fd8000 { + reg =3D <0x32fd8000 0x7eff>; + + ports { + #address-cells =3D <1>; + #size-cells =3D <0>; + + port@1 { + reg =3D <1>; + + hdmi_tx_out: endpoint { + remote-endpoint =3D <&fixup_hdmi_connector_in>; + }; + }; + }; + }; + }; + }; +}; --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996A6398905 for ; Mon, 30 Mar 2026 19:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898893; cv=none; b=o6GVqiQ1Bo9GVzn1EbFy2PuXryPI0Ooa/HlGP8+hWtXCR9B/98evX/6PKSF1b9QgiyJ+Vu7i9OTMfHBgXobftstBJkdrM4dGxek8ZpAL0KFEtSJmUOw5BhRn6kZilKbOUtT0KckVPJltTKXD2J97d3vReMaHRipPfkItdRxnAho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898893; c=relaxed/simple; bh=YA5rkGo59cGVShbUciTlqGvq35SibmD2JQtM1yqO7O4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nrRfIpCGtULj48pAxE6MYMnOhC6gKHJx4FYTsk9/eCdtyb1N6qoOD97O1bZJzJzOJKhp9oXtAE+Gjn98POCvYWxdrBAloYrv+RLb4PAxHCOIyn9/pFzXYN3aKjj0PE+LDZWfb93R5U2BPGUqSmzQaXVDNBsA0f+yRkH2UD7MEpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BYrE+kPC; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BYrE+kPC" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 4C1561A3090; Mon, 30 Mar 2026 19:28:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 14DD65FFA8; Mon, 30 Mar 2026 19:28:11 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D2CFD10450CE2; Mon, 30 Mar 2026 21:27:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898888; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=n1k86Zo5Z3Wbr084UKzF99BGuv5mRcxWHfMNaWnksg8=; b=BYrE+kPCb79aNu4Gu6E2PHtB282FFnegJZdAetcKXH+TyauxVCZW1E+I8h/LIBaNEWOIqS 5vWSVqjkupG1iyeDCpyx8/UkVeE/dbN8t/ypRyFRTGT1th1EhQckElzuSDbXbfcjDbb1+B nVLYkYeulzH6JgFNMhf2873zIAaFlcuWI1WJSRk4FrhYvVlEy607d2QSafHZe48dJ/7Hvl Q4UeJZstu5+lKcS4GB09ZVmd/xfOUW8augQdkzvDuP1K5Tbw4oqlSfZM+Lmr7QzrcWlCIp xoBHF8W1SEdriIxZajVgVdjCn5p1jcZnxeIGB8XIEN0VsKqu3kKVBoczKlKXTA== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:50 +0200 Subject: [PATCH v2 09/10] drm/bridge: imx8mp-hdmi-tx: switch to DRM_BRIDGE_ATTACH_NO_CONNECTOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-9-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 The imx8mp-hdmi-tx one of many drivers based on dw-hdmi. dw-hdmi in turn can operate in two different modes, depending on the platform data as set by the driver: A. hdmi->plat_data->output_port =3D 0: the HDMI output (port@1) in device tree is not used [0] B. hdmi->plat_data->output_port =3D 1: the HDMI output (port@1) is parsed to find the next bridge The imx8mp-hdmi-tx driver falls in case A. Switching to case B, which is the current best practice, requires that the HDMI connector is always described in the live device tree, and a previous commit ensured this is always the case by adding an overlay in case the device tree does not comply. So now we can simply switch to the new mode and support DRM_BRIDGE_ATTACH_NO_CONNECTOR. Signed-off-by: Luca Ceresoli --- Changes in v2: - new patch, split out of the previous patch --- drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c b/drivers/gpu/drm/= bridge/imx/imx8mp-hdmi-tx.c index 32fd3554e267..8e8cfd66f23b 100644 --- a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c +++ b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-tx.c @@ -138,6 +138,7 @@ static int imx8mp_dw_hdmi_probe(struct platform_device = *pdev) plat_data->phy_name =3D "SAMSUNG HDMI TX PHY"; plat_data->priv_data =3D hdmi; plat_data->phy_force_vendor =3D true; + plat_data->output_port =3D 1; =20 platform_set_drvdata(pdev, hdmi); =20 --=20 2.53.0 From nobody Wed Apr 1 09:45:44 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 696AE3988FD; Mon, 30 Mar 2026 19:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898903; cv=none; b=Jdal16v4wm4f+R5eAOHNGTeT4p8/KvJ4fhxFMdvpdaFfnCUkWKI3WyMiIC71VQ4aBrCL2vYZWC0yVCGpzb0fHwcE3JmlSDHumqnmLuNahCcQ6TUZDH+d58GY9KXCfYmzaUWvwT9VYVnosaI5xGkUcqqqs3Ha+Y+fgyP810DIhVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774898903; c=relaxed/simple; bh=k4oECNgcgBffSrqVG/1BTCiLFKfxRRx2KgQM/Onrk2c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cCWM96OlWgvRmyYE/LscjCXWOeAkxthk2+qt0J9hrNJ3kOT5+H4I2MK1kNUbson5IxveDNnK0NpQw04MrEHG7TBa2wluX5JONYpTFliSR0wVx4CiwDi80Cqps59JNbRRbB+dRFvmx9u5gl9T1dBY8YEhFRrzrBvxOu/8yBAf2Gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=oUJWw+sn; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oUJWw+sn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 6286DC4042D; Mon, 30 Mar 2026 19:28:51 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2B5685FFA8; Mon, 30 Mar 2026 19:28:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D985E10450A1D; Mon, 30 Mar 2026 21:28:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1774898898; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=RWUsNAX4qkcAdj0Wcj9Oo2se6gzwrm1zu3SjMpebEPg=; b=oUJWw+snQiJK02OPuQbuHCk6voqfaJP4n5+P7ls65RFfDHnsX2qLyzuuWtQtOZpB2d8Ju2 /Ql5QOLjabiVDAJsEshL8Rx1jn0a9fEKfk558xZkRHYFjnmqluA6pP7pTYbvRByv/7KgPF qPPd2c2Aptn8+8W2XDOalCkM5rLwHIFbLkHHMZQq066fyk2yZ6aREg12OPszPsII5wkk/c 3ZKS4bQiXN0ix65glAXmXA4TlR1ZKO4pn3beZ17TMH3k7qCbSNdZZKqprWad0MTHo4Kdkm cCuXPz6SezX9ubQncm6HLiFQKMQK6wMfkfN/F/sHH/aJrnaM0jDU02rO0RlELA== From: Luca Ceresoli Date: Mon, 30 Mar 2026 21:25:51 +0200 Subject: [PATCH v2 10/10] drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-drm-lcdif-dbanc-v2-10-c7f2af536a24@bootlin.com> References: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 Convert this driver to DRM_BRIDGE_ATTACH_NO_CONNECTOR and to the drm_bridge_connector framework which is the current DRM bridge best practice. Tested-by: Martyn Welch Tested-by: Alexander Stein # TQMa8MPxL/MB= a8MPxL Signed-off-by: Luca Ceresoli --- Changes in v2: - Added missing select DRM_DISPLAY_HELPER in Kconfig - Rebased on previous patch changes --- drivers/gpu/drm/mxsfb/Kconfig | 2 ++ drivers/gpu/drm/mxsfb/lcdif_drv.c | 16 +++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig index 264e74f45554..31db7a824a93 100644 --- a/drivers/gpu/drm/mxsfb/Kconfig +++ b/drivers/gpu/drm/mxsfb/Kconfig @@ -33,6 +33,8 @@ config DRM_IMX_LCDIF select DRM_GEM_DMA_HELPER select DRM_PANEL select DRM_PANEL_BRIDGE + select DRM_DISPLAY_HELPER + select DRM_BRIDGE_CONNECTOR help Choose this option if you have an LCDIFv3 LCD controller. Those devices are found in various i.MX SoC (i.MX8MP, diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index c8ba8f9b1da8..7f07ae24e0dc 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -57,6 +58,7 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *= lcdif) struct of_endpoint of_ep; struct drm_bridge *bridge; struct drm_encoder *encoder; + struct drm_connector *connector; int ret; =20 if (!of_device_is_available(remote)) @@ -86,11 +88,23 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) "Failed to initialize encoder for endpoint%u\n", of_ep.id); =20 - ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); + ret =3D drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CO= NNECTOR); if (ret) return dev_err_probe(dev, ret, "Failed to attach bridge for endpoint%u\n", of_ep.id); + + connector =3D drm_bridge_connector_init(lcdif->drm, encoder); + if (IS_ERR(connector)) + return dev_err_probe(dev, PTR_ERR(connector), + "Failed to init bridge_connector for endpoint%u\n", + of_ep.id); + + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) + return dev_err_probe(dev, ret, + "Failed to attach connector for endpoint%u\n", + of_ep.id); } =20 return 0; --=20 2.53.0