From nobody Thu Apr 2 06:15:12 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8960B2E8B64 for ; Mon, 30 Mar 2026 14:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774881182; cv=none; b=IXmi2iNv7GVNNyTpFQ3SqHopxDedjQert0+r5LEFdca08pTAWYye3qvPv618AzeD+0D6wJPerP/2HJLH/ajUNUhGYt4H9R1qq0oAdsJ0nd1n7lw5LR5vz3a6bpejSVEwORLtjivcnYIeIbhMFq4fw4Z2/NNBWAxiDuw9En1oX2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774881182; c=relaxed/simple; bh=aExlSSaLla1nCjUvgyoARQzBD88LhnGckG7GUkW3GbE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qM10nqtq/LyxovPE8A3MJyoHWvPG0JP2o0GKxD+KMZoEyIXRG/J7eLNYZ9RWwM1GOOv0HZDnWbQh2a1kmDAjc/Ajl9DVu7cFy17H2fuTGIEgSnN++mTvI3htVmsHamP2oFtSTHcPMraoiPwXaPHJchhr13Q7sM/06RKVUyU/Ung= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=axh2dPJv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=pAtN/qUO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="axh2dPJv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="pAtN/qUO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774881180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewVCMiY2A8SH+vVFiby43Oli8Pss41RewLglHBz7dlw=; b=axh2dPJvy2Tv2tBWr8tkyOUpn2VL6msVZoDI2hr1Xzbi/W+RAIzdDJzWA2M6WpVRNt5NfK 3jr2SGpV/eii7XT4SiFDEVQ/NB+pXfYhIZNKYpOSadYOeBn33KdvfeFECof+DPgqc8S2SS Pl7FTIpzj+h3ZbjgRomi6cMCHzFrqFw= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-wH5DIc6VNXay9HaKcNAy4g-1; Mon, 30 Mar 2026 10:32:59 -0400 X-MC-Unique: wH5DIc6VNXay9HaKcNAy4g-1 X-Mimecast-MFC-AGG-ID: wH5DIc6VNXay9HaKcNAy4g_1774881179 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-5093787e2fdso227848521cf.2 for ; Mon, 30 Mar 2026 07:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774881179; x=1775485979; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=ewVCMiY2A8SH+vVFiby43Oli8Pss41RewLglHBz7dlw=; b=pAtN/qUO35xtM2DyxJR3bfESxxTV4588FZo57r6Bg7scehwNiRePAUjyEUsfUX13Gw K/Z8aIvg8QTSQ/Za+QRJAb/wMheRR/zdi2pYrFEKHwWUfkaTDJmE76tnH/190uX6JpRa mduO6Vyvnm16pRe/ZuyCvV+gtFAcZgJsmCDe4dAAsYe2fXppsnm8SilMNel+4eoMQ/ss VXqxdLxfQakUpSh37KCcZAj88KlcuM9iQELEeFQ+SXt7q4DkDmre638yHva2dhcfibVs s952RUyyIwGl+192EaAupE3vrQA0Gd/RXBJ0yuKjcOd6q3jG5S3ekHA83xzrd3cineMR pAtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774881179; x=1775485979; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ewVCMiY2A8SH+vVFiby43Oli8Pss41RewLglHBz7dlw=; b=FMKKrbM1wVsC+EeLpaaIhZa6zRBNZkQ0JUqYPBZjrvbQRNpNw3swuIDLyko8vYt+PA 8g+xExxHOYmSV8pzPqZsrjSsT+3V9XY2AR/eFz7Imm10Z+YCIqHwjgcBbldtCGDtkDR+ 9jIMHH/gsadhT3bRntjeWECG74+G/zRI+s6lLzOxMiJck8l1JvYOwTQucXGwi8AN9j8U mlW47jl5XIOPlvxLYCJ/4TIXejAvG24KscgXVrmregteaNag+Y07TkwlLZfsN8IDyJZQ kHom8Qh1WrtNHx8spJ1wPQcEwu1byN/OxLJwJn6hPDMqL2hKG8yYc9r+eRerTuiw+vMR mqzQ== X-Forwarded-Encrypted: i=1; AJvYcCVQz9hOjE6YnKGtSvNBVgKp4o2EMn7KtcMI2cUz/PR+YGRZ6nKkC6W6tfmRVdKOeamVThNYvOAZpnikW+0=@vger.kernel.org X-Gm-Message-State: AOJu0YzlI+aQ96CcghdCaSsRyj74gdcF0LrshPJCe/UpCWmZBpYf2QVA jJ843gSOmMBD2uv7vZk1pixh88TQFP9R4NEgP7DBI+JbVus+VCaz07mUfAvueoyRNlQZOPI67Ig 2XvQFq0PitKpQIlc52xXkbaYPCwfhIAXJAKwZ4R4Wz2o34vYv3XrwrvFoGvwVLHrp0A== X-Gm-Gg: ATEYQzy0T6wbWO+3kRj8EXXn+dYaqb0PvpNDPT0vx2SkS3ATpvW5O+6bj5PHS0+nKW7 n7j3R2btsaMb/S7fzARbbwYOQEGJwM+eSm7Ixh0rYmdlpy6ZsExwJEvq25DMkYzcZBE9e9FvWx1 2g1VmVFGo3DKo6KNhawrDzN2aLFy8P8m3UxdsSW5RmQdFrKXPTrakOFyC6uK0B+OHOluleEtUS8 p1xahcOCufzyOXFfiNwfpkmlhN01jBApEbRjzQ0xXc8XS9VhBkwL+nLzkGzN7SqeTxlQGUHww1X EYRjPF7AT/H6BvIQmL1vGf7xkVOVyqKXHE9HgatIxP92xlgb5DOSftb56+pBpYX/L38ZQq3e1f9 XuOsPYm+mbMz+CJrJyhxFocvJk9XNMXwjtt8n1kLzW3tUr9ra3B4CWyPspJsN X-Received: by 2002:a05:622a:514c:b0:509:a9b:8a6f with SMTP id d75a77b69052e-50ba391e18amr186074511cf.56.1774881178541; Mon, 30 Mar 2026 07:32:58 -0700 (PDT) X-Received: by 2002:a05:622a:514c:b0:509:a9b:8a6f with SMTP id d75a77b69052e-50ba391e18amr186073831cf.56.1774881177981; Mon, 30 Mar 2026 07:32:57 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50bbcbb3babsm52494131cf.25.2026.03.30.07.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 07:32:57 -0700 (PDT) From: Brian Masney Date: Mon, 30 Mar 2026 10:32:37 -0400 Subject: [PATCH] clk: visconti: pll: initialize clk_init_data to zero Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260330-clk-visconti-init-v1-1-ac3e825e54b5@redhat.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MWwqAIBAAryL73YIW2eMq0YfYWkuhoRGBdPekz 4GZyZAoMiUYRYZINycOvoCqBNjN+JWQl8JQy1rLppFojx2LZoO/GNnzhW3vDA2mI20UlO6M5Pj 5n9P8vh/E/7fCYwAAAA== X-Change-ID: 20260330-clk-visconti-init-58fae9a7e6a1 To: Michael Turquette , Stephen Boyd , Nobuhiro Iwamatsu , Rosen Penev Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1700; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=aExlSSaLla1nCjUvgyoARQzBD88LhnGckG7GUkW3GbE=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDJPdU7dYna2I6bszrPXbBPlgqZnHgneIfFJ/71uQoJu9 ZayR9fYO0pZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZgIhwjD//SgFqGa+ybWqjvl U8+EOqpHJecZ/WJqf5LYfVXZyvjEfob/aUKVHZV8+y7cW/HZRPJi+5+C7T8/X5yoVZdj3LJXafI 8dgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Sashiko reported the following: > The struct clk_init_data init is declared on the stack without being > fully zero-initialized. While fields like name, flags, parent_names, > num_parents, and ops are explicitly assigned, the parent_data and > parent_hws fields are left containing stack garbage. clk_core_populate_parent_map() currently prefers the parent names over the parent data and hws, so this isn't a problem at the moment. If that ordering ever changed in the future, then this could lead to some unexpected crashes. Let's just go ahead and make sure that the struct clk_init_data is initialized to zero as a good practice. Fixes: b4cbe606dc367 ("clk: visconti: Add support common clock driver and r= eset driver") Link: https://sashiko.dev/#/patchset/20260326042317.122536-1-rosenp%40gmail= .com Signed-off-by: Brian Masney Reviewed-by: Beno=C3=AEt Monin --- drivers/clk/visconti/pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index 6fd02c4b641ed58f1943e55dd60ae80aba30b902..805b95481281761ad7ea4f59dda= c07e4cdfb9d42 100644 --- a/drivers/clk/visconti/pll.c +++ b/drivers/clk/visconti/pll.c @@ -249,7 +249,7 @@ static struct clk_hw *visconti_register_pll(struct visc= onti_pll_provider *ctx, const struct visconti_pll_rate_table *rate_table, spinlock_t *lock) { - struct clk_init_data init; + struct clk_init_data init =3D {}; struct visconti_pll *pll; struct clk_hw *pll_hw_clk; size_t len; --- base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 change-id: 20260330-clk-visconti-init-58fae9a7e6a1 Best regards, --=20 Brian Masney