From nobody Thu Apr 2 13:32:40 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92749244684 for ; Sun, 29 Mar 2026 19:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811043; cv=none; b=WwXdr9RCcX11Rcg3tghSCNJeQ/s74mn9L6d/Zl08GOPSRJRMfY3HIpzMPihSDbLY1RR9YFLqM/bxTCgimjBeaR/imggzwOMzfL/FtoLWVoNy39+p248m5t2vxhb+sC5DjvXDvWrH8D7t+dCyGoy+PwjT5wF+a2/dg+FiYyvcgWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774811043; c=relaxed/simple; bh=70pqPdPbl7uQp20iWj8a4rOSRU/Egok3eSzupS/bzfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kogYjeetfqZGRRnfv9r4hXUrWDMrCt7RKPB4jemHxJIfhvbzUnilkwj5tiA4pzKdCldt0qTvNYM9ozcS0PZ0TRd7T3cbo+cYtsKXZWT5cstq4dcbEZvJVg9gXfBiU0OJ9CFdVBdgxNOzCe2hXDnxedlgja+MIItyZW5se/u4Hew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TH4q9LzE; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TH4q9LzE" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82a646c96bdso3090804b3a.2 for ; Sun, 29 Mar 2026 12:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774811041; x=1775415841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+mU/h+l86Dxfj+U7yKBkezYMTKfac40N2oWD7yA0Gpk=; b=TH4q9LzE0klnG22PCBXOp3Zx5pzMHYShhLuAit3bUOR/0fwIReGIKcGfks7mrqlVJ8 KKFUHyTFRcOW9lxQrJneS7ySRuNGLXUzgnJaFYJbysE6S/zcmUidQ4fH4oOrHvcFodpp OC3Ityh30QM4AtwDyEQa7QDWXZbJil9xcuscOS/pgxxI2yIlET1OOi35WhPIJqDg9xIG TOzjBixuDo8x9u9BOKxrGL60snxUrPW06ap1b4740zSbvA2McO748doTHpAEss9hlvsL y+F+YsLeCprj+qLy0mkIF1+tvf0vDakoZpZnI/1hAUADW1Eu/O0UOdBEypUIPcnTOH5K nf5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774811041; x=1775415841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+mU/h+l86Dxfj+U7yKBkezYMTKfac40N2oWD7yA0Gpk=; b=fr68rtOGIHR1vMf06eUHF78BKr/AtXRF5WNcJ7GubmdalAia+dZMQwo3b97Q+zA5rB cBIieJSdp0CgRHrLM2KJi6MnOXc48J7FT2i4RGOOcAJDfKg9x9g2tt6rRQUslip5Jhzh 1Yx/AlDuIpjetg+I+d6jC8N7h6JnHo5j1G3Pov27Qrv8JYtBZZejR3hFq6DmOssmCoKD Kzii7ukTRcRoIiQy6ZGyUKfHAV2vasi5zmQv1qTI3vG6qo4wPzzZNFLQDrV04Qb1TXai HaAYTkfjyzxHSr5anZkOyXoMhNRZ3tYMZVLTLj6ksJyliorz6xFyOchDBc61scUo1iSW 5mfQ== X-Forwarded-Encrypted: i=1; AJvYcCUDcc1k99ObD0vJuDSrBJ6UyWtS+QsT7A95pPhe7qELdt515Zy4twh+s/oVBeF7KBvugJ20n2z2hQ3i6jg=@vger.kernel.org X-Gm-Message-State: AOJu0YxKT5U8QmMfda0rkP1sweCjNbtdsyIsoW5gA1jxR9q5680eewGM kMX2luhsYTlg23mblYQ/CPxys1QffcV2oCVHMlTtA0vvVMzl6hJ2HwGYeedLqDVsAtpF5Q== X-Gm-Gg: ATEYQzxjYpzBfOVhVONBdwsjOc6csPR0kE+7OB/vChSdBZwHoorNxC5tybuZg59uFn2 M7x1FU+YWLFjPUcy8cNXFOhs2l0DlzX5vwDUQ1gZA7op+PUxO8kb+tNvUeDcV6MA7lQOU9KrfCx HIskRXCVmqGGjBWVsu0K3ZlZ6nhQURE6Li08tarGBuwViXb4zsnlfqXO+4eLSapYUft/2mOgHPQ MH8xab9aq4ahlJYOiVhq+9PWTan6C68PtCHy+noJMjz5dQl/b4IMNyRtg+8UKeR+RTh+tTMBpwI A4/NObPZvI7A91iS0QdfJETSuP4TXrsZ00LswRtSvo+jFVd0rRZmavkzaX/MofqXamcSzFxa8Ex 3hwWs4T6ArDK158nMpvWht77V5Db0l8dDkUToJs8qwYriTYBccbAUflrBAheS5G6n1FtVSShUcG vmviOeklPfzzpoDIkCRA== X-Received: by 2002:a05:6a00:1acb:b0:829:bd4d:3817 with SMTP id d2e1a72fcca58-82c95ed4749mr9205453b3a.28.1774811040776; Sun, 29 Mar 2026 12:04:00 -0700 (PDT) Received: from kfuzz ([202.120.234.33]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca843b818sm5866178b3a.6.2026.03.29.12.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 12:04:00 -0700 (PDT) From: Kangzheng Gu To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, kees@kernel.org, thorsten.blum@linux.dev, arnd@arndb.de, sjur.brandeland@stericsson.com, xiaoguai0992@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3] net: caif: fix stack out-of-bounds write in cfctrl_link_setup() Date: Sun, 29 Mar 2026 19:03:50 +0000 Message-ID: <20260329190350.19065-1-xiaoguai0992@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" cfctrl_link_setup() copies the RFM volume name from a received control packet into linkparam.u.rfm.volume until a '\0' is found. A malformed packet can omit the terminator and make the copy run past the 20-byte stack buffer. Stop copying once the buffer is full and mark the frame as failed by setting CFCTRL_ERR_BIT so the link setup is rejected. Fixes: b482cd2053e3 ("net-caif: add CAIF core protocol stack") Cc: stable@vger.kernel.org Signed-off-by: Kangzheng Gu --- v3: - remove the Reported-by. - print a warn message and reject link setup by setting CFCTRL_ERR_BIT. net/caif/cfctrl.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/caif/cfctrl.c b/net/caif/cfctrl.c index c6cc2bfed65d..373ab1dc67a7 100644 --- a/net/caif/cfctrl.c +++ b/net/caif/cfctrl.c @@ -416,8 +416,16 @@ static int cfctrl_link_setup(struct cfctrl *cfctrl, st= ruct cfpkt *pkt, u8 cmdrsp cp =3D (u8 *) linkparam.u.rfm.volume; for (tmp =3D cfpkt_extr_head_u8(pkt); cfpkt_more(pkt) && tmp !=3D '\0'; - tmp =3D cfpkt_extr_head_u8(pkt)) + tmp =3D cfpkt_extr_head_u8(pkt)) { + if (cp >=3D (u8 *)linkparam.u.rfm.volume + + sizeof(linkparam.u.rfm.volume) - 1) { + pr_warn("Request reject, volume name length exceeds %lu\n", + sizeof(linkparam.u.rfm.volume)); + cmdrsp |=3D CFCTRL_ERR_BIT; + break; + } *cp++ =3D tmp; + } *cp =3D '\0'; =20 if (CFCTRL_ERR_BIT & cmdrsp) --=20 2.50.1