From nobody Thu Apr 2 09:18:47 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B222279DCC; Sun, 29 Mar 2026 17:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; cv=fail; b=jrvmHyf7mw7bqRJ2gScsVMGCZa2hQn14Ayh4NPIV1AI2wVObURBbEn/lEtrlVa+BwCK1Z/Cj1cftlSD8ko0u0SnkBN/4JsLvWsCb4H/LkoSwZ7Mp6qRl1j7i0LQfSe4DbTuyLNWk66+jkjbRiy07h8X7OUwl6MMbAryuJSrzHYA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; c=relaxed/simple; bh=gP+lk+hI0t4p6rJuenp8mSzmbATRgoTv+BXA7oOKPLM=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=lT25J9KvqQNAC4G8VdYiOOsCAY78U1epOQ7Jay0BG3DiNsR4C39Pzg7pQnsqja0I4zv5IBOUdMwCU1mxGM7MV6dUmrSVcQeicVE8Cno2UPJx852n9n7oUBFbzbcy7L1KtFyThAfc9M2Q4QsOi7A1WSWNbQB29kAHH8n4n9TElI8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=aBiqOInI; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="aBiqOInI" Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62T3XPxP2073616; Sun, 29 Mar 2026 17:09:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=NR VesDss7pcr/oeL5yqqB9RfBgnpVs5T+zfAgJQMIOU=; b=aBiqOInIw4TC7H/ONP r5h0pROXRVOXislYo9MJxIaca8Gwg5szhH4GhDUl4s24+nUHRSPSU1PXDKAaiBOQ G9E3F72mgRj6lv7ULC5BLnbhDneRtbkJF7OFt9pi9bMBkH9EkpqO9XVkeqV5M7fS i/qRziiSy8+Wxuyw7rQ0vpzqXVLMWRYbLn8bMnhnv5bYJJD74cbmMoSP5wtyThjr vuQdAg7fM6f+FbT/dMexl5BQZP15iZ5bweiXRpZDz/qKf8Vuu/gIjimbPFWMeeLU 57M7C50N9yhhDeIg2OXGz0Q5AvxVVx4sPzdEB7bjYcH9phXt01DaTnXb/VQlOdDM XVXw== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d6v993vyp-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 17:09:59 +0000 (GMT) Received: from p1wg14924.americas.hpqcorp.net (unknown [10.119.18.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id 1F5B5D281; Sun, 29 Mar 2026 17:09:58 +0000 (UTC) Received: from p1wg14923.americas.hpqcorp.net (10.119.18.111) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:57 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Sun, 29 Mar 2026 05:09:57 -1200 Received: from DM2PR04CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:57 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OlImsQnvCoEtf5iBPWq0ZdWKwQC86fHeodTYY4evzqP3voMM4A52FzJuCK0Sk5qOhJ0P/TeZa/4IL4NYuHyEtJ5F60/xO3P3lO0e+vqid+eBTLoTVO+usGkllz1Jt8fT2djaGrDTH5clGfCKdAKZdtdLobsI/vn8LSQ9t0IlWMkGBDVK6nATpbh+91tT/9QuNTY73QJtVgyJaiIG4vgppUI5bc5UMfPm2HgG6TkOd524cxyrgq6xtstOXonrdhWT8SYJNQ4h3mWx0ZlIrwpss2fd7IRQPhzMYW4EEGIsWTpdh/qS84yZM3e5CNPMU1XyY4iZOVTOpL+6EkeCUWrDsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NRVesDss7pcr/oeL5yqqB9RfBgnpVs5T+zfAgJQMIOU=; b=d5NK00oGjUiv71ETJyJqB9Mkn9i4eoNrZJ+WMPp44N9kkbflrF4l9qgcNK/e31SnRxBj0c5Ok7K59BXaUB/tfZKX5qKG6AzLnCX7kRWR71dkcFxlaEZcgI+iLX9dT39JMsGl986uHJst6bPt3idOzJ2yjCSg2iAR3KBDub2pOAJTgxs1ecZ3TIqd4E28RKrry2p3MZc0lblZ3nuE26saIav4FrH/XX0EK9Km0zNHUrfnAqgeY5HRR1v0FLqhuvuP/0LwWQqYn5WlDefNMOQM12APDP7MwMjuB/mev/z0fug8OtM6CUJHu84eSnAyhYzhY/BaoImhQyhdgRDODaFSZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by SJ0PR84MB1992.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.27; Sun, 29 Mar 2026 17:09:40 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9745.027; Sun, 29 Mar 2026 17:09:40 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: [PATCH 1/4] hwmon: (tps53679) Fix array access with zero-length block read Thread-Topic: [PATCH 1/4] hwmon: (tps53679) Fix array access with zero-length block read Thread-Index: AQHcv57Utu8gXvMxhUyzn+KwqJdXeA== Date: Sun, 29 Mar 2026 17:09:40 +0000 Message-ID: <20260329170925.34581-2-sanman.pradhan@hpe.com> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> In-Reply-To: <20260329170925.34581-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|SJ0PR84MB1992:EE_ x-ms-office365-filtering-correlation-id: 5e8d5c0a-67ae-4168-784a-08de8db5f6b8 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|56012099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: sJOQHMy2UVD3XZ7slc519ga58zphNut7bThVIlFqt5x7mT48oI4E/zaF9rb53E/UbdFsuhQob3oEe49jnAZxyGqmlMHjZ104cLfD9VhvU9yUd+ODGbe/vbTPFYSE7/cx0BKeBML+r6n+eL3Kd5scJgQSMQsQhyl9+1m+rfLQkXlvEjW7+8z10YxhXdg1kHYrhR6qQ+zeS9dhV1mpbQ7D0uHw9Mat3M0KU+ImZzRSgqdrXwUF/JwB2rTG6at+TYEBRx+0ykeCrp4vNiHQf76grfsyNk586VtAn+GEQNWBc4mZ7Wfcgru6MFU+mqf0OhkUOH6jPgl+ywpxT9EVnx/3WmxbqbVeWHkYWdyT+w69TocQkY4NvP9lg7/9SnemZ4LwryKLgPZ46VJRCq43ipJgyapKJtNzj/pnLXrbNLZDZJche3d3OL9o1slrR219qdRjyhU5OSwSxReS1TxWSeOUQvvlbb4udmxUo/30bTsiXB6C5ThRGhtOcRFqXnoWGpQuW6MWmgNjbhVg2eIMBgbphjmh9oJ/B2WB9T32tSjmf2eP/swOKFiQFpOFtOT4lA+piMC34wqkh25X9LSpE6yrRWn+AcaOtEcdhTGoNfne6S5AQLmPGVsO10fXlxC8Qfg6DbPi3+J/6b3A8XJw4b+NjnoVPd3aGU2QIIeVLM4x1PTS6ym/OssogcpsXSmAyxbpa7U2lM8zLVDqqRN0sPY06HurrFzo24tNGDo2krHDVA/OiRavjHm04nsE+eJp9jT5NCZTXvEFwEl92lwZYtleguaZcGzG+lNrC6CN3OjCvuk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?J39B9W32gRI2SGEP0Dz8PfLUbTyAv2ZQx5W10Aj5vRMOHTSDbXY+/5HLpv?= =?iso-8859-1?Q?arZRkQ6/zF0RI1kb5gABE2iK83O+uYqADRwcjxjdB1y94BKfIlSlK7EnR5?= =?iso-8859-1?Q?a3J0mL+uVztYhNkV6BI+OJhFNfSbdufV1eA72/DysT8y3vrklphGclWW84?= =?iso-8859-1?Q?lVx62Fz1PBxeZxEgG85hvnc9/PlaTxB8dKqbmQs3iBtqmbk4J73ZIxoSzB?= =?iso-8859-1?Q?GozPKrmQ1XxgsaDaFvChR7wBWY+lhcih6FJQTPBseLDN5hyCiYAqpZxFI5?= =?iso-8859-1?Q?d7xFYYddnsJEC6MVNSCvdb/3b6TAgmbgDARqciWBN4ImNeOxWzsLAzIaTX?= =?iso-8859-1?Q?0aLZaY6TY4LATDEtWa1E6PglE66K7Boznf2WMADHZp+LwqknaEu9712Xn/?= =?iso-8859-1?Q?PfzbfPWkxklQBCXBi1n4CgrmOnMgznbnZItn+edK55ro10Uq/b6EzJPx1k?= =?iso-8859-1?Q?QezcKQylTYJOUhwLfj3XFJ2LPe2+8C1qK05FO2FWAbskQ2V/kNFq7ZPH4s?= =?iso-8859-1?Q?M5iib0AXCnKODG0hEJOKOsidjzKWt3JwrIPYnXu66JnqEoiEVxzFoqy+zt?= =?iso-8859-1?Q?cEL1nvs1xeRZ4TGyRTLiGFnAYkutIDhP0DO1CziZ2/o+czqvuPu4HvtlJ+?= =?iso-8859-1?Q?cyegOuGZtPZXaLyf67uwcNysffGn37ESvVN1kAofxQM1klx4MlmtRwjk1g?= =?iso-8859-1?Q?MZkNSZZA/6CK0+dhVNBqjMH7D8j3P4FgA0+snHMFrH5WttZabkxz0UqG71?= =?iso-8859-1?Q?sA0bpJ75J9jO1MPDYR/L8xO5RnOeoZt9C4KjqtqGLQNMvItECrKoC3QsFN?= =?iso-8859-1?Q?TusBj3KkvFQ5va07OqhW7iOVLWbooXDn6J/NyHIxM+vCCdGSvFLSbdTS2U?= =?iso-8859-1?Q?Km2kRZ9aH4CZt08LcTFed10hviMLMIkD0PT9qGLNv6WfV02Zz8bJYcWYZq?= =?iso-8859-1?Q?pgAcL7iH9EFFoZzzPWrkFTSDe8iTPvs2qGnw454ygzbt+7JIMF7gL2JBjX?= =?iso-8859-1?Q?LBWbYZ9GTKIfpKR0nRyWTZIxCr6wdgMPGNFQmTAaQEehGwd+tV6fO2IIEo?= =?iso-8859-1?Q?V9Ko8L61Oz0m3+CzFiyQrsUi3T47dsuE5qgMCabirPuaoBPNAf8xqvowqK?= =?iso-8859-1?Q?LOjUnIa9AMC43IkFn3IijeUTfusGlL+zTBSiCabu6j84eof/8oamv/9lRG?= =?iso-8859-1?Q?7No+Sb1hm4TxJ6/00x8Tew5qsRf+bza89O+UqUsY3nMhoSxg6bQO7f6sYE?= =?iso-8859-1?Q?7bMmtK6XyRn1sbRgxY1nmxJIRqHzd4WO29AInmRMCNTmjkfo8sv6lv469Z?= =?iso-8859-1?Q?O20tbjyD1pgt+LggW0t5SgZvlaX9+MHzPoRNfmBEUfCWzrvuHmYu1/BHgb?= =?iso-8859-1?Q?sMEV9ggscy0lF7qW/xfxzQNm2M7IcyUsTezxSf7Plt7vebjanNJrTTuByE?= =?iso-8859-1?Q?4gAOcyJ39N6SJTKMEsVXcbYM3O5OiQY14id/YiUXaPs7ZUUHi9+o/ekVij?= =?iso-8859-1?Q?JeC6GTdFjXfO3CXbb+xfwPIvoqqLamcflB6m5AcIZ1zaDHmdBq4y5gTRjw?= =?iso-8859-1?Q?YbiHZ58Ir33d0DEq8XIamQ6F+J75aA3VMSfkQUF4Xg4JkXOf9JRdQ0+WdF?= =?iso-8859-1?Q?EONyH2Hj3gDFc9miyt0OhI7VtB7UrJQPLzX5W24pp/zotg3WQZprNNzFlG?= =?iso-8859-1?Q?2bw4LKUrM/d1d6m733YnA4qa4RNpMGQbTRMMv16km6pGKAmX/tq4Nicjsp?= =?iso-8859-1?Q?8bi6BL6G7IulbEBRqOQmhXZ7pY1dtjE8xA6/UKUzf0hNLpwJQMHjwkGzyu?= =?iso-8859-1?Q?59NOsvikTg=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: AGmgPyDQCzlfK27Od98Im2fpnD95rXNoHsKafNjd4jMYIJOKpx3Au2puMnb3Drguu8I8FTdEdf9hSA2dXvaruu896BCd1aXl99yCJ7C9Uq95WBrCcfpC2SFtXxU9/ujQgnJ5PZYc882uaHsSls9q8J8qEBkM7bZHZORJTnPfNhKtz7awKaCogN2t8O6843ZSMxnEVO/ZM4rnIuCbXSDkBIv0WxvAENWcvQ61I+0KBYxnCGtFVZTuDvWuhoMA2gFGNrAbYwbnblpuH9REX8ZVVvSVHP4n2v7qPhn4zVN1gJ2vJn6lfxC9qNN6yr0T3pRBefpkB3KwqY50I0CzXd5ejQ== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8d5c0a-67ae-4168-784a-08de8db5f6b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2026 17:09:40.0424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dC9cqBN0RvA+JMZtyg9REpeauJitxwxZG4fJPY4anyfe+R0N/a8JsffV6wY+3FuGnAsBoKnkSC1uAi+Hz463gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1992 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=aP79aL9m c=1 sm=1 tr=0 ts=69c95ce7 cx=c_pps a=5jkVtQsCUlC8zk5UhkBgHg==:117 a=5jkVtQsCUlC8zk5UhkBgHg==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=6XKncaru_qjgLvANlS_8:22 a=OUXY8nFuAAAA:8 a=8qga_VDxk_QUCVnnbUcA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-ORIG-GUID: lWs1hF1B7FA1Pq10VGwcnBsbG4NcVRq3 X-Proofpoint-GUID: lWs1hF1B7FA1Pq10VGwcnBsbG4NcVRq3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDEzMyBTYWx0ZWRfXwK+sPqHGSgNR 91lN2kr0V78BNvCYWG1znaZxun0rZwmZ/rW3LKZPh49sDb5mfQKnzTI0WmU+i6OS8xTKcp2PhBV 5SZQ8o/13gdcjj+iaWbjBPGZBLx9o/QUpVtuZ5nl0hUBK8+mnV5xnEjtC0/zoNBZ6D281QWgHN+ T/bANKoqPC0sqid5eaVuq39WMe59HntAtABEd0B5tlaCKi+M58pnhwrZQTirRalFv8faj9kFHU0 ckdsl0XYijpCeoVwP/EYQHEsygjrFOEqnszBbmUiDj9JAVoSoFq/Oas2yNpRDMsI6pAdKVYNdWE gJ7K1vZCTPY/cyTju7BHvv6hVGpFZcJuC/7LYierNV/BK0LmbLQ40TA274RNEQnHaJRrig4ySj8 SEh0anEQ+izEp9ZQKQiDqYBgxZJ1JuxcQ6AISsk8eF6064aTLdw/wE9ibCosW6j3MyJbnQtePGG RdIK6PoucoRYDJ12stA== X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_04,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 malwarescore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290133 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan i2c_smbus_read_block_data() can return 0, indicating a zero-length read. When this happens, tps53679_identify_chip() accesses buf[ret - 1] which is buf[-1], reading one byte before the buffer on the stack. Fix by changing the check from "ret < 0" to "ret <=3D 0", treating a zero-length read as an error (-EIO), which prevents the out-of-bounds array access. Also fix a typo in the adjacent comment: "if present" instead of duplicate "if". Fixes: 75ca1e5875fe ("hwmon: (pmbus/tps53679) Add support for TPS53685") Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/tps53679.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c index df2726659a4e..1a6abc32afe2 100644 --- a/drivers/hwmon/pmbus/tps53679.c +++ b/drivers/hwmon/pmbus/tps53679.c @@ -103,10 +103,10 @@ static int tps53679_identify_chip(struct i2c_client *= client, } =20 ret =3D i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf); - if (ret < 0) - return ret; + if (ret <=3D 0) + return ret < 0 ? ret : -EIO; =20 - /* Adjust length if null terminator if present */ + /* Adjust length if null terminator is present */ buf_len =3D (buf[ret - 1] !=3D '\x00' ? ret : ret - 1); =20 id_len =3D strlen(id); --=20 2.34.1 From nobody Thu Apr 2 09:18:47 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E1EE3815E9; Sun, 29 Mar 2026 17:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; cv=fail; b=Kdb3hJCaAcc9JbKWNk6jjeOhnAgfrk0Lr5vKfBn6QdcxNLWaNLvkEx5X5Idws2PO3+I4lUGmpIjjlEd2odkItUsNucLt3HhBFKhhJXg1p1XSh+zdMq5HIkp8g34S6iJDJd/KN1b1U9f+y+JKDYKz7KuJZT6bJwPj1K+UOujlejs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; c=relaxed/simple; bh=ZCp3Ud485CiDImoojh/VHpVkLndQF2RbUHq33ZkiM4Q=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=BYDZ5uPuzP2kiuEZmq+T7sO3wjdiBFGHnISg/niLx/T8bAJowXGpNU+dkiLnplZi1Yuw/30fIkdfJ94rN6KQSSuvCAMsiNKQ+XFP+UvTM/malBAF6KthZpZ75X3zIT5j4P/dgUCoTv07tawjIUqmdYQhC7rqll9gTA+TaOW5wms= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=Ddh8sus6; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="Ddh8sus6" Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62T333W91185456; Sun, 29 Mar 2026 17:10:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=CP Aaku9dGUy4n1i4a7LFFxZ25e07OFj6trPDCPXtBkg=; b=Ddh8sus6qf2ji+dgOc R1ocw2InbK8cnH8wMLfBYxGbBjxqFVX7Y60xYY4oieSMC6aFPKawJwWppPii5HUh yObaWw4WxhXhKlfwB3/7yk6w/0gKKriFPMLJzhk4i4eTo7vueCW/yjDiHfrFRWPV aqTnZvEKlRmTBImY/W5CjWMiu0n8hvCF7+xg9aGBZf7Mslvs5cDAVWRKVnrfY/Bk ln8g+Lr0pRHU03reJuC3dU8EGzgGSGf4krv1nJh+vcYQH8Y0PkocdO+FhZ6vktBk 7Y/W3qwY4JTvC1Z//UiCmy9Je5ZwWWd9jAr07vAzRrcrFYut1l9UhVAWJsK8cxwl 0lPA== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d6utuc336-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 17:10:05 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 372BF802BBA; Sun, 29 Mar 2026 17:10:05 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:10:05 -1200 Received: from p1wg14924.americas.hpqcorp.net (10.119.18.113) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:58 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Sun, 29 Mar 2026 05:09:58 -1200 Received: from DM2PR04CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:58 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JdcR9hWCf7Y6ha7LGsiVqkB0W9ckOo2v3WIUoOfZJlertFZRq/SIlm7fedQPWn3FO7zaqO6R1+BB7JAR26fFhTSXMhPMw/uoqVW9Jwd7BAYQGSz3RDph6iieduVAQ1PJKV2oqgqyKsRL67KqVxCf/RDysq1WCMeWl7F1k94SszSPsgH/Rxd1M3+1EmkoiV4JAXzo37Hl+NU/aIzcEG6gTtnE/JOCsJ0SIo5YyWOU4GfnmkbuxzV8L3kbqt9+pPVZ8x/JQyzO/H/zTbsOOLdoD2fC6cWguB8ISK1lmJsUAzvZakZycx0aQBIxJTJ33XnUicll+yYphLrQRs9LduYsLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CPAaku9dGUy4n1i4a7LFFxZ25e07OFj6trPDCPXtBkg=; b=OmgCQd/rLscKv0llqvussX4yaUJcilakFPVmxZESke7dfOu2UKVTm03EX+0FNyEtSrHBw6nH1BfsR/BLd+T80RcSjx1xRbfmcN0MNyb9AdsU01DaTKjbPjUuSGrAiA62wI0NTbiUBeXrQfnnpa/xJyBs/KbAlDnP0u1FZVoQJTJP4TS45B3w2Vpcul8/56QJIw+I9cRNkQAVgxgGjzMGoKasz/FdMTrvJchsnkoT3AzxRZ8VTc3DkEmIXi07zeslkMIvpVLJVmw30qVvIi2p6XkrVphlH5MkCna1Tjpp3CkJXrO9Ov0DNBUKOayZ560BvhhhbCqA+dRQ0wKWLXa/8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by SJ0PR84MB1992.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.27; Sun, 29 Mar 2026 17:09:44 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9745.027; Sun, 29 Mar 2026 17:09:44 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: [PATCH 2/4] hwmon: (tps53679) Fix device ID comparison and printing in tps53676_identify() Thread-Topic: [PATCH 2/4] hwmon: (tps53679) Fix device ID comparison and printing in tps53676_identify() Thread-Index: AQHcv57WBISaMU9p50iwQJWEl89COw== Date: Sun, 29 Mar 2026 17:09:44 +0000 Message-ID: <20260329170925.34581-3-sanman.pradhan@hpe.com> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> In-Reply-To: <20260329170925.34581-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|SJ0PR84MB1992:EE_ x-ms-office365-filtering-correlation-id: f5c9da0d-f4d6-4e02-548f-08de8db5f95a x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|56012099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: erkkNOGfF0LMKH8TddksVE4oeDP8AvrIAH+rJkiXc1XVl0aB/cZB33Sh7ZZ2Hw6HlTU3yJEPPFqoTDRFfSSk3NDmjADoikdeyvikZj+/al5AnptA/lITdQ7VBXISt9kHloX3mlJ9tdBbJolknwQ6MaOoHz97SFGcYsXebH/XIcvS7D6OU6eGd4e+zCpyBxLVVpKlv+sFgYiOpD3HozAaF2SAAgOfKh7IdENpn32dERjKFVoofz1Y5XjxODEa6gpY4Ut0H3r+RDmHH+6Pg43ZtkjEWjkcvdEotZ6mtapde9eMvXJLGBNMPLnNUf4ecJvPJmsja/WWd8P4sa6WCeYzeBf8NHntwz4X7Eq/4vo0kHNOt0ESRSuqh5Kq1ybKExNz1evtghBytm009iTYYBDCNqgb2l7kvGmhHbD7s6YCymhbOT2JIpybZKYudXJK5k5gDW0JYqKVU1ymHrNg9SNufiHeqzwHldMuoHxNX+scBFK3cihtkb8Xik5aMYBuRrXPw/V/uK5rZECThybdPS0GDdQyJnQ9hf5ZzfE/TwOBNt1pxdra4X3uoYXgYOdIr2+7QHccblHh4rV3bl/iOweHyzrTuCEuDb3epan9cftwZ/7gqWM7nIROHhKcEK3hMOZSk7KNS6c4UV4z6pKsvEZ2pF+hK8l/Fes5Vy2rL0qMp8TscCwbMxtlm8ngbPguTe4/N4Ri/gZlpl9G1dkP+/CyOw43pqxTZDoEd0ByrL39OxPROnk4pxon4DrBb22DeJDbIe77yQvDcXjBACidiDJ5lH10nAChnUGFBb6qqTOjLX8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vqUgx/LLxpvwjptquNwFeE8yvncThe5JMo+W3xH6qb5y+geohtuJvoc/wA?= =?iso-8859-1?Q?t5kEUTcpxKru971LYwqAQGIXNSKtMdMdBvxbB2wFYOEqUQrujCEi9wMHIO?= =?iso-8859-1?Q?JhdrpXWTeb2PS6q72piOj+O6CgQidt9a5rDNfVuGPaRSToGKT1bpB3AZdF?= =?iso-8859-1?Q?N3Ce6igU1h9JvaCaKfco4bzjrqz1oNpGxbGdryM6xe5WHxfXyf8B1uIes8?= =?iso-8859-1?Q?NbrAk8TUdCidgo4e/RfPQxFQ5KtqHk8ewSf/wWj37N+L3mNutIT7WumN11?= =?iso-8859-1?Q?hG6y0nWnDjIPX5BzCG7EQZ1Yqt7aFGHzjB0IejDPVsnXBnT1B/BHLFmD9J?= =?iso-8859-1?Q?yhZwB8rPO36n9ezrfMDM5WHPugIY5+CFZa4p6ZL8EZVwmszHzM01D5etb+?= =?iso-8859-1?Q?sv8KlWNhXsxu3cGvxs7lseYwt08TkLe0R2tA4cyk8aUVyoOA3wdc7rxubN?= =?iso-8859-1?Q?ZOqalgJQ4gbxsbcJN0SaTiXBSyaYGQ84YzcnPCquPMEGZegYeHxMv9pfaq?= =?iso-8859-1?Q?oMnimM+cCmPqD3OzxeYHO/ptLfTCmGzkJndw9T9QWtg1B/3hPuAqdLEOgi?= =?iso-8859-1?Q?x3KRT1nZEWiRCRY3/+RN28b6YeG/kYwMqRWYxdjwT4UhoS22JxYKTgxDh9?= =?iso-8859-1?Q?55FHGRzDkUGJiKg+08HgqF2xNWDe3mKobcQNRKMC3GSGbYcqAzkFj2hsdi?= =?iso-8859-1?Q?LlfFm7W4UVkDLV4Ho34Io9Cpsalb3vY4JObyoFFBcxn+rNmbVf0dqwsBqo?= =?iso-8859-1?Q?hZACYreqrfHKk9gnTo6GYJOWFuY3Dmntt0PiIhc8LrgWt6xBDD3mzQXAPd?= =?iso-8859-1?Q?zeMofR9Wmxt/XK99hK7Wq6rxk5FcxdiO/NTMcpDfiWVmD9Tcl4FZjeYJRb?= =?iso-8859-1?Q?Sq/PtNS2a5rfTQMYCOlkDz1PdJYKEYaVcFA5MVwBsQ4xTFQh2yoJARLMgn?= =?iso-8859-1?Q?cdRuyOi4ak4+P/6c/J/iJB+OZWuSI0wjs4omo61wOY9kwKcHNaDoX2M6Uh?= =?iso-8859-1?Q?TlgsKDJdeiKhV3010UEqRjduZ9IurKXcoun3PtFC4WFe54EHUfQ052YA+2?= =?iso-8859-1?Q?4oOAXSQ/xC8buo27jYxqIvLVxhvKEVK5BidqDqbjbMwuunAvQZV2H4eH40?= =?iso-8859-1?Q?obYLZqCN6iBNYuZz7ef9cl+1sISidQjT4wXo+62c3uK7afJKYFwte1m5+R?= =?iso-8859-1?Q?mT6fqCtJtk1zTC3k6aKvTAYhoYlV7g4Fq7tz/BGreCr30hkDlMkW37vOAg?= =?iso-8859-1?Q?GGaVA/+lzyDXoC83DotTImSxXJrtpT62918d4Ziwd2IReu5rTY8wdQ5lkm?= =?iso-8859-1?Q?MpeQh4KGEg40CocSRbW9OnWtkeF4gcbWpzm4R5qRrbt8efC/tVbhScPBNi?= =?iso-8859-1?Q?IiYSEsPu4D2vQ0r28uK0iLkxrj5bWPVgTvRzFxVRFOhy/C0ltG6PE2gOcb?= =?iso-8859-1?Q?1gXxlNhcv7mLpCgR7/wsgqd00r8fmS756nr1IROSobrGa5TX/KTBcUUCo6?= =?iso-8859-1?Q?MGY6GblkJsCpRtBWFoEcRt02mnW829PZffQ0LHwjLpnZ5OiF9+F1HEmTgU?= =?iso-8859-1?Q?GXhE6v9bOSZ1qvxHJRoHT3GaOZY2tsoq2UzqilG0x+NhVZVTtImiZ7xvc9?= =?iso-8859-1?Q?O22JTWF9gL4HgRjXFXVVXmPD8LYaG51qm4hOl4tu97ACO3IfVP36Bm1Kkj?= =?iso-8859-1?Q?n8Mm63ukOe0wgHYya60RWDFy3PAOSUpfpLfrDG2oPdDT37/u8H6QyPRDZq?= =?iso-8859-1?Q?vR9la1sZt1ozafzT/xypzM0ytMslxGriPqBZS8YB2edrEAfuJPaVDV4uYQ?= =?iso-8859-1?Q?HeoQLvYrpg=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: uNcmfGeyKesR3hVEJHtLwiJxN5W5ag09hU/K4PYJ62KY0XKHO29LHIDvP0gY27ck0PvH7BAm+q71zYs/qD72xWMwbKEfUNa7fVBrmWDKmb4U79gRtQRwTXxnOA0TtljAzxXnhv4EqQHLtLJb7+UO0CKVpNwsPNaMCYUcKjvCWa5VIau2YKirsFsf8SbO+StlvA7mXc3LhOppXtE8NCYn29Dv6/iSqQW68Rf5u4D+U6N50gw/YdT7kU6sAq+Ti5xrJNt41fVMOE6RHu8tstkyOglTLJ5E9KdIzd6wEr9wcyhe/8RwRIK/Aae7RazN+Oc76gF/ktUsU6xSDUnPMFK+Dw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f5c9da0d-f4d6-4e02-548f-08de8db5f95a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2026 17:09:44.4919 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gmFlgI8F+4loHuQhvmy88FPaVtuEdW+dQr5qQ8FTrIUFLUZlj/xprsedFVbImm0AbMHVo7ShhoVjPf8TiB8G3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1992 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: Cvnhj8k_1pRhyqVyQ2pwAwL4wEJT3hvc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDEzMyBTYWx0ZWRfX65GRdDQwrCIb k3xgUO0YAtDzS23N5uZEe54rrn7Gez6AihQsQ6zlnCa7sTMPPh0ZoDg2+hGmT78xIxRNgvjvYir /6OOnqgcobRrlA0P0IadH+UhdNc5dJSieHbZiTIpoPhHBUVCHu2AUBe0N0Lt0YcoOj4XaDes0xC XnO7CTS2EVOUzeB9NCzEQVJrQNPIgSpNPlB0fwvA6bpFXSThS3smDbhO9yDKTnLAiPP6qrpNe/p 1W+XT11wsLzgESEkMCzVXfML/LK5MeAbsIEBLrisGLZOK/Q8D8raen/wnZiWGreOvtUco3vmlS5 3GKbw6YEguwjtJ7wQJihvNJBd2ABJbJSBFtnbvdKYWdmoM2mbCpUkhxREvKdDgTh6/xXyN0Csi0 vK/PSmhwz6ZiX3hGGwDeYftekTkcpQXSxwg/ZY2esaeewBuOT1g1nAaVu5dHqGSVdz63StlQC+0 MBiJsDXyhS1CukDr08Q== X-Authority-Analysis: v=2.4 cv=N4Mk1m9B c=1 sm=1 tr=0 ts=69c95ced cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=ZSrvDirOKP4VPF05hnFf:22 a=OUXY8nFuAAAA:8 a=PDycEKfu8UU9aoxfwVMA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-GUID: Cvnhj8k_1pRhyqVyQ2pwAwL4wEJT3hvc X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_04,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1011 lowpriorityscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290133 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan tps53676_identify() uses strncmp() to compare the device ID buffer against a byte sequence containing embedded non-printable bytes (\x53\x67\x60). strncmp() is semantically wrong for binary data comparison; use memcmp() instead. Additionally, the buffer from i2c_smbus_read_block_data() is not NUL-terminated, so printing it with "%s" in the error path is undefined behavior and may read past the buffer. Use "%*ph" to hex-dump the actual bytes returned. Also add a short-read guard: if fewer than 5 bytes are returned, report -EIO (protocol/hardware failure) rather than -ENODEV, since a truncated response is not the same as a wrong device ID. Fixes: cb3d37b59012 ("hwmon: (pmbus/tps53679) Add support for TI TPS53676") Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/tps53679.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c index 1a6abc32afe2..d6600502d6b0 100644 --- a/drivers/hwmon/pmbus/tps53679.c +++ b/drivers/hwmon/pmbus/tps53679.c @@ -175,8 +175,12 @@ static int tps53676_identify(struct i2c_client *client, ret =3D i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf); if (ret < 0) return ret; - if (strncmp("TI\x53\x67\x60", buf, 5)) { - dev_err(&client->dev, "Unexpected device ID: %s\n", buf); + if (ret < 5) { + dev_err(&client->dev, "Short device ID read: %*ph\n", ret, buf); + return -EIO; + } + if (memcmp(buf, "TI\x53\x67\x60", 5)) { + dev_err(&client->dev, "Unexpected device ID: %*ph\n", ret, buf); return -ENODEV; } =20 --=20 2.34.1 From nobody Thu Apr 2 09:18:47 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACEF38239A; Sun, 29 Mar 2026 17:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804223; cv=fail; b=BxmizeNWNvfZmwQj4C3LHsJXrwfgslRiODfwy6bRNPkLVdFjT17KLF3tfd/JiNSxveTvsyOep62Zs/BdRzW4Fx9pgim5ElXj/Y+aXs8yo06luYA0UPEaAlggKGsmptnPJat9hES9p119KVlektTX1KpqgruHcB622/6KOdrEenA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804223; c=relaxed/simple; bh=6c+cA21eOZiuonyYq/4iL2QR6k218QxyDCKGd9pULxI=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=EaDPlbFxHBi8ogrPVrqbiUl1DN4Q2b7ouR9jyzJN7p2YuYkQYbXZalQNO2lORathXl9J2t0aGxrjQh9NDfbga6WabeTM7kEg27MYqhGbSXuQINVsrrTAk0IfnN8BrcKMIpi70EBv2OrjPJt+nsmOfhrCnrl3CR6jsh5fKpYgMbo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=NxictZIs; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="NxictZIs" Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62TA3LKF2410180; Sun, 29 Mar 2026 17:10:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=Vk VREVLVPLvYMxqaXwCNZXzV+KVp5ZtEmzMqDBGhzv4=; b=NxictZIsRJZmfCqUqK /Q6UVqi1Pevw0Idu/eoZd12XU5XSOSFblKVi2f9Vb3N8jJun7/uizApASPWK2XZz JwMsvyq0oDjKiaefAbXQX53wF4pTfi3EFq3n7Zh7b3b8u9jeSHmUTPoeKmXdSfIm m4HN0FABoyh5aq95/RlT2tjj/oaXEWl/vnYCao9m7DMP+wN/sVixTTJpv58Ezx8b qLaSDyDtdcwCpgabRDG5h9xPkRf7IYHL4td4LUc1zdbX5Yk5bS237ISKrFhY9Qf6 /iIQLn5UjESSfZZtJ1VQptrAAeg5xMVaBBo4YeetFnhrAr52nnsY38Uq3xdmmZUE S2yA== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d716j28y5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 17:10:05 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id 4F46CD1E9; Sun, 29 Mar 2026 17:10:05 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:10:05 -1200 Received: from p1wg14925.americas.hpqcorp.net (10.119.18.114) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:59 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14925.americas.hpqcorp.net (10.119.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Sun, 29 Mar 2026 05:09:59 -1200 Received: from DM2PR04CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:58 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dlPNkocwUP7LQQFVdy9NP1GuUCHuWjsnT/KI9/tqhgiVKCXwGjRKhbmhnuIPv/38ZJr3A3XFXS8aIujG4viHtTyn5vBZ1IkQoZ9Ew1u65NBNWCzz/B681bh7aHyTvc2iLjHjDJ+sxnL2CkPRb9m4v5yKjlF2UT5fkxT2XfzwE1II+GArAD+qTwbCcqr6e52jDAmjjg2HT68AqLYM5v+85Bl29NCNpgJCtaR3vAr+s8svTFurngpTkwtSMThklogPUmWArEjW2kfvM8zjXahsYYTFsCttKN5X8jEaeFqGe6h07ATcCGjDfOhrxhY68zY9HxF0NmLfnwPO/vD1golMIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VkVREVLVPLvYMxqaXwCNZXzV+KVp5ZtEmzMqDBGhzv4=; b=dTF5dmJ9NHgAIMADgUFbpaicePZ6Zf0SM96dboMCojP6OGfVHFgXYoEGO0xXirVx52XnZ11ZHlKcB9pijoSevgWJc1rnlS4+Jw4pdN5DBmbm7voNFY/Klnt3iYl5e9J+qIsZW08JADqKANGdbP0K3x+fv4h6LyYXXEYYO083VZyeDo+qqQuvi85OVgeD+4VWDi/5FkXLIU4esI/yWj5ON4Dy1xxe61RjDCISl5Bp5GFYffdjX5iwBv6qkw58owj46pB80CMXs3FqHjDGFbCNWMqx/r18+QBPLj0oItC5cyoNgZ5vQV1fxN7w8a/dqo6UGDJy/apWTW2Dsp4jrN3keA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by SJ0PR84MB1992.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.27; Sun, 29 Mar 2026 17:09:49 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9745.027; Sun, 29 Mar 2026 17:09:49 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: [PATCH 3/4] hwmon: (pxe1610) Check return value of page-select write in probe Thread-Topic: [PATCH 3/4] hwmon: (pxe1610) Check return value of page-select write in probe Thread-Index: AQHcv57ZqifkkczCREOjPYiI3MPLnw== Date: Sun, 29 Mar 2026 17:09:48 +0000 Message-ID: <20260329170925.34581-4-sanman.pradhan@hpe.com> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> In-Reply-To: <20260329170925.34581-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|SJ0PR84MB1992:EE_ x-ms-office365-filtering-correlation-id: 2eb01e2f-091b-44f2-dbb3-08de8db5fc06 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|56012099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: 01AhYNWrv8OxwIphjnyiAMF4HSEMfdu14iV5LYyudqFD38bx0miyGzHDLSoUvwdXHbrCWVvdpemJuJ4heHZfZZ5ruYID0ARw9keoD8OfYtE4UtPF11+UYHG4wYsc8+FWS03N9OE0RVqffrjt3Vzh075t6t+fjeeULW9Im4soLxLN3CsXWwd0p4v2VpQpnXX0cqMJr3pYshkOeQmgA4YcdmWvEYKmBXixcHJEPp39ktKe2XYmcHBII1B5T5erB3Xg3qS0TsuHi22YAlYhjsRJi8+PEEExoy0JVl56etW2g6Ct1rPxXMxHnSxv3r4PuZpDlRPUm4VHX0gEcTas8AhHWO5m3J97wDpiYefVV/epjJAPtIgbkZdVerworMgwkHrEoTEARVGvWdcTS4M1w4o6blcBvfXt0XujD3fahnMPNMAdAF9Oi+waXmxoTGfg2PgWIeGQPFZMdIDvy/n5AR9t3fDs7riMDBEE2aLXbLsfBTx0Tyv1WQk0fNJm5NY8n3XPqvda1ZajmS3cvjMCGquClsvL+WBGGkygEwJQIi2wYmFTDdMn1zOllRe9f6JVnPqTMx5GfEm7DMTcjGgenHuaHf1xxydICuFSXh7XNfJbiPc+AFwfoIWh96VIPJSHmuY+7AMM3iCBp2JlFc4jHFoYKsqpw2JOya1Mz7kdiQU78Tqf+ISp9EEAPjnGteJMlXbkQz155dNQXAdU8bR4q4pulVm0MG5GctgzIcMdA5fy95QuNS1UxYUvrKl728RUliyLphfr8Yc2u5gq/ROueVo7NpTRz0lrseZlyPJ09QnR8O8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?mqNZftjP+bxwdguXQUBZgneAJ1q3oEoQUc9domKxDzSLhPEH2eGf0L8qwB?= =?iso-8859-1?Q?ikD4X56Vfu88haOX+VE6QhsOFWa9OU6Qa3kV7svECQ8BC8oxGb41hd3Wjf?= =?iso-8859-1?Q?MnZfHBXUhygcj7Yc4uj4Qby5jvXA5oLA2v6cd2a/ag9DCZHYWhCOYvH1M8?= =?iso-8859-1?Q?Cbn5VvsuJ1oBeloIt+srMCZLr8trtajBsivBzYIql2n3gNomTWAP5mgoUs?= =?iso-8859-1?Q?w8IV+IM52f4Nm+HyHBBhPpKM9rRq2e7uKa3UNg0YVXkBeHroD9QmfB78hC?= =?iso-8859-1?Q?U08TOok5vm3V0Ks6PjUyC+xhyuL41FeX9pIKvgrptMv7QyJ/uT+G/yCc5E?= =?iso-8859-1?Q?WBxdVLsJONRc1O5NPd7w/pPPtF9dvlgocUz4R1PdiwHFeVC/0GF7FIO4zc?= =?iso-8859-1?Q?Ubo1KFcN5S+rOTSLeuwwDkH8lVPVN8YW/Pv6FAkZJXV/sniPZ4LgIAKf4W?= =?iso-8859-1?Q?igGXq8y7P9M/CEqvKtAkZPTC6/cBS170uUqI+JAfNDRUrpUuwnQTvA4W7r?= =?iso-8859-1?Q?xqMIq8e+xu/V2KeeXOuTvT0uBmq+xyw8ZF1flClWwAHhSLUPcoMHfQ3YJt?= =?iso-8859-1?Q?GYKwJHhlD+eJYG+pZfCa7ncipeob4Zn1Lw9W8ZRp6qy4savqCPA0nyWDLS?= =?iso-8859-1?Q?u0Np60CIBd+ZH/nHU7eYcI4jQkRAulJhSzJ+UlGiLPnsRqjSOJVrE5lfkS?= =?iso-8859-1?Q?HdNAzYCznAVcIYXYvgZ+5B1Wn69w4NbCUzby/lLfgpkDUNUVCYNgeY7clF?= =?iso-8859-1?Q?1O5HBHno7fhRY1UXWnuNV/f4I3S6gVuDMr0w1NFHnBGdhzcc2QwQPxaEAV?= =?iso-8859-1?Q?3VnnojIsGsOpHTzp4urSkmi0nW/6k7cbwnmgrca0kzWN6LVaMRGyFTTpuH?= =?iso-8859-1?Q?rszode1s4sinYDOuGE8DtfgeEa6h3AvAiRDZXK2N/mwBcGU/k9L2FMtk1w?= =?iso-8859-1?Q?vcKsJw3YYXW6HTWjmZr7OLGy5BqvS63erkhqeVcgc79OyPV3I3sjxD0s7W?= =?iso-8859-1?Q?zP66UKjl3eP2DGkCMoY+mAcx50ifaNDQj59d0uHWj5oq/z82LOCkdI5oAG?= =?iso-8859-1?Q?GKISnd/cYbpX4CmwsPB8mle29FwwBLkHs6uUZoGKHQ+Ls9lznq7h38XSwn?= =?iso-8859-1?Q?39lBDN3/ayxcPpYARcbELDDrAHLqKzS0IlGFTiFAaGN4UswR3ZoSSSLGaR?= =?iso-8859-1?Q?u4NZo0GWmEo/7lSFwmyNjO2PkGm//nrMhK04jrGuPzsC44pM53s5nalSKZ?= =?iso-8859-1?Q?KtlLzfZIkFW8C70Q/KDlNKJuxW5mMpIW2RuXrmmZ2o6mDO9w+lFh76MTS3?= =?iso-8859-1?Q?jTbIEq5dYmF6egYtTiMKi0PgXIvF+i2Ky0zbXdjH1HNOqQAbErZAiVc3xr?= =?iso-8859-1?Q?Vr4ma4qOTianmRvmKcWe5SBRsPBZ6h0Z6tEmLPwjQagM8KuJ1k598m7IdF?= =?iso-8859-1?Q?jQ08zvUjpEOCcSvLajpA7hcymETGKLCW20y2bCcbdnEs75x8ZC9ZB4Gygy?= =?iso-8859-1?Q?XDzmSEvPSNeJpmJIx5Jhsh7kENM999lfT1vG1SZi75UAxJB/+Txy/K9U8U?= =?iso-8859-1?Q?IQLOmy6HU/sfwyeUFutSJ4QCWEVnWZpnshuFwF2Drao6eXVR+WMD2E1Ugx?= =?iso-8859-1?Q?9bKdYd++Zg3RZqJNZ6p9sgG3riwezu8cHfPOYcgpSbhA+Wv/gSO/f4IDuM?= =?iso-8859-1?Q?V5gSosMOtAwSvV3U9xuETSydOguGXIkHH+Bueqvo3QUtVPuLyAPXSyrVC7?= =?iso-8859-1?Q?P49ahAujMr1lC5iny3SDfsXvz5rOl1Gde2M+RopTw1gZkRLO72c4xzFEBi?= =?iso-8859-1?Q?+mrXw9GaPQ=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Re3FnxfuNc21wnjQJmhtZ4B/441wcG94Bx08JgGKHhO3zyPa9OlU7iI+6ek9b6qUmDxa8ws2qZj2FH5qVhwPYCbDcWomPg91g3wRi+V9BHM6Bzmw6P+O9xLZIIl5hO/hSXixO3aqSKJk7zjk7f6gscuUcmMVGs3vaT9aBIMDsw21IwZXu5HKEteF8+GMr0mnFN2x+cDolkH/9cSpKZVscTxDoHUb96QZ+ON1y+wUBVFnzB2U9f3oNKBWN+Ip/ZSEguHloIG9PHcAlA87oUyUR//cBZRjb7DLLXnSrfTlmAfrB59MGyUnplNhP4LchYOxbUzT4sfOMfK4oHvhswzj5A== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb01e2f-091b-44f2-dbb3-08de8db5fc06 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2026 17:09:48.9797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tjP5YhtWsVEkaiSRhwu/dbwGTuM+Apw7DNrmQlbeQYKrJ+P+wN2xzfBv1c5elNvOK9ZpM8rNkuMnlJdfSC3T3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1992 X-OriginatorOrg: hpe.com X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDEzMyBTYWx0ZWRfXzXHa1zRT4BDv Amk8OcPpJD4b0/u5cV5mCnW8p4TjhAfa2u1uHGLqf4h1Vo86YTc9qxMHxtZjzVaLmaA0aR0KV7E A4jWe4GeeQFnyTL/CSPiLzMz5wKVjRSaT8E3sKgCnAhbXZSj8ERqbrMOX4pdjt6KRaSEEyU2qZo uenQLi1MOKwh6BoKRwoxYJDFU3NGGCKzzDwafYWBn94rXdvdUxRdI8dVwYknefl/GyCC0AOHVZ2 ECJRsyKKDxlwnN2wsSF19XuWaMVI7Stm408mQDkdc7P+1AIdF3+5dMzuWJsRjekjAV4ls/oQHSq ek9IjL1avBj1LaGDhPryVC+J7iQ71ViJ8GBU4OzqvEH9BqpIlhLrmcj8fLvgSz484LxDkw5vFo9 anQCVGDzeIvZMfUdzqgkXkVq+hhLRZE98IbWfq4T/88CWEA3HRji7D4LWVj0Lr7OQLnMRwjjMuC uyCVdcnO6vRCZHIlK6A== X-Proofpoint-ORIG-GUID: HLMQMTOpavJ3LMNGRtb1IhDo_J9g0ks8 X-Authority-Analysis: v=2.4 cv=DIuCIiNb c=1 sm=1 tr=0 ts=69c95cee cx=c_pps a=5jkVtQsCUlC8zk5UhkBgHg==:117 a=5jkVtQsCUlC8zk5UhkBgHg==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=3haJ9R1Aw3gUfsUHDaCR:22 a=OUXY8nFuAAAA:8 a=I2HXvSVKOc2IUxaNvNYA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-GUID: HLMQMTOpavJ3LMNGRtb1IhDo_J9g0ks8 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_04,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290133 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan pxe1610_probe() writes PMBUS_PAGE to select page 0 but does not check the return value. If the write fails, subsequent register reads operate on an indeterminate page, leading to silent misconfiguration. Check the return value and propagate the error using dev_err_probe(), which also handles -EPROBE_DEFER correctly without log spam. Fixes: 28ccdfd11344 ("hwmon: (pmbus) Add Infineon PXE1610 VR driver") Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/pxe1610.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/pxe1610.c b/drivers/hwmon/pmbus/pxe1610.c index 6a4a978eca7e..24c1f961c766 100644 --- a/drivers/hwmon/pmbus/pxe1610.c +++ b/drivers/hwmon/pmbus/pxe1610.c @@ -104,7 +104,10 @@ static int pxe1610_probe(struct i2c_client *client) * By default this device doesn't boot to page 0, so set page 0 * to access all pmbus registers. */ - i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); + ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); + if (ret < 0) + return dev_err_probe(&client->dev, ret, + "Failed to set page 0\n"); =20 /* Read Manufacturer id */ ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf); --=20 2.34.1 From nobody Thu Apr 2 09:18:47 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8882D0605; Sun, 29 Mar 2026 17:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; cv=fail; b=XyvjOywEm0dHFb9YGHFLZo18ZyaOqKgzbFbfQWIPJg/kAOfL0N5k4RC7pa36b6qLUIu26gzNv7VydVlsJO/CcdfkZSGRdDfBt2KP5elze06NGLU3uLuHyfqHKqJLe1DbF0zIseI5k6w/U7b+gfN+Nv6Vq/5VyjfD3+FbUq64fQc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774804222; c=relaxed/simple; bh=PXDqlSQDL063VTkZUGp1lZ17qXcKpd+8E/oBY38ltec=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=MzJOEl96dFwcev9UWfWw0trr7MKaSjIYkvZXW0oYXIyQ/qWYUtT0LxlmKZ6ILVsypGeiXc0+78l/iVqAG/JngmObRHSey0ekkFCbmu6gaQNRtUTO4yWmaC62Ubq5OqBH4ek8Ojbf9lra6rd9cbFJYAR+dbpkRksA7uIHOQeG058= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=H3oxp//b; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="H3oxp//b" Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62TEsswO2849921; Sun, 29 Mar 2026 17:10:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=PX DqlSQDL063VTkZUGp1lZ17qXcKpd+8E/oBY38ltec=; b=H3oxp//b92u901uJFk VrDaFPut0mOLLiG9VC7Fvu7CDw/RsiDe+/6jCfoJQViLBIom41jYWv3YA2j8e0lF HPzVs05X3X2hD6QLkGiG7agpxOKBVzNDaWp0zYlcMr1Irey6IMAOG0dU4JKo8r4U DnpwVCiixmfnBZh6GYGN+bTtiUweOATfJlPWLEFtH92mQNx274WI1AZ1ah1W9DP1 HkqKsgDwUsTDaYaZOUkMZvvzsfb4gn5dyigVJ71Im0tJEQzPKdsLBbpuR/NDjoWX AjSSHUhR+02C4yZknlH58reViCoQuDauGl/UU+PfSnH0MEjY3WA4PDzsRAcRub0+ cQiw== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d768egkwd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 29 Mar 2026 17:10:00 +0000 (GMT) Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 14FC2801AD0; Sun, 29 Mar 2026 17:10:00 +0000 (UTC) Received: from p1wg14926.americas.hpqcorp.net (10.119.18.115) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:59 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Sun, 29 Mar 2026 05:09:59 -1200 Received: from DM2PR04CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 29 Mar 2026 05:09:59 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sJHT1IugVhgIAPerAEjnSGE3xmADd1swGVOuY6Lh9+j4qPd5RnRk8VrsWVViNLJOxG5KeWvHvLtUjlLEsQ+TTwmey8E/f0ymQaP9BRGHqBNF70/it/VyCv42m/+m9cvymhrmRKQAdSLnwpUSuEEbwJUQ0hHr0sD96EUSqqpbb1dC+LK/1WT8uAA7c+ckBSHTTePnqKXa+0EXQJ9kD4j8iQo+s47TEUPyjNwjM/IsLO5vxY0DXTeAJHi2HnLklWPg2yvquhfnpwK9jkPcfKXKLf5EC3UjvZBFp1fS8ZyInn+3ESmTIcNT/+iaX1fRb9PyfzBMjORThdq2aoAYWN1OQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXDqlSQDL063VTkZUGp1lZ17qXcKpd+8E/oBY38ltec=; b=KZT7pIc+8oTHKCXq9R91lIb5cZ46oAW25G0PojMP3e6e9GUgkVxHBJsI57PEh7KrZiygoe7Y1ahPiJKhUEbQPwtMcSO2axFq4pFIZylWAyzLcRzh59CfweflSWx07buQiUkjHbltIlkHggdujQh12FNCYMj5MzDxxMC7pUbhQrJS6mVn7Gi5TJ3mLYjBeBVKiBbH/6jILaN10I1hS5eXoXpIHF1Qh+qVpevqwpE/K0umCsFf6gyVj9Yp9o1vK0uYgjEMeLeY7q12jBU+gZSe9YWhKwEnt2dmTIOeB+2FHCbQZ+Nbvba2+o3YYLqfZof38VrXP0Z62BAibBnDCT78kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by SJ0PR84MB1992.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:a03:436::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.27; Sun, 29 Mar 2026 17:09:53 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9745.027; Sun, 29 Mar 2026 17:09:53 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "Delphine_CC_Chiu@Wiwynn.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan Subject: [PATCH 4/4] hwmon: (ltc4286) Add missing MODULE_IMPORT_NS("PMBUS") Thread-Topic: [PATCH 4/4] hwmon: (ltc4286) Add missing MODULE_IMPORT_NS("PMBUS") Thread-Index: AQHcv57c6U5hhqhL+0WfONoAgKOMRQ== Date: Sun, 29 Mar 2026 17:09:53 +0000 Message-ID: <20260329170925.34581-5-sanman.pradhan@hpe.com> References: <20260329170925.34581-1-sanman.pradhan@hpe.com> In-Reply-To: <20260329170925.34581-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|SJ0PR84MB1992:EE_ x-ms-office365-filtering-correlation-id: 115fc983-9e79-4304-bd1e-08de8db5feac x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|56012099003|22082099003|18002099003|38070700021; x-microsoft-antispam-message-info: sJyBPq4pNp7r/QnoYpzjBzFjQXivJmuLyUYLv2gR1Ql7QNCIdxaFojhYp0Fv90jRcrowUi08Okqb3C8alFzcYk6/d9aqQ16FY7bTgtaVSjc36nkYQQFl29Ii/hrbgYQeGXMn3XxcNcUQJDqf6dUdXcDXzT+jVARVlaZ+Uje9xJH3+zgMVX+PvIlDaE2GBspApDSQJVUvOqIoXtY6J2zBAUA+9VWuxFRtReJqkx5dSWFMbKOOtUn8g4KKmmEDprKKDn8eb9FfUvBDZbMVpQVfWMJKpLzG68tKp+/vQA0jEZXrsnA4vyFxuKO8y/3naMx8q/qAtCwrOX6FS92yu2TYLyHKfXoNGu+8Es6Hz6iFc11ewhsv4eAta4Kyhy/SLXj67ZW9/uJFYV+b4l3LSjJ20AtPoT22PzIe57uE1REcIywjQqxDr4CdmaR8O3IhNoN/1UUbhbx+zXD62FslbDh11zHK7dA8lPPdfK/Uev5DaoDwAwguO7OYTnsWgqRXXwqgmDup7ALhWUmcSH70iBp5kO9NhsR4TE/mOTyBD/2w9Ays/tkGYbQTf/sU9g+TPGjDLMN/yygcDOn+vXp5AbtBPkmvfjHnny2XAM93a1DZamIZRctt24LkWpp1njlHjayHyUVJMTJ+S9Red0VpEUpdO5iJKcA22IaAyQSHmn3ZJn6xD4rqMB/4pDpcICeTyQaLWnPoHknLZ83h0GQxuMJS8Kk25rPfeYTbcYYZ9Uudk5zNQ5vfFJNVbuOuT/OkD9FSv8EpZbEFglAwp0MfwcEFgHVOFmfMzii1+tSmLtm7+gE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(56012099003)(22082099003)(18002099003)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4gC0OXlu8f8Q0t5pApXEDPwQX1TIWhRQOriucHMCP1H2lM6wmJ8G+XgckP?= =?iso-8859-1?Q?xyx/MYFUQKfdAfYTUQM8M4TBt61zHNNPQJ+8UgPHhQMl/2yjOVvczbfxpT?= =?iso-8859-1?Q?kCTEiNgfKVoIb0NnoF+7ib4Kk5LMXMg3ylL5Mct4Tf0n8pvCbDcRJvws10?= =?iso-8859-1?Q?LvKE565PTamW8h8XmeBWMdG4tU+/BoheTHKXi0ITQuFVRKZiFjLI9QG0a+?= =?iso-8859-1?Q?U9Am4qqBsFgOUGYRcqMzffbZy8uDx05jue+0xSseWC7CQWeLOpW8U6BQb7?= =?iso-8859-1?Q?dhjHOBgI9yHeRGV+tamWUH3pb9IntFnwgO3IQZwC6yp9tmQ/6wg5Vtq38T?= =?iso-8859-1?Q?gQN1WXzem+KGqFfNl6Jeti16qc7o/2weNcY8vLzqvRsnNwOkgstxoayTqE?= =?iso-8859-1?Q?OB5RuMVK51rtxCBQHi5h0P8IQBcryatE2X7sAeqYuTMn5d3mRvatwdftBu?= =?iso-8859-1?Q?owheqdh5T/S3W4C2/E/WEyf3IBofeAwV7tA4OHB4NwkzeFMpyU7t+h3IxR?= =?iso-8859-1?Q?bVeWMyqTecjsudIPFvugkISTo/wBXwnphPAju1soT8NB/rQwafvfvpnnJ1?= =?iso-8859-1?Q?GqAEvJ/shHBdLsE5idgWwwWDEPKpVpjjSrF+NJK1M4YXWchrPjoSauXv8A?= =?iso-8859-1?Q?139+hZ8XAoaSKqo6NTDleQp0Q6pOzeCmudV57MW1I9EToEcDJ+ow3dujVA?= =?iso-8859-1?Q?vwHQbV3vUncR8/CdivhtQB6yj8/v6t7lrFpRC2MNo0V/FSXyn5vP/nL49Y?= =?iso-8859-1?Q?JVA679tq/f2PSVfpahNeg2GDsMtcK5cYiAGLQsSNiEtkigf0wifFbN0xVN?= =?iso-8859-1?Q?w0OoAqFF0vctuk1QmyC9NZMPetQnMKQLfIoDexSkDcl/gwkymxsB+/1ly1?= =?iso-8859-1?Q?w9jwUyqwFeNwVargrKppZScbHq6sNVkObIHgK5r1vrxU5Gf5kQt/3Go00F?= =?iso-8859-1?Q?4nwRA+EtEhnQSmvLPG6YYC9QAhCs7lQzXcy8lFv6wMBrpA8rqbgD5TfKTm?= =?iso-8859-1?Q?TzUYHxCNWd6GwNMibtpOVUrrF25ML+qgmTgunJvNOZKqeOEhS5gQLAbVIf?= =?iso-8859-1?Q?pd1JiBRcevHtw8QPDihioY+RwG37EyE3rg/xxxab9Y2febxGW7EFUfCKNK?= =?iso-8859-1?Q?/mdbBhn5oBr547IL+meoj9fY5FyIKZr5+JDimUgWhwmVE5DeEFLE9FbrIZ?= =?iso-8859-1?Q?2TNCcQd0O/eZyPwWeacAUnRRJSJNQ956tI4Om8ZglvrgKTc6q1/pjjTPTN?= =?iso-8859-1?Q?fsmTpXmz9VVobQDcbBhbVznqvblf9tHYuF76IcF9VQmxX+sEeLnKbKCazZ?= =?iso-8859-1?Q?pzlqIku28yqAtKTTrTwRI/UxBRV5oHr9QB7opc/DaRP0Va7CqGWO8Mp+Vs?= =?iso-8859-1?Q?05lkS9jFQdkr67MX45TOxTxfPNZdwSlK9Ufz03son70sj8Oli44yfhgTPK?= =?iso-8859-1?Q?rIOKIpy9S9NETktktKyxvHErtxIZ6JcBUKFRRI+QfACJrODOqGQ7D+fvDL?= =?iso-8859-1?Q?Hysq1rxyHv3cy1p5Wh9bqoUQuUNg69gfHX0Mcu/U6fPTiltqkCVCqoMJL2?= =?iso-8859-1?Q?hfFoFk3NJOGwJ0867JWYF1djGYysQ8Vc/mSIaWvoXV2J+2nKJchlNu5Ubz?= =?iso-8859-1?Q?MZgj91Xxrb38N0OBT0g+f7jBarVmDlBbX55iT2gCQuuJyLkf16rPL6imkP?= =?iso-8859-1?Q?M99/m37CUxob2L2AF3TtMoeoln/YHYSs9wDpaUxEfkW9i9fpbGF6kKxFa6?= =?iso-8859-1?Q?OrhuYoqBrXCzAeUhDqVnnIJGyYveZYuEkV0z19yGcTwKS0CaQnhVdUEHkY?= =?iso-8859-1?Q?n3ZugIj/1w=3D=3D?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Bc+lVOmuMiQymo9CpwUq5XKBrCxOg9HOF7NNMnx2aormbzdfGDdfzWnO5dU/9hsQ5uyt6l2xWwsc3gOKA00kRKP66IekLzyKOMsGMxc1JvpFRSUm/ZkC4nzGw1Bs0wOpUI3eagXLKYQgCqD1oUBgNHfGj0auXr0HycVLNf1NHeQ2cr3bj8mOA1UqvdE0YfXrVo+uBuADr9BuHF5cD3dsuh4ehWM+fi3tLu4hXJyYanW9A+UX81sFrKistd+GF6bJiPNS5uV8pykSkYQQTbmR+5XsczXJDdjDAihyWw1hiIWsGRB2O+K3fa5jEOqJOALeeJ8mpNmKgKtCIa/rREDzHw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 115fc983-9e79-4304-bd1e-08de8db5feac X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2026 17:09:53.4275 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +Tb4SVPeVyhFRQIDQmQ5F9jpgk//DVqoKXS66IA4XRoblbqHyM43kci2QBHIaW0UqW0/GKcpdx0vdfOMLqTzRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR84MB1992 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=G5IR0tk5 c=1 sm=1 tr=0 ts=69c95ce8 cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=k7r4yCLl9DVLXMiQTbtC:22 a=OUXY8nFuAAAA:8 a=cPYzWk29AAAA:8 a=utbyc8ruBblTlh3aM0cA:9 a=wPNLvfGTeEIA:10 a=zZCYzV9kfG8A:10 a=cAcMbU7R10T-QSRYIcO_:22 a=oSR2DF9YFqZEN4IGatwP:22 X-Proofpoint-ORIG-GUID: OdqyEKAelzaVxmP5nwmJAVij3nkBnrCC X-Proofpoint-GUID: OdqyEKAelzaVxmP5nwmJAVij3nkBnrCC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI5MDEzMyBTYWx0ZWRfX1ZXz16sTEG9p 5YXHh+x0PAk3N8b4SJHFmzc2z8nOpxKqHqLD5KPVRV2fnWp7ADITm6t0VxlaxLj7A2E0E4zb1/b wRFlV8T2/aSw3Y1VyS/DEBN0MMTQmBAwzKGhni7GhJoxrvKsGvBsQtvPIlZ7KDj3uoyfhLRD1Jm 5CsP8w+3PmE+1jka1Qr1rgYiqG59T6wf26bW9BWNH1q8oQbN8GDc/gAi0rRlxBjnVuNAWy/R07n svRGEnP447U8WY2IctKYOURngI73B8BSfHirBMIIFqL1dNgLnXSFcv+Q6pbWo84G1NQdB/uHkPr N27Qphe9ht0YKtbmCSNxruRWboVDhN2XqOOKHlqOtijHIfv9iXknxI+mvELiPAO/s6Gx+0xnXzV vI3HHliUlF5t3aXgVU4H1A71NLoTAFEHcFg1+Uhx0NeO+xPyPKvkyflUue9t/871zVZBZqTyUiN CYpJY8pwV8yFgn+vx+Q== X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_04,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603290133 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan ltc4286.c uses PMBus core symbols exported in the PMBUS namespace, such as pmbus_do_probe(), but does not declare MODULE_IMPORT_NS("PMBUS"). Add the missing namespace import to avoid modpost warnings. Fixes: 0c459759ca97 ("hwmon: (pmbus) Add ltc4286 driver") Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/ltc4286.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwmon/pmbus/ltc4286.c b/drivers/hwmon/pmbus/ltc4286.c index aabd0bcdfeee..8715d380784a 100644 --- a/drivers/hwmon/pmbus/ltc4286.c +++ b/drivers/hwmon/pmbus/ltc4286.c @@ -173,3 +173,4 @@ module_i2c_driver(ltc4286_driver); MODULE_AUTHOR("Delphine CC Chiu "); MODULE_DESCRIPTION("PMBUS driver for LTC4286 and compatibles"); MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("PMBUS"); --=20 2.34.1