From nobody Thu Apr 2 12:19:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E32C361DA2 for ; Sun, 29 Mar 2026 15:54:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774799675; cv=none; b=ICIjYtSUDmOxUka/FKK4TCm/OLqAMm2cOklWET9I1nz1IqbeDeFLZTmKCGkmFfIEW3vOTjO45oauijnC+yTlX91ugvEUaEP3HMkSoqSmv2lrZz41M5b8kpM/FjPCyGiK6BgQGJSsgZpX+R38E3MboBQxqNs3uj+i7PxyH32E23s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774799675; c=relaxed/simple; bh=PVBKB2SCRXrbvDcEuEYtLcZixSqNmSGPMwEn2xXmndA=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=pmcN/v34BeV2IilTBceopZCXbWo7UhGLh2fdb+7p+O/spHZSkP51DMUExUDT681EIEPJe8eO5aYDgu+6lgiVPdisAuxmK9ZOMDkkNprw3iRKHVgWC2S1ZWZn2q8UjotrkOoMhOSnGUQVRD5fR9DWuy2smMFlH9VcOnVfeMriPlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ESSzj3xw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ESSzj3xw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4188CC2BC9E; Sun, 29 Mar 2026 15:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774799675; bh=PVBKB2SCRXrbvDcEuEYtLcZixSqNmSGPMwEn2xXmndA=; h=Date:From:To:Cc:Subject:References:From; b=ESSzj3xw/OgwxM7KtgyoLFO3Xdcg805KjTZsely56Wu4LUDAWlHwJatgsSrMLt6Ec r1PKZ4C448LyYPsVgiD7m/Jaz/nWh9S9WBWg9PtGlcbjSRBzOdTfuqnjli209cPJ23 fGaBVLutm5Rc0u/F/Ly+idUJx1VVtaBeQTGLWE4rPRDzzMGPDHoARyNTrHU8BV9hs9 5+eNangJLtpcAvf94K+fwXfoactgeYdNVcYnNMgaS0DO6L0bhTu5cRU3cYmcwFXfCq UU9KnoQlqZN2sSAQLrQQEFLXRWuMDLU3T4Mwx0tlAfEt0iZ7Ci/FovkenaeHdSz03x i6tXcSzyWqvbA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w6sU5-0000000Fqsr-0Ugj; Sun, 29 Mar 2026 11:55:29 -0400 Message-ID: <20260329155528.976183997@kernel.org> User-Agent: quilt/0.69 Date: Sun, 29 Mar 2026 11:55:13 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Mark Brown Subject: [for-next][PATCH 1/3] tracing: Remove tracing_alloc_snapshot() when snapshot isnt defined References: <20260329155512.926671150@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The function tracing_alloc_snapshot() is only used between trace.c and trace_snapshot.c. When snapshot isn't configured, it's not used at all. The stub function was defined as a global with no users and no prototype causing build issues. Remove the function when snapshot isn't configured as nothing is calling it. Also remove the EXPORT_SYMBOL_GPL() that was associated with it as it's not used outside of the tracing subsystem which also includes any modules. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260328101946.2c4ef4a5@robin Reported-by: Mark Brown Closes: https://lore.kernel.org/all/acb-IuZ4vDkwwQLW@sirena.co.uk/ Fixes: bade44fe546212 (tracing: Move snapshot code out of trace.c and into = trace_snapshot.c) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 850f62032fd2..7b9dd6378849 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -810,19 +810,12 @@ int tracing_alloc_snapshot(void) =20 return ret; } -EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); #else void tracing_snapshot(void) { WARN_ONCE(1, "Snapshot feature not enabled, but internal snapshot used"); } EXPORT_SYMBOL_GPL(tracing_snapshot); -int tracing_alloc_snapshot(void) -{ - WARN_ONCE(1, "Snapshot feature not enabled, but snapshot allocation used"= ); - return -ENODEV; -} -EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); void tracing_snapshot_alloc(void) { /* Give warning */ --=20 2.51.0