From nobody Thu Apr 2 12:22:45 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A74946C for ; Sun, 29 Mar 2026 07:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774769979; cv=none; b=sPup/JF8rwTu3JHHWMU/fwbZBWAU3PU31YY2X/OkbbCjfPyA8MXptOwuSOpr1kvmhBW5y3gZ9AG8G3Vaa91XaJUyeUkYsAq9rbqO0CVKasj5hvRWwMfI/Va0p4MnUTihvKz3PD0UNCkbz4mnKp/c+pXmykkhFRQc+m82ILRuUrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774769979; c=relaxed/simple; bh=rt4SneNogbv+fBP7qYmNDkcdZNGKAHKhbMLD1UJV2oc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LVZ+lBHBldgWOYTL2lkg3ajP5iK5wH39i6aeuIt4jFpPMKy5bgmw1VFR4lutqYv4NYW8k2lmDK4KE9cTvnIKTviHDOuYfm0KtpRt6VBpUpM5eVtD51FeVu7oiZDmI3o44FmFBdv7IlT5jjPDzXT+v0sfiPj/GBtng9A9Y8mS31c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-05 (Coremail) with SMTP id zQCowADHVAgx18hpuMXNCw--.16447S2; Sun, 29 Mar 2026 15:39:30 +0800 (CST) From: Pengpeng Hou To: arnd@arndb.de, gregkh@linuxfoundation.org, James.Bottomley@HansenPartnership.com Cc: linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH v2] enclosure: bound sysfs link name construction Date: Sun, 29 Mar 2026 15:39:28 +0800 Message-ID: <20260329073928.22257-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260329030943.28672-1-pengpeng@iscas.ac.cn> References: <20260329030943.28672-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowADHVAgx18hpuMXNCw--.16447S2 X-Coremail-Antispam: 1UD129KBjvJXoW7urW5ZF43Xr1DJFyrKFW7Arb_yoW8Wr45pa yfua4UuryUua1kWa1UZanrWFy5X3WUJw4UG3s8C345CrnxZrW0ka4DA3W5Wrn5tFZ7Aa12 qa13t345u3W7Zw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkK14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWx JwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7VUjO6pD UUUUU== X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" enclosure_link_name() prefixes the component device name with "enclosure_device:" in a fixed 64-byte stack buffer. The helper currently uses strcpy() and strcat() with no remaining-space check. enclosure_component_alloc() stores component names in a 64-byte buffer and then uses dev_set_name() on that result, so dev_name(&cdev->cdev) can already reach 63 characters. Prefixing that with the 17-byte "enclosure_device:" string overflows the 64-byte link-name buffer. Use snprintf() so link-name construction stays within ENCLOSURE_NAME_SIZE without changing the existing callers. Fixes: cb6b7f40630f ("[SCSI] ses: fix up functionality after class_device->= device conversion") Signed-off-by: Pengpeng Hou --- v2: - wrap the changelog at 72 columns - keep the fix to bounded link-name construction only drivers/misc/enclosure.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index cf6382981777..de457378c501 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -184,8 +184,8 @@ EXPORT_SYMBOL_GPL(enclosure_unregister); =20 static void enclosure_link_name(struct enclosure_component *cdev, char *na= me) { - strcpy(name, "enclosure_device:"); - strcat(name, dev_name(&cdev->cdev)); + snprintf(name, ENCLOSURE_NAME_SIZE, "enclosure_device:%s", + dev_name(&cdev->cdev)); } =20 static void enclosure_remove_links(struct enclosure_component *cdev) --=20 2.50.1 (Apple Git-155)