From nobody Thu Apr 2 12:35:21 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97FC40DFD3 for ; Sun, 29 Mar 2026 07:06:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768018; cv=none; b=WsQYuTMlSK8lJ6jrMyNdBdvO/VvRVL1KNBrJZTDA1gZbjBSKBC2VXNZMRahIiHfUp0zu2mJACDrDD0+7Ea4skH8O+T1opqdJBT9AjK7fbeH/s7DoZ5XolR6q8dsu0DBR64UDODP6tlw6kwJppQ1SWtGD7E0h8HiPzDi5zrcL08E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768018; c=relaxed/simple; bh=TIUrJlohH7zzcX5wL9kNLLx0H8njEDL4nmQhrrq1NaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WcMP4GWNTlrtTwmDtzEG2uQWZUuuScDxy77UU9jwRQCFUmhFru9wfmTWo4SlqdMZ9ah7GIqfiA0O9TGek0GbtZQvx2MV2WnRXFX0Qvb2MUz9oRp12Gb4BjuaeKQTWilLmG3D4vn6Ti1tLTspnWeVhAnyD+euQ1yZVzUA1lFUN04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pto9I7//; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pto9I7//" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82a62714fe6so1364928b3a.0 for ; Sun, 29 Mar 2026 00:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774768017; x=1775372817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X/Kc/rqS3O8FcnFqoMXkBJLowbwjhPQjCnPmNyfgP7g=; b=pto9I7//0Fy0MFrQuTUG1Tq5FFy40rNEJsps0hcS6WkkbPs90mtmYJTUyklAg5XQ4h CR1h+P/3TKSCmhoNQ/dPnEdyLDvf2eTge4FnTrlll01MqgnB1AmREnQrg/RApb7T4PhG SYKIMKzRHX7DYEQzAE7BCDdg+dU+Sd/LGSA8mW9CkUi6JB7fXIVrHR7N5cgqrZabuTZC c2GJJK0SID8GOy2UN2lZ9W/bSI8Ihv+zCTvOpM/7UM9GLLD62Of9Mqljy2RmoI4Lm0Yd F4gYDgI+7qmkPFMZX4VsICPytF7oSugRHUDgVB9chBTM7vLPGW/ki5uY0qJpA0BWgcWx WhoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774768017; x=1775372817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X/Kc/rqS3O8FcnFqoMXkBJLowbwjhPQjCnPmNyfgP7g=; b=KVVgpO7ePYa3VC7dpQmVp0ultRa2eVVSrohXrjxCgW+uRqFy6fLc5mzues3XEy3uCi G62oW5L0UYOqLekHHRhzt90LtZMfEPSdaeaUEIubMyzK+i8vQ9ye9LPM/0vD5azqNicD 1CkWFmWu4lhRPMfI/ket6FR3yF2DzfMJGC+Y6a+F86h28ZKlFN0+EcgNKJJpxj6L31Gk GUXOrMJke1ywtCGFu1949p5FE5+zwsixnyqDU6tcmRMvKKypqT9Ju8kWEJmKmp+pB0QE Hjpj+L66zZBUe1jlHuFTQ8SGaq/BJVeNLVFcn1LYuvui8pgbS268cM2Z0EPRyBSk8zCG iQxg== X-Forwarded-Encrypted: i=1; AJvYcCXDsT9PSn19gKFzFuQyNryqyf/tdmr8kvLQju2N6JPKjJPo9A+6iMRo7Y5/Y5yXEqVXj2SVU9lCgCS7OW4=@vger.kernel.org X-Gm-Message-State: AOJu0YxJXt5jOi1sATNyCXlhHr87G0MdYy1BdDlBGilgRroyBqSUHcZH qpmNygYnuwqojL2ovMWqJB7fCcGAb/iywXpPOqnL7JkYFebkNTEzlaXB X-Gm-Gg: ATEYQzwGNbt1TeoSk0bNrAtLN8CghJ8s7jEdrrnFKT/BZDQvi8Rw3fsWVTcUQXnI7CJ Qwm2dLXt2lI3hMA3wjSnNMPrJsZUCVS4XkfZ0y3VKczvjw+WKj75r9HWp2mK+E9SW3Z3q7gb2cY 7+kivp6c51S+fD9CcG9vmou3J/B1uUchbp4igclRKkdOX/fKzPOJOBnrkTxHxeAPo4rWPMGrs0u +Oxl3dGTUDDHTTfUuaG4Nmd7JhYXBo8b1n1xqhvMuUkr/tf85b0SCRlxs8XRny/4vkRB+WfwYk+ XaAo1hNQRAEp9wymSv5d7ToQkCkz4I4IVZcBc1y+ySClpluYMdURVxIXWEsofNXD9Q3xTSLgl27 GFBCxSy10LonT/fp81jQ40TMVO61UikhXJNoYEXwv1XNrAMQOTifoH96O0c7NJa8Rq7tI/g+H96 wWcNqr/vO13cRpZ6EhXlpWO2tcedMQc2ijltEHOH5xNeI= X-Received: by 2002:a05:6a00:22cc:b0:827:2d7b:5038 with SMTP id d2e1a72fcca58-82c86326de8mr9740481b3a.5.1774768016837; Sun, 29 Mar 2026 00:06:56 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8437441sm3911640b3a.3.2026.03.29.00.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 00:06:56 -0700 (PDT) From: aravindanilraj0702@gmail.com To: rafael@kernel.org Cc: daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v2 1/2] thermal: intel: int340x: Fix potential shift overflow in ptc_mmio_write Date: Sun, 29 Mar 2026 03:06:41 -0400 Message-ID: <20260329070642.10721-2-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260329070642.10721-1-aravindanilraj0702@gmail.com> References: <20260329070642.10721-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The value parameter is u32 but is shifted into a u64 register value without casting first. If the shift amount pushes bits beyond 32, they are lost. Cast value to u64 before shifting to ensure all bits are preserved. Signed-off-by: Aravind Anilraj --- .../intel/int340x_thermal/platform_temperature_control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/platform_temperature_con= trol.c b/drivers/thermal/intel/int340x_thermal/platform_temperature_control= .c index 0ccc72c93499..18ac5014d8dc 100644 --- a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c +++ b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c @@ -138,7 +138,7 @@ static void ptc_mmio_write(struct pci_dev *pdev, u32 of= fset, int index, u32 valu =20 reg_val =3D readq((void __iomem *) (proc_priv->mmio_base + offset)); reg_val &=3D ~mask; - reg_val |=3D (value << ptc_mmio_regs[index].shift); + reg_val |=3D ((u64)value << ptc_mmio_regs[index].shift); writeq(reg_val, (void __iomem *) (proc_priv->mmio_base + offset)); } =20 --=20 2.47.3 From nobody Thu Apr 2 12:35:21 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE4E040DFD3 for ; Sun, 29 Mar 2026 07:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768023; cv=none; b=hTE4ugMwKilT7KHPQa6F3+SBaufWSkUeDVTdJfRb/ezRXoVg1bOnqTeYD2/JK3stnejh0PYhP2XSCL3Ju+GVcwapAS23bjXO3CfudEqnD/spJPJrY4yv0NZboFLBtJ/qkz+fD6w0mWWfoS9FivKmLXJ7oJuChRhoA0hdiA6q90c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774768023; c=relaxed/simple; bh=El5UGz6rKlunrw+bvxZSz+QJrugKhpwdFMLjMHXMgzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nv5r99VdMqDqD8JagT3bInq0U2ikYmHw+xy+QeC6W3ziVx6gWOcySwnrZxAQsWHKVWIo/qA9+XU0Cs38OVY9gO/jYYH883cWQ1Wmfxo1te8t5gE7Jm0IXu6XgNr6wqP7BxFl+YFVBSvAydSzt5Bv56qvh+o4MKx630EdO7WNxkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EpA++fTb; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EpA++fTb" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c742d4df00cso1751117a12.1 for ; Sun, 29 Mar 2026 00:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774768021; x=1775372821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5/it1c9Kax7yLBHD1HmPRV0TNRw4DIg5tr0zA922iag=; b=EpA++fTbV21UJh8PZWTeQhnFB1kVLR4Negaz9qxJ3ZV8+q/stIDVUl201OY1x7CRcQ 9N4n43Foo57IiOuCRap3m/FgoUuk4TFQJ0YuiSxgsXJejyQgkGMY1yeKpKxflUKlLOR1 lpLLLad7wmCKY0qaFlrzX9JUVjMlEzYNzKy1aARB4YjKsztqDgP3SZn4anQCSAYCwbsv g+ZCJ6crrn38y5muOftqHhKmxX+DonyTF/miXmcqZoRTDKzvNKJlaP+ajpdI8auDf6tg cN3CGuoR2v7U9RzKBGwkLGmAWdDJhAdJM//NaAtxyCvR0sY5+e3h/oz3K+zPDVDjUx0X +jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774768021; x=1775372821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5/it1c9Kax7yLBHD1HmPRV0TNRw4DIg5tr0zA922iag=; b=X9zbIs/LMZxjVhIG1sQFy2jGIKVwn32T7lE00IjMygKvL5JjHj7GRCFekmrx88BPhK gS/rcxUOKDDY03t25pWS7Ml7bVojuzem3Q0z8ZZDfb0K8t57nHpe7UeS4XIBCZ8AuYD8 J9COuj/vTROZetJdCZceLCNSEz4p3hCuttOlADxEdGHQkPj9VF3Xo0lmgsruOo9r9FCG nQ8dzgLl3KVMynbLcJbLbqeNGaj6T3n6tROluTl4Sp60+FB9/qu/Jy6nxGiRFqT/Izof IYS9D7ptnAFCc1nRH93S3GpgZDjt5Z9Izt4A+jdmTNZSoKQnoNGUUGwIE9U1qoSl56y/ aAPg== X-Forwarded-Encrypted: i=1; AJvYcCVuxth1RcJGPSpcgJ8a7UOA1CV6kiVLfyhCTHnXqBzHLYXas18iSpZDZm2n2Z7DvTLga2i2tu3fyEFA4zw=@vger.kernel.org X-Gm-Message-State: AOJu0YxK3Meg02SoCNKXDz9ohcOHLULh4ss1Q3IHjaZE3SRqwo+AL+h4 z3WlcL7pdu5ML7rcpQLxPJaH8/5NQHFVnqoQokIXP3VDpKZH+Grnax5u X-Gm-Gg: ATEYQzxh3bviCZK9st5VK/oKUW5YXhXGPc4o14wnoruTa9SELCxrFeHib+46/fOVfun IawlHJHo9OWWdkME/x34vFaPUYzzfTV9paHaOcwiTezQ+cMjF6FqGDZ9TVxnhuAFaroZH8oLaFS GxYkkL+IMIIVVEWOTZx4dzR9h8fMWsi1qwZrvjr57ULGyfl4ZYkFbuWHrd9Izvo75IGmDIMgQoa zP5MLXzc67e7iT8WgcTla6PaFTp3hOOxEN+IjBKMLqtJiu5lX0AHBDgA+dcX8k8SWWnZKEG8VRm APQjEbdzpVAhBkKjDV/9xpkbnSqylff599NnYaLeg3vu50dTEW5DeN6MCQSP1vY1LorggxlqiJ8 NwSEf3RvGSnVhUQrs89/9BIcwqt94fJA9M+Kpoq597o8hKBoj3sD+k/1SBiHMtOB1olmzWsfc9E 9A20XotmbTCQUhokZEkvsceihnFDGKCd76ZUTo4PF/B9o= X-Received: by 2002:a05:6a00:a809:b0:829:7a62:6a with SMTP id d2e1a72fcca58-82c969c171amr7304542b3a.22.1774768021086; Sun, 29 Mar 2026 00:07:01 -0700 (PDT) Received: from debian.killsync.com ([103.85.207.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8437441sm3911640b3a.3.2026.03.29.00.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 00:07:00 -0700 (PDT) From: aravindanilraj0702@gmail.com To: rafael@kernel.org Cc: daniel.lezcano@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, srinivas.pandruvada@linux.intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v2 2/2] thermal: intel: int340x: Check return value of ptc_create_groups() Date: Sun, 29 Mar 2026 03:06:42 -0400 Message-ID: <20260329070642.10721-3-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260329070642.10721-1-aravindanilraj0702@gmail.com> References: <20260329070642.10721-1-aravindanilraj0702@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj proc_thermal_ptc_add() ignores the return value of ptc_create_groups(), causing the driver to silenty continue even if sysfs group creation fails. The thermal control interface would be unavailable with no indication of failure. Check the return value and on failure clean up any sysfs groups that were successfully created before the error, then propagate the error to the caller which already handles it correctly via goto err_rem_rapl. Signed-off-by: Aravind Anilraj --- .../int340x_thermal/platform_temperature_control.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/intel/int340x_thermal/platform_temperature_con= trol.c b/drivers/thermal/intel/int340x_thermal/platform_temperature_control= .c index 18ac5014d8dc..d92a6f84a778 100644 --- a/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c +++ b/drivers/thermal/intel/int340x_thermal/platform_temperature_control.c @@ -278,12 +278,18 @@ static void ptc_delete_debugfs(void) int proc_thermal_ptc_add(struct pci_dev *pdev, struct proc_thermal_device = *proc_priv) { if (proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_PTC) { - int i; + int i, ret; =20 for (i =3D 0; i < PTC_MAX_INSTANCES; i++) { ptc_instance[i].offset =3D ptc_offsets[i]; ptc_instance[i].pdev =3D pdev; - ptc_create_groups(pdev, i, &ptc_instance[i]); + ret =3D ptc_create_groups(pdev, i, &ptc_instance[i]); + if (ret) { + while (i--) + sysfs_remove_group(&pdev->dev.kobj, + &ptc_instance[i].ptc_attr_group); + return ret; + } } =20 ptc_create_debugfs(); --=20 2.47.3