From nobody Thu Apr 2 12:31:15 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D4F72571A0 for ; Sun, 29 Mar 2026 03:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753801; cv=none; b=T+C7uBq5iP/XDnbwQCuOFqIB5IAhsAUI15kWeS+jTyv3muJfHujiOSLkuda4bfFvvLvU+0C0AgabEfG0yfR0uQemiDeACiYB8nimoBrssrS+WPgk8NFav/NcXgSRErZTxTnf50LDY+dH7YLrC8RVQnDBg/caEDvEZvpcTX/nyoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753801; c=relaxed/simple; bh=iqUd7zrWgCWY+d/icqZ+nB0MLHcR7yodtGhizfQZ1m0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GfNvBlIh7v8UN4MvtlBJYU1Ne7L5t8FjrxoLKsM62B1M0yfoVy/e3v5bDfTyuG4xipwjPNzi7L7Ji1juIQ1MKUUOwBx332nwz+vo9n2ef54v/6hv2JOq2OyYKNIAbEW7MCxis6vbbMkexAn5vVD5IVvzypKx1Oz788Asf3mYJ3E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-01 (Coremail) with SMTP id qwCowADnkGz9l8hptud8Cw--.32606S2; Sun, 29 Mar 2026 11:09:50 +0800 (CST) From: Pengpeng Hou To: eajames@linux.ibm.com, ninad@linux.ibm.com, joel@jms.id.au Cc: linux@roeck-us.net, andrew@aj.id.au, benh@kernel.crashing.org, linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] fsi: occ: bound SRAM write payload length Date: Sun, 29 Mar 2026 11:09:49 +0800 Message-ID: <20260329030949.32485-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowADnkGz9l8hptud8Cw--.32606S2 X-Coremail-Antispam: 1UD129KBjvJXoW7ury8KF18Gw45KrWUuw4UArb_yoW8GF15pF y5KayjvrnxJF4Sqw18tw15WayrK3Z7uFy2gFZrZas3Zrs5GF1xuFyDGFyI93W7trnrAryf K39FkFn8WayDAFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkE14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1q6rW5McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v2 6r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j 6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUDOz 3UUUUU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" occ_putsram() rounds the requested SRAM write length up to an eight-byte boundary and then copies that payload into occ->buffer without checking whether the rounded length still fits behind the OCC/SBE command header. Reject payloads that would overrun the fixed response buffer instead of copying past the end of occ->buffer. Fixes: 7ed98dddb764 ("fsi: Add On-Chip Controller (OCC) driver") Signed-off-by: Pengpeng Hou --- drivers/fsi/fsi-occ.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c index 416d176f0936..f52cf539bbda 100644 --- a/drivers/fsi/fsi-occ.c +++ b/drivers/fsi/fsi-occ.c @@ -315,6 +315,7 @@ static int occ_putsram(struct occ *occ, const void *dat= a, ssize_t len, u8 seq_no, u16 checksum) { u32 data_len =3D ((len + 7) / 8) * 8; /* must be multiples of 8 B */ + size_t max_data_len; size_t cmd_len, parsed_len, resp_data_len; size_t resp_len =3D OCC_MAX_RESP_WORDS; __be32 *buf =3D occ->buffer; @@ -345,6 +346,11 @@ static int occ_putsram(struct occ *occ, const void *da= ta, ssize_t len, break; } =20 + max_data_len =3D OCC_MAX_RESP_WORDS * sizeof(*buf); + max_data_len -=3D (5 + idx) * sizeof(*buf); + if (data_len > max_data_len) + return -EINVAL; + buf[4 + idx] =3D cpu_to_be32(data_len); memcpy(&buf[5 + idx], data, len); =20 --=20 2.50.1 (Apple Git-155)