From nobody Thu Apr 2 12:36:50 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2651972617 for ; Sun, 29 Mar 2026 03:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753799; cv=none; b=YM2cFt200mftnOcw6CfxxcW4Q43VLgmtwwJar2KW3zv0LaAkN+Fcwd/CYTFOOd5qr/VnPI2Pa+yOYG+OEsZAIRBpTBJc+5d1cTwhEpGFZpgDQyIX9sZpGdbym2WTjZWJ9eZjEwZN8HkF43ip/sbJyJmHJtbegVT7rYohniQzs2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774753799; c=relaxed/simple; bh=RGLV6V6niwwV9QIq/V5T24uWZfOTI/VtFevKcwc6PDM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=E5Ri2x8qrUys7DpPh3+By+1s8jYZI1wZkPSoyF83sDZvAr2K4yD92B/cNvZdxCbp/ir1nmZOk2k8e5zrCzJ071+ilslSSB8BpGfk3VUexK9M390W2mD5anAyzbBPgI/pS3YcK+vfWZmn7EwSWJbPaiWlU6t8ICACTBjlu6ixpUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-01 (Coremail) with SMTP id qwCowAC3YGz3l8hpfOd8Cw--.9254S2; Sun, 29 Mar 2026 11:09:43 +0800 (CST) From: Pengpeng Hou To: arnd@arndb.de, gregkh@linuxfoundation.org, James.Bottomley@HansenPartnership.com Cc: linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] enclosure: bound sysfs link name construction Date: Sun, 29 Mar 2026 11:09:43 +0800 Message-ID: <20260329030943.28672-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAC3YGz3l8hpfOd8Cw--.9254S2 X-Coremail-Antispam: 1UD129KBjvJXoW7urW5ZF4fZr47JF4kKrW7urg_yoW8uFy3pa yUWF98Wr1Uua17W3WUZayDWa45Za1kJw47G3s0kws3Aw4xZrWkGF1jka45Wrn8tF97Aa17 Ja13Jry5u3W7Ww7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkC14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67 AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIY rxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14 v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8 JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUYNVyDU UUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" enclosure_link_name() prefixes the component device name with "enclosure_de= vice:" in a fixed 64-byte stack buffer. The helper currently uses strcpy() = and strcat() with no remaining-space check even though the component device= name itself can approach the same length. Switch the helper to bounded formatting and propagate an error when the pre= fixed link name does not fit. Fixes: cb6b7f40630f ("[SCSI] ses: fix up functionality after class_device->= device conversion") Signed-off-by: Pengpeng Hou --- drivers/misc/enclosure.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/misc/enclosure.c b/drivers/misc/enclosure.c index cf6382981777..f09707ca02e8 100644 --- a/drivers/misc/enclosure.c +++ b/drivers/misc/enclosure.c @@ -182,17 +182,21 @@ EXPORT_SYMBOL_GPL(enclosure_unregister); #define ENCLOSURE_NAME_SIZE 64 #define COMPONENT_NAME_SIZE 64 =20 -static void enclosure_link_name(struct enclosure_component *cdev, char *na= me) +static int enclosure_link_name(struct enclosure_component *cdev, char *nam= e) { - strcpy(name, "enclosure_device:"); - strcat(name, dev_name(&cdev->cdev)); + if (snprintf(name, ENCLOSURE_NAME_SIZE, "enclosure_device:%s", + dev_name(&cdev->cdev)) >=3D ENCLOSURE_NAME_SIZE) + return -EINVAL; + + return 0; } =20 static void enclosure_remove_links(struct enclosure_component *cdev) { char name[ENCLOSURE_NAME_SIZE]; =20 - enclosure_link_name(cdev, name); + if (enclosure_link_name(cdev, name)) + return; =20 /* * In odd circumstances, like multipath devices, something else may @@ -214,7 +218,12 @@ static int enclosure_add_links(struct enclosure_compon= ent *cdev) if (error) return error; =20 - enclosure_link_name(cdev, name); + error =3D enclosure_link_name(cdev, name); + if (error) { + sysfs_remove_link(&cdev->cdev.kobj, "device"); + return error; + } + error =3D sysfs_create_link(&cdev->dev->kobj, &cdev->cdev.kobj, name); if (error) sysfs_remove_link(&cdev->cdev.kobj, "device"); --=20 2.50.1 (Apple Git-155)